Re: [PATCH v3 0/5] add feature arc in rte_graph

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:59:57 +0530 Nitin Saxena wrote: > Feature arc represents an ordered list of features/protocols at a given > networking layer. It is a high level abstraction to connect various > rte_graph nodes, as feature nodes, and allow packets steering across > these nodes in a generic m

Re: [PATCH 0/4] net/mlx5: series to fix and improve tx trace capabilities

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 14:40:24 +0300 Viacheslav Ovsiienko wrote: > There is a series of weakly dependent patches related to the tx trace > in mlx5 PMD: > - fix issue in the trace dump Python script > - update the real-time clock reading routine, make it atomic >and move its initialization to t

Re: [PATCH v6 1/7] event/dlb2: include headers for vector and memory copy APIs

2024-10-09 Thread Stephen Hemminger
On Fri, 20 Sep 2024 12:27:10 +0200 Mattias Rönnblom wrote: > The DLB2 PMD depended on being included as a side-effect > of being included. > > In addition, DLB2 used rte_memcpy() but did not include , > but rather depended on other include files to do so. > > This patch addresses both of thos

Re: [PATCH] doc: update TAP device features

2024-10-09 Thread Stephen Hemminger
On Sun, 6 Oct 2024 21:36:31 +0100 Ferruh Yigit wrote: > On 10/4/2024 9:48 PM, Stephen Hemminger wrote: > > On Fri, 4 Oct 2024 02:48:21 +0100 > > Ferruh Yigit wrote: > > > >>> +Stats per queue = Y > >>> > >> > >> This feature name is misleading, > >> it is for 'rte_eth_dev_set_[rt]x_q

Re: [PATCH v2] fib: network byte order IPv4 lookup

2024-10-09 Thread Stephen Hemminger
On Tue, 8 Oct 2024 17:16:05 + Vladimir Medvedkin wrote: > Previously when running rte_fib_lookup IPv4 addresses must have been in > host byte order. > > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on > fib create, which will allow to have IPv4 in network byte order

Re: [PATCH v4 2/2] ip_frag: updated name for IP frag define

2024-10-09 Thread Stephen Hemminger
On Mon, 8 Jan 2024 11:36:14 + Euan Bourke wrote: > diff --git a/config/rte_config.h b/config/rte_config.h > index da265d7dd2..e2fa2a58fa 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -85,7 +85,7 @@ > #define RTE_RAWDEV_MAX_DEVS 64 > > /* ip_fragmentation defines */

RE: [PATCH v7 1/7] eal: add static per-lcore memory allocation facility

2024-10-09 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 18 September 2024 10.26 > > Introduce DPDK per-lcore id variables, or lcore variables for short. > > An lcore variable has one value for every current and future lcore > id-equipped thread. > > The primary use ca

Re: [RFC] app/testpmd: use RSS conf from software when configuring DCB

2024-10-09 Thread Stephen Hemminger
On Wed, 12 Apr 2023 17:52:39 +0800 Min Zhou wrote: > In the testpmd command, we have to stop the port firstly before configuring > the DCB. However, some PMDs may execute a hardware reset during the port > stop, such as ixgbe. Some kind of reset operations of PMD could clear the > configurations

Re: [PATCH v6 2/2] dts: mac filter test suite refactored for new dts

2024-10-09 Thread Patrick Robb
Thanks Nick this looks (almost) ready to be applied to next-dts. Other than a little disconnect between your series and Dean's Patch-145500 ("dts: add VLAN methods to testpmd shell") series which I will flag below, I think this looks good. On Tue, Oct 8, 2024 at 4:45 PM Nicholas Pratte wrote: >

RE: [PATCH] examples/l2fwd-macsec: enable extended packet number

2024-10-09 Thread Akhil Goyal
> -Original Message- > From: Akhil Goyal > Sent: Monday, September 16, 2024 4:57 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; Vamsi Krishna > Attunuru ; Akhil Goyal > Subject: [PATCH] examples/l2fwd-macsec: enable extended packet number > > Enabled the e

RE: [PATCH v2] examples/ipsec-secgw: fix dequeue count from cryptodev

2024-10-09 Thread Akhil Goyal
> > Subject: [PATCH v2] examples/ipsec-secgw: fix dequeue count from cryptodev > > > > Setting dequeue packet count to max of MAX_PKT_BURST > > size instead of MAX_PKTS. > > > > Dequeue from cryptodev is called with MAX_PKTS but > > routing functions allocate hop/dst_ip arrays of > > size MAX_PKT_B

RE: [PATCH v2 06/10] baseband/acc: remove soft output bypass

2024-10-09 Thread Chautru, Nicolas
Hi Maxime, There is no formal support for VRB2 yet, this is ongoing and we will formally enable this only in DPDK 24.11. So we don’t believe this commit below is truly a `fix` required to be applied on stable branch. Ie. DPDK 23.11 will not support VRB2 anyway. Still Hernan will put the fix

Re: [RFC PATCH] build: automatically report minimum meson version

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 16:24:01 +0100 Bruce Richardson wrote: > Add a script to buildtools to report the minimum meson version given in > our meson.build file. Then use this script in two ways: > > 1. in the .ci/linux-setup.sh script, use the auto-determined minimum >version to set up the CI, r

RE: [PATCH v2 1/2] fib: implement RCU rule reclamation

2024-10-09 Thread Doug Foster
The check for NULL is not necessary before calling rte_rcu_qsbr_dq_delete. Similar to other free routines, an error will not occur when the dq pointer is NULL. However, it will give a debug log statement to indicate an invalid parameter and return 0 to indicate success. -Original Message---

Re: [PATCH v2] doc: reword sample app guides

2024-10-09 Thread Stephen Hemminger
On Sun, 6 Oct 2024 16:45:17 -0700 Nandini Persad wrote: > I have reviewed these sections for grammar/clarity > and made small modifications to the formatting of sections > to adhere to a template which will create uniformality > in the sample application user guides overall. > > Signed-off-by:

RE: [PATCH v2 2/2] cryptodev: move RSA padding information into xform

2024-10-09 Thread Kusztal, ArkadiuszX
Acked-by: Arek Kusztal > -Original Message- > From: Akhil Goyal > Sent: Wednesday, October 9, 2024 5:23 PM > To: Gowrishankar Muthukrishnan ; > dev@dpdk.org; Kusztal, ArkadiuszX ; Fan Zhang > ; Anoob Joseph ; Ankur > Dwivedi ; Tejasree Kondoj ; > Ji, Kai ; Dooley, Brian > Cc: Richardson

Re: [PATCH 0/5] Increase minimum meson version

2024-10-09 Thread Patrick Robb
Hi Min Zhou, I think it makes sense for you to set your meson version to the minimum version supported for DPDK (so, .57 now I suppose) instead of .63. The principle that David described above regarding LTS is also true for main. So, for the main and next-* branch testing that Loongson lab does, w

[PATCH 2/5] net/ice: improve Tx scheduler graph output

2024-10-09 Thread Bruce Richardson
The function to dump the TX scheduler topology only adds to the chart nodes connected to TX queues or for the flow director VSI. Change the function to work recursively from the root node and thereby include all scheduler nodes, whether in use or not, in the dump. Also, improve the output of the T

[PATCH 5/5] net/ice: limit the number of queues to sched capabilities

2024-10-09 Thread Bruce Richardson
Rather than assuming that each VSI can hold up to 256 queue pairs, or the reported device limit, query the available nodes in the scheduler tree to check that we are not overflowing the limit for number of child scheduling nodes at each level. Do this by multiplying max_children for each level beyo

[PATCH 1/5] net/ice: detect stopping a flow-director queue twice

2024-10-09 Thread Bruce Richardson
If the flow-director queue is stopped at some point during the running of an application, the shutdown procedure for the port issues an error as it tries to stop the queue a second time, and fails to do so. We can eliminate this error by setting the tail-register pointer to NULL on stop, and checki

RE: [EXTERNAL] [PATCH v5 3/4] crypto/qat: add sm2 encryption/decryption function

2024-10-09 Thread Akhil Goyal
> This commit adds SM2 elliptic curve based asymmetric > encryption and decryption to the Intel QuickAssist > Technology PMD. > > Signed-off-by: Arkadiusz Kusztal > --- > doc/guides/cryptodevs/features/qat.ini | 1 + > doc/guides/rel_notes/release_24_11.rst | 4 + > drivers

RE: [PATCH v7 3/7] eal: add lcore variable performance test

2024-10-09 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 18 September 2024 10.26 A few corrections to a comment. Besides that, Acked-by: Morten Brørup > +/* > + * The potential performance benefit of lcore variables compared to > + * the use of statically sized, lcore

RE: [EXTERNAL] [PATCH v5 2/4] cryptodev: add ec points to sm2 op

2024-10-09 Thread Akhil Goyal
> In the case when PMD cannot support the full process of the SM2, > but elliptic curve computation only, additional fields > are needed to handle such a case. > > Points C1, kP therefore were added to the SM2 crypto operation struct. > > Signed-off-by: Arkadiusz Kusztal > --- > lib/cryptodev/r

RE: [PATCH v6 1/7] event/dlb2: include headers for vector and memory copy APIs

2024-10-09 Thread Morten Brørup
Acked-by: Morten Brørup

RE: [PATCH v6 2/7] net/octeon_ep: add missing vector API header include

2024-10-09 Thread Morten Brørup
Acked-by: Morten Brørup

RE: [PATCH v6 4/7] fib: add missing vector API header include

2024-10-09 Thread Morten Brørup
Acked-by: Morten Brørup

RE: [PATCH v6 3/7] distributor: add missing vector API header include

2024-10-09 Thread Morten Brørup
Acked-by: Morten Brørup

RE: [EXTERNAL] [v2] crypto/dpaa2_sec: rework debug code

2024-10-09 Thread Akhil Goyal
Hi Gagan, > Output debug information according to various modes. > > Signed-off-by: Jun Yang > Signed-off-by: Gagandeep Singh It seems the base patch was merged in main branch. Can you rebase this patch on current top of tree? > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 72

RE: [EXTERNAL] [PATCH v5 1/4] cryptodev: reorder structures in asym crypto header

2024-10-09 Thread Akhil Goyal
> Asymmetric-crypto header has a simple structure that allows to > keep logically separate blocks together. Therefore, xforms, > ops, and generic structs may be appropriately ordered. > This patch moves sm2-op structs to be placed along other > algorithms-op structs. > > Signed-off-by: Arkadiusz K

RE: [PATCH v6 6/7] ci: test compiler memcpy

2024-10-09 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Friday, 20 September 2024 12.27 > +if [ "$CCMEMCPY" = "true" ]; then > + OPTS="$OPTS -Duse_cc_memcpy=true" > +else > + OPTS="$OPTS -Duse_cc_memcpy=true" > +fi With the bug (only testing true) found by David fixed, Ac

Re: [v5 15/15] bus/dpaa: add port bmi stats

2024-10-09 Thread Stephen Hemminger
On Tue, 8 Oct 2024 16:28:10 +0530 Gagandeep Singh wrote: > From: Hemant Agrawal > > Add BMI statistics and fixing the existing extended > statistics > > Signed-off-by: Hemant Agrawal > Signed-off-by: Gagandeep Singh > --- This patch is failing build, Fedora has a more recent Gcc with more

Re: [PATCH v2] net/mvneta: fix possible out-of-bounds write

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 06:08:45 + Chengwen Feng wrote: > The mvneta_ifnames_get() function will save 'iface' value to ifnames, > it will out-of-bounds write if passed many iface pairs (e.g. > 'iface=xxx,iface=xxx,...'). > > Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton") > Cc: sta...@dpdk.o

RE: [PATCH v4 1/2] ipsec: allow stateless IPsec processing

2024-10-09 Thread Konstantin Ananyev
> Introduce stateless packet preparation API for IPsec > processing. The new API would allow preparation of IPsec > packets without altering the internal state of an IPsec > session. > > For outbound IPsec processing, the change enables user to > provide sequence number to be used for the IPsec

Re: [PATCH 2/5] net/ice: improve Tx scheduler graph output

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:08:19 +0100 Bruce Richardson wrote: > The function to dump the TX scheduler topology only adds to the chart > nodes connected to TX queues or for the flow director VSI. Change the > function to work recursively from the root node and thereby include all > scheduler nodes, w

Re: [PATCH 3/5] net/ice: add option to choose DDP package file

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:08:20 +0100 Bruce Richardson wrote: > The "Dynamic Device Personalization" package is loaded at initialization > time by the driver, but the specific package file loaded depends upon > what package file is found first by searching through a hard-coded list > of firmware pat

Re: [PATCH 5/5] net/ice: limit the number of queues to sched capabilities

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:08:22 +0100 Bruce Richardson wrote: > Rather than assuming that each VSI can hold up to 256 queue pairs, > or the reported device limit, query the available nodes in the scheduler > tree to check that we are not overflowing the limit for number of > child scheduling nodes a

Re: [PATCH 4/5] net/ice: add option to download scheduler topology

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:08:21 +0100 Bruce Richardson wrote: > diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h > index 2781362d04..76310f2c99 100644 > --- a/drivers/net/ice/ice_ethdev.h > +++ b/drivers/net/ice/ice_ethdev.h > @@ -564,6 +564,7 @@ struct ice_devargs { >

Re: [PATCH 1/5] net/ice: detect stopping a flow-director queue twice

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 18:08:18 +0100 Bruce Richardson wrote: > If the flow-director queue is stopped at some point during the running > of an application, the shutdown procedure for the port issues an error > as it tries to stop the queue a second time, and fails to do so. We can > eliminate this e

Re: [PATCH v13 4/4] eal: add PMU support to tracing library

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 14:50:02 +0200 Morten Brørup wrote: > > From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > > Sent: Wednesday, 9 October 2024 13.23 > > > > +PMU tracepoint > > +-- > > + > > +Performance monitoring unit (PMU) event values can be read from > > hardware > > +reg

RE: [EXTERNAL] Re: [PATCH v3 1/9] drivers/raw: introduce cnxk rvu lf device driver

2024-10-09 Thread Akhil Goyal
> On Wed, 9 Oct 2024 00:19:07 +0530 > Akhil Goyal wrote: > > > CNXK product families can have a use case to allow PF and VF > > applications to communicate using mailboxes and also get notified > > of any interrupt that may occur on the device. > > Hence, a new raw device driver is added for such

RE: [PATCH v4 1/2] ipsec: allow stateless IPsec processing

2024-10-09 Thread Akhil Goyal
> > > > Introduce stateless packet preparation API for IPsec > > processing. The new API would allow preparation of IPsec > > packets without altering the internal state of an IPsec > > session. > > > > For outbound IPsec processing, the change enables user to > > provide sequence number to be us

Re: [PATCH v12 0/7] Improve EAL bit operations API

2024-10-09 Thread David Marchand
On Fri, Sep 20, 2024 at 12:57 PM Mattias Rönnblom wrote: > > This patch set represent an attempt to improve and extend the RTE > bitops API, in particular for functions that operate on individual > bits. > > All new functionality is exposed to the user as generic selection > macros, delegating the

RE: [RFC 0/4] ethdev: rework config restore

2024-10-09 Thread Dariusz Sosnowski
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 9, 2024 03:08 > To: Konstantin Ananyev ; Dariusz Sosnowski > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Andrew Rybchenko > Cc: dev@dpdk.org; Bruce Richardson > Subject: Re: [RFC 0/4] ethdev: rework config restore > >

[PATCH v2] maintainers: update for dts

2024-10-09 Thread Patrick Robb
Paul and Patrick have been appointed as the new dts maintainers. Updating the MAINTAINERS file to reflect this. Signed-off-by: Patrick Robb Signed-off-by: Paul Szczepanek --- v2: added updated for Tree section MAINTAINERS | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

RE: rte_ring move head question for machines with relaxed MO (arm/ppc)

2024-10-09 Thread Wathsala Wathawana Vithanage
> > > > > > 1. rte_ring_generic_pvt.h: > > > > = > > > > > > > > pseudo-c-code //related > > > > armv8 instructions > > > > > > > > ---

[PATCH v3 01/12] baseband/acc: fix access to deallocated mem

2024-10-09 Thread Hernan Vargas
Prevent op_addr access during queue_stop operation, as this memory may have been deallocated. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 36 --

[PATCH v3 00/12] acc baseband PMD fix and updates for 24.11

2024-10-09 Thread Hernan Vargas
This series targets 24.11. v3: Updated code with community recommendations. Added 2 commits for rte_free refactor and clean up of VRB1 capabilities. v2: Rebased to the latest next-baseband-for-main which includes needed rte_bbdev lib updates. v1: It includes a memory access fix, refactoring of qu

[PATCH v3 03/12] baseband/acc: queue allocation refactor

2024-10-09 Thread Hernan Vargas
Refactor to manage queue memory per operation more flexibly for VRB devices. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/acc_common.h | 5 + drivers/baseband/acc/rte_vrb_pmd.c | 214 - 2 files changed, 157 insertions(+), 62 deletions(-) diff --git a/driv

[PATCH v3 04/12] baseband/acc: configure max queues per device

2024-10-09 Thread Hernan Vargas
Configure max_queues based on the number of queue groups and numbers of AQS per device variant. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_

[PATCH v3 02/12] baseband/acc: fix soft output bypass RM

2024-10-09 Thread Hernan Vargas
Removing soft output bypass RM capability due to VRB2 device limitations. Fixes: b49fe052f9cd ("baseband/acc: add FEC capabilities for VRB2 variant") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_vrb_pmd.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions

[PATCH v3 06/12] baseband/acc: enhance SW ring alignment

2024-10-09 Thread Hernan Vargas
Calculate the aligned total size required for queue rings, ensuring that the size is a power of two for proper memory allocation. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/acc_common.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/acc

[PATCH v3 05/12] baseband/acc: future proof structure comparison

2024-10-09 Thread Hernan Vargas
Some implementation in the PMD is based on some size assumption from the bbdev structure, which should use sizeof instead to be more future proof in case these structures change. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 4 ++-- 1 file cha

RE: [EXTERNAL] [PATCH v8 6/8] lib/cryptodev: add sm4 xts for crypto

2024-10-09 Thread Akhil Goyal
> Title should be cryptodev: add SM4-XTS > > > add support of sm4 xts . > > > > Signed-off-by: Hanxiao Li > > Send this patch (along with test cases) as a separate patchset "not included > in this > series." > > Update documentation doc/guides/cryptodevs/features/defaults.ini > Update release

RE: [EXTERNAL] Re: [PATCH v2] rawdev: add API to get device from index

2024-10-09 Thread Akhil Goyal
> > > diff --git a/lib/rawdev/rte_rawdev_pmd.h b/lib/rawdev/rte_rawdev_pmd.h > > > index 22b406444d..8339122348 100644 > > > --- a/lib/rawdev/rte_rawdev_pmd.h > > > +++ b/lib/rawdev/rte_rawdev_pmd.h > > > @@ -102,6 +102,30 @@ rte_rawdev_pmd_get_named_dev(const char > *name) > > > return NUL

[PATCH v3 11/12] baseband/acc: rte free refactor

2024-10-09 Thread Hernan Vargas
Refactor to explicitly set pointer to NULL after free to avoid double free. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 23 +++-- drivers/baseband/acc/rte_vrb_pmd.c| 48 +++ 2 files changed, 39 insertions(+), 32 deletions(-) diff

[PATCH v3 10/12] baseband/acc: cosmetic changes

2024-10-09 Thread Hernan Vargas
Cosmetic code changes. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 2 +- drivers/baseband/acc/rte_vrb_pmd.c| 54 +-- 2 files changed, 36 insertions(+), 20 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pm

[PATCH v3 09/12] baseband/acc: reset ring data valid bit

2024-10-09 Thread Hernan Vargas
Reset only the valid bit to keep info ring data notably for dumping. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rt

[PATCH v3 12/12] baseband/acc: clean up of VRB1 capabilities

2024-10-09 Thread Hernan Vargas
The interrupt support was defeatured on the VRB1 device. Signed-off-by: Hernan Vargas --- doc/guides/bbdevs/vrb1.rst | 3 --- drivers/baseband/acc/rte_vrb_pmd.c | 8 ++-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/doc/guides/bbdevs/vrb1.rst b/doc/guides/bbdevs/vrb

[PATCH v3 08/12] baseband/acc: remove check on HARQ memory

2024-10-09 Thread Hernan Vargas
Automatically reset HARQ memory to prevent errors and simplify usage. In a way we can assume that the HARQ output operation will always overwrite the buffer, so we can reset this from the driver to prevent an error being reported when application fails to do this explicitly. Signed-off-by: Hernan

[PATCH v3 07/12] baseband/acc: algorithm tuning for LDPC decoder

2024-10-09 Thread Hernan Vargas
Reverting to MS1 version of the algorithm to improve MU1 fading conditions. Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_vrb_pmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/ba

RE: [PATCH v6 7/7] vhost: optimize memcpy routines when cc memcpy is used

2024-10-09 Thread Morten Brørup
> +#if defined(RTE_USE_CC_MEMCPY) && defined(RTE_ARCH_X86_64) > +static __rte_always_inline void > +pktcpy(void *restrict in_dst, const void *restrict in_src, size_t len) > +{ A comment describing why batch_copy_elem.dst and src point to 16 byte aligned data would be nice. > + void *dst = __

Re: [EXTERNAL] Re: [PATCH v6 0/2] devtools: add tracepoint check in checkpatch

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 06:03:58 + Ankur Dwivedi wrote: > >> Please let me know if this patch series can be merged in DPDK or if there > >> are > >any comments. > > > >Not sure why the patch got ignored. > >Perhaps if check-tracepoint was run first against existing code; add to > >check- > >pa

[PATCH 4/5] net/ice: add option to download scheduler topology

2024-10-09 Thread Bruce Richardson
The DDP package file being loaded at init time may contain an alternative Tx Scheduler topology in it. Add driver option to load this topology at init time. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/ice_ddp.c | 18 +++--- drivers/net/ice/base/ice_ddp.h | 4 ++-- drive

[PATCH 3/5] net/ice: add option to choose DDP package file

2024-10-09 Thread Bruce Richardson
The "Dynamic Device Personalization" package is loaded at initialization time by the driver, but the specific package file loaded depends upon what package file is found first by searching through a hard-coded list of firmware paths. To enable greater control over the package loading, we can add a

[PATCH 0/5] updates for net/ice driver

2024-10-09 Thread Bruce Richardson
This patchset contains a set of updates for the ice driver, a number of which are in the area of the "rte_tm" APIs for Tx scheduling. These patches were previously submitted as part of a larger set[1], but separating them out here for easier review and merge ahead of the more substantial changes f

RE: [PATCH v3 1/3] cryptodev: add asymmetric operational capability

2024-10-09 Thread Akhil Goyal
> Subject: [PATCH v3 1/3] cryptodev: add asymmetric operational capability > > Asymmetric crypto algorithms such as SM2, EdDSA would need per op > capability and based on it, the input param to a crypto operation > is chosen wisely. > > Signed-off-by: Gowrishankar Muthukrishnan > --- > v3: > -

RE: [PATCH 4/6] eal: add unit tests for atomic bitset operations

2024-10-09 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 12 September 2024 06.52 > > On Fri, Aug 09, 2024 at 10:14:38PM +0200, Mattias R??nnblom wrote: > > Extend bitset tests to cover the basic operation of the > > rte_bitset_atomic_*() family of functions. > > > > Signed-of

Re: [PATCH v3 5/5] net/cxgbe: use rte macro instead of GCC attribute

2024-10-09 Thread David Marchand
On Wed, Mar 6, 2024 at 11:14 PM Tyler Retzlaff wrote: > > Use existing __rte_may_alias macro from rte_common.h instead of > directly using __attribute__((__may_alias__)). > > Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Reviewed-by: Potnuri Bharat Teja Applied, thanks. -- David

[DPDK/core Bug 1385] rt_bitops.h fails to give implied atomicity guarantees

2024-10-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1385 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED A

RE: [PATCH] cryptodev: remove unnecessary list end

2024-10-09 Thread Akhil Goyal
> > From: Akhil Goyal [mailto:gak...@marvell.com] > > Sent: Wednesday, 9 October 2024 13.25 > > > > RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END and > > RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END are not used anywhere and > > mostly it do not fulfil any objective. > > Rather it does not allow addition of new algo

RE: [PATCH v1] examples/ipsec-secgw: free the actual mbuf pointer

2024-10-09 Thread Akhil Goyal
> Subject: [PATCH v1] examples/ipsec-secgw: free the actual mbuf pointer > > In case of crypto event vector, the vector points to crypto op structure > in priv area and not actual mbuf. > Extract the mbuf pointer and pass these to rte_mbuf_free to free the > mbufs. > > Signed-off-by: Vidya Sagar

Re: [PATCH v4 0/6] refine argparse library

2024-10-09 Thread Stephen Hemminger
On Mon, 18 Mar 2024 11:18:32 + Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argp

RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm

2024-10-09 Thread Akhil Goyal
> > Subject: RE: [PATCH v6 1/6] cryptodev: add EDDSA asymmetric crypto algorithm > > > > > Acked-by: Arkadiusz Kusztal Series Applied to dpdk-next-crypto Thanks. Updated release notes and removed deprecation notices for EDDSA.

RE: [PATCH v2 2/2] cryptodev: move RSA padding information into xform

2024-10-09 Thread Akhil Goyal
> Acked-by: Arek Kusztal > Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto Updated release notes and removed associated deprecation notices. Thanks.

RE: [EXTERNAL] Re: [PATCH v1] Revert "doc: extension of crypto event callback announced"

2024-10-09 Thread Akhil Goyal
> On Thu, 1 Aug 2024 13:06:07 +0530 > Srujana Challa wrote: > > > The previously planned update to the `rte_cryptodev_cb_fn` function > > prototype is being reverted. The introduction of the > > `rte_cryptodev_queue_pair_event_error_query` API provides a means for > > applications to retrieve the

Re: [PATCH v1 1/3] uapi: introduce kernel uAPI headers import

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 10:58:03 +0200 Maxime Coquelin wrote: > +fixup_includes() > +{ > + local path=$1 > + > + sed -i -E -e ' > + s/([[:space:](])(__user|__force|__iomem)[[:space:]]/\1/g > + s/__attribute_const__([[:space:]]|$)/\1/g > + s@^#include @@ > + > s/(^|[^a-zA-Z0-9

RE: [PATCH v3 1/3] crypto/ipsec_mb: add SM3 algorithm support

2024-10-09 Thread Akhil Goyal
> > -Original Message- > > From: Dooley, Brian > > Sent: Thursday, October 3, 2024 6:05 PM > > To: Ji, Kai ; De Lara Guarch, Pablo > > > > Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian > > > > Subject: [PATCH v3 1/3] crypto/ipsec_mb: add SM3 algorithm support > > > > This patch int

RE: [PATCH v2 2/2] cryptodev: move RSA padding information into xform

2024-10-09 Thread Akhil Goyal
Hi Arek Any objections on this patch? > Subject: [PATCH v2 2/2] cryptodev: move RSA padding information into xform > > RSA padding information could be a xform entity rather than part of > crypto op, as it seems associated with hashing algorithm used for > the entire crypto session, where this al

[RFC PATCH] build: automatically report minimum meson version

2024-10-09 Thread Bruce Richardson
Add a script to buildtools to report the minimum meson version given in our meson.build file. Then use this script in two ways: 1. in the .ci/linux-setup.sh script, use the auto-determined minimum version to set up the CI, rather than hard-coding it. 2. in meson.build call the script to report

RE: [PATCH v4 1/2] ipsec: allow stateless IPsec processing

2024-10-09 Thread Akhil Goyal
Hi Konstantin, Can you ack this patch if everything is fine? > Subject: [PATCH v4 1/2] ipsec: allow stateless IPsec processing > > Introduce stateless packet preparation API for IPsec > processing. The new API would allow preparation of IPsec > packets without altering the internal state of an I

RE: [PATCH] test/security: skip IPsec post process for negative tests

2024-10-09 Thread Akhil Goyal
> Subject: [PATCH] test/security: skip IPsec post process for negative tests > > Skips calling test_ipsec_post_process for negative inline IPsec tests > as received packet might not be valid for a negative case. > > Signed-off-by: Srujana Challa Acked-by: Akhil Goyal Applied to dpdk-next-crypt

Re: [PATCH] bus/pci: don't open uio device in secondary process

2024-10-09 Thread Stephen Hemminger
On Wed, 9 Oct 2024 12:11:32 +0200 Konrad Sztyber wrote: > On 10/7/24 19:49, Stephen Hemminger wrote: > > On Wed, 28 Aug 2024 12:40:02 +0200 > > Konrad Sztyber wrote: > > > >> The uio_pci_generic driver clears the bus master bit when the device > >> file is closed. So, when the secondary proc

Re: [PATCH] doc: enhance the global log level documentation

2024-10-09 Thread Stephen Hemminger
On Wed, 26 Jun 2024 19:10:48 +0200 Ilya Maximets wrote: > On 6/26/24 17:09, David Marchand wrote: > > The current documentation is non intuitive in that the global log level > > can be understood as being a single knob controlling all components > > logs. > > On the contrary, all the global log l

Re: [PATCH v2 0/4] cfgfile: enhance error detecting

2024-10-09 Thread Stephen Hemminger
On Fri, 5 Jul 2024 09:31:11 + Chengwen Feng wrote: > When I was trying to debug a problem introduced by config.ini in > test-dma-perf, I found the cfgfile library should enhance error > detecting, so got this patchset. > > Chengwen Feng (4): > cfgfile: remove dead code > cfgfile: support

Re: [PATCH v6 0/2] Mac Filter Port to New DTS

2024-10-09 Thread Patrick Robb
Series-reviewed-by: Patrick Robb

Re: [PATCH v6 1/2] dts: add methods for setting mac and multicast addresses

2024-10-09 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v6 1/2] dts: add methods for setting mac and multicast addresses

2024-10-09 Thread Patrick Robb
Actually, I do have one thought. On Tue, Oct 8, 2024 at 4:45 PM Nicholas Pratte wrote: > +def set_mac_addr(self, port_id: int, mac_address: str, add: bool, > verify: bool = True) -> None: > +"""Add or remove a mac address on a given port's Allowlist. > + > +Args: > +

Re: [PATCH] net/mvpp2: fix build by removing newlines in logs

2024-10-09 Thread Thomas Monjalon
09/10/2024 11:18, Thomas Monjalon: > After using RTE_LOG_LINE_PREFIX in MRVL_LOG macro, > an assert was detecting some newlines in logs. > After removing these superfluous newlines, the compilation passes. > > Fixes: 2b843cac232e ("drivers: use per line logging in helpers") > > Signed-off-by: Tho

RE: [EXTERNAL] [PATCH v2] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-09 Thread Akhil Goyal
> AESNI_MB SW PMDs increment Intel IPsec MB version to 1.4. > A minimum IPsec Multi-buffer version of 1.4 or greater is now required > for the 24.11 LTS release. > > Signed-off-by: Brian Dooley > Acked-by: Kai Ji > Acked-by: Pablo de Lara > --- > This patch relates to a deprecation notice sent

Re: [PATCH] bus/pci: don't open uio device in secondary process

2024-10-09 Thread Konrad Sztyber
On 10/7/24 19:49, Stephen Hemminger wrote: On Wed, 28 Aug 2024 12:40:02 +0200 Konrad Sztyber wrote: The uio_pci_generic driver clears the bus master bit when the device file is closed. So, when the secondary process terminates after probing a device, that device becomes unusable in the primar

RE: [PATCH v2 0/2] cryptodev: add queue pair priority

2024-10-09 Thread Akhil Goyal
> Subject: [PATCH v2 0/2] cryptodev: add queue pair priority > > Changes in v2: > - added release notes and removed deprecation notice. > - removed gerrit-id > > Akhil Goyal (2): > cryptodev: add queue pair priority > app/crypto-perf: test queue pair priority > > app/test-crypto-perf/cperf_

Re: [PATCH] cryptodev: remove unnecessary list end

2024-10-09 Thread Hemant Agrawal
On 09-10-2024 16:54, Akhil Goyal wrote: RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END and RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END are not used anywhere and mostly it do not fulfil any objective. Rather it does not allow addition of new algorithms and new padding type as it result in ABI breakage. Hence, the

[PATCH v5 4/4] app/test: add test sm2 C1/Kp test cases

2024-10-09 Thread Arkadiusz Kusztal
This commit adds tests cases to be used when C1 or kP elliptic curve points need to be computed. Signed-off-by: Arkadiusz Kusztal --- app/test/test_cryptodev_asym.c | 138 - app/test/test_cryptodev_sm2_test_vectors.h | 112 ++- 2 files

[PATCH v5 2/4] cryptodev: add ec points to sm2 op

2024-10-09 Thread Arkadiusz Kusztal
In the case when PMD cannot support the full process of the SM2, but elliptic curve computation only, additional fields are needed to handle such a case. Points C1, kP therefore were added to the SM2 crypto operation struct. Signed-off-by: Arkadiusz Kusztal --- lib/cryptodev/rte_crypto_asym.h |

[PATCH v5 3/4] crypto/qat: add sm2 encryption/decryption function

2024-10-09 Thread Arkadiusz Kusztal
This commit adds SM2 elliptic curve based asymmetric encryption and decryption to the Intel QuickAssist Technology PMD. Signed-off-by: Arkadiusz Kusztal --- doc/guides/cryptodevs/features/qat.ini | 1 + doc/guides/rel_notes/release_24_11.rst | 4 + drivers/common/qat/qat_ad

RE: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-09 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 9, 2024 3:03 AM > To: Kusztal, ArkadiuszX ; Marchand, David > > Cc: dev@dpdk.org; Ji, Kai ; Dooley, Brian > > Subject: Re: [PATCH v2 1/3] net: add thread-safe crc api > > On 10/8/2024 9:51 PM, Kusztal, ArkadiuszX wro

Re: [PATCH] Increasing ci meson version to .57

2024-10-09 Thread David Marchand
On Wed, Oct 9, 2024 at 5:43 AM Stephen Hemminger wrote: > > On Tue, 8 Oct 2024 15:25:43 -0400 > Patrick Robb wrote: > > > There is a proposed increase in the minimum meson version to .57 > > This patch aligns the linux setup ci script with this change. > > > > Signed-off-by: Patrick Robb > > I

[PATCH v3 1/5] graph: add feature arc support

2024-10-09 Thread Nitin Saxena
add feature arc to allow dynamic steering of packets across graph nodes based on protocol features enabled on incoming or outgoing interface Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24_11.rst | 10 + lib/graph/graph_feature_arc.c| 1223 ++

[PATCH v3 2/5] graph: add feature arc option in graph create

2024-10-09 Thread Nitin Saxena
Added option in graph create to call feature-specific process node functions. This removes extra overhead for checking feature arc status in nodes where application is not using feature arc processing Signed-off-by: Pavan Nikhilesh Signed-off-by: Nitin Saxena --- doc/guides/rel_notes/release_24

[PATCH v3 0/5] add feature arc in rte_graph

2024-10-09 Thread Nitin Saxena
Feature arc represents an ordered list of features/protocols at a given networking layer. It is a high level abstraction to connect various rte_graph nodes, as feature nodes, and allow packets steering across these nodes in a generic manner. Features (or feature nodes) are nodes which handles part

  1   2   3   >