[PATCH v8 7/9] net/zxdh: add configure zxdh intr implementation

2024-10-30 Thread Junlong Wang
configure zxdh intr include risc,dtb. and release intr. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 300 + drivers/net/zxdh/zxdh_ethdev.h | 8 + drivers/net/zxdh/zxdh_msg.c| 188 + drivers/net/zxdh/zxdh_msg.h| 13

[PATCH v8 0/9] net/zxdh: introduce net zxdh driver

2024-10-30 Thread Junlong Wang
v8: - fix flexible arrays銆乄address-of-packed-member error. - all structs銆乪num銆乨efine ,etc use zxdh/ZXDH_ prefixed. - use zxdh_try/release_lock,and move loop into zxdh_timedlock, make hardware lock follow spinlock pattern. v7: - add release notes and modify zxdh.rst issues. - avoid us

Re: [PATCH] bus/vmbus: remove unnecessary packed attribute

2024-10-30 Thread David Marchand
On Tue, Oct 22, 2024 at 4:37 AM Stephen Hemminger wrote: > > The VMBus ring structure was marked packed which will cause > warnings if the no-address-of-packed is enabled. The structure > is all 32 bit values and the packed attribute has no impact > on the code layout; remove it. > > Signed-off-by

Re: [PATCH v4] common/cnxk: allow enabling IOVA field in mbuf

2024-10-30 Thread Jerin Jacob
On Mon, Oct 28, 2024 at 3:13 PM Shijith Thotton wrote: > > The value of RTE_IOVA_IN_MBUF has always been disabled on CNXK > platforms, as IOVA in the mbuf is unnecessary. This update changes that > behavior to respect the value set by the user. A warning message will be > printed if the build is c

Re: [PATCH] testpmd: add hairpin-map parameter

2024-10-30 Thread Etelson, Gregory
Hello Stephen, +static __rte_always_inline +char *parse_hairpin_map_entry(char *input, char **next) +{ + char *tail = strchr(input, ':'); + + if (!tail) + return NULL; + tail[0] = '\0'; + *next = tail + 1; + return input; +} + There is no reason to mark this as

Re: [PATCH v1] net/macb: add new driver

2024-10-30 Thread Bruce Richardson
On Wed, Oct 30, 2024 at 09:53:29AM +, liwencheng wrote: > add Phytium NIC MACB ethdev PMD driver. > > Signed-off-by: liwencheng > --- > drivers/net/macb/base/generic_phy.c | 276 + > drivers/net/macb/base/generic_phy.h | 198 > drivers/net/macb/base/macb_common.c | 667

Re: [PATCH v2 0/6] Clean up many __builtin_* in drivers.

2024-10-30 Thread David Marchand
On Fri, Oct 25, 2024 at 9:04 AM David Marchand wrote: > > Here is a series cleaning up most of uses of __builtin_* helpers in > drivers when they have a direct replacement in EAL. > > checkpatch is extended to forbid new additions. > > -- > David Marchand > > Changes since v1: > - more fixes in cr

Re: [PATCH] app/dumpcap: replace use of __builtin_clzl

2024-10-30 Thread David Marchand
On Wed, Oct 16, 2024 at 10:52 PM Stephen Hemminger wrote: > > DPDK applications should avoid direct use of compiler builtin. > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") > > Signed-off-by: Stephen Hemminger Applied, thanks. -- David Marchand

Re: [PATCH v3 0/3] Import Kernel uAPI header files

2024-10-30 Thread David Marchand
On Tue, Oct 29, 2024 at 3:42 PM David Marchand wrote: > > On Mon, Oct 28, 2024 at 4:48 PM Maxime Coquelin > wrote: > > > > This series enables importing Linux Kernel uAPI headers > > into the DPDK repository. It aims at solving alignment > > issues between the build system and the system applicat

[PATCH 2/4] net/nfp: extract function to check physical reprsentor

2024-10-30 Thread Chaoyong He
Extract a helper function to check the physical representor port. Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c| 18 -- .../net/nfp/flower/nfp_flower_representor.h| 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/

[PATCH 1/4] net/nfp: fix port index problem

2024-10-30 Thread Chaoyong He
Fix one port index problem imported by mistake. Fixes: 97b6825d9a7b ("net/nfp: extract function to allocate PHY") Fixes: fd1ec7bc8f0a ("net/nfp: extract function to initialize PF") Fixes: bb9f9fdcbe00 ("net/nfp: extract function to allocate PF") Fixes: c8e29c168c20 ("net/nfp: extract function to a

[PATCH 4/4] net/nfp: add support for port identify

2024-10-30 Thread Chaoyong He
Implement the necessary functions to allow user to visually identify a physical port associated with a netdev by blinking an LED on that port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 30 drivers/net/nfp/nfp_eth

RE: [PATCH V2 3/7] net/mlx5: add new devargs to control probe optimization

2024-10-30 Thread Slava Ovsiienko
Hi, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 29, 2024 6:07 PM > To: Minggang(Gavin) Li > Cc: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; NBU-Contact-Thomas > Monjalon (EXTERNAL) ; Dariusz Sosnowski > ; Bing Zhao ; Suanming Mou > ; dev@dpdk.org; Raslan Dara

[PATCH 2/3] net/nfp: add support for EEPROM functions

2024-10-30 Thread Chaoyong He
Add support for the following EEPROM function callbacks: .get_eeprom_len Get the maximum size of the device EEPROM data. .get_eeprom Get the device EEPROM data at a certain offset and length. .set_eeprom Set the device EEPROM data at a certain offset and length. Note that for an nfp NIC, the "d

[PATCH 0/3] NFP PMD enhancement

2024-10-30 Thread Chaoyong He
This patch series fix one problem imported by mistake and add support of two new APIs. Chaoyong He (3): net/nfp: extract function to check physical reprsentor net/nfp: add support for EEPROM functions net/nfp: add support for port identify .../net/nfp/flower/nfp_flower_representor.c | 12

[PATCH 1/3] net/nfp: extract function to check physical reprsentor

2024-10-30 Thread Chaoyong He
Extract a helper function to check the physical representor port. Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c| 18 -- .../net/nfp/flower/nfp_flower_representor.h| 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/

[PATCH 3/3] net/nfp: add support for port identify

2024-10-30 Thread Chaoyong He
Implement the necessary functions to allow user to visually identify a physical port associated with a netdev by blinking an LED on that port. Signed-off-by: James Hershaw Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 30 drivers/net/nfp/nfp_eth

Re: [PATCH v2 0/6] Reduce scope address-of-packed-member warning

2024-10-30 Thread David Marchand
On Fri, Oct 25, 2024 at 6:51 PM Bruce Richardson wrote: > > The warning for address-of-packed-member was being disabled globally in > DPDK. While for drivers which need to access hardware-defined > data-structures the use of packed may make sense, for normal libs and > applications the use of pac

Re: [PATCH] config/arm: fix warning for native build with meson >= 0.55

2024-10-30 Thread David Marchand
On Mon, Oct 28, 2024 at 2:11 PM David Marchand wrote: > > Caught in UNH logs for native compilation on ARM: > > Program /./dpdk/config/arm/armv8_machine.py found: YES > (/./dpdk/config/arm/armv8_machine.py) > WARNING: Project targeting '>= 0.57' but tried to use feature deprecated

Re: [PATCH V3 7/7] mlx5: add backward compatibility for RDMA monitor

2024-10-30 Thread Minggang(Gavin) Li
On 10/30/2024 12:26 AM, Stephen Hemminger wrote: On Tue, 29 Oct 2024 15:42:56 +0200 "Minggang Li(Gavin)" wrote: +* **Updated NVIDIA mlx5 driver.** + + Optimized port probe in large scale. + This feature enhances the efficiency of probing VF/SFs on a large scale + by significantly reduc

Re: [PATCH v1] config/x86: add lcore support for AMD EPYC Zen5 platforms

2024-10-30 Thread David Marchand
On Mon, Oct 21, 2024 at 12:21 PM Sivaprasad Tummala wrote: > > On x86 platforms, max lcores are limited to 128 by default. > > On AMD EPYC processors, this limit was adjusted for native builds in > the commit acb34af951cf ("config/x86: increase lcores number for native > AMD EPYC") > > As agreed e

[PATCH 0/4] NFP PMD enhancement

2024-10-30 Thread Chaoyong He
This patch series fix one problem imported by mistake and add support of two new APIs. --- v2: * add one missing commit. --- Chaoyong He (4): net/nfp: fix port index problem net/nfp: extract function to check physical reprsentor net/nfp: add support for EEPROM functions net/nfp: add suppo

Re: [PATCH v2] test/bitops: check worker lcore availability

2024-10-30 Thread David Marchand
On Fri, Oct 25, 2024 at 9:39 AM David Marchand wrote: > > Coverity is not able to understand that having 2 lcores means that > rte_get_next_lcore(-1, 0, 1) can't return RTE_MAX_LCORE. > Add a check. > > Coverity issue: 445382, 445383, 445384, 445387, 445389, 445391 > Fixes: 35326b61aecb ("bitops:

[PATCH 3/3] net/mlx5: fix stub for HWS context validation

2024-10-30 Thread Dariusz Sosnowski
Since weak symbols are not supported on MinGW, move mlx5_hw_ctx_validate() to dedicated stubs file. Fixes: f3b76d541a25 ("net/mlx5: validate HWS context in meter operations") Signed-off-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c | 7 --- drivers/net/mlx5/mlx5_flow_hw_s

[PATCH 1/3] net/mlx5: fix mingw stubs link issue in flow creation

2024-10-30 Thread Dariusz Sosnowski
Offending commit used weak symbols to implement stubs for functions for creating control flow rules for MAC address and VLAN matching. Since weak symbols are not supported with MinGW and concrete implementations of these functions are required if and only if PMD is compiled on Linux and DV API is

[PATCH 0/3] net/mlx5: fix mingw link issues

2024-10-30 Thread Dariusz Sosnowski
This patchset fixes link issues with MinGW which appear in next-net-mlx-main tree. It is based on commit 69461d18dfd5 ("net/mlx5/hws: fix TC to TOS fields mapping in NAT64"). Dariusz Sosnowski (3): net/mlx5: fix mingw stubs link issue in flow creation net/mlx5: fix mingw stubs link issue in

[PATCH 2/3] net/mlx5: fix mingw stubs link issue in flow destroy

2024-10-30 Thread Dariusz Sosnowski
Offending commit used weak symbols to implement stubs for functions for destroying control flow rules for MAC address and VLAN matching. Since weak symbols are not supported with MinGW and concrete implementations of these functions are required if and only if PMD is compiled on Linux and DV API i

[PATCH v8 5/9] net/zxdh: add msg chan enable implementation

2024-10-30 Thread Junlong Wang
Add msg chan enable implementation to support send msg to backend(device side) get infos. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 6 + drivers/net/zxdh/zxdh_ethdev.h | 12 + drivers/net/zxdh/zxdh_msg.c| 641 - drivers/net/zxdh/zxdh_

[PATCH v6] testpmd: add hairpin map parameter

2024-10-30 Thread Gregory Etelson
Hairpin offloads packet forwarding between ports. Packet is expected on Rx port , Rx queue and is forwarded to Tx port Tx queue . Testpmd implements a static hairpin configuration scheme. The new parameter allows explicit selection of Rx and Tx ports and queues in hairpin configuration. The new

Re: [PATCH v2 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-30 Thread Bruce Richardson
On Wed, Oct 30, 2024 at 12:21:00PM +0100, David Marchand wrote: > Hello Bruce, > > On Fri, Oct 25, 2024 at 6:51 PM Bruce Richardson > wrote: > > > > There are multiple instances in the DPDK app folder where we set up an > > IP header and then compute the checksum field by direct addition of > > n

RE: [PATCH v1] examples/fips_validation: fix EdDSA signature size

2024-10-30 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Tuesday 29 October 2024 05:59 > To: dev@dpdk.org; Dooley, Brian ; Gowrishankar > Muthukrishnan > Cc: Anoob Joseph ; Akhil Goyal > Subject: [PATCH v1] examples/fips_validation: fix EdDSA signature size > > Fix EdDSA signatur

RE: [PATCH v2 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-30 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 30 October 2024 12.28 > > On Wed, Oct 30, 2024 at 12:21:00PM +0100, David Marchand wrote: > > Hello Bruce, > > > > On Fri, Oct 25, 2024 at 6:51 PM Bruce Richardson > > wrote: > > > > > > There are multiple instances i

[PATCH] graph: fix memory leak in node clone

2024-10-30 Thread pbhagavatula
From: Pavan Nikhilesh Free memory allocated for the node when xstats memory allocation fails. Coverity issue: 445529 Fixes: 070db97e017b ("graph: support node xstats") Signed-off-by: Pavan Nikhilesh --- lib/graph/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/g

Re: [PATCH v2 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-30 Thread David Marchand
Hello Bruce, On Fri, Oct 25, 2024 at 6:51 PM Bruce Richardson wrote: > > There are multiple instances in the DPDK app folder where we set up an > IP header and then compute the checksum field by direct addition of > nine uint16_t values in the header (20 bytes less the cksum field). > The existin

Re: [RFC PATCH v2] net: 2-byte align packed headers

2024-10-30 Thread David Marchand
On Wed, Oct 30, 2024 at 1:35 PM Morten Brørup wrote: > > Recheck-request: iol-unit-amd64-testing It will need some rebase, regardless of the retest. -- David Marchand

RE: [RFC PATCH v2] net: 2-byte align packed headers

2024-10-30 Thread Morten Brørup
Recheck-request: rebase=main, iol-unit-amd64-testing Thanks David.

Re: [PATCH] net: increase the maximum of RX/TX descriptors

2024-10-30 Thread Lukáš Šišmiš
On 29. 10. 24 15:37, Morten Brørup wrote: From: Lukas Sismis [mailto:sis...@cesnet.cz] Sent: Tuesday, 29 October 2024 13.49 Intel PMDs are capped by default to only 4096 RX/TX descriptors. This can be limiting for applications requiring a bigger buffer capabilities. The cap prevented the appli

Re: [PATCH] dumpcap: check return value from adding interface

2024-10-30 Thread David Marchand
On Sun, Oct 27, 2024 at 7:29 PM Stephen Hemminger wrote: > > The rte_pcapng_add_interface could fail. > For example: running out of space for the file. > > Covertity issue: 446742 Coverity* > Signed-off-by: Stephen Hemminger Applied, thanks. -- David Marchand

Re: [PATCH v2 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-30 Thread David Marchand
On Wed, Oct 30, 2024 at 12:32 PM Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Wednesday, 30 October 2024 12.28 > > > > On Wed, Oct 30, 2024 at 12:21:00PM +0100, David Marchand wrote: > > > Hello Bruce, > > > > > > On Fri, Oct 25, 2024 at 6:51 PM

[PATCH] net/hns3: support flow rule priority

2024-10-30 Thread Jie Hai
From: Dengdui Huang The hardware determines the priority of the flow rule based on the position of the rule in the hardware flow director table. Lower index denotes higher priority (it means when a packet matches multiple indexes, the smaller index wins). This patch implements flow priority based

[PATCH v2 2/2] net/ice: increase the maximum of RX/TX descriptors

2024-10-30 Thread Lukas Sismis
Intel PMDs are capped by default to only 4096 RX/TX descriptors. This can be limiting for applications requiring a bigger buffer capabilities. By bufferring more packets with RX/TX descriptors, the applications can better handle the processing peaks. Setting ice max descriptors to 8192 - 32 as per

[PATCH v2] dts: add l2fwd test suite

2024-10-30 Thread Thomas Wilks
Add a basic L2 forwarding test suite which tests the correct functionality of the forwarding facility built-in in the DPDK. The tests are performed with different queues numbers per port. Bugzilla ID: 1481 Signed-off-by: Luca Vizzarro Signed-off-by: Thomas Wilks Reviewed-by: Paul Szczepanek -

RE: [PATCH v1] examples/fips_validation: prehash input for RSA

2024-10-30 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Tuesday 29 October 2024 06:01 > To: dev@dpdk.org; Dooley, Brian ; Gowrishankar > Muthukrishnan > Cc: Anoob Joseph ; Akhil Goyal > Subject: [PATCH v1] examples/fips_validation: prehash input for RSA > > Plain text needs to b

[PATCH v2 1/2] net/ixgbe: increase the maximum of RX/TX descriptors

2024-10-30 Thread Lukas Sismis
Intel PMDs are capped by default to only 4096 RX/TX descriptors. This can be limiting for applications requiring a bigger buffer capabilities. By bufferring more packets with RX/TX descriptors, the applications can better handle the processing peaks. Setting ixgbe max descriptors to 8192 as per da

Re: [RFC PATCH v2] net: 2-byte align packed headers

2024-10-30 Thread David Marchand
On Wed, Oct 30, 2024 at 1:55 PM Morten Brørup wrote: > > Recheck-request: rebase=main, iol-unit-amd64-testing There is a conflict because of a change in rte_ether.h and the rte_ip.h split into rte_ip4.h/rte_ip6.h (Robin series). Could you send a new revision? Thanks. -- David Marchand

RE: [RFC PATCH v2] net: 2-byte align packed headers

2024-10-30 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 30 October 2024 16.11 > > On Wed, Oct 30, 2024 at 1:55 PM Morten Brørup > wrote: > > > > Recheck-request: rebase=main, iol-unit-amd64-testing > > There is a conflict because of a change in rte_ether.h and the > rte_ip.h

Re: [PATCH] net: increase the maximum of RX/TX descriptors

2024-10-30 Thread Stephen Hemminger
On Wed, 30 Oct 2024 14:58:40 +0100 Lukáš Šišmiš wrote: > On 29. 10. 24 15:37, Morten Brørup wrote: > >> From: Lukas Sismis [mailto:sis...@cesnet.cz] > >> Sent: Tuesday, 29 October 2024 13.49 > >> > >> Intel PMDs are capped by default to only 4096 RX/TX descriptors. > >> This can be limiting for a

Re: [PATCH v2 5/6] net: add smaller IPv4 cksum function for simple cases

2024-10-30 Thread Bruce Richardson
On Wed, Oct 30, 2024 at 03:08:06PM +0100, David Marchand wrote: > On Wed, Oct 30, 2024 at 12:32 PM Morten Brørup > wrote: > > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Wednesday, 30 October 2024 12.28 > > > > > > On Wed, Oct 30, 2024 at 12:21:00PM +0100, David M

Re: [PATCH v6 3/5] net/ice: enhance Tx scheduler hierarchy support

2024-10-30 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 29/10/2024 17:01, Bruce Richardson wrote: Increase the flexibility of the Tx scheduler hierarchy support in the driver. If the HW/firmware allows it, allow creating up to 2k child nodes per scheduler node. Also expand the number of supported layers to the max ava

Re: [PATCH v6 1/5] net/ice: add option to download scheduler topology

2024-10-30 Thread Medvedkin, Vladimir
Acked-by: Vladimir Medvedkin On 29/10/2024 17:01, Bruce Richardson wrote: The DDP package file being loaded at init time may contain an alternative Tx Scheduler topology in it. Add driver option to load this topology at init time. Signed-off-by: Bruce Richardson --- doc/guides/nics/ice.rst

[PATCH v4] doc: modernize build instructions on Windows

2024-10-30 Thread Andre Muezerie
Meson 0.57 was an unstable version and is now outdated. The referenced bug in Meson 0.58 is fixed in stable releases. Recommend the latest stable release which is tested. Building DPDK applications that run on 32-bit Windows is currently not supported. However, some Visual Studio environments defa

Re: [PATCH] net/vmxnet3: Fix vmxnet3 NULL pointer deref after configuration failure

2024-10-30 Thread Roger Melton (rmelton)
On 10/29/24 11:15 PM, Ferruh Yigit wrote: > On 10/26/2024 3:33 PM, Roger B Melton wrote: >> Problem: >> >> If vxmnet3_dev_configure() fails, applications may call >> vmxnet3_dev_close(). If the failure occurs before the vmxnet3 >> hw->shared structure is allocated the close will lead to a segv. >>

[PATCH v2] Revert "eal/unix: fix thread creation"

2024-10-30 Thread luca . boccassi
From: Luca Boccassi This commit introduced a regression on arm64, causing a deadlock. lcores_autotest gets stuck and never terminates: [ 1077s] EAL: Detected CPU lcores: 4 [ 1077s] EAL: Detected NUMA nodes: 1 [ 1077s] EAL: Detected shared linkage of DPDK [ 1077s] EAL: Multi-process socket /tmp/d

[PATCH v7 2/7] ring: common functions for 'move head' ops

2024-10-30 Thread Konstantin Ananyev
Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - code deduplication - ability in future to re-use the same code to introduce new functionality For each sync mode corresponding move_prod_head() and move_cons_head() are nearly i

[PATCH v7 0/7] Stage-Ordered API and other extensions for ring library

2024-10-30 Thread Konstantin Ananyev
Testing coverage (passed): x86_64, i686, PPC, ARM Would like to express my gratitude to all community members who helped me with testing it on different platforms, in particular: David Christensen Cody Cheng Patrick Robb Phanendra Vukkisala Chengwen Feng v6 -> v7 - updated Programmer Guid

Re: [PATCH] Revert "eal/unix: fix thread creation"

2024-10-30 Thread Luca Boccassi
On Wed, 30 Oct 2024 at 19:52, Stephen Hemminger wrote: > > On Wed, 30 Oct 2024 19:08:41 + > luca.bocca...@gmail.com wrote: > > > From: Luca Boccassi > > > > This commit introduced a regression on arm64, causing a deadlock. > > lcores_autotest gets stuck and never terminates: > > > > [ 1077s]

[PATCH v7 5/7] ring/soring: introduce Staged Ordered Ring

2024-10-30 Thread Konstantin Ananyev
Staged-Ordered-Ring (SORING) provides a SW abstraction for 'ordered' queues with multiple processing 'stages'. It is based on conventional DPDK rte_ring, re-uses many of its concepts, and even substantial part of its code. It can be viewed as an 'extension' of rte_ring functionality. In particular,

[PATCH v7 6/7] app/test: add unit tests for soring API

2024-10-30 Thread Konstantin Ananyev
Add both functional and stess test-cases for soring API. Stress test serves as both functional and performance test of soring enqueue/dequeue/acquire/release operations under high contention (for both over committed and non-over committed scenarios). Signed-off-by: Eimear Morrissey Signed-off-by:

[PATCH v7 7/7] test: add stress test suite

2024-10-30 Thread Konstantin Ananyev
Add a new test suite which purpose is to run 'stress' tests: main purpose is put a pressure to dpdk sync algorithms to flag their misbehaving/slowdown/etc. Right now it consists from just 2 test-cases: meson test --suite stress-tests --list DPDK:stress-tests / ring_stress_autotest DPDK:stress-tests

RE: [PATCH 0/6] reduce number of warnings being disabled

2024-10-30 Thread Konstantin Ananyev
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, October 30, 2024 5:38 PM > To: dev@dpdk.org > Cc: Bruce Richardson > Subject: [PATCH 0/6] reduce number of warnings being disabled > > for historical reasons, many drivers had extra warnings disabled, > especially in the

RE: [PATCH v3] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-30 Thread Wathsala Wathawana Vithanage
> Subject: [PATCH v3] crypto/ipsec_mb: bump minimum IPsec MB version > > AESNI_MB SW PMDs increment Intel IPsec MB version to 1.4. > A minimum IPsec Multi-buffer version of 1.4 or greater is now required for the > 24.11 LTS release. > > Signed-off-by: Brian Dooley > Acked-by: Kai Ji > Acked-b

[PATCH v1 0/1] baseband/acc: fix ring memory allocation logic

2024-10-30 Thread Nicolas Chautru
Hi Maxime, Can you please review and apply that fix for 24.11. Thanks, Nic Nicolas Chautru (1): baseband/acc: fix ring memory allocation logic drivers/baseband/acc/acc_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1

[PATCH v1 1/1] baseband/acc: fix ring memory allocation logic

2024-10-30 Thread Nicolas Chautru
Allowing ring memory allocation whose end address is aligned with 64 MB. Previous logic was off by one. Fixes: 060e76729302 ("baseband/acc100: add queue configuration") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/acc_common.h | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH V2 3/7] net/mlx5: add new devargs to control probe optimization

2024-10-30 Thread Stephen Hemminger
On Wed, 30 Oct 2024 08:16:58 + Slava Ovsiienko wrote: > Hi, > > > > -Original Message- > > From: Stephen Hemminger > > Sent: Tuesday, October 29, 2024 6:07 PM > > To: Minggang(Gavin) Li > > Cc: Slava Ovsiienko ; Matan Azrad > > ; Ori Kam ; NBU-Contact-Thomas > > Monjalon (EXTERNAL

[PATCH] Revert "eal/unix: fix thread creation"

2024-10-30 Thread luca . boccassi
From: Luca Boccassi This commit introduced a regression on arm64, causing a deadlock. lcores_autotest gets stuck and never terminates: [ 1077s] EAL: Detected CPU lcores: 4 [ 1077s] EAL: Detected NUMA nodes: 1 [ 1077s] EAL: Detected shared linkage of DPDK [ 1077s] EAL: Multi-process socket /tmp/d

[PATCH] common/idpf: add missing newline at end of file

2024-10-30 Thread Stephen Hemminger
The README file had missing newline. Signed-off-by: Stephen Hemminger --- drivers/common/idpf/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/idpf/base/README b/drivers/common/idpf/base/README index ff26f736ec..457b5a81f3 100644 --- a/drivers/common

Re: [PATCH v6 0/5] Improve rte_tm support in ICE driver

2024-10-30 Thread Bruce Richardson
On Tue, Oct 29, 2024 at 05:01:52PM +, Bruce Richardson wrote: > This patchset expands the capabilities of the traffic management > support in the ICE driver. It allows the driver to support different > sizes of topologies, and support >256 queues and more than 3 hierarchy > layers. > > --- >

[PATCH 2/2] net/mlx5: fix counter query loop getting stuck

2024-10-30 Thread Dariusz Sosnowski
Counter service thread, responsible for refreshing counter values stored in host memory, is running an "infinite loop" with the following logic: - For each port: - Refresh port's counter pool - call to __mlx5_hws_cnt_svc(). - Perform aging checks. - Go to sleep if time left in current cycl

[PATCH 1/2] net/mlx5: fix dangling pointer to params

2024-10-30 Thread Dariusz Sosnowski
Offending commits introduced 2 structures which held temporary parameters for flow rule created. These parameters were passed to "rule_acts" buffers stored inside template table and they were used only during a call to mlx5dr_rule_create(). After mlx5dr_rule_create() finished, "rule_acts" buffer is

[PATCH 0/2] net/mlx5: fix counter query loop getting stuck

2024-10-30 Thread Dariusz Sosnowski
Main content of this patchset is "net/mlx5: fix counter query loop getting stuck" patch. The preceding patch is required, because the fix for counter query loop triggered the dangling pointer compilation error in GCC 14.2.1 in an unrelated part of the code. To be specific, the following part caus

[DPDK/DTS Bug 1573] NIC latency issue on the AsyncSniffer callback function

2024-10-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1573 Bug ID: 1573 Summary: NIC latency issue on the AsyncSniffer callback function Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRM

[PATCH v1] dts: add time delay to async sniffer callback function

2024-10-30 Thread Nicholas Pratte
There exists a bug within i40e NICs in which the async sniffer does not catch send packets as a result of the callback function sending packets too quickly before the NICs are ready to start capturing. There could be a multitude of reasons why this happens on these NICs, but for the time being, in

Re: [PATCH] common/idpf: add missing newline at end of file

2024-10-30 Thread Bruce Richardson
On Wed, Oct 30, 2024 at 08:52:35AM -0700, Stephen Hemminger wrote: > The README file had missing newline. > > Signed-off-by: Stephen Hemminger > --- > drivers/common/idpf/base/README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/common/idpf/base/README b/drive

Re: [PATCH] net: increase the maximum of RX/TX descriptors

2024-10-30 Thread Lukáš Šišmiš
On 30. 10. 24 16:20, Stephen Hemminger wrote: On Wed, 30 Oct 2024 14:58:40 +0100 Lukáš Šišmiš wrote: On 29. 10. 24 15:37, Morten Brørup wrote: From: Lukas Sismis [mailto:sis...@cesnet.cz] Sent: Tuesday, 29 October 2024 13.49 Intel PMDs are capped by default to only 4096 RX/TX descriptors.

Re: [PATCH] Revert "eal/unix: fix thread creation"

2024-10-30 Thread Stephen Hemminger
On Wed, 30 Oct 2024 19:08:41 + luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > This commit introduced a regression on arm64, causing a deadlock. > lcores_autotest gets stuck and never terminates: > > [ 1077s] EAL: Detected CPU lcores: 4 > [ 1077s] EAL: Detected NUMA nodes: 1 > [ 10

Re: [PATCH] net/mlx5: fix PMD compilation in non-HWS setup

2024-10-30 Thread Raslan Darawsheh
Hi, From: Gregory Etelson Sent: Tuesday, October 29, 2024 3:34 PM To: dev@dpdk.org Cc: Gregory Etelson; Maayan Kashani; Raslan Darawsheh; Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Suanming Mou; Matan Azrad Subject: [PATCH] net/mlx5: fix PMD compilation in non-HWS setup The PMD cal

RE: [PATCH v3 1/2] net/ixgbe: increase the maximum of RX/TX descriptors

2024-10-30 Thread Morten Brørup
> From: Lukas Sismis [mailto:sis...@cesnet.cz] > Sent: Wednesday, 30 October 2024 16.43 > > Intel PMDs are capped by default to only 4096 RX/TX descriptors. > This can be limiting for applications requiring a bigger buffer > capabilities. By bufferring more packets with RX/TX > descriptors, the ap

RE: [PATCH v3 2/2] net/ice: increase the maximum of RX/TX descriptors

2024-10-30 Thread Morten Brørup
> From: Lukas Sismis [mailto:sis...@cesnet.cz] > Sent: Wednesday, 30 October 2024 16.43 > > Intel PMDs are capped by default to only 4096 RX/TX descriptors. > This can be limiting for applications requiring a bigger buffer > capabilities. By bufferring more packets with RX/TX > descriptors, the ap

[PATCH 3/6] net/e1000/base: remove warning disable flags

2024-10-30 Thread Bruce Richardson
Not all the flags for disabling warnings on the base code are needed, so remove the unnecessary ones. Signed-off-by: Bruce Richardson --- drivers/net/e1000/base/meson.build | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/e1000/base/meson.build b/drivers/ne

[PATCH 0/6] reduce number of warnings being disabled

2024-10-30 Thread Bruce Richardson
for historical reasons, many drivers had extra warnings disabled, especially in their base code directory. Many, but not all, of these warning disabling flags are unnecessary so remove as many as we can. Bruce Richardson (6): net/i40e/base: remove warning disable flags net/ice/base: remove war

[PATCH 2/6] net/ice/base: remove warning disable flag

2024-10-30 Thread Bruce Richardson
The -Wno-unused-value flag is not needed for building the base code, so remove that flag from the list of warnings to disable. Signed-off-by: Bruce Richardson --- drivers/net/ice/base/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ic

[PATCH 6/6] common/idpf/base: remove warning disable flags

2024-10-30 Thread Bruce Richardson
Remove unnecessary warning disable flags, and for the remaining flag implement a compiler-check for it before adding it to the cflags. Signed-off-by: Bruce Richardson --- drivers/common/idpf/base/meson.build | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH 5/6] net/fm10k/base: remove warning disable flags

2024-10-30 Thread Bruce Richardson
Not all the warning disable flags on the base code are necessary, so reduce the list to only those needed. Signed-off-by: Bruce Richardson --- drivers/net/fm10k/base/meson.build | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/fm10k/base/meson.build b/driver

[PATCH 4/6] net/iavf: remove warning disable flag

2024-10-30 Thread Bruce Richardson
The no-strict-aliasing flag is not needed for the iavf build so remove it. Signed-off-by: Bruce Richardson --- drivers/net/iavf/meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build index 27d104cc12..b48bb83438 100644 --- a/d

[PATCH v3 1/1] net/bonding: make bonding functions stable

2024-10-30 Thread Lukas Sismis
Remove rte_experimental macros from the stable functions as they have been part of the stable API since 23.11. Signed-off-by: Lukas Sismis --- drivers/net/bonding/rte_eth_bond.h| 4 drivers/net/bonding/rte_eth_bond_8023ad.h | 1 - drivers/net/bonding/version.map | 15 +++

[PATCH v3 2/2] net/ice: increase the maximum of RX/TX descriptors

2024-10-30 Thread Lukas Sismis
Intel PMDs are capped by default to only 4096 RX/TX descriptors. This can be limiting for applications requiring a bigger buffer capabilities. By bufferring more packets with RX/TX descriptors, the applications can better handle the processing peaks. Setting ice max descriptors to 8192 - 32 as per

[PATCH v3 1/2] net/ixgbe: increase the maximum of RX/TX descriptors

2024-10-30 Thread Lukas Sismis
Intel PMDs are capped by default to only 4096 RX/TX descriptors. This can be limiting for applications requiring a bigger buffer capabilities. By bufferring more packets with RX/TX descriptors, the applications can better handle the processing peaks. Setting ixgbe max descriptors to 8192 as per da

Re: [PATCH] net: increase the maximum of RX/TX descriptors

2024-10-30 Thread Stephen Hemminger
On Wed, 30 Oct 2024 16:40:10 +0100 Lukáš Šišmiš wrote: > On 30. 10. 24 16:20, Stephen Hemminger wrote: > > On Wed, 30 Oct 2024 14:58:40 +0100 > > Lukáš Šišmiš wrote: > > > >> On 29. 10. 24 15:37, Morten Brørup wrote: > From: Lukas Sismis [mailto:sis...@cesnet.cz] > Sent: Tuesday, 2

RE: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls

2024-10-30 Thread Pavan Nikhilesh Bhagavatula
> > Hi Pavan, > > > > Snipped > > > > > > > > I see compilation failure on ARM platforms due to missing header include. > > > > > > ../examples/helloworld/main.c: In function 'parse_topology': > > > ../examples/helloworld/main.c:83:13: error: implicit declaration of > > > function 'strtoul'; did yo

Re: [PATCH v6] testpmd: add hairpin map parameter

2024-10-30 Thread Stephen Hemminger
On Wed, 30 Oct 2024 09:37:24 +0200 Gregory Etelson wrote: > +static int > +port_config_hairpin_rxq(portid_t pi, uint16_t peer_tx_port, > + queueid_t rxq_head, queueid_t txq_head, > + uint16_t qcount, uint32_t manual_bind) > +{ > + int diag; > + queu

[PATCH] build: output source and build dirs at end of config

2024-10-30 Thread Bruce Richardson
The configuration run of meson produces a lot of output. When running test-meson-builds script, or any other script which does multiple builds, it can be useful to see the directory in which ninja is being run. Currently this requires scrolling back to the top of the output, so to simplify things p

Re: [PATCH v4] doc: modernize build instructions on Windows

2024-10-30 Thread Stephen Hemminger
On Wed, 30 Oct 2024 08:19:45 -0700 Andre Muezerie wrote: > Meson 0.57 was an unstable version and is now outdated. > The referenced bug in Meson 0.58 is fixed in stable releases. > Recommend the latest stable release which is tested. > > Building DPDK applications that run on 32-bit Windows is >

Re: [PATCH v2] net/ice: fix incorrect reading of PHY timestamp

2024-10-30 Thread Bruce Richardson
On Wed, Oct 30, 2024 at 02:16:11AM +, Soumyadeep Hore wrote: > In ICE PMD, previously the ready bitmap checking before reading > PHY timestamp was not present. This caused incorrect Tx > timestamping. > > The ready bitmap checking is enabled and PHY timestamp is read once > the ready bitmap gi

Re: [PATCH v1] net/macb: add new driver

2024-10-30 Thread Stephen Hemminger
On Wed, 30 Oct 2024 09:53:29 + liwencheng wrote: > add Phytium NIC MACB ethdev PMD driver. > > Signed-off-by: liwencheng > --- > drivers/net/macb/base/generic_phy.c | 276 + > drivers/net/macb/base/generic_phy.h | 198 > drivers/net/macb/base/macb_common.c | 667 +

[PATCH 1/6] net/i40e/base: remove warning disable flags

2024-10-30 Thread Bruce Richardson
The i40e base code driver has a number of unnecessary warning disabling flags. We can remove three flags warning about variable format errors. In the process, simplify the list to one flag per line. Suggested-by: David Marchand Signed-off-by: Bruce Richardson --- drivers/net/i40e/base/meson.bui

[PATCH v7 3/7] ring: make copying functions generic

2024-10-30 Thread Konstantin Ananyev
Note upfront: that change doesn't introduce any functional or performance changes. It is just a code-reordering for: - improve code modularity and re-usability - ability in future to re-use the same code to introduce new functionality There is no real need for enqueue_elems()/dequeue_elems() to

[PATCH v7 1/7] test/ring: fix failure with custom number of lcores

2024-10-30 Thread Konstantin Ananyev
ring_stress_autotest fails to initialize the ring when RTE_MAX_LCORE value is not a number of 2. There is a flaw in calculation required number of elements in the ring. Fix it by aligning number of elements to next power of 2. Fixes: bf28df24e915 ("test/ring: add contention stress test") Cc: sta..

[PATCH v7 4/7] ring: make dump function more verbose

2024-10-30 Thread Konstantin Ananyev
From: Eimear Morrissey The current rte_ring_dump function uses the generic rte_ring_headtail structure to access head/tail positions. This is incorrect for the RTS case where the head is stored in a different offset in the union of structs. Switching to a separate function for each sync type allo

RE: [EXTERNAL] [RFC v3 2/3] test/lcore: enable tests for topology

2024-10-30 Thread Pavan Nikhilesh Bhagavatula
> add functional test cases to validate topology supported lcore > API. > > v3 changes: > - fix test test-report/2024-October/817748.html > > Signed-off-by: Vipin Varghese > --- Test fails on ARM platform: lcore 19, socket 0, role RTE, cpuset 19 Control thread running successfully INFO: lco

RE: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls

2024-10-30 Thread Varghese, Vipin
Hi Pavan, Snipped > > I see compilation failure on ARM platforms due to missing header include. > > ../examples/helloworld/main.c: In function 'parse_topology': > ../examples/helloworld/main.c:83:13: error: implicit declaration of function > 'strtoul'; > did you mean 'strtok'? [-Wimplicit-func

  1   2   3   >