> From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> Sent: Tuesday, 19 November 2024 05.35
>
> From: Tyler Retzlaff
>
> MSVC struct packing is not compatible with GCC. Provide a macro that
> can be used to push existing pack value and sets packing to 1-byte.
> The existing __rte_packed
Update virtio_crypto_config structure to include AKCIPHER algorithms,
as per VirtIO standard.
Signed-off-by: Gowrishankar Muthukrishnan
Change-Id: I227bfa9b2bb840a92d50b21b538892927379f3f2
---
lib/vhost/virtio_crypto.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vhost
> > The function node_dump add some printing of node information. Signed-off-
> > by: Huichao cai --- lib/graph/graph_debug. c | 11
> > ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git
> > a/lib/graph/graph_debug. c
> > The function node_dump add some printing of node inform
> -Original Message-
> From: Morten Brørup
> Sent: Tuesday, November 19, 2024 8:32 AM
> To: Andre Muezerie ;
> roret...@linux.microsoft.com; techbo...@dpdk.org
> Cc: yuying.zh...@intel.com; aman.deep.si...@intel.com;
> anatoly.bura...@intel.com; bruce.richard...@intel.com;
> byron.mar
Update virtio_crypto_config structure to include AKCIPHER algorithms,
as per VirtIO standard.
Signed-off-by: Gowrishankar Muthukrishnan
---
v1:
- updated patch description.
---
lib/vhost/virtio_crypto.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vhost/virtio_cryp
https://bugs.dpdk.org/show_bug.cgi?id=1414
Patrick Robb (pr...@iol.unh.edu) changed:
What|Removed |Added
Resolution|--- |FIXED
Status|CONFI
Dear Thomas,
How about the following modification? Or could I just change rte_smp_rmb to
rte_rmb instead?
struct rtl_tx_desc {
RTE_ATOMIC(u32) opts1;
u32 opts2;
u64 addr;
u32 reserved0;
u32 reserved1;
u32 reserved2;
u32 reserved3;
};
stati
15/11/2024 16:25, Andre Muezerie:
> ../lib/rcu/rte_rcu_qsbr.c(101): warning C4334: '<<': result of 32-bit
> shift implicitly converted to 64 bits (was 64-bit shift intended?)
> ../lib/rcu/rte_rcu_qsbr.c(107): warning C4334: '<<': result of 32-bit
> shift implicitly converted to 64 bits (was 64-bi
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Tuesday, 19 November 2024 10.26
>
> 15/11/2024 17:18, Stephen Hemminger:
> > On Fri, 15 Nov 2024 07:25:30 -0800
> > Andre Muezerie wrote:
> >
> > > From reading the code this is also a bugfix:
> > > (1 << id), where id = thread_id & 0x3
> Subject: [PATCH v2] vhost: include AKCIPHER algorithms in crypto_config
>
> Update virtio_crypto_config structure to include AKCIPHER algorithms,
> as per VirtIO standard.
>
> Signed-off-by: Gowrishankar Muthukrishnan
> ---
Acked-by: Akhil Goyal
> > 15/11/2024 02:55, Huichao Cai:
> > > The members "dispatch" and "xstat_off" of the structure "rte_node"
> > > can be min cache aligned to make room for future expansion and to make
> > > sure have better performance. Add corresponding comments.
> > >
> > > Signed-off-by: Huichao Cai ]
>
> Acke
13/11/2024 07:38, Andrew Rybchenko:
> On 11/13/24 06:08, Morten Brørup wrote:
> >> From: Andre Muezerie [mailto:andre...@linux.microsoft.com]
> >> Sent: Wednesday, 13 November 2024 02.25
> >>
> >> The issues that were preventing mempool from getting compiled with
> >> MSVC were fixed, so now it sho
13/11/2024 01:30, fengchengwen:
> On 2024/11/13 6:48, Andre Muezerie wrote:
> > The issues that were preventing argparser from getting compiled with
> > MSVC were fixed, so now it should not be excluded from the
> > compilation anymore.
> >
> > Signed-off-by: Andre Muezerie
>
> Acked-by: Chengwe
On 2024-11-12 03:02, Andre Muezerie wrote:
1) MSVC does not support VLAs. Use standard fixed C arrays of
maximum size required instead.
2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8:
error: array subscript 9 is outside array bounds of 'uint64_t[16]'
{aka 'long unsi
On 10/24/24 11:05, David Marchand wrote:
On Fri, Oct 11, 2024 at 1:17 PM Konrad Sztyber wrote:
The uio_pci_generic driver clears the bus master bit when the device
file is closed. So, when the secondary process terminates after probing
a device, that device becomes unusable in the primary proc
> > Subject: [PATCH v1] examples/fips_validation: fix EdDSA signature size
> >
> > Fix EdDSA signature size.
> >
> > Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")
> >
> > Signed-off-by: Gowrishankar Muthukrishnan
Applied to dpdk-next-crypto
Thanks.
Update virtio_crypto_config structure to include AKCIPHER algorithms,
as per VirtIO standard.
Signed-off-by: Gowrishankar Muthukrishnan
---
v1:
- updated patch description.
---
lib/vhost/virtio_crypto.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vhost/virtio_cryp
Yes atomic load is perfect.
rte_rmb is worst :)
19/11/2024 09:52, 王颢:
> Dear Thomas,
>
> How about the following modification? Or could I just change rte_smp_rmb to
> rte_rmb instead?
>
> struct rtl_tx_desc {
> RTE_ATOMIC(u32) opts1;
> u32 opts2;
> u64 addr;
> u32 reser
12/11/2024 10:56, Dmitry Kozlyuk:
> 2024-11-11 08:14 (UTC-0800), Andre Muezerie:
> > Meson 0.57 was an unstable version and is now outdated.
> > The referenced bug in Meson 0.58 is fixed in stable releases.
> > Recommend the first version containing the fix: 1.5.2.
> >
> > Building DPDK applicatio
From: Medvedkin, Vladimir
Sent: Monday 11 November 2024 5:46 pm
To: Richardson, Bruce ; dev@dpdk.org
Cc: sta...@dpdk.org ; Connolly, Padraig J
; Stokes, Ian ; Zhang, Qi Z
; Kevin Liu
Subject: Re: [PATCH] net/iavf: add segment-length check to Tx prep
Acked-by
> The function EVP_PKEY_CTX_free allows NULL parameter
> (similar to free()).
>
> Signed-off-by: Stephen Hemminger
> ---
Applied to dpdk-next-crypto
Thanks.
Tested-by: Padraig Connolly
> Acked-by: Vladimir Medvedkin
>On 11/11/2024 16:42, Bruce Richardson wrote:
> > In the Tx prep function, the metadata checks were only checking the
> > packet length and ignoring the data length. For single-buffer packets we
> > can quickly check that the data leng
> > Subject: [PATCH v1] examples/fips_validation: prehash input for RSA
> >
> > Plain text needs to be prehashed for RSA as well in asymmetric crypto
> > validation.
> >
> > Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA")
> >
> > Signed-off-by: Gowrishankar Muthukrishnan
> Acked-by
15/11/2024 17:18, Stephen Hemminger:
> On Fri, 15 Nov 2024 07:25:30 -0800
> Andre Muezerie wrote:
>
> > From reading the code this is also a bugfix:
> > (1 << id), where id = thread_id & 0x3f, was wrong when thread_id > 0x1f.
>
> Since this seems to be a common anti-pattern in DPDK,
> I wonder i
On Fri, Nov 15, 2024 at 07:14:25PM +, Vladimir Medvedkin wrote:
> 'i40e_get_outer_vlan()' does not check 'i40e_aq_debug_read_register()'
> return value. This patch fixes this issue.
I think a little more detail on the scope of the changes could be good
here. It fixes the issue by allowing the
On Tue, 19 Nov 2024 16:34:24 +0100
Thomas Monjalon wrote:
> 31/07/2024 01:40, Stephen Hemminger:
> > The CentOS Project has shifted focus from CentOS Linux to CentOS Stream.
> > Both CentOS 7 and 8 are now end of life (EOL).
> >
> > CentOS Linux 7 EOL: 2024-06-30
> > CentOS Linux 8 EOL:
16/11/2024 02:12, Stephen Hemminger:
> Because of misuse of & vs && operator, the member code would
> always use the primary bucket.
>
> Fixes: 904ec78a239c ("member: implement HT mode")
> Cc: yipeng1.w...@intel.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Stephen Hemminger
Applied, thanks.
19/11/2024 19:27, Dmitry Kozlyuk:
> 2024-11-19 15:48 (UTC+), Bruce Richardson:
> > On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote:
> > > 2024-10-26 06:43 (UTC-0500), Lewis Donzis:
> > > > Is the extra control necessary, i.e., why not just always do this and
> > > > let
> > >
12/09/2024 03:29, fengchengwen:
> On 2024/9/12 8:55, Stephen Hemminger wrote:
> > The function strtok is not thread safe, better to use strtok_r.
> > This patch was found by running semgrep on the DPDK repository.
> >
> > Signed-off-by: Stephen Hemminger
> Acked-by: Chengwen Feng
Applied, thank
On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote:
> 2024-10-26 06:43 (UTC-0500), Lewis Donzis:
> > Is the extra control necessary, i.e., why not just always do this and let
> > the EAL option control whether the pages get dumped?
>
> I've been evaluating your suggestion and see no do
13/11/2024 01:59, Huisong Li:
> The typo in the guide is hard to understand. Necessary to fix it.
>
> Fixes: dd6fd75bf662 ("power: introduce PM QoS API on CPU wide")
>
> Signed-off-by: Huisong Li
Applied, thanks.
13/08/2024 17:57, Stephen Hemminger:
> The cfgfile tests did not get built since conversion to meson
> and they used an awkward way to manage the test data.
>
> This patchset converts the tests to use a helper to take
> text file and make it into a C header. Then use the C header
> to generate tem
19/04/2024 11:07, Vidya Sagar Velumuri:
> Add test cases to verify zero fill and one fill
>
> Signed-off-by: Vidya Sagar Velumuri
Waiting for review from DMA maintainers.
> diff --git a/app/test/test.h b/app/test/test.h
> index 15e23d297f..0ca6519f6e 100644
> --- a/app/test/test.h
> +++ b/app/t
19/11/2024 19:40, Stephen Hemminger:
> On Tue, 19 Nov 2024 16:34:24 +0100
> Thomas Monjalon wrote:
>
> > 31/07/2024 01:40, Stephen Hemminger:
> > > The CentOS Project has shifted focus from CentOS Linux to CentOS Stream.
> > > Both CentOS 7 and 8 are now end of life (EOL).
> > >
> > > CentOS L
09/10/2024 03:22, fengchengwen:
> On 2024/10/4 10:48, Stephen Hemminger wrote:
> > From: Fidaullah Noonari
> >
> > when app is launched with -m proc-info exit without
> > rte_eal_cleanup() causing memory leakage. This commit resolves the
> > memory leakage issue and closes app properly.
> >
> >
> Danylo Vodopianov (2):
> app/testpmd: fix flow update
> app/testpmd: fix aged flow destroy
Applied, thanks.
On Wed, Oct 30, 2024 at 05:16:01PM +, Bruce Richardson wrote:
> The configuration run of meson produces a lot of output. When running
> test-meson-builds script, or any other script which does multiple
> builds, it can be useful to see the directory in which ninja is being
> run. Currently this
14/11/2024 11:05, Gowrishankar Muthukrishnan:
> Hi,
> > wrote:
> > >
> > > Add co-maintainer for DMA perf app.
> > >
> > > Signed-off-by: Gowrishankar Muthukrishnan
> >
> > Good to have more maintainers.
> >
> > Acked-by: Jerin Jacob
>
> Could this patch be applied ?.
Waiting for acks from o
26/09/2024 14:13, Amit Prakash Shukla:
> Add support to configure device specific config parameters for a
> testcase. Example:
>
> lcore_dma0=lcore=11,dev=:00:04.1,dir=mem2dev,raddr=0x3,
> coreid=1,pfid=2,vfid=3
> lcore_dma1=lcore=12,dev=:00:04.2,dir=dev2mem,raddr=0x2,
> co
08/10/2024 08:52, Shaiq Wani:
> Added a note to avoid usage errors by end user.
>
> Signed-off-by: Shaiq Wani
>
> v2 - addressed review comments.
> ---
> --- a/app/test-dma-perf/config.ini
> +++ b/app/test-dma-perf/config.ini
> @@ -61,6 +61,9 @@
> ; If you do not specify a result file, one will
18/10/2024 03:08, Jie Hai:
> Add options to support configuring RX burst size and cache size
> of mbuf mempoool.
Applied, thanks.
2024-11-19 15:48 (UTC+), Bruce Richardson:
> On Mon, Oct 28, 2024 at 04:26:06PM +0300, Dmitry Kozlyuk wrote:
> > 2024-10-26 06:43 (UTC-0500), Lewis Donzis:
> > > Is the extra control necessary, i.e., why not just always do this and let
> > > the EAL option control whether the pages get dumped
31/07/2024 01:40, Stephen Hemminger:
> The CentOS Project has shifted focus from CentOS Linux to CentOS Stream.
> Both CentOS 7 and 8 are now end of life (EOL).
>
> CentOS Linux 7 EOL: 2024-06-30
> CentOS Linux 8 EOL: 2021-12-31
> CentOS Stream 8 EOL: 2024-05-31
>
> Update the d
On Tue, Nov 19, 2024 at 05:22:21PM +0100, Thomas Monjalon wrote:
> 19/11/2024 16:57, Bruce Richardson:
> > When using a secondary process, e.g. pdump, not all PCI devices will be
> > probed correctly if the primary process has allowlisted devices using
> > the shortened syntax, omitting the initial
> So... this is a weird one. I've integrated the code generation under
> dts-check-format.sh, so nobody should really worry about it, as that
> should be run before submitting. If it's not, then the CI will
> eventually pick it up when dts-check-format will be in place.
Right, and that definitely
Applied to next-dts, thanks.
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test-pmd/cmdline.c | 2 +-
app/test-pmd/cmdline_flow.c | 15
From: Konstantin Ananyev
1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’
>From my understanding, tuple size here should never exceed
sizeof(union rte_thash_tuple), so it should be safe to replace VLA with
fixed size array.
Signed-off-by: Konstant
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
drivers/common/idpf/idpf_common_rxtx.c
From: Konstantin Ananyev
1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length array ‘positions’
Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash
From: Andre Muezerie
1) MSVC does not support VLAs. Use standard fixed C arrays of
maximum size required instead.
2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8:
error: array subscript 9 is outside array bounds of 'uint64_t[16]'
{aka 'long unsigned int[16]'} [-Werror=
From: Konstantin Ananyev
1) ./lib/eal/linux/eal_interrupts.c:1073:16
: warning: ISO C90 forbids variable length array ‘events’
MSVC does not support VLAs. Use alloca() to allocate the memory on
the stack.
2) ./lib/eal/linux/eal_interrupts.c:1319:16
: warning: ISO C90 forbids variable le
20/11/2024 02:45, zhang.yon...@zte.com.cn:
> The patch is currently in the accepted state.
Yes I've merged it.
> Should I resubmit the patch or modify it in the next release?
You can modify with a new patch for the next release.
v3 changes:
* rebased the series to latest commit.
v2 changes:
* Handled a comment to enhance the invalid port ID logic
and added a user option to decide exit or silently skip
in case invalid port in the rules list.
Gagandeep Singh (3):
examples/l3fwd: support single route file
exampl
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
drivers/common/idpf/idpf_common_rxtx.c
On Tue, Nov 19, 2024 at 11:16:04AM +0100, Mattias Rönnblom wrote:
> On 2024-11-12 03:02, Andre Muezerie wrote:
> >1) MSVC does not support VLAs. Use standard fixed C arrays of
> >maximum size required instead.
> >
> >2) ../usr/lib/gcc/x86_64-redhat-linux/13/include/emmintrin.h:742:8:
> > error:
Hi Thomas,
>> +#define ZXDH_GDMA_SRC_LLI_ERR (1 << 16)>> +#define
>> ZXDH_GDMA_SRC_DATA_ERR (1 << 17)>> +#define
>> ZXDH_GDMA_DST_ADDR_ERR (1 << 18)>> +#define
>> ZXDH_GDMA_ERR_STATUS(1 << 19)>> +#define
>> ZXDH_GDMA_ERR_I
On Fri, Oct 25, 2024 at 11:26:14PM +0300, Dmitry Kozlyuk wrote:
> It was impossible to include mapped contigmem buffers in core dump.
> Add hw.contigmem.coredump_enable tunable to control the inclusion.
>
> Mappings backed by OBJ_FICTITIOUS are excluded from core dump.
> While contigmem is a devic
From: Konstantin Ananyev
../drivers/net/ice/ice_rxtx.c:1871:29: warning:
variable length array used [-Wvla]
Here VLA is used as a temp array for mbufs that will be used as a split
RX data buffers.
As at any given time only one thread can do RX from particular queue,
at rx_queue_setup() we ca
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/mlx5/mlx5.c | 5 ++---
drivers/net/mlx5/mlx5_flow.c |
rte_smp_rmb is deprecated and it is too heavy.
Signed-off-by: Howard Wang
---
drivers/net/r8169/r8169_rxtx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/r8169/r8169_rxtx.c b/drivers/net/r8169/r8169_rxtx.c
index a3b86300f0..57b97338d4 100644
--- a/drivers
From: Tyler Retzlaff
MSVC does not support optional C11 VLAs. When building for Windows
enable -Wvla so that mingw and clang also fail if a VLA is used.
Signed-off-by: Tyler Retzlaff
---
config/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/config/meson.build b/config/meso
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/common/mlx5/mlx5_common.h| 4 ++--
drivers/common/mlx5/mlx
From: Konstantin Ananyev
1) ./lib/rcu/rte_rcu_qsbr.c:359:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
2) ./lib/rcu/rte_rcu_qsbr.c:422:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
In both cases we allocate VLA for one element from RCU deferred que
14/11/2024 10:20, Yong Zhang:
> Introduce rawdev driver support for GDTC which
> can help to connect two separate hosts with each other.
>
> Signed-off-by: Yong Zhang
I've sorted things, and avoided reindent in the last patch.
Series applied, thanks.
A new DPDK release candidate is ready for testing:
https://git.dpdk.org/dpdk/tag/?id=v24.11-rc3
There are 192 new patches in this snapshot.
Hopefully almost everything expected should be in.
Release notes:
https://doc.dpdk.org/guides/rel_notes/release_24_11.html
Highlights of 24.
fix return value on adding the EM or LPM rules.
Fixes: e7e6dd643092 ("examples/l3fwd: support config file for EM")
Fixes: 52def963fc1c ("examples/l3fwd: support config file for LPM/FIB")
Cc: sean.morris...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Gagandeep Singh
---
examples/l3fwd/em_route_
14/11/2024 10:20, Yong Zhang:
> +#define ZXDH_GDMA_SRC_LLI_ERR (1 << 16)
> +#define ZXDH_GDMA_SRC_DATA_ERR (1 << 17)
> +#define ZXDH_GDMA_DST_ADDR_ERR (1 << 18)
> +#define ZXDH_GDMA_ERR_STATUS(1 << 19)
> +#define ZXDH_GDMA_ERR_
01/11/2024 03:26, lihuisong (C):
> For this series,
> Acked-by: Huisong Li
> 在 2024/10/30 16:54, Chengwen Feng 写道:
> > When developing patchset [1], I found the kvargs test is hard to
> > understand when tried to add some testcase.
> >
> > So refactor kvargs by:
> > 1. introduce UT suite framework
From: Konstantin Ananyev
1) ./lib/ethdev/rte_ethdev.c:3244:16
: warning: ISO C90 forbids variable length array ‘xstats_names’
2) ./lib/ethdev/rte_ethdev.c:3345:17
: warning: ISO C90 forbids variable length array ‘ids_copy’
3) ./lib/ethdev/rte_ethdev.c:3538:16
: warning: ISO C90 forbid
From: Konstantin Ananyev
1) ./lib/eal/linux/eal_interrupts.c:1073:16
: warning: ISO C90 forbids variable length array ‘events’
MSVC does not support VLAs. Use alloca() to allocate the memory on
the stack.
2) ./lib/eal/linux/eal_interrupts.c:1319:16
: warning: ISO C90 forbids variable le
From: Andre Muezerie
As per guidance technical board meeting 2024/04/17. This series
removes the use of VLAs from code built for Windows for all 3
toolchains. If there are additional opportunities to convert VLAs
to regular C arrays please provide the details for incorporation
into the series.
M
From: Konstantin Ananyev
../lib/gro/rte_gro.c:182:34: warning:
variable length array used [-Wvla]
../lib/gro/rte_gro.c:363:34: warning:
variable length array used [-Wvla]
In both cases the pattern is the same: we use unprocess_pkts[nb_pkts] to
collect un-used by GRO packets, and then cop
On 2024/11/20 1:42, Thomas Monjalon wrote:
> 08/10/2024 08:52, Shaiq Wani:
>> Added a note to avoid usage errors by end user.
>>
>> Signed-off-by: Shaiq Wani
>>
>> v2 - addressed review comments.
>> ---
>> --- a/app/test-dma-perf/config.ini
>> +++ b/app/test-dma-perf/config.ini
>> @@ -61,6 +61,9 @
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test/test.c | 2 +-
app/test/test_cmdline_s
From: Konstantin Ananyev
1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning:
variable length array used [-Wvla]
2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning:
variable length array used [-Wvla]
3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning:
variable len
From: Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays.
Signed-off-by: Andre Muezerie
---
lib/hash/rte_thash_gf2_poly_math.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/hash/rte_thash_gf2_poly_math.c
b/lib/hash/rte_thash_gf2_pol
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Reviewed-by: Bruce Richardson
---
drivers/net/i40e/i40e_testpmd.c | 5 ++-
From: Andre Muezerie
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Andre Muezerie
---
app/test-pmd/shared_rxq_fwd.c | 2 +-
1 file changed, 1 insertion(+),
From: Konstantin Ananyev
gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.
Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: sta...@dpdk.org
Signed-off-by: Konstantin Ananyev
Acked-by: Ferr
14/10/2024 18:47, Stephen Hemminger:
> On Mon, 30 Sep 2024 22:53:21 +0300
> Shani Peretz wrote:
>
> > These code snippets demonstrate rule creation using
> > template and non-template APIs.
> > They include functions that enable developers to create rules.
> > The purpose of providing these snipp
From: Tyler Retzlaff
Include alloca.h for Linux and malloc.h for Windows to get declaration
of alloca().
Signed-off-by: Tyler Retzlaff
---
lib/eal/linux/include/rte_os.h | 1 +
lib/eal/windows/include/rte_os.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/eal/linux/include/rte_os
From: Konstantin Ananyev
1) ./lib/rcu/rte_rcu_qsbr.c:359:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
2) ./lib/rcu/rte_rcu_qsbr.c:422:9
: warning: ISO C90 forbids variable length array ‘data’ [-Wvla]
In both cases we allocate VLA for one element from RCU deferred que
From: Konstantin Ananyev
1) ./lib/hash/rte_thash.c:774:9
: warning: ISO C90 forbids variable length array ‘tmp_tuple’
>From my understanding, tuple size here should never exceed
sizeof(union rte_thash_tuple), so it should be safe to replace VLA with
fixed size array.
Signed-off-by: Konstant
From: Konstantin Ananyev
1) ./lib/ethdev/rte_ethdev.c:3244:16
: warning: ISO C90 forbids variable length array ‘xstats_names’
2) ./lib/ethdev/rte_ethdev.c:3345:17
: warning: ISO C90 forbids variable length array ‘ids_copy’
3) ./lib/ethdev/rte_ethdev.c:3538:16
: warning: ISO C90 forbid
From: Konstantin Ananyev
1) ../lib/eal/common/eal_common_proc.c:695:15
: warning: variable length array used
As msg->num_fds should not exceed RTE_MP_MAX_FD_NUM, replaced
it with fixed size array.
Signed-off-by: Konstantin Ananyev
---
lib/eal/common/eal_common_proc.c | 5 +++--
1 file cha
From: Konstantin Ananyev
1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning:
variable length array used [-Wvla]
2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning:
variable length array used [-Wvla]
3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning:
variable len
From: Konstantin Ananyev
../drivers/net/ice/ice_rxtx.c:1871:29: warning:
variable length array used [-Wvla]
Here VLA is used as a temp array for mbufs that will be used as a split
RX data buffers.
As at any given time only one thread can do RX from particular queue,
at rx_queue_setup() we ca
From: Konstantin Ananyev
1) ./lib/hash/rte_cuckoo_hash.c:2362:9
: warning: ISO C90 forbids variable length array ‘positions’
2) ../lib/hash/rte_cuckoo_hash.c:2478:9
: warning: ISO C90 forbids variable length array ‘positions’
Both rte_hash_lookup_bulk_data() and
rte_hash_lookup_with_hash
As per guidance technical board meeting 2024/04/17. This series
removes the use of VLAs from code built for Windows for all 3
toolchains. If there are additional opportunities to convert VLAs
to regular C arrays please provide the details for incorporation
into the series.
MSVC does not support VL
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Acked-by: Bruce Richardson
---
drivers/common/idpf/idpf_common_rxtx.c
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test/test.c | 2 +-
app/test/test_cmdline_s
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
app/test-pmd/cmdline.c | 2 +-
app/test-pmd/cmdline_flow.c | 15
From: Konstantin Ananyev
gro_vxlan_tcp4_tbl_timeout_flush() is called without taking into account
that first entries in pkts[] can be already occupied by
un-processed packets.
Fixes: 74080d7dcf31 ("gro: support IPv6 for TCP")
Cc: sta...@dpdk.org
Signed-off-by: Konstantin Ananyev
Acked-by: Ferr
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Andre Muezerie
---
app/test-pmd/shared_rxq_fwd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
Reviewed-by: Bruce Richardson
---
drivers/net/i40e/i40e_testpmd.c | 5 ++-
MSVC does not support VLAs, replace VLAs with standard C arrays.
Signed-off-by: Andre Muezerie
---
lib/hash/rte_thash_gf2_poly_math.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/hash/rte_thash_gf2_poly_math.c
b/lib/hash/rte_thash_gf2_poly_math.c
index 1c62974e
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/common/mlx5/mlx5_common.h| 4 ++--
drivers/common/mlx5/mlx
From: Tyler Retzlaff
MSVC does not support optional C11 VLAs. When building for Windows
enable -Wvla so that mingw and clang also fail if a VLA is used.
Signed-off-by: Tyler Retzlaff
---
config/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/config/meson.build b/config/meso
From: Tyler Retzlaff
MSVC does not support VLAs, replace VLAs with standard C arrays
or alloca(). alloca() is available for all toolchain/platform
combinations officially supported by DPDK.
Signed-off-by: Tyler Retzlaff
---
drivers/net/mlx5/mlx5.c | 5 ++---
drivers/net/mlx5/mlx5_flow.c |
1 - 100 of 147 matches
Mail list logo
