[PATCH v2 09/26] net/ntnic: improve logging format specifiers

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Updated logging format specifiers for better consistency and to match the expected data types Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 7 +- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 2 +- .../link_agx_100g/nt4ga_agx_l

[PATCH v2 13/26] net/ntnic: add error logging for hsh

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Enhance error logging in hw_db_inline_hsh_deref function to ensure proper handling of HSH RCP preset failures. Signed-off-by: Danylo Vodopianov --- .../nthw/flow_api/profile_inline/flow_api_hw_db_inline.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

[PATCH v2 22/26] net/ntnic: remove unnecessary void cast

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov There is no need to cast memset to void. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nim/i2c_nim.c | 2 +- drivers/net/ntnic/nthw/flow_filter/flow_nthw_cat.c| 4 ++-- drivers/net/ntnic/nthw/flow_filter/flow_nthw_csu.c| 4 ++-- dr

[PATCH v2 05/26] net/ntnic: include all queues into statistics

2025-05-05 Thread Oleksandr Kolomeiets
Queues with indices greater than or equal to RTE_ETHDEV_QUEUE_STAT_CNTRS are ignored when calculating per-queue statistics, however they should be taken into account for calculating the total. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/ntnic_ethdev.c | 32 ++---

[PATCH v2 01/26] net/ntnic: remove usage of the variable-length arrays

2025-05-05 Thread Oleksandr Kolomeiets
VLAs with known upper limits are replaced with fixed-length arrays. In case an upper limit of an array cannot be known in advance, the memory for such an array is allocated dynamically using alloca. In comparison to malloc family of functions, the alloca executes faster due to working directly with

[PATCH v2 00/26] net/ntnic: fixes and improvements

2025-05-05 Thread Oleksandr Kolomeiets
* Fix issues detected by static code analyzers CoverityScan and PVS studio - PVS studio: https://inbox.dpdk.org/dev/caoavg170qdnxdfstjcvjhzafy-fs8e98xpba3q8u--wx+k_...@mail.gmail.com/1-a.txt * Fix requested issues mentioned here https://inbox.dpdk.org/dev/20250222134157.73763253@hermes.local/

[PATCH v2 08/26] net/ntnic: correct misspelled variable names

2025-05-05 Thread Oleksandr Kolomeiets
Rename alloced_size to allocated_size. Rename num_queues_alloced to num_queues_allocated. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h | 2 +- .../net/ntnic/nthw/flow_api/hw_mod/hw_mod_backend.c | 4 ++-- drivers/net/ntnic/ntnic_ethdev.c

[PATCH v2 07/26] net/ntnic: apply packing to the structure

2025-05-05 Thread Oleksandr Kolomeiets
The structure virtq_desc should not contain any paddings, so it has been wrapped with __rte_packed_begin and __rte_packed_end macros. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/ntnic_virt_queue.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v2 10/26] net/ntnic: remove usless expressions

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov simplify conditionals and remove redundant checks Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 3 +- .../link_agx_100g/nt4ga_agx_link_100g.c | 16 +-- drivers/net/ntnic/nim/i2c_nim.c | 3 +- .../core/

[PATCH v2 24/26] net/ntnic: add null verification

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Add verification on NULL for variables before use it in the memset. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 3 +++ .../link_mgmt/link_100g/nt4ga_link_100g.c | 2 ++ .../net/ntnic/nthw/flow_api/flow_id_table.c| 3

[PATCH v2 21/26] net/ntnic: avoid divide by zero

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Fix CID issue 457736 divide by 0. It was avoided by adding adittional checking on the return value for function. Fixes: effa04693274 ("net/ntnic: add statistics") Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/stat/nthw_stat.c | 4 1 file changed, 4 i

[PATCH v2 20/26] net/ntnic: rework array usage

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Array usage made more explicitly, avoid pointer arithmetic. Signed-off-by: Danylo Vodopianov --- .../ntnic/link_mgmt/link_agx_100g/nt4ga_agx_link_100g.c | 8 drivers/net/ntnic/ntnic_ethdev.c | 2 +- 2 files changed, 5 insertions(+), 5

[PATCH v2 04/26] net/ntnic: remove extra memset

2025-05-05 Thread Oleksandr Kolomeiets
The function rte_eth_stats_get fills the structure stats with zeroes before it eventually calls dpdk_stats_collect. That makes the call to memset inside dpdk_stats_collect redundant. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/ntnic_ethdev.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH v2 11/26] net/ntnic: remove unused code

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Remove unused CRC calculation and simplify AVR probe logging. The condition is always false. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/core/nthw_fpga.c | 299 +--- 1 file changed, 11 insertions(+), 288 deletions(-) diff --git a/dri

[PATCH v2 03/26] net/ntnic: replace pragma pack with DPDK defined macros

2025-05-05 Thread Oleksandr Kolomeiets
The macros __rte_packed_begin and __rte_packed_end are used instead of #pragma pack(1) when structure or union memory should be minimized. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_flm_v25.h | 14 ++ drivers/net/ntnic/nthw/core/nthw_spi_v3.c | 15 +

[PATCH v2 14/26] net/ntnic: add explicitly specificator

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Add unsigned long long type to the value to ensure that the value 1 is explicitly treated as a 64-bit unsigned integer. Signed-off-by: Danylo Vodopianov --- .../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2 18/26] net/ntnic: add return value check

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Add separate return value verification and logs for function. Signed-off-by: Danylo Vodopianov --- .../nthw/core/nt200a0x/reset/nthw_fpga_rst_nt200a0x.c| 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ntnic/nthw/core/nt200a0x/reset/nthw_fpga

[PATCH v2 15/26] net/ntnic: add handle memory allocation failures

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Added checks for `calloc` return values to handle memory allocation failures. Check for null in rpp_lr_nthw_init Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/flow_api/flow_group.c | 17 ++-- drivers/net/ntnic/nthw/flow_api/flow_km.c | 4 +++

[PATCH v2 19/26] net/ntnic: remove redundant assignments and branching

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Remove double if statement branching as far as it has the same fillings. Signed-off-by: Danylo Vodopianov --- .../link_agx_100g/nt4ga_agx_link_100g.c | 22 ++- .../core/nt200a0x/reset/nthw_fpga_rst9563.c | 1 - drivers/net/ntnic/nthw/nthw_rac.c

[PATCH v2 06/26] net/ntnic: avoid misleading variable names

2025-05-05 Thread Oleksandr Kolomeiets
In the context of the NTNIC driver, the variables named if_index stand for the index of the PHY. However, the term if_index could also refer to the interface index assigned by the OS. To mitigate potential confusion these variables were renamed. Signed-off-by: Oleksandr Kolomeiets --- drivers/ne

[PATCH v2 25/26] net/ntnic: avoid possible deadlock

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Sometimes during high flow learn performance two threads could cause deadlock using queue and mutex. learn_ignored variable sets when flow learn and gets when flow removes. Hence, learn_ignore should not be protected as far as two thread could not access to the same flow

[PATCH v2 23/26] net/ntnic: remove unnecessary memset

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Calling memset before free() has no effect and will be flagged by security parsing tools as a potential bug. None of these data structures have sensitive information. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nthw/core/nthw_hif.c | 5 + drivers/

[PATCH v2 02/26] net/ntnic: handle string truncations when using strlcpy

2025-05-05 Thread Oleksandr Kolomeiets
While strlcpy prevents out-of-bounds access, it allows bugs to remain unnoticed. If unexcepted truncation took place, the respective warning message is emitted. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/ntnic_xstats/ntnic_xstats.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH v2 26/26] net/ntnic: fix operation with rte ring queue

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov User should call rte_ring_dequeue_zc_elem_finish to complete the dequeue operation. However this complete step if record absent. This change rework queue read operation. Fixes: 96c8249be53e ("net/ntnic: learn flow queue handling") Signed-off-by: Danylo Vodopianov ---

[PATCH v2 16/26] net/ntnic: remove redundant initialization

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Some variables set twice in the code. Fix host side FEC enablement Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/nim/i2c_nim.c | 2 +- drivers/net/ntnic/nthw/core/nthw_phy_tile.c | 1 - drivers/net/ntnic/ntnic_vfio.c | 1 - 3 files chan

[PATCH v2 12/26] net/ntnic: remove usless part of conditional expression

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov The conditional expressions that always has unchanging state was removed Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c | 2 +- drivers/net/ntnic/nthw/core/nthw_fpga.c | 4 +--- 2 files changed, 2 insertions(

[PATCH v2 17/26] net/ntnic: enhance null checks and assertions

2025-05-05 Thread Oleksandr Kolomeiets
From: Danylo Vodopianov Avoid usage before check Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 4 ++-- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 4 ++-- .../net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c | 2 +- .../link_mgmt/l

Re: [PATCH v2] net: fix GTP packet parsing

2025-05-05 Thread huangdengdui
Hi, Jiale, this patch can solve the issues[1] you reported. Can you review this patch and add a Tested-by tag? [1] https://bugs.dpdk.org/show_bug.cgi?id=1672 On 2025/4/17 20:37, Dengdui Huang wrote: > After parsing the GTP packet header, the next protocol type should > be converted from RTE_GTP_

RE: [PATCH] net/mlx5/hws: fix send queue drain on FW WQE destroy

2025-05-05 Thread Bing Zhao
Hi, > -Original Message- > From: Maayan Kashani > Sent: Sunday, April 27, 2025 7:28 PM > To: dev@dpdk.org > Cc: Maayan Kashani ; Dariusz Sosnowski > ; Raslan Darawsheh ; > sta...@dpdk.org; Alex Vesker ; Slava Ovsiienko > ; Bing Zhao ; Ori Kam > ; Suanming Mou ; Matan Azrad > > Subject: [

Polling for patchseries in DPDK - the /series/ and /events/ endpoints

2025-05-05 Thread Patrick Robb
There was some discussion at last week's CI meeting about usage of the Patchwork /events/ endpoint for polling for patches, and issues with that process. Here is a relevant blurb, explaining some issues Aaron has run into using the dpdk-ci repo "poll-pw.sh" shell script: * Discus

[PATCH] net/mlx5: fix transceiver warning when not exist

2025-05-05 Thread Yogev Chaimovich
0001-net-mlx5-fix-transceiver-warning-when-not-exist.patch Description: 0001-net-mlx5-fix-transceiver-warning-when-not-exist.patch

[RFC 09/18] net/hinic3: add a NIC business configuration module

2025-05-05 Thread Feifei Wang
From: Yi Chen The items of configurations and queries for NIC business include MAC, VLAN, MTU, RSS and so on. These configurations and queries are handled by mgmt module. This patch introduces related data structures and function codes. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by:

[RFC 10/18] net/hinic3: add context and work queue support

2025-05-05 Thread Feifei Wang
From: Xin Wang Work queue is used for cmdq and tx/rx buff description. Nic business needs to configure cmdq context and txq/rxq context. This patch adds data structures and function codes for work queue and context. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- dr

[RFC 15/18] net/hinic3: add MML and EEPROM access feature

2025-05-05 Thread Feifei Wang
From: Xin Wang Add man-machine language support and implements the get eeprom method. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c| 13 + drivers/net/hinic3/mml/hinic3_dbg.c | 171 + drivers/net/hinic3/mml/hin

[RFC 08/18] net/hinic3: add module about hardware operation

2025-05-05 Thread Feifei Wang
From: Yi Chen Add code and data structure for hardware operation, including configuration, query, initialization and release. Signed-off-by: Yi Chen Signed-off-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/base/hinic3_hw_cfg.c | 240 ++ drivers/net/hinic3/base/hinic3_

[RFC 11/18] net/hinic3: add a mailbox communication module

2025-05-05 Thread Feifei Wang
From: Yi Chen This patch adds support for mailbox of hinic3 PMD driver, mailbox is used for communication between PF/VF driver and MPU. This patch provides mailbox-related data structures and functional code. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/n

[RFC 14/18] net/hinic3: add Rx/Tx functions

2025-05-05 Thread Feifei Wang
From: Feifei Wang This patch add package sending and receiving function codes. Signed-off-by: Feifei Wang Signed-off-by: Yi Chen Reviewed-by: Xin Wang --- drivers/net/hinic3/hinic3_ethdev.c | 9 +- drivers/net/hinic3/hinic3_rx.c | 301 +++- drivers/net/hinic3/hinic3_tx.c |

[RFC 12/18] net/hinic3: add device initailization

2025-05-05 Thread Feifei Wang
From: Xin Wang This patch contains data structures and function codes related to device initialization. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c | 514 + drivers/net/hinic3/hinic3_ethdev.h | 119 +

[RFC 11/18] net/hinic3: add a mailbox communication module

2025-05-05 Thread Feifei Wang
From: Yi Chen This patch adds support for mailbox of hinic3 PMD driver, mailbox is used for communication between PF/VF driver and MPU. This patch provides mailbox-related data structures and functional code. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/n

[RFC 01/18] net/hinic3: add intro doc for hinic3

2025-05-05 Thread Feifei Wang
From: Feifei Wang This patch adds some basic files to describe the hinic3 driver. Signed-off-by: Feifei Wang Signed-off-by: Yi Chen Reviewed-by: Xin Wang --- .mailmap | 4 +- MAINTAINERS| 6 +++ doc/guides/nics/hinic3.rst

[RFC 00/18] add hinic3 PMD driver

2025-05-05 Thread Feifei Wang
*** BLURB HERE *** The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. Feifei Wang (3): net/hinic3: add intro doc for hinic3 net/hinic3: add dev ops net/hinic3: add Rx/Tx functions Xin Wang (7): net/hinic3

[RFC 10/18] net/hinic3: add context and work queue support

2025-05-05 Thread Feifei Wang
From: Xin Wang Work queue is used for cmdq and tx/rx buff description. Nic business needs to configure cmdq context and txq/rxq context. This patch adds data structures and function codes for work queue and context. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- dr

[RFC 17/18] net/hinic3: add FDIR flow control module

2025-05-05 Thread Feifei Wang
From: Yi Chen Added support for flow director filters, including ethertype, IPv4, IPv6, and tunnel VXLAN. In addition, user can add or delete filters. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/hinic3_ethdev.c | 82 ++ drivers/net/hinic3/hi

[RFC 15/18] net/hinic3: add MML and EEPROM access feature

2025-05-05 Thread Feifei Wang
From: Xin Wang Add man-machine language support and implements the get eeprom method. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c| 13 + drivers/net/hinic3/mml/hinic3_dbg.c | 171 + drivers/net/hinic3/mml/hin

[RFC 14/18] net/hinic3: add Rx/Tx functions

2025-05-05 Thread Feifei Wang
From: Feifei Wang This patch add package sending and receiving function codes. Signed-off-by: Feifei Wang Signed-off-by: Yi Chen Reviewed-by: Xin Wang --- drivers/net/hinic3/hinic3_ethdev.c | 9 +- drivers/net/hinic3/hinic3_rx.c | 301 +++- drivers/net/hinic3/hinic3_tx.c |

[RFC 12/18] net/hinic3: add device initailization

2025-05-05 Thread Feifei Wang
From: Xin Wang This patch contains data structures and function codes related to device initialization. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c | 514 + drivers/net/hinic3/hinic3_ethdev.h | 119 +

[RFC 16/18] net/hinic3: add RSS promiscuous ops

2025-05-05 Thread Feifei Wang
From: Xin Wang Add RSS and promiscuous ops related function codes. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c | 370 + drivers/net/hinic3/hinic3_ethdev.h | 31 +++ 2 files changed, 401 insertions(+

[RFC 18/18] drivers/net: add hinic3 PMD build and doc files

2025-05-05 Thread Feifei Wang
From: Yi Chen The meson.build file is added to this patch to enable the hinic3 compilation function. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- doc/guides/nics/features/hinic3.ini | 9 ++ drivers/net/hinic3/base/meson.build | 50 +++

[RFC 00/18] add hinic3 PMD driver

2025-05-05 Thread Feifei Wang
*** BLURB HERE *** The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. Feifei Wang (3): net/hinic3: add intro doc for hinic3 net/hinic3: add dev ops net/hinic3: add Rx/Tx functions Xin Wang (7): net/hinic3

Use external_buffer by ret_pktmbuf_attach on dpaa2 device

2025-05-05 Thread 段世博
Hello everyone, we want to use external_buffer on the dpaa2 nic, but when I use rte_pktmbuf_attach, the network card cannot read the content of external_buffer correctly. When I map this external_buffer through rte_fslmc_vfio_mem_dmamap (an internal function), the network card can read the data nor

[RFC 03/18] net/hinic3: add hardware interfaces of BAR operation

2025-05-05 Thread Feifei Wang
From: Yi Chen This patch adds some HW interfaces for bar operatioin interfaces, including: mapped bar address geeting, HW attributes getting, msi-x reg operation, function type getting and so on. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/bas

[RFC 04/18] net/hinic3: add support for cmdq mechanism

2025-05-05 Thread Feifei Wang
From: Xin Wang Micocode is named ucode in SP series NIC. Its main responsibility is data transmission and reception. But it can also handle some administration works. It uses cmdq mechanism. This patch introduces data structures, initialization, interfaces, and commands sending functions of cmdq.

[RFC 06/18] net/hinic3: add eq mechanism function code

2025-05-05 Thread Feifei Wang
From: Yi Chen Eqs include aeq and ceq. Aeq is a kind of queue for mgmt asynchronous message and mgmt command response message. This patch introduces data structures, initialization, and related interfaces about aeq. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- dr

[RFC 02/18] net/hinic3: add basic header files

2025-05-05 Thread Feifei Wang
From: Xin Wang Add HW registers definition header file for SP series NIC. Add some headers that define commands and basic defines for use in the code. Signed-off-by: Xin Wang Reviewed-by: Yi Chen Reviewed-by: Feifei Wang --- drivers/net/hinic3/base/hinic3_cmd.h| 231

[RFC 05/18] net/hinic3: add NIC event module

2025-05-05 Thread Feifei Wang
From: Xin Wang Currently, there are two types of events: pf/vf connection status and port information printing. This patch contains related data structures and function codes. Signed-off-by: Xin Wang Reviewed-by: Yi Chen Reviewed-by: Feifei Wang --- drivers/net/hinic3/base/hinic3_nic_event.c

[RFC 07/18] net/hinic3: add mgmt module function code

2025-05-05 Thread Feifei Wang
From: Yi Chen Mgmt module is a kind of administration module for the chip. It is responsible for handling administration command from host. It mainly uses aeq to implement. This patch adds related data structures, packaged interfaces and function codes. Signed-off-by: Yi Chen Reviewed-by: Xin W

[RFC 01/18] net/hinic3: add intro doc for hinic3

2025-05-05 Thread Feifei Wang
From: Feifei Wang This patch adds some basic files to describe the hinic3 driver. Signed-off-by: Feifei Wang Signed-off-by: Yi Chen Reviewed-by: Xin Wang --- .mailmap | 4 +- MAINTAINERS| 6 +++ doc/guides/nics/hinic3.rst

[RFC 17/18] net/hinic3: add FDIR flow control module

2025-05-05 Thread Feifei Wang
From: Yi Chen Added support for flow director filters, including ethertype, IPv4, IPv6, and tunnel VXLAN. In addition, user can add or delete filters. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- drivers/net/hinic3/hinic3_ethdev.c | 82 ++ drivers/net/hinic3/hi

[PATCH] bus/pci: introduce get_iova_mode for pci dev

2025-05-05 Thread Kyo Liu
I propose this patch for DPDK to enable coexistence between DPDK and kernel drivers for regular NICs.This solution requires adding a new pci_ops in rte_pci_driver, through which DPDK will retrieve the required IOVA mode from the vendor driver. This mechanism is necessary to handle different IOMMU c

[RFC 16/18] net/hinic3: add RSS promiscuous ops

2025-05-05 Thread Feifei Wang
From: Xin Wang Add RSS and promiscuous ops related function codes. Signed-off-by: Xin Wang Reviewed-by: Feifei Wang Reviewed-by: Yi Chen --- drivers/net/hinic3/hinic3_ethdev.c | 370 + drivers/net/hinic3/hinic3_ethdev.h | 31 +++ 2 files changed, 401 insertions(+

Addressing ninja build error message

2025-05-05 Thread vivekanandi
Hello, My name is Vivek. I'm a Computer Science major from Canada. I was trying to install DPDK but encountered this error. I am familiar with BPF programming so tried to look into the compat.h file but the build/af_xdp directory was empty after I got the error message. I've attached a txt file th

[PATCH 1/1] net/nbl add doc and minimun nbl build framework

2025-05-05 Thread Kyo Liu
Signed-off-by: Kyo Liu --- .mailmap | 5 MAINTAINERS | 9 +++ doc/guides/nics/features/nbl.ini | 23 + doc/guides/nics/index.rst| 1 + doc/guides/nics/nbl.rst | 42 drivers/n

[Bug Report] KNI Module Causes Loopback Interface to Have Incorrect ifindex in Linux 5.4.46

2025-05-05 Thread nan he
Dear DPDK Developers, I am reporting an issue encountered in an environment running Linux kernel version 5.4.46 with DPDK 19.11. When attempting to run Docker containers in bridge mode, the container creation fails consistently. The kmsg indicate a crash during the initialization of the loopback d

[RFC 18/18] drivers/net: add hinic3 PMD build and doc files

2025-05-05 Thread Feifei Wang
From: Yi Chen The meson.build file is added to this patch to enable the hinic3 compilation function. Signed-off-by: Yi Chen Reviewed-by: Xin Wang Reviewed-by: Feifei Wang --- doc/guides/nics/features/hinic3.ini | 9 ++ drivers/net/hinic3/base/meson.build | 50 +++

[dpdk-dev] Regarding HQOS with run-to-completion Model

2025-05-05 Thread farooq basha
Hello DevTeam, I am planning to use DPDK HQOS for Traffic shaping with a run-to-completion Model. While I was reading the dpdk-qos document, I came across the following statement. "*Running enqueue and dequeue operations for the same output port from different cores is likely to cause signifi

[PATCH 0/1] unresolved symbol mlx5_geneve_tlv_parser_create

2025-05-05 Thread Andre Muezerie
When compiling DPDK with mlx5 using clang on Windows with "debug" buildtype the error below is hit: net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol mlx5_geneve_tlv_parser_create referenced in function flow_dv_discover_priorities drivers\rte_net_mlx5-25.dll : fatal e

[PATCH 1/1] net/mlx5: unresolved symbol mlx5_geneve_tlv_parser_create

2025-05-05 Thread Andre Muezerie
When compiling DPDK with mlx5 using clang on Windows with "debug" buildtype the error below is hit: net_mlx5_mlx5_flow_dv.c.obj : error LNK2019: unresolved external symbol mlx5_geneve_tlv_parser_create referenced in function flow_dv_discover_priorities drivers\rte_net_mlx5-25.dll : fatal e

[PATCH] doc: update parameters to use for mlx5 on Windows

2025-05-05 Thread Andre Muezerie
The linker parameters to use with MSVC and Clang differ. Showing explicitly what to use with each in the documentation. Signed-off-by: Andre Muezerie --- doc/guides/platform/mlx5.rst | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/doc/guides/platform/mlx

Re: [PATCH v2 2/2] crypto/ipsec_mb: fix QP release in secondary

2025-05-05 Thread David Marchand
Hello, On Thu, Apr 24, 2025 at 4:26 PM Yang Ming wrote: > > Hi, > > On 2025/4/7 13:25, Yang Ming wrote: > > From: myang > > > > When a secondary process tries to release a queue pair (QP) that > > does not belong to it, error logs occur: > > CRYPTODEV: ipsec_mb_ipc_request() line 373: Unable to

Re: [PATCH 1/1] buildtools: avoid break due to failure to cleanup temporary directory

2025-05-05 Thread Dmitry Kozlyuk
Hi Andre, On 05.05.2025 22:46, Andre Muezerie wrote: When compiling drivers on Windows, instances have been seen where a temporary directory fails to get cleaned up due to ERROR_SHARING_VIOLATION (32). Code inspection did not reveal problems with the DPDK code and scripts, and this issue was on

[PATCH] eal: add asprintf() function for Windows

2025-05-05 Thread Andre Muezerie
The asprintf function is not part of the C standard library but is a GNU extension commonly available in Unix-like systems. It dynamically allocates memory to store the formatted output string, similar to sprintf, but avoids buffer overflow issues by automatically sizing the buffer. Instead of rew

Re: [PATCH 1/1] buildtools: avoid break due to failure to cleanup temporary directory

2025-05-05 Thread Andre Muezerie
On Mon, May 05, 2025 at 12:46:45PM -0700, Andre Muezerie wrote: > When compiling drivers on Windows, instances have been seen where a > temporary directory fails to get cleaned up due to > ERROR_SHARING_VIOLATION (32). > > Code inspection did not reveal problems with the DPDK code and scripts, > a

[PATCH] net/mlx5: use portable version of __builtin_ffsl

2025-05-05 Thread Andre Muezerie
Builtin __builtin_ffsl is not available with MSVC therefore a portable replacement should be used. Function rte_ffs32 is already available in eal and should be used instead. Signed-off-by: Andre Muezerie --- drivers/net/mlx5/mlx5_tx.c| 4 ++-- drivers/net/mlx5/mlx5_utils.c | 2 +- 2 files c

[PATCH] net/mlx5: declare size of rte_v128u32_t

2025-05-05 Thread Andre Muezerie
When compiling with MSVC the error below is hit: drivers\net\mlx5\mlx5_tx.h(1148): error C2065: 'rte_v128u32_t': undeclared identifier Turns out that with MSVC the data type rte_v128u32_t is not used, but its size needs to be known. This patch defines a macro to store that size and replaces i

[PATCH] net/mlx5: avoid implicit conversion to 64 bits

2025-05-05 Thread Andre Muezerie
When compiling with MSVC, errors like the one below pop up: ../drivers/crypto/mlx5/mlx5_crypto_xts.c(488): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) Depending on the situation, the fix is to do a 64-bit shift, or be explicit a

RE: [PATCH v6 0/2] node: add mbuf dynamic field for nodes

2025-05-05 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Monday, April 28, 2025 4:07 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v6 0/2] node: add mbuf dynamic field

[PATCH 1/1] buildtools: avoid break due to failure to cleanup temporary directory

2025-05-05 Thread Andre Muezerie
When compiling drivers on Windows, instances have been seen where a temporary directory fails to get cleaned up due to ERROR_SHARING_VIOLATION (32). Code inspection did not reveal problems with the DPDK code and scripts, and this issue was only seen on Windows. Adding a 1 second sleep before clean

[PATCH 0/1] avoid break due to failure to cleanup temporary directory

2025-05-05 Thread Andre Muezerie
When compiling drivers on Windows, instances have been seen where a temporary directory fails to get cleaned up due to ERROR_SHARING_VIOLATION (32). Code inspection did not reveal problems with the DPDK code and scripts, and this issue was only seen on Windows. The proposed fix adds a mitigation

[PATCH] eal: add getline() function for Windows

2025-05-05 Thread Andre Muezerie
Existing DPDK code uses getline(), which is a POSIX function and is not available in the Windows APIs. Instead of rewriting it or coming up with some other replacement, this patch makes use of the implementation provided by NetBSD to make it possible to compile code dependent on getline on Windows

Re: |FAILURE| pw153190 [PATCH V3] Add new tracepoint function for type time_t

2025-05-05 Thread David Marchand
Hello, On Wed, Apr 30, 2025 at 7:21 AM Changqing Li wrote: > I'm new to this project, and have no clue about the failure, could experts > at this project provide > > some help about the following failure? > > + sudo babeltrace > /home/runner/work/dpdk/dpdk/build/app/test/suites/rte-2025-04-30-

Re: Addressing ninja build error message

2025-05-05 Thread David Marchand
Hello, On Mon, May 5, 2025 at 2:55 PM vivekanandi wrote: > > Hello, > My name is Vivek. I'm a Computer Science major from Canada. > > I was trying to install DPDK but encountered this error. I am familiar with > BPF programming so tried to look into the compat.h file but the build/af_xdp > dire

Re: Regarding Mellanox bifurcated driver on Azure

2025-05-05 Thread Prashant Upadhyaya
On Wed, 30 Apr 2025 at 22:21, Stephen Hemminger wrote: > On Wed, 30 Apr 2025 22:00:29 +0530 > Prashant Upadhyaya wrote: > > > On Wed, 30 Apr 2025 at 19:58, Stephen Hemminger < > step...@networkplumber.org> > > wrote: > > > > > On Wed, 30 Apr 2025 13:00:53 +0530 > > > Prashant Upadhyaya wrote: >

[PATCH] common/mlx5: use intrinsics instead of inline assembly

2025-05-05 Thread Andre Muezerie
When compiling with MSVC the errors below are hit because msvc does not support inline assembly: 1) ../drivers/common/mlx5/mlx5_common.c(86): warning C4013: '__asm__' undefined; assuming extern returning int ../drivers/common/mlx5/mlx5_common.c(87): error C2143: syntax error: missing ')'