Re: [RFC PATCH 0/5] Introduce mempool object new debug capabilities

2025-06-16 Thread Stephen Hemminger
On Mon, 16 Jun 2025 10:29:05 +0300 Shani Peretz wrote: > This feature is designed to monitor the lifecycle of mempool objects > as they move between the application and the PMD. > > It will allow us to track the operations and transitions of each mempool > object throughout the system, helping i

[PATCH v2] buildtools: allow a different minimum meson version for Windows

2025-06-16 Thread Andre Muezerie
There is a minimum meson version specified in the DPDK meson project section, which has been documented. This string is parsed by buildtools\get-min-meson-version.py and this information is used by lab automation to install the corresponding meson package on the build machine. Turns out that the m

[PATCH v2 0/2] Latencystats optimizations and fix

2025-06-16 Thread Stephen Hemminger
After investigating latencystat test failures, discovered it poorly designed to handle bursts and multiple queues. v2 - need atomic to be safe on non ordered platforms Stephen Hemminger (2): latencystats: fix receive sample MP issues latencystats: optimize locking on transmit lib/latenc

[PATCH v2 1/2] latencystats: fix receive sample MP issues

2025-06-16 Thread Stephen Hemminger
The receive callback was not safe with multiple queues. If one receive queue callback decides to take a sample it needs to add that sample and do atomic update to the previous TSC sample value. Add a new lock for that. Optimize the check for when to take sample so that it only needs to lock when l

[PATCH v2 2/2] latencystats: optimize locking on transmit

2025-06-16 Thread Stephen Hemminger
If transmit callback is called, and there are no packets in the burst with timestamp set, then the expensive operations of locking and accessing TSC can be skipped. Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 17 + 1 file changed, 13 insertions(+),

DPDK libs as one big shared object

2025-06-16 Thread Morten Brørup
Why are we still building one .so file per DPDK library, instead of just building one big dpdk.so for all DPDK libraries? I think it's legacy from when DPDK libraries were versioned individually, and thus not relevant anymore. Wouldn't building one big dpdk.so eliminate the problems with circula

Re: [PATCH] doc: elaborate on per test suite configuration dts docs

2025-06-16 Thread Luca Vizzarro
Agree with Dean's changes. Also the start marker is broken, but can easily be added. Reviewed-by: Luca Vizzarro

[PATCH v2 12/16] net/nbl: add nbl device rxtx queue setup and release ops

2025-06-16 Thread dimon.zhao
Implement NBL device Rx and Tx queue setup & release functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 81 + .../nbl/nbl_hw/nbl_hw_leonis/nbl_res_leonis.c | 2 + drivers/net/nbl/nbl_hw/nbl_resource.h | 99 ++ drivers/net/nbl/nbl_hw/nbl_tx

[PATCH v2 14/16] net/nbl: add nbl device Tx and Rx burst

2025-06-16 Thread dimon.zhao
Implement NBL device Tx and Rx burst Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 108 +- drivers/net/nbl/nbl_dev/nbl_dev.h | 5 + drivers/net/nbl/nbl_dispatch.c| 62 drivers/net/nbl/nbl_ethdev.c | 7 + d

[PATCH v2 08/16] net/nbl: add complete device init and uninit functionality

2025-06-16 Thread dimon.zhao
NBL device is a concept of low level device which used to manage hw resource and to interact with fw Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_core.c| 8 +- drivers/net/nbl/nbl_core.h| 7 + drivers/net/nbl/nbl_dev/nbl_dev.c | 248 ++

[PATCH v2 09/16] net/nbl: add UIO and VFIO mode for nbl

2025-06-16 Thread dimon.zhao
NBL device support UIO/VFIO Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 1 + drivers/net/nbl/nbl_common/nbl_userdev.c | 24 +++ drivers/net/nbl/nbl_common/nbl_userdev.h | 10 .../nbl_hw_leonis/nbl_phy_leonis_snic.c | 7

[PATCH v2 10/16] net/nbl: add nbl coexistence mode for nbl

2025-06-16 Thread dimon.zhao
NBL device support coexistence mode Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_common/nbl_userdev.c | 729 +- drivers/net/nbl/nbl_common/nbl_userdev.h | 11 + drivers/net/nbl/nbl_core.c| 3 +- drivers/net/nbl/nbl_core.h|

[PATCH v2 15/16] net/nbl: add nbl device xstats and stats

2025-06-16 Thread dimon.zhao
Implement NBL device xstats and stats functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 148 +- drivers/net/nbl/nbl_dev/nbl_dev.h | 2 + drivers/net/nbl/nbl_dispatch.c| 111 + .../nbl/nbl_hw/nbl_hw_le

[PATCH v2 06/16] net/nbl: add Dispatch layer definitions and implementation

2025-06-16 Thread dimon.zhao
add Dispatch layer related definitions Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 1 + drivers/net/nbl/nbl_core.c| 7 + drivers/net/nbl/nbl_core.h| 4 + drivers/net/nbl/nbl_dispatch.c| 466 ++

[PATCH v2 07/16] net/nbl: add Dev layer definitions and implementation

2025-06-16 Thread dimon.zhao
add Dev layer related definitions Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 2 + drivers/net/nbl/nbl_core.c| 14 +- drivers/net/nbl/nbl_core.h| 16 ++ drivers/net/nbl/nbl_dev/nbl_dev.c | 200 ++ drive

[PATCH v2 00/16] NBL PMD for Nebulamatrix NICs

2025-06-16 Thread dimon.zhao
Features: - - MTU update - promisc mode set - xstats - Basic stats Support NICs: - - S1205CQ-A00CHT - S1105AS-A00CHT - S1055AS-A00CHT - S1052AS-A00CHT - S1051AS-A00CHT - S1045XS-A00CHT - S1205CQ-A00CSP - S1055AS-A00CSP - S1052AS-A00CSP Dimon Zhao (16): net/nbl: add doc and

[PATCH v2 11/16] net/nbl: add nbl ethdev configuration

2025-06-16 Thread dimon.zhao
NBL device add ethdev configuration Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 33 +-- drivers/net/nbl/nbl_include/nbl_include.h | 3 ++- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/net/nbl/nbl_dev/nbl_dev.c b/drive

[PATCH v2 04/16] net/nbl: add Channel layer definitions and implementation

2025-06-16 Thread dimon.zhao
add Channel layer related definitions and nbl_thread for mbx interact Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 3 + drivers/net/nbl/nbl_common/nbl_common.c | 47 ++ drivers/net/nbl/nbl_common/nbl_common.h | 10 + drivers/net/nbl/nbl_common/nbl

[PATCH v2 02/16] net/nbl: add simple probe/remove and log module

2025-06-16 Thread dimon.zhao
Our driver architecture is relatively complex because the code is highly reusable and designed to support multiple features.  For example, our driver can support open-source UIO/VFIO drivers while also coexisting with kernel drivers.  Additionally, the codebase supports multiple chip variants, each

[PATCH v2 05/16] net/nbl: add Resource layer definitions and implementation

2025-06-16 Thread dimon.zhao
add Resource layer related definitions Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 3 + drivers/net/nbl/nbl_core.c| 11 +- drivers/net/nbl/nbl_core.h| 4 + drivers/net/nbl/nbl_hw/nbl_channel.h | 2 +- .../n

[PATCH v2 03/16] net/nbl: add PHY layer definitions and implementation

2025-06-16 Thread dimon.zhao
add PHY layer related definitions and product ops Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 2 + drivers/net/nbl/nbl_core.c| 54 -- drivers/net/nbl/nbl_core.h| 30 +- drivers/net/nbl/nbl_ethdev.c

[PATCH v2 01/16] net/nbl: add doc and minimum nbl build framework

2025-06-16 Thread dimon.zhao
add minimum PMD code, doc and build infrastructure for nbl driver. Signed-off-by: dimon.zhao --- .mailmap | 5 MAINTAINERS | 9 +++ doc/guides/nics/features/nbl.ini | 9 +++ doc/guides/nics/index.rst| 1 + doc/guides/nics/nbl.

[PATCH v2 13/16] net/nbl: add nbl device start and stop ops

2025-06-16 Thread dimon.zhao
Implement NBL device start and stop functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 173 +- drivers/net/nbl/nbl_dispatch.c| 121 +++- drivers/net/nbl/nbl_ethdev.c | 5 + drivers/net/nbl/nbl_hw/nbl_

[PATCH v2 16/16] net/nbl: nbl device support set MTU and promisc

2025-06-16 Thread dimon.zhao
Implement NBL device set MTU and promisc functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_core.h| 2 + drivers/net/nbl/nbl_dev/nbl_dev.c | 60 +++ drivers/net/nbl/nbl_dev/nbl_dev.h | 4 +- drivers/net/nbl/nbl_dispatch.c

[PATCH] event/dlb2: add datapath support in secondary processes

2025-06-16 Thread Tirthendu Sarkar
The producer port and consumer queue addresses are configured during port setup. These are needed during enqueue and dequeue operations. For a eventdev that is configured in primary process, these need to be stored so that secondary processes can retrieve them for doing enueue and dequeue. Store p

[DPDK/ethdev Bug 1725] iavf pmd vlan Issue: dpdk-22.11.0

2025-06-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1725 Bug ID: 1725 Summary: iavf pmd vlan Issue: dpdk-22.11.0 Product: DPDK Version: 22.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major Priorit

Re: [PATCH 6/6] trace: add PMU

2025-06-16 Thread Bruce Richardson
On Mon, Jun 16, 2025 at 11:49:03AM +0200, Tomasz Duszynski wrote: > >16/06/2025 08:53, Tomasz Duszynski: > >> @@ -86,6 +86,7 @@ always_enable = [ > >> 'ring', > >> 'stack', > >> 'telemetry', > >> +'pmu', > >> ] > > > >This list is alphabetically sorted. > > Righ

[DPDK/core Bug 1724] test_pktmbuf_read_from_offset tests for incorrect overflow behaviour of rte_pktmbuf_read

2025-06-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1724 Bug ID: 1724 Summary: test_pktmbuf_read_from_offset tests for incorrect overflow behaviour of rte_pktmbuf_read Product: DPDK Version: unspecified Hardware: All OS:

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-16 Thread Dylan Schneider
Hello Stephen and Thomas, I uploaded this patch which says it has UT failures, but upon closer inspection, there aren't any signs of any tests failing. Can you please take a look? From: Schneide Sent: Friday, June 6, 2025 3:52 PM To: dev@dpdk.org ; Thomas Monjalo

RE: [PATCH v2 2/2] ethdev: remove callback checks from fast path

2025-06-16 Thread Morten Brørup
> From: Sunil Kumar Kori [mailto:sk...@marvell.com] > Sent: Monday, 16 June 2025 10.36 > > > > > From: Sunil Kumar Kori > > > > Sent: Monday, 12 May 2025 17.07 > > > > > > > > rte_eth_fp_ops contains ops for fast path APIs. Each API validates > > > > availability of callback and then invoke it. >

Re: [PATCH v2] dts: fix deterministic doc

2025-06-16 Thread Luca Vizzarro
Looks good. Reviewed-by: Luca Vizzarro

Re: [PATCH v1 3/3] net/zxdh: modify RSS related issues

2025-06-16 Thread Stephen Hemminger
On Sat, 7 Jun 2025 10:30:20 +0800 Junlong Wang wrote: > modify rss related issues in testing process. Better commit message please. Should have Fixes: tabg. > > Signed-off-by: Junlong Wang > --- > drivers/net/zxdh/zxdh_ethdev.c | 1 + > drivers/net/zxdh/zxdh_ethdev_ops.c | 66

Re: [PATCH] test/crypto: fix RSA decrypt op validation

2025-06-16 Thread Ji, Kai
Hi Gowrishankar, Thanks for reach out, I don't have those environments setup on my end, but Ubuntu 20.04 and RHEL8 are old but still common LTS packages. Are you able to dump the actual msg buffer ? It is highly possible relates to dsitro-specific patches ? Paddings ? Or crypto polices in RHE

[PATCH v2] dts: fix devbind initialization bug

2025-06-16 Thread Dean Marx
Rearrange the topology and DPDK setup/teardown calls during test runs to ensure the devbind script is not called while the DPDK tmp directory doesn't exist. Fixes: 4cef16f1f0a4 ("dts: improve port handling") Signed-off-by: Dean Marx --- dts/framework/test_run.py | 5 +++-- 1 file changed, 3 ins

Re: [PATCH v1 2/3] net/zxdh: modify some VLAN related issues

2025-06-16 Thread Stephen Hemminger
On Sat, 7 Jun 2025 10:30:19 +0800 Junlong Wang wrote: > modify some vlan related issues, and provided > vlan tpid set ops. > > Signed-off-by: Junlong Wang Best not to mix bug fix with new features. Bug fix should have Fixes: tag.

iavf pmd vlan Issue: dpdk-22.11.0

2025-06-16 Thread Amiya Ranjan Mohakud
Hi All, I'm encountering an issue with XL710 SR-IOV on KVM for VLAN packets with DPDK-22.11.0 version. *Issue Description:* I have disabled RTE_ETH_RX_OFFLOAD_VLAN_STRIP in rte_eth_conf and calling rte_eth_dev_configure and expecting my dpdk application to receive the packets with vlan tags. Late

Re: [PATCH v2] pcapng: allow any protocol link type for the interface block

2025-06-16 Thread Stephen Hemminger
On Mon, 9 Jun 2025 15:19:37 -0600 Schneide wrote: > From: Dylan Schneider > > Allow the user to specify protocol link type when creating pcapng files. > This change is needed to specify the protocol type in the pcapng file, > DLT_EN10MB specifies ethernet packets only. This will allow dissecto

Re: [PATCH] doc: fix missing feature matrix for event device

2025-06-16 Thread Jerin Jacob
On Mon, Jun 16, 2025 at 2:02 PM wrote: > > From: Pavan Nikhilesh > > Fix missing feature matrix addition for event device DMA and > vector adapters. > > Fixes: 66a30a29387a ("eventdev/dma: introduce DMA adapter") > Fixes: e12c3754da7a ("eventdev/vector: introduce event vector adapter") > > Signed

Re: [PATCH] buildtools: allow a different minimum meson version for Windows

2025-06-16 Thread Andre Muezerie
On Mon, Jun 16, 2025 at 09:27:00AM +0100, Bruce Richardson wrote: > On Mon, Jun 16, 2025 at 08:36:31AM +0100, Bruce Richardson wrote: > > On Fri, Jun 13, 2025 at 09:14:38AM -0700, Andre Muezerie wrote: > > > There is a minimum meson version specified in the DPDK meson project > > > section, which h

Re: [PATCH] buildtools: allow a different minimum meson version for Windows

2025-06-16 Thread Bruce Richardson
On Mon, Jun 16, 2025 at 08:09:44AM -0700, Andre Muezerie wrote: > On Mon, Jun 16, 2025 at 09:27:00AM +0100, Bruce Richardson wrote: > > On Mon, Jun 16, 2025 at 08:36:31AM +0100, Bruce Richardson wrote: > > > On Fri, Jun 13, 2025 at 09:14:38AM -0700, Andre Muezerie wrote: > > > > There is a minimum

Re: [PATCH v5] event/cnxk: add event vector adapter support

2025-06-16 Thread Jerin Jacob
On Sat, Jun 14, 2025 at 4:49 AM wrote: > > From: Pavan Nikhilesh > > Add event vector adapter support to CN20K event device. > > Signed-off-by: Pavan Nikhilesh > --- > v2 Changes: > - Add depends on series tag. > - Fix compilation. > v3 Changes: > - Rebase. > - Fix errors from check-meson.py

RE: [PATCH 6/6] trace: add PMU

2025-06-16 Thread Morten Brørup
> From: Tomasz Duszynski [mailto:tduszyn...@marvell.com] > Sent: Monday, 16 June 2025 11.49 > > >16/06/2025 08:53, Tomasz Duszynski: > >> @@ -86,6 +86,7 @@ always_enable = [ > >> 'ring', > >> 'stack', > >> 'telemetry', > >> +'pmu', > >> ] > > > >This list is alp

[PATCH v2] dts: fix devbind initialization bug

2025-06-16 Thread Dean Marx
Rearrange the topology and DPDK setup/teardown calls during test runs to ensure the devbind script is not called while the DPDK tmp directory doesn't exist. Fixes: 4cef16f1f0a4 ("dts: improve port handling") Signed-off-by: Dean Marx --- dts/framework/test_run.py | 5 +++-- 1 file changed, 3 ins

Re: [PATCH v2] buildtools: allow a different minimum meson version for Windows

2025-06-16 Thread Bruce Richardson
On Mon, Jun 16, 2025 at 08:31:11AM -0700, Andre Muezerie wrote: > There is a minimum meson version specified in the DPDK meson project > section, which has been documented. This string is parsed by > buildtools\get-min-meson-version.py and this information is used by > lab automation to install the

[PATCH v2 02/16] net/nbl: add simple probe/remove and log module

2025-06-16 Thread dimon.zhao
Our driver architecture is relatively complex because the code is highly reusable and designed to support multiple features.  For example, our driver can support open-source UIO/VFIO drivers while also coexisting with kernel drivers.  Additionally, the codebase supports multiple chip variants, each

[PATCH v2 04/16] net/nbl: add Channel layer definitions and implementation

2025-06-16 Thread dimon.zhao
add Channel layer related definitions and nbl_thread for mbx interact Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 3 + drivers/net/nbl/nbl_common/nbl_common.c | 47 ++ drivers/net/nbl/nbl_common/nbl_common.h | 10 + drivers/net/nbl/nbl_common/nbl

[PATCH v2 00/16] NBL PMD for Nebulamatrix NICs

2025-06-16 Thread dimon.zhao
Features: - - MTU update - promisc mode set - xstats - Basic stats Support NICs: - - S1205CQ-A00CHT - S1105AS-A00CHT - S1055AS-A00CHT - S1052AS-A00CHT - S1051AS-A00CHT - S1045XS-A00CHT - S1205CQ-A00CSP - S1055AS-A00CSP - S1052AS-A00CSP Dimon Zhao (16): net/nbl: add doc and

[PATCH v2 05/16] net/nbl: add Resource layer definitions and implementation

2025-06-16 Thread dimon.zhao
add Resource layer related definitions Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 3 + drivers/net/nbl/nbl_core.c| 11 +- drivers/net/nbl/nbl_core.h| 4 + drivers/net/nbl/nbl_hw/nbl_channel.h | 2 +- .../n

[PATCH v2 10/16] net/nbl: add nbl coexistence mode for nbl

2025-06-16 Thread dimon.zhao
NBL device support coexistence mode Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_common/nbl_userdev.c | 729 +- drivers/net/nbl/nbl_common/nbl_userdev.h | 11 + drivers/net/nbl/nbl_core.c| 3 +- drivers/net/nbl/nbl_core.h|

[PATCH v2 12/16] net/nbl: add nbl device rxtx queue setup and release ops

2025-06-16 Thread dimon.zhao
Implement NBL device Rx and Tx queue setup & release functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 81 + .../nbl/nbl_hw/nbl_hw_leonis/nbl_res_leonis.c | 2 + drivers/net/nbl/nbl_hw/nbl_resource.h | 99 ++ drivers/net/nbl/nbl_hw/nbl_tx

[PATCH v2 06/16] net/nbl: add Dispatch layer definitions and implementation

2025-06-16 Thread dimon.zhao
add Dispatch layer related definitions Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 1 + drivers/net/nbl/nbl_core.c| 7 + drivers/net/nbl/nbl_core.h| 4 + drivers/net/nbl/nbl_dispatch.c| 466 ++

[PATCH v2 07/16] net/nbl: add Dev layer definitions and implementation

2025-06-16 Thread dimon.zhao
add Dev layer related definitions Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 2 + drivers/net/nbl/nbl_core.c| 14 +- drivers/net/nbl/nbl_core.h| 16 ++ drivers/net/nbl/nbl_dev/nbl_dev.c | 200 ++ drive

[PATCH v2 08/16] net/nbl: add complete device init and uninit functionality

2025-06-16 Thread dimon.zhao
NBL device is a concept of low level device which used to manage hw resource and to interact with fw Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_core.c| 8 +- drivers/net/nbl/nbl_core.h| 7 + drivers/net/nbl/nbl_dev/nbl_dev.c | 248 ++

[PATCH v2 03/16] net/nbl: add PHY layer definitions and implementation

2025-06-16 Thread dimon.zhao
add PHY layer related definitions and product ops Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 2 + drivers/net/nbl/nbl_core.c| 54 -- drivers/net/nbl/nbl_core.h| 30 +- drivers/net/nbl/nbl_ethdev.c

[PATCH v2 01/16] net/nbl: add doc and minimum nbl build framework

2025-06-16 Thread dimon.zhao
add minimum PMD code, doc and build infrastructure for nbl driver. Signed-off-by: dimon.zhao --- .mailmap | 5 MAINTAINERS | 9 +++ doc/guides/nics/features/nbl.ini | 9 +++ doc/guides/nics/index.rst| 1 + doc/guides/nics/nbl.

[PATCH v2 09/16] net/nbl: add UIO and VFIO mode for nbl

2025-06-16 Thread dimon.zhao
NBL device support UIO/VFIO Signed-off-by: dimon.zhao --- drivers/net/nbl/meson.build | 1 + drivers/net/nbl/nbl_common/nbl_userdev.c | 24 +++ drivers/net/nbl/nbl_common/nbl_userdev.h | 10 .../nbl_hw_leonis/nbl_phy_leonis_snic.c | 7

[PATCH v2 15/16] net/nbl: add nbl device xstats and stats

2025-06-16 Thread dimon.zhao
Implement NBL device xstats and stats functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 148 +- drivers/net/nbl/nbl_dev/nbl_dev.h | 2 + drivers/net/nbl/nbl_dispatch.c| 111 + .../nbl/nbl_hw/nbl_hw_le

[PATCH v2 14/16] net/nbl: add nbl device Tx and Rx burst

2025-06-16 Thread dimon.zhao
Implement NBL device Tx and Rx burst Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 108 +- drivers/net/nbl/nbl_dev/nbl_dev.h | 5 + drivers/net/nbl/nbl_dispatch.c| 62 drivers/net/nbl/nbl_ethdev.c | 7 + d

[PATCH v2 16/16] net/nbl: nbl device support set MTU and promisc

2025-06-16 Thread dimon.zhao
Implement NBL device set MTU and promisc functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_core.h| 2 + drivers/net/nbl/nbl_dev/nbl_dev.c | 60 +++ drivers/net/nbl/nbl_dev/nbl_dev.h | 4 +- drivers/net/nbl/nbl_dispatch.c

[PATCH v2 13/16] net/nbl: add nbl device start and stop ops

2025-06-16 Thread dimon.zhao
Implement NBL device start and stop functions Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 173 +- drivers/net/nbl/nbl_dispatch.c| 121 +++- drivers/net/nbl/nbl_ethdev.c | 5 + drivers/net/nbl/nbl_hw/nbl_

[PATCH v2 11/16] net/nbl: add nbl ethdev configuration

2025-06-16 Thread dimon.zhao
NBL device add ethdev configuration Signed-off-by: dimon.zhao --- drivers/net/nbl/nbl_dev/nbl_dev.c | 33 +-- drivers/net/nbl/nbl_include/nbl_include.h | 3 ++- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/drivers/net/nbl/nbl_dev/nbl_dev.c b/drive

Re: [PATCH v2 5/5] net/zxdh: add support VLAN TPID set ops

2025-06-16 Thread zhoumin
Recheck-request: rebase=main, loongarch-compilation

RE: [PATCH] net/ice: fix DCF RSS hash update

2025-06-16 Thread Jiale, SongX
> -Original Message- > From: Mingjin Ye > Sent: Wednesday, June 11, 2025 5:51 PM > To: dev@dpdk.org > Cc: Ye, MingjinX ; sta...@dpdk.org; Richardson, > Bruce ; Burakov, Anatoly > > Subject: [PATCH] net/ice: fix DCF RSS hash update > > Get rss hash configuration, rss_hf is always the defa

Re: [PATCH v2] dts: fix devbind initialization bug

2025-06-16 Thread Patrick Robb
Recheck-request: iol-intel-Functional

[PATCH v2 1/5] net/zxdh: fix meson.build issus in compilation

2025-06-16 Thread Junlong Wang
fix meson.build issus in compilation, which caused the inability to compile in the arm64 environment. Fixes: 29e89288ff14 ("net/zxdh: add driver skeleton") Cc: sta...@dpdk.org Signed-off-by: Junlong Wang --- drivers/net/zxdh/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH v2 5/5] net/zxdh: add support VLAN TPID set ops

2025-06-16 Thread Junlong Wang
provided vlan tpid set ops implementations. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 1 + drivers/net/zxdh/zxdh_ethdev_ops.c | 37 ++ drivers/net/zxdh/zxdh_ethdev_ops.h | 1 + drivers/net/zxdh/zxdh_msg.c| 30 ++

[PATCH v2 4/5] net/zxdh: modify RSS related issues

2025-06-16 Thread Junlong Wang
modify rss related issues in testing process. Modify the comments of the maintainers. Fixes: 01acc23bab13 ("net/zxdh: optimize RSS operations") Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.h | 1 + drivers/net/zxdh/zxdh_ethdev_ops.c | 64 +++--- driv

[PATCH v2 3/5] net/zxdh: modify some VLAN related issues

2025-06-16 Thread Junlong Wang
modify some vlan related issues, which were discovered during the testing process. Fixes: b4f996b7fcf6 ("net/zxdh: optimize VLAN filter and offload") Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 9 - drivers/net/zxdh/zxdh_ethdev_ops.c | 4 ++-- drivers/net/zxdh

[PATCH v2 2/5] net/zxdh: modify some MAC config issues

2025-06-16 Thread Junlong Wang
modify some mac config issues, which were discovered during the testing process. Fixes: 1c8f68b64cfc ("net/zxdh: optimize MAC operations") Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 16 drivers/net/zxdh/zxdh_ethdev_ops.c | 34 +++- driv

[PATCH v2 00/16] NBL PMD for Nebulamatrix NICs

2025-06-16 Thread dimon.zhao
Features: - - MTU update - promisc mode set - xstats - Basic stats Support NICs: - - S1205CQ-A00CHT - S1105AS-A00CHT - S1055AS-A00CHT - S1052AS-A00CHT - S1051AS-A00CHT - S1045XS-A00CHT - S1205CQ-A00CSP - S1055AS-A00CSP - S1052AS-A00CSP Dimon Zhao (16): net/nbl: add doc and

Re: [PATCH v2] dts: fix devbind initialization bug

2025-06-16 Thread Patrick Robb
Thanks, looks good and I gave it a testrun on some XL710. I'm going to include the Slack summary of the bugs for clarity on the v2: Bugs: 1. topology setup is called before DPDKRuntimeEnvironment setup, but DPDKRuntimeEnvironment setup is required for topology setup, so the ordering needs to be r

Re: [PATCH v3 2/3] drivers/net: remove use of non-standard array range initialization

2025-06-16 Thread David Marchand
On Thu, Jun 12, 2025 at 4:18 PM Andre Muezerie wrote: > diff --git a/drivers/net/r8169/base/rtl8125a_mcu.c > b/drivers/net/r8169/base/rtl8125a_mcu.c > index 5a69b3e094..c9bf5fc6ad 100644 > --- a/drivers/net/r8169/base/rtl8125a_mcu.c > +++ b/drivers/net/r8169/base/rtl8125a_mcu.c > @@ -162,7 +162,1

Re: [PATCH] buildtools: allow a different minimum meson version for Windows

2025-06-16 Thread Bruce Richardson
On Fri, Jun 13, 2025 at 09:14:38AM -0700, Andre Muezerie wrote: > There is a minimum meson version specified in the DPDK meson project > section, which has been documented. This string is parsed by > buildtools\get-min-meson-version.py and this information is used by > lab automation to install the

[RFC PATCH 4/5] app/testpmd: add testpmd command to dump mempool history

2025-06-16 Thread Shani Peretz
dumps the mempool object history to console or to a file. The dump will contain: - Operation history for each mempool object - Summary and statistics about all mempool objects testpmd> dump_mempool_objects_history testpmd> dump_mempool_objects_history Signed-off-by: Shani Peretz --- app/test-

Re: [PATCH 6/6] trace: add PMU

2025-06-16 Thread Tomasz Duszynski
>16/06/2025 08:53, Tomasz Duszynski: >> @@ -86,6 +86,7 @@ always_enable = [ >> 'ring', >> 'stack', >> 'telemetry', >> +'pmu', >> ] > >This list is alphabetically sorted. Right, missed that. > >What is the justification for always enabling PMU lib? >Is it a good

[PATCH v1 1/1] malloc: handle invalid socket ID's when allocating

2025-06-16 Thread Anatoly Burakov
This issue was reported by static analysis. It is a false positive, because both `rte_socket_count` and `rte_socket_id_by_idx` only report information about physical sockets (so return value of -1 cannot happen, as we only get into this function when socket ID parameter is -1, which excludes extern

Re: [PATCH 3/6] lib/pmu: reimplement per-arch ops as callbacks

2025-06-16 Thread Tomasz Duszynski
>16/06/2025 08:53, Tomasz Duszynski: >> +static inline int >> +pmu_arch_init(void) >> +{ >> + if (arch_ops && arch_ops->init) >> + return arch_ops->init(); > >These are not boolean values, please compare explicitly with NULL. Okay.

Re: [PATCH 3/6] lib/pmu: reimplement per-arch ops as callbacks

2025-06-16 Thread Thomas Monjalon
16/06/2025 08:53, Tomasz Duszynski: > +static inline int > +pmu_arch_init(void) > +{ > + if (arch_ops && arch_ops->init) > + return arch_ops->init(); These are not boolean values, please compare explicitly with NULL.

[PATCH 1/3] argparse: track parsed arguments internally

2025-06-16 Thread Bruce Richardson
Change how the argparse library records what cmdline arguments have been seen or not; instead of setting an extra hidden flag in the user-passed argument structure, set a flag on an internally allocated and managed array. This means that the user parameters are not modified during the parse operati

[PATCH 2/3] argparse: mark parameter struct as const

2025-06-16 Thread Bruce Richardson
Now that argparse no longer modifies the parameters passed in by the user, mark them as explicitly "const" to provide that guarantee to the user. Signed-off-by: Bruce Richardson --- lib/argparse/rte_argparse.c | 40 ++--- lib/argparse/rte_argparse.h | 2 +- 2 fil

[PATCH 0/3] argparse: improve handling of multi-instance args

2025-06-16 Thread Bruce Richardson
Coverity (correctly) identified an issue[1] where, after the recent rework[2], the internal flag, used by argparse to track what arguments were previously encountered or not, was out of range for the type and no longer having any effect. Fixing this flag to be back into range then, somewhat surpris

Re: [PATCH 4/6] lib/pmu: use build system defined RTE_LIB_PMU macro

2025-06-16 Thread Tomasz Duszynski
>16/06/2025 08:53, Tomasz Duszynski: >> RTE_LIB_PMU is defined by build system automatically if DPDK is build >> for Linux. Otherwise it's missing. >> >> That said all cases where conditional compilation is required >> can be handled without introducing other macros. > >You don't need to know if it

[PATCH 3/3] test/argparse: add test for repeated arguments

2025-06-16 Thread Bruce Richardson
Add a test case to check that argparse throws an error when an argument is repeated on the commandline without the SUPPORT_MULTI flag. Also test that multiple arguments are correctly handled with the flag. Signed-off-by: Bruce Richardson --- app/test/test_argparse.c | 33

[RFC PATCH 2/5] drivers: add mempool history compilation flag

2025-06-16 Thread Shani Peretz
This commit adds a new compilation flag to enable mempool history recording in DPDK drivers. - Add support check for mempool history feature in each driver's meson - Skip building drivers that don't support mempool history when enabled Drivers must explicitly support this feature in their meson f

Re: [PATCH v2] dts: fix deterministic doc

2025-06-16 Thread Clemens Famulla-Conrad
> Thanks. This needs to pass the linter, see my suggestions below. Thanks for your suggestions! The CI is still failing[1] in "Windows Server 2022" => dpdk_msvc_compile I don't see a relation to my change and also other patches show the same issue[2]. Not sure if I need to do something, do you ha

[PATCH 0/2] fix parse tunnel packet ptyoe

2025-06-16 Thread Dengdui Huang
Dengdui Huang (2): net: fix parse the tunnel length of tunnel with UDP app/testpmd: fix obtain inner info of tunnel packet app/test-pmd/csumonly.c | 6 +++--- lib/net/rte_net.c | 4 lib/net/rte_net.h | 2 ++ 3 files changed, 9 insertions(+), 3 deletions(-) -- 2.33.0

[PATCH 1/2] net: fix parse the tunnel length of tunnel with UDP

2025-06-16 Thread Dengdui Huang
Currently, the tunnel length info is not available when get the tunnel packet type with UDP port. This patch adds the parsing of the tunnel length info. Additionally, adding comments for the inner_l2_len field and the tunnel_len field would help in understanding their. Fixes: 64ed7f854cf4 ("net:

[PATCH 2/2] app/testpmd: fix obtain inner info of tunnel packet

2025-06-16 Thread Dengdui Huang
The l2_len field of tunnel packets already includes the tunnel_len field. Additionally, the current offset used for the internal Ethernet header is incorrect. This patch fixes these issues. Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API") Cc: sta...@dpdk.org Signed-off-by: Dengdui

Re: [PATCH] buildtools: allow a different minimum meson version for Windows

2025-06-16 Thread Bruce Richardson
On Mon, Jun 16, 2025 at 08:36:31AM +0100, Bruce Richardson wrote: > On Fri, Jun 13, 2025 at 09:14:38AM -0700, Andre Muezerie wrote: > > There is a minimum meson version specified in the DPDK meson project > > section, which has been documented. This string is parsed by > > buildtools\get-min-meson-

RE: [PATCH v2 2/2] ethdev: remove callback checks from fast path

2025-06-16 Thread Sunil Kumar Kori
> > > From: Sunil Kumar Kori > > > Sent: Monday, 12 May 2025 17.07 > > > > > > rte_eth_fp_ops contains ops for fast path APIs. Each API validates > > > availability of callback and then invoke it. > > > These checks impact data path performace. > > > > Picking up the discussion from another thread

Re: [dpdk-dev v1] app/test-crypto-perf: remove unsupported test cases from perf json

2025-06-16 Thread Radu Nicolau
On 13-Jun-25 12:00 PM, Kai Ji wrote: Remove all unsupported test cases in json files Signed-off-by: Kai Ji --- Acked-by: Radu Nicolau

Re: [PATCH 4/6] lib/pmu: use build system defined RTE_LIB_PMU macro

2025-06-16 Thread Thomas Monjalon
16/06/2025 08:53, Tomasz Duszynski: > RTE_LIB_PMU is defined by build system automatically if DPDK is build > for Linux. Otherwise it's missing. > > That said all cases where conditional compilation is required > can be handled without introducing other macros. You don't need to know if it is com

Re: [PATCH 6/6] trace: add PMU

2025-06-16 Thread Thomas Monjalon
16/06/2025 08:53, Tomasz Duszynski: > @@ -86,6 +86,7 @@ always_enable = [ > 'ring', > 'stack', > 'telemetry', > +'pmu', > ] This list is alphabetically sorted. What is the justification for always enabling PMU lib? Is it a good idea to always enable an experime

Re: [PATCH v3 1/3] app/test: remove use of non-standard array range initialization

2025-06-16 Thread David Marchand
Adding Akhil and Kai Ji, On Thu, Jun 12, 2025 at 5:04 PM Bruce Richardson wrote: > > On Thu, Jun 12, 2025 at 07:17:20AM -0700, Andre Muezerie wrote: > > Array range initialization is non-standard and is not provided by > > all compilers. MSVC does not implement it and ends up emitting > > errors

[RFC PATCH 3/5] net/mlx5: mark an operation in mempool object's history

2025-06-16 Thread Shani Peretz
record operations on mempool objects when it is allocated and released inside the mlx5 PMD. Signed-off-by: Shani Peretz --- drivers/net/mlx5/mlx5_rx.c | 9 + drivers/net/mlx5/mlx5_rx.h | 2 ++ drivers/net/mlx5/mlx5_rxq.c | 9 +++-- drivers/net/mlx5/mlx5_rxtx_vec.c |

[RFC PATCH 1/5] mempool: record mempool objects operations history

2025-06-16 Thread Shani Peretz
This feature is designed to monitor the lifecycle of mempool objects as they move between the application and the PMD. It will allow us to track the operations and transitions of each mempool object throughout the system, helping in debugging and understanding objects flow. added a bitmap to the

[RFC PATCH 0/5] Introduce mempool object new debug capabilities

2025-06-16 Thread Shani Peretz
This feature is designed to monitor the lifecycle of mempool objects as they move between the application and the PMD. It will allow us to track the operations and transitions of each mempool object throughout the system, helping in debugging and understanding objects flow. The implementation in

[RFC PATCH 5/5] usertool: add a script to parse mempool history dump

2025-06-16 Thread Shani Peretz
Added a Python script that parses the history dump of a mempool object generated by rte_mempool_objects_dump and presents it in a human-readable format. If an operation ID is repeated, such as in the case of a double free, it will be highlighted in red and listed at the end of the file. Signed-of

Re: [PATCH] common/mlx5: fix dependency detection on Windows

2025-06-16 Thread Thomas Monjalon
This is the documentation to prepare mlx5 on Windows: https://docs.nvidia.com/networking/display/winof2v290/devx+interface 13/06/2025 23:48, Patrick Robb: > Good catch David on this system having a partial install of mlx5dev > header/library. > > NVIDIA guys, do any of you have a link to the cur