[dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-02 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero --- doc/guides/nics/features/nfp.ini | 25 + 1 file changed, 25 insertions(+) diff --git a/doc/guides/nics/features/nfp.ini b/doc/guides/nics/features/nfp.ini index d967151..dd78233 100644 --- a/doc/guides/nics/features/nfp.ini +++ b/doc

[dpdk-dev] [PATCH v3] nfp: report link speed using hardware info

2016-12-02 Thread Alejandro Lucero
Previous reported speed was hardcoded. v3: remove unsed macro v2: using RTE_DIM instead of own macro Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b

[dpdk-dev] About RTE_MAX_ETHPORT_QUEUE_STATS_MAPS

2014-08-21 Thread Alejandro Lucero
Hi, Documentation and header files describe stat_idx parameter for rte_eth_dev_set_tx_queue_stats_mapping and rte_eth_dev_set_rx_queue_stats_mapping as The value must be in the range [0, RTE_MAX_ETHPORT_QUEUE_STATS_MAPS - 1] I have not found a definition for RTE_MAX_ETHPORT_QUEUE_STATS_MAPS

Re: [dpdk-dev] [PATCH v3 25/29] net/nfp: use eal I/O device memory read/write API

2017-01-12 Thread Alejandro Lucero
gt; From: Santosh Shukla > > Replace the raw I/O device memory read/write access with eal > abstraction for I/O device memory read/write access to fix > portability issues across different architectures. > > CC: Alejandro Lucero > Signed-off-by: Santosh Shukla > Signed-off-b

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-12 Thread Alejandro Lucero
On Thu, Jan 12, 2017 at 11:55 AM, Ferruh Yigit wrote: > On 12/9/2016 8:54 AM, Gregory Etelson wrote: > > Hello, > > > > IGB_UIO driver does not close port PCI activities after DPDK process > exits. > > DPDK API provides rte_eth_dev_close() to manage port PCI, > > but it can be skipped if process

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-12 Thread Alejandro Lucero
On Thu, Jan 12, 2017 at 12:22 PM, Ferruh Yigit wrote: > On 1/12/2017 12:12 PM, Alejandro Lucero wrote: > > > > > > On Thu, Jan 12, 2017 at 11:55 AM, Ferruh Yigit > <mailto:ferruh.yi...@intel.com>> wrote: > > > > On 12/9/2016 8:

Re: [dpdk-dev] [PATCH v3 25/29] net/nfp: use eal I/O device memory read/write API

2017-01-13 Thread Alejandro Lucero
Thanks for that repo. It really makes things easier. I have run our NFP PMD unit tests using that repo, and this change seems to work without no problem. Thanks again. On Thu, Jan 12, 2017 at 1:40 PM, Jerin Jacob wrote: > On Thu, Jan 12, 2017 at 10:53:17AM +0000, Alejandro Lucero wr

Re: [dpdk-dev] [PATCH v3 25/29] net/nfp: use eal I/O device memory read/write API

2017-01-13 Thread Alejandro Lucero
On Fri, Jan 13, 2017 at 10:57 AM, Jerin Jacob < jerin.ja...@caviumnetworks.com> wrote: > On Fri, Jan 13, 2017 at 10:49:15AM +, Alejandro Lucero wrote: > > Thanks for that repo. It really makes things easier. > > > > I have run our NFP PMD unit tests using that repo,

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-13 Thread Alejandro Lucero
chain triggers. On Fri, Jan 13, 2017 at 5:33 AM, Tan, Jianfeng wrote: > > > > -Original Message- > > From: Yigit, Ferruh > > Sent: Friday, January 13, 2017 10:05 AM > > To: Tan, Jianfeng; Alejandro Lucero > > Cc: Gregory Etelson; dev; us...@dpdk.org >

Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

2017-01-13 Thread Alejandro Lucero
Acked. Thanks! On Thu, Jan 12, 2017 at 1:04 PM, Olivier Matz wrote: > Fix typo when checking that no Vlan offload flags are passed at port > initialization. > > By the way, also fix a typo in the log. > > Fixes: d4a27a3b092a ("nfp: add basic features") > > Signed-off-by: Olivier Matz > --- >

[dpdk-dev] [PATCH] config: build nfp pmd support by default

2017-01-13 Thread Alejandro Lucero
Because using a NFP PMD requires specific BSP installed, the PMD support was not the default option before. This was just for making people aware of such dependency, since there is no need for such a BSP for just compiling DPDK with NFP PMD support. Signed-off-by: Alejandro Lucero --- config

Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check

2017-01-13 Thread Alejandro Lucero
I was assuming in my acked answer, that the patch had followed usual path and automatic compilation did not fail. But I forgot about the NFP PMD not being enabled by default :-) Hopefully, this will change if this just sent patch is accepted: http://www.dpdk.org/ml/archives/dev/2017-January/0548

Re: [dpdk-dev] [PATCH] config: build nfp pmd support by default

2017-01-16 Thread Alejandro Lucero
Richardson < bruce.richard...@intel.com> wrote: > On Mon, Jan 16, 2017 at 04:43:11PM +, Ferruh Yigit wrote: > > On 1/13/2017 11:50 AM, Alejandro Lucero wrote: > > > Because using a NFP PMD requires specific BSP installed, the PMD > > > support was not the def

Re: [dpdk-dev] [PATCH] config: build nfp pmd support by default

2017-01-18 Thread Alejandro Lucero
Thanks! On Tue, Jan 17, 2017 at 11:58 PM, Ferruh Yigit wrote: > On 1/17/2017 11:20 PM, Ferruh Yigit wrote: > > On 1/13/2017 11:50 AM, Alejandro Lucero wrote: > >> Because using a NFP PMD requires specific BSP installed, the PMD > >> support was not the default optio

[dpdk-dev] [PATCH] igb_uio: map dummy dma forcing iommu domain attachment

2017-01-18 Thread Alejandro Lucero
and unmap is harmless even when iommu is not enabled at all. Signed-off-by: Alejandro Lucero --- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 21 + 1 file changed, 21 insertions(+) diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio

Re: [dpdk-dev] [dpdk-users] IGB_UIO: PCI Resources Management

2017-01-19 Thread Alejandro Lucero
On Thu, Jan 19, 2017 at 4:36 PM, Ferruh Yigit wrote: > On 1/13/2017 11:10 AM, Alejandro Lucero wrote: > > I completely misread the patch, and I wrongly thought that code was > > linked to module removal, but I see this is not about that, but about > > releasing the /dev/uio

Re: [dpdk-dev] Hotplug support for VFIO

2017-02-07 Thread Alejandro Lucero
It seems none is working on this VFIO support. I will work on this if there is no reply to this thread saying the opposite the next days. On Thu, Feb 2, 2017 at 12:58 PM, Eelco Chaudron wrote: > On 02/02/17 13:05, Burakov, Anatoly wrote: > >> Hi Eelco, >> >> Please forgive me my ignorance on th

Re: [dpdk-dev] [PATCH] igb_uio: map dummy dma forcing iommu domain attachment

2017-02-08 Thread Alejandro Lucero
Hi Ferruh, On Tue, Feb 7, 2017 at 3:59 PM, Ferruh Yigit wrote: > Hi Alejandro, > > On 1/18/2017 12:27 PM, Alejandro Lucero wrote: > > For using a DPDK app when iommu is enabled, it requires to > > add iommu=pt to the kernel command line. But using igb_uio driver > >

Re: [dpdk-dev] Hotplug support for VFIO

2017-02-08 Thread Alejandro Lucero
plug, which is basically related to unmapping PCI resources, and the interrupt part will be likely quite similar, the IOMMU unmapping requires more work. I dare to say this is the main reason for not having VFIO hotplug support right now. Maybe Tetsuya can confirm this or give us other reasons. &

Re: [dpdk-dev] Hotplug support for VFIO

2017-02-08 Thread Alejandro Lucero
I just wanted to clarify the hotplug VFIO is not the problem, as I can see it, but the unplug. When attaching a device the current VFIO code will be used, but there is no code for doing the IOMMU unmapping when unplugging. On Wed, Feb 8, 2017 at 3:43 PM, Alejandro Lucero < alejandro.

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-06 Thread Alejandro Lucero
Then I guess I should send another version of this patch. On Tue, Dec 6, 2016 at 12:46 PM, Mcnamara, John wrote: > > -Original Message- > > From: Yigit, Ferruh > > Sent: Tuesday, December 6, 2016 12:08 PM > > To: Alejandro Lucero ; dev@dpdk.org; > > M

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Alejandro Lucero
; > >> To: Yong Wang ; Thomas Monjalon > > >> > > >> Cc: Harish Patil ; dev@dpdk.org; Rahul > Lakkireddy > > >> ; Stephen Hurd > > >> ; Jan Medala ; Jakub > > >> Palider ; John Daley ; Adrien > > >> Mazarguil ; Alejandro

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-09 Thread Alejandro Lucero
That's fine. Thank you On Tue, Dec 6, 2016 at 4:01 PM, Ferruh Yigit wrote: > On 12/6/2016 2:51 PM, Alejandro Lucero wrote: > > Then I guess I should send another version of this patch. > > I can also update the patch while applying, if you agree with following > cont

Re: [dpdk-dev] [PATCH v3] nfp: report link speed using hardware info

2016-12-09 Thread Alejandro Lucero
On Tue, Dec 6, 2016 at 11:57 AM, Ferruh Yigit wrote: > On 12/2/2016 9:05 AM, Alejandro Lucero wrote: > > Previous reported speed was hardcoded. > > > > v3: remove unsed macro > > v2: using RTE_DIM instead of own macro > > > > Signed-off-by: Alejand

[dpdk-dev] [PATCH v4] nfp: report link speed using hardware info

2016-12-16 Thread Alejandro Lucero
and more ellaborated commit comment. v3: remove unsed macro v2: use RTE_DIM instead of own macro Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 27 +-- drivers/net/nfp/nfp_net_ctrl.h | 11 +++ 2 files changed, 36 insertions(+), 2 deletions

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-16 Thread Alejandro Lucero
dro Lucero wrote: > > That's fine. > > Applied to dpdk-next-net/master, thanks. > > > > > Thank you > > > > On Tue, Dec 6, 2016 at 4:01 PM, Ferruh Yigit > <mailto:ferruh.yi...@intel.com>> wrote: > > > > On 12/6/2016 2:51 PM, Aleja

Re: [dpdk-dev] [PATCH v4] nfp: report link speed using hardware info

2016-12-19 Thread Alejandro Lucero
On Mon, Dec 19, 2016 at 10:24 AM, Ferruh Yigit wrote: > On 12/16/2016 5:10 PM, Alejandro Lucero wrote: > > Previous reported speed was hardcoded because there was not firmware > > support for getting this information. This change needs to support old > > firmware versi

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

2016-12-19 Thread Alejandro Lucero
On Mon, Dec 19, 2016 at 11:45 AM, Ferruh Yigit wrote: > On 12/16/2016 5:29 PM, Alejandro Lucero wrote: > > Hi, > > > > One question about this patch. I will send another patch soon which will > > require to modify the file created by this patch. So, should I use the &g

[dpdk-dev] [PATCH v5] nfp: report link speed using hardware info

2016-12-19 Thread Alejandro Lucero
v4: Make conditional simple and more ellaborated commit comment. v3: remove unsed macro v2: use RTE_DIM instead of own macro Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 27 +-- drivers/net/nfp/nfp_net_ctrl.h | 11 +++ 2 files changed, 36

[dpdk-dev] [PATCH] nfp: extend speed capabilities advertised

2016-12-19 Thread Alejandro Lucero
NFP supports more speeds than just 40 and 100GB, which were what was advertised before. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 27afbfd

[dpdk-dev] [PATCH] nfp: remove rx port metadata

2016-12-19 Thread Alejandro Lucero
This was required for middlebox-like firmware which NFP does not support anymore. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 32 drivers/net/nfp/nfp_net_pmd.h | 2 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a

[dpdk-dev] [PATCH] nfp: fix typo in tx offload capabilities

2016-12-19 Thread Alejandro Lucero
Because macros for TCP and UDP related to offload cksums have same values, this was not a main problem. But better to use the right ones. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp

Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised

2016-12-19 Thread Alejandro Lucero
On Mon, Dec 19, 2016 at 2:36 PM, Ferruh Yigit wrote: > Hi Alejandro, > > Hi, > On 12/19/2016 12:05 PM, Alejandro Lucero wrote: > > NFP supports more speeds than just 40 and 100GB, which were > > what was advertised before. > > > > Signed-off-by: Alejandro

[dpdk-dev] [PATCH] nfp: avoid modulo operations for handling ring wrapping

2016-12-19 Thread Alejandro Lucero
been removed. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 66 +-- drivers/net/nfp/nfp_net_pmd.h | 5 +--- 2 files changed, 33 insertions(+), 38 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index

Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised

2016-12-19 Thread Alejandro Lucero
On Mon, Dec 19, 2016 at 3:05 PM, Ferruh Yigit wrote: > On 12/19/2016 3:02 PM, Alejandro Lucero wrote: > > > > > > On Mon, Dec 19, 2016 at 2:36 PM, Ferruh Yigit > <mailto:ferruh.yi...@intel.com>> wrote: > > > > Hi Alejandro, > > > >

Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised

2016-12-19 Thread Alejandro Lucero
On Mon, Dec 19, 2016 at 4:35 PM, Marc wrote: > > > On 19 December 2016 at 17:18, Alejandro Lucero < > alejandro.luc...@netronome.com> wrote: > >> On Mon, Dec 19, 2016 at 3:05 PM, Ferruh Yigit >> wrote: >> >> > On 12/19/2016 3:02 PM, Alejandro L

Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised

2016-12-19 Thread Alejandro Lucero
On Mon, Dec 19, 2016 at 4:43 PM, Ferruh Yigit wrote: > On 12/19/2016 4:18 PM, Alejandro Lucero wrote: > > On Mon, Dec 19, 2016 at 3:05 PM, Ferruh Yigit > > wrote: > > > >> On 12/19/2016 3:02 PM, Alejandro Lucero wrote: > >>> > >>&g

Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised

2016-12-19 Thread Alejandro Lucero
I forgot one thing: to update the features file with this new one. I will wait for your feedback regarding the discussed problem for sending another version. Thanks On Mon, Dec 19, 2016 at 5:59 PM, Alejandro Lucero < alejandro.luc...@netronome.com> wrote: > > > On Mon, Dec 19,

[dpdk-dev] [PATCH] nfp: add support for rx interrupts

2016-12-19 Thread Alejandro Lucero
This is supported with UIO and VFIO modules. With UIO, LSC interrupt is disabled. Signed-off-by: Alejandro Lucero --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/nfp_net.c| 112 +-- drivers/net/nfp/nfp_net_ctrl.h | 1 + 3 files

[dpdk-dev] [PATCH] nfp: add tso support

2016-12-20 Thread Alejandro Lucero
This patch implements NFP PMD support for TSO but it also requires a firmware advertising the capability. Signed-off-by: Alejandro Lucero --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/nfp_net.c| 40 2 files changed, 33 insertions

Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised

2016-12-20 Thread Alejandro Lucero
On Tue, Dec 20, 2016 at 10:25 AM, Ferruh Yigit wrote: > On 12/19/2016 6:00 PM, Alejandro Lucero wrote: > > I forgot one thing: to update the features file with this new one. > > > > I will wait for your feedback regarding the discussed problem for > > sending another

Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised

2016-12-20 Thread Alejandro Lucero
On Tue, Dec 20, 2016 at 10:29 AM, Alejandro Lucero < alejandro.luc...@netronome.com> wrote: > > > On Tue, Dec 20, 2016 at 10:25 AM, Ferruh Yigit > wrote: > >> On 12/19/2016 6:00 PM, Alejandro Lucero wrote: >> > I forgot one thing: to update the features file

[dpdk-dev] [PATCH v2] nfp: extend speed capabilities advertised

2016-12-20 Thread Alejandro Lucero
NFP supports more speeds than just 40 and 100GB, which were what was advertised before. v2: add feature to nfp.ini Signed-off-by: Alejandro Lucero --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/nfp_net.c| 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v6] nfp: report link speed using hardware info

2016-12-20 Thread Alejandro Lucero
configured to 40G. v6: avoid to report speed with old firmware v5: Fix missing parenthesis v4: Make conditional simple and more ellaborated commit comment. v3: remove unsed macro v2: use RTE_DIM instead of own macro Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 28

[dpdk-dev] [PATCH] nfp: add support for new metadata api

2016-12-20 Thread Alejandro Lucero
facilitating interaction between firmware and host code. Old way of handling metadata needs to be still there for supporting old firmware. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 33 +++-- drivers/net/nfp/nfp_net_ctrl.h | 6 ++ 2 files changed

Re: [dpdk-dev] [PATCH] nfp: add support for new metadata api

2017-01-04 Thread Alejandro Lucero
Hi Ferruh, On Wed, Jan 4, 2017 at 3:15 PM, Ferruh Yigit wrote: > On 12/20/2016 2:13 PM, Alejandro Lucero wrote: > > NFP is a smart programmable NIC and firmware is deployed for specific > > system needs, like offloading OVS, vRouter, contrack or eBPF into the > > hardware

Re: [dpdk-dev] [PATCH] common: introduce an integer log2 function

2017-07-03 Thread Alejandro Lucero
Hi, Sorry for the late answer. Yes, that's fine. Thank you On Sat, Jul 1, 2017 at 3:37 PM, Thomas Monjalon wrote: > Alejandro, > > Are you OK to replace log2 by rte_log2_u32? > I'm waiting your ack to apply this patch. > > > 06/04/2017 16:23, Olivier MATZ: > > I forgot to CC Alejandro for n

Re: [dpdk-dev] 17.11 Intel Roadmap

2017-07-25 Thread Alejandro Lucero
Hi Tim, I'd like to add this: Netronome NFP PMD with PF support, including PF mutliport suport. Currently NFP PMF just supports VFs. Thanks On Tue, Jul 25, 2017 at 11:18 AM, O'Driscoll, Tim wrote: > Below are the features that we're planning to submit for the 17.11 > release. We'll submit a p

[dpdk-dev] [PATCH] vfio: add hotplug support

2017-03-16 Thread Alejandro Lucero
Current device hotplug is just when using UIO. This patch adds same functionality with VFIO. It has been validated through tests using IOMMU and also with VFIO and no-iommu mode. Signed-off-by: Alejandro Lucero --- lib/librte_eal/common/eal_common_pci.c | 2 +- lib/librte_eal

[dpdk-dev] KNI offloads

2017-03-17 Thread Alejandro Lucero
Is there any reason for this driver not supporting LSO or CSUM offloads? I know this is a virtual netdev but I think it should support those options and enabled them depending on the PMD to send or receive packets from. About giving to the KNI that info, maybe using the kernel firmware interface

[dpdk-dev] [PATCH 1/3] nfp: clean tx descriptor flags

2017-03-21 Thread Alejandro Lucero
When LSO, not doing this can led to firmware disruption. It does not show as error because TCP ends up sending data again later on. Fixes: 9ba3d0ae2090 (\"net/nfp: add TSO support\") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 12 +--- 1 file changed, 9

[dpdk-dev] [PATCH 2/3] nfp: fix problem with pkt_len to data_len conversion

2017-03-21 Thread Alejandro Lucero
requires to have pkt_len set. NFP PMD was assuming pkt_len is set in all the chained mbufs and unit tests for gather dma were building mbufs with pkt_len always set. This patch gets rid of that assumption. Fixes: b812daadad0d (\"nfp: add Rx and Tx\") Signed-off-by: Alejandro Lucero --

[dpdk-dev] [PATCH 3/3] nfp: fix problem with rx interrupts

2017-03-21 Thread Alejandro Lucero
Current code enables RX interrupts even if this it not requested. Fixes: ea121b28316d (\"net/nfp: add Rx interrupts\") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_net.c b/drive

Re: [dpdk-dev] [PATCH] vfio: add hotplug support

2017-03-24 Thread Alejandro Lucero
Hi Anatoly, On Wed, Mar 22, 2017 at 1:49 PM, Burakov, Anatoly wrote: > Hi Alejandro, > > Just a general comment, I think there's now a rule to not split error > messages onto multiple lines > even if going above the 80 char limit, to make grepping easier. > > Ok. Thanks. > > Current device hot

Re: [dpdk-dev] [PATCH] vfio: add hotplug support

2017-03-24 Thread Alejandro Lucero
On Thu, Mar 23, 2017 at 12:08 PM, Burakov, Anatoly < anatoly.bura...@intel.com> wrote: > Hi Alejandro, > > I think the documentation should also be updated to reflect the fact that > this patch adds VFIO support for hotplug. > Yes. Thanks. I will submit a new version with all the fixes from your

[dpdk-dev] [PATCH v2] vfio: add hotplug support

2017-03-27 Thread Alejandro Lucero
Current device hotplug is just supported by UIO managed devices. This patch adds same functionality with VFIO. It has been validated through tests using IOMMU and also with VFIO and no-iommu mode. Signed-off-by: Alejandro Lucero --- app/Makefile | 1 + doc

Re: [dpdk-dev] [PATCH v2] vfio: add hotplug support

2017-03-29 Thread Alejandro Lucero
On Wed, Mar 29, 2017 at 9:57 AM, Burakov, Anatoly wrote: > Hi Alejandro, > > > From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] > > Sent: Monday, March 27, 2017 11:56 AM > > To: Burakov, Anatoly > > Cc: dev@dpdk.org > > Subject: [PATCH v2] vfio:

[dpdk-dev] [PATCH v3] vfio: add hotplug support

2017-03-29 Thread Alejandro Lucero
Current device hotplug is just supported by UIO managed devices. This patch adds same functionality with VFIO. It has been validated through tests using IOMMU and also with VFIO and no-iommu mode. Signed-off-by: Alejandro Lucero --- doc/guides/prog_guide/port_hotplug_framework.rst | 2

Re: [dpdk-dev] Hotplug support for VFIO

2017-02-10 Thread Alejandro Lucero
On Thu, Feb 9, 2017 at 3:16 AM, Tetsuya Mukawa wrote: > 2017-02-09 0:48 GMT+09:00 Alejandro Lucero >: > > I just wanted to clarify the hotplug VFIO is not the problem, as I can > see > > it, but the unplug. When attaching a device the current VFIO code will be > > use

Re: [dpdk-dev] [PATCH] igb_uio: map dummy dma forcing iommu domain attachment

2017-02-13 Thread Alejandro Lucero
On Fri, Feb 10, 2017 at 7:03 PM, Ferruh Yigit wrote: > On 2/8/2017 11:54 AM, Alejandro Lucero wrote: > > Hi Ferruh, > > > > On Tue, Feb 7, 2017 at 3:59 PM, Ferruh Yigit > <mailto:ferruh.yi...@intel.com>> wrote: > > > > Hi Alejandro, > > &g

Re: [dpdk-dev] [PATCH] igb_uio: map dummy dma forcing iommu domain attachment

2017-02-13 Thread Alejandro Lucero
On Fri, Feb 10, 2017 at 7:06 PM, Ferruh Yigit wrote: > On 2/10/2017 7:03 PM, Ferruh Yigit wrote: > > On 2/8/2017 11:54 AM, Alejandro Lucero wrote: > >> Hi Ferruh, > >> > >> On Tue, Feb 7, 2017 at 3:59 PM, Ferruh Yigit >> <mailto:ferruh.yi...@

[dpdk-dev] mbuf changes

2016-10-26 Thread Alejandro Lucero
On Tue, Oct 25, 2016 at 2:05 PM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Oct 25, 2016 at 05:24:28PM +0530, Shreyansh Jain wrote: > > On Monday 24 October 2016 09:55 PM, Bruce Richardson wrote: > > > On Mon, Oct 24, 2016 at 04:11:33PM +, Wiles, Keith wrote: > > > > >

[dpdk-dev] [PATCH 2/2] virtio: support IOMMU platform

2016-09-04 Thread Alejandro Lucero
I know RedHat is working on a vIOMMU so I guess this work is related to that effort, but it is a surprise virtio using IOMMU. I thought IOMMU just made sense when using SRIOV. My second guess is using IOMMU with virtio is a matter of security, but by other hand, virtio + IOMMU could imply serious p

[dpdk-dev] [PATCH] nfp: using random mac address if not a configured mac

2016-09-16 Thread Alejandro Lucero
Thank you for the feedback. I'll send the fixed patched today. On Tue, Sep 13, 2016 at 8:30 PM, Thomas Monjalon wrote: > 2016-09-13 18:10, Ferruh Yigit: > > Hi Alejandro, > > > > On 8/16/2016 4:15 PM, Alejandro Lucero wrote: > > > Signed-off-by: Alejandro

[dpdk-dev] [PATCH v2] nfp: using random MAC address if not configured

2016-09-16 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 82e3e4e..1948a12 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net

[dpdk-dev] [PATCH v2] nfp: fixing bug when copying MAC address

2016-09-16 Thread Alejandro Lucero
Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 1948a12..d79f0a1 100644 ---

[dpdk-dev] [PATCH v2] nfp: unregister interrupt callback when closing

2016-09-16 Thread Alejandro Lucero
With an app using hotplug feature, when a device is unplugged without unregistering makes the interrupt handling unstable. Fixes: 6c53f87b3497 ("nfp: add link status interrupt") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 5 + 1 file changed, 5 insertions(+)

Re: [dpdk-dev] Will huge page have negative effect on guest vm in qemu enviroment?

2017-06-22 Thread Alejandro Lucero
On Wed, Jun 21, 2017 at 8:22 AM, Sam wrote: > Thank you~ > > 1. We have a compare test on qemu-kvm enviroment with huge page and without > huge page. Qemu start process is much longer in huge page enviromwnt. And I > write an email titled with '[DPDK-memory] how qemu waste such long time > under

Re: [dpdk-dev] vfio: failed to select IOMMU type

2017-04-05 Thread Alejandro Lucero
Hi Andrew, Anatoly, On Tue, Apr 4, 2017 at 4:52 PM, Burakov, Anatoly wrote: > Hi Andrew, > > > I think a key to the main problem is the same IOMMU group used for both > PCI functions. > > It tries to set IOMMU type using the same file descriptor twice. The > second set is dummy, since the same v

Re: [dpdk-dev] vfio: failed to select IOMMU type

2017-04-05 Thread Alejandro Lucero
On Tue, Apr 4, 2017 at 5:20 PM, Burakov, Anatoly wrote: > Hi Andrew, > > > Please, take a look at http://dpdk.org/dev/patchwork/patch/23202/ > > I took a quick look. It should fix the problem (closing the group will > cause container detachment, so we can always assume that if there's no > contai

Re: [dpdk-dev] vfio: failed to select IOMMU type

2017-04-18 Thread Alejandro Lucero
On Thu, Apr 6, 2017 at 11:10 AM, Burakov, Anatoly wrote: > Hi Alejandro, > > > Yes, the code was not aware of that possibility. Being honest, I knew > about that, but not in my mind when implementing the code. I have just > cards where each PF even VF have their own VFIO group. This could be a >

Re: [dpdk-dev] [PATCH] vfio: set IOMMU type for the container once

2017-04-21 Thread Alejandro Lucero
The patch is OK for me. I have run tests with that change with no problems. But I can just run tests with devices where each one got its own IOMMU group, so my ack is just for that case (although theoretically this patch fixes the other case). I'm looking at doing some changes to the kernel for bei

Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-26 Thread Alejandro Lucero
clear_group(vfio_group_fd); > > >> -return -1; > > >> +if (!t) { > > >> +RTE_LOG(ERR, EAL, " %s failed to select IOMMU > > >> + type\n", > > >> dev_addr); > > >>

Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-26 Thread Alejandro Lucero
On Wed, Apr 26, 2017 at 9:58 AM, Burakov, Anatoly wrote: > Hi Alejandro, > > > I was counting on first submitted patch being accepted. > > OK, that's on me then. > > > There is another thing to solve which is to unplug ports when there are > more than one (already plugged) in an IOMMU group. I ha

[dpdk-dev] [PATCH] nfp: fix mbuf releasing when segments

2017-04-26 Thread Alejandro Lucero
tx descriptors will release linked mbufs inside the xmit function, and rte_pktmbuf_seg_free is used instead of rte_pktmbuf_free. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/net/nfp

[dpdk-dev] [PATCH] vfio: fix device unplug when several devices per vfio group

2017-04-26 Thread Alejandro Lucero
("vfio: support hotplug") Signed-off-by: Alejandro Lucero --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 32 lib/librte_eal/linuxapp/eal/eal_vfio.h | 1 + 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_vfi

Re: [dpdk-dev] [PATCH] vfio: set IOMMU type for the container once

2017-04-26 Thread Alejandro Lucero
owrishankar > > > On Friday 21 April 2017 02:53 PM, Alejandro Lucero wrote: > > The patch is OK for me. I have run tests with that change with no > problems. But I can just run tests with devices where each one got its own > IOMMU group, so my ack is just for that case (altho

Re: [dpdk-dev] [RFC PATCH 4/5] kni: add support to get gso_size info

2017-05-03 Thread Alejandro Lucero
I guess this is just need this for tso offload. isn't it? Just asking because I have done some work adding gather and tso offload to kni and I was wondering if this is duplicated job from my part. If you are wondering what KNI offload means, since it is not talking to any hw, the offload is regar

Re: [dpdk-dev] [PATCH] vfio: fix device unplug when several devices per vfio group

2017-05-08 Thread Alejandro Lucero
Hi Jerin, On Mon, May 8, 2017 at 4:20 PM, Jerin Jacob wrote: > -Original Message- > > Date: Sun, 30 Apr 2017 19:29:49 +0200 > > From: Thomas Monjalon > > To: Alejandro Lucero > > Cc: dev@dpdk.org, "Burakov, Anatoly" > > Subject: Re: [dpd

[dpdk-dev] [PATCH] vfio: use right index when tracking devices in a vfio group

2017-05-08 Thread Alejandro Lucero
going through the vfio group array but this should not be a problem as this is not related to packet handling at all. Fixes: a9c349e3a100 ("vfio: fix device unplug when several devices per group") Signed-off-by: Alejandro Lucero --- lib/librte_eal/linuxapp/eal/eal_v

Re: [dpdk-dev] [PATCH] vfio: fix device unplug when several devices per vfio group

2017-05-08 Thread Alejandro Lucero
on adding some for this VFIO hotplug feature. On Mon, May 8, 2017 at 5:44 PM, Alejandro Lucero < alejandro.luc...@netronome.com> wrote: > Hi Jerin, > > On Mon, May 8, 2017 at 4:20 PM, Jerin Jacob m> wrote: > >> -Original Message- >> > Date: Sun, 30 Apr

Re: [dpdk-dev] [PATCH] vfio: use right index when tracking devices in a vfio group

2017-05-09 Thread Alejandro Lucero
Hi Anatoly, On Tue, May 9, 2017 at 4:18 PM, Burakov, Anatoly wrote: > Hi Alejandro, > > > From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] > > Sent: Monday, May 8, 2017 6:44 PM > > To: dev@dpdk.org > > Cc: Burakov, Anatoly ; > > jerin.ja...@cav

[dpdk-dev] [PATCH v2] vfio: use right index when tracking devices in a vfio group

2017-05-10 Thread Alejandro Lucero
going through the vfio group array but this should not be a problem as this is not related to packet handling at all. Fixes: a9c349e3a100 ("vfio: fix device unplug when several devices per group") Signed-off-by: Alejandro Lucero --- lib/librte_eal/linuxapp/eal/eal_v

Re: [dpdk-dev] New Coverity defects in VFIO

2017-05-11 Thread Alejandro Lucero
On Thu, May 11, 2017 at 5:38 PM, Stephen Hemminger < step...@networkplumber.org> wrote: > Looks like obvious C array bounds issues... > > Right. I will send a patch today. Thanks > Begin forwarded message: > > Date: Thu, 11 May 2017 06:32:38 -0700 > From: scan-ad...@coverity.com > To: step...@

[dpdk-dev] [PATCH] vfio: fix array bounds check

2017-05-12 Thread Alejandro Lucero
Checking against VFIO_MAX_GROUPS goes beyond the maximum array index which should be (VFIO_MAX_GROUPS - 1). Fixes: 94c0776b1bad("support hotplug") Coverity issue: 144555 Coverity issue: 144556 Coverity issue: 144557 Signed-off-by: Alejandro Lucero --- lib/librte_eal/linuxapp/eal/eal_

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-16 Thread Alejandro Lucero
Maybe we need another feature for detected link speed report capability. There is already support for ETH_SPEED_NUM_NONE if the speed is not defined or it can not be specified by the device. Netronome has some firmwares without that link speed report capability, although maybe we are not the only

Re: [dpdk-dev] [PATCH] drivers/net: document missing speed capabilities feature

2017-05-16 Thread Alejandro Lucero
On Tue, May 16, 2017 at 11:02 AM, Thomas Monjalon wrote: > 16/05/2017 11:39, Alejandro Lucero: > > Maybe we need another feature for detected link speed report capability. > > > > There is already support for ETH_SPEED_NUM_NONE if the speed is not > defined > > or

[dpdk-dev] VFIO no-iommu

2015-12-15 Thread Alejandro Lucero
Hi, I know a bit about VFIO implementation, have been debugging IOMMU (intel) problems, know how QEMU/KVM work about using legacy or vfio attached devices, and I'm the maintainer of a DPDK PMD recently accepted upstream which requires our particular UIO driver (not maintained upstream). So I gues

[dpdk-dev] [PATCH v2] net/nfp: add multiprocess support

2018-12-11 Thread Alejandro Lucero
Signed-off-by: Alejandro Lucero --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/nics/features/nfp_vf.ini| 1 + doc/guides/nics/nfp.rst| 12 ++ drivers/net/nfp/nfp_net.c | 133 + drivers/net/nfp/nfpcore

Re: [dpdk-dev] [PATCH 6/9] net/ifc: add devarg for LM mode

2018-12-12 Thread Alejandro Lucero
On Wed, Nov 28, 2018 at 9:56 AM Xiao Wang wrote: > This patch series enables a new method for live migration, i.e. software > assisted live migration. This patch provides a device argument for user > to choose the methold. > > When "swlm=1", driver/device will do live migration with a relay threa

[dpdk-dev] [PATCH] net/nfp: fix device start/stop for VFs

2019-01-02 Thread Alejandro Lucero
Previous commit adding multiprocess support broke VF support. When VFs, the PMD does not set the link up or down. Fixes: ef28aa96e53b ("net/nfp: support multiprocess") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 28 1 file changed, 16

[dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

2019-01-03 Thread Alejandro Lucero
ith a secondary process specifically enabling this CPP bridge service and therefore giving access to the NFP to those host tools. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 393 +- drivers/net/nfp/nfp_net_pmd.h | 1 + 2 files changed

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

2019-01-09 Thread Alejandro Lucero
On Wed, Jan 9, 2019 at 10:54 AM Ferruh Yigit wrote: > On 1/3/2019 8:56 AM, Alejandro Lucero wrote: > > The Netronome's Network Flow Processor chip is highly programmable > > with the goal of processing packets at high speed. Processing units > > and other chip compone

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

2019-01-10 Thread Alejandro Lucero
On Wed, Jan 9, 2019 at 4:15 PM Ferruh Yigit wrote: > On 1/9/2019 2:20 PM, Alejandro Lucero wrote: > > > > > > On Wed, Jan 9, 2019 at 10:54 AM Ferruh Yigit > <mailto:ferruh.yi...@intel.com>> wrote: > > > > On 1/3/2019 8:56 AM, Alejandro Lucero

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

2019-01-11 Thread Alejandro Lucero
On Fri, Jan 11, 2019 at 11:48 AM Ferruh Yigit wrote: > On 1/10/2019 11:55 AM, Alejandro Lucero wrote: > > > > > > On Wed, Jan 9, 2019 at 4:15 PM Ferruh Yigit > <mailto:ferruh.yi...@intel.com>> wrote: > > > > On 1/9/2019 2:20 PM, Alejandro Lucer

[dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

2019-01-11 Thread Alejandro Lucero
ith a secondary process specifically enabling this CPP bridge service and therefore giving access to the NFP to those host tools. v2: - Avoid printfs for debugging - fix compilation problems for powerpc Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c

Re: [dpdk-dev] [PATCH v2 0/5] use IOVAs check based on DMA mask

2018-10-02 Thread Alejandro Lucero
As I was told, I sent this patchset early September (actually it was still October) for making it for 18.11. I wonder if this will be applied when doing the integration phase or it will need to wait until 19.02. On Fri, Aug 31, 2018 at 1:51 PM Alejandro Lucero < alejandro.luc...@netronome.

Re: [dpdk-dev] [PATCH v2 2/5] mem: use address hint for mapping hugepages

2018-10-04 Thread Alejandro Lucero
On Wed, Oct 3, 2018 at 1:50 PM Burakov, Anatoly wrote: > On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > > Linux kernel uses a really high address as starting address for > > serving mmaps calls. If there exist addressing limitations and > > IOVA mode is VA, this starting

[dpdk-dev] Fwd: [PATCH v2 1/5] mem: add function for checking memsegs IOVAs addresses

2018-10-04 Thread Alejandro Lucero
I sent this email only to Anatoly. Sending it again to mailing list. On Wed, Oct 3, 2018 at 1:43 PM Burakov, Anatoly wrote: > On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > > A device can suffer addressing limitations. This functions checks > > memsegs have iovas within the

Re: [dpdk-dev] [PATCH v2 2/5] mem: use address hint for mapping hugepages

2018-10-04 Thread Alejandro Lucero
On Thu, Oct 4, 2018 at 1:08 PM Burakov, Anatoly wrote: > On 04-Oct-18 12:43 PM, Alejandro Lucero wrote: > > > > > > On Wed, Oct 3, 2018 at 1:50 PM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > On 31-Aug-18 1:50 PM, Alejand

  1   2   3   4   5   6   >