-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index f9ce204..aa611e1 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
During initialization, mac address is read from configuration bar. This is
the default option when using VFs.
This patch adds support for reading the mac address using the NSPU
interface when PMD works with the PF.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 59
NFP PMF has now support for both, PF and VFs. This patch updates
the guide and give some information about implications.
Signed-off-by: Alejandro Lucero
---
doc/guides/nics/nfp.rst | 71 -
1 file changed, 52 insertions(+), 19 deletions(-)
diff
On Mon, Aug 28, 2017 at 5:42 PM, Ferruh Yigit
wrote:
> On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> > NFP PMD has just had support for SRIOV VFs until now. This patchset adds
> > support for the PF, but just for being used as another DPDK port. No VF
> > manag
On Mon, Aug 28, 2017 at 5:42 PM, Ferruh Yigit
wrote:
> On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> > Using NSPU interface for fw upload. Firmware file needs to be
> > installed in specific path inside system firmware directory.
> >
> > NSPU buffer is used for
On Mon, Aug 28, 2017 at 5:43 PM, Ferruh Yigit
wrote:
> On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> > A NFP PF PCI devices can have PCI ID 4000 or 6000.
> >
> > Signed-off-by: Alejandro Lucero
>
> <...>
>
> > @@ -2682,6 +2682,10 @@ static int nfp_pf_
On Mon, Aug 28, 2017 at 5:42 PM, Ferruh Yigit
wrote:
> On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> > Configuring the NFP PMD for using the PF requires access through the
> > NSPU interface for device configuration. This patch adds a specific probe
> > function for the P
On Thu, Aug 31, 2017 at 10:13 AM, Ferruh Yigit
wrote:
> On 8/31/2017 10:08 AM, Alejandro Lucero wrote:
> >
> >
> > On Mon, Aug 28, 2017 at 5:43 PM, Ferruh Yigit > <mailto:ferruh.yi...@intel.com>> wrote:
> >
> > On 8/24/2017 5:20 PM, Alejandro Luc
On Mon, Aug 28, 2017 at 5:42 PM, Ferruh Yigit
wrote:
> On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> > Firmware has symbols helping to configure things like number of
> > PF ports, vNIC BARs addresses inside NFP memories, or ethernet
> > link state. Different firmwar
notes
- creating different features files for PF and VF
- fix typo inside nfp_nspu.c
Alejandro Lucero (18):
net/nfp: add NSP user space interface
net/nfp: add specific PF probe function
net/nfp: add support for new PCI id
net/nfp: add NSP support for commands
net/nfp: add NSP FW upload
later for configuring the PF vNIC
bars, a subset of PF PCI BARs.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/Makefile | 2 +
drivers/net/nfp/nfp_nfpu.c | 103
drivers/net/nfp/nfp_nfpu.h | 55 +++
drivers/net/nfp/nfp_nspu.c | 129
greater than 0.19.
No ethernet port is created yet.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 75 +++
1 file changed, 69 insertions(+), 6 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index a3bf5e1
A NFP PF PCI devices can have PCI ID 4000 or 6000.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 4
drivers/net/nfp/nfp_net_pmd.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index cb48fdc..ca481e4 100644
as well which
does not require the buffer at all.
Commands will allow firmware upload, symbol resolution and ethernet
link configuration. Future commands will allow specific offloads like
flow offloads and eBPF offload.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_nspu.c | 181
Using NSPU interface for fw upload. Firmware file needs to be
installed in specific path inside system firmware directory.
NSPU buffer is used for writing the firmware before sending the
command.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_nspu.c | 66
symbol data
regarding different hardware configurations. Once the driver has
the information about a specific object, a mapping is required
configuring an NFP expansion bar creating a device PCI bar window.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_nspu.c | 86
PMD will use this function for uploading the firmware. First, a
symbol resolution is done for finding out if there is a firmware
already there. If not, a NFP reset is called before using NSPU
fw upload code.
PMD PF probe function is now using this logic.
Signed-off-by: Alejandro Lucero
/tx bars
mapped through a expansion bar using that specific physical address.
The PMD will use the PCI bar offset returned for mapping the vNIC
rx/tx bars.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_nspu.c | 21 -
drivers/net/nfp/nfp_nspu.h | 1 +
2 files changed
returned for accessing the vNIC bar.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_nspu.c | 13 +
drivers/net/nfp/nfp_nspu.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/drivers/net/nfp/nfp_nspu.c b/drivers/net/nfp/nfp_nspu.c
index 5a3ae0e..827f0b2 100644
--- a
functions introduced previously for configuring
NFP expansion bars.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 56 ---
drivers/net/nfp/nfp_net_pmd.h | 4
2 files changed, 52 insertions(+), 8 deletions(-)
diff --git a/drivers
(_portX, with X
being the port index) which DPDK core is not aware of. While rx
interrupts with multiport could be likely solved with some layer of
indirection, hotplug would require changes to DPDK core.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 199
invokes pmd initialization with the new eth_dev.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 49 ---
1 file changed, 42 insertions(+), 7 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 021b0ea
concurrent access. A spinlock is added to the global nspu object for
protecting the NFP and avoiding the concurrent access.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net_eth.h | 82 +++
drivers/net/nfp/nfp_nspu.c| 79
: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 5bfb18e..251a1c6 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -737,6
NFP PMD has now support for both, PF and VFs. This patch updates
the guide and give some information about implications.
Signed-off-by: Alejandro Lucero
---
doc/guides/nics/nfp.rst | 77 +
1 file changed, 58 insertions(+), 19 deletions(-)
diff
Signed-off-by: Alejandro Lucero
---
doc/guides/rel_notes/release_17_11.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/doc/guides/rel_notes/release_17_11.rst
b/doc/guides/rel_notes/release_17_11.rst
index 170f4f9..8773b08 100644
--- a/doc/guides/rel_notes/release_17_11.rst
soon in another patch.
SRIOV is not supported by the PF yet, and it is wrong to include it
as a VF driver feature, so none of the files have such a feature.
Signed-off-by: Alejandro Lucero
---
doc/guides/nics/features/nfp.ini| 29 -
doc/guides/nics/features
During initialization, mac address is read from configuration bar. This is
the default option when using VFs.
This patch adds support for reading the mac address using the NSPU
interface when PMD works with the PF.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 59
to:dev-boun...@dpdk.org] On Behalf Of Alejandro Lucero
> > Sent: Friday, September 1, 2017 3:12 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 16/18] doc: update NFP with PF support
> > information
> >
> > NFP PMD has now support for both, PF and VFs. T
On Wed, Sep 6, 2017 at 10:53 AM, Ferruh Yigit
wrote:
> On 9/4/2017 5:03 PM, Alejandro Lucero wrote:
> > Hi John,
> >
> > Thanks for your review. I will modify the doc in next patch set version.
> >
> > I'll wait until Ferruh give me the green light for s
From: root
NFP PMD has now support for both, PF and VFs. This patch updates
the guide and give some information about implications.
Signed-off-by: root
---
doc/guides/nics/nfp.rst | 78 +
1 file changed, 59 insertions(+), 19 deletions(-)
diff --
It seems I did not commit with the right signature.
I will send it again. Sorry about this.
On Wed, Sep 6, 2017 at 3:47 PM, Alejandro Lucero <
alejandro.luc...@netronome.com> wrote:
> From: root
>
> NFP PMD has now support for both, PF and VFs. This patch updates
> the g
NFP PMD has now support for both, PF and VFs. This patch updates
the guide and give some information about implications.
Signed-off-by: Alejandro Lucero
---
doc/guides/nics/nfp.rst | 78 +
1 file changed, 59 insertions(+), 19 deletions(-)
diff
I understand this is the representor idea suiting Intel cards but it does
not cover other possibilities.
At least, Netronome and Mellanox require a representor not just for
controlling a VF, but also for sending and receiving packets through the
representor PMD.
I sent an abstract for a presentat
On Thu, Sep 7, 2017 at 2:13 PM, Declan Doherty
wrote:
> On 07/09/2017 11:01 AM, Alejandro Lucero wrote:
>
>> I understand this is the representor idea suiting Intel cards but it does
>> not cover other possibilities.
>>
>> At least, Netronome and Mellanox requ
NFP supports RSS but it is not being advertised.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 5d35ce1..2c288c2 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b
Link speed is not advertised in old firmwares. However, it is safe
to remove the check because reading NFP_NET_CFG_STS returns 0 in
those cases.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a
I tried to start a discussion about eBPF support with DPDK in last DPDK
meeting in Santa Clara:
https://dpdksummit.com/Archive/pdf/2017USA/DPDK%20support%20for%20new%20hardware%20offloads.pdf
In slide 17 I have some points which, IMHO, are worth to discuss before
adding this support.
I can see c
In next 18.05 the old hw offload API will be removed. This patch adds
support for just the new hw offload API.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 294 ++
drivers/net/nfp/nfp_net_pmd.h | 6 +-
2 files changed, 217
not been
splitted up because is completely internal to the NFP functionality. The
second patch makes the PMD changes required for using the new interface.
Alejandro Lucero (4):
net/nfp: add NFP CPP support
net/nfp: update PMD for using new CPP interface
doc: update NFP guide
net/nfp
New CPP interface changes the way firmware upload is managed by
the PMD. It also supports different firmware file names for
having specific firmware aplications per card.
Signed-off-by: Alejandro Lucero
---
doc/guides/nics/nfp.rst | 31 ---
1 file changed, 24
work with.
This change just changes initialization with the datapath being unaffected.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/Makefile | 17 ++-
drivers/net/nfp/nfp_net.c | 342 +-
drivers/net/nfp/nfp_net_pmd.h | 16 +-
3 files changed
New CPP interface makes NSPU interface obsolete. These files are
not needed anymore.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net_eth.h | 82 --
drivers/net/nfp/nfp_nfpu.c| 108 ---
drivers/net/nfp/nfp_nfpu.h| 55
drivers/net/nfp/nfp_nspu.c| 642
On Tue, Mar 27, 2018 at 7:25 PM, Ferruh Yigit
wrote:
> On 3/15/2018 2:30 PM, Alejandro Lucero wrote:
> > In next 18.05 the old hw offload API will be removed. This patch adds
> > support for just the new hw offload API.
> >
> > Signed-off-by: Alejandro Lucero
>
On Fri, Mar 30, 2018 at 11:37 AM, Ferruh Yigit
wrote:
> On 3/23/2018 5:35 PM, Alejandro Lucero wrote:
> > CPP refers to the internal NFP Command Push Pull bus. This patch allows
> > to create CPP commands from user space allowing to access any single
> > part of the c
On Fri, Mar 30, 2018 at 11:37 AM, Ferruh Yigit
wrote:
> On 3/23/2018 5:35 PM, Alejandro Lucero wrote:
> > New CPP interface changes the way firmware upload is managed by
> > the PMD. It also supports different firmware file names for
> > having specific firmware
This is required in some NFP firmwares when working with VFs.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 09854a2..b014209
These capabilities are enabled in current NFP firmwares by
default, but it could be they are not with NFP firmwares to come.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net
.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 000d339..fe41e61 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2810,10
On Tue, Sep 19, 2017 at 10:53 AM, Ferruh Yigit
wrote:
> On 9/1/2017 3:12 PM, Alejandro Lucero wrote:
> > Signed-off-by: Alejandro Lucero
> > ---
> > doc/guides/rel_notes/release_17_11.rst | 9 +
> > 1 file changed, 9 insertions(+)
> >
> > diff --g
Hi guys,
i have been on PTO since the 19th of October.
I will test this patch asap, but I'm aware this has already been accepted.
On Wed, Oct 25, 2017 at 6:37 PM, Ferruh Yigit
wrote:
> On 10/24/2017 5:35 AM, Thomas Monjalon wrote:
> > 24/10/2017 12:35, Gaetan Rivet:
> >> Gaetan Rivet (6):
> >>
gaetan.ri...@6wind.com
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 8c1c1f0..05f26bc 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
I'm afraid the patch introduced a problem for the NFP PMD.
I have submitted a patch fixing it: "net/nfp: avoid unplug if multiport"
Thanks
On Mon, Oct 30, 2017 at 9:45 AM, Alejandro Lucero <
alejandro.luc...@netronome.com> wrote:
> Hi guys,
>
> i have been on
Not all struct fields will be written and random data could
confuse readers.
Fixes: 92aa491b881e ("nfp: add statistics")
Coverity: 140755
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/d
If the function actually returns a null value, a null pointer
dereference will occur.
Fixes: dd63df2bfff3 ("net/nfp: add NSP symbol resolution command")
Coverity: 195013
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_nspu.c | 3 +++
1 file changed, 3 insertions(+)
di
File descriptor is not released in any potential exit path
inside the function.
Fixes: f37d8a4b67b2 ("net/nfp: add NSP FW upload command")
Coverity: 195018
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_nspu.c | 4
1 file changed, 4 insertions(+)
diff --git a/drive
The fstat function could return a value that indicates an error condition.
If this is not checked, the error condition may not be handled correctly.
Fixes: f37d8a4b67b2 ("net/nfp: add NSP FW upload command")
Coverity: 195019
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_
We do not know how big can the BAR be, but we know anything less
than 1MB is an error. This BAR needs to be big enough for accessing
most of NFP internals.
Fixes: d12206e00590 ("net/nfp: add NSP user space interface")
Coverity: 195024
Signed-off-by: Alejandro Lucero
---
drive
First, the received pointer was not checked before. Then the pointer
from malloc was not the one used in the existing check.
Fixes: ad60bca34899 ("net/nfp: read PF port MAC addr using NSP")
Coverity: 195027
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_nspu.c | 6
Memory allocated was not being released in any exit path.
Fixes: 48e2255f1b63 ("net/nfp: add NSP support for HW link configuration")
Coverity: 195030
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_nspu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/nfp/
We have two problems here. First the jumbo frame check should not be
there at all. Then, the configuration should not fail in any case
related to CRC striping.
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp
Wrong patch.
I have removed it from patchwork.
On Fri, Nov 17, 2017 at 6:23 PM, Alejandro Lucero <
alejandro.luc...@netronome.com> wrote:
> We have two problems here. First the jumbo frame check should not be
> there at all. Then, the configuration should not fail in any case
>
The wrong mtu length was used for configuring the hardware. The
max_rx_pktlen reported was also wrong.
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
When jumbo frames is configured, the hardware mtu needs to be updated to
the specified max_rx_pkt_len. Also, changing mtu should be avoided once
the PMD port started.
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp
NFP does CRC strip by default and it is not configurable. But, even
if an app requests not to do it, that should not be a reason for PMD
configuration failure.
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp
Some apps can enable RSS but not update the reta table nor the hash.
This patch adds a default reta table setup based on total number of
configured rx queues. The hash key is dependent on how the app
configures the rx_conf struct.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c
We are seeing same performance drops but in our case is 16.11.3 compared
against 17.05.2 and 17.08.
That is when DPDK is used with SRIOV inside VMs, and the only change is the
DPDK version. Similar tests but using SRIOV in the host don't have such a
drop.
One change that could impact performance
On Mon, Nov 27, 2017 at 5:58 PM, Walker, Benjamin wrote:
> On Sun, 2017-11-05 at 01:17 +0100, Thomas Monjalon wrote:
> > Hi, restarting an old topic,
> >
> > 05/01/2017 16:52, Tan, Jianfeng:
> > > On 1/5/2017 5:34 AM, Walker, Benjamin wrote:
> > > > > > Note that this
> > > > > > probably means t
On Tue, Nov 28, 2017 at 5:50 PM, Walker, Benjamin wrote:
> On Tue, 2017-11-28 at 14:16 +0000, Alejandro Lucero wrote:
> >
> >
> > On Mon, Nov 27, 2017 at 5:58 PM, Walker, Benjamin <
> benjamin.wal...@intel.com>
> > wrote:
> > > On Sun, 2017-11-05 at 0
Acked-by: Alejandro Lucero
On Thu, Jan 25, 2018 at 9:01 AM, Harry van Haaren <
harry.van.haa...@intel.com> wrote:
> This commit aligns the names for dynamic logging with
> the newly defined logging format.
>
> Signed-off-by: Harry van Haaren
>
> ---
>
> M
Other NICs with VF support do not use the _pf suffix for these files
but just for the VF description.
This change makes NFP files consistent in this regard and helps with
how the DPDK web nics features matrix shows NFP devices.
Signed-off-by: Alejandro Lucero
---
doc/guides/nics/features
Although this can be done by the app, because other PMDs are doing it,
apps expect this behaviour from the PMD.
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index e5bfde6
("nfp: add Rx and Tx")
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 5180a31..fc501d6 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drive
Mixing numeric macros with bit shifts macros is not a good idea.
Fixes: 011411586e03 ("net/nfp: extend speed capabilities advertised")
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
My english is far worse than those from the marketing team.
Signed-off-by: Alejandro Lucero
---
doc/guides/nics/nfp.rst | 43 ++-
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a/doc/guides/nics/nfp.rst b/doc/guides/nics/nfp.rst
index
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index fd4dd39..6078e9f 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -1522,7
The mbuf ol_flags field was changed to uin64_t with DPDK version 1.8
Fixes: b812daadad0d (\"nfp: add Rx and Tx\")
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drive
Even with tx checksum offload available, do not set the flag by default.
Fixes: b812daadad0d (\"nfp: add Rx and Tx\")
Signed-off-by: Alejandro Lucero
---
drivers/net/nfp/nfp_net.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net.c b/d
Hi Jay,
I saw these errors when I worked in the HPC sector. They come usually with
a kernel dump for each core in the machine so you can know, after some
peering at the kernel code, how the soft lockup triggers. When I did that
it was always an issue with the memory.
So those times that you can s
Inside this function mbuf_data_room_size is set to a default value if
opaque_arg is null and it should be set to the value pointed by opaque_arg
if not null. Current implementation is using not the value but with the
pointer itself. I think this:
roomsz = (uint16_t)(uintptr_t)opaque_arg;
Hi Olivier,
On Fri, Jan 9, 2015 at 2:28 PM, Olivier MATZ wrote:
> Hi Alejandro,
>
> On 01/09/2015 03:12 PM, Alejandro Lucero wrote:
> > Inside this function mbuf_data_room_size is set to a default value if
> > opaque_arg is null and it should be set to the value pointed b
Hi David,
On Wed, Oct 21, 2015 at 6:24 AM, David Marchand
wrote:
> Hello Alejandro,
>
> On Fri, Oct 16, 2015 at 12:45 PM, Alejandro.Lucero <
> alejandro.lucero at netronome.com> wrote:
>
>> From: "Alejandro.Lucero"
>>
>> This patch adds a new UIO kernel driver for supporting PCI VFs with
>> Net
of it or
we definitely find out it is really needed. any chance to accept nfp_uio by
now?
Thanks
On Wed, Oct 21, 2015 at 4:25 PM, Thomas Monjalon
wrote:
> 2015-10-21 15:39, Alejandro Lucero:
> > On Wed, Oct 21, 2015 at 6:24 AM, David Marchand <
> david.marchand at 6wind
On Wed, Oct 21, 2015 at 5:03 PM, Thomas Monjalon
wrote:
> 2015-10-21 16:57, Alejandro Lucero:
> > I understand interest for not having another UIO driver does exist. We
> > could maintain an external nfp_uio by now till either we get rid of it or
> > we definitely find ou
to do (pci mask
will be wrong). So, would it be acceptable to submit a new PMD without any
documentation by now? I prefer this for the sake of integration than giving
wrong or incomplete documentation.
Thanks
On Wed, Oct 21, 2015 at 8:40 PM, Alejandro Lucero <
alejandro.lucero at netronome.
I have seen the API definition says nothing about accuracy but some PMD
implementations sacrifice accuracy for the sake of performance. If I'm not
understanding the code wrongly i40e and ixgbe check DD bit just for the
first descriptor in a group of 4, and they take all of them as used if the
firs
Yes. It will build by now.
Once we add the PF then BSP will be needed. I guess this is the same for
MLX PMDs needing specific Mellanox libraries.
On Wed, Nov 4, 2015 at 3:03 PM, Thomas Monjalon
wrote:
> 2015-11-02 12:25, Alejandro.Lucero:
> > +Before using the Netronome's DPDK PMD some NFP-6xxx
Yes, this is true.
There is a internal Netronome project for upstreaming the netdev kernel
driver along with a BSP driver.
PMD support will be in the BSP.
There is a public github repo with current drivers:
https://github.com/Netronome/nfp-drv-kmods
On Thu, Nov 5, 2015 at 10:59 AM, Vincent JAR
Yes.
There was a bug in 1.8 affecting how BARs are used in the device, but this
should be fixed in 2.2
On Thu, Nov 5, 2015 at 11:42 PM, Stephen Hemminger <
stephen at networkplumber.org> wrote:
> On Thu, 05 Nov 2015 11:59:59 +0100
> Vincent JARDIN wrote:
>
> >
> > On 05/11/2015 11:43, Alejandro
I tried to do that but there is some issue with the inlining. I think this
is due to inline keyword being processed (also) as static by the compiler.
On Wed, Nov 25, 2015 at 4:29 PM, Stephen Hemminger <
stephen at networkplumber.org> wrote:
> On Wed, 25 Nov 2015 16:19:51 +
> "Alejandro.Lucero
Signed-off-by: Alejandro Lucero
Signed-off-by: Rolf Neugebauer
---
drivers/net/nfp/nfp_net.c | 179 +
1 file changed, 179 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 8451a49..fc02916 100644
--- a/drivers
Signed-off-by: Alejandro Lucero
Signed-off-by: Rolf Neugebauer
---
drivers/net/nfp/nfp_net.c | 218 +
1 file changed, 218 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 7e30774..8451a49 100644
--- a/drivers
.
- Moving the documentation files to a new patch file.
- Adding info to MAINTAINERS and release files.
Alejandro Lucero (9):
nfp: basic initialization
nfp: adding rx/tx functionality
nfp: adding rss
nfp: adding stats
nfp: adding link functionality
nfp: adding extra functionality
nfp: link
Signed-off-by: Alejandro Lucero
Signed-off-by: Rolf Neugebauer
---
drivers/net/nfp/nfp_net.c | 191 +
1 file changed, 191 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 567ea26..5383f51 100644
--- a/drivers
Signed-off-by: Alejandro Lucero
Signed-off-by: Rolf Neugebauer
---
drivers/net/nfp/nfp_net.c | 96 +
1 file changed, 96 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index fc02916..567ea26 100644
--- a/drivers/net
Signed-off-by: Alejandro Lucero
Signed-off-by: Rolf Neugebauer
---
drivers/net/nfp/nfp_net.c | 123 +
1 file changed, 123 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 5383f51..3763790 100644
--- a/drivers
Signed-off-by: Alejandro Lucero
Signed-off-by: Rolf Neugebauer
---
doc/guides/nics/index.rst |1 +
doc/guides/nics/nfp.rst | 265 +
2 files changed, 266 insertions(+)
create mode 100644 doc/guides/nics/nfp.rst
diff --git a/doc/guides/nics
Signed-off-by: Alejandro Lucero
Signed-off-by: Rolf Neugebauer
---
drivers/net/nfp/nfp_net.c | 993 +
1 file changed, 993 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 18067c0..7e30774 100644
--- a/drivers
Signed-off-by: Alejandro Lucero
Signed-off-by: Rolf Neugebauer
---
MAINTAINERS |1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index df5b962..ece737a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -317,6 +317,7 @@ F: app/test/test_pmd_ring_perf.c
Null PMD
M
Signed-off-by: Alejandro Lucero
Signed-off-by: Rolf Neugebauer
---
MAINTAINERS |3 +
config/common_linuxapp |6 +
doc/guides/rel_notes/release_2_2.rst|4 +
drivers/net/Makefile|1 +
drivers/net/nfp/Makefile
401 - 500 of 569 matches
Mail list logo
