econd_range
HASH: Can't generate m-sequence due to period overflow
EAL: Test assert test_adjust_tuple line 559 failed: can not adjust
tuple, ret -17
---
> +
> + for (i = 0; i < (TUPLE_SZ / 4); i++)
> + tmp_tuple[i] =
> + rte_be_to_cpu_32(*(uint32_t *)&tuple[i * 4]);
> +
> + hash = rte_softrss(tmp_tuple, TUPLE_SZ / 4, new_key);
> + RTE_TEST_ASSERT((hash & HASH_MSK(reta_sz)) ==
> + desired_value, "bad desired value\n");
> +
> + rte_thash_free_ctx(ctx);
> +
> + return TEST_SUCCESS;
> +}
--
David Marchand
aid,
> Reviewed-by: Juraj Linkeš
This patch is wrong.
It fixes the qualcomm doc part while it should go in:
http://patchwork.dpdk.org/project/dpdk/patch/20210429080644.11423-1-thierry.herbe...@6wind.com/
It fixes kunpeng and cn10k, so the fixes line is wrong.
Please drop it, I already submitted a different fix for the latter.
--
David Marchand
On Thu, Apr 29, 2021 at 11:53 AM Juraj Linkeš
wrote:
> > -Original Message-
> > From: dev On Behalf Of David Marchand
> > Sent: Thursday, April 29, 2021 9:08 AM
> > To: dev@dpdk.org
> > Cc: tho...@monjalon.net; Jerin Jacob ; Ruifeng Wang
> > ; Jan Vik
.1 spec is that GSO can be
> used independently of CSUM. There is nothing preventing to
> send a fully checksummed TSO packet.
This forces a superfluous cksum in such a situation.
It can be fixed later if needed.
The virtio pmd rx side has the same behavior.
> Anyways, that's unusual and not the goal of this patch.
>
> Acked-by: Flavio Leitner
Thanks!
--
David Marchand
On Thu, Apr 29, 2021 at 3:30 PM Maxime Coquelin
wrote:
> On 4/29/21 10:04 AM, David Marchand wrote:
> > The vhost library current configures Tx offloading (PKT_TX_*) on any
>
> s/current/currently/
Ok.
>
> > packet received from a guest virtio device which asks for some
ample (this current patch),
- maintain the v21 ABI
* using symbol versioning, this adds no branch, recompiled
application use the new ABI, this can't be backported to 20.11,
* keeping the current behavior by default, but introducing a new
flag that an application would pass to rte_vhost_driver_register().
This new flag triggers this current patch behavior but it would add an
additional branch per packets bulk in vhost dequeue path. This *could*
be backported to 20.11.
--
David Marchand
VIRTIO_NET_HDR_GSO_ECN and VIRTIO_NET_HDR_GSO_UDP,
--
David Marchand
David Marchand (4):
mbuf: mark old offload flag as deprecated
net/virtio: do not touch Tx offload flags
net/virtio: refactor Tx offload helper
vhost: fix offload flags in Rx path
doc/guides/prog_guide/vhost_lib.rst | 12
PKT_RX_EIP_CKSUM_BAD has been declared deprecated but there was no
warning to applications still using it.
Fix this by marking as deprecated with the newly introduced
RTE_DEPRECATED.
Fixes: e8a419d6de4b ("mbuf: rename outer IP checksum macro")
Signed-off-by: David Marchand
Reviewed-
Tx offload flags are of the application responsibility.
Leave the mbuf alone and use a local storage for implicit tcp checksum
offloading in case of TSO.
Signed-off-by: David Marchand
Reviewed-by: Maxime Coquelin
Acked-by: Flavio Leitner
---
drivers/net/virtio/virtqueue.h | 6 --
1 file
Purely cosmetic but it is rather odd to have an "offload" helper that
checks if it actually must do something.
We already have the same checks in most callers, so move this branch
in them.
Signed-off-by: David Marchand
Reviewed-by: Flavio Leitner
Reviewed-by: Ruifeng Wang
Reviewed-
RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS flag is added to enable the
new behavior.
The vhost example has been updated for the new behavior: TSO is applied to
any packet marked LRO.
Fixes: 859b480d5afd ("vhost: add guest offload setting")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Reviewed-by: Maxim
On Mon, May 3, 2021 at 3:27 PM David Marchand wrote:
>
> PKT_RX_EIP_CKSUM_BAD has been declared deprecated but there was no
> warning to applications still using it.
> Fix this by marking as deprecated with the newly introduced
> RTE_DEPRECATED.
>
> Fixes: e8a419d6de4b (&
x27;t get
fixed by this change.
I'd rather not backport it.
Opinions?
--
David Marchand
On Mon, May 3, 2021 at 5:24 PM Maxime Coquelin
wrote:
> On 5/3/21 3:26 PM, David Marchand wrote:
> > The important part is the last patch on vhost handling of offloading
> > requests coming from a virtio guest interface.
> >
> > The rest are small fixes that I accumulat
on net/tap,
- added missing bits in example/vhost,
- relaxed checks on VIRTIO_NET_HDR_GSO_ECN and VIRTIO_NET_HDR_GSO_UDP,
--
David Marchand
David Marchand (3):
net/virtio: do not touch Tx offload flags
net/virtio: refactor Tx offload helper
vhost: fix offload flags in Rx path
doc/guides
Tx offload flags are of the application responsibility.
Leave the mbuf alone and use a local storage for implicit tcp checksum
offloading in case of TSO.
Signed-off-by: David Marchand
Reviewed-by: Maxime Coquelin
Acked-by: Flavio Leitner
---
drivers/net/virtio/virtqueue.h | 6 --
1 file
Purely cosmetic but it is rather odd to have an "offload" helper that
checks if it actually must do something.
We already have the same checks in most callers, so move this branch
in them.
Signed-off-by: David Marchand
Reviewed-by: Flavio Leitner
Reviewed-by: Ruifeng Wang
Reviewed-
RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS flag is added to enable the
new behavior.
The vhost example has been updated for the new behavior: TSO is applied to
any packet marked LRO.
Fixes: 859b480d5afd ("vhost: add guest offload setting")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Reviewed-by: Maxim
On Mon, May 3, 2021 at 8:35 PM Stanisław Kardach wrote:
> On Mon, 3 May 2021, 16:28 Olivier Matz, wrote:
>> On Mon, May 03, 2021 at 04:21:25PM +0200, David Marchand wrote:
>> > On Mon, Apr 12, 2021 at 10:29 AM Stanislaw Kardach
>> > wrote:
>> > >
&g
ll fail
> as if implementation is wrong (which one can argue is). Therefore this
> patchset
> tries to give user a way to check whether a lock_free is supported or not both
> at compile time (build flag) and at runtime (ENOTSUP errno in
> rte_stack_create).
Series applied.
Thanks Stanislaw!
--
David Marchand
On Tue, Apr 27, 2021 at 6:02 PM Dharmik Thakkar wrote:
>
> - Add debug counters for objects put/get to/from the common pool.
> - Make __MEMPOOL_STAT_ADD() more generic
>
Series applied, thanks.
--
David Marchand
rue);
> +
> vf->vf_reset = false;
Not checking for the return code can leave the device in an invalid state.
Then after this, calling the init code will fail.
I'd rather move rte_pci_set_bus_master() (it is a noop if bus master
is already enabled) in the init path and check for the return code
there?
WDYT?
--
David Marchand
licon kunpeng")
Signed-off-by: David Marchand
Reviewed-by: Jerin Jacob
Reviewed-by: Ruifeng Wang
---
Changes since v1:
- made use of an anonymous string literal instead of comments,
- dropped the #guide_doc tag,
---
config/arm/meson.build| 21 +++
.../l
ectories.
Can we have a default behavior where only committed files are considered?
Maybe filtering with git ls-files **/meson.build.
--
David Marchand
e_errno;
> }
We have a double free with this change.
If realloc on stats returns the same location, but node lookup fails,
stats_in is left untouched and still points at the original stats
location.
This location is then freed in the free: label, and later is freed in
stats_mem_fini() from caller.
--
David Marchand
On Wed, May 5, 2021 at 4:56 AM Wang, Haiyue wrote:
>
> > -Original Message-
> > From: David Marchand
> > Sent: Tuesday, May 4, 2021 19:32
> > To: Wang, Haiyue
> > Cc: dev ; Zhang, Qi Z ; Wang, Liang-min
> > ;
> > Wu, Jingjing ; Xing, Bei
callbacks = new_callbacks;
+
while (i < num_callbacks && strcmp(cmd, callbacks[i].cmd) > 0)
i++;
if (i != num_callbacks)
And there is a race to fix in list_commands() (which accesses the
callbacks array without taking the lock).
--
David Marchand
mmands to collect
> driver stats? Is this upstream able?
I don't remember a limitation/guideline on this subject.
Any command can be registered, this is up to the telemetry client to invoke it.
--
David Marchand
as a local agent for the system hosting the dpdk
process and forward the retrieved data to another "central" collectd,
using the "network"
https://collectd.org/wiki/index.php/Networking_introduction
With collectd plugins, it also opens the possibility to gather other
metrics (out of dpdk) from this system and/or publish in different
forms the collected data.
--
David Marchand
Most of the checks on developer_mode have been accidentally dropped.
Restore them.
Fixes: 7d611e35b077 ("lib: simplify main build file")
Signed-off-by: David Marchand
---
lib/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/meson.build b/lib/m
Add a check on versioned symbol duplicates in map files.
Signed-off-by: David Marchand
---
Changes since v1:
- rebased,
---
devtools/check-symbol-maps.sh | 15 +++
1 file changed, 15 insertions(+)
diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh
index
Hook check-symbol-maps.sh in the symbol check when in developer mode to
help developers catch issues before submitting their changes.
Signed-off-by: David Marchand
---
Changes since v1:
- now that we have the developer mode, added this check in the build
process,
---
buildtools/check
of fairness in final wakeup notification distribution
>in burst mode. Though this issue was not observed, the change is in
>line with the functional tests.
Series applied, thanks.
--
David Marchand
On Tue, Mar 23, 2021 at 6:48 PM Piotr Kubaj wrote:
>
> Looks like I forgot to commit the change that includes headers for
> sysctlbyname().
>
> Patch attached.
The mailing list drops attachments.
Please submit a v2.
Thanks.
--
David Marchand
I'll post my suggestion as a patch aimed at 21.08.
--
David Marchand
being registered at the same time.
> > This is now fixed to lock before iterating the list,
> > and unlock afterwards.
> >
> > Fixes: f38748736eb2 ("telemetry: add default callback commands")
> > Cc: sta...@dpdk.org
> >
> > Reported-by: David Marc
On Wed, May 5, 2021 at 6:30 PM Tyler Retzlaff
wrote:
>
> On Fri, Mar 12, 2021 at 09:07:22AM +0100, David Marchand wrote:
> > On Thu, Mar 11, 2021 at 10:08 PM Tyler Retzlaff
> > wrote:
> > >
> > > Avoid expanding v and mul parameters multiple times in the macr
On Tue, May 4, 2021 at 2:43 PM David Marchand wrote:
>
> Keep the list of socs in a single place and include it so that the
> documentation won't get outdated.
>
> Fixes: 8f5ea6a464ac ("config/arm: fix implementer and its SoCs")
> Fixes: 1b4c86a721c9 ("c
intel/master
dpdk-next-net-mlx/master
dpdk-next-net-mrvl/master
dpdk-next-net/master
dpdk-next-pipeline/master
dpdk-next-virtio/master
dpdk/HEAD -> dpdk/master
dpdk/master
Those remote tracking branches can be dropped.
--
David Marchand
This code is not performance sensitive and can be switched to dynamic
allocations.
Signed-off-by: David Marchand
---
lib/telemetry/rte_telemetry.h | 2 +-
lib/telemetry/telemetry.c | 15 +--
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/lib/telemetry
Fixes: ce9efbf5bb09 ("bus/fslmc: support dynamic logging")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/bus/fslmc/fslmc_logs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h
index dd74cb7dcf..
Fixes: 653242c3375a ("event/dpaa2: add self test")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/event/dpaa2/dpaa2_eventdev_logs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/event/dpaa2/dpaa2_eventdev_logs.h
b/drivers/event/dpaa2/dpaa2_eventdev_lo
) would leak the associated
thread resources. I leave it to this driver maintainer to comment/fix.
- The vhost library also lets a service thread in the background but since
there is no way to unitialize this library, there is no leak to fix from
my pov.
--
David Marchand
David Marchand (2
("net/ark: integrate PMD")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/net/ark/ark_pktgen.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ark/ark_pktgen.c b/drivers/net/ark/ark_pktgen.c
index 28a44f7546..515bfe461c 100644
--- a/drivers/net/ark/ark_pktgen
ds.
Fixes: 3b3757bda3c3 ("net/ice: get VF hardware index in DCF")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/net/ice/ice_dcf_parent.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c
index c8e433239
Fixes: 06c7871dde01 ("eal: restrict default plugin path to shared lib mode")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
lib/eal/common/eal_common_options.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/eal/common/eal_common_options.c
te_calloc.
Fixes: 5f0978e96220 ("net/ice/base: add OS specific implementation")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
drivers/net/ice/base/ice_osdep.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_osdep.h b/drivers/net/ice/base/i
Testing OVS build against 21.05-rc2 revealed some issues.
Bits were also missing on OVS side, so for people interested, a
rebased dpdk-latest OVS branch is available at:
https://github.com/david-marchand/ovs/commits/dpdk-latest
--
David Marchand
David Marchand (2):
net: add endianness
reuse ethernet header
definition in flow item") and commit a56a262e3408 ("ethdev: reuse VLAN
header definition in flow item").
Signed-off-by: David Marchand
---
lib/net/rte_ether.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/net/rte_ether.h b/lib/n
eeBSD support"
This is a check enforced by OVS itself.
See [1] for some context.
1: https://github.com/openvswitch/ovs/commit/b2befd5bb2db
Fixes: 89813a522e68 ("net: provide IP-related API on any OS")
Signed-off-by: David Marchand
---
lib/net/rte_ip.h | 2 +-
1 file changed, 1 inse
evice;
> + /**< Driver info. supplied by probing */
> + const char *driver_name;
> +
> + /**< Device name */
> + char name[RTE_DMADEV_NAME_MAX_LEN];
> +} __rte_cache_aligned;
> +
I see no queue/channel notion.
How does a rte_dmadev object relate to a physical hw engine?
--
David Marchand
On Wed, Jun 16, 2021 at 6:26 PM wrote:
>
> From: Owen Hilyard
>
> The directory steam was not closed when the hugepage action was
> HUGEPAGE_CHECK_EXISTS. This caused a memory leak in some parts of
> the unit tests.
>
> Signed-off-by: Owen Hilyard
Reviewed-by: Dav
;);
> + cmdline_free(cl);
> return -1;
> }
>
> /* void functions */
> cmdline_stdin_exit(NULL);
> -
> + if (cl != NULL)
> + cmdline_free(cl);
We made sure cl != NULL above, no nee
On Wed, Jun 16, 2021 at 6:37 PM David Marchand
wrote:
>
> On Wed, Jun 16, 2021 at 6:26 PM wrote:
> >
> > From: Owen Hilyard
> >
> > The directory steam was not closed when the hugepage action was
> > HUGEPAGE_CHECK_EXISTS. This caused a memory leak in som
process did not initialise correctly, but it tried
to cleanup afterwards... per chance, do you have a crash reported in
syslog?
--
David Marchand
'numa': false
> > }
>
> Any comment or ack?
$ meson setup build-centriq --cross-file config/arm/arm64_centriq2400_linux_gcc
...
Compiler for C supports arguments -Wno-missing-field-initializers
-Wmissing-field-initializers: YES
config/arm/meson.build:226:0: ERROR: Duplicate dictionary key: part_number
--
David Marchand
r is reported only once for each function it appears in
$ git grep SFC_ETHDEV_STARTED
drivers/net/sfc/sfc_flow.c: if (sa->state != SFC_ETHDEV_STARTED) {
--
David Marchand
wd: add forwarding port mapping option")
> Cc: sta...@dpdk.org
>
> Signed-off-by: SunChengLian
Reviewed-by: David Marchand
--
David Marchand
break;
> -
> case CMD_LINE_OPT_NO_MAC_UPDATING_NUM:
> mac_updating = 0;
> break;
> --
> 2.25.1
>
Reviewed-by: David Marchand
--
David Marchand
alEdge does not
> accept any liability for virus infected mails.
This trailer does not make sense on a public mailing list.
Please ask your IT to remove it.
Thanks!
--
David Marchand
d could success to merge, thanks.
How did you test this work?
UNH recently started testing with ASAN and it reveals leaks just in
the unit test.
Merging these annotations will help catch more issues.
But users will hit the current issues that we must fix first.
--
David Marchand
town Industrial Park, Leixlip, County Kildare
> Registered Number: 308263
>
>
> This e-mail and any attachments may contain confidential material for the sole
> use of the intended recipient(s). Any review or distribution by others is
> strictly prohibited. If you are not the intended recipient, please contact the
> sender and delete all copies.
Please ask your IT to get this trailer removed.
--
David Marchand
han@wsfd-netdev66 dpdk]$ cat
/usr/lib/gcc/x86_64-redhat-linux/10/libatomic.so
INPUT ( /usr/lib64/libatomic.so.1.2.0 )
[dmarchan@wsfd-netdev66 dpdk]$ file /usr/lib64/libatomic.so.1.2.0
/usr/lib64/libatomic.so.1.2.0: cannot open
`/usr/lib64/libatomic.so.1.2.0' (No such file or directory)
[dmarchan@wsfd-netdev66 dpdk]$ meson --version
0.55.3
--
David Marchand
On Mon, Jun 21, 2021 at 2:41 PM Lance Richardson
wrote:
>
> On Tue, May 11, 2021 at 10:42 AM Lance Richardson
> wrote:
> >
> > On Tue, May 11, 2021 at 10:31 AM David Marchand
> > wrote:
> > >
> > > On Fri, Mar 26, 2021 at 5:37 PM Lance Richardson
ade to remove the for loop entirely.
>
> Fixes: f7e861e21c ("rib: support IPv6")
Cc: sta...@dpdk.org
>
> Signed-off-by: Owen Hilyard
Vladimir, can you review this fix?
Thanks!
--
David Marchand
e regardless of the result of the
f_delete() op.
The same is done out of the loop which means this function returns
-EINVAL and frees the rule in this case too.
Bernard, Ferruh, can you review please?
Thanks!
--
David Marchand
or a runtime compat issue?
A good title makes life easier for users and people maintaining stable
versions of DPDK.
--
David Marchand
ate in the title that the mlx5 driver can now handle
correctly rdma-core 35.
Additionally, it could indicate which feature X is now behaving as intended.
But if feature X is something internal to the mlx5 driver, it is worth skipping.
--
David Marchand
")
> >
> > Signed-off-by: Owen Hilyard
> This patch should be backported.
> Please add the following line after the Fixes line:
> Cc: sta...@dpdk.org
I'll add it when applying, no need for a v3.
Thanks.
--
David Marchand
This hack was needed with the make build system.
With meson, any private header from a library is visible as long as a
dependency to this library is expressed.
Signed-off-by: David Marchand
---
app/test/test_eal_fs.c | 3 +--
app/test/test_memzone.c| 3 ++-
app/test
.11, as they have been experimental for >= 2yrs at
> this point.
Just an additional comment.
Marking stable is not the only choice.
We can also consider hiding such symbols (marking internal) if there
is no clear usecase out of DPDK.
--
David Marchand
dk.org
>
> Signed-off-by: Owen Hilyard
Acked-by: Bernard Iremonger
Applied, thanks.
--
David Marchand
gned-off-by: Owen Hilyard
Acked-by: Vladimir Medvedkin
Applied, thanks.
--
David Marchand
; > printf("Error: failed to open /dev/null for reading!");
> > + cmdline_free(cl);
> > return -1;
> > }
>
> The cmdline_free(cl) after a if (cl == NULL) is not needed.
I took the liberty of doing the change when applying and added your ack.
Thanks.
--
David Marchand
e: tests")
Updated sha1.
Cc: sta...@dpdk.org
>
> Signed-off-by: Owen Hilyard
> Reviewed-by: David Marchand
Acked-by: Olivier Matz
Applied, thanks.
--
David Marchand
lags")
Cc: sta...@dpdk.org
> Signed-off-by: Owen Hilyard
Reviewed-by: David Marchand
Applied, thanks.
--
David Marchand
gt;
> Signed-off-by: David Christensen
Reviewed-by: David Marchand
Looking at
http://patchwork.dpdk.org/project/dpdk/patch/20210623204355.74362-1-...@linux.vnet.ibm.com/,
I understand it should be merged after this current patch.
Can you confirm?
--
David Marchand
r_enable
> * rte_bbdev_queue_start
> * rte_bbdev_queue_stop
> * rte_bbdev_release
> * rte_bbdev_setup_queues
> * rte_bbdev_start
> * rte_bbdev_stats_get
> * rte_bbdev_stats_reset
> * rte_bbdev_stop
Regardless of removing the experimental status on this API, part of
the symbols listed here are driver-only and should be marked internal.
--
David Marchand
> * rte_comp_op_bulk_free
> * rte_comp_op_free
> * rte_comp_op_pool_create
>
Part of the symbols listed here are driver-only (at least the *_pmd_*
symbols) and should be marked internal.
--
David Marchand
; + * net/iavf
> + * net/mlx5
> + * net/af_xdp
This list will get obsolete.
It looks like a driver capability, so can we have a ethdev feature added?
Then mark drivers that supports this feature.
And the power lib documentation will have a reference to
doc/guides/nics/features.rst.
--
David Marchand
On Thu, Jun 3, 2021 at 6:55 PM David Marchand wrote:
>
> Both "normal" and "dcf" inits have their copy of some firmware loading
> code.
>
> The DSN query is moved in specific parts for the "normal" and "dcf" init.
>
> A common helper i
dk.org/project/dpdk/patch/20210616065257.16044-1-david.march...@redhat.com/
--
David Marchand
ixed with these patches:
http://patchwork.dpdk.org/project/dpdk/patch/20210622024706.1179945-1-sunchengl...@loongson.cn/
http://patchwork.dpdk.org/project/dpdk/patch/20210622024944.1180109-2-sunchengl...@loongson.cn/
Can you test/review them?
Thanks.
--
David Marchand
se drivers maintainers, check nothing is broken.
--
David Marchand
Changes since v2:
- update comment on libarchive link dependency,
Changes since v1:
- address comments on patch2,
David Marchand (2):
net/ice: factorize firmware loading
eal: handle compressed firmwares
.github/workflows
s helper takes care of finding the right firmware file and loading
it.
The adapter active_pkg_type field is set by this helper.
The ice_access macro is removed from the osdep.h header: osdep.h should
only hosts wrappers for base driver code.
Signed-off-by: David Marchand
---
drivers/net/ice/ba
dependency: without libarchive, a
runtime warning is emitted so that users know there is a compressed
firmware.
Windows implementation is left as an empty stub.
Signed-off-by: David Marchand
Reviewed-by: Igor Russkikh
---
Changes since v2:
- added a comment on libarchive link dependency,
Changes since
mode::RTE_ETH_MQ_RX_VMDQ_DCB_RSS' value '7'
[snip]
I guess libabigail is lost because the symbol
rte_eth_rx_mq_mode::ETH_MQ_RX_NONE simply disappeared (because we used
a macro to wrap to the new name).
Maybe we could go the other way: leave the current enums defined as is
and put in place wrappers for new names pointing as old names.
The rest of the code in DPDK would use the new names only.
This comment applies if we want to merge this change in 21.08 and/or
we want to backport this change.
This won't be a problem if we merge this patch in 21.11.
> ---
> We can get the update on v21.11 and remove backward compatibility macros
> on v22.11.
--
David Marchand
s patch fixes this issue by reallocating the device metadata only
if the device is not running.
WDYT?
> virtqueues, a vring state change notification is sent to
> notify the application of its disablement. Since the callback
> is supposed to be blocking, it is safe to reallocate it
> afterwards.
--
David Marchand
),
> + 0, vq->numa_node);
> if (resubmit->resubmit_list == NULL) {
> VHOST_LOG_CONFIG(ERR,
> "failed to allocate memory for resubmit
> desc.\n");
> - free(resubmit);
> + rte_free(resubmit);
> return RTE_VHOST_MSG_RESULT_ERR;
> }
>
> --
> 2.31.1
>
--
David Marchand
_socket() and their reallocation is handled
> in numa_realloc().
>
Series lgtm with some little nits.
Thanks Maxime!
--
David Marchand
On Mon, Jun 28, 2021 at 4:22 PM Burakov, Anatoly
wrote:
>
> On 18-Jun-21 10:04 AM, David Marchand wrote:
> > On Fri, Jun 18, 2021 at 9:49 AM Lin, Xueqin wrote:
> >>>> Suggest listing demo code and tool capture information for user to try if
> >>>
t; >
> > Prefix for the title of such a patch should be mem:
Anatoly and Jerin like your patch, but it is still a RFC and there
were comments on a missing release note update and unit test.
Please address those comments and submit a regular patch.
Thanks.
--
David Marchand
mic ops
if cc.get_id() == 'gcc'
+code = '''#include
+void main() { printf("Atomilink me.\n"); }
+'''
+if not cc.links(code, args: '-latomic', name: 'libatomic link check')
+build = false
+reason = 'missing dependency, "libatomic"'
+subdir_done()
+endif
ext_deps += cc.find_library('atomic')
endif
--
David Marchand
> +#endif
> +#ifdef RTE_ETHDEV_DEBUG_TX
> + RTE_LOG_REGISTER(ngbe_logtype_tx, pmd.net.ngbe.tx, DEBUG);
> +#endif
--
David Marchand
_REGISTER_DEFAULT(mlx5_crypto_logtype, NOTICE)
> +RTE_PMD_EXPORT_NAME(MLX5_CRYPTO_DRIVER_NAME, __COUNTER__);
> +RTE_PMD_REGISTER_PCI_TABLE(MLX5_CRYPTO_DRIVER_NAME, mlx5_crypto_pci_id_map);
> +RTE_PMD_REGISTER_KMOD_DEP(MLX5_CRYPTO_DRIVER_NAME, "* ib_uverbs & mlx5_core
> & mlx5_ib");
--
David Marchand
Following commit eeded2044af5 ("log: register with standardized names"),
the new helpers should be preferred so that we can maintain a consistent
naming for logtypes.
Signed-off-by: David Marchand
---
devtools/checkpatches.sh | 8
1 file changed, 8 insertions(+)
diff --git
s configuration in the get_infos op is
wrong, be it 1 or 0.
Idem with LSC.
I don't think enabling LSC works as expected, because this driver does
not report the RTE_ETH_DEV_INTR_LSC capability.
Which leads me to a question for ethdev maintainers.
I am surprised we don't have a capabil
ated if they check ABI.
And in general, we want them to continue testing net/sfc.
I sent a mail to ask for this.
--
David Marchand
og)
> > +{
> > + enetfec_logtype_pmd = rte_log_register("pmd.net.enetfec");
> > + if (enetfec_logtype_pmd >= 0)
> > + rte_log_set_level(enetfec_logtype_pmd, RTE_LOG_NOTICE);
>
> rte_log_register_type_and_pick_level() should be used.
>
> > +}
Please prefer RTE_LOG_REGISTER_DEFAULT().
Thanks.
--
David Marchand
> > +}
>
>
> Since ice PMD needs to check if the firmware file with different name can be
> accessed
> by some kind of order, before doing the final firmware selection. Should we
> also add
> the firmware access API for handling this ?
I don't see the need.
Is the behavior changed for net/ice with this patch?
--
David Marchand
501 - 600 of 8235 matches
Mail list logo
