[dpdk-dev] [PATCH] mk: suppress reference of packed members

error: taking address of packed member 'mlock' of class or structure 'rte_mem_config' may result in an unaligned pointer value [-Werror,-Waddress-of-packed-member] Signed-off-by: Emmanuel Roullit --- mk/toolchain/clang/rte.vars.mk | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH] net/cxgbe: add parenthesis on bitwise operation

clang reports the following error: error: logical not is only applied to the left hand side of this bitwise operator. [-Werror,-Wlogical-not-parentheses] Signed-off-by: Emmanuel Roullit --- drivers/net/cxgbe/cxgbe_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[dpdk-dev] [PATCH] net/qede: correct function declaration syntax

clang reports this error message: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] Signed-off-by: Emmanuel Roullit --- drivers/net/qede/qede_eth_if.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_eth_if.h b/drivers/net

[dpdk-dev] [PATCH] eal: fail eal when no hugepages were found

ase, where nr_hugepages would be 0 as well, is handled earlier. Fixes: 5e823a451261 ("ethdev: remove some VF functions") Signed-off-by: Emmanuel Roullit --- lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_memory

[dpdk-dev] [PATCH] eal: reset driver name pointer on failure

t;eal: fix argument parsing check") Signed-off-by: Emmanuel Roullit --- lib/librte_eal/common/eal_common_devargs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index e403717be..ffa8ad96f 100644

[dpdk-dev] [PATCH] ethdev: remove useless pointer initialization

dev: fix data reset when allocating port") Signed-off-by: Emmanuel Roullit --- lib/librte_ether/rte_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 61f44e218..d7f78c23a 100644 --- a/lib/librte_

[dpdk-dev] [PATCH] vhost: remove unneeded variable assignment

introduce reply ack feature") Signed-off-by: Emmanuel Roullit --- lib/librte_vhost/vhost_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 7343a00a1..3391d5ea5 100644 --- a/lib/librte_vhost/vhost_user.

[dpdk-dev] [PATCH] net/virtio: do not gso when no header is present

~~~ Fixes: 2a51b1091cb5 ("vhost: support indirect descriptor in non-mergeable Rx") Signed-off-by: Emmanuel Roullit --- lib/librte_vhost/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio

[dpdk-dev] [PATCH] rte_table: ensure prev bucket has a valid pointer

Fixes: 43f15e28377f ("table: fix verification on hash bucket header alignment") Signed-off-by: Emmanuel Roullit --- lib/librte_table/rte_table_hash_key16.c | 7 +-- lib/librte_table/rte_table_hash_key32.c | 7 +-- 2 files changed, 10 insertions(+), 4 deletions(-) diff -

[dpdk-dev] [PATCH] net/bonding: remove useless assignment

b042 ("net: align ethdev and eal driver names") Signed-off-by: Emmanuel Roullit --- drivers/net/bonding/rte_eth_bond_pmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 02e34483f..f3ac9e273 1006

[dpdk-dev] [PATCH 2/3] net/cxgbe: remove unused variable usage

Found with clang static analysis: drivers/net/cxgbe/sge.c:900:3: warning: Value stored to 'in_use' is never read in_use += q->size; ^ ~~~ Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API") Signed-off-by: Emmanuel Roullit

[dpdk-dev] [PATCH 3/3] net/cxgbe: remove unused variable

Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API") Signed-off-by: Emmanuel Roullit --- drivers/net/cxgbe/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c index 42051ca01..37b609040 10

[dpdk-dev] [PATCH 1/3] net/cxgbe: init data value before reading seeprom

0x1) && --max_poll); ~ ^ Fixes: 17ba077c5c54 ("net/cxgbe: support register dump") Signed-off-by: Emmanuel Roullit --- drivers/net/cxgbe/base/t4_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/bas

[dpdk-dev] [PATCH v2] mk: suppress error for reference of packed members

aac ("mk: stop on warning only in developer build") Signed-off-by: Emmanuel Roullit --- v2: * Only apply compiler flag on clang >= 4.0 mk/toolchain/clang/rte.toolchain-compat.mk | 4 mk/toolchain/clang/rte.vars.mk | 4 2 files changed, 8 insertions(+) diff --git a

[dpdk-dev] [PATCH] net/bonding: remove useless assignment

db5badb042 ("net: align ethdev and eal driver names") Signed-off-by: Emmanuel Roullit --- drivers/net/bonding/rte_eth_bond_pmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 02e34483f..f3ac9e273 1006

Re: [dpdk-dev] [PATCH v2] mk: suppress error for reference of packed members

Hi Thomas, Thanks for the hints. I will improve the patch and resubmit. Comments are present inline. Regards, - Emmanuel On Wed, Jan 25, 2017 at 11:08 AM, Thomas Monjalon wrote: > 2017-01-24 22:04, Emmanuel Roullit: > > Found with clang build: > > error: taking address o