Ok, I'll send a new version today.
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, June 30, 2020 2:29 AM
> To: Fady Bader
> Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman
> ; Yohad Tor ;
> dmitry.kozl...@gmail.com; harini.ramakrish
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, June 30, 2020 2:26 AM
> To: Fady Bader
> Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman
> ; Yohad Tor ;
> dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com;
> ocard...@microsoft.com;
Function versioning implementation is not supported by Windows.
Function versioning was disabled on Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/include/rte_function_versioning.h | 8
1 file changed, 8 insertions(+)
diff --git a/lib/librte_eal/include
Some eal functions are used by mempool lib but not exported on Windows.
The functions were exported.
Added mempool to supported libraries for Windows compilation.
Signed-off-by: Fady Bader
---
lib/librte_eal/rte_eal_exports.def | 6 ++
lib/librte_eal/rte_eal_version.map | 1 +
lib
mempool used Unix memory management calls, which are not supported
on Windows.
Used generic memory management instead.
Signed-off-by: Fady Bader
---
lib/librte_mempool/rte_mempool.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/lib/librte_mempool
management
patchset.
Fady Bader (3):
eal: disable function versioning on Windows
mempool: use generic memory management
mempool: mempool build on Windows
lib/librte_eal/include/rte_function_versioning.h | 8
lib/librte_eal/rte_eal_exports.def | 6 ++
lib/
> -Original Message-
> From: Kinsella, Ray
> Sent: Thursday, July 2, 2020 5:57 PM
> To: Fady Bader ; dev@dpdk.org
> Cc: Thomas Monjalon ; Tasnim Bashar
> ; Tal Shnaiderman ; Yohad Tor
> ; dmitry.kozl...@gmail.com;
> harini.ramakrish...@microsoft.com; ocard...@mic
> -Original Message-
> From: Thomas Monjalon
> Sent: Sunday, July 5, 2020 11:38 AM
> To: Kinsella, Ray ; Fady Bader
> Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman
> ; Yohad Tor ;
> dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com;
> ocard...@m
Using generic memory management calls instead of Unix memory management
calls for mempool.
Signed-off-by: Fady Bader
---
lib/librte_mempool/rte_mempool.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib
Function versioning implementation is not supported by Windows.
Function versioning was disabled on Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/include/rte_function_versioning.h | 2 +-
lib/meson.build | 5 +
2 files changed, 6 insertions(+), 1
quot;.
v2:
* Replace ifndef of tracepoints with symbol export from memory management
patchset.
Fady Bader (3):
eal: disable function versioning on Windows
mempool: use generic memory management
mempool: mempool build on Windows
lib/librte_eal/include/rte_function_versioning.h |
Some eal functions are used by mempool lib but not exported on Windows.
The functions were exported.
Added mempool to supported libraries for Windows compilation.
Signed-off-by: Fady Bader
---
lib/librte_eal/rte_eal_exports.def | 6 ++
lib/librte_eal/rte_eal_version.map | 1 +
lib
> -Original Message-
> From: David Marchand
> Sent: Sunday, July 5, 2020 3:01 PM
> To: Fady Bader
> Cc: dev ; Thomas Monjalon ; Tasnim
> Bashar ; Tal Shnaiderman ;
> Yohad Tor ; Dmitry Kozlyuk
> ; Harini Ramakrishnan
> ; Omar Cardona
> ; Pallavi Kadam ;
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Sunday, July 5, 2020 3:08 PM
> To: Fady Bader
> Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar
> ; Tal Shnaiderman ; Yohad Tor
> ; harini.ramakrish...@microsoft.com;
> ocard...@microsoft.com; pallavi.ka
Using generic memory management calls instead of Unix memory management
calls for mempool.
Signed-off-by: Fady Bader
---
lib/librte_mempool/rte_mempool.c | 26 --
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.c b/lib
:
* Rebased on current master and v5 of "eal/windows: ring build on Windows".
v2:
* Replace ifndef of tracepoints with symbol export from memory management
patchset.
Fady Bader (3):
eal: disable function versioning on Windows
mempool: use generic memory management
mempool: mempoo
Function versioning implementation is not supported by Windows.
Function versioning was disabled on Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/include/rte_function_versioning.h | 2 +-
lib/meson.build | 5 +
2 files changed, 6 insertions(+), 1
Some eal functions are used by mempool lib but not exported on Windows.
The functions were exported.
Added mempool to supported libraries for Windows compilation.
Signed-off-by: Fady Bader
---
lib/librte_eal/rte_eal_exports.def | 6 ++
lib/meson.build| 2 +-
2 files
> -Original Message-
> From: Thomas Monjalon
> Sent: Sunday, July 5, 2020 11:24 PM
> To: Fady Bader
> Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman
> ; Yohad Tor ;
> dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com;
> ocard...@microsoft.com;
https://code.woboq.org/qt5/include/netinet/in.h.html
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, June 16, 2020 12:04 PM
> To: Fady Bader
> Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman
> ; Yohad Tor ;
> dmitry.kozl...@gmail.com; harini.ramakrish
> -Original Message-
> From: Bruce Richardson
> Sent: Monday, July 6, 2020 11:20 AM
> To: Fady Bader
> Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar
> ; Tal Shnaiderman ; Yohad Tor
> ; dmitry.kozl...@gmail.com;
> harini.ramakrish...@microsoft.com
added comments to unclear code.
v3:
* Rebased on current master and v5 of "eal/windows: ring build on Windows".
v2:
* Replace ifndef of tracepoints with symbol export from memory management
patchset.
Fady Bader (3):
eal: disable function versioning on Windows
mempool: u
Some EAL functions are used by mempool lib but not exported on Windows.
The functions are exported.
Added mempool to supported libraries for Windows compilation.
Signed-off-by: Fady Bader
Acked-by: Olivier Matz
---
lib/librte_eal/rte_eal_exports.def | 6 ++
lib/meson.build
Function versioning implementation is not supported by Windows.
Function versioning is disabled on Windows.
Signed-off-by: Fady Bader
---
doc/guides/windows_gsg/intro.rst | 4
lib/meson.build | 6 +-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/doc
Using generic memory management calls instead of Unix memory management
calls for mempool.
Signed-off-by: Fady Bader
Acked-by: Olivier Matz
Acked-by: Andrew Rybchenko
Reviewed-by: Dmitry Kozlyuk
---
lib/librte_mempool/rte_mempool.c | 26 --
1 file changed, 12
Addded needed files and fixes for windows in order to get
librte_net compiling under Windows.
v3:
* replaced htons with rte_cpu_to_be_16.
* rebased to current master.
Fady Bader (3):
net: fix s_addr redefinition in Windows
net: replace htons with rte_cpu_to_be_16
eal/windows
librte_net wasn't compiling under Windows.
To solve this, needed exports and files were added for Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/windows/include/netinet/in.h
htons wasn't defined in Windows for the minGW compiler.
htons was replaced with rte_cpu_to_be_16 in order to compile
under Windows.
Signed-off-by: Fady Bader
---
lib/librte_net/rte_arp.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/lib/librte_net/rte_ar
s_addr in Windows is defined in windows.h so its
undefined in order to be defined as part of rte_ether_hdr.
Signed-off-by: Fady Bader
---
lib/librte_net/rte_ether.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
index
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, July 8, 2020 12:10 PM
> To: Fady Bader
> Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman
> ; Yohad Tor ;
> dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com;
> ocard...@microsoft.com;
xport list which are implemented in the header and shouldn't be exported.
Fixes: 4b5062755aa74517ed1d7bd ("mempool: allow user-owned cache")
Fixes: 656f2d3ede96902202a1a5f ("mempool: deprecate specific get and put
functions")
Cc: sta...@dpdk.org
Signed-off-by: Fady
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 67 +
lib/librte_eal/windows/include
This patchset splits OS dependent EAL timer functions and implements them for
windows.
Depends-on: series-9374 ("Windows basic memory management")
Fady Bader (2):
timer: move from common to Unix directory
timer: support EAL functions on Windows
lib/librte_eal/common/eal_comm
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 68 +
lib/librte_eal/windows/include
This patchset splits OS dependent EAL timer functions and implements them for
windows.
v2:
* fixing styles and correctness errors
Depends-on: series-9374 ("Windows basic memory management")
Fady Bader (2):
timer: move from common to Unix directory
timer: support EAL fu
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal/unix/eal_ti
From: Fady Bader
This patchset splits OS dependent EAL timer functions and implements them for
windows.
v2:
* fixing styles and correctness errors.
v3:
* fixing correctness, get_tsc_freq was reimplemented.
Depends-on: series-9374 ("Windows basic memory management")
Fad
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 ++
lib/librte_eal/windows/eal_timer.c | 96 +
lib/librte_eal/windows/include/rte_os.h | 2
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal
* fixing styles and correctness errors.
Depends-on: series-9374 ("Windows basic memory management")
Fady Bader (2):
timer: move from common to Unix directory
timer: support EAL functions on Windows
lib/librte_eal/common/eal_common_timer.c | 22
lib/librte_ea
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 96 +
lib/librte_eal/windows/include
Implementation of rte_proc_type_t for Windows as it is needed for Windows
eal timer.
Signed-off-by: Fady Bader
---
lib/librte_eal/windows/eal.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c
index 2cf7a04ef..831179799 100644
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 77 +
lib/librte_eal/windows/include
* fixing styles and correctness errors.
v5:
* breaking the dependency on "Windows basic memory management" series.
* fixing correctness errors and warnings.
Fady Bader (3):
timer: move from common to Unix directory
eal: proc type function for Windows
timer: support EAL functi
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal
* fixing styles and correctness errors.
v5:
* breaking the dependency on "Windows basic memory management" series.
* fixing correctness errors and warnings.
v6:
* fixing styles and correctness errors.
Fady Bader (3):
timer: move from common to Unix directory
eal: proc type
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal
Implementation of rte_proc_type_t for Windows as it is needed for Windows
eal timer.
Signed-off-by: Fady Bader
---
lib/librte_eal/windows/eal.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c
index d084606a6..feee91244 100644
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 86 +
lib/librte_eal/windows/include
(MESHCHANINOV) ; Narcisa
> Ana Maria Vasile ; Fady Bader
> ; Tal Shnaiderman ; Dmitry
> Kozlyuk ; Thomas Monjalon
> ; Harini Ramakrishnan
> ; Omar Cardona
> ; Pallavi Kadam ;
> Ranjit Menon ; John McNamara
> ; Marko Kovacevic
> ; Anatoly Burakov
>
> Subject: [PATC
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Wednesday, May 13, 2020 11:43 AM
> To: Fady Bader
> Cc: dev@dpdk.org; Dmitry Malloy (MESHCHANINOV)
> ; Narcisa Ana Maria Vasile
> ; Tal Shnaiderman ;
> Thomas Monjalon ; Harini Ramakrishnan
> ; Oma
> -Original Message-
> From: Fady Bader
> Sent: Wednesday, May 13, 2020 12:09 PM
> To: Dmitry Kozlyuk
> Cc: dev@dpdk.org; Dmitry Malloy (MESHCHANINOV)
> ; Narcisa Ana Maria Vasile
> ; Tal Shnaiderman ;
> Thomas Monjalon ; Harini Ramakrishnan
> ; Oma
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Wednesday, May 13, 2020 12:39 PM
> To: Fady Bader
> Cc: dev@dpdk.org; Dmitry Malloy (MESHCHANINOV)
> ; Narcisa Ana Maria Vasile
> ; Tal Shnaiderman ;
> Thomas Monjalon ; Harini Ramakrishnan
> ; Oma
ile size_t is 8. I'm trying to make the code compatible for both Linux
and Windows, How do you recommend doing that ?
> + rte_trace_point_emit_ptr(free_cb);
> + rte_trace_point_emit_ptr(opaque);
> +)
> +
Regards,
Fady Bader
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal/fr
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 86 +
lib/librte_eal/windows/include
Implementation of rte_proc_type_t for Windows as it is needed for Windows
eal timer.
Signed-off-by: Fady Bader
---
lib/librte_eal/windows/eal.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c
index d084606a6..feee91244 100644
* fixing styles and correctness errors.
v5:
* breaking the dependency on "Windows basic memory management" series.
* fixing correctness errors and warnings.
v6:
* fixing styles and correctness errors.
v7:
* fixing make errors.
Fady Bader (3):
timer: move from common to
n the export list.
To solve this per_lcore__rte_errno was added to the Windows export
list.
Signed-off-by: Fady Bader
Depends-on: series-9374 ("Windows basic memory management")
---
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/rte_eal_version.map | 5 -
n the export list.
To solve this per_lcore__rte_errno was added to the Windows export
list.
Signed-off-by: Fady Bader
Depends-on: series-9374 ("Windows basic memory management")
---
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/rte_eal_version.map | 3 +++
n the export list.
To solve this per_lcore__rte_errno was added to the Windows export
list.
Signed-off-by: Fady Bader
---
Depends-on: series-9374 ("Windows basic memory management")
v3: Fix style issues.
v2: Fix style issues.
---
lib/librte_eal/rte_eal_exports.def | 1 +
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Thursday, May 21, 2020 7:17 AM
> To: Fady Bader ; dev@dpdk.org
> Cc: Thomas Monjalon ; Tal Shnaiderman
> ; Yohad Tor ;
> olivier.m...@6wind.com; harini.ramakrish...@microsoft.com;
> ocard...@microsoft.co
n the export list.
To solve this per_lcore__rte_errno was added to the Windows export
list.
Signed-off-by: Fady Bader
---
Depends-on: series-9374 ("Windows basic memory management")
v4: rebase on "Windows basic memory management" v5.
v3: Fix style issues.
v2: Fix style is
What should we do with the ABI versioning in Windows ?
Added changes in order to build mempool lib on windows.
Depends-on: patch-70497 ("ring: build on Windows")
Fady Bader (5):
mempool: disable tracing for Windows
eal: disable function versioning on Windows
mempool: use generic memory management
eal: export needed functions f
__rte_trace_mem_per_thread_alloc is used by mempool lib but not exported on
Windows.
the function was exported.
Signed-off-by: Fady Bader
---
lib/librte_eal/rte_eal_version.map | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/rte_eal_version.map
b/lib/librte_eal
Tracing is not supported for Windows.
Disabled all trace calls in for Windows.
Signed-off-by: Fady Bader
---
lib/librte_mempool/mempool_trace_points.c | 4
lib/librte_mempool/rte_mempool.c | 20
lib/librte_mempool/rte_mempool.h | 22
mempool used Unix memory management calls, which are not supported
on Windows.
Used generic memory management instead.
Signed-off-by: Fady Bader
---
lib/librte_mempool/rte_mempool.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/lib/librte_mempool
Mempool didn't compile on Windows.
Needed changes were made to fix this.
Signed-off-by: Fady Bader
---
lib/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/meson.build b/lib/meson.build
index 30ed9e05e..c53732383 100644
--- a/lib/meson.build
+++
Function versioning is not needed on Windows, also the function versioning
implementation is not supported by Windows.
Function versioning was disabled on Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/include/rte_function_versioning.h | 4
1 file changed, 4 insertions(+)
diff
Added changes in order to build mempool lib on windows.
Depends-on: patch-70497 ("ring: build on Windows")
v2:
* Replace ifndef of tracepoints with symbol export from memory management
patchset.
Fady Bader (4):
eal: disable function versioning on Windows
mempool: u
Some eal functions were used by mempool lib but not exported on Windows.
The function was exported.
Signed-off-by: Fady Bader
---
lib/librte_eal/rte_eal_exports.def | 6 ++
lib/librte_eal/rte_eal_version.map | 3 +++
2 files changed, 9 insertions(+)
diff --git a/lib/librte_eal
mempool used Unix memory management calls, which are not supported
on Windows.
Used generic memory management instead.
Signed-off-by: Fady Bader
---
lib/librte_mempool/rte_mempool.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/lib/librte_mempool
Added mempool to supported libraries for Windows compilation.
Signed-off-by: Fady Bader
---
lib/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/meson.build b/lib/meson.build
index 30ed9e05e..c53732383 100644
--- a/lib/meson.build
+++ b/lib/meson.build
Function versioning is not needed on Windows, also the function versioning
implementation is not supported by Windows.
Function versioning was disabled on Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/include/rte_function_versioning.h | 4
1 file changed, 4 insertions(+)
diff
Hi,
I have a few questions regarding your memory management patch.
In the "eal/windows: fix rte_page_sizes with Clang on Windows"
(http://patches.dpdk.org/patch/67390/) patch I didn't understand the work
around that you did and what the problem was.
Regarding rte_mp functions I see you implemente
Addded needed files and fixes for windows in order to get
librte_net compiling under Windows.
Fady Bader (3):
net: fix s_addr redefinition in Windows
net: add htons to minGW for Windows
eal/windows: librte_net build on Windows
lib/librte_eal/common/meson.build | 1 +
lib
s_addr in Windows is defined in windows.h so its
undefined in order to be defined as part of rte_ether_hdr.
Signed-off-by: Fady Bader
---
lib/librte_net/rte_ether.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
index
librte_net wasn't compiling under Windows.
To solve this, needed exports and files were added for Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/windows/include/netinet/in.h
htons wasnt defined in Windows for the minGW compiler.
Definition of htons was added in order to use htons.
Signed-off-by: Fady Bader
---
lib/librte_eal/windows/include/rte_os.h | 4
lib/librte_net/rte_arp.c| 2 ++
2 files changed, 6 insertions(+)
diff --git a/lib
Addded needed files and fixes for windows in order to get
librte_net compiling under Windows.
Depends-on: series-10282 ("build mempool on Windows")
Fady Bader (3):
net: fix s_addr redefinition in Windows
net: add htons to minGW for Windows
eal/windows: librte_net build on Win
s_addr in Windows is defined in windows.h so its
undefined in order to be defined as part of rte_ether_hdr.
Signed-off-by: Fady Bader
---
lib/librte_net/rte_ether.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
index
htons wasnt defined in Windows for the minGW compiler.
Definition of htons was added in order to use htons.
Signed-off-by: Fady Bader
---
lib/librte_eal/windows/include/rte_os.h | 4
lib/librte_net/rte_arp.c| 2 ++
2 files changed, 6 insertions(+)
diff --git a/lib
librte_net wasn't compiling under Windows.
To solve this, needed exports and files were added for Windows.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/windows/include/netinet/in.h
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 90 +
lib/librte_eal/windows/include
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal/fr
oved unneded headers.
Fady Bader (3):
timer: move from common to Unix directory
eal: proc type function for Windows
timer: support EAL functions on Windows
lib/librte_eal/common/eal_common_timer.c | 22
lib/librte_eal/common/meson.build| 1 +
lib/librte_eal/freebsd/Ma
Implementation of rte_proc_type_t for Windows as it is needed for Windows
eal timer.
Signed-off-by: Fady Bader
---
lib/librte_eal/windows/eal.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c
index d084606a6..feee91244 100644
3de30 ("lib: provide initial versioning")
Cc: sta...@dpdk.org
Signed-off-by: Fady Bader
---
lib/librte_meter/rte_meter_version.map | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/librte_meter/rte_meter_version.map
b/lib/librte_meter/rte_meter_version.map
index b493bcebe
3de30 ("lib: provide initial versioning")
Cc: sta...@dpdk.org
Signed-off-by: Fady Bader
---
v2: fixed commit message style issue
---
lib/librte_meter/rte_meter_version.map | 6 --
1 file changed, 6 deletions(-)
diff --git a/lib/librte_meter/rte_meter_version.map
b/lib/librte_met
Sending a new version soon.
> Subject: Re: [PATCH v8 3/3] timer: support EAL functions on Windows
>
>
> On 6/14/2020 1:43 AM, Fady Bader wrote:
> > Implemented the needed Windows eal timer functions.
> >
> > Signed-off-by: Fady Bader
> > ---
> > li
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal/fr
oved unneded headers.
v9:
* rebasing to current master.
* fixing correctness issue.
Fady Bader (2):
timer: move from common to Unix directory
timer: support EAL functions on Windows
lib/librte_eal/common/eal_common_timer.c | 22
lib/librte_eal/common/meson.build|
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 91 +
lib/librte_eal/windows/include
sleep referenced in function set_tsc_freq
The reason was that some functions called POSIX functions.
The solution was to move POSIX dependent functions from common to Unix.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/eal_common_timer.c | 22 --
lib/librte_eal/fr
oved unneded headers.
v9:
* rebasing to current master.
* fixing correctness issue.
v10:
* fixing correctness issue.
Fady Bader (2):
timer: move from common to Unix directory
timer: support EAL functions on Windows
lib/librte_eal/common/eal_common_timer.c | 22
l
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 93 +
lib/librte_eal/windows/include
> -Original Message-
> From: Ranjit Menon
> Sent: Thursday, June 18, 2020 1:16 AM
> To: Fady Bader ; dev@dpdk.org
> Cc: Thomas Monjalon ; Tasnim Bashar
> ; Tal Shnaiderman ; Yohad Tor
> ; dmitry.kozl...@gmail.com;
> harini.ramakrish...@microsoft.com; ocard...@mic
1 - 100 of 152 matches
Mail list logo
