[dpdk-dev] [PATCH 1/7] app/test-pmd: code style fix

2015-01-19 Thread Helin Zhang
Added code style fixes. Signed-off-by: Helin Zhang --- app/test-pmd/config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 97b6525..87dedf9 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1918,11

[dpdk-dev] [PATCH 2/7] ethdev: code style fix

2015-01-19 Thread Helin Zhang
Added code style fixes. Signed-off-by: Helin Zhang --- lib/librte_ether/rte_eth_ctrl.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h index 5d9c387..4308eae 100644 --- a/lib

[dpdk-dev] [PATCH 3/7] i40e: code style fix

2015-01-19 Thread Helin Zhang
Added code style fixes. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_fdir.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_fdir.c b/lib/librte_pmd_i40e/i40e_fdir.c index 68511c8..c9e535b 100644 --- a/lib/librte_pmd_i40e/i40e_fdir.c

[dpdk-dev] [PATCH 4/7] ethdev: fix of calculating the size of flow type mask array

2015-01-19 Thread Helin Zhang
It wrongly calculates the size of the flow type mask array. The fix is to align the flow type maximum index ID with the number of element bit width, and then divide the number of element bit width. Signed-off-by: Helin Zhang --- lib/librte_ether/rte_eth_ctrl.h | 6 +- 1 file changed, 5

[dpdk-dev] [PATCH 5/7] ethdev: unification of flow types

2015-01-19 Thread Helin Zhang
s are made in i40e and testpmd accordingly. Signed-off-by: Helin Zhang --- app/test-pmd/cmdline.c| 88 --- app/test-pmd/config.c | 71 +-- lib/librte_ether/rte_eth_ctrl.h | 55 ++--

[dpdk-dev] [PATCH 6/7] ethdev: unification of RSS offload types

2015-01-19 Thread Helin Zhang
specific hardwares. Signed-off-by: Helin Zhang --- app/test-pipeline/init.c| 2 +- app/test-pmd/config.c | 60 + examples/distributor/main.c | 9 +- examples/ip_pipeline/init.c | 2 +- examples/l3fwd-acl/main.c

[dpdk-dev] [PATCH 7/7] app/testpmd: support new rss offloads

2015-01-19 Thread Helin Zhang
RSS offloads supported 'ip' and 'udp' only, which did not demonstrate all of the hardware capabilities. The modifications adds support of new RSS offloads of 'tcp', 'sctp', 'ether' and 'all'. Signed-off-by: Helin Zhang --- app/tes

[dpdk-dev] [PATCH v9 0/5] Support configuring hash functions

2015-01-22 Thread Helin Zhang
Solved compile errors on ICC. v9 changes: * Added typo fixes in rte_eth_ctrl.h. * Splitted modifications in both rte_eth_ctrl.h and i40e, one patch is for ethdev, the other one is for i40e. Helin Zhang (5): i40e: use constant as the default hash keys ethdev: code style fixes ethdev: su

[dpdk-dev] [PATCH v9 1/5] i40e: use constant as the default hash keys

2015-01-22 Thread Helin Zhang
Calculating the default RSS hash keys at run time is not needed at all, and may have race conditions. The alternative is to use array of random values which were generated manually as the default hash keys. Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev.c | 14 +++--- 1

[dpdk-dev] [PATCH v9 2/5] ethdev: code style fixes

2015-01-22 Thread Helin Zhang
Added code style fixes. Signed-off-by: Helin Zhang --- lib/librte_ether/rte_eth_ctrl.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/librte_ether/rte_eth_ctrl.h index 5d9c387..4b3c5fc 100644 --- a/lib/librte_ether

[dpdk-dev] [PATCH v9 3/5] ethdev: support of configuring hash functions

2015-01-22 Thread Helin Zhang
In order to support hash filter configuration, filter type of hash is added, also the corresponding structures, macros and definitions are added. Signed-off-by: Helin Zhang --- lib/librte_ether/rte_eth_ctrl.h | 63 + 1 file changed, 63 insertions(+) v9

[dpdk-dev] [PATCH v9 4/5] i40e: support of controlling hash functions

2015-01-22 Thread Helin Zhang
Hash filter control has been implemented for i40e. It includes getting/setting, - global hash configurations (hash function type, and symmetric hash enable per flow type) - symmetric hash enable per port Signed-off-by: Helin Zhang --- lib/librte_pmd_i40e/i40e_ethdev.c | 294

[dpdk-dev] [PATCH v9 5/5] app/testpmd: add commands to support hash functions

2015-01-22 Thread Helin Zhang
To demonstrate the hash filter control, commands are added. They are, - get_sym_hash_ena_per_port - set_sym_hash_ena_per_port - get_hash_global_config - set_hash_global_config Signed-off-by: Helin Zhang --- app/test-pmd/cmdline.c | 333 + 1 file

[dpdk-dev] [PATCH 00/17] unified packet type

2015-01-29 Thread Helin Zhang
types and L4 types. All PMDs should translate the offloaded packet types into this 4 fields of information, for user applications. Helin Zhang (17): mbuf: add definitions of unified packet types e1000: support of unified packet type ixgbe: support of unified packet type ixgbe: support of

[dpdk-dev] [PATCH 01/17] mbuf: add definitions of unified packet types

2015-01-29 Thread Helin Zhang
inner L3 type fields, and can be stored in 16 bits mbuf field of 'packet_type'. Signed-off-by: Helin Zhang Signed-off-by: Cunming Liang Signed-off-by: Jijiang Liu --- lib/librte_mbuf/rte_mbuf.h | 74 ++ 1 file changed, 74 insertions(+) diff -

[dpdk-dev] [PATCH 02/17] e1000: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_e1000/igb_rxtx.c | 95 ++--- 1 file changed, 80 insertions(+), 15 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH 03/17] ixgbe: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 141 +- 1 file changed, 107 insertions(+), 34 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH 04/17] ixgbe: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type for Vector PMD. Signed-off-by: Cunming Liang Signed-off-by: Helin Zhang --- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 39 +++ 1 file changed, 21

[dpdk-dev] [PATCH 05/17] i40e: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Signed-off-by: Helin Zhang Signed-off-by: Jijiang Liu --- lib/librte_pmd_i40e/i40e_rxtx.c | 778 ++-- 1 file changed, 504 insertions(+), 274

[dpdk-dev] [PATCH 06/17] bond: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/librte_pmd_bond

[dpdk-dev] [PATCH 07/17] enic: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_enic/enic_main.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/librte_pmd_enic/enic_main.c b

[dpdk-dev] [PATCH 08/17] vmxnet3: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for ol_flags are replaced by unified packet type. Signed-off-by: Helin Zhang --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b

[dpdk-dev] [PATCH 09/17] app/test-pipeline: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- app/test-pipeline/pipeline_hash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app

[dpdk-dev] [PATCH 10/17] app/test-pmd: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- app/test-pmd/csumonly.c | 6 +++--- app/test-pmd/rxonly.c | 9 +++-- 2 files changed, 6 insertions(+), 9

[dpdk-dev] [PATCH 11/17] app/test: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- app/test/packet_burst_generator.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[dpdk-dev] [PATCH 12/17] examples/ip_fragmentation: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- examples/ip_fragmentation/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [PATCH 14/17] examples/l3fwd-acl: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- examples/l3fwd-acl/main.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff

[dpdk-dev] [PATCH 13/17] examples/ip_reassembly: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- examples/ip_reassembly/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [PATCH 15/17] examples/l3fwd-power: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- examples/l3fwd-power/main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/examples

[dpdk-dev] [PATCH 17/17] mbuf: remove old packet type bit masks for ol_flags

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- lib/librte_mbuf/rte_mbuf.c | 6 -- lib/librte_mbuf/rte_mbuf.h | 10 ++ 2 files changed, 2

[dpdk-dev] [PATCH 16/17] examples/l3fwd: support of unified packet type

2015-01-29 Thread Helin Zhang
To unify packet types among all PMDs, bit masks and relevant macros of packet type for ol_flags are replaced by unified packet type and relevant macros. Signed-off-by: Helin Zhang --- examples/l3fwd/main.c | 64 +-- 1 file changed, 37 insertions

[dpdk-dev] [PATCH v9 00/19] unified packet type

2015-07-03 Thread Helin Zhang
. * Reworked newly added cxgbe driver and tep_termination example application to support unified packet type, which is disabled by default. Helin Zhang (19): mbuf: redefine packet_type in rte_mbuf mbuf: add definitions of unified packet types e1000: replace bit mask based packet type with uni

[dpdk-dev] [PATCH v9 01/19] mbuf: redefine packet_type in rte_mbuf

2015-07-03 Thread Helin Zhang
types (UDP, TCP and SCTP) are supported in vectorized ixgbe PMD. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Note that around 2% performance drop (64B) was observed of doing 4 ports (1 port per 82599 card) IO forwarding on t

[dpdk-dev] [PATCH v9 02/19] mbuf: add definitions of unified packet types

2015-07-03 Thread Helin Zhang
type, inner L2 type, inner L3 type and inner L4 type fields, and can be stored in 'struct rte_mbuf' of 32 bits field 'packet_type'. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang

[dpdk-dev] [PATCH v9 04/19] ixgbe: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
d of doing 4 ports (1 port per 82599 card) IO forwarding on the same SNB core. Signed-off-by: Helin Zhang --- drivers/net/ixgbe/ixgbe_rxtx.c | 163 + 1 file changed, 163 insertions(+) v2 changes: * Used redefined packet types and enlarged packet_type fie

[dpdk-dev] [PATCH v9 06/19] enic: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/enic/e

[dpdk-dev] [PATCH v9 07/19] vmxnet3: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/n

[dpdk-dev] [PATCH v9 05/19] i40e: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/i40e/i

[dpdk-dev] [PATCH v9 08/19] fm10k: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/fm10k/fm

[dpdk-dev] [PATCH v9 09/19] cxgbe: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/cxgbe

[dpdk-dev] [PATCH v9 03/19] e1000: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- drivers/net/e1000/

[dpdk-dev] [PATCH v9 10/19] app/test-pipeline: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- app/tes

[dpdk-dev] [PATCH v9 11/19] app/testpmd: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang Signed-off-by: Jijiang Liu

[dpdk-dev] [PATCH v9 13/19] examples/ip_fragmentation: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/ip_fragmentat

[dpdk-dev] [PATCH v9 14/19] examples/ip_reassembly: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/ip_reassem

[dpdk-dev] [PATCH v9 12/19] app/test: Remove useless code

2015-07-03 Thread Helin Zhang
Severl useless code lines are added accidently, which blocks packet type unification. They should be deleted at all. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- app/test

[dpdk-dev] [PATCH v9 15/19] examples/l3fwd-acl: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/l3fwd-acl/m

[dpdk-dev] [PATCH v9 16/19] examples/l3fwd-power: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/l3fwd-power/

[dpdk-dev] [PATCH v9 17/19] examples/l3fwd: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/l3fwd/ma

[dpdk-dev] [PATCH v9 18/19] examples/tep_termination: replace bit mask based packet type with unified packet type

2015-07-03 Thread Helin Zhang
To unify packet types among all PMDs, bit masks of packet type for 'ol_flags' are replaced by unified packet type. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- examples/tep_terminati

[dpdk-dev] [PATCH v9 19/19] mbuf: remove old packet type bit masks

2015-07-03 Thread Helin Zhang
As unified packet types are used instead, those old bit masks and the relevant macros for packet type indication need to be removed. To avoid breaking ABI compatibility, all the changes would be enabled by RTE_NEXT_ABI, which is disabled by default. Signed-off-by: Helin Zhang --- lib

[dpdk-dev] [PATCH v2] doc: announce ABI changes planned for unified packet type

2015-07-03 Thread Helin Zhang
The significant ABI changes are planned for unified packet type which will be supported from release 2.2. Here announces that ABI changes in detail. Signed-off-by: Helin Zhang --- doc/guides/rel_notes/abi.rst | 1 + 1 file changed, 1 insertion(+) v2 changes: * Added 'struct rte_kni_mbu

[dpdk-dev] [PATCH v3] doc: announce ABI changes planned for unified packet type

2015-07-08 Thread Helin Zhang
The significant ABI changes of all shared libraries are planned to support unified packet type which will be taken effect from release 2.2. Here announces that ABI changes in detail. Signed-off-by: Helin Zhang --- doc/guides/rel_notes/abi.rst | 1 + 1 file changed, 1 insertion(+) v2 changes

[dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag

2016-02-22 Thread Helin Zhang
PCIe feature of 'Extended Tag' is important for 40G performance. It adds its enabling during each port initialization, to ensure the high performance. Signed-off-by: Helin Zhang --- doc/guides/rel_notes/release_16_04.rst | 6 drivers/net/i40e/i40e_ethdev.c

[dpdk-dev] [PATCH v2 0/3] enable extended tag for i40e

2016-02-22 Thread Helin Zhang
ngs. - Kept the sys files as they were, and added ABI change announcement for them. - Moved high performance part of i40e from 'GSG' to a new for .nics'. Helin Zhang (3): i40e: enable extended tag eal: remove pci config of extended tag igb_uio: deprecate

[dpdk-dev] [PATCH v2 2/3] eal: remove pci config of extended tag

2016-02-22 Thread Helin Zhang
Remove pci configuration of 'extended tag' and 'max read request size', as they are not required by all devices and it lets PMD to configure them if neccessary. In addition, 'pci_config_space_set()' is deprecated. Signed-off-by: Helin Zhang --- config/common_

[dpdk-dev] [PATCH v2 3/3] igb_uio: deprecate sys files

2016-02-22 Thread Helin Zhang
It deprecated sys files of 'extended_tag' and 'max_read_request_size', and announced the planned ABI changes of them. Signed-off-by: Helin Zhang --- doc/guides/linux_gsg/enable_func.rst | 47 --- doc/guides/nics/i40e.rst

[dpdk-dev] [PATCH v2 0/3] enable extended tag for i40e

2016-02-22 Thread Helin Zhang
ngs. - Kept the sys files as they were, and added ABI change announcement for them. - Moved high performance part of i40e from 'GSG' to a new for .nics'. Helin Zhang (3): i40e: enable extended tag eal: remove pci config of extended tag igb_uio: deprecate

[dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag

2016-02-22 Thread Helin Zhang
PCIe feature of 'Extended Tag' is important for 40G performance. It adds its enabling during each port initialization, to ensure the high performance. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- doc/guides/rel_notes/release_16_04.rst | 6 drivers/net/i40e/i40

[dpdk-dev] [PATCH v2 2/3] eal: remove pci config of extended tag

2016-02-22 Thread Helin Zhang
Remove pci configuration of 'extended tag' and 'max read request size', as they are not required by all devices and it lets PMD to configure them if neccessary. In addition, 'pci_config_space_set()' is deprecated. Signed-off-by: Helin Zhang Acked-by: Jingjing W

[dpdk-dev] [PATCH v2 3/3] igb_uio: deprecate sys files

2016-02-22 Thread Helin Zhang
It deprecated sys files of 'extended_tag' and 'max_read_request_size', and announced the planned ABI changes of them. Signed-off-by: Helin Zhang Acked-by: Jingjing Wu --- doc/guides/linux_gsg/enable_func.rst | 47 --- doc/guides/nics/i40e.rst

[dpdk-dev] [PATCH 00/29] i40e base driver update

2016-01-15 Thread Helin Zhang
i40e base driver is updated, to support new X722 device IDs, and use rx control AQ commands to read/write rx control registers. Of cause, fixes and enhancements are added as listed as below. Helin Zhang (29): i40e/base: use explicit cast from u16 to u8 i40e/base: Acquire NVM, before issuing

[dpdk-dev] [PATCH 01/29] i40e/base: use explicit cast from u16 to u8

2016-01-15 Thread Helin Zhang
Current implementation generates compilation warnings. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_lan_hmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_lan_hmc.c b/drivers/net/i40e/base/i40e_lan_hmc.c index 6511767..2260648

[dpdk-dev] [PATCH 02/29] i40e/base: Acquire NVM, before issuing an AQ read nvm command

2016-01-15 Thread Helin Zhang
It needs to acquire the NVM before issuing an AQ read to the X722 NVM otherwise it will get EBUSY from the FW. Also release when done. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_nvm.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff

[dpdk-dev] [PATCH 03/29] i40e/base: add hw flag for doing the SRCTL access using AQ for X722

2016-01-15 Thread Helin Zhang
Instead of doing the MAC check, use a flag that gets set per MAC. This way there are less chances of user error and it can enable multiple MACs with the capability in a single place rather than cluttering the code with MAC checks. Signed-off-by: Helin Zhang --- drivers/net/i40e/base

[dpdk-dev] [PATCH 04/29] i40e/base: add changes in nvm read to support X722

2016-01-15 Thread Helin Zhang
t can be called from the paths that need the bulk access. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_nvm.c | 109 ++--- drivers/net/i40e/base/i40e_prototype.h | 8 ++- 2 files changed, 92 insertions(+), 25 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH 05/29] i40e/base: Limit DCB FW version checks to XL710/X710 devices

2016-01-15 Thread Helin Zhang
XL710/X710 devices requires FW version checks to properly handle DCB configurations from the FW while other devices (e.g. X722) do not, so limit these checks to XL710/X710 only. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_dcb.c | 34 +- 1 file

[dpdk-dev] [PATCH 06/29] i40e/base: check for stopped admin queue

2016-01-15 Thread Helin Zhang
d-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c index 998582c..e1a162e 100644 --- a/drivers/net/i40e/base/i40e_adminq.c +++ b/drivers/net/i40e

[dpdk-dev] [PATCH 07/29] i40e/base: set aq count after memory allocation

2016-01-15 Thread Helin Zhang
The standard way to check if the AQ is enabled is to look at the count field. So it should only set this field after it has successfully allocated memory. To do otherwise is to incite panic among the populace. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq.c | 4 ++-- 1 file

[dpdk-dev] [PATCH 08/29] i40e/base: clean event descriptor before use

2016-01-15 Thread Helin Zhang
In one obscure corner case, it was possible to clear the NVM update wait flag when no update_done message was actually received. This patch cleans the event descriptor before use, and moves the opcode check to where it won't get done if there was no event to clean. Signed-off-by: Helin

[dpdk-dev] [PATCH 09/29] i40e/base: add new device IDs and delete deprecated one

2016-01-15 Thread Helin Zhang
Add new Device ID's for backplane and QSFP+ adapters, and delete deprecated one for backplane. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_common.c | 12 ++-- drivers/net/i40e/base/i40e_devids.h | 10 +- 2 files changed, 19 insertions(+), 3 deletions(-) diff

[dpdk-dev] [PATCH 10/29] i40e/base: fix up recent proxy and wol bits for X722_SUPPORT

2016-01-15 Thread Helin Zhang
The recently added opcodes should be available only with X722 SUPPORT, so move them into the #ifdef, and reorder these to be in numerical order with the rest of the opcodes. Several structs that were added are unnecessary, so they are removed here. Signed-off-by: Helin Zhang --- drivers/net

[dpdk-dev] [PATCH 12/29] i40e/base: Fix for PHY NVM interaction problem

2016-01-15 Thread Helin Zhang
calling get phy capability function because that bit is not set when device is in PHY interaction mode. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_common.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b

[dpdk-dev] [PATCH 11/29] i40e/base: define function capabilities in only one place

2016-01-15 Thread Helin Zhang
The device capabilities were defined in two places, and neither had all the definitions. It really belongs with the AQ API definition, so this patch removes the other set of definitions and fills out the missing item. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1

[dpdk-dev] [PATCH 14/29] i40e/base: add APIs to Add/remove port mirroring rules

2016-01-15 Thread Helin Zhang
This patch implements necessary functions related to port mirroring features such as add/delete mirror rule, function to set promiscuous VLAN mode for VSI if mirror rule_type is "VLAN Mirroring". Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_common.

[dpdk-dev] [PATCH 13/29] i40e/base: set shared bit for multicast filters

2016-01-15 Thread Helin Zhang
Add the use of the new Shared MAC filter bit for multicast and broadcast filters in order to make better use of the filters available from the device. The FW folks have assured that setting this bit on older FW will have no affect, so it doesn't need a version check. Signed-off-by: Helin

[dpdk-dev] [PATCH 15/29] i40e/base: add VEB stat control and remove L2 cloud filter

2016-01-15 Thread Helin Zhang
functionality exists. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 3 ++- drivers/net/i40e/base/i40e_common.c | 11 ++- drivers/net/i40e/base/i40e_prototype.h | 4 ++-- drivers/net/i40e/i40e_ethdev.c | 2 +- 4 files changed, 11 insertions(+), 9

[dpdk-dev] [PATCH 16/29] i40e/base: implement the API function for aq_set_switch_config

2016-01-15 Thread Helin Zhang
Add the support code for calling the AdminQ API call aq_set_switch_config. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 12 drivers/net/i40e/base/i40e_common.c | 28 drivers/net/i40e/base/i40e_prototype.h | 3 +++ 3

[dpdk-dev] [PATCH 17/29] i40e/base: Add functions to blink led on Coppervale PHY

2016-01-15 Thread Helin Zhang
This patch adds functions to blink led on devices using Coppervale PHY since MAC registers used in other designs do not work in this device configuration. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_common.c| 329 + drivers/net/i40e/base

[dpdk-dev] [PATCH 18/29] i40e/base: When in promisc mode apply promisc mode to Tx Traffic as well

2016-01-15 Thread Helin Zhang
n MFP which is similar to defport. An API check is not required, since this bit is reserved for FW API version < 1.5. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 1 + drivers/net/i40e/base/i40e_common.c | 9 - 2 files changed, 9 insertions(+), 1

[dpdk-dev] [PATCH 19/29] i40e/base: Increase timeout when checking GLGEN_RSTAT_DEVSTATE bit

2016-01-15 Thread Helin Zhang
When linking with particular PHY types (ex: copper PHY), the amount of time it takes for the GLGEN_RSTAT_DEVSTATE to be set increases greatly, which can lead to a timeout and failure to load the driver. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_common.c | 6 +++--- 1 file

[dpdk-dev] [PATCH 20/29] i40e/base: Save off VSI resource count when updating VSI

2016-01-15 Thread Helin Zhang
When updating a VSI, save off the number of allocated and unallocated VSIs as we do when adding a VSI. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_common.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base

[dpdk-dev] [PATCH 21/29] i40e/base: coding style fixes

2016-01-15 Thread Helin Zhang
It adds coding style fixes. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_common.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 9a0b787..e94f726 100644 --- a

[dpdk-dev] [PATCH 22/29] i40e/base: use FW to read/write rx control registers

2016-01-15 Thread Helin Zhang
RX control register read/write functions are added, as directly read/write may fail when under stress small traffic. After the adminq is ready, all rx control registers should be read/written by dedicated functions. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 16

[dpdk-dev] [PATCH 23/29] i40e/base: expose some registers to program parser, FD and RSS logic

2016-01-15 Thread Helin Zhang
This patch adds 7 new register definitions for programming the parser, flow director and RSS blocks in the HW. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_register.h | 48 +++ drivers/net/i40e/i40e_ethdev.c| 11 ++-- 2 files changed, 50

[dpdk-dev] [PATCH 25/29] i40e/base: add AQ thermal sensor control struct

2016-01-15 Thread Helin Zhang
It adds the new AQ command and struct for managing a thermal sensor. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h

[dpdk-dev] [PATCH 26/29] i40e/base: add/update structure and macro definitions

2016-01-15 Thread Helin Zhang
Several structures and macros are added or updated, such as 'struct i40e_aqc_get_link_status', 'struct i40e_aqc_run_phy_activity' and 'struct i40e_aqc_lldp_set_local_mib_resp'. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 45

[dpdk-dev] [PATCH 27/29] i40e: add base driver release info

2016-01-15 Thread Helin Zhang
It adds base driver release information such as release date, for better tracking in the future. Signed-off-by: Helin Zhang --- drivers/net/i40e/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/Makefile b/drivers/net/i40e/Makefile index 033ee4a..6dd6eaa 100644 --- a

[dpdk-dev] [PATCH 28/29] i40e: add/remove new device IDs

2016-01-15 Thread Helin Zhang
It adds several new device IDs, and also removed one which is not used at all. Signed-off-by: Helin Zhang --- doc/guides/rel_notes/release_2_3.rst| 15 +++ lib/librte_eal/common/include/rte_pci_dev_ids.h | 8 ++-- 2 files changed, 21 insertions(+), 2 deletions

[dpdk-dev] [PATCH 29/29] i40e: use rx control function for rx control registers

2016-01-15 Thread Helin Zhang
As required, rx control registers have to be read/written by rx control functions, otherwise if may fail to read/write when under stress small traffic. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c| 66 --- drivers/net/i40e

[dpdk-dev] [PATCH 24/29] i40e/base: Add a Virtchnl offload for RSS PCTYPE V2

2016-01-15 Thread Helin Zhang
X722 supports Expanded version of TCP, UDP PCTYPES for RSS. Add a Virtchnl offload to support this. Without this patch VF drivers will not be able to support the correct PCTYPES for X722 and UDP flows will not fan out. Signed-off-by: Helin Zhang --- drivers/net/i40e/base/i40e_virtchnl.h | 1

[dpdk-dev] [PATCH 0/2] i40e setting ether type of VLANs

2016-01-22 Thread Helin Zhang
It adds setting ether type of single VLAN(inner VLAN) and outer VLAN for i40e. For ixgbe and e1000/igb, as the external API changed, it supports setting single VLAN(inner VLAN) only. Helin Zhang (2): ethdev: add vlan type for setting ether type i40e: add VLAN ether type config app/test-pmd

[dpdk-dev] [PATCH 1/2] ethdev: add vlan type for setting ether type

2016-01-22 Thread Helin Zhang
In order to set ether type of VLAN for single VLAN, inner and outer VLAN, the VLAN type as an input parameter is added to 'rte_eth_dev_set_vlan_ether_type()'. In addition, corresponding changes in e1000, ixgbe and i40e are also added. Signed-off-by: Helin Zhang --- app/test-pmd

[dpdk-dev] [PATCH 2/2] i40e: add VLAN ether type config

2016-01-22 Thread Helin Zhang
It adds the setting VLAN ether type of single VLAN, inner and outer VLAN. Single VLAN is treated as inner VLAN as usual. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev.c | 55 +++--- 1 file changed, 51 insertions(+), 4 deletions(-) diff --git a

[dpdk-dev] [PATCH 1/3] i40e: add setting VF MAC address in DPDK PF host

2016-01-28 Thread Helin Zhang
It adds pre-setting the VF MAC addresses from DPDK PF host side before any VF being initialized, by introducing a new element of 'struct rte_vf_conf' in 'struct rte_eth_conf'. It supports up to 128 VFs per physical port of setting VF MAC addresses. Signed-off-by: Helin Zh

[dpdk-dev] [PATCH 2/3] i40evf: use ether interface for validating MAC address

2016-01-28 Thread Helin Zhang
It uses ether interface of 'is_valid_assigned_ether_addr' for validating MAC address. In the meanwhile, more annotations are added for obtaining/generating VF MAC address. Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_ethdev_vf.c | 14 +++--- 1 file changed, 7 insert

[dpdk-dev] [PATCH 0/3] support setting i40e VF MAC address from DPDK host side

2016-01-28 Thread Helin Zhang
ABI broken, as ABI changes in 'struct rte_eth_conf' has already been announced in R2.2. Helin Zhang (3): i40e: add setting VF MAC address in DPDK PF host i40evf: use ether interface for validating MAC address app/testpmd: set default MAC addresses for each VF app/test-pmd

[dpdk-dev] [PATCH 3/3] app/testpmd: set default MAC addresses for each VF

2016-01-28 Thread Helin Zhang
It generates MAC addresses during host port initialization, which will be set as default MAC addresses for corresponding VFs. Signed-off-by: Helin Zhang --- app/test-pmd/testpmd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd

[dpdk-dev] [PATCH v2 0/2] fix coverity issues

2016-06-26 Thread Helin Zhang
It fixes several problematic dereference issues and missing break issue reported by Coverity. Helin Zhang (2): i40e: fix problematic dereference i40e: fix missing break in switch drivers/net/i40e/i40e_pf.c | 11 +-- drivers/net/i40e/i40e_rxtx.c | 12 2 files changed

[dpdk-dev] [PATCH v2 1/2] i40e: fix problematic dereference

2016-06-26 Thread Helin Zhang
778a1fa2e4e ("i40e: set up and initialize flow director") Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Helin Zhang --- drivers/net/i40e/i40e_pf.c | 5 +++-- drivers/net/i40e/i40e_rxtx.c | 12 2 files changed, 11 insertions(+), 6 deletions(-) dif

<    1   2   3   4   5   6   7   8   9   10   >