Re: [dpdk-dev] [PATCH v2] net/ixgbe: ensure link status is updated

2017-04-03 Thread Laurent Hardy
ink status is updated Hi, Can this patch be applied? Thanks, Olivier On Thu, 16 Feb 2017 17:32:01 +0100, Olivier Matz wrote: From: Laurent Hardy In case of fiber and link speed set to 1Gb at peer side (with autoneg or with defined speed), link status could be not properly updated at time cable

Re: [dpdk-dev] [PATCH v2] net/ixgbe: ensure link status is updated

2017-04-11 Thread Laurent Hardy
On 04/10/2017 03:36 PM, Ferruh Yigit wrote: On 4/3/2017 2:23 PM, Laurent Hardy wrote: Hi Wei, Thanks for your reply. If autoneg is false, then we set a default speed to the highest value before performing the link setup. You are right, there is no relevant reason to keep this check on speed

[dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2017-04-12 Thread Laurent Hardy
speed as no link setup will be triggered. To avoid this issue, IXGBE_FLAG_NEED_LINK_CONFIG is set to try a link setup each time link_update() is triggered and current link status is down. When cable is plugged-in, link setup will be performed via ixgbe_setup_link(). Signed-off-by: Laurent Hardy

[dpdk-dev] [PATCH v4] net/ixgbe: ensure link status is updated

2017-04-27 Thread Laurent Hardy
speed as no link setup will be triggered. To avoid this issue, IXGBE_FLAG_NEED_LINK_CONFIG is set to try a link setup each time link_update() is triggered and current link status is down. When cable is plugged-in, link setup will be performed via ixgbe_setup_link(). Signed-off-by: Laurent Hardy

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF

2017-05-10 Thread Laurent Hardy
ia-type() of ixgbe VF is NULL and should not be called directly. It had better be replaced by calling ixgbe_get_media_type( ) to avoid crash. Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") Cc: sta...@dpdk.org Signed-off-by: Wei Dai Acked-by: Laurent Hardy Hi Roger and

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

2018-10-11 Thread Laurent Hardy
Of Ilya Maximets Sent: Wednesday, September 12, 2018 4:05 PM To: Zhang, Qi Z ; dev@dpdk.org Cc: Lu, Wenzhuo ; Ananyev, Konstantin ; Laurent Hardy ; Dai, Wei ; sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update On 12.09.2018 09:49, Zhang, Qi Z wrote

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

2018-10-15 Thread Laurent Hardy
Hi Wei, On 10/12/2018 09:36 AM, Zhao1, Wei wrote: Hi, laurent.hardy You are the author for the patch (* net/ixgbe: ensure link status is updated), why do you implement code that way? Is that must that set up link with wait? ixgbe_setup_link(hw, speed, true); The main issue which has lea

Re: [dpdk-dev] [PATCH] net/i40e: add a specific API to control the LLDP agent

2018-05-21 Thread Laurent Hardy
(Management Information Base). Signed-off-by: Laurent Hardy Signed-off-by: Zijie Pan Does it mean that this feature is enabled by default in i40e devices? Should it be disabled by default? The new API is just an interface to control the LLDP agent. No functions of i40e call it by default. It is

Re: [dpdk-dev] [PATCH] net/i40e: add a specific API to control the LLDP agent

2018-05-22 Thread Laurent Hardy
Hi Qi, On 05/21/2018 03:11 PM, Zhang, Qi Z wrote: Hi Zijie: -Original Message- From: Zijie Pan [mailto:zijie@6wind.com] Sent: Friday, May 18, 2018 6:14 PM To: dev@dpdk.org Cc: Xing, Beilei ; Zhang, Qi Z ; Laurent Hardy Subject: [PATCH] net/i40e: add a specific API to control the

[dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-07 Thread Laurent Hardy
control requests (on/off). Signed-off-by: Laurent Hardy --- doc/guides/nics/features.rst | 5 + lib/librte_ethdev/rte_ethdev.c | 12 lib/librte_ethdev/rte_ethdev.h | 15 +++ lib/librte_ethdev/rte_ethdev_core.h | 4 lib

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
Hi all, On 1/8/20 10:55 AM, David Marchand wrote: On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: Hello Laurent, Bonne année. Cc: maintainers. On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy wrote: In current led control API we have no way to

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
On 1/8/20 2:06 PM, Thomas Monjalon wrote: 08/01/2020 13:59, Ferruh Yigit: On 1/8/2020 10:31 AM, Laurent Hardy wrote: Hi all, On 1/8/20 10:55 AM, David Marchand wrote: On Wed, Jan 8, 2020 at 10:09 AM Ferruh Yigit wrote: On 1/8/2020 8:56 AM, David Marchand wrote: Hello Laurent, Bonne

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
: Hello Laurent, Bonne année. Cc: maintainers. On Tue, Jan 7, 2020 at 3:57 PM Laurent Hardy wrote: In current led control API we have no way to know if a device is able to handle on/off requests coming from the application. Knowing if the device is led control capable could be useful to avoid

Re: [dpdk-dev] [PATCH] librte_ethdev: extend dpdk api led control to query capability

2020-01-08 Thread Laurent Hardy
On 1/8/20 3:07 PM, Thomas Monjalon wrote: 08/01/2020 14:58, Laurent Hardy: About the 'is_supported()' versions of APIs, in the current patch I factorize the check on dev ops on and off availability in a same function named "led_ctrl_capable" but I can rename it if req

Re: [dpdk-dev] [PATCH] i40e: i40evf link status is always down with the Intel XL710 driver

2020-05-14 Thread Laurent Hardy
Hello Scott, What is the use case in which VF link status is always down? vf->link_speed should contain a VIRTCHNL_LINK_SPEED enum (which has been mapped on I40E_LINK_SPEED_* enum). when we are looking for vf->link_speed into the switch case of i40evf_dev_link_update(), we should have a value mat

[dpdk-dev] [PATCH] i40evf: use non spinning delay when issuing AQ request to PF

2020-03-30 Thread Laurent Hardy
CPU core. Signed-off-by: Olivier Matz Signed-off-by: Laurent Hardy --- Hi all, Some question coming along with this patch: 1)Is there any downside to use the rte_eal_delay_us_sleep which will put the thread to sleep instead of the rte_eal_delay_ms (for both control plane and dataplane threads

[dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2016-11-17 Thread Laurent Hardy
a link setup each time link_update() is triggered and current link status is down. When cable is plugged-in, link setup will be performed via ixgbe_setup_link(). Signed-off-by: Laurent Hardy --- drivers/net/ixgbe/ixgbe_ethdev.c | 20 drivers/net/ixgbe/ixgbe_ethdev.h |1

[dpdk-dev] [PATCH] net/ixgbe: ensure link status is updated

2016-11-28 Thread Laurent Hardy
Hello, Is there anyone available to review this patch ? regards, Laurent On 11/17/2016 06:29 PM, Laurent Hardy wrote: > In case of link speed set to 1Gb at peer side (with autoneg or with > defined speed) and cable not plugged-in when device is configured > and started, then link stat