device, we can already see few
notifications being suppressed when doing throughput
testing with Iperf3. We can expect to see much more being
suppressed when the offloading thread is under pressure.
Signed-off-by: Maxime Coquelin
---
v3: s/0/false/ (David)
lib/vhost/vhost.c | 4
lib/vhost
(unsigned long long)vq_info.device_addr);
VHOST_LOG_CONFIG(dev->ifname, INFO, "\tavail_idx: %u\n",
vq_info.split.avail_index);
VHOST_LOG_CONFIG(dev->ifname, INFO, "\tready: %u\n", vq_info.ready);
It is surprising PRIx64 does not work on other architectures.
I don't see a better solution, so:
Acked-by: Maxime Coquelin
Thanks,
Maxime
On 9/28/23 18:33, Chautru, Nicolas wrote:
HI Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Thursday, September 28, 2023 1:27 AM
To: Chautru, Nicolas ; hemant.agra...@nxp.com;
dev@dpdk.org
Cc: david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v1 1/7] bbdev
On 9/29/23 18:35, Nicolas Chautru wrote:
This allows to expose the FFT window width being introduced in
previous commit based on what is configured dynamically on the
device platform.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.h | 3 +++
drivers/baseband/acc/rte_
struct, doing so would be more future-proof. Maybe it
could be considered?
But in the mean time, it addresses this specific issue:
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
desc = acc_desc(q, total_enqueued_cbs);
vrb_fcw_td_fill(op, &desc->req.fcw_td);
Hi Eelco,
On 10/3/23 14:36, Eelco Chaudron wrote:
On 29 Sep 2023, at 12:38, Maxime Coquelin wrote:
Guest notifications offloading, which has been introduced
in v23.07, aims at offloading syscalls out of the datapath.
This patch optimizes the offloading by not offloading the
guest
w_fft *) (q->fcw_ring +
+ ((q->sw_ring_head + total_enqueued_cbs) &
q->sw_ring_wrap_mask)
+ * ACC_MAX_FCW_SIZE);
vrb1_fcw_fft_fill(op, fcw);
vrb1_dma_desc_fft_fill(op, &desc->req, input, output, &in_offset,
&out_offset);
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
Thanks for doing the split, that will ease review.
On 9/29/23 18:35, Nicolas Chautru wrote:
Adding a few functions and common code prior to
extending the VRB driver.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/acc_common.h | 164 +++---
drivers/baseband/a
.tail_ptrs_dl5g_hi = VRB2_VfDmaFec5GdlRespPtrHiRegVf,
+ .tail_ptrs_dl5g_lo = VRB2_VfDmaFec5GdlRespPtrLoRegVf,
+ .tail_ptrs_ul5g_hi = VRB2_VfDmaFec5GulRespPtrHiRegVf,
+ .tail_ptrs_ul5g_lo = VRB2_VfDmaFec5GulRespPtrLoRegVf,
+ .tail_ptrs_dl4g_hi = VRB2_VfDmaFec4GdlRespPtrHiRegVf,
+ .tail_ptrs_dl4g_lo = VRB2_VfDmaFec4GdlRespPtrLoRegVf,
+ .tail_ptrs_ul4g_hi = VRB2_VfDmaFec4GulRespPtrHiRegVf,
+ .tail_ptrs_ul4g_lo = VRB2_VfDmaFec4GulRespPtrLoRegVf,
+ .tail_ptrs_fft_hi = VRB2_VfDmaFftRespPtrHiRegVf,
+ .tail_ptrs_fft_lo = VRB2_VfDmaFftRespPtrLoRegVf,
+ .tail_ptrs_mld_hi = VRB2_VfDmaMldRespPtrHiRegVf,
+ .tail_ptrs_mld_lo = VRB2_VfDmaMldRespPtrLoRegVf,
+ .depth_log0_offset = VRB2_VfQmgrGrpDepthLog20Vf,
+ .depth_log1_offset = VRB2_VfQmgrGrpDepthLog21Vf,
+ .qman_group_func = VRB2_VfQmgrGrpFunction0Vf,
+ .hi_mode = VRB2_VfHiMsixVectorMapperVf,
+ .pf_mode = 0,
+ .pmon_ctrl_a = VRB2_VfPmACntrlRegVf,
+ .pmon_ctrl_b = VRB2_VfPmBCntrlRegVf,
+ .pmon_ctrl_c = VRB2_VfPmCCntrlRegVf,
+ .vf2pf_doorbell =VRB2_VfHiVfToPfDbellVf,
+ .pf2vf_doorbell =VRB2_VfHiPfToVfDbellVf,
+};
+
+
#endif /* _VRB_PMD_H_ */
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 9/29/23 18:35, Nicolas Chautru wrote:
New implementation for some of the FEC features
specific to the VRB2 variant.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 567 -
1 file changed, 548 insertions(+), 19 deletions(-)
diff --git
On 9/29/23 18:35, Nicolas Chautru wrote:
Support for the FFT the processing specific to the
VRB2 variant.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 132 -
1 file changed, 128 insertions(+), 4 deletions(-)
diff --git a/drivers/base
On 9/29/23 18:35, Nicolas Chautru wrote:
Adding the capability for the MLD-TS processing specific to
the VRB2 variant.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 378 +
1 file changed, 378 insertions(+)
diff --git a/drivers/baseban
ACC_PF_INT_QMGR_ERR = 13,
- ACC_PF_INT_INT_REQ_OVERFLOW = 14,
- ACC_PF_INT_APB_TIMEOUT = 15,
+ ACC_PF_INT_ARAM_ACCESS_ERR = 11,
+ ACC_PF_INT_ARAM_ECC_1BIT_ERR = 12,
+ ACC_PF_INT_PARITY_ERR = 13,
+ ACC_PF_INT_QMGR_OVERFLOW = 14,
+ ACC_PF_INT_QMGR_ERR = 15,
+ ACC_PF_INT_ATS_ERR = 22,
+ ACC_PF_INT_ARAM_FUUL = 23,
+ ACC_PF_INT_EXTRA_READ = 24,
+ ACC_PF_INT_COMPLETION_TIMEOUT = 25,
+ ACC_PF_INT_CORE_HANG = 26,
+ ACC_PF_INT_DMA_HANG = 28,
+ ACC_PF_INT_DS_HANG = 27,
};
#endif /* VRB1_PF_ENUM_H */
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
am dev_name
+ * The name of the device. This is the short form of PCI BDF, e.g. 00:01.0.
+ * It can also be retrieved for a bbdev device from the dev_name field in the
+ * rte_bbdev_info structure returned by rte_bbdev_info_get().
+ * @param conf
+ * Configuration to apply to VRB2 HW.
+ *
+ * @return
+ * Zero on success, negative value on failure.
+ */
+int
+vrb2_configure(const char *dev_name, struct rte_acc_conf *conf);
+
#endif /* _VRB_CFG_H_ */
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
/* Stronger alignment requirement when in decompression mode */
if (fcw->hcin_decomp_mode > 0)
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 10/3/23 19:22, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Tuesday, October 3, 2023 8:16 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v3 11/12] baseband/acc
On 10/3/23 20:20, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Tuesday, October 3, 2023 7:37 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v3 09/12] baseband/acc
On 10/3/23 20:54, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Tuesday, October 3, 2023 6:15 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v3 06/12] baseband/acc
On 10/3/23 21:06, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Tuesday, October 3, 2023 4:52 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v3 02/12] baseband/acc
On 10/4/23 23:28, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Wednesday, October 4, 2023 12:36 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v3 06/12] baseband
On 10/4/23 23:18, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Wednesday, October 4, 2023 12:11 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v3 09/12] baseband
On 10/4/23 23:11, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Tuesday, October 3, 2023 7:28 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v3 08/12] baseband/acc
t;oerrors = tx_total_errors;
return 0;
}
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 10/5/23 21:48, Nicolas Chautru wrote:
This exposes the width of each windowing shape being configured on
the device. This allows to distinguish different version of the
flexible pointwise windowing applied to the FFT and expose
this platform configuration to the application.
This also add t
ev *dev, struct
rte_bbdev_driver_info *dev_info)
fetch_acc_config(dev);
/* Check the status of device. */
dev_info->device_status = vrb_device_status(dev);
+ dev_info->fft_window_width = d->fft_window_width;
/* Exposed number of queues. */
dev_info->
changed, 190 insertions(+), 43 deletions(-)
Reviewed-by: Maxime Coquelin
Maxime
On 10/5/23 21:49, Nicolas Chautru wrote:
New implementation for some of the FEC features
specific to the VRB2 variant.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 370 +
1 file changed, 328 insertions(+), 42 deletions(-)
diff --git
On 10/5/23 19:59, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Thursday, October 5, 2023 7:35 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v3 09/12] baseband
;
+ dequeued_cbs += ret;
+ }
+
+ q->aq_dequeued += aq_dequeued;
+ q->sw_ring_tail += dequeued_cbs;
+ /* Update enqueue stats. */
+ q_data->queue_stats.dequeued_count += i;
+ return i;
+}
+
/* Initialization Function */
static void
vrb_bbdev_init(struct rte_bbdev *dev, struct rte_pci_driver *drv)
@@ -3896,6 +4268,8 @@ vrb_bbdev_init(struct rte_bbdev *dev, struct
rte_pci_driver *drv)
dev->dequeue_ldpc_dec_ops = vrb_dequeue_ldpc_dec;
dev->enqueue_fft_ops = vrb_enqueue_fft;
dev->dequeue_fft_ops = vrb_dequeue_fft;
+ dev->enqueue_mldts_ops = vrb2_enqueue_mldts;
+ dev->dequeue_mldts_ops = vrb2_dequeue_mldts;
d->pf_device = !strcmp(drv->driver.name, RTE_STR(VRB_PF_DRIVER_NAME));
d->mmio_base = pci_dev->mem_resource[0].addr;
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
Hi,
Thanks for investigating the issue and proposing a fix!
On 10/10/23 04:08, liufengjiang.0426 wrote:
When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc
Fix the warning that a single line of comm
&dequeued_ops, &aq_dequeued,
+ &dequeued_descs, num);
+ else
+ ret = vrb2_dequeue_ldpc_enc_one_op_tb(q,
&ops[dequeued_ops],
+ &dequeued_ops, &aq_dequeued,
+ &dequeued_descs);
else
ret = vrb_dequeue_enc_one_op_cb(q, &ops[dequeued_ops],
&dequeued_ops, &aq_dequeued,
@@ -3526,7 +3813,6 @@ vrb_bbdev_init(struct rte_bbdev *dev, struct
rte_pci_driver *drv)
(pci_dev->id.device_id == RTE_VRB1_VF_DEVICE_ID)) {
d->device_variant = VRB1_VARIANT;
d->queue_offset = vrb1_queue_offset;
- d->fcw_ld_fill = vrb1_fcw_ld_fill;
d->num_qgroups = VRB1_NUM_QGRPS;
d->num_aqs = VRB1_NUM_AQS;
if (d->pf_device)
Reviewed-by: Maxime Coquelin
On 10/6/23 22:08, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Friday, October 6, 2023 12:54 AM
To: Chautru, Nicolas ; dev@dpdk.org
Cc: hemant.agra...@nxp.com; david.march...@redhat.com; Vargas, Hernan
Subject: Re: [PATCH v5 01/12] bbdev: add
On 10/6/23 09:55, Maxime Coquelin wrote:
On 10/5/23 21:48, Nicolas Chautru wrote:
This allows to expose the FFT window width being introduced in
previous commit based on what is configured dynamically on the
device platform.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc
On 10/5/23 04:18, Nicolas Chautru wrote:
Support for the FFT the processing specific to the
VRB2 variant.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 137 +++--
1 file changed, 129 insertions(+), 8 deletions(-)
Reviewed-by: Maxime
On 10/5/23 21:49, Nicolas Chautru wrote:
Support for the FFT the processing specific to the
VRB2 variant.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 146 +++--
1 file changed, 119 insertions(+), 27 deletions(-)
Reviewed-by: Maxime
On 10/10/23 22:20, Nicolas Chautru wrote:
v6: removed one empty line typo.
Thanks
v5: missed a line in v4 patch 2/12.
change to 9/12 with suggested refactor.
v4: updates based on Maxime's suggestions:
- FFT windowing exposure tweaked to show number of windows
as well in capacity to
On 9/19/23 20:24, Hernan Vargas wrote:
Some constraints are imposed onto the ACC100 HARQ input size,
but that value is incorrectly aligned down when getting close to
max (Ncb-F) which is not required.
The wireless performance impact is negligeable but still causes a
few LLRs no to be combined
mlx5_vdpa_steer_unset(priv);
pthread_mutex_unlock(&priv->steer_update_lock);
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 9/30/23 03:00, Andrey Ignatov wrote:
vhost device doesn't report TX errors what complicates debugging of
dropped packets. Add oerrors to port stats.
- before (testpmd `show port stats`):
TX-packets: 18328512 TX-errors: 0 TX-bytes: 1173024768
- after:
TX-packets: 1737728
On 9/29/23 12:38, Maxime Coquelin wrote:
Guest notifications offloading, which has been introduced
in v23.07, aims at offloading syscalls out of the datapath.
This patch optimizes the offloading by not offloading the
guest notification for a given virtqueue if one is already
being offloaded
On 9/20/23 15:01, Maxime Coquelin wrote:
With Virtio-user, the Virtio descriptor buffer address is the
virtual address of the mbuf's buffer. On 32 bits builds, it is
expected to be 32 bits.
With Virtio-PCI, the Virtio descriptor buffer address is the
physical address of the mbuf's
On 8/8/23 13:32, Yajun Wu wrote:
The mlx5_vdpa_virtq_kick_handler function may still be running and waiting
on virtq->virtq_lock while mlx5_vdpa_cqe_event_unset function is trying to
re-initialize the virtq->virtq_lock.
This causes mlx5_vdpa_virtq_kick_handler thread can't be wake up and can'
On 9/13/23 15:58, David Marchand wrote:
The LA12XX driver was not linked to the dpdk-test-bbdev tool because of
what looks like a rebase issue.
Fixes: 2b504721bfda ("app/bbdev: enable la12xx")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
app/test-bbdev/meson.build | 2 +-
1 file
Hi,
On 10/10/23 09:12, Maxime Coquelin wrote:
Hi,
Thanks for investigating the issue and proposing a fix!
On 10/10/23 04:08, liufengjiang.0426 wrote:
When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header
Signed-off-by: Fengjiang Liu
---
drivers/net/virtio/virtqueue.h | 1 +
1 file changed, 1 insertion(+)
No need to resend so many new versions :)
(For new patches, don't forget to increase the revision number).
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 9/18/23 18:31, Hernan Vargas wrote:
Add support for new FPGA variant AGX100 (on Arrow Creek N6000).
Signed-off-by: Hernan Vargas
---
doc/guides/bbdevs/fpga_5gnr_fec.rst | 72 +-
drivers/baseband/fpga_5gnr_fec/agx100_pmd.h | 273
.../baseband/fpga_5gnr_fec/fpga_5gnr
/rte_pmd_fpga_5gnr_fec.h | 16 +-
3 files changed, 154 insertions(+), 157 deletions(-)
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 9/18/23 18:31, Hernan Vargas wrote:
Create a new file vc_5gnr_pmd.h to store structures and macros specific
to Vista Creek 5G FPGA implementation and rename functions specific to
the Vista Creek variant.
Signed-off-by: Hernan Vargas
---
.../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h| 18
On 9/29/23 20:13, Hernan Vargas wrote:
test-bbdev.py relying on non-recommended subprocess Popen.
This can lead to unstability where the process cannot be stopped with a
s/unstability/instabilities/
sig TERM.
Use subprocess run with proper timeout argument.
Fixes: f714a18885a6 ("app/testb
On 9/29/23 20:13, Hernan Vargas wrote:
Update the timeout argument and default values.
Update EAL help message and default value.
Add iter_max and snr arguments.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test-bbdev.py | 22 ++
app/test-bbdev/test_bbdev_perf.c
On 9/29/23 20:13, Hernan Vargas wrote:
Renaming ACC200 macros to use generic intel vRAN Boost (VRB).
No functional impact.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 91
1 file changed, 45 insertions(+), 46 deletions(-)
diff --git
On 9/29/23 20:13, Hernan Vargas wrote:
Add range limit to prevent LLR generation greater than the data buffer
size.
Should be a fix?
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/app/test-bbdev/test_bbdev_per
_bulk() failed");
+ TEST_ASSERT_SUCCESS(ret, "rte_bbdev_enc_op_alloc_bulk()
failed");
if (test_vector.op_type != RTE_BBDEV_OP_NONE)
copy_reference_ldpc_enc_op(ops_enq, burst_sz, dequeued,
bufs->inputs,
Reviewed-by: Maxime Coquelin
Maxime
ASSERT_SUCCESS(return_value = rte_bbdev_queue_info_get(dev_id,
If should be a fix IMO.
With fixes tag added and stable cc'ed:
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
PC_ENC_CONCATENATION;
else {
- printf("The given value is not a turbo encoder flag\n");
+ printf("The given value is not a LDPC encoder flag - %s\n",
token);
return -1;
}
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 9/29/23 20:13, Hernan Vargas wrote:
Increase max burst size to 1023.
Signed-off-by: Hernan Vargas
---
app/test-bbdev/main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-bbdev/main.h b/app/test-bbdev/main.h
index dc10a505d141..ac0083ec6673 100644
--- a/ap
or->mask;
+
+ if (check_mld_segments(vector) < 0)
+ return -1;
+
+ /* Check which params were set */
+ if (!(mask & TEST_BBDEV_VF_OP_FLAGS)) {
+ printf(
+ "WARNING: op_flags was not specified in vector file and
capabilities will not be validated\n");
+ }
+ if (!(mask & TEST_BBDEV_VF_EXPECTED_STATUS))
+ printf(
+ "WARNING: expected_status was not specified in vector file
and will be set to 0\n");
+ return 0;
+}
+
/* checks encoder parameters */
static int
check_encoder(struct test_bbdev_vector *vector)
@@ -1520,6 +1649,9 @@ bbdev_check_vector(struct test_bbdev_vector *vector)
} else if (vector->op_type == RTE_BBDEV_OP_FFT) {
if (check_fft(vector) == -1)
return -1;
+ } else if (vector->op_type == RTE_BBDEV_OP_MLDTS) {
+ if (check_mld(vector) == -1)
+ return -1;
} else if (vector->op_type != RTE_BBDEV_OP_NONE) {
printf("Vector was not filled\n");
return -1;
diff --git a/app/test-bbdev/test_bbdev_vector.h
b/app/test-bbdev/test_bbdev_vector.h
index 2ea271ffb78b..14b8ef2764ad 100644
--- a/app/test-bbdev/test_bbdev_vector.h
+++ b/app/test-bbdev/test_bbdev_vector.h
@@ -65,6 +65,7 @@ struct test_bbdev_vector {
struct rte_bbdev_op_ldpc_dec ldpc_dec;
struct rte_bbdev_op_ldpc_enc ldpc_enc;
struct rte_bbdev_op_fft fft;
+ struct rte_bbdev_op_mldts mldts;
};
/* Additional storage for op data entries */
struct op_data_entries entries[DATA_NUM_TYPES];
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
FT_WIN_SIZE - 1)) {
+ tok = strtok(NULL, VALUE_DELIMITER);
+ if (tok == NULL)
+ return -1;
+ }
+ }
+ ret = ((err == NULL) || (*err != '\0')) ? -1 : 0;
} else if (!strcmp(key_token, "op_flags")) {
vector->mask |= TEST_BBDEV_VF_OP_FLAGS;
ret = parse_turbo_flags(token, &op_flags, vector->op_type);
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
BDEV_LDPC_HARQ_4BIT_COMPRESSION;
else if (!strcmp(token, "RTE_BBDEV_LDPC_LLR_COMPRESSION"))
*op_flag_value = RTE_BBDEV_LDPC_LLR_COMPRESSION;
else if (!strcmp(token,
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
g for configuration failure in a test application is quite useful
in my opinion, as it can help catching regressions, isn't it?
Maxime
Thanks
Nic
-Original Message-----
From: Maxime Coquelin
Sent: Tuesday, October 17, 2023 9:43 PM
To: Vargas, Hernan ; dev@dpdk.org;
gak...@marvell.com; Ri
, not the code.
Thanks,
Maxime
Thanks
Nic
-Original Message-
From: Maxime Coquelin
Sent: Tuesday, October 17, 2023 9:08 PM
To: Vargas, Hernan ; dev@dpdk.org;
gak...@marvell.com; Rix, Tom
Cc: Chautru, Nicolas ; Zhang, Qi Z
Subject: Re: [PATCH v1 02/11] test/bbdev: update python script
le in RHEL, we use this script for BBDEV validation for our
downstream packages.
Maxime
Heman, any concern on your side with this change?
-Original Message-
From: Maxime Coquelin
Sent: Thursday, October 19, 2023 11:19 AM
To: Chautru, Nicolas ; Vargas, Hernan
; dev@dpdk.org; gak...@marvel
On 10/19/23 18:55, Stephen Hemminger wrote:
All API's that before 22.11 release should have experimental
tag removed.
Signed-off-by: Stephen Hemminger
---
lib/vhost/rte_vhost.h| 5
lib/vhost/rte_vhost_async.h | 19 --
lib/vhost/rte_vhost_crypto.h | 1 -
lib/v
On 10/19/23 21:10, Stephen Hemminger wrote:
All API's that before 22.11 release should have experimental
tag removed.
Signed-off-by: Stephen Hemminger
---
lib/vhost/rte_vhost.h| 5
lib/vhost/rte_vhost_async.h | 19 --
lib/vhost/rte_vhost_crypto.h | 1 -
lib/v
t_ops;
- rte_bbdev_enqueue_status_str;
- rte_bbdev_fft_op_alloc_bulk;
- rte_bbdev_fft_op_free_bulk;
- #added in 23.11
+ # added in 23.11
rte_bbdev_dequeue_mldts_ops;
rte_bbdev_enqueue_mldts_ops;
rte_bbdev_mldts_op_alloc_bulk;
Acked-by: Maxime Coquelin
Thanks,
Maxime
On 10/19/23 09:24, David Marchand wrote:
On Mon, Sep 25, 2023 at 6:36 PM Maxime Coquelin
wrote:
Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.
The access status must also be checked.
Even if adding the lock was not enou
uot;)
Fixes: 830f7e790732 ("vhost: add non-blocking API for posting interrupt")
Cc: sta...@dpdk.org
Reported-by: Li Feng
Signed-off-by: Maxime Coquelin
---
lib/vhost/vhost.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/lib/vhost/vhost.c b/lib/vhost/v
multiple patches to ease LTS maintainers backports,
but could be squashed if preferred.
Changes in v2:
--
- Rebased to apply on -rc1 (David)
- Add Fixes tag in patch 1 (David)
- Fix various typos in commit logs (David)
Maxime Coquelin (7):
vhost: fix missing vring call check on
Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.
The access status must also be checked.
Fixes: 4e0de8dac853 ("vhost: protect vring access done by application")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
li
Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.
The access status must also be checked.
Fixes: d761d455a0e4 ("vhost: add operation to offload the interrupt kick")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
li
Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.
The access status must also be checked.
Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async vhost")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.
The access status must also be checked.
Fixes: be75dc99ea1f ("vhost: support per-virtqueue statistics")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
lib/vho
Acquiring the access lock is not enough to ensure
virtqueue's metadata such as vring pointers are valid.
The access status must also be checked.
Fixes: 78639d54563a ("vhost: introduce async enqueue registration API")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
li
The power monitor get API is missing both access lock
protection and access status check.
Fixes: 34fd4373ce76 ("vhost: add power monitor API")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
---
lib/vhost/vhost.c | 13 -
1 file changed, 12 insertions(+), 1 deletio
et config vector");
- return -EBUSY;
- }
-
if (virtio_with_packed_queue(hw)) {
#if defined(RTE_ARCH_X86_64) && defined(CC_AVX512_SUPPORT)
if ((hw->use_vec_rx || hw->use_vec_tx) &&
It looks good to me, so I can change the title
On 10/20/23 10:51, Chenbo Xia wrote:
I left Intel and joined Nvidia, so update my email address.
Signed-off-by: Chenbo Xia
---
.mailmap| 2 +-
MAINTAINERS | 12 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
Welcime back Chenbo :)
Acked-by: Maxime Coquelin
On 10/19/23 14:12, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Thursday, October 19, 2023 10:47 AM
To: Chautru, Nicolas ; Vargas, Hernan
; dev@dpdk.org; gak...@marvell.com; Rix, Tom
Cc: Zhang, Qi Z
Subject: Re: [PATCH v1 06/11] test/bbdev
With LTS maintainers actually added... sorry.
On 10/23/23 11:05, Maxime Coquelin wrote:
On 10/19/23 14:12, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Thursday, October 19, 2023 10:47 AM
To: Chautru, Nicolas ; Vargas, Hernan
; dev@dpdk.org
Unique device name */
@@ -369,6 +374,7 @@ struct rte_bbdev_info {
bool started; /**< Set if device is currently started */
struct rte_bbdev_driver_info drv; /**< Info from device driver */
};
+/* >8 End of structure rte_bbdev_info. */
/**
* Retrieve information
+++---
doc/guides/tools/testbbdev.rst | 2 ++
7 files changed, 22 insertions(+), 196 deletions(-)
Thanks for removing these duplications.
Reviewed-by: Maxime Coquelin
Maxime
On 8/8/23 19:35, Stephen Hemminger wrote:
Since 23.11 is an LTS release it is time to remove the experimental
bandaid off many API's. There are about 850 API's marked with experimental
on current main branch. This addresses the easy to remove ones and
gets it down to about 690 places.
The rul
On 10/10/23 22:34, Nicolas Chautru wrote:
Adding more information in bbdev documentation related to the
bbdev device discovery from info_get which was not very verbose so far.
Notably for FEC and FFT operations which have extra parameters to
manage different implementation variants.
Also use
On 10/20/23 10:47, Maxime Coquelin wrote:
Li Feng initially reported segmentation fault in rte_vhost_vring_call()
because of not checking the virtqueue metadata can be accessed.
This should be achieved by checking the access_ok status field of
the virtqueue.
This series also takes the
ed-by: Wei Ling
Reviewed-by: Maxime Coquelin
---
v2:
- rewording of the title
---
drivers/net/virtio/virtio_ethdev.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index
On 10/17/23 09:26, Fengjiang Liu wrote:
When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc
Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
Signed-off-by:
Hi Nicolas,
On 10/18/23 12:56, David Marchand wrote:
On Tue, Oct 10, 2023 at 7:55 PM Hernan Vargas wrote:
Implement de-ratematch pre-processing for ACC100 SW corner cases.
Some specific 5GUL FEC corner cases may cause unintended back pressure
and in some cases a potential stability issue on t
Hi Nicolas;
On 10/16/23 16:49, Chautru, Nicolas wrote:
Hi Maxime,
Just a heads up that Hernan is going on paternity leave, I will be
covering for his series pending for 23.11. Ping me if there is any
update required from review that I may have missed.
Pending series in patchwork:
* SDK +
: Maxime Coquelin
Thanks,
Maxime
nt16_t) process_cnt; /** Counter of processes using the
device */
};
/* Forward declarations */
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
w_ring_depth + q->sw_ring_tail - q->sw_ring_head;
+ int32_t avail = acc_ring_avail_enq(q);
That's problematic because the patch introducing acc_ring_avail_enq() is
a feature patch for v22.11 and not a fix. You'll have to help the LTS
maintainers to backport it.
Other than that:
Revie
On 10/12/22 04:53, Hernan Vargas wrote:
It is possible for some corner case to run more batch enqueue than
supported. A protection is required to avoid that corner case.
Enhance all ACC100 enqueue operations with check to see if there is room
in the atomic queue for enqueueing batches into the
No new line here.
Reviewed-by: Maxime Coquelin
---
drivers/baseband/acc/rte_acc100_pmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_acc100_pmd.c
index b436bd9078..436af977e4 100644
--- a/driver
insertions(+), 7 deletions(-)
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
by: Hernan Vargas
Reviewed-by: Maxime Coquelin
---
drivers/baseband/acc/rte_acc100_pmd.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_acc100_pmd.c
index f636d4fa0f..3a008a3b88 10
On 10/12/22 04:53, Hernan Vargas wrote:
Add unlikely checks for NULL operation values.
Fixes: f404dfe35cc ("baseband/acc100: support 4G processing")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
Reviewed-by: Maxime Coquelin
---
drivers/baseband/acc/rte_acc100_
On 10/12/22 04:53, Hernan Vargas wrote:
Enforce additional check on Frame Control Word validity and add stronger
alignment for decompression mode.
Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
drivers/baseband/ac
On 10/12/22 04:53, Hernan Vargas wrote:
Allocate info ring, tail pointers and HARQ layout memory for a device
only if it hasn't already been allocated.
Fixes: 06531464151 ("baseband/acc100: support interrupt")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
drivers/baseband/acc/rte_a
TTACH))
+ if (enc->op_flags & RTE_BBDEV_LDPC_CRC_24B_ATTACH)
in_length_in_bits -= 24;
in_length_in_bytes = in_length_in_bits >> 3;
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
.
Fixes: 06531464151 ("baseband/acc100: support interrupt")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
No new line here.
Reviewed-by: Maxime Coquelin
---
drivers/baseband/acc/rte_acc100_pmd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/ba
No new line
Reviewed-by: Maxime Coquelin
---
drivers/baseband/acc/rte_acc100_pmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c
b/drivers/baseband/acc/rte_acc100_pmd.c
index e561d33150..8e5cd76693 100644
--- a/drivers/ba
1 - 100 of 5478 matches
Mail list logo
