RE: [PATCH v2 0/2] ethdev: add random item support

2023-10-12 Thread Michael Baum
On Monday, 11 September 2023 20:53 Stephen Hemminger wrote: > > On Mon, 11 Sep 2023 18:55:45 +0200 > Morten Brørup wrote: > > > > From: Michael Baum [mailto:michae...@nvidia.com] > > > Sent: Monday, 11 September 2023 08.42 > > > > > >

RE: [PATCH v2 1/2] ethdev: add random item support

2023-10-12 Thread Michael Baum
11/09/2023 19:00, Thomas Monjalon: > > 11/09/2023 09:41, Michael Baum: > > Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". > > This item enables to match on some random value as a part of flow rule. > > > > Signed-off-by: M

RE: [PATCH 3/3] ethdev: add structure for indirect AGE update

2022-10-19 Thread Michael Baum
> >> On 10/3/22 11:30, Ori Kam wrote: > >>> Hi Andrew, > >>> > >>>> -Original Message- > >>>> From: Andrew Rybchenko > >>>> Sent: Monday, 3 October 2022 11:04 > >>>> > >>>> On 9/21/22 17:54, Michael

[PATCH v2 0/3] ethdev: AGE action preparation

2022-10-19 Thread Michael Baum
n, to be aligned with the structure definition. - Place long comment before struct member definition. Michael Baum (3): ethdev: add strict queue to pre-configuration flow hints ethdev: add queue-based API to report aged flow rules ethdev: add structure for indirect AGE update app/test-pmd/cm

[PATCH v2 3/3] ethdev: add structure for indirect AGE update

2022-10-19 Thread Michael Baum
Add a new structure for indirect AGE update. This new structure enables: 1. Update timeout value. 2. Stop AGE checking. 3. Start AGE checking. 4. restart AGE checking. Signed-off-by: Michael Baum Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c| 66 ++ app

[PATCH v2 1/3] ethdev: add strict queue to pre-configuration flow hints

2022-10-19 Thread Michael Baum
resource could be isolated and access based on queue, without lock, for example. This patch add flag about above situation and could be extended to cover more situations. Signed-off-by: Michael Baum Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 10 ++ doc/guides

[PATCH v2 2/3] ethdev: add queue-based API to report aged flow rules

2022-10-19 Thread Michael Baum
resources are isolated by queue and needn't synchronize. If application do use queue-based flow management but configure port without RTE_FLOW_PORT_FLAG_STRICT_QUEUE, which means application operate a given flow rule on different queues, the queue id parameter will be ignored. Signed-off-by: Mi

[PATCH v3 0/3] ethdev: AGE action preparation

2022-10-19 Thread Michael Baum
n, to be aligned with the structure definition. - Place long comment before struct member definition. v3: - Fix miss "break" in indirect action update switch-case. Michael Baum (3): ethdev: add strict queue to pre-configuration flow hints ethdev: add queue-based API to report aged flow

[PATCH v3 3/3] ethdev: add structure for indirect AGE update

2022-10-19 Thread Michael Baum
Add a new structure for indirect AGE update. This new structure enables: 1. Update timeout value. 2. Stop AGE checking. 3. Start AGE checking. 4. restart AGE checking. Signed-off-by: Michael Baum Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c| 66 ++ app

[PATCH v3 2/3] ethdev: add queue-based API to report aged flow rules

2022-10-19 Thread Michael Baum
resources are isolated by queue and needn't synchronize. If application do use queue-based flow management but configure port without RTE_FLOW_PORT_FLAG_STRICT_QUEUE, which means application operate a given flow rule on different queues, the queue id parameter will be ignored. Signed-off-by: Mi

[PATCH v3 1/3] ethdev: add strict queue to pre-configuration flow hints

2022-10-19 Thread Michael Baum
resource could be isolated and access based on queue, without lock, for example. This patch add flag about above situation and could be extended to cover more situations. Signed-off-by: Michael Baum Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 10 ++ doc/guides

[PATCH 1/2] common/mlx5: fix miss null check in devargs parsing

2022-10-24 Thread Michael Baum
but its field "args" is invalid, the function tries to parse it and dereference to NULL pointer. This patch adds check to avoid this NULL dereferencing. Fixes: a729d2f093e9 ("common/mlx5: refactor devargs management") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Signed-off

[PATCH 0/2] mlx5: fix miss NULL check in devargs parsing

2022-10-24 Thread Michael Baum
the PMD tries to parse it and dereference to NULL pointer. Those patches add checks to avoid these NULL dereferencing. Michael Baum (2): common/mlx5: fix miss null check in devargs parsing net/mlx5: fix miss null check in ETH devargs parsing drivers/common/mlx5/mlx5_common.c | 8 ++

[PATCH 2/2] net/mlx5: fix miss null check in ETH devargs parsing

2022-10-24 Thread Michael Baum
tion avoids parsing it. However, when it valid but its field "args" is invalid, the function tries to parse it and dereference to NULL pointer. This patch adds check to avoid this NULL dereferencing. Fixes: 919488fbfa71 ("net/mlx5: support Sub-Function") Cc: xuemi...@nvidia.co

[PATCH] net/mlx5: fix wrong free function in HWS AGE info

2022-10-24 Thread Michael Baum
HWS AGE action support") Cc: michae...@nvidia.com Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_hws_cnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c index 9c37700f94..

RE: [PATCH v3 2/3] ethdev: add queue-based API to report aged flow rules

2022-10-26 Thread Michael Baum
On 10/26/22 22:16, Andrew Rybchenko wrote: > > On 10/19/22 17:49, Michael Baum wrote: > > When application use queue-based flow rule management and operate the > > same flow rule on the same queue, e.g create/destroy/query, API of > > querying aged flow rules should also

RE: [PATCH v3 3/3] ethdev: add structure for indirect AGE update

2022-10-26 Thread Michael Baum
On 10/26/22 22:18, Andrew Rybchenko wrote: > > On 10/19/22 17:49, Michael Baum wrote: > > Add a new structure for indirect AGE update. > > > > This new structure enables: > > 1. Update timeout value. > > 2. Stop AGE checking. > > 3. Start

[PATCH v4 0/3] ethdev: AGE action preparation

2022-10-26 Thread Michael Baum
n, to be aligned with the structure definition. - Place long comment before struct member definition. v3: - Fix miss "break" in indirect action update switch-case. v4: - Remove unrelated doc fixes. Michael Baum (3): ethdev: add strict queue to pre-configuration flow hints ethdev: add

[PATCH v4 1/3] ethdev: add strict queue to pre-configuration flow hints

2022-10-26 Thread Michael Baum
resource could be isolated and access based on queue, without lock, for example. This patch add flag about above situation and could be extended to cover more situations. Signed-off-by: Michael Baum Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- app/test-pmd/cmdline_flow.c | 10

[PATCH v4 2/3] ethdev: add queue-based API to report aged flow rules

2022-10-26 Thread Michael Baum
resources are isolated by queue and needn't synchronize. If application do use queue-based flow management but configure port without RTE_FLOW_PORT_FLAG_STRICT_QUEUE, which means application operate a given flow rule on different queues, the queue id parameter will be ignored. Signed-off-by: Mi

[PATCH v4 3/3] ethdev: add structure for indirect AGE update

2022-10-26 Thread Michael Baum
Add a new structure for indirect AGE update. This new structure enables: 1. Update timeout value. 2. Stop AGE checking. 3. Start AGE checking. 4. restart AGE checking. Signed-off-by: Michael Baum Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- app/test-pmd/cmdline_flow.c| 66

[PATCH 0/5] net/mlx5: some counter fixes

2022-10-31 Thread Michael Baum
Some fixes for HW/SW steering counters. Michael Baum (5): net/mlx5: fix race condition in counter pool resizing net/mlx5: fix accessing the wrong counter net/mlx5: fix missing counter elements copies in r2r cases net/mlx5: add assertions in counter get/put net/mlx5: assert for enough

[PATCH 1/5] net/mlx5: fix race condition in counter pool resizing

2022-10-31 Thread Michael Baum
number by 16M. Fixes: 3aa279157fa0 ("net/mlx5: synchronize flow counter pool creation") Cc: suanmi...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c| 28 +--- drivers/net/mlx5/mlx5.h

[PATCH 2/5] net/mlx5: fix accessing the wrong counter

2022-10-31 Thread Michael Baum
cnt_id is taken from the cache. Unfortunately, for updating fields like "in_used" or "age_idx", the function wrongly may use the old "iidx" coming from an invalid cnt_id. Update the "iidx" in case of an invalid counter popped from the cache. Fixes: 4d368e1da

[PATCH 3/5] net/mlx5: fix missing counter elements copies in r2r cases

2022-10-31 Thread Michael Baum
scenario is commonly happening in counters when the internal mlx5 service thread copies elements from the reset ring into the reuse ring. This patch changes the function to copy n3 regardless of n2 value. Fixes: 4d368e1da3a4 ("net/mlx5: support flow counter action for HWS") Cc: jack...@nvi

[PATCH 4/5] net/mlx5: add assertions in counter get/put

2022-10-31 Thread Michael Baum
Add assertions to help debug in case of counter double alloc/free. Signed-off-by: Michael Baum Acked-by: Matan Azrad Acked-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_hws_cnt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx5/mlx5_hws_cnt.h b/drivers/net/mlx5

[PATCH 5/5] net/mlx5: assert for enough space in counter rings

2022-10-31 Thread Michael Baum
those assumptions. Signed-off-by: Michael Baum Acked-by: Matan Azrad Acked-by: Xiaoyu Min --- drivers/net/mlx5/mlx5_flow_hw.c | 2 +- drivers/net/mlx5/mlx5_hws_cnt.c | 25 drivers/net/mlx5/mlx5_hws_cnt.h | 106 +--- 3 files changed, 72 insertions(+), 61

RE: [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-01-24 Thread Michael Baum
Hi All, any comments? From: Michael Baum > The "rte_compressdev_info_get()" function retrieves the contextual information > of a device. > The output structure "dev_info" contains a list of devices supported > capabilities > for each supported algorithm. &g

RE: [EXT] [PATCH 1/4] compressdev: add LZ4 algorithm support

2023-01-30 Thread Michael Baum
On Mon, Jan 30, 2023 at 20:35 PM Akhil Goyal wrote: > > > +/** > > + * Block checksum flag. > > + * If this flag is set, each data block will be followed by a 4-bytes > > checksum, > > + * calculated by using the xxHash-32 algorithm on the raw (compressed) data > > + * block. The intention is t

RE: [EXT] [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-02-01 Thread Michael Baum
Hi, > > > Hi, > > > > > > > > After this change, I'm not sure about the purpose of > > > > "RTE_COMP_ALGO_LIST_END". > > > > There is no any other use of it in DPDK code, and it isn't > > > > represent the number of algorithms supported by the API since the > > > > "RTE_COMP_ALGO_UNSPECIFIED" i

[PATCH v2 0/2] compressdev: fix end of list enums conflict

2023-02-01 Thread Michael Baum
Handle the conflict about which enum value is used as end of list. v2: add patch to remove useless list end enums. Michael Baum (2): compressdev: fix end of comp PMD list macro conflict compressdev: remove useless list end enums drivers/compress/mlx5/mlx5_compress.c| 4

[PATCH v2 1/2] compressdev: fix end of comp PMD list macro conflict

2023-02-01 Thread Michael Baum
es") Fixes: 2d148597ce76 ("compress/qat: add gen-specific implementation") Fixes: 384bac8d6555 ("compress/mlx5: add supported capabilities") Cc: fiona.tr...@intel.com Cc: roy.fan.zh...@intel.com Cc: ma...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- driver

[PATCH v2 2/2] compressdev: remove useless list end enums

2023-02-01 Thread Michael Baum
The both "RTE_COMP_ALGO_LIST_END" and "RTE_COMP_HASH_ALGO_LIST_END" are useless. This patch removes them from the library. Signed-off-by: Michael Baum --- lib/compressdev/rte_comp.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/compressdev/rte_comp.h b/lib/co

[PATCH v2 0/4] compressdev: add LZ4 support

2023-02-02 Thread Michael Baum
patch/20220410182622.8828-1-rzid...@nvidia.com/ v2: - Add macros for all LZ4 flags in the standard. - Rebase. Depends-on: series-26738 ("compressdev: fix end of list enums conflict") Michael Baum (4): compressdev: add LZ4 algorithm support app/test-compress-perf: allow test

[PATCH v2 1/4] compressdev: add LZ4 algorithm support

2023-02-02 Thread Michael Baum
Add support for LZ4 algorithm: - Add Lz4 param structure to XFORM structures. - Add capabilities flags for LZ4 params. - Add xxHash-32 checksum and capabilities flag. Signed-off-by: Michael Baum --- doc/guides/compressdevs/features/default.ini | 7 ++ doc/guides/rel_notes/release_23_03.rst

[PATCH v2 2/4] app/test-compress-perf: allow test single compress operation

2023-02-02 Thread Michael Baum
Part of the application options is to test only compress and only decompress but actually the application ignores this user option and tries to test always both compress and decompress. Allow testing only compress and only decompress. Signed-off-by: Matan Azrad Signed-off-by: Michael Baum

[PATCH v2 3/4] app/test-compress-perf: add algo option

2023-02-02 Thread Michael Baum
Add a command line option `algo` to select the compress algorithm supported by the compress API: null (DMA), deflate and lzs. Default for deflate. Signed-off-by: Matan Azrad Signed-off-by: Michael Baum --- app/test-compress-perf/comp_perf_options.h| 2 + .../comp_perf_options_parse.c

[PATCH v2 4/4] app/test-compress-perf: add LZ4 support

2023-02-02 Thread Michael Baum
Add support for LZ4 algorithm and add a new parameter for it. Signed-off-by: Michael Baum --- app/test-compress-perf/comp_perf_options.h| 1 + .../comp_perf_options_parse.c | 43 ++- .../comp_perf_test_cyclecount.c | 7

[PATCH v2 0/8] compress/mlx5: add LZ4 support

2023-02-02 Thread Michael Baum
Depends-on: series-26738 ("compressdev: fix end of list enums conflict") v2: - Rebase. - Update PRM names. - Add a new fix at the beginning of the patch-set. Michael Baum (8): compress/mlx5: fix decompress xform validation compress/mlx5: fix wrong output Adler-32 checksum offset c

[PATCH v2 1/8] compress/mlx5: fix decompress xform validation

2023-02-02 Thread Michael Baum
object. This patch changes it to verify decompress xform object. Fixes: 2efd26544554 ("compress/mlx5: support partial transformation") Cc: rzid...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 2 +- 1 file changed, 1 insertion(+

[PATCH v2 2/8] compress/mlx5: fix wrong output Adler-32 checksum offset

2023-02-02 Thread Michael Baum
ns") Cc: ma...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index cadff83f27..c46fb4eb89

[PATCH v2 3/8] compress/mlx5: fix QP setup for partial transformations

2023-02-02 Thread Michael Baum
requirement. Fixes: 2efd26544554 ("compress/mlx5: support partial transformation") Cc: rzid...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/com

[PATCH v2 4/8] compress/mlx5: support new metadata layout added in BF3

2023-02-02 Thread Michael Baum
eld-3 device ID") Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++-- drivers/common/mlx5/mlx5_devx_cmds.h | 3 +- drivers/common/mlx5/mlx5_prm.h| 40 +++- drivers/compress/mlx5/mlx5_compress.c | 45 +-- 4 fil

[PATCH v2 7/8] common/mlx5: add LZ4 capabilities check

2023-02-02 Thread Michael Baum
Add capabilities check for LZ4 decompression algorithm. Signed-off-by: Michael Baum --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++ drivers/common/mlx5/mlx5_prm.h | 16 ++-- 3 files changed, 23 insertions(+), 2 deletions

[PATCH v2 8/8] compress/mlx5: add support for LZ4 algorithm

2023-02-02 Thread Michael Baum
Add support for decompress LZ4 algorithm for mlx5 PMD. Signed-off-by: Michael Baum --- doc/guides/compressdevs/features/mlx5.ini | 18 ++- doc/guides/compressdevs/mlx5.rst | 49 ++- doc/guides/rel_notes/release_23_03.rst| 4 + drivers/compress/mlx5/mlx5_compress.c | 150

[PATCH v2 5/8] compress/mlx5: remove unused variable from priv structure

2023-02-02 Thread Michael Baum
The priv structure has variable named "min_block_size" coming from HCA capabilities. This field isn't used and copied into the priv structure for free. This patch removes this field. Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 3 --- 1 file chang

[PATCH v2 6/8] compress/mlx5: add xform validate function

2023-02-02 Thread Michael Baum
Separate the xform validations from create function into new function. The new function checks caps directly from HCA attr structure, so all capabilities in priv structure were removed. Signed-off-by: Michael Baum --- drivers/compress/mlx5/mlx5_compress.c | 75 +++ 1

[PATCH v2 0/2] ethdev: add random item support

2023-09-11 Thread Michael Baum
Add support for matching random value using new "rte_flow_item_random" structure. This random value is not based on the packet data/headers. Application shouldn't assume that this value is kept during the life time of the packet. v2: - Rabase. - Fix copy-paste mistake in release

[PATCH v2 1/2] ethdev: add random item support

2023-09-11 Thread Michael Baum
Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". This item enables to match on some random value as a part of flow rule. Signed-off-by: Michael Baum --- doc/guides/nics/features/default.ini | 1 + doc/guides/prog_guide/rte_flow.rst | 11 + doc/guides

[PATCH v2 2/2] app/testpmd: add random item support

2023-09-11 Thread Michael Baum
Add support for random item, usage example: pattern random spec value 0x1 mask value 0x3 / eth / end Flow rule with above pattern matching 25% of the traffic, it hits only when random value suffix is "01" and miss the others ("00", "10", "11"). Si

RE: [PATCH v2 0/2] ethdev: add random item support

2023-09-12 Thread Michael Baum
On Mon, 11 Sep 2023 18:55:45 +0200 Morten Brørup wrote: > > > From: Michael Baum [mailto:michae...@nvidia.com] > > Sent: Monday, 11 September 2023 08.42 > > > > Add support for matching random value using new "rte_flow_item_random" > > structure. &g

[dpdk-dev] [PATCH 0/5] net/mlx5: add indirect count action

2021-04-26 Thread Michael Baum
Add support of indirect action API for count action. Michael Baum (5): net/mlx5: support flow count action handle app/testpmd: remove indirect RSS action query app/testpmd: support indirect counter action query net/mlx5: fix flow age event triggering net/mlx5: use aging by counter when

[dpdk-dev] [PATCH 1/5] net/mlx5: support flow count action handle

2021-04-26 Thread Michael Baum
to be supported, and the user can choose the way he wants to share the counter. The new indirect action API is only supported in DevX, so sharing counter action in Verbs can only be done through the old mechanism. [1] https://mails.dpdk.org/archives/dev/2020-July/174110.html Signed-off-by: Michael

[dpdk-dev] [PATCH 2/5] app/testpmd: remove indirect RSS action query

2021-04-26 Thread Michael Baum
The port_action_handle_query function supports query operation for indirect RSS action. No driver currently supports this operation, and this support is unnecessary. Remove it. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- app/test-pmd/config.c | 7 --- 1 file changed, 7

[dpdk-dev] [PATCH 3/5] app/testpmd: support indirect counter action query

2021-04-26 Thread Michael Baum
Counter action query was implemented as part of flow query, but was not implemented as part of indirect action query. This patch adds the required implementation. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- app/test-pmd/config.c | 145

[dpdk-dev] [PATCH 5/5] net/mlx5: use aging by counter when counter is existed

2021-04-26 Thread Michael Baum
no need to create more ASO action for it. The current code always uses ASO when it is supported in the device, change it to reuse the non-shared counter if it exists in the flow. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_flow_dv.c | 149

[dpdk-dev] [PATCH 4/5] net/mlx5: fix flow age event triggering

2021-04-26 Thread Michael Baum
stop the event invoking forever. Unset the TRIGGER flag before the event invoking in order to allow set it by the user callback. Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Cc: sta...@dpdk.org Reported-by: David Bouyeure Signed-off-by: Michael Baum Acked-by: M

[dpdk-dev] [PATCH v2] net/mlx5: workaround ASO memory region creation

2021-04-26 Thread Michael Baum
Due to kernel issue in direct MKEY creation using the DevX API for physical memory, this patch replaces the ASO MR creation to use Verbs API. Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad -

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] compress/mlx5: fix constant size in QP creation

2021-06-28 Thread Michael Baum
External email: Use caution opening links or attachments > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 23, 2021 9:48 AM > To: Michael Baum > Cc: dev@dpdk.org; sta...@dpdk.org; Matan Azrad ; > Raslan Darawsheh ; Slava Ovsiienko > > S

[dpdk-dev] [PATCH] common/mlx5: share memory free callback

2021-06-28 Thread Michael Baum
All the mlx5 drivers using MRs for data-path must unregister the mapped memory when it is freed by the dpdk process. Currently, only the net/eth driver unregisters MRs in free event. Move the net callback handler from net driver to common. Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked

[dpdk-dev] [PATCH 1/3] regex/mlx5: fix memory region unregistration

2021-06-28 Thread Michael Baum
DPDK process. Register a driver callback for memory event in order to free out all the MRs of memory that is going to be freed from the dpdk process. Fixes: cda883bbb655 ("regex/mlx5: add dynamic memory registration to datapath") Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- T

[dpdk-dev] [PATCH 2/3] regex/mlx5: fix leak in PCI remove function

2021-06-28 Thread Michael Baum
ation to datapath") Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- drivers/regex/mlx5/mlx5_regex.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index 0f12d94d7e..f64dc2824c 100644 --- a/drivers/regex/mlx5/ml

[dpdk-dev] [PATCH 3/3] regex/mlx5: fix redundancy in PCI remove function

2021-06-28 Thread Michael Baum
In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: sta...@dpdk.org Signed-off-by: Mi

[dpdk-dev] [PATCH v2 1/4] regex/mlx5: fix size of setup constants

2021-06-30 Thread Michael Baum
32-bit arithmetic, and then used in a context that expects an expression of type size_t that might be 64 bit. Change the size of the above constants to size_t. Fixes: 30d604bb1504 ("regex/mlx5: fix type of setup constants") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: M

[dpdk-dev] [PATCH v2 2/4] compress/mlx5: fix constant size in QP creation

2021-06-30 Thread Michael Baum
is greater than 32 bit and it 64-system, the variable will lose its value even though the function can get 64-bit argument. Change the size of the numeric constant 1 to size_t. Fixes: 8619fcd5161b ("compress/mlx5: support queue pair operations") Cc: sta...@dpdk.org Signed-off-by: Mi

[dpdk-dev] [PATCH v2 3/4] vdpa/mlx5: fix constant type in QP creation

2021-06-30 Thread Michael Baum
variable will get into it a different value than what the function intended it to get. Set the numeric constant 1 to be uint64_t in the first place. Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers

[dpdk-dev] [PATCH v2 4/4] net/mlx5: fix constant type in MP allocation

2021-06-30 Thread Michael Baum
ned-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index bb9a908087..83ee8ddb9c 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/

[dpdk-dev] [PATCH] compress/mlx5: fix memory region unregistration

2021-07-01 Thread Michael Baum
DPDK process. Register a driver callback for memory event in order to free out all the MRs of memory that is going to be freed from the dpdk process. Fixes: f8c97babc9f4 ("compress/mlx5: add data-path functions") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --

[dpdk-dev] [PATCH_v2 1/3] regex/mlx5: fix memory region unregistration

2021-07-04 Thread Michael Baum
DPDK process. Register a driver callback for memory event in order to free out all the MRs of memory that is going to be freed from the dpdk process. Fixes: cda883bbb655 ("regex/mlx5: add dynamic memory registration to datapath") Cc: sta...@dpdk.org Signed-off-by: Michael Ba

[dpdk-dev] [PATCH_v2 2/3] regex/mlx5: fix leak in PCI remove function

2021-07-04 Thread Michael Baum
ation to datapath") Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- drivers/regex/mlx5/mlx5_regex.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index 0f12d94d7e..f64dc2824c 100644 --- a/drivers/regex/mlx5/ml

[dpdk-dev] [PATCH_v2 3/3] regex/mlx5: fix redundancy in PCI remove function

2021-07-04 Thread Michael Baum
In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: sta...@dpdk.org Signed-off-by: Mi

[dpdk-dev] [PATCH_v3 0/3] regex/mlx5: some independent fixes

2021-07-07 Thread Michael Baum
Some independent fixes in MLX5 RegEx driver. v1: Initial fixes. v2: Initialize pointer of global generation number. Add global generation number checking in indirect mkey creation. v3: Rebase. Michael Baum (3): regex/mlx5: fix memory region unregistration regex/mlx5: fix leak in PCI

[dpdk-dev] [PATCH_v3 1/3] regex/mlx5: fix memory region unregistration

2021-07-07 Thread Michael Baum
DPDK process. Register a driver callback for memory event in order to free out all the MRs of memory that is going to be freed from the dpdk process. Fixes: cda883bbb655 ("regex/mlx5: add dynamic memory registration to datapath") Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- dri

[dpdk-dev] [PATCH_v3 2/3] regex/mlx5: fix leak in PCI remove function

2021-07-07 Thread Michael Baum
ation to datapath") Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- drivers/regex/mlx5/mlx5_regex.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index 0f12d94d7e..f64dc2824c 100644 --- a/drivers/regex/mlx5/ml

[dpdk-dev] [PATCH_v3 3/3] regex/mlx5: fix redundancy in PCI remove function

2021-07-07 Thread Michael Baum
In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: sta...@dpdk.org Signed-off-by: Mi

Re: [dpdk-dev] [EXT] [PATCH] compress/mlx5: fix memory region unregistration

2021-07-07 Thread Michael Baum
;compress/mlx5: add data-path functions") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Michael Baum > > Acked-by: Matan Azrad > > --- > CI is reporting error with this patch. Can you check? This patch depends on this patch: https://patchwork.dpdk.org/projec

[PATCH] ethdev: fix GENEVE option item conversion

2024-07-15 Thread Michael Baum
Fixes: 2b4c72b4d10d ("ethdev: introduce GENEVE header TLV option item") Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- lib/ethdev/rte_flow.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.

[PATCH v2 0/2] mlx5/testpmd: external RxQ tests

2022-06-16 Thread Michael Baum
iptor threshold and host shaper") v1: Initial commit. v2: Fix typos in documentation. Move mlx5 specific tests to mlx5 library. Change socket style SOCK_DGRAM -> SOCK_SEQPACKET. Michael Baum (2): app/testpmd: add test for remote PD and CTX app/testpmd: add test for external R

[PATCH v2 2/2] app/testpmd: add test for external RxQ

2022-06-16 Thread Michael Baum
; port (port_id) ext_rxq unmap (rte_queue_id) Signed-off-by: Michael Baum Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst| 19 drivers/net/mlx5/mlx5_testpmd.c | 153 +++- 2 files changed, 170 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx5

[PATCH v2 1/2] app/testpmd: add test for remote PD and CTX

2022-06-16 Thread Michael Baum
ication import it using IPC, and updates the devargs list before attaching. The syntax is: testpmd > port attach (identifier) mlx5_socket=(path) Where "path" is the IPC socket path agreed on the remote process. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- app/test-pmd

[PATCH v3 0/2] net/mlx5: external RxQ tests

2022-06-28 Thread Michael Baum
specific tests to mlx5 library. Change socket style SOCK_DGRAM -> SOCK_SEQPACKET. v3: Move all these tests to mlx5 library. Add mlx5 prefix to mlx5 specific tests. Improve documentation. Michael Baum (2): net/mlx5: add test for remote PD and CTX net/mlx5: add test for external Rx qu

[PATCH v3 1/2] net/mlx5: add test for remote PD and CTX

2022-06-28 Thread Michael Baum
cess. [1] http://patches.dpdk.org/project/dpdk/patch/20220224232511.3238707-4-michae...@nvidia.com/ Signed-off-by: Michael Baum Reviewed-by: Thomas Monjalon Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst| 47 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 + drivers/net/mlx5/mlx

[PATCH v3 2/2] net/mlx5: add test for external Rx queue

2022-06-28 Thread Michael Baum
; mlx5 port (port_id) ext_rxq unmap (sw_queue_id) Signed-off-by: Michael Baum Reviewed-by: Thomas Monjalon Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst| 19 drivers/net/mlx5/mlx5_testpmd.c | 163 2 files changed, 182 insertions(+) diff --git

[dpdk-dev] [PATCH 0/6] net/mlx5: reduce Tx datapath compile time

2021-04-05 Thread Michael Baum
generated in the same file and this compilation is not being done in parallel with using multithreading. Therefore, in this series we split the mlx5_rxtx.c file into several separate files to allow different functions to be compiled simultaneously. Michael Baum (6): net/mlx5: separate Rx

[dpdk-dev] [PATCH 3/6] net/mlx5: separate Tx function declarations to another file

2021-04-05 Thread Michael Baum
This patch separates Tx function declarations to different header file in preparation for removing their implementation from the source file and as an optional preparation for Tx cleanup. Signed-off-by: Michael Baum --- drivers/net/mlx5/linux/mlx5_mp_os.c | 1 + drivers/net/mlx5/linux

[dpdk-dev] [PATCH 1/6] net/mlx5: separate Rx function declarations to another file

2021-04-05 Thread Michael Baum
header file in preparation for removing them from the source file and as an optional preparation step for further consolidation of Rx burst functions. Signed-off-by: Michael Baum --- drivers/net/mlx5/linux/mlx5_mp_os.c | 1 + drivers/net/mlx5/linux/mlx5_os.c| 1 + drivers/net/mlx5/linux

[dpdk-dev] [PATCH 6/6] net/mlx5: separate Tx burst functions to different files

2021-04-05 Thread Michael Baum
This patch separates Tx burst function implementations to different source files, thus allowing them to compile in parallel. Signed-off-by: Michael Baum --- drivers/net/mlx5/meson.build | 4 + drivers/net/mlx5/mlx5_rxtx.c | 201 --- drivers/net/mlx5

[dpdk-dev] [PATCH 2/6] net/mlx5: separate Rx function implementations to new file

2021-04-05 Thread Michael Baum
This patch separates Rx function implementations to different source file as an optional preparation step for further consolidation of Rx burst functions. Signed-off-by: Michael Baum --- drivers/net/mlx5/meson.build |1 + drivers/net/mlx5/mlx5_rx.c | 1203

[dpdk-dev] [PATCH 5/6] net/mlx5: separate Tx function implementations to new file

2021-04-05 Thread Michael Baum
This patch separates Tx function implementations to different source file as an optional preparation step for Tx cleanup. Signed-off-by: Michael Baum --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5_rxtx.c | 757 - drivers/net/mlx5

[dpdk-dev] [PATCH v2 0/6] net/mlx5: reduce Tx datapath compile time

2021-04-11 Thread Michael Baum
generated in the same file and this compilation is not being done in parallel with using multithreading. Therefore, in this series we split the mlx5_rxtx.c file into several separate files to allow different functions to be compiled simultaneously. v2: fix compilation error + rebase Michael Baum

[dpdk-dev] [PATCH v2 3/6] net/mlx5: separate Tx function declarations to another file

2021-04-11 Thread Michael Baum
This patch separates Tx function declarations to different header file in preparation for removing their implementation from the source file and as an optional preparation for Tx cleanup. Signed-off-by: Michael Baum Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_mp_os.c | 1

[dpdk-dev] [PATCH v2 2/6] net/mlx5: separate Rx function implementations to new file

2021-04-11 Thread Michael Baum
This patch separates Rx function implementations to different source file as an optional preparation step for further consolidation of Rx burst functions. Signed-off-by: Michael Baum Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/meson.build |1 + drivers/net/mlx5/mlx5_rx.c | 1203

[dpdk-dev] [PATCH v2 1/6] net/mlx5: separate Rx function declarations to another file

2021-04-11 Thread Michael Baum
header file in preparation for removing them from the source file and as an optional preparation step for further consolidation of Rx burst functions. Signed-off-by: Michael Baum Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_mp_os.c | 1 + drivers/net/mlx5/linux/mlx5_os.c

[dpdk-dev] [PATCH v2 5/6] net/mlx5: separate Tx function implementations to new file

2021-04-11 Thread Michael Baum
This patch separates Tx function implementations to different source file as an optional preparation step for Tx cleanup. Signed-off-by: Michael Baum Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5_rxtx.c | 757

[dpdk-dev] [PATCH v2 6/6] net/mlx5: separate Tx burst functions to different files

2021-04-11 Thread Michael Baum
This patch separates Tx burst function implementations to different source files, thus allowing them to compile in parallel. Signed-off-by: Michael Baum Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/meson.build | 4 + drivers/net/mlx5/mlx5_rxtx.c | 201

[PATCH 00/20] mlx5: refactor devargs management

2022-01-27 Thread Michael Baum
nto a dictionary, then sends it to all the drivers that will use it during the their probing. Each driver updates within dictionary which keys it has used, then the common driver checks the updated dictionary and reports about unknown devargs. Michael Baum (20): net/mlx5: fix wrong check sibling d

[PATCH 01/20] net/mlx5: fix wrong check sibling device config mismatch

2022-01-27 Thread Michael Baum
after the relevant adjustments. Fixes: 92d5dd483450 ("net/mlx5: check sibling device configurations mismatch") Fixes: 2d241515ebaf ("net/mlx5: add devarg for extensive metadata support") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/n

[PATCH 02/20] net/mlx5: fix ineffective metadata argument adjustment

2022-01-27 Thread Michael Baum
is another adjustment later. This patch moves the adjustment after the second parsing. Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 8 1 file changed, 4 insert

[PATCH 03/20] net/mlx5: fix wrong place of ASO CT object release

2022-01-27 Thread Michael Baum
the sharing device context free function and thus solves both problems. Fixes: 0af8a2298a42 ("net/mlx5: release connection tracking management") Fixes: ee9e5fad03eb ("net/mlx5: initialize connection tracking management") Cc: sta...@dpdk.org Signed-off-by: Michael Baum A

[PATCH 04/20] net/mlx5: fix inconsistency errno update in SH creation

2022-01-27 Thread Michael Baum
his value instead of "err" value. Fixes: 5dfa003db53f ("common/mlx5: fix post doorbell barrier") Fixes: 5d55a494f4e6 ("net/mlx5: split multi-thread flow handling per OS") Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/

  1   2   3   4   5   6   7   >