Re: [PATCH v2 1/2] eal: expose lcore pthread id

2022-10-20 Thread Michael Pfeiffer
On Thu, 2022-10-20 at 08:36 -0700, Stephen Hemminger wrote: > On Thu, 20 Oct 2022 13:20:40 +0200 > David Marchand wrote: > > > On Fri, Oct 14, 2022 at 9:54 AM Markus Theil > > wrote: > > > > > > From: Michael Pfeiffer > > > > > > Al

Re: [PATCH v2 1/2] eal: expose lcore pthread id

2023-07-05 Thread Michael Pfeiffer
ed by each worker. I guess due to the possibility to set the name by pthread id, and obtain it for ctrl threads, but not for regular workers, we got the impression of a "missing piece" in the API. I understand the motivation to keep pthread internals out of the API, so i guess we ca

[PATCH] net/ice: fix missing Tx burst mode name

2022-04-04 Thread Michael Pfeiffer
The function ice_xmit_pkts_vec_avx2_offload was left out in the list of tx functions for ice_tx_burst_mode_get. Fixes: 52ccdcf2fd41 ("net/ice: add AVX2 offload Tx") Cc: wenzhuo...@intel.com Cc: sta...@dpdk.org Signed-off-by: Michael Pfeiffer Suggested-by: Michael Rossberg --- drive

[dpdk-dev] [PATCH] eal: add include for rte_byteorder on ARM

2021-06-04 Thread Michael Pfeiffer
Including rte_byteorder.h may fail for ARM builds with 'Platform must be built with RTE_FORCE_INTRINSICS' if rte_config.h is not included before. Include rte_config.h from rte_byteorder.h to solve the issue. Signed-off-by: Michael Pfeiffer --- lib/eal/arm/include/rte_byteo

[dpdk-dev] [PATCH v2 1/1] eal: arm: fix out of tree build

2021-06-06 Thread Michael Pfeiffer
or ARM") Cc: ko...@rehivetech.com Cc: sta...@dpdk.org Signed-off-by: Michael Pfeiffer --- v2: * Fixed subject line. * Add "Fixes:" and CC to stable. lib/eal/arm/include/rte_byteorder.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/eal/arm/include/rte_byte

[dpdk-dev] [PATCH v3] eal: arm: fix out of tree build

2021-06-06 Thread Michael Pfeiffer
or ARM") Cc: ko...@rehivetech.com Cc: sta...@dpdk.org Signed-off-by: Michael Pfeiffer --- v3: * Proper in-reply-to. v2: * Fixed subject line. * Add "Fixes:" and CC to stable. lib/eal/arm/include/rte_byteorder.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/eal/

[dpdk-dev] [PATCH v4] eal: arm: fix out of tree build

2021-06-08 Thread Michael Pfeiffer
rations for ARM") Cc: ko...@rehivetech.com Cc: sta...@dpdk.org Signed-off-by: Michael Pfeiffer --- v4: * Apply to fix to rte_atomic_{32,64}.h, rte_{mcs,spin,ticket}lock.h as well. * Remove unnecessary include of rte_config.h. * Adjust commit message. v3: * Proper in-reply-to. v2: * Fixed

[dpdk-dev] [PATCH v5] eal: arm: fix out of tree build

2021-06-09 Thread Michael Pfeiffer
k operations for ARM") Fixes: ca49b92079df ("ticketlock: enable generic ticketlock on all arch") Cc: sta...@dpdk.org Cc: ko...@rehivetech.com Cc: phil.y...@arm.com Cc: joyce.k...@arm.com Signed-off-by: Michael Pfeiffer --- v5: * Add Fixes: tag. v4: * Apply to fix to rte_atomic_{32,64}.

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] eal: arm: fix out of tree build

2021-06-11 Thread Michael Pfeiffer
Hi there, On Fri, 2021-06-11 at 10:59 +0100, Bruce Richardson wrote: > On Fri, Jun 11, 2021 at 11:54:25AM +0200, David Marchand wrote: > > Hello Bruce, > > > > On Wed, Jun 9, 2021 at 12:18 PM Michael Pfeiffer > > wrote: > > > > > > Including

[dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Michael Pfeiffer
The name in rte_kni_device_info is passed to the kernel, which allows interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a longer name currently trigger a kernel BUG in alloc_netdev_mqs in net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation. Signed-off-by: Michael

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Michael Pfeiffer
t; Hi Michael, > > Isn't it better to set it to IFNAMSIZ instead of 16? > > Best regards, > Igot > > On Fri, Nov 15, 2019 at 2:41 PM Michael Pfeiffer < > michael.pfeif...@tu-ilmenau.de> wrote: > > > The name in rte_kni_device_info is passed to the ker

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

2019-11-15 Thread Michael Pfeiffer
Hi Ferruh, On Fri, 2019-11-15 at 12:49 +, Ferruh Yigit wrote: > On 11/15/2019 12:43 PM, Michael Pfeiffer wrote: > > Hi Igor, > > you're right, RTE_KNI_NAMESIZE == IFNAMSIZ is the intention. > > However, > > to my understanding linux/if.h (where IFNAMSIZ is de

[dpdk-dev] [PATCH v2] kni: reduce interface name size

2019-11-15 Thread Michael Pfeiffer
The name in rte_kni_device_info is passed to the kernel, which allows interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a longer name currently trigger a kernel BUG in alloc_netdev_mqs in net/core/dev.c. Reduce RTE_KNI_NAMESIZE to prevent this situation. Signed-off-by: Michael

[dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-09 Thread Michael Pfeiffer
Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add this special case to the checksum offload emulation in net/tap. Signed-off-by: Michael Pfeiffer --- drivers/net/tap/rte_eth_tap.c | 13 ++

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-10 Thread Michael Pfeiffer
Hi, On Tue, 2020-11-10 at 15:59 +, Ferruh Yigit wrote: > On 11/9/2020 2:22 PM, Michael Pfeiffer wrote: > > Unlike TCP, UDP checksums are optional and may be zero to indicate "not > > set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add > > th

[dpdk-dev] [PATCH v2] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-13 Thread Michael Pfeiffer
Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add this special case to the checksum offload emulation in net/tap. Signed-off-by: Michael Pfeiffer --- v2: * Added comment. drive

Re: [dpdk-dev] [PATCH v2] net: calculate checksums for packets with IPv4 options

2020-10-06 Thread Michael Pfeiffer
Hi, On Tue, 2020-10-06 at 10:10 +0200, Olivier Matz wrote: > On Mon, Oct 05, 2020 at 07:39:45PM -0700, Stephen Hemminger wrote: > > On Tue, 06 Oct 2020 00:55:19 +0200 > > Thomas Monjalon wrote: > > > > > > On 9/1/20 12:47 PM, Michael Pfeiffer wrote: > &

[dpdk-dev] [PATCH] net: add rte_ipv4_hdr_len()

2020-10-12 Thread Michael Pfeiffer
Add a function to calculate the length of an IPv4 header as suggested on the mailing list [1]. Call where appropriate. [1] https://mails.dpdk.org/archives/dev/2020-October/184471.html Suggested-by: Thomas Monjalon Signed-off-by: Michael Pfeiffer --- app/test-pmd/5tswap.c | 2

[dpdk-dev] [PATCH] net: calculate checksums for packets with IPv4 options

2020-08-21 Thread Michael Pfeiffer
header length from the packet's IHL field. Signed-off-by: Michael Pfeiffer --- lib/librte_net/rte_ip.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h index fcd1eb342..6c3ff2603 100644 --- a/lib/librte_net/rte_ip.h

[dpdk-dev] [PATCH v2] net: calculate checksums for packets with IPv4 options

2020-09-01 Thread Michael Pfeiffer
header length from the packet's IHL field. Signed-off-by: Michael Pfeiffer --- v2: * Use actual header length for sanity check as well. * Introduce ip_hdr_len variable to increase readability. lib/librte_net/rte_ip.h | 21 + 1 file changed, 13 insertions(+), 8 deletions(-)