> Sent: Wednesday, July 26, 2023 11:25 AM
> > To: Olivier Matz
> > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin
> > Kumar Dabilpuram ; Rakesh Kudurumalla
> >
> > Subject: [PATCH v2 1/1] app/test: resolve mbuf_test application failure
app/test: fix extern
Unfortunatly I don't have enough time to undertake my maintainer role at
the expected level. It will probably not going to get better anytime
soon, so remove myself from maintainers.
Signed-off-by: Olivier Matz
---
MAINTAINERS | 6 --
1 file changed, 6 deletions(-)
diff --git a/MAINTA
Hello,
On Tue, Oct 17, 2023 at 04:35:50PM +, Konstantin Ananyev wrote:
>
> > >
> > > > On Tue, Oct 17, 2023 at 04:27:37PM +0200, Olivier Matz wrote:
> > > > > Unfortunatly I don't have enough time to undertake my maintainer role
> > >
Hi Wenjun,
On Mon, Oct 10, 2022 at 01:30:54AM +, Wu, Wenjun1 wrote:
> Hi Olivier,
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: Thursday, September 29, 2022 8:22 PM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming ; Wu, Wenjun1
> > ; Zh
to avoid needless emptying of cache.
> > > - */
> > > - void *objs[RTE_MEMPOOL_CACHE_MAX_SIZE * 3]; /**< Cache objects */
> > > + /**
> > > + * Cache objects
> > > + *
> > > + * Cache is allocated to this size to allow it to overflow in
> > certain
> > > + * cases to avoid needless emptying of cache.
> > > + */
> > > + void *objs[RTE_MEMPOOL_CACHE_MAX_SIZE * 2] __rte_cache_aligned;
> > > } __rte_cache_aligned;
> >
> > I think aligning objs on cacheline should be a separate patch.
>
> Good point. I'll let you do it. :-)
>
> PS: Thank you for following up on this patch series, Andrew!
Many thanks for this rework.
Acked-by: Olivier Matz
On Sun, Oct 09, 2022 at 04:44:08PM +0200, Morten Brørup wrote:
> > From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru]
> > Sent: Sunday, 9 October 2022 15.38
> > To: Olivier Matz
> > Cc: dev@dpdk.org; Morten Brørup; Bruce Richardson
> > Subject: [PATC
On Sat, Oct 08, 2022 at 10:56:06PM +0200, Thomas Monjalon wrote:
> 07/10/2022 12:44, Andrew Rybchenko:
> > From: Morten Brørup
> >
> > A flush threshold for the mempool cache was introduced in DPDK version
> > 1.3, but rte_mempool_do_generic_get() was not completely updated back
> > then, and som
nge dpdk-pmdinfo.py to actually "execute" the files provided on the
> command line with LD_TRACE_LOADED_OBJECTS=1 set. Ensure that the files
> are valid dynamically executable ELF programs to avoid obscure and
> confusing errors.
>
> Reported-by: Olivier Matz
> Signed-off-by: Robin Jarry
Tested on buildroot without ldd.
Reviewed-by: Olivier Matz
On Fri, Oct 14, 2022 at 05:57:39PM +0200, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Friday, 14 October 2022 16.01
> >
> > Hi Morten, Andrew,
> >
> > On Sun, Oct 09, 2022 at 05:08:39PM +0200, Morten Brørup w
w id.
Bugzilla ID: 1101
Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests")
Cc: sta...@dpdk.org
Signed-off-by: Olivier Matz
---
drivers/event/sw/sw_evdev_selftest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/event/sw/sw_evdev_selftest.c
b/drivers/event/sw/sw_evdev_selfte
The log should display the value, not the id.
Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests")
Cc: sta...@dpdk.org
Signed-off-by: Olivier Matz
---
drivers/event/sw/sw_evdev_selftest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
Hi Chenbo,
On Mon, Oct 17, 2022 at 06:58:59AM +, Xia, Chenbo wrote:
> Hi Olivier,
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: Thursday, September 29, 2022 8:22 PM
> > To: dev@dpdk.org
> > Cc: Maxime Coquelin ; Xia, Chenbo
> >
Add the queue id and/or the port id in some logs, so it is easier to
understand what happens.
Signed-off-by: Olivier Matz
Reviewed-by: Maxime Coquelin
---
v2
* use %u instead of %d for unsigned types
drivers/net/virtio/virtio_ethdev.c | 6 --
drivers/net/virtio/virtio_rxtx.c | 3 ++-
2
On Fri, Oct 14, 2022 at 04:02:02PM +0200, Olivier Matz wrote:
> Hi Robin,
>
> On Thu, Oct 13, 2022 at 03:41:25PM +0200, Robin Jarry wrote:
> > Some environments (buildroot) do not have the ldd utility installed by
> > default. However, ldd is often only a wrapper shell
D: 1105
Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Signed-off-by: Olivier Matz
---
app/test/test_pmd_perf.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c
index fe765c
D: 1105
Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Signed-off-by: Olivier Matz
---
v2:
* fix typo (-SOCKET_ID_ANY instead of SOCKET_ID_ANY)
app/test/test_pmd_perf.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/app
s are not returned immediatly
to the pool, they may stay in the hw tx ring during some time, which is
a driver decision.
After processing traffic on cores 8 and 24 with this testpmd, I get:
cache_count[0]=231
cache_count[8]=123
cache_count[24]=122
In my opinion, it is not realistic to
On Thu, Oct 27, 2022 at 11:22:07AM +0200, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Thursday, 27 October 2022 10.35
> >
> > Hi Morten,
> >
> > On Wed, Oct 26, 2022 at 04:44:36PM +0200, Morten Brørup wrote:
>
On Thu, Oct 27, 2022 at 02:11:29PM +0200, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Thursday, 27 October 2022 13.43
> >
> > On Thu, Oct 27, 2022 at 11:22:07AM +0200, Morten Brørup wrote:
> > > > From: Olivier
On Tue, Apr 13, 2021 at 01:52:26PM +0200, Thomas Monjalon wrote:
> 13/04/2021 22:05, Wenwu Ma:
> > Amount of allocated memory was not enough for mempool
> > which cause buffer overflow when access fields of mempool
> > private structure in the rte_pktmbuf_priv_size function.
>
> Was it causing the
On Thu, Apr 15, 2021 at 08:51:27AM -0400, Aaron Conole wrote:
> Olivier Matz writes:
>
> > On Tue, Apr 13, 2021 at 01:52:26PM +0200, Thomas Monjalon wrote:
> >> 13/04/2021 22:05, Wenwu Ma:
> >> > Amount of allocated memory was not enough for mempool
> >>
Hi Lingyu,
On Sat, Apr 17, 2021 at 09:25:31AM +, Lingyu Liu wrote:
> Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE.
>
> Signed-off-by: Lingyu Liu
> Acked-by: Hemant Agrawal
The number of available packet types for tunnels is quite low (already
mentionned in this thread [1]).
[1]
On Mon, Apr 19, 2021 at 07:07:59PM -0500, Dharmik Thakkar wrote:
> Make __MEMPOOL_STAT_ADD macro more generic and delete
> __MEMPOOL_CONTIG_BLOCKS_STAT_ADD macro
>
> Suggested-by: Olivier Matz
> Signed-off-by: Dharmik Thakkar
> Reviewed-by: Ruifeng Wang
> Reviewed-by:
Hi Dharmik,
Please see some comments below.
On Mon, Apr 19, 2021 at 07:08:00PM -0500, Dharmik Thakkar wrote:
> From: Joyce Kong
>
> If cache is enabled, objects will be retrieved/put from/to cache,
> subsequently from/to the common pool. Now the debug stats calculate
> the objects retrieved/put
Hi Dharmik,
Few comments below.
On Thu, Apr 22, 2021 at 08:29:38PM -0500, Dharmik Thakkar wrote:
> From: Joyce Kong
>
> If cache is enabled, objects will be retrieved/put from/to cache,
> subsequently from/to the common pool. Now the debug stats calculate
> the objects retrieved/put from/to cac
On Thu, Apr 22, 2021 at 08:29:36PM -0500, Dharmik Thakkar wrote:
> Subject: [dpdk-dev] [PATCH v4 0/2] lib/mempool: add debug stats
I missed that one: please use "mempool:" instead of "lib/mempool:"
prefix in the titles.
Thanks,
Olivier
>
> - Add debug counters for objects put/get to/from the co
e implementation for aarch64")
> Cc: phil.y...@arm.com
> Cc: sta...@dpdk.org
Acked-by: Olivier Matz
ed gives a better indication of what actually
> was tested.
>
> Signed-off-by: Stanislaw Kardach
> Cc: sta...@dpdk.org
Acked-by: Olivier Matz
r aarch64")
> Cc: phil.y...@arm.com
> Cc: sta...@dpdk.org
Acked-by: Olivier Matz
Clarify that the mempool private initializer and object initializer used
for packet pools require that the mempool private size is large enough.
Also add an assert (only enabled when -DRTE_ENABLE_ASSERT is passed) to
check this constraint.
Signed-off-by: Olivier Matz
---
lib/mbuf/rte_mbuf.c
The function rte_pktmbuf_init() expects that the mempool private area is
large enough and was previously initialized by rte_pktmbuf_pool_init(),
which is not the case.
This causes the function rte_pktmbuf_priv_size() to return an
unpredictable value, and this value is used as a size in a memset.
patches may be postponed to 20.08 if required.
Olivier Matz (4):
net/tap: fix Rx cksum flags on IP options packets
net/tap: fix Rx cksum flags on TCP packets
net: introduce functions to verify L4 checksums
test/cksum: new test for L3/L4 checksum API
MAINTAINERS | 1 +
app
ned-off-by: Olivier Matz
---
drivers/net/tap/rte_eth_tap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 68baa18523..e7b185a4b5 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
Cc: sta...@dpdk.org
Signed-off-by: Olivier Matz
---
drivers/net/tap/rte_eth_tap.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index e7b185a4b5..71282e8065 100644
--- a/drivers/net/tap/rte_eth_tap.c
+
culate the checksum to set in
a packet, introduce 2 new helpers for checksum verification. They return
0 if the checksum is valid in the packet.
Use this new helper in net/tap driver.
Signed-off-by: Olivier Matz
---
drivers/net/tap/rte_eth_tap.c | 7 +-
lib/net/rte_ip.h
Add a simple unit test for checksum API.
Signed-off-by: Olivier Matz
---
MAINTAINERS | 1 +
app/test/autotest_data.py | 6 +
app/test/meson.build | 2 +
app/test/test_cksum.c | 271 ++
4 files changed, 280 insertions(+)
create
Hi Morten,
Thank you for the review.
<...>
On Tue, Apr 27, 2021 at 05:07:04PM +0200, Morten Brørup wrote:
> > +static inline uint16_t
> > +rte_ipv4_udptcp_cksum(const struct rte_ipv4_hdr *ipv4_hdr, const void
> > *l4_hdr)
> > +{
> > + uint16_t cksum = __rte_ipv4_udptcp_cksum(ipv4_hdr, l4_hdr);
init shared memory fail.
>
> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Chengwen Feng
> Signed-off-by: Min Hu (Connor)
Acked-by: Olivier Matz
On Mon, May 03, 2021 at 04:21:25PM +0200, David Marchand wrote:
> On Mon, Apr 12, 2021 at 10:29 AM Stanislaw Kardach wrote:
> >
> > The lock-free stack implementation (RTE_STACK_F_LF) is supported only on a
> > subset of platforms, namely x86_64 and arm64. Platforms supporting 128b
> > atomics
>
together, it is
> better to distinguish them.
>
> Signed-off-by: Joyce Kong
> Signed-off-by: Dharmik Thakkar
> Reviewed-by: Ruifeng Wang
> Reviewed-by: Honnappa Nagarahalli
Acked-by: Olivier Matz
Hi Owen,
Thanks for fixing this test.
Some comments below.
On Wed, Jun 16, 2021 at 02:07:24PM -0400, ohily...@iol.unh.edu wrote:
> From: Owen Hilyard
>
> Fixes for a few memory leaks in the cmdline_autotest unit test.
>
> All of the leaks were related to not freeing the commandline struct
> af
Hi Owen,
One small issue remain, please see below.
On Wed, Jun 23, 2021 at 02:06:45PM -0400, ohily...@iol.unh.edu wrote:
> From: Owen Hilyard
>
> Fixes for a few memory leaks in the cmdline_autotest unit test.
>
> All of the leaks were related to not freeing the commandline struct
> after test
why RTE_PTYPE_L3_IPV4_EXT_UNKNOWN cannot happen in
tap_verify_csum() (patch 1)
* align style of rte_ipv6_udptcp_cksum_verify() to
rte_ipv4_udptcp_cksum_verify() (patch 3)
* clarify comment above rte_ipv4_udptcp_cksum_verify() and
rte_ipv6_udptcp_cksum_verify() (patch 3)
Olivier Matz (4
ned-off-by: Olivier Matz
---
drivers/net/tap/rte_eth_tap.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 5735988e7c..5513cfd2d7 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte
Cc: sta...@dpdk.org
Signed-off-by: Olivier Matz
Acked-by: Andrew Rybchenko
---
drivers/net/tap/rte_eth_tap.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 5513cfd2d7..5429f611c1 100644
-
culate the checksum to set in
a packet, introduce 2 new helpers for checksum verification. They return
0 if the checksum is valid in the packet.
Use this new helper in net/tap driver.
Signed-off-by: Olivier Matz
Acked-by: Morten Brørup
---
drivers/net/tap/rte_eth_tap.c | 7 +-
lib/ne
Add a simple unit test for checksum API.
Signed-off-by: Olivier Matz
---
MAINTAINERS | 1 +
app/test/autotest_data.py | 6 +
app/test/meson.build | 2 +
app/test/test_cksum.c | 271 ++
4 files changed, 280 insertions(+)
create
Hi Mohsin,
Hope you are fine!
Please see my comments below.
On Wed, Jun 30, 2021 at 01:04:04PM +0200, Mohsin Kazmi wrote:
> Re: [PATCH v2] net: prepare the outer ipv4 hdr for checksum
I suggest to highlight that it this is the Intel-specific tx-prepare
function in the commit title. What about:
ned-off-by: Olivier Matz
---
app/test/test_mbuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 8e0561eabb..9a248dfaea 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -2363,7 +2363,7 @@ test_pktmbuf_ext_shinfo_i
_parse_check(struct cmdline *cl, const char *buf);
> +
> /**
> * complete() must be called with *state==0 (try to complete) or
> * with *state==-1 (just display choices), then called without
> diff --git a/lib/cmdline/version.map b/lib/cmdline/version.map
> index b9bbb87510..fc7fdd6ea4 100644
> --- a/lib/cmdline/version.map
> +++ b/lib/cmdline/version.map
> @@ -81,5 +81,8 @@ EXPERIMENTAL {
> rdline_get_history_buffer_size;
> rdline_get_opaque;
>
> + # added in 22.07
> + cmdline_parse_check;
> +
> local: *;
> };
> --
> 2.34.1
>
With these changes:
Acked-by: Olivier Matz
"test: take test names from command line")
> Bugzilla ID: 1002
>
> Signed-off-by: Bruce Richardson
Acked-by: Olivier Matz
Members Attending
=
9/11
- Aaron
- Bruce
- Hemant
- Jerin
- Kevin
- Maxime
- Olivier (chair)
- Stephen
- Thomas
NOTE: The technical board meetings are on every second Wednesday at
https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK
community members are welcome to
On Fri, Jun 10, 2022 at 03:08:49PM +0100, Bruce Richardson wrote:
> On Tue, Jun 07, 2022 at 10:08:30AM +0200, Olivier Matz wrote:
> > Hi Bruce,
> >
> > Just few minor comments below.
> >
> > On Fri, May 20, 2022 at 04:12:39PM +0100, Bruce Richardson wrote:
> &
Hi,
On Thu, Jun 30, 2022 at 05:55:21PM +0100, Bruce Richardson wrote:
> On Thu, Jun 30, 2022 at 09:55:16PM +0530, Shijith Thotton wrote:
> > If all devices are configured to run in IOVA mode as VA, physical
> > address field of mbuf (buf_iova) won't be used. In such cases, buf_iova
> > space is fr
1 +
> app/test/test_cksum_perf.c | 118 +
> 3 files changed, 120 insertions(+)
> create mode 100644 app/test/test_cksum_perf.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c923712946..2a4c99e05a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@
Hi,
On Fri, Jul 08, 2022 at 02:56:08PM +0200, Mattias Rönnblom wrote:
> __rte_raw_cksum() (used by rte_raw_cksum() among others) accessed its
> data through an uint16_t pointer, which allowed the compiler to assume
> the data was 16-bit aligned. This in turn would, with certain
> architectures and
On Mon, Jul 11, 2022 at 10:42:37AM +, Mattias Rönnblom wrote:
> On 2022-07-11 11:47, Olivier Matz wrote:
> > Hi Mattias,
> >
> > Please see few comments below.
> >
> > On Fri, Jul 08, 2022 at 02:56:07PM +0200, Mattias Rönnblom wrote:
> >> Add perform
off-by: Mattias Rönnblom
Acked-by: Olivier Matz
Thank you!
ze.
>
> Performance impact seems to range from none to a very slight
> regression.
>
> Bugzilla ID: 1035
> Cc: sta...@dpdk.org
Fixes: 6006818cfb26 ("net: new checksum functions")
> ---
>
> v3:
> * Use RTE_ALIGN_FLOOR() in the pointer arithmeti
Hi Luc,
On Wed, Apr 07, 2021 at 08:53:23AM -0400, Luc Pelletier wrote:
> The creation of control threads uses a pthread barrier for
> synchronization. This patch fixes a race condition where the pthread
> barrier could get destroyed while one of the threads has not yet
> returned from the pthread_
Hi Joyce,
On Thu, Mar 18, 2021 at 07:20:22PM +0800, Joyce Kong wrote:
> If cache is enabled, objects will be retrieved/put from/to cache,
> subsequently from/to the common pool. Now the debug stats calculate
> the objects retrieved/put from/to cache and pool together, it is
> better to distinguish
Hi Luc,
On Wed, Apr 07, 2021 at 10:42:37AM -0400, Luc Pelletier wrote:
> The creation of control threads uses a pthread barrier for
> synchronization. This patch fixes a race condition where the pthread
> barrier could get destroyed while one of the threads has not yet
> returned from the pthread_
rning to applications still using it.
> Fix this by marking as deprecated with the newly introduced
> RTE_DEPRECATED.
>
> Signed-off-by: David Marchand
Acked-by: Olivier Matz
On Wed, Apr 07, 2021 at 05:15:39PM -0300, Flavio Leitner wrote:
> On Thu, Apr 01, 2021 at 11:52:40AM +0200, David Marchand wrote:
> > Tx offload flags are of the application responsibility.
> > Leave the mbuf alone and check for TSO where needed.
> >
> > Signed-off-by: David Marchand
> > ---
>
>
On Thu, Apr 01, 2021 at 11:52:40AM +0200, David Marchand wrote:
> Tx offload flags are of the application responsibility.
> Leave the mbuf alone and check for TSO where needed.
>
> Signed-off-by: David Marchand
Maybe the problem being solved should be better described in the commit
log. Is it a
> This is not done in this patch for now so TSO activation is forcibly
> refused.
>
> Fixes: 859b480d5afd ("vhost: add guest offload setting")
>
> Signed-off-by: David Marchand
> ---
Reviewed-by: Olivier Matz
LGTM, just one little comment below.
<...>
&g
On Thu, Apr 08, 2021 at 01:47:18PM +0530, Tejasree Kondoj wrote:
> Adding new mbuf packet type for UDP encapsulated
> ESP packets.
>
> Signed-off-by: Tejasree Kondoj
> ---
> doc/guides/rel_notes/release_21_05.rst | 5 +
> lib/librte_mbuf/rte_mbuf_ptype.h | 21 +
>
her_hdr`
> definition to avoid conflict. Place source MAC address in both `s_addr`
> and `S_un.S_addr` fields, so that access works either directly or
> through the macro as defined in Windows headers.
>
> Signed-off-by: Dmitry Kozlyuk
> Acked-by: Ranjit Menon
Acked-by: Olivier Matz
Hi Dmitry,
On Thu, Apr 08, 2021 at 01:22:49AM +0300, Dmitry Kozlyuk wrote:
> Users of relied on it to provide IP-related defines,
> like IPPROTO_* constants, but still had to include POSIX headers
> for inet_pton() and other standard IP-related facilities.
>
> Extend so that it is a single head
On Thu, Apr 08, 2021 at 08:21:58AM -0300, Flavio Leitner wrote:
> On Thu, Apr 08, 2021 at 09:41:59AM +0200, Olivier Matz wrote:
> > On Wed, Apr 07, 2021 at 05:15:39PM -0300, Flavio Leitner wrote:
> > > On Thu, Apr 01, 2021 at 11:52:40AM +0200, David Marchand wrote:
> > >
Hi Raslan,
On Sun, Apr 04, 2021 at 10:45:51AM +0300, Raslan Darawsheh wrote:
> Define new rte header for gtp PDU session container
> based on RFC 38415-g30
Do you have a link to this RFC?
> Signed-off-by: Raslan Darawsheh
> ---
> lib/librte_net/rte_gtp.h | 34 ++
On Thu, Apr 08, 2021 at 12:37:27PM +, Raslan Darawsheh wrote:
> Hi Olivier,
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: Thursday, April 8, 2021 3:30 PM
> > To: Raslan Darawsheh
> > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Ori Kam
ned from the pthread_barrier_wait function, which could result in
> undefined behaviour.
>
> Fixes: 3a0d465 ("eal: fix use-after-free on control thread creation")
> Cc: jianfeng@intel.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Luc Pelletier
Acked-by: Olivier Matz
n creating a control thread")
> Cc: olivier.m...@6wind.com
> Cc: sta...@dpdk.org
>
> Signed-off-by: Luc Pelletier
Thank you for these 2 fixes. Note the the title of your patches do not
contain the version (should have been v8?). I don't know how critical
it is for commiters.
Acked-by: Olivier Matz
On Thu, Apr 08, 2021 at 09:58:35AM -0300, Flavio Leitner wrote:
> On Thu, Apr 08, 2021 at 02:05:21PM +0200, Olivier Matz wrote:
> > On Thu, Apr 08, 2021 at 08:21:58AM -0300, Flavio Leitner wrote:
> > > On Thu, Apr 08, 2021 at 09:41:59AM +0200, Olivier Matz wrote:
> > > &
On Thu, Apr 08, 2021 at 10:51:34PM +0300, Dmitry Kozlyuk wrote:
> 2021-04-08 13:45 (UTC+0200), Olivier Matz:
> [...]
> > > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
> > > index c572d003cb..e7361bf520 100644
> > > --- a/drivers/net/i40
Hi Xueming,
On Sat, Apr 10, 2021 at 02:23:55PM +, Xueming Li wrote:
> Adds a new function to get value of a specific key from kvargs list.
>
> Signed-off-by: Xueming Li
> Reviewed-by: Gaetan Rivet
> ---
> lib/librte_kvargs/rte_kvargs.c | 20
> lib/librte_kvargs/rte_kva
Hi Morten,
Thank you for enhancing the mempool test. Please see some comments
below.
On Wed, Jan 19, 2022 at 12:37:32PM +0100, Morten Brørup wrote:
> "What gets measured gets done."
>
> This patch adds mempool performance tests where the number of objects to
> put and get is constant at compile
ate_persec=917582643
get_bulk=32 put_bulk=32 keep=32 constant_n=false rate_persec=871248691
get_bulk=32 put_bulk=32 keep=32 constant_n=true rate_persec=1134021836
Signed-off-by: Morten Brørup
Signed-off-by: Olivier Matz
---
Hi Morten,
Here is the updated patch.
I launched the mempool_perf on
On Mon, Jan 24, 2022 at 03:53:09PM +0100, Olivier Matz wrote:
> From: Morten Brørup
>
> "What gets measured gets done."
>
> This patch adds mempool performance tests where the number of objects to
> put and get is constant at compile time, which may significantly
ate_persec=917582643
get_bulk=32 put_bulk=32 keep=32 constant_n=false rate_persec=871248691
get_bulk=32 put_bulk=32 keep=32 constant_n=true rate_persec=1134021836
Signed-off-by: Morten Brørup
Signed-off-by: Olivier Matz
---
Hi Morten,
Here is the updated patch.
I launched the mempool_perf on
Hi Morten,
Few comments below.
On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote:
> A flush threshold for the mempool cache was introduced in DPDK version
> 1.3, but rte_mempool_do_generic_get() was not completely updated back
> then, and some inefficiencies were introduced.
>
> This
Hi Morten,
On Wed, Jan 19, 2022 at 04:03:01PM +0100, Morten Brørup wrote:
> mempool: fix put objects to mempool with cache
>
> This patch optimizes the rte_mempool_do_generic_put() caching algorithm,
> and fixes a bug in it.
I think we should avoid grouping fixes and optimizations in one
patch.
On Mon, Jan 10, 2022 at 09:40:48AM +, Bruce Richardson wrote:
> On Sat, Jan 08, 2022 at 12:00:17PM +0100, Morten Brørup wrote:
> > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > Sent: Friday, 7 January 2022 16.12
> > >
> > > On Tue, Dec 28, 2021 at 03:28:45PM +0100, Morten
On Mon, Jan 24, 2022 at 04:38:58PM +0100, Olivier Matz wrote:
> On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote:
> > --- a/lib/mempool/rte_mempool.h
> > +++ b/lib/mempool/rte_mempool.h
> > @@ -1443,6 +1443,10 @@ rte_mempool_put(struct rte_m
Hi Zhiheng,
Thank you for your patch proposal.
On Thu, Dec 23, 2021 at 10:07:41AM +, Zhiheng Chen wrote:
> In rte_mempool_ring.c, the committer uses the symbol ENOBUFS to
> describe the return value of function common_ring_sc_dequeue,
> but in rte_mempool.h, the symbol ENOENT is used to descr
Hi Morten,
On Mon, Jan 24, 2022 at 06:20:49PM +0100, Morten Brørup wrote:
> > From: Olivier Matz [mailto:olivier.m...@6wind.com]
> > Sent: Monday, 24 January 2022 16.00
> >
> > From: Morten Brørup
> >
> > "What gets measured gets done."
> >
Hi,
On Tue, Jan 11, 2022 at 05:45:49PM +0100, Thomas Monjalon wrote:
> 14/12/2021 08:56, Gaoxiang Liu:
> > Because dynamic fields are registered by the DPDK application,
> > so it is up to the application to decide whether to copy the value of
> > dynamic fields.
> > So delete dynamic fields copy
Hi Tianli,
On Wed, Nov 10, 2021 at 11:57:19PM +0800, Tianli Lai wrote:
> the primary program(such as ofp app) run first, then run the secondary
> program(such as dpdk-pdump), the primary program would receive signal
> SIGSEGV. the function stack as follow:
>
> aived signal SIGSEGV, Segmentation f
r, so we can simply remove
> strlen().
>
> Fixes: 7b295dceea07 ("test/mbuf: add unit test cases")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
Acked-by: Olivier Matz
Hi Radu,
On Fri, Sep 03, 2021 at 11:59:42AM +0100, Radu Nicolau wrote:
> [PATCH] net: add support for UDP segmentation case
What about this title instead?
net: exclude IP len from phdr cksum if offloading UDP frag
> Add support to the ipv4/ipv6 pseudo-header function when TSO is enabled
> in th
On Thu, Oct 14, 2021 at 07:12:29AM +, Xia, Chenbo wrote:
> > -Original Message-
> > From: Ivan Malov
> > Sent: Friday, September 17, 2021 2:50 AM
> > To: dev@dpdk.org
> > Cc: Maxime Coquelin ; sta...@dpdk.org; Andrew
> > Rybchenko ; Xia, Chenbo
Hi Sean,
On Thu, Oct 07, 2021 at 10:25:56AM +, Sean Morrissey wrote:
> These header includes have been flagged by the iwyu_tool
> and removed.
>
> Signed-off-by: Sean Morrissey
> ---
> lib/kvargs/rte_kvargs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/kvargs/rte_kvargs.c b
On Fri, Oct 15, 2021 at 12:33:31PM +0300, Andrew Rybchenko wrote:
> On 10/15/21 12:18 PM, Dmitry Kozlyuk wrote:
> >> -Original Message-
> >> From: Andrew Rybchenko
> >> [...]
> >>> diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c
> >>> index 51c0ba2931..2204f140b3 100644
On Fri, Oct 15, 2021 at 09:58:49AM +, Dmitry Kozlyuk wrote:
>
>
> > -Original Message-
> > From: Olivier Matz
> > Sent: 15 октября 2021 г. 12:43
> > To: Andrew Rybchenko
> > Cc: Dmitry Kozlyuk ; dev@dpdk.org; Matan Azrad
> >
> > Subj
Hi Dmitry,
On Wed, Oct 13, 2021 at 02:01:28PM +0300, Dmitry Kozlyuk wrote:
> Data path performance can benefit if the PMD knows which memory it will
> need to handle in advance, before the first mbuf is sent to the PMD.
> It is impractical, however, to consider all allocated memory for this
> purp
On Fri, Oct 15, 2021 at 01:41:40PM +0200, David Marchand wrote:
> On Fri, Oct 15, 2021 at 12:42 PM Dmitry Kozlyuk wrote:
> > > a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index
> > > 8d5f99f7e7..27d197fe86 100644
> > > --- a/lib/mempool/rte_mempool.c
> > > +++ b/lib/mempool/rte_mempool
On Fri, Oct 15, 2021 at 10:20:06AM +0100, Morrissey, Sean wrote:
>
> On 15/10/2021 10:00, Olivier Matz wrote:
> > Hi Sean,
> >
> > On Thu, Oct 07, 2021 at 10:25:56AM +, Sean Morrissey wrote:
> > > These header includes have been flagged by the iwyu_tool
>
On Fri, Oct 15, 2021 at 10:39:41AM +0200, David Marchand wrote:
> This option should be prefixed with -- for consistency with others.
>
> Fixes: a103a97e7191 ("eal: allow user to override default mempool driver")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
Reviewed-by: Olivier Matz
On Thu, Oct 14, 2021 at 02:56:22PM -0700, Stephen Hemminger wrote:
> More codespell finds.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Olivier Matz
Thanks!
1 - 100 of 3409 matches
Mail list logo
