[PATCH] doc: update Linux core isolation guide

2022-05-02 Thread Pavan Nikhilesh
Update Linux core isolation guide to include isolation from timers, rcu processing and IRQs. Signed-off-by: Pavan Nikhilesh --- doc/guides/linux_gsg/enable_func.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/guides/linux_gsg/enable_func.rst b/doc/guides

[PATCH 1/6] app/eventdev: simplify signal handling and teardown

2022-04-26 Thread Pavan Nikhilesh
Remove rte_*_dev calls from signal handler callback. Split ethernet device teardown into Rx and Tx sections, wait for workers to finish processing after disabling Rx to allow workers to complete processing currently held packets. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_main.c

[PATCH 2/6] app/eventdev: clean up worker state before exit

2022-04-26 Thread Pavan Nikhilesh
the worker exit timing and when there are very less number of flows. Add clean up function to release any scheduling contexts held by the worker by using RTE_EVENT_OP_RELEASE. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c| 31 +++-- app/test-eventdev

[PATCH 3/6] examples/eventdev: clean up worker state before exit

2022-04-26 Thread Pavan Nikhilesh
the worker exit timing and when there are very less number of flows. Add clean up function to release any scheduling contexts held by the worker by using RTE_EVENT_OP_RELEASE. Signed-off-by: Pavan Nikhilesh --- examples/eventdev_pipeline/pipeline_common.h | 22

[PATCH 4/6] examples/l3fwd: clean up worker state before exit

2022-04-26 Thread Pavan Nikhilesh
the worker exit timing and when there are very less number of flows. Add clean up function to release any scheduling contexts held by the worker by using RTE_EVENT_OP_RELEASE. Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd_em.c| 32 ++-- examples/l3fwd

[PATCH 5/6] examples/l2fwd-event: clean up worker state before exit

2022-04-26 Thread Pavan Nikhilesh
the worker exit timing and when there are very less number of flows. Add clean up function to release any scheduling contexts held by the worker by using RTE_EVENT_OP_RELEASE. Signed-off-by: Pavan Nikhilesh --- examples/l2fwd-event/l2fwd_common.c | 34 + examples/l2fwd

[PATCH 6/6] examples/ipsec-secgw: cleanup worker state before exit

2022-04-26 Thread Pavan Nikhilesh
the worker exit timing and when there are very less number of flows. Add a cleanup function to release any scheduling contexts held by the worker by using RTE_EVENT_OP_RELEASE. Signed-off-by: Pavan Nikhilesh --- examples/ipsec-secgw/ipsec_worker.c | 40 - 1 file changed

[PATCH 1/2] event/cnxk: add additional checks in OP_RELEASE

2022-04-26 Thread Pavan Nikhilesh
Add additional checks while performing RTE_EVENT_OP_RELEASE to ensure that there are no pending SWTAGs and FLUSHEs in flight. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 4 +--- drivers/event/cnxk/cn10k_worker.c | 8 ++-- drivers/event/cnxk/cn9k_eventdev.c

[PATCH 2/2] event/cnxk: move post-processing to separate function

2022-04-26 Thread Pavan Nikhilesh
Move event post-processing to a separate function. Do complete event post-processing in tear-down functions to prevent incorrect memory free. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 5 +- drivers/event/cnxk/cn10k_worker.h | 190

[PATCH] event/cnxk: add SLMTST support to Tx adapter

2022-04-27 Thread Pavan Nikhilesh
transmitting a single WQE. Signed-off-by: Pavan Nikhilesh --- Depends-on: Series-22634 drivers/common/cnxk/hw/ssow.h| 7 +++ drivers/common/cnxk/roc_dev_priv.h | 6 ++ drivers/common/cnxk/roc_io.h | 8 drivers/common/cnxk/roc_io_generic.h | 7

[PATCH v2 1/2] event/cnxk: add additional checks in OP_RELEASE

2022-04-27 Thread Pavan Nikhilesh
Add additional checks while performing RTE_EVENT_OP_RELEASE to ensure that there are no pending SWTAGs and FLUSHEs in flight. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Fix compilation with RTE_LIBRTE_MEMPOOL_DEBUG enabled. drivers/event/cnxk/cn10k_eventdev.c | 4 +--- drivers/event

[PATCH v2 2/2] event/cnxk: move post-processing to separate function

2022-04-27 Thread Pavan Nikhilesh
Move event post-processing to a separate function. Do complete event post-processing in tear-down functions to prevent incorrect memory free. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 5 +- drivers/event/cnxk/cn10k_worker.h | 189

[PATCH 1/3] eventdev: add function to quiesce an event port

2022-04-27 Thread Pavan Nikhilesh
from the lcore, this might also include any prefetched events. While releasing the event port from the lcore, this function calls the user-provided flush callback once per event. Signed-off-by: Pavan Nikhilesh --- lib/eventdev/eventdev_pmd.h | 19 +++ lib/eventdev/rte_eventdev.c

[PATCH 2/3] eventdev: update examples to use port quiesce

2022-04-27 Thread Pavan Nikhilesh
Quiesce event ports used by the workers core on exit to free up any outstanding resources. Signed-off-by: Pavan Nikhilesh Change-Id: Iea1f933d4f4926630d82a9883fbe3f1e75876097 --- Depends-on: Series-22677 app/test-eventdev/test_perf_common.c | 8 app/test-eventdev

[PATCH 3/3] event/cnxk: implement event port quiesce function

2022-04-27 Thread Pavan Nikhilesh
Implement event port quiesce function to clean up any lcore resources used. Signed-off-by: Pavan Nikhilesh Change-Id: I7dda3d54dc698645d25ebbfbabd81760940fe649 --- drivers/event/cnxk/cn10k_eventdev.c | 78 ++--- drivers/event/cnxk/cn9k_eventdev.c | 60

[PATCH 2/3 v2] eventdev: update examples to use port quiesce

2022-04-27 Thread Pavan Nikhilesh
Quiesce event ports used by the workers core on exit to free up any outstanding resources. Signed-off-by: Pavan Nikhilesh --- Depends-on: Series-22677 app/test-eventdev/test_perf_common.c | 8 app/test-eventdev/test_pipeline_common.c | 12 examples

[PATCH 1/3 v2] eventdev: add function to quiesce an event port

2022-04-27 Thread Pavan Nikhilesh
from the lcore, this might also include any prefetched events. While releasing the event port from the lcore, this function calls the user-provided flush callback once per event. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Remove internal Change-Id tag from commit messages. lib/eventdev

[PATCH 3/3 v2] event/cnxk: implement event port quiesce function

2022-04-27 Thread Pavan Nikhilesh
Implement event port quiesce function to clean up any lcore resources used. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 78 ++--- drivers/event/cnxk/cn9k_eventdev.c | 60 +- 2 files changed, 130 insertions(+), 8 deletions

[PATCH v6 1/2] hash: split x86 and SW hash CRC intrinsics

2022-04-27 Thread Pavan Nikhilesh
Split x86 and SW hash crc intrinsics into a separate files. Signed-off-by: Pavan Nikhilesh --- v6 Changes: - Simplify rte_hash_crc_set_alg function. (Ruifeng) v5 Changes: - Move CRC functions to implementation specific files to remove ifdef clutter. (Ruifeng) lib/hash/hash_crc_sw.h

[PATCH v6 2/2] hash: unify crc32 selection for x86 and Arm

2022-04-27 Thread Pavan Nikhilesh
`rte_hash_crc.h` it will fail to compile. Signed-off-by: Pavan Nikhilesh --- .../{rte_crc_arm64.h => hash_crc_arm64.h} | 69 ++--- lib/hash/hash_crc_x86.h | 89 +++ lib/hash/meson.build | 1 - lib/hash/rte_hash_cr

[PATCH v7 1/2] hash: split x86 and SW hash CRC intrinsics

2022-04-27 Thread Pavan Nikhilesh
Split x86 and SW hash crc intrinsics into a separate files. Signed-off-by: Pavan Nikhilesh --- v7 Changes: - Fix build with ppc and other arch. v6 Changes: - Simplify rte_hash_crc_set_alg function. (Ruifeng) v5 Changes: - Move CRC functions to implementation specific files to remove

[PATCH v7 2/2] hash: unify crc32 selection for x86 and Arm

2022-04-27 Thread Pavan Nikhilesh
`rte_hash_crc.h` it will fail to compile. Signed-off-by: Pavan Nikhilesh --- .../{rte_crc_arm64.h => hash_crc_arm64.h} | 69 ++-- lib/hash/hash_crc_generic.h | 72 + lib/hash/hash_crc_x86.h | 89 +++ lib/hash/meson.bu

[PATCH v8 1/2] hash: split x86 and SW hash CRC intrinsics

2022-04-29 Thread Pavan Nikhilesh
Split x86 and SW hash crc intrinsics into a separate files. Signed-off-by: Pavan Nikhilesh Reviewed-by: Ruifeng Wang --- v8 Changes: - Install arch specific headers as indirect headers. - Retain `rte` prefix for arch specific headers. v7 Changes: - Fix build with ppc and other arch. v6

[PATCH v8 2/2] hash: unify crc32 selection for x86 and Arm

2022-04-29 Thread Pavan Nikhilesh
`rte_hash_crc.h` it will fail to compile. Signed-off-by: Pavan Nikhilesh Reviewed-by: Ruifeng Wang --- lib/hash/meson.build | 1 + lib/hash/rte_crc_arm64.h | 69 +++--- lib/hash/rte_crc_generic.h | 72 ++ lib/hash/rte_crc_x86.h | 89 +++ lib

[dpdk-dev] [PATCH] ethdev: fix ethdev start return value

2017-06-07 Thread Pavan Nikhilesh
From: Pavan Nikhilesh Bhagavatula If ethdev has already started it should return -EBUSY instead of 0 when rte_eth_dev_start is called. Fixes: af75078fece3 ("first public release") Signed-off-by: Pavan Nikhilesh --- lib/librte_ether/rte_ethdev.c | 2 +- 1 file changed, 1 inser

[dpdk-dev] [PATCH] eventdev: fix eventdev start return value

2017-06-07 Thread Pavan Nikhilesh
From: Pavan Nikhilesh Bhagavatula If eventdev has already started it should return -EBUSY instead of 0 when rte_event_dev_start is called. Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs") Signed-off-by: Pavan Nikhilesh --- lib/librte_eventdev/rte_eventdev.c |

[dpdk-dev] [PATCH] cryptodev: fix cryptodev start return value

2017-06-07 Thread Pavan Nikhilesh
From: Pavan Nikhilesh Bhagavatula If cryptodev has already started it should return -EBUSY instead of 0 when rte_cryptodev_start is called. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Signed-off-by: Pavan Nikhilesh --- lib/librte

Re: [dpdk-dev] [PATCH v2 1/5] bus/fslmc: fix physical addressing check

2018-10-12 Thread Pavan Nikhilesh
Hi Shreyansh, On Tue, Oct 09, 2018 at 04:55:44PM +0530, Shreyansh Jain wrote: > In case RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is enabled, only supported > class is RTE_IOVA_PA. > > Fixes: f7768afac101 ("bus/fslmc: support dynamic IOVA") > Cc: hemant.agra...@nxp.com > > Signed-off-by: Shreyansh Jain > --

Re: [dpdk-dev] [PATCH v2 1/5] bus/fslmc: fix physical addressing check

2018-10-12 Thread Pavan Nikhilesh
On Fri, Oct 12, 2018 at 04:14:36PM +0530, Shreyansh Jain wrote: > On Friday 12 October 2018 02:31 PM, Pavan Nikhilesh wrote: > > Hi Shreyansh, > > > > On Tue, Oct 09, 2018 at 04:55:44PM +0530, Shreyansh Jain wrote: > > > In case RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is enabl

Re: [dpdk-dev] [PATCH v3 1/5] bus/fslmc: fix physical addressing check

2018-10-13 Thread Pavan Nikhilesh
On Sat, Oct 13, 2018 at 05:51:26PM +0530, Shreyansh Jain wrote: > In case RTE_LIBRTE_DPAA2_USE_PHYS_IOVA is enabled, only supported > class is RTE_IOVA_PA. > > Fixes: f7768afac101 ("bus/fslmc: support dynamic IOVA") > Cc: hemant.agra...@nxp.com > > Signed-off-by: Shreyansh Jain > --- > drivers/bu

[dpdk-dev] [PATCH] eventdev: update get id from name to include PCI devices

2018-06-14 Thread Pavan Nikhilesh
Currently, rte_event_dev_get_dev_id works only for virtual devices(vdev) update the function to include devices probed through pci. Signed-off-by: Pavan Nikhilesh --- lib/librte_eventdev/rte_eventdev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args

2018-06-14 Thread Pavan Nikhilesh
-args to pass device args without the need to whitelist the devices. --pci-args 000X:00:0X.0,self_test=1 Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Document the option usage in eal_common_usage. - Update commit log to be more informative. lib/librte_eal/common

[dpdk-dev] [PATCH] event/octeontx: fix flush callback

2018-06-14 Thread Pavan Nikhilesh
When event queues are being flushed the getwork operation used to extract events should be a grouped getwork operation to the specific event queue. Fixes: 8384f0e039ea ("event/octeontx: support device stop flush callback") Signed-off-by: Pavan Nikhilesh --- drivers/even

Re: [dpdk-dev] [PATCH] examples: fix RSS hash function configuration

2018-06-21 Thread Pavan Nikhilesh
Hi Ferruh, On Wed, Jun 20, 2018 at 04:01:22PM +0100, Ferruh Yigit wrote: > ethdev layer introduced checks for application requested RSS hash > functions and returns error for ones unsupported by hardware > > This check breaks some sample applications which blindly configures > RSS hash functions w

Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args

2018-06-27 Thread Pavan Nikhilesh
>> > > >> Add a new eal command line option --pci-args to pass device args without > > >> the > > >> need to whitelist the devices. > > >>--pci-args 000X:00:0X.0,self_test=1 > > >> > > >> Signed-off-by: Pavan

[dpdk-dev] [PATCH] mempool/octeontx: fix pool to aura mapping

2018-06-27 Thread Pavan Nikhilesh
HW needs each pool to be mapped to an aura set of 16 auras. Previously, pool to aura mapping was considered to be 1:1. Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 2 +

[dpdk-dev] [PATCH] net/thunderx: add support for Rx VLAN offload

2018-07-01 Thread Pavan Nikhilesh
From: "Kudurumalla, Rakesh" This feature is used to offload stripping of vlan header from recevied packets and update vlan_tci field in mbuf when DEV_RX_OFFLOAD_VLAN_STRIP & ETH_VLAN_STRIP_MASK flag is set. Signed-off-by: Rakesh Kudurumalla Signed-off-by: Pavan Nikhilesh --

[dpdk-dev] [PATCH v2] mempool/octeontx: fix pool to aura mapping

2018-07-01 Thread Pavan Nikhilesh
HW needs each pool to be mapped to an aura set of 16 auras. Previously, pool to aura mapping was considered to be 1:1. Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh Acked-by: Santosh Shukla --- v2 Changes: - use macr

[dpdk-dev] [PATCH v3] mempool/octeontx: fix pool to aura mapping

2018-07-02 Thread Pavan Nikhilesh
HW needs each pool to be mapped to an aura set of 16 auras. Previously, pool to aura mapping was considered to be 1:1. Fixes: 02fd6c744350 ("mempool/octeontx: support allocation") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh Acked-by: Santosh Shukla Acked-by: Jerin Jacob --

[dpdk-dev] [PATCH] eal: roundup tsc frequency when estimating it

2018-11-29 Thread Pavan Nikhilesh
When estimating tsc frequency using sleep/gettime round it up to the nearest multiple of 10Mhz for more accuracy. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/eal_common_timer.c | 4 ++-- lib/librte_eal/common/include/rte_common.h | 10 ++ lib/librte_eal/linuxapp/eal

Re: [dpdk-dev] [PATCH] eal: roundup tsc frequency when estimating it

2018-11-29 Thread Pavan Nikhilesh
Hi Stephen, On Thu, Nov 29, 2018 at 01:21:52PM -0800, Stephen Hemminger wrote: > On Thu, 29 Nov 2018 08:32:03 + > Pavan Nikhilesh wrote: > > > When estimating tsc frequency using sleep/gettime round it up to the > > nearest multiple of 10Mhz for more accuracy. > &g

Re: [dpdk-dev] [PATCH 0/3] new software event timer adapter

2018-11-29 Thread Pavan Nikhilesh
Hi Eric, I think we may need to address the librte_timer and event_timer patches in separate series as we are modifying common code for the sake of sw_event_timer PMD and the series title implies that only the PMD has been modified. Also, I think we need to profile and report the performance regr

Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args

2018-07-10 Thread Pavan Nikhilesh
Hi Shahaf, On Tue, Jun 26, 2018 at 12:48:49PM +, Shahaf Shuler wrote: > Hi Pavan, > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh: > > Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev > > args > > > > Currently, the only way of s

Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args

2018-07-10 Thread Pavan Nikhilesh
Hi Gaëtan,Ferruh, On Wed, Jun 27, 2018 at 11:57:36AM +0200, Gaëtan Rivet wrote: > On Wed, Jun 27, 2018 at 02:25:30PM +0530, Pavan Nikhilesh wrote: > > Hi Gaëtan, > > > > On Wed, Jun 27, 2018 at 10:39:59AM +0200, Gaëtan Rivet wrote: > > > Hi Ferruh, Pavan, &

Re: [dpdk-dev] [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-07-10 Thread Pavan Nikhilesh
Hi Nikhil, On Fri, Jul 06, 2018 at 12:12:07PM +0530, Nikhil Rao wrote: > The caps API allows the application to query if the transmit > stage is implemented in the eventdev PMD or uses the common > rte_service function. The PMD callbacks support the > eventdev PMD implementation of the adapter. >

[dpdk-dev] [PATCH] app/eventdev: fix order test service init

2018-07-13 Thread Pavan Nikhilesh
Previous modification to evt_service_setup() broke order_queue/atq tests. Fixes: b0333c55dfa5 ("app/eventdev: add service core configuration") Cc: sta...@dpdk.org Reported-by: Gage Eads Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_order_atq.c | 12

[dpdk-dev] [PATCH v2 1/2] net/thunderx: enable Rx checksum offload

2018-07-16 Thread Pavan Nikhilesh
Add L3/L4 Rx checksum offload and update capabilities. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Add Rx checksum offload support for l3fwd. drivers/net/thunderx/nicvf_ethdev.c | 33 - drivers/net/thunderx/nicvf_ethdev.h | 1 + drivers/net/thunderx/nicvf_rxtx.c | 73

[dpdk-dev] [PATCH v2 2/2] net/thunderx: add support for Rx VLAN offload

2018-07-16 Thread Pavan Nikhilesh
From: "Kudurumalla, Rakesh" This feature is used to offload stripping of vlan header from recevied packets and update vlan_tci field in mbuf when DEV_RX_OFFLOAD_VLAN_STRIP & ETH_VLAN_STRIP_MASK flag is set. Signed-off-by: Rakesh Kudurumalla Signed-off-by: Pavan Nikhilesh --

Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args

2018-07-16 Thread Pavan Nikhilesh
On Mon, Jul 16, 2018 at 12:25:29AM +0200, Thomas Monjalon wrote: > External Email > > 10/07/2018 12:19, Pavan Nikhilesh: > > Hi Gaëtan,Ferruh, > > > > On Wed, Jun 27, 2018 at 11:57:36AM +0200, Gaëtan Rivet wrote: > > > On Wed, Jun 27, 2018 at 02:25:30PM +053

[dpdk-dev] [pbhagavat...@caviumnetworks.com: Re: [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter]

2018-07-16 Thread Pavan Nikhilesh
Hi Nikhil, On Mon, Jul 16, 2018 at 11:25:45AM +0530, Rao, Nikhil wrote: > On 7/10/2018 4:26 PM, Pavan Nikhilesh wrote: > > +int __rte_experimental > > +rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint32_t *caps) > > +{ > > The caps get API needs to be similar to

[dpdk-dev] [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-07-16 Thread Pavan Nikhilesh
On Mon, Jul 16, 2018 at 02:17:40PM +, Rao, Nikhil wrote: > > > -Original Message- > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Monday, July 16, 2018 5:03 PM > > To: Rao, Nikhil ; > > jkollanukka...@caviumnetworks.com; o

[dpdk-dev] [PATCH] app/eventdev: use proper teardown sequence

2018-07-17 Thread Pavan Nikhilesh
Use proper teardown sequence when SIGINT is caught to prevent eventdev from going into undefined state. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_main.c | 6 +- app/test-eventdev/test_pipeline_common.c | 1 - 2 files changed, 5 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH] event/octeontx: prefetch mbuf instead of wqe

2018-07-17 Thread Pavan Nikhilesh
Prefetch mbuf pointer instead of wqe when SSO receives pkt from PKI. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/ssovf_worker.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/octeontx/ssovf_worker.h b/drivers/event/octeontx/ssovf_worker.h index

[dpdk-dev] [PATCH v3 1/2] net/thunderx: enable Rx checksum offload

2018-07-18 Thread Pavan Nikhilesh
Add L3/L4 Rx checksum offload and update capabilities. Signed-off-by: Pavan Nikhilesh --- v3 Changes: - rebase on top of next-net v2 Changes: - Add Rx checksum offload support for l3fwd. drivers/net/thunderx/nicvf_ethdev.c | 33 - drivers/net/thunderx/nicvf_ethdev.h | 1

[dpdk-dev] [PATCH v3 2/2] net/thunderx: add support for Rx VLAN offload

2018-07-18 Thread Pavan Nikhilesh
From: "Kudurumalla, Rakesh" This feature is used to offload stripping of vlan header from recevied packets and update vlan_tci field in mbuf when DEV_RX_OFFLOAD_VLAN_STRIP & ETH_VLAN_STRIP_MASK flag is set. Signed-off-by: Rakesh Kudurumalla Signed-off-by: Pavan Nikhilesh --

[dpdk-dev] [PATCH v2] app/eventdev: use proper teardown sequence

2018-07-19 Thread Pavan Nikhilesh
Use proper teardown sequence when SIGINT is caught to prevent eventdev from going into undefined state. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Only stopping the ethdev(producer) is sufficient.(Jerin) app/test-eventdev/evt_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter

2018-07-19 Thread Pavan Nikhilesh
Modifying port state is not necessary when starting/stopping Rx adapter as it is same as starting/stopping ethdev. Fixes: 45a914c5bd71 ("event/octeontx: support event Rx adapter") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/ssovf_evdev.c | 14 ++-

[dpdk-dev] [PATCH] net/octeontx: fix stop clearing fastpath functions

2018-07-24 Thread Pavan Nikhilesh
;) Signed-off-by: Pavan Nikhilesh --- drivers/net/octeontx/octeontx_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index 1eb453b21..8fe868678 100644 --- a/drivers/ne

[dpdk-dev] [PATCH v3] app/eventdev: use proper teardown sequence

2018-07-24 Thread Pavan Nikhilesh
Use proper teardown sequence when SIGINT is caught to prevent eventdev from going into undefined state. Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Segregate ethdev_stop and close to prevent possible SEGFAULT. - handle early shutdown. v2 Changes: - Only stopping the ethdev(producer

[dpdk-dev] [PATCH v4] app/eventdev: use proper teardown sequence

2018-07-24 Thread Pavan Nikhilesh
Use proper teardown sequence when SIGINT is caught to prevent eventdev from going into undefined state. Signed-off-by: Pavan Nikhilesh --- v4 Changes: - Check opts before closing ethdev. v3 Changes: - Segregate ethdev_stop and close to prevent possible SEGFAULT. - handle early shutdown

Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter

2018-08-17 Thread Pavan Nikhilesh
Hi Nikhil, Few comments inline. Nit: Please use --in-reply-to while sending next versions. (https://core.dpdk.org/contribute/) Thanks, Pavan On Fri, Aug 17, 2018 at 09:50:52AM +0530, Nikhil Rao wrote: > > This patch adds tests for the eth Tx adapter APIs. It also > tests the data path for

Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter

2018-08-22 Thread Pavan Nikhilesh
On Wed, Aug 22, 2018 at 09:43:02PM +0530, Rao, Nikhil wrote: > > > + ev_qid = qcnt; > > > + qconf.nb_atomic_flows = dev_info.max_event_queue_flows; > > > + qconf.nb_atomic_order_sequences = 32; > > > + qconf.schedule_type = RTE_SCHED_TYPE_ATOMIC; > > > + qconf.priority

[dpdk-dev] [PATCH] event/octeontx: add Tx adapter support

2018-08-31 Thread Pavan Nikhilesh
Add Tx adapter support and move few routines around to avoid code duplication. Signed-off-by: Pavan Nikhilesh --- This patch depends on the Tx adapter series http://patches.dpdk.org/project/dpdk/list/?series=1121 drivers/event/octeontx/ssovf_evdev.c | 80 +++ drivers

[dpdk-dev] [PATCH 2/2] app/test-eventdev: add Tx adapter support

2018-08-31 Thread Pavan Nikhilesh
Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c| 216 +++- app/test-eventdev/test_pipeline_common.c | 193 ++ app/test-eventdev

[dpdk-dev] [PATCH 1/2] app/test-eventdev: fix minor typos

2018-08-31 Thread Pavan Nikhilesh
Fix minor typos. Fixes: 314bcf58ca8f("app/eventdev: add pipeline queue worker functions") Signed-off-by: Pavan Nikhilesh --- This patchset depends on the Tx adapter series http://patches.dpdk.org/project/dpdk/list/?series=1121 app/test-eventdev/test_pipeline_atq

Re: [dpdk-dev] [PATCH v5 1/4] app/eventdev: add event timer adapter as a producer

2018-04-17 Thread Pavan Nikhilesh
> It seems your patch introduce build regression on RHEL 7.5: > $ gcc --version > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) > > $ make -j32 install T=x86_64-native-linuxapp-gcc DESTDIR=legacy_destdir > > == Build app/test-eventdev > CC test_perf_common.o > /tmp/dpdk_build/app/test-eventdev/tes

[dpdk-dev] [PATCH] net/axgbe: fix incorrect cache alignment macro

2018-04-17 Thread Pavan Nikhilesh
Due to missing cacheline_aligned definition compiler treats it as a global variable replace it with proper cache alignment macro. Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup") Signed-off-by: Pavan Nikhilesh --- drivers/net/axgbe/axgbe_rxtx.h | 2 +- 1 file changed, 1 inser

[dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-18 Thread Pavan Nikhilesh
Add macro to mark a variable to be mostly read only and place it in a separate section. Signed-off-by: Pavan Nikhilesh --- Group together mostly read only data to avoid cacheline bouncing, also useful for auditing purposes. lib/librte_eal/common/include/rte_common.h | 5 + 1 file

[dpdk-dev] [PATCH 2/2] drivers: mark logtype variables as read mostly

2018-04-18 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/bus/dpaa/dpaa_bus.c | 8 drivers/bus/fslmc/fslmc_bus.c | 2 +- drivers/bus/vdev/vdev.c | 2 +- drivers/common/octeontx/octeontx_mbox.c | 2 +- drivers/crypto/dpaa2_sec

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-18 Thread Pavan Nikhilesh
On Wed, Apr 18, 2018 at 06:43:11PM +0100, Ferruh Yigit wrote: > On 4/18/2018 4:30 PM, Pavan Nikhilesh wrote: > > Add macro to mark a variable to be mostly read only and place it in a > > separate section. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > &g

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-19 Thread Pavan Nikhilesh
On Wed, Apr 18, 2018 at 07:03:06PM +0100, Ferruh Yigit wrote: > On 4/18/2018 6:55 PM, Pavan Nikhilesh wrote: > > On Wed, Apr 18, 2018 at 06:43:11PM +0100, Ferruh Yigit wrote: > >> On 4/18/2018 4:30 PM, Pavan Nikhilesh wrote: > >>> Add macro to mark a variable to be mo

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-19 Thread Pavan Nikhilesh
On Thu, Apr 19, 2018 at 01:09:58PM +0100, Bruce Richardson wrote: > On Thu, Apr 19, 2018 at 02:50:52PM +0530, Pavan Nikhilesh wrote: > > On Wed, Apr 18, 2018 at 07:03:06PM +0100, Ferruh Yigit wrote: > > > On 4/18/2018 6:55 PM, Pavan Nikhilesh wrote: > > > > On Wed, Ap

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-19 Thread Pavan Nikhilesh
On Thu, Apr 19, 2018 at 04:37:23PM +0100, Bruce Richardson wrote: > On Thu, Apr 19, 2018 at 08:48:33PM +0530, Pavan Nikhilesh wrote: > > On Thu, Apr 19, 2018 at 01:09:58PM +0100, Bruce Richardson wrote: > > > On Thu, Apr 19, 2018 at 02:50:52PM +0530, Pavan Nikhilesh wrote: >

[dpdk-dev] [PATCH] drivers: cleanup unnecessary global variables

2018-04-19 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 - drivers/bus/dpaa/base/qbman/bman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman/qman.c| 2 +- drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ++-- drivers/bus/dpaa/base/qbman

[dpdk-dev] [PATCH] doc: update release notes for OcteonTx TIM driver

2018-04-20 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/release_18_05.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 290fa0940..70ef5d4e1 100644 --- a/doc/guides/rel_notes/release_18_05.rst

[dpdk-dev] [PATCH] doc: fix minor typos in OcteonTx platform and eventdev docs

2018-04-20 Thread Pavan Nikhilesh
Fixes: 26cb0a72412f ("doc: add octeontx platform guide") Fixes: 48191dde6acf ("doc: add octeontx mempool guide") Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx.rst | 2 +- doc/guides/platform/octeontx.rst | 4 ++-- 2 files changed, 3 insertions(+), 3 dele

Re: [dpdk-dev] [PATCH] doc: fix minor typos in OcteonTx platform and eventdev docs

2018-04-20 Thread Pavan Nikhilesh
Hi Marko, Will send out v2 with the appropriate changes. Thanks, Pavan On Fri, Apr 20, 2018 at 09:24:34AM +, Kovacevic, Marko wrote: > And there is a space you need to just get rid of at the bottom > > :doc: `../linux_gsg/index.rst` > > :doc:`../linux_gsg/index` > > Marko K

[dpdk-dev] [PATCH v2] doc: fix minor typos in OcteonTx platform and eventdev docs

2018-04-20 Thread Pavan Nikhilesh
Fixes: 26cb0a72412f ("doc: add octeontx platform guide") Fixes: 48191dde6acf ("doc: add octeontx mempool guide") Signed-off-by: Pavan Nikhilesh Acked-by: Marko Kovacevic --- v2 Changes: - Remove .rst at the end of doc links. - Remove space prior to linux gsg link.

Re: [dpdk-dev] event/octeontx: add event timer adapter driver

2018-04-23 Thread Pavan Nikhilesh
Hi Ali, Looks like a compiler bug rather than code issue, I have verified this on x86 with gcc 4.8.5 and don't see an issue. Looking around I found that compiling with -O1 on aarch64 gcc 4.8.5 seems to fix the compiler bug. Thanks, Pavan. On Sun, Apr 22, 2018 at 04:03:36PM +, Ali Alnubani w

[dpdk-dev] [PATCH] event/octeontx: fix incorrect SPDX placement

2018-04-23 Thread Pavan Nikhilesh
Fixes: fd5baf09cdf9 ("event/octeontx: probe timvf PCIe devices") Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 3 +-- drivers/event/octeontx/timvf_evdev.h | 3 +-- drivers/event/octeontx/timvf_worker.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletion

[dpdk-dev] [PATCH] event/octeontx: fix snprintf mempool name overflow

2018-04-23 Thread Pavan Nikhilesh
Bugzilla-ID: 28 Fixes: f874c1eb1519 ("event/octeontx: create and free timer adapter") Reported-by: Harry van Haaren Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/event/octeontx/tim

Re: [dpdk-dev] [PATCH] drivers: cleanup unnecessary global variables

2018-04-25 Thread Pavan Nikhilesh
On Mon, Apr 23, 2018 at 11:00:09AM +0200, Olivier Matz wrote: > On Fri, Apr 20, 2018 at 12:21:59AM +0530, Pavan Nikhilesh wrote: > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 - > > drivers/bus/dpaa/base/

[dpdk-dev] [PATCH] net/octeontx: fix missing offload flags

2018-05-03 Thread Pavan Nikhilesh
Fix missing DEV_RX_OFFLOAD_CHECKSUM flag in RX offloads. Remove depricated txq_flags field. Fixes: a92870896b4a ("net/octeontx: use the new offload APIs") Signed-off-by: Pavan Nikhilesh --- drivers/net/octeontx/octeontx_ethdev.c | 5 + drivers/net/octeontx/octeontx_ethdev.h

[dpdk-dev] [PATCH] net/thunderx: remove depricated txq flags

2018-05-03 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/net/thunderx/nicvf_ethdev.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c index b673b4716..2a8bdf38e 100644 --- a/drivers/net/thunderx/nicvf_ethdev.c +++ b/drivers/net

[dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers

2018-05-07 Thread Pavan Nikhilesh
Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error" for aarch64. Signed-off-by: Pavan Nikhilesh --- mk/toolchain/gcc/rte.toolchain-compat.mk | 8 1 file changed, 8 insertions(+) diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/too

Re: [dpdk-dev] [PATCH 2/2] app/test-eventdev: add Tx adapter support

2018-09-04 Thread Pavan Nikhilesh
On Tue, Sep 04, 2018 at 11:07:15AM +0530, Rao, Nikhil wrote: > Hi Pavan, > > Few comments below. > > On 8/31/2018 4:10 PM, Pavan Nikhilesh wrote: > > Convert existing Tx service based pipeline to Tx adapter based APIs and > > simplify worker functions. > > &

[dpdk-dev] [PATCH v2 1/4] app/test-eventdev: fix minor typos

2018-09-04 Thread Pavan Nikhilesh
Fix minor typos. Fixes: 314bcf58ca8f ("app/eventdev: add pipeline queue worker functions") Signed-off-by: Pavan Nikhilesh --- v2 Changes: - remove stray newlines in logs. - update pipeline description (Nikhil). - add Tx adapter error condition when some ethdev, eventdev pair hav

[dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support

2018-09-04 Thread Pavan Nikhilesh
Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c| 269 --- app/test-eventdev/test_pipeline_common.c | 206 + app/test-eventdev

[dpdk-dev] [PATCH v2 2/4] app/test-eventdev: remove redundant newlines

2018-09-04 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index a54068df3..832ab8b6e 100644 --- a/app

[dpdk-dev] [PATCH v2 4/4] doc: update eventdev application guide

2018-09-04 Thread Pavan Nikhilesh
Update eventdev application guide to reflect Tx adapter related changes. Signed-off-by: Pavan Nikhilesh --- .../eventdev_pipeline_atq_test_generic.svg| 848 +++--- ...ntdev_pipeline_atq_test_internal_port.svg} | 26 +- .../eventdev_pipeline_queue_test_generic.svg | 570

Re: [dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support

2018-09-05 Thread Pavan Nikhilesh
On Wed, Sep 05, 2018 at 12:24:18PM +0530, Rao, Nikhil wrote: > On 9/4/2018 7:42 PM, Pavan Nikhilesh wrote: > > Convert existing Tx service based pipeline to Tx adapter based APIs and > > simplify worker functions. > > > > Signed-off-by: Pavan Nikhilesh >

[dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support

2018-09-05 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- This patch depends on the following series: http://patches.dpdk.org/project/dpdk/list/?series=1121 examples/eventdev_pipeline/main.c | 62 ++-- examples/eventdev_pipeline/pipeline_common.h | 31 +- .../pipeline_worker_generic.c

[dpdk-dev] [PATCH] test/eventdev: fix incorrect unit test

2018-09-05 Thread Pavan Nikhilesh
Enqueue, dequeue depths are only valid for event devs that have burst mode capability. Check event dev capability before testing depth boundary. Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") Signed-off-by: Pavan Nikhilesh --- test/test/test_eventdev.c | 21 ---

Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support

2018-09-19 Thread Pavan Nikhilesh
On Wed, Sep 19, 2018 at 08:24:01AM +0530, Rao, Nikhil wrote: > On 9/5/2018 7:15 PM, Pavan Nikhilesh wrote: > > Signed-off-by: Pavan Nikhilesh > > --- > > This patch depends on the following series: > > http://patches.dpdk.org/project/dpdk/list/?series=1121 > >

[dpdk-dev] [PATCH v3 1/4] app/test-eventdev: fix minor typos

2018-09-19 Thread Pavan Nikhilesh
Fix minor typos. Fixes: 314bcf58ca8f ("app/eventdev: add pipeline queue worker functions") Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Force all the ports to use the non-internal cap mode when we detect that one of the port doesn't have internal port capability. ap

[dpdk-dev] [PATCH v3 4/4] doc: update eventdev application guide

2018-09-19 Thread Pavan Nikhilesh
Update eventdev application guide to reflect Tx adapter related changes. Signed-off-by: Pavan Nikhilesh --- cc: .../eventdev_pipeline_atq_test_generic.svg| 848 +++--- ...ntdev_pipeline_atq_test_internal_port.svg} | 26 +- .../eventdev_pipeline_queue_test_generic.svg | 570

[dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support

2018-09-19 Thread Pavan Nikhilesh
Convert existing Tx service based pipeline to Tx adapter based APIs and simplify worker functions. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_atq.c| 269 --- app/test-eventdev/test_pipeline_common.c | 202 + app/test-eventdev

[dpdk-dev] [PATCH v3 2/4] app/test-eventdev: remove redundant newlines

2018-09-19 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_pipeline_common.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index 12a58fbbf..cdf9010b4 100644 --- a/app

[dpdk-dev] [PATCH v4 2/4] app/test-eventdev: remove redundant newlines

2018-09-24 Thread Pavan Nikhilesh
Remove unnecessary newline at the end of logs. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/test_pipeline_common.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test

[dpdk-dev] [PATCH v4 1/4] app/test-eventdev: fix minor typos

2018-09-24 Thread Pavan Nikhilesh
Fix minor typos. Fixes: 314bcf58ca8f ("app/eventdev: add pipeline queue worker functions") Cc: sta...@dpdk.org Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v4 Changes: - Address review comments (Jerin). v3 Changes: - Force all the ports to use the non-internal cap mo

  1   2   3   4   5   6   7   8   9   10   >