Re: [dpdk-dev] [PATCH 00/11] example/l3fwd: introduce event device support

2019-09-27 Thread Pavan Nikhilesh Bhagavatula
http://patches.dpdk.org/project/dpdk/list/?series=6498 Pavan. >-Original Message- >From: Ananyev, Konstantin >Sent: Thursday, September 26, 2019 3:41 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; akhil.go...@nxp.com >Cc: dev@dpdk.org >Subject: RE: [dpdk-

Re: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop

2019-09-27 Thread Pavan Nikhilesh Bhagavatula
>> >> From: Pavan Nikhilesh >> >> Add event dev main loop based on enabled l2fwd options and >eventdev >> capabilities. >> >> Signed-off-by: Pavan Nikhilesh >> --- > > > >> +if (flags & L2FWD_EVENT_TX_DIRECT) { >> +rte_event_eth_tx_adapter_txq_set(mbuf, 0); >> +

Re: [dpdk-dev] [PATCH v4 05/10] examples/l2fwd-event: add eventdev queue and port setup

2019-09-27 Thread Pavan Nikhilesh Bhagavatula
>> Subject: [dpdk-dev] [PATCH v4 05/10] examples/l2fwd-event: add >eventdev >> queue and port setup >> >> From: Pavan Nikhilesh >> >> Add event device queue and port setup based on event eth Tx >adapter >> capabilities. >> >> Signed-off-by: Sunil Kumar Kori >> Signed-off-by: Pavan Nikhilesh >> -

Re: [dpdk-dev] [PATCH v4 04/10] examples/l2fwd-event: add eth port setup for eventdev

2019-09-27 Thread Pavan Nikhilesh Bhagavatula
>> Subject: [dpdk-dev] [PATCH v4 04/10] examples/l2fwd-event: add eth >port >> setup for eventdev >> >> From: Sunil Kumar Kori >> >> Add ethernet port Rx/Tx queue setup for event device which are later >> used for setting up event eth Rx/Tx adapters. >> >> Signed-off-by: Sunil Kumar Kori >> --- >

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: add set ptype function

2019-09-29 Thread Pavan Nikhilesh Bhagavatula
>On 8/21/19 11:47 PM, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Add `rte_eth_dev_set_supported_ptypes` function that will allow the >> application to inform the PMD the packet types it is interested in. >> Based on the ptypes set PMDs can optimize their Rx path. >> >> -If appl

Re: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop

2019-09-30 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Nipun Gupta >Sent: Monday, September 30, 2019 1:17 PM >To: Jerin Jacob >Cc: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; >bruce.richard...@intel.com; Akhil Goyal ; >Marko Kovacevic ; Ori Kam >; Radu Nicolau ; >Toma

Re: [dpdk-dev] [PATCH v3 7/7] examples: disable Rx packet type parsing

2019-09-30 Thread Pavan Nikhilesh Bhagavatula
>*app_params, >> } >> >> rte_eth_promiscuous_enable(port_id); >> +rte_eth_dev_set_supported_ptypes(port_id, >RTE_PTYPE_UNKNOWN); > >This is strange, since the function signature is defined (in 1/7) as: > > int rte_eth_dev_set_supported_ptypes(uint16_t port_id, uint32_t >ptype_mask,

Re: [dpdk-dev] [PATCH v4 08/10] examples/l2fwd-event: add eventdev main loop

2019-09-30 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Nipun Gupta >Sent: Monday, September 30, 2019 11:21 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob >Cc: Jerin Jacob Kollanukkaran ; >bruce.richard...@intel.com; Akhil Goyal ; >Marko Kovacevic ; Ori Kam >; Radu

Re: [dpdk-dev] [PATCH v4 1/7] ethdev: add set ptype function

2019-10-01 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Andrew Rybchenko >Sent: Tuesday, October 1, 2019 12:34 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; John McNamara >; Marko Kovacevic >; Thomas Monjalon >; Ferruh Yigit >Cc: dev@dpdk.org >Subject: [EXT

Re: [dpdk-dev] [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2020-12-22 Thread Pavan Nikhilesh Bhagavatula
>Add release barriers before updating the processed packets for worker >lcores to ensure the worker lcore has really finished data processing >and then it can update the processed packets number. > I believe we can live with minor inaccuracies in stats being presented as atomics are pretty heavy

Re: [dpdk-dev] [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2021-01-05 Thread Pavan Nikhilesh Bhagavatula
Hi Feifei, >Hi, Pavan > >Sorry for my late reply and thanks very much for your review. > >> -Original Message----- >> From: Pavan Nikhilesh Bhagavatula >> Sent: 2020年12月22日 18:33 >> To: Feifei Wang ; jer...@marvell.com; >Harry van >> Haaren

Re: [dpdk-dev] [EXT] [PATCH v3] examples/eventdev: refactor ethdev port stop

2021-01-05 Thread Pavan Nikhilesh Bhagavatula
Hi Feifei, >Move eth stop code from "signal_handler" function to the end of >"main" >function. There are two reasons for this: > >First, this improves code maintenance and makes code look simple and >clear. Based on this change, after receiving the interrupt signal, >"fdata->done" is set as 1. The

Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework

2021-01-05 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Juraj Linkeš >Sent: Wednesday, December 23, 2020 5:17 PM >To: bruce.richard...@intel.com; ruifeng.w...@arm.com; >honnappa.nagaraha...@arm.com; phil.y...@arm.com; >vcchu...@amazon.com; dharmik.thak...@arm.com; >jerinjac...@gmail.com; hemant.agra

Re: [dpdk-dev] [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2021-01-08 Thread Pavan Nikhilesh Bhagavatula
Hi Feifei, >Hi, Pavan > > > >> -邮件原件----- > >> 发件人: Pavan Nikhilesh Bhagavatula > >> 发送时间: 2021年1月5日 17:29 > >> 收件人: Feifei Wang ; jer...@marvell.com; >Harry > >> van Haaren > >> 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli

Re: [dpdk-dev] [EXT] [PATCH v2 4/5] common/octeontx2: fix build with sve enabled

2021-01-08 Thread Pavan Nikhilesh Bhagavatula
Hi Ruifeng, >Building with gcc 10.2 with SVE extension enabled got error: > >{standard input}: Assembler messages: >{standard input}:4002: Error: selected processor does not support `mov >z3.b,#0' >{standard input}:4003: Error: selected processor does not support >`whilelo p1.b,xzr,x7' >{standard

Re: [dpdk-dev] [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2021-01-08 Thread Pavan Nikhilesh Bhagavatula
Hi Feifei, >Hi, Pavan > >> -邮件原件----- >> 发件人: Pavan Nikhilesh Bhagavatula >> 发送时间: 2021年1月8日 17:13 >> 收件人: Feifei Wang ; jer...@marvell.com; >Harry >> van Haaren >> 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli >> ; sta...@dpdk.org; Ruifeng W

Re: [dpdk-dev] [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2021-01-12 Thread Pavan Nikhilesh Bhagavatula
Hi Feifei, >Hi Feifei, > >>Hi, Pavan >> >>> -----邮件原件----- >>> 发件人: Pavan Nikhilesh Bhagavatula >>> 发送时间: 2021年1月8日 17:13 >>> 收件人: Feifei Wang ; >jer...@marvell.com; >>Harry >>> van Haaren >>> 抄送: dev@dpdk.org; nd

Re: [dpdk-dev] [EXT] [PATCH v15 12/12] config: fix Arm implementer and its SoCs

2021-01-18 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Juraj Linkeš >Sent: Friday, January 15, 2021 6:56 PM >To: bruce.richard...@intel.com; ruifeng.w...@arm.com; >honnappa.nagaraha...@arm.com; phil.y...@arm.com; >vcchu...@amazon.com; dharmik.thak...@arm.com; >jerinjac...@gmail.com; hemant.agra...@

Re: [dpdk-dev] [EXT] Re: [PATCH 1/2] event/octeontx2: remove selftest from dev args

2020-11-19 Thread Pavan Nikhilesh Bhagavatula
>On Thu, Nov 19, 2020 at 1:24 PM wrote: >> >> From: Pavan Nikhilesh >> >> Since selftest now depends on dynamic mbuf fields it is not >> feasible to run selftest on device probe. > >Indeed, this is something that I missed with the seqn rework. >Can't you call rte_event_dev_selftest() from within

Re: [dpdk-dev] [EXT] Re: [PATCH 1/2] event/octeontx2: remove selftest from dev args

2020-11-19 Thread Pavan Nikhilesh Bhagavatula
> >On Thu, Nov 19, 2020 at 2:31 PM Pavan Nikhilesh Bhagavatula > wrote: >> We can but generally selftest is run as a safety net before an >> custom application runs but now since selftest uses dynamic >> mbuf fields the custom application would be starved of that >&g

Re: [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq

2020-07-21 Thread Pavan Nikhilesh Bhagavatula
>Subject: [dpdk-dev] [PATCH v3 1/2] app/test-eventdev: Fix pipeline atq ./devtools/check-git-log.sh Wrong headline uppercase: app/test-eventdev: Fix pipeline atq Having a more informative commit title and message would be helpful, Something like: " app/eventdev: fix capability check in

Re: [dpdk-dev] [PATCH v4 0/3] event/octeontx2: add support for event crypto adapter

2020-10-08 Thread Pavan Nikhilesh Bhagavatula
Series-Acked-by: Pavan Nikhilesh >This patch series adds support for event crypto adapter in op new >mode in the OCTEON TX2 event PMD. The functionality has been >verified with event crypto adapter test application. Build with >meson and ninja is supported. > >v4: >* In the "event/octeontx2: add

Re: [dpdk-dev] [EXT] [PATCH v2 1/2] eventdev: eventdev: express DLB/DLB2 PMD constraints

2020-10-12 Thread Pavan Nikhilesh Bhagavatula
>This commit implements the eventdev ABI changes required by >the DLB PMD. > >Signed-off-by: Timothy McDaniel For octeontx/octeontx2 Acked-by: Pavan Nikhilesh >--- > drivers/event/dpaa/dpaa_eventdev.c | 3 +- > drivers/event/dpaa2/dpaa2_eventdev.c | 5 +- > drivers/event/

Re: [dpdk-dev] [PATCH v2 2/2] eventdev: update app and examples for new eventdev ABI

2020-10-12 Thread Pavan Nikhilesh Bhagavatula
>> Subject: [PATCH v2 2/2] eventdev: update app and examples for new >eventdev ABI >> >> Several data structures and constants changed, or were added, >> in the previous patch. This commit updates the dependent >> apps and examples to use the new ABI. >> >> Signed-off-by: Timothy McDaniel With f

Re: [dpdk-dev] [PATCH] eal: add new prefetch0_write variant

2020-09-13 Thread Pavan Nikhilesh Bhagavatula
>This commit adds a new rte_prefetch0_write() variant, suggests to the >compiler to use a prefetch instruction with intention to write. As a >compiler builtin, the compiler can choose based on compilation target >what the best implementation for this instruction is. Why not have the other varian

Re: [dpdk-dev] [PATCH] eal: add new prefetch0_write variant

2020-09-14 Thread Pavan Nikhilesh Bhagavatula
>> >This commit adds a new rte_prefetch0_write() variant, suggests to >the >> >compiler to use a prefetch instruction with intention to write. As a >> >compiler builtin, the compiler can choose based on compilation >target >> >what the best implementation for this instruction is. >> >> Why not have

RE: [RFC] Define well known packet burst sizes

2024-10-12 Thread Pavan Nikhilesh Bhagavatula
> We should define some "well known" packet burst sizes in rte_config.h. > A while back we had the same idea, except that it should be platform specific Ex., for CNXK optimal burst size across workloads is 64. Instead of rte_config.h maybe we should have it as a meson option in meson_options.tx

RE: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific errors

2024-10-12 Thread Pavan Nikhilesh Bhagavatula
> > From: Robin Jarry > > Sent: Friday, October 11, 2024 3:24 PM > > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > > ; Nithin Kumar Dabilpuram > > ; Kiran Kumar Kokkilagadda > > ; zhirun@intel.com; Zhirun Yan > > > > Cc: dev@dpdk.org >

RE: [EXTERNAL] Re: [PATCH v8 04/17] event/cnxk: fix pointer mismatch in cleanup

2024-10-08 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 8, 2024 10:10 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; sta...@dpdk.org; Pavan > Nikhilesh Bhagavatula > Subject: [EXTERNAL] Re: [PATCH v8 04/17] event/cnxk: fix pointer mismatch > i

RE: [EXTERNAL] [PATCH v9 04/17] event/cnxk: fix free of non-heap in cleanup code

2024-10-08 Thread Pavan Nikhilesh Bhagavatula
> The code to cleanup in case of error would derefence null pointer > then pass that result to rte_free. > > Fixes: 97a05c1fe634 ("event/cnxk: add port config") > Cc: sthot...@marvell.com > Cc: sta...@dpdk.org > > Signed-off-by: Stephen Hemminger Thanks Stephen, Acked-by: Pavan Nikhilesh

RE: [EXTERNAL] Re: [PATCH v4 3/5] graph: add stats for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Robin Jarry > Sent: Friday, October 11, 2024 3:24 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; zhirun@intel.com; Zhirun Yan > > Cc: dev@dpdk.org > Subject

RE: [EXTERNAL] Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> On Fri, Aug 16, 2024 at 5:10 PM wrote: > > > > From: Pavan Nikhilesh > > > > Add ability for Nodes to advertise error counters > > during registration. > > > > Signed-off-by: Pavan Nikhilesh > > Such a series deserve a cover letter. > > It also deserves a RN update, and I see no removal of t

RE: [EXTERNAL] Re: [PATCH v4 4/5] node: add error stats for ip4 lookup node

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Robin Jarry > Sent: Friday, October 11, 2024 3:19 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; zhirun@intel.com; Wathsala Vithanage > ; Bruce Richardson > ;

RE: [EXTERNAL] Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> I forgot to mention. > > If you submit a v5, could you squash all commits that deal with > lib/graph into a single patch? Including the public API to increment the > nodes xstats? I will squash (2/5, 3/5), (4/5, 5/5) and leave 1/5 alone as it is a very big patch containing updates to svg fil

RE: [EXTERNAL] Re: [PATCH v5 0/6] Introduce event pre-scheduling

2024-10-04 Thread Pavan Nikhilesh Bhagavatula
> > From: Pavan Nikhilesh > > > > Event pre-scheduling improves scheduling performance by assigning events > > to event ports in advance when dequeues are issued. > > This series introduces various types and levels of pre-scheduling to the > > eventdev library. > > > > pre-scheduling Types: > > *

RE: [EXTERNAL] Re: [PATCH v7 1/6] eventdev: introduce event pre-scheduling

2024-10-06 Thread Pavan Nikhilesh Bhagavatula
> On Sat, 5 Oct 2024 13:29:56 +0530 > wrote: > > > +static int > > +preschedule_test(enum rte_event_dev_preschedule_type > preschedule_type, const char *preschedule_name) > > +{ > > +#define NB_EVENTS 1024 > > + uint64_t start, total; > > + struct rte_event ev; > > + int rc, cnt; > > +

RE: [EXTERNAL] [PATCH] event/octeontx: resolve possible integer overflow

2024-10-18 Thread Pavan Nikhilesh Bhagavatula
> The last argument passed to ssovf_parsekv() is an > unsigned char*, but it is accessed as an integer. > This can lead to an integer overflow. > > Hence, make ensure the argument is accessed as a char > and for better error handling use strtol instead of atoi. > > Signed-off-by: Hanumanth Pothul

RE: [PATCH] event/cnxk: remove single dequeue functions

2024-10-21 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Tuesday, October 22, 2024 10:30 AM > To: Jerin Jacob ; mattias.ronnb...@ericsson.com; > Pavan Nikhilesh Bhagavatula ; Shijith Thotton > > Cc: dev@dpdk.org > Subject: [PATCH] event/cnxk: remove

RE: [EXTERNAL] Re: [PATCH v5 0/3] Introduce node-specific errors in graph library

2024-10-14 Thread Pavan Nikhilesh Bhagavatula
> Hi Pavan, > > I am resending my review here. It seems you didn't get it. > > , Oct 14, 2024 at 13:58: > > From: Pavan Nikhilesh > > > > > > Introduce the ability for nodes to advertise error counters during > > registration and increment them during the node process function in > > the graph l

RE: [EXTERNAL] Re: [PATCH 07/20] event/cnxk: add CN20K SSO dequeue fast path

2024-10-22 Thread Pavan Nikhilesh Bhagavatula
> On Thu, 3 Oct 2024 18:52:24 +0530 > wrote: > > > +static __rte_always_inline uint16_t > > +cn20k_sso_hws_get_work(struct cn20k_sso_hws *ws, struct rte_event > *ev, const uint32_t flags) > > +{ > > + union { > > + __uint128_t get_work; > > + uint64_t u64[2]; > > + } gw; >

RE: [EXTERNAL] Re: [PATCH 01/20] common/cnxk: implement SSO HW info

2024-10-22 Thread Pavan Nikhilesh Bhagavatula
> On Thu, 3 Oct 2024 18:52:18 +0530 > wrote: > > > From: Pavan Nikhilesh > > > > Add SSO HW info mbox to get hardware capabilities, and reuse > > them instead of depending on hardcoded values. > > Remove redundant includes. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > You need to fix dir

RE: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls

2024-10-30 Thread Pavan Nikhilesh Bhagavatula
> > Hi Pavan, > > > > Snipped > > > > > > > > I see compilation failure on ARM platforms due to missing header include. > > > > > > ../examples/helloworld/main.c: In function 'parse_topology': > > > ../examples/helloworld/main.c:83:13: error: implicit declaration of > > > function 'strtoul'; did yo

RE: [EXTERNAL] [RFC v3 2/3] test/lcore: enable tests for topology

2024-10-30 Thread Pavan Nikhilesh Bhagavatula
> add functional test cases to validate topology supported lcore > API. > > v3 changes: > - fix test test-report/2024-October/817748.html > > Signed-off-by: Vipin Varghese > --- Test fails on ARM platform: lcore 19, socket 0, role RTE, cpuset 19 Control thread running successfully INFO: lco

RE: [EXTERNAL] [RFC v3 3/3] examples: add lcore topology API calls

2024-10-30 Thread Pavan Nikhilesh Bhagavatula
> Enhance example code to allow topology based lcores API, while > retaining default behaviour. > > - helloworld: allow lcoes to send hello to lcores in selected topology. > - l2fwd: allow use of IO lcores topology. > - skeleton: choose the lcore from IO topology which has more ports. > > v3 c

RE: [EXTERNAL] Re: [PATCH v2 1/3] eventdev: introduce event pre-scheduling

2024-09-26 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: Pavan Nikhilesh Bhagavatula > > Sent: Wednesday, September 25, 2024 6:30 AM > > To: Mattias Rönnblom ; Pathak, Pravin > > ; Jerin Jacob ; Shijith > Thotton > > ; Sevincer, Abdullah > ; > > hemant.agra..

RE: [EXTERNAL] Re: [PATCH v2 1/3] eventdev: introduce event pre-scheduling

2024-09-25 Thread Pavan Nikhilesh Bhagavatula
> On 2024-09-19 15:13, Pavan Nikhilesh Bhagavatula wrote: > >>> From: pbhagavat...@marvell.com > >>> Sent: Tuesday, September 17, 2024 3:11 AM > >>> To: jer...@marvell.com; sthot...@marvell.com; Sevincer, Abdullah > >>> ; hemant.agra...@nxp.com;

RE: [PATCH v2 1/3] eventdev: introduce event pre-scheduling

2024-09-19 Thread Pavan Nikhilesh Bhagavatula
> > From: pbhagavat...@marvell.com > > Sent: Tuesday, September 17, 2024 3:11 AM > > To: jer...@marvell.com; sthot...@marvell.com; Sevincer, Abdullah > > ; hemant.agra...@nxp.com; > > sachin.sax...@oss.nxp.com; Van Haaren, Harry > ; > > mattias.ronnb...@ericsson.com; lian...@liangbit.com; Mccarthy

RE: [EXTERNAL] Re: [PATCH v4 0/6] Introduce event pre-scheduling

2024-10-02 Thread Pavan Nikhilesh Bhagavatula
> > From: Pavan Nikhilesh > > > > Event pre-scheduling improves scheduling performance by assigning events > > to event ports in advance when dequeues are issued. > > This series introduces various types and levels of pre-scheduling to the > > eventdev library. > > Any numbers on how much this im

RE: [EXTERNAL] [PATCH v7 04/16] event/cnxk: fix pointer mismatch in cleanup

2024-10-02 Thread Pavan Nikhilesh Bhagavatula
> The code to cleanup in case of error was passing incorrect > value to rte_free. The ports[] entry was allocated with > rte_malloc and that should be used instead of the offset > in that object. > > Fixes: 97a05c1fe634 ("event/cnxk: add port config") > Cc: sthot...@marvell.com > Cc: sta...@dpdk.o

RE: [EXTERNAL] [RFC PATCH v6 1/2] eventdev: add atomic queue to test-eventdev app

2025-02-04 Thread Pavan Nikhilesh Bhagavatula
> Add an atomic queue test to the test-eventdev app, which is based on the > order queue test that exclusively uses atomic queues. > > This makes it compatible with event devices such as the > distributed software eventdev. > > The test detects if port maintenance is required. > > To verify atom

RE: [EXTERNAL] [RFC v5 1/2] eventdev: add atomic queue to test-eventdev app

2025-01-22 Thread Pavan Nikhilesh Bhagavatula
> Add an atomic queue test based on the order queue test that exclusively uses > atomic queues. > This makes it compatible with event devices such as the distributed software > eventdev. > > The test detects if port maintenance is required. > > To verify atomicity, a spinlock is set up for each c

RE: [EXTERNAL] [RFC PATCH v6 1/2] eventdev: add atomic queue to test-eventdev app

2025-02-14 Thread Pavan Nikhilesh Bhagavatula
> On Tue, 2025-02-04 at 16:11 +0000, Pavan Nikhilesh Bhagavatula wrote: > > > Add an atomic queue test to the test-eventdev app, which is based on the > > > order queue test that exclusively uses atomic queues. > > > > > > This makes it compatible with even

RE: [PATCH] config/arm: fix march features not being set

2025-03-18 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, March 13, 2025 10:13 AM > To: Wathsala Wathawana Vithanage ; Jerin > Jacob ; Bruce Richardson > Cc: dev@dpdk.org; nd > Subject: RE: [PATCH] config/arm: fix march features not being set >

RE: [EXTERNAL] [PATCH] config/arm: fix meson for native instruction set Arm CPUs

2025-03-19 Thread Pavan Nikhilesh Bhagavatula
Hi Gregory, > Arm meson.build unconditionally relays on the `extra_features` > member of SoC configuration. > > SoC dictionary is populated for Arm CPUs with generic instruction set > only. > For Arm CPUs with native CPU instruction set the SoC dictionary is > empty. > > meson setup failed for

RE: [RFC 0/2] introduce event vector adapter

2025-03-26 Thread Pavan Nikhilesh Bhagavatula
++ > -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, March 26, 2025 6:45 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [RFC 0/2] introduce event vector adapter > > From: Pavan Nikhilesh > >

RE: [EXTERNAL] Re: [RFC 2/2] eventdev: add default software vector adapter

2025-03-26 Thread Pavan Nikhilesh Bhagavatula
> On Wed, 26 Mar 2025 18:44:36 +0530 > wrote: > > > +struct sw_vector_adapter_service_data { > > + uint32_t service_id; > > + RTE_ATOMIC(rte_mcslock_t *) lock; > > + RTE_TAILQ_HEAD(, sw_vector_adapter_data) adapter_list; > > +}; > > Why the indirect pointer to the lock? rather than embeddi

RE: [RFC v2 0/3] Introduce DMA enqueue/dequeue operations

2025-03-26 Thread Pavan Nikhilesh Bhagavatula
++ > -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, March 27, 2025 1:07 AM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [RFC v2 0/3] Introduce DMA enqueue/dequeue operations > > From: Pavan Nikhilesh

RE: [EXTERNAL] [PATCH] config/arm: fix meson for native instruction set Arm CPUs

2025-03-27 Thread Pavan Nikhilesh Bhagavatula
> Hi Gregory, > > > Arm meson.build unconditionally relays on the `extra_features` > > member of SoC configuration. > > > > SoC dictionary is populated for Arm CPUs with generic instruction set > > only. > > For Arm CPUs with native CPU instruction set the SoC dictionary is > > empty. > > > > meso

RE: [PATCH v6 0/2] node: add mbuf dynamic field for nodes

2025-05-05 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Monday, April 28, 2025 4:07 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v6 0/2] n

RE: [EXTERNAL] Re: [25.11 PATCH 1/3] dmadev: add enqueue dequeue operations

2025-05-02 Thread Pavan Nikhilesh Bhagavatula
Hi Fengchengwen, > Hi Pavan, > > On 2025/4/16 18:09, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Add enqueue/dequeue operations that use struct rte_dma_op > > to communicate with the dma device. > > These operations need to be enabled at dma device configuration > > time b

RE: [PATCH v5 1/2] node: add global node mbuf dynfield

2025-04-18 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Wednesday, April 9, 2025 7:26 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v5 1/2]

RE: [EXTERNAL] Re: [PATCH] devtools: fix regex of cnxk skip files

2025-03-06 Thread Pavan Nikhilesh Bhagavatula
> 06/03/2025 16:25, pbhagavat...@marvell.com: > > From: Pavan Nikhilesh > > > > SKIP_FILES should include the path of the file. > > Update the regex to match the path. > > Can you please also check this one: > -v SKIP_FILES='osdep.h$' > Is it really working without the full path? > Sure,

RE: [EXTERNAL] Re: [PATCH] devtools: fix regex of cnxk skip files

2025-03-06 Thread Pavan Nikhilesh Bhagavatula
> 06/03/2025 16:25, pbhagavat...@marvell.com: > > From: Pavan Nikhilesh > > > > SKIP_FILES should include the path of the file. > > Update the regex to match the path. > > > > Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver") > > > > Signed-off-by: Pavan Nikhilesh > > --- > >

RE: [PATCH] config/arm: fix march features not being set

2025-03-12 Thread Pavan Nikhilesh Bhagavatula
> Hi Pavan, > > I think this patch does the right thing. I have a minor comment on the > cc.has_argument you have added. > > > --- > > config/arm/meson.build | 11 --- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build

RE: [EXTERNAL] [RFC v7 0/4] eventdev: atomic tests to test-eventdev app

2025-02-20 Thread Pavan Nikhilesh Bhagavatula
> Add atomic tests to the test-eventdev app which correspond to the order > tests but use exclusively atomic queues. > > The test detects if port maintenance is required, and so they are compatible > with event devices such as the distributed software eventdev. > > To verify atomicity, a spinlock

RE: [PATCH] test/event: fix number of queues in eventdev conf

2025-02-25 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Shijith Thotton > Sent: Thursday, February 6, 2025 8:03 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; Shijith Thotton ; > sta...@dpdk.org; Naga Harish K S V > Subject: [PATCH] test/event: fix number of

RE: [PATCH v3 02/14] eventdev: remover unnecessary deref on function pointers

2025-02-25 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, February 20, 2025 10:25 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Morten Brørup > > ; Richardson, Bruce > > ; Gujjar, Abhinandan S > > ; Jerin Jacob ; Amit > > Prakash Shukla ; Naga Harish K, S V > > > > Sub

RE: [EXTERNAL] Re: [PATCH 1/2] node: add global node mbuf dynfield

2025-04-04 Thread Pavan Nikhilesh Bhagavatula
> Hi Stephen, > > Thanks for commenting. See response inline. > > Regards, > Nitin > > On Tue, Apr 1, 2025 at 7:45 PM Stephen Hemminger > wrote: > > > > On Tue, 1 Apr 2025 09:50:46 +0530 > > Nitin Saxena wrote: > > > > > +int rte_node_mbuf_dynfield_register(void) > > > +{ > > > + struct no

RE: [PATCH v6 1/2] node: add global node mbuf dynfield

2025-05-09 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Monday, April 28, 2025 4:07 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v6 1/2]

RE: [PATCH v6 2/2] node: use node mbuf dynfield in ip4 nodes

2025-05-09 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Nitin Saxena > Sent: Monday, April 28, 2025 4:07 PM > To: Nithin Kumar Dabilpuram ; Pavan Nikhilesh > Bhagavatula ; Robin Jarry > ; Christophe Fontaine > Cc: dev@dpdk.org; Jerin Jacob ; Nitin Saxena > > Subject: [PATCH v6 2/2] n

RE: rte_lcore_has_role() return value

2025-05-19 Thread Pavan Nikhilesh Bhagavatula
Hi Morten, Looks like this is meant for Vipin. +Vipin Thanks, Pavan. > Pavan, > > The rte_lcore_has_role() documentation says it returns bool. > > Its implementation returns a true value (-1) if given a non-compliant > lcore_id, > e.g. LCORE_ID_ANY. > > I think it should behave like rte_lc

RE: rte_lcore_has_role() return value

2025-05-19 Thread Pavan Nikhilesh Bhagavatula
My bad, I got it confused with lcore topology patches. I will look into this. Thanks, Pavan. > -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Monday, May 19, 2025 7:32 PM > To: Morten Brørup ; Varghese, Vipin > > Cc: dev > Subject: RE: rte_lcore_ha

RE: [EXTERNAL] [PATCH] drivers: remove __rte_used from functions for compatibility with MSVC

2025-05-27 Thread Pavan Nikhilesh Bhagavatula
> > From: Andre Muezerie > > Sent: Friday, April 4, 2025 7: 18 AM > > To: Nithin Kumar Dabilpuram ; Kiran Kumar > > Kokkilagadda ; ZjQcmQRYFpfptBannerStart Prioritize security for external emails: Confirm sender and content safety before clicking links or o

Re: [EXTERNAL] Re: [25.11 PATCH v3 0/5] Introduce DMA enqueue/dequeue operations

2025-06-09 Thread Pavan Nikhilesh Bhagavatula
Hi Bruce, >On Sat, May 24, 2025 at 02:43:10PM +0530, pbhagavat...@marvell.com wrote: >> From: Pavan Nikhilesh >> >> Introduce DMA enqueue/dequeue operations to the DMA device library. >> >> Add configuration flags to rte_dma_config instead of boolean for >> individual features. >> >> The enqueue

Re: [EXTERNAL] [PATCH v2] examples/l3fwd: adjust Tx burst size based on Rx burst

2025-06-10 Thread Pavan Nikhilesh Bhagavatula
>Previously, the TX burst size was fixed at 256, leading to performance >degradation in certain scenarios. > >This patch introduces logic to set the TX burst size to match the >configured RX burst size (--burst option, default 32, max 512) >for better efficiency. > >Fixes: d5c4897ecfb2 ("examples/l

Re: [PATCH] test/event: fix event vector adapter timeouts

2025-06-19 Thread Pavan Nikhilesh Bhagavatula
>Sent: Thursday, June 12, 2025 05:43 >To: Jerin Jacob; tho...@monjalon.net; david.march...@redhat.com; Pavan >Nikhilesh Bhagavatula >Cc: dev@dpdk.org >Subject: [PATCH] test/event: fix event vector adapter timeouts > >From: Pavan Nikhilesh > >Update event vector adapte

<    1   2   3   4   5   6