Hi Olivier,
On Mon, Sep 19, 2016 at 03:42:42PM +0200, Olivier Matz wrote:
> When possible, replace the uses of rte_mempool_create() with
> the helper provided in librte_mbuf: rte_pktmbuf_pool_create().
>
> This is the preferred way to create a mbuf pool.
>
> By the way, akso update the document
Hi Hemant,
On Wed, Jan 18, 2017 at 12:12:56AM +0530, Hemant Agrawal wrote:
> When possible, replace the uses of rte_mempool_create() with
> the helper provided in librte_mbuf: rte_pktmbuf_pool_create().
>
> This is the preferred way to create a mbuf pool.
>
> This also updates the documentation.
Hi Olivier,
Reply inline.
On Tue, Jan 31, 2017 at 11:31:51AM +0100, Olivier Matz wrote:
> Hi Santosh,
>
> I guess this patch is targeted for 17.05, right?
>
Yes.
> Please see some other comments below.
>
> On Fri, 20 Jan 2017 20:43:41 +0530,
> wrote:
> > Fro
Hi Olivier,
On Mon, Feb 06, 2017 at 06:01:15PM +0100, Olivier Matz wrote:
> On Tue, 31 Jan 2017 20:02:26 +0530, Santosh Shukla
> wrote:
> > Hi Olivier,
> >
> > Reply inline.
> >
> > On Tue, Jan 31, 2017 at 11:31:51AM +0100, Olivier Matz wrote:
> > >
On Wed, Dec 14, 2016 at 11:02:23AM +0800, Yuanhan Liu wrote:
> On Wed, Dec 14, 2016 at 07:25:56AM +0530, Jerin Jacob wrote:
> > * Following macros are derived from linux/pci_regs.h, however,
> > * we can't simply include that header here, as there is no such
> > @@ -320,37 +322,37 @@ static con
On Wed, Dec 14, 2016 at 10:55:34AM +0800, Yuanhan Liu wrote:
> On Wed, Dec 14, 2016 at 07:25:57AM +0530, Jerin Jacob wrote:
> > From: Santosh Shukla
> >
> > Replace the raw I/O device memory read/write access with eal
> > abstraction for I/O device memory read/write ac
On Thu, Dec 15, 2016 at 04:37:12PM +0800, Jianbo Liu wrote:
> On 14 December 2016 at 09:55, Jerin Jacob
> wrote:
> > From: Santosh Shukla
> >
> > Replace the raw I/O device memory read/write access with eal
> > abstraction for I/O device memory read/write access
Hi Jiangbo,
On Thu, Dec 15, 2016 at 08:40:19PM -0800, Santosh Shukla wrote:
> On Thu, Dec 15, 2016 at 04:37:12PM +0800, Jianbo Liu wrote:
> > On 14 December 2016 at 09:55, Jerin Jacob
> > wrote:
> > > From: Santosh Shukla
> > >
> >
> > memory barri
Hi Shreyansh,
On Thu, Dec 29, 2016 at 10:46:35AM +0530, Shreyansh Jain wrote:
> From: Hemant Agrawal
>
> Adding NXP DPAA2 architecture specific mempool support
> Each mempool instance is represented by a DPBP object
> from the FSL-MC bus.
>
> This patch also registers a dpaa2 type MEMPOOL OPS
>
On Wed, Jan 04, 2017 at 09:53:40PM +0800, Tiwei Bie wrote:
> On Tue, Dec 27, 2016 at 03:19:29PM +0530, Jerin Jacob wrote:
> > From: Santosh Shukla
> > /* Update the tx tail register */
> > rte_wmb();
> > - I40E_PCI_REG_WRITE(
kpatch result:
- No error/warning noticed.
[1] https://www.mail-archive.com/dev@dpdk.org/msg67438.html
[2] https://www.mail-archive.com/dev@dpdk.org/msg70279.html
Santosh Shukla (12):
eal/pci: introduce PCI driver iova as va flag
eal/pci: export match function
bsdapp/eal_pci: get iommu cla
IOMMU/SMMU.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/common/include/rte_pci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_pci.h
b/lib/librte_eal/common/include/rte_pci.h
index 8b123391c..ac79040dd 100644
--- a/lib
Export rte_pci_match() function as it needed in the followup patch.
Signed-off-by: Santosh Shukla
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/common/eal_common_pci.c | 10 +-
lib/librte_eal/common/include/rte_pci.h | 15
Introducing rte_pci_get_iommu_class API which helps to get iommu class
of PCI device on the bus and returns preferred iova mapping mode for
PCI bus.
Bsdapp case returns default iova mode.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/bsdapp/eal/eal_pci.c
e value '1' is _pa and value '2' is _va mode.
So mode selection scheme is like:
if mode == 2 then iova mode is _va.
if mode == 1 then iova mode is _pa
if mode == 3 then iova mode ia _pa.
So mode !=2 will be default iova mode.
Signed-off-by: Santosh Shukla
Signed-off-by: Je
. Check for vfio-noiommu mode enabled.
If 1) & 2) is false and 0) is true then select
mapping scheme as iova=va. Otherwise use default
mapping scheme (iova_pa).
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v1 --> v2:
- Removed Linux version check in vfio_noiommu func. R
Introducing rte_eal_iova_mode() helper API. This API
used by non-eal library for detecting iova mode.
Signed-off-by: Santosh Shukla
---
lib/librte_eal/bsdapp/eal/eal.c | 6 ++
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/common/include/rte_eal.h
- Moving late bus scanning to up..just after eal_parsing.
- Auto detect iova mapping mode, based on the result of
rte_bus_scan_iommu_class.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal.c | 16 ++--
1 file changed, 10 insertions
- Moving late bus scanning to up..just after eal_parsing.
- Mapping mode would be default for bsdapp. It supports
only one pass through mode (RTE_KDRV_NIC_UIO)
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/bsdapp/eal/eal.c | 16 ++--
1 file changed
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_mempool/rte_mempool.h | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c
b/lib/librte_eal/linuxapp/eal/eal_memory.c
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/common/rte_malloc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_malloc.c
b/lib/librte_eal/common/rte_malloc.c
Check iova mode and accordingly map iova to pa or va.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c
b/lib/librte_eal
Export rte_pci_match() function as it needed in the followup patch.
Signed-off-by: Santosh Shukla
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/common/eal_common_pci.c | 10 +-
lib/librte_eal/common/include/rte_pci.h | 15
rg/msg67438.html
[2] https://www.mail-archive.com/dev@dpdk.org/msg70674.html
[3] https://www.mail-archive.com/dev@dpdk.org/msg70279.html
[4] https://www.mail-archive.com/dev@dpdk.org/msg70692.html
Santosh Shukla (11):
eal/pci: introduce PCI driver iova as va flag
eal/pci: export match function
IOMMU/SMMU.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/common/include/rte_pci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_pci.h
b/lib/librte_eal/common/include/rte_pci.h
index 8b123391c..ac79040dd 100644
--- a/lib
. Check for vfio-noiommu mode enabled.
If 1) & 2) is false and 0) is true then select
mapping scheme as iova=va. Otherwise use default
mapping scheme (iova_pa).
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v1 --> v2:
- Removed Linux version check in vfio_noiommu func. R
e value '1' is _pa and value '2' is _va mode.
So mode selection scheme is like:
if mode == 2 then iova mode is _va.
if mode == 1 then iova mode is _pa
if mode == 3 then iova mode ia _pa.
So mode !=2 will be default iova mode.
Signed-off-by: Santosh Shukla
Signed-off-by: Je
Introducing rte_pci_get_iommu_class API which helps to get iommu class
of PCI device on the bus and returns preferred iova mapping mode for
PCI bus.
Bsdapp case returns default iova mode.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/bsdapp/eal/eal_pci.c
Introducing rte_eal_iova_mode() helper API. This API
used by non-eal library for detecting iova mode.
Signed-off-by: Santosh Shukla
---
lib/librte_eal/bsdapp/eal/eal.c | 6 ++
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/common/include/rte_eal.h
- Moving late bus scanning to up..just after eal_parsing.
- Auto detect iova mapping mode, based on the result of
rte_bus_scan_iommu_class.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal.c | 16 ++--
1 file changed, 10 insertions
- Moving late bus scanning to up..just after eal_parsing.
- Mapping mode would be default for bsdapp. It supports
only one pass through mode (RTE_KDRV_NIC_UIO)
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/bsdapp/eal/eal.c | 16 ++--
1 file changed
Check iova mode and accordingly map iova to pa or va.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c
b/lib/librte_eal
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c
b/lib/librte_eal/linuxapp/eal/eal_memory.c
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/common/rte_malloc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_malloc.c
b/lib/librte_eal/common/rte_malloc.c
m_usage to make it mempool aware.
Refer [2].
[1] http://dpdk.org/dev/patchwork/patch/25603/
[2] http://dpdk.org/dev/patchwork/patch/25605/
Signed-off-by: Santosh Shukla
---
doc/guides/rel_notes/deprecation.rst | 8
1 file changed, 8 insertions(+)
diff --git a/doc/guides/rel_notes/depre
-octeontx-hw-mempool-manager
Santosh Shukla (6):
mempool: fix flags data type
mempool: get the mempool capability
mempool: detect physical contiguous object in pool
mempool: add mempool arg in xmem size and usage
mempool: introduce block size align flag
mempool: update range info t
pool is contiguous.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v1 -- v2:
- Renamed flag to MEMPOOL_F_CAPA_PHYS_CONTIG
- Comment reworded.
Refer [1].
[1] http://dpdk.org/dev/patchwork/patch/25604/
lib/librte_mempool/rte_mempool.c | 8
lib/librte_mempool/rte_mempool.h
Allow mempool to advertise its capability.
A handler been introduced called rte_mempool_ops_get_capabilities.
- Upon ->get_capabilities call, mempool driver will advertise
capability by updating to 'mp->flags'.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v
xmem_size and xmem_usage need to know the status of mp->flag.
Following patch will make use of that.
Signed-off-by: Santosh Shukla
---
v1 -- v2:
- added new mempool param in xmem_size/usage, Per deprecation notice [1]
and discussion based on thread [2]
[1] http://dpdk.org/dev/patchwork/pa
or consumer mode")
Fixes: d6f78df6fe ("mempool: use bit flags for multi consumers and producers")
Fixes: d1d914ebbc ("mempool: allocate in several memory chunks by default")
Signed-off-by: Santosh Shukla
---
- Changes are based on per deprecation notice [1]
[1] http:/
7; may end up sacrificing first block_sz area of
memzone area x. So total number of the object which can fit in the
pool area is n-1, Which is incorrect behavior.
Therefore we request one additional object (/block_sz area) from memzone
when F_BLK_SZ_ALIGNED flag is set.
Signed-off-by: Santosh Sh
/end address to HW pool manager.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v1 -- v2:
- Added RTE_FUNC_PTR_OR_RET
lib/librte_mempool/rte_mempool.c | 3 +++
lib/librte_mempool/rte_mempool.h | 22 ++
lib/librte_mempool/rte_mempool_ops.c
IOMMU/SMMU.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v3 --> v4:
- Renamed RTE_PCI_DRV_NEED_IOVA_VA to RTE_PCI_DRV_IOVA_AS_VA.
(Suggested by Maxime)
lib/librte_eal/common/include/rte_pci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/incl
Introducing rte_pci_get_iommu_class API which helps to get iommu class
of PCI device on the bus and returns preferred iova mapping mode for
PCI bus.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v3 --> v4:
- Created a separate patch per suggestion from Maxime.
Initially thou
071282.html
[6] http://dpdk.org/ml/archives/dev/2017-July/070951.html
[7] http://dpdk.org/ml/archives/dev/2017-July/070941.html
[8] http://dpdk.org/ml/archives/dev/2017-July/070952.html
[9] http://dpdk.org/ml/archives/dev/2017-July/070918.html
Santosh Shukla (12):
eal/pci: introduce PCI driver
Export rte_pci_match() function as it needed in the followup patch.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Acked-by: Maxime Coquelin
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/common/eal_common_pci.c | 10 +-
lib/librte_eal
Introducing rte_eal_iova_mode() helper API. This API
used by non-eal library for detecting iova mode.
Signed-off-by: Santosh Shukla
---
lib/librte_eal/bsdapp/eal/eal.c | 6 ++
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +
lib/librte_eal/common/include/rte_eal.h
RTE_PCI_DRV_IOVA_AS_VA.
2. Look for any device attached to UIO class of driver.
3. Check for vfio-noiommu mode enabled.
If 2) & 3) is false and 1) is true then select
mapping scheme as RTE_IOVA_VA. Otherwise use default
mapping scheme (RTE_IOVA_PA).
Signed-off-by: Santosh Shukla
Signed-off-by: J
Bsdapp case returns default iova mode.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v3 --> v4:
- Removed rte_pci_get_iommu_class api declaration. Now that
sits into separate patch [03/12].
lib/librte_eal/bsdapp/eal/eal_pci.c | 10 ++
lib/librte_eal/bsd
selection scheme is:
if mode == 0 then iova mode is _pa,
if mode == 1 then iova mode is _pa,
if mode == 2 then iova mode is _va,
if mode == 3 then iova mode ia _pa.
So mode !=2 will be default iova mode (_pa).
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v3 --> v4:
- Initia
- Moving late bus scanning to up..just after eal_parsing.
- Auto detect iova mapping mode, based on the result of
rte_bus_scan_iommu_class.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal.c | 15 +--
1 file changed, 9 insertions(+), 6
- Moving late bus scanning to up..just after eal_parsing.
- Mapping mode would be default for bsdapp. It supports
only one pass through mode (RTE_KDRV_NIC_UIO)
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/bsdapp/eal/eal.c | 15 +--
1 file changed, 9
Check iova mode and accordingly map iova to pa or va.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c
b/lib/librte_eal
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c
b/lib/librte_eal/linuxapp/eal/eal_memory.c
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/common/rte_malloc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_malloc.c
b/lib/librte_eal/common/rte_malloc.c
changes return val from -EINVAL to -ENOTSUP.
(Suggested by Olivier)
* Specific details on v1-->v2 change summary described in each patch.
Checkpatch status:
- None.
Work History:
* Refer [1] for v1.
Thanks.
[1] http://dpdk.org/ml/archives/dev/2017-June/067022.html
Santosh Shukla (2):
e
user can override the RTE_MEMPOOL_OPS_DEFAULT by passing
pool handle to eal `--mbuf-pool-ops=""`.
Signed-off-by: Santosh Shukla
---
v1 --> v2:
(Changes per review feedback from Olivier)
- Renamed rte_eal_get_mempool_name to rte_eal_mbuf_default_mempool_ops().
- Added support in bsda
];
rte_eth_dev_get_preferred_pool_ops(ethdev_port_id, pref_mempoolx /*out*/);
rte_mempool_create_empty();
rte_mempool_set_ops_byname( , pref_memppol, );
rte_mempool_populate_default();
Signed-off-by: Santosh Shukla
---
v1 --> v2:
- Renamed _get_preferred_pool to _get_preferred_pool_ops().
Per v1 review feedb
m_usage to make it mempool aware.
Refer [2].
[1] http://dpdk.org/dev/patchwork/patch/25603/
[2] http://dpdk.org/dev/patchwork/patch/25605/
Signed-off-by: Santosh Shukla
---
v1 --> v2:
- Changed the title.
- Added empty line between 'mempool:' and - ``.
(Both suggested by Olivier)
604/
[4] v1: http://dpdk.org/dev/patchwork/patch/25605/
[5] v1:
http://dev.dpdk.narkive.com/Qcu55Lgz/dpdk-dev-patch-0-4-infrastructure-to-support-octeontx-hw-mempool-manager
Santosh Shukla (6):
mempool: fix flags data type
mempool: get the mempool capability
mempool: detect physical contigu
Allow mempool to advertise its capability.
A handler been introduced called rte_mempool_ops_get_capabilities.
- Upon ->get_capabilities call, mempool driver will advertise
capability by updating to 'mp->flags'.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v2
or consumer mode")
Fixes: d6f78df6fe ("mempool: use bit flags for multi consumers and producers")
Fixes: d1d914ebbc ("mempool: allocate in several memory chunks by default")
Signed-off-by: Santosh Shukla
---
Cc: Wenfeng Liu
Cc: Lazaros Koromilas
Cc: Olivier Matz
v
7; may end up sacrificing first block_sz area of
memzone area x. So total number of the object which can fit in the
pool area is n-1, Which is incorrect behavior.
Therefore we request one additional object (/block_sz area) from memzone
when F_BLK_SZ_ALIGNED flag is set.
Signed-off-by: Santosh Sh
pool is contiguous.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v2 -- v3:
- type casted len to uint64_t (fix build warning).
v1 -- v2:
- Renamed flag to MEMPOOL_F_CAPA_PHYS_CONTIG
- Comment reworded.
Refer [1].
[1] http://dpdk.org/dev/patchwork/patch/25604/
lib/librte_mempool
xmem_size and xmem_usage need to know the status of mp->flag.
Following patch will make use of that.
Signed-off-by: Santosh Shukla
---
v1 -- v2:
- added new mempool param in xmem_size/usage, Per deprecation notice [1]
and discussion based on thread [2]
[1] http://dpdk.org/dev/patchwork/pa
/end address to HW pool manager.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
v1 -- v2:
- Added RTE_FUNC_PTR_OR_RET
lib/librte_mempool/rte_mempool.c | 3 +++
lib/librte_mempool/rte_mempool.h | 22 ++
lib/librte_mempool/rte_mempool_ops.c
Export rte_pci_match() function as it needed in the followup patch.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Acked-by: Maxime Coquelin
---
v4 --> v5:
- Changed DPDK_17.08 to DPDK_17.11 in _version.map
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 7 +++
IOMMU/SMMU.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
---
v3 --> v4:
- Renamed RTE_PCI_DRV_NEED_IOVA_VA to RTE_PCI_DRV_IOVA_AS_VA.
(Suggested by Maxime)
lib/librte_eal/common/include/rte_pci.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/
/071282.html
[6] http://dpdk.org/ml/archives/dev/2017-July/070951.html
[7] http://dpdk.org/ml/archives/dev/2017-July/070941.html
[8] http://dpdk.org/ml/archives/dev/2017-July/070952.html
[9] http://dpdk.org/ml/archives/dev/2017-July/070918.html
[10] http://dpdk.org/ml/archives/dev/2017-July/071754.
Introducing rte_pci_get_iommu_class API which helps to get iommu class
of PCI device on the bus and returns preferred iova mapping mode for
PCI bus.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
---
v3 --> v4:
- Created a separate patch per suggest
Introducing rte_eal_iova_mode() helper API. This API
used by non-eal library for detecting iova mode.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
---
lib/librte_eal/bsdapp/eal/eal.c | 6 ++
lib/librte_eal/bsdapp/eal
- Moving late bus scanning to up..just after eal_parsing.
- Auto detect iova mapping mode, based on the result of
rte_bus_scan_iommu_class.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
---
lib/librte_eal/linuxapp/eal/eal.c | 15 +--
1
RTE_PCI_DRV_IOVA_AS_VA.
2. Look for any device attached to UIO class of driver.
3. Check for vfio-noiommu mode enabled.
If 2) & 3) is false and 1) is true then select
mapping scheme as RTE_IOVA_VA. Otherwise use default
mapping scheme (RTE_IOVA_PA).
Signed-off-by: Santosh Shukla
Signed-off-by: J
selection scheme is:
if mode == 0 then iova mode is _pa,
if mode == 1 then iova mode is _pa,
if mode == 2 then iova mode is _va,
if mode == 3 then iova mode ia _pa.
So mode !=2 will be default iova mode (_pa).
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
Bsdapp case returns default iova mode.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
---
v3 --> v4:
- Removed rte_pci_get_iommu_class api declaration. Now that
sits into separate patch [03/12].
lib/librte_eal/bsdapp/eal/eal_pci.c |
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c
b/lib/librte_eal
Check iova mode and accordingly map iova to pa or va.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
---
lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal
- Moving late bus scanning to up..just after eal_parsing.
- Mapping mode would be default for bsdapp. It supports
only one pass through mode (RTE_KDRV_NIC_UIO)
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
---
lib/librte_eal/bsdapp/eal/eal.c | 15
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
Reviewed-by: Maxime Coquelin
---
lib/librte_eal/common/rte_malloc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_malloc.c
b/lib
On Fri, Mar 31, 2017 at 03:47:49PM +0530, Shreyansh Jain wrote:
> Mempool test currently supports:
> * ring_mp_mc
> * stack
>
> In case a new mempool handler is added, there are multiple options
> for supporting that in the mempool autotest:
> 1. Like the patch below, adding a new default pool o
(Fixes: 6da9d2457 event/octeontx: add mailbox support)
Signed-off-by: Santosh Shukla
---
drivers/event/octeontx/ssovf_mbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/octeontx/ssovf_mbox.c
b/drivers/event/octeontx/ssovf_mbox.c
index 7394a3a97..0d4fd392a
hdev API called _get_preferred_pool(), where PMD driver
gets a chance to advertise their pool capability to the application. And based
on that hint- application creates pools for that driver.
Santosh Shukla (2):
eal: Introducing option to set mempool handle
ether/ethdev: Allow pmd to advertise preferred
CONFIG_RTE_MEMPOOL_DEFAULT_OPS=.
So Introducing get_preferred_pool() API. Which allows PMD driver
to advertise their pool capability to Application.
Based on that hint, Application creates separate pool for
That driver.
Signed-off-by: Santosh Shukla
---
lib/librte_ether/rte_ethdev.c | 16
There is no way that either of NIC's could use their choice
of mempool handle.
Because Currently mempool handle programmed in static way i.e.
User has to set pool handle name in CONFIG_RTE_MEMPOOL_OPS_DEFAULT=''
So introducing eal option --pkt-mempool="".
Signed-off-by: Sa
the version
to which it is merged
#86: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:822:
+#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 2, 0)
Thanks.
[1] http://dpdk.org/dev/patchwork/patch/24549/
Santosh Shukla (10):
bsdapp/eal_pci: get iommu class
linuxapp/eal_pci: get iommu class
bus:
Introducing rte_pci_get_iommu_class API which helps to get iommu class
of PCI device on the bus and returns preferred iova mapping mode for
that bus.
Bsdapp case returns default iova mode.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/bsdapp/eal/eal_pci.c
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal_pci.c | 38 +
lib/librte_eal/linuxapp/eal/eal_vfio.c | 23 +++
lib/librte_eal/linuxapp/eal/eal_vfio.h | 4 +++
lib/librte_eal/linuxa
In the case of user don't want to use bus iova scheme and want
to override.
For that, Adding eal option --iova-mode= where valid input
string is 'pa' or 'va'.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/common/
Currently there is noway to detect iova address mapping scheme for a
device on the bus.
API(rte_bus_get_iommu_class) helps to automatically detect and select
appropriate iova mapping scheme for iommu capable device on that bus.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib
- Moving late bus scanning to up..just after eal_parsing.
- Mapping mode would be default for bsdapp. It supports
only one pass through mode (RTE_KDRV_NIC_UIO)
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/bsdapp/eal/eal.c | 24
- Moving late bus scanning to up..just after eal_parsing.
- Detect iova mapping mode based on user provided eal option
(rte_eal_iova_mode) and result of rte_bus_scan_iommu_class.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal.c | 24
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c
b/lib/librte_eal/linuxapp/eal/eal_memory.c
Check iova mode and accordingly map iova to pa or va.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c
b/lib/librte_eal
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_mempool/rte_mempool.h | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
Check iova mode and accordingly return phy addr.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_eal/common/rte_malloc.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_malloc.c
b/lib/librte_eal/common/rte_malloc.c
Let test_mbuf alloc and free mempool.
Cc: sta...@dpdk.org
Signed-off-by: Santosh Shukla
---
v1 --> v2:
- Clubed v1 two patch into 1 patch per Olivier review comment [1]
[1] http://dpdk.org/dev/patchwork/patch/24237/
test/test/test_mbuf.c |
empool/rte_mempool.h:269:
+#define MEMPOOL_F_POOL_CONTIG0x0040 /**< Detect physcially contiguous objs
*/
total: 0 errors, 2 warnings, 21 lines checked
Thanks.
Santosh Shukla (4):
mempool: get the external mempool capability
mempool: detect physical contiguous object in pool
mempoo
Allow external mempool to advertise its capability.
A handler been introduced called rte_mempool_ops_get_hw_cap.
- Upon ->get_hw_cap call, mempool driver will advertise
capability by returning flag.
- Common layer updates flag value in 'mp->flags'.
Signed-off-by: Santosh Shukl
/end address to HW pool manager.
Signed-off-by: Santosh Shukla
Signed-off-by: Jerin Jacob
---
lib/librte_mempool/rte_mempool.c | 2 ++
lib/librte_mempool/rte_mempool.h | 24
lib/librte_mempool/rte_mempool_ops.c | 13 +
lib
1 - 100 of 533 matches
Mail list logo
