RE: [PATCH 0/5] dma/ioat: fix issues with stopping and restarting device

2023-01-16 Thread Walsh, Conor
Hi Bruce, This patchset breaks the dmadev autotest for IOAT on IceLake. Trace below: ### Test dmadev instance 0 [:00:01.0] IOAT.status: ACTIVE [0x100242880] DMA Dev 0: Running copy Tests Ops submitted: 85120Ops completed: 85120Errors: 0 DMA Dev 0: Running stop-start Tests IOAT.status

RE: [PATCH v2 2/6] dma/ioat: fix incorrectly set indexes after restart

2023-01-18 Thread Walsh, Conor
> As part of the process of restarting a dma instance, the IOAT driver > will reset the HW addresses and state values. The read and write > indexes for SW use need to be similarly reset to keep HW and SW in > sync. > > Fixes: 583f046dd404 ("dma/ioat: add start and stop") > Cc: conor.wa...@intel.co

RE: [PATCH v2 3/6] dma/ioat: fix incorrect error reporting on restart

2023-01-18 Thread Walsh, Conor
> When the DMA device was stopped and restarted by the driver, the control > register specifying the behaviour on error was not getting correctly > reset. This caused unit tests to fail as explicitly introduced errors > were got getting reported back. > > Fix by moving the setting of the register

RE: [PATCH v2 4/6] test/dmadev: check result for device stop

2023-01-18 Thread Walsh, Conor
> The DMA device stop API can return an error value so check that return > value when running dmadev unit tests. > > Signed-off-by: Bruce Richardson Reviewed-by: Conor Walsh

RE: [PATCH v2 1/6] dma/ioat: fix device stop if no copies done

2023-01-18 Thread Walsh, Conor
> The HW DMA devices supported by IOAT driver do not transition to > the "active" state until the first operation is started by the HW. > Therefore, if the user calls "rte_dma_stop()" on a device without > triggering any operations, the sequence of commands to be sent to > the HW is different, as i

RE: [PATCH v1] examples/l3fwd: fix for coverity scan

2023-01-18 Thread Walsh, Conor
> This patch fixes (Logically dead code) coverity issue. > This patch also fixes (Uninitialized scalar variable) coverity issue. > > Coverity issue: 381687 > Coverity issue: 381686 > Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method") > > Signed-off-by: Mohammad Iqbal Ahmad Acke

RE: no printf in drivers code

2023-02-03 Thread Walsh, Conor
> Hello, > > We have too many drivers using printf() instead of rte_log(). > Please propose a plan to replace or remove the calls to printf(). > If no plan, I could propose one but you may not like it :) > > Affected drivers are: > baseband/acc > bus/dpaa > bus/fslmc > cry

Re: [dpdk-dev] [PATCH v7 1/5] examples/l3fwd: fix LPM IPv6 subnets

2021-04-15 Thread Walsh, Conor
> > > > The IPv6 subnets used were not within the 2001:200::/48 subnet > > {{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 48, 0}, > {{32, 1, 2, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0}, 48, 1}, > etc... > > Err... all those subnets were exactly == 2001:200::/48. > Is the issue that the examp

Re: [dpdk-dev] [PATCH v7 1/5] examples/l3fwd: fix LPM IPv6 subnets

2021-04-15 Thread Walsh, Conor
> > > > The IPv6 subnets used were not within the 2001:200::/48 subnet > > > > > > {{32, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 48, 0}, > > > {{32, 1, 2, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0}, 48, 1}, > > > etc... > > > > > > Err... all those subnets were exactly == 2001:200::/48. > > > I

Re: [dpdk-dev] [PATCH 4/4] examples/l3fwd: make data struct to be memory efficient

2021-04-26 Thread Walsh, Conor
> >> There are some holes in data struct lcore_conf. The holes are > >> due to alignment requirement. > >> > >> For struct lcore_rx_queue, there is no need to make every element > >> of this type to be cache line aligned, because the data is not > >> shared between cores. > >> > >> Member len of s

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-05-06 Thread Walsh, Conor
> >>> 21/04/2021 11:11, Conor Walsh: > + The following will include a snippet from the skeleton sample > app:: > + > + .. literalinclude:: ../../../examples/skeleton/basicfwd.c > +:language: c > +:start-after: Display the port

Re: [dpdk-dev] [PATCH] examples/l3fwd: remove useless reloads in FIB main loop

2021-07-06 Thread Walsh, Conor
> > This patch aligns the l3fwd FIB code with the changes made to LPM in > > commit 74fb854a3de6 ("examples/l3fwd: remove useless reloads in LPM > > main loop"). > > This change ensures the compiler knows that the lcore config variables > > are constant values and the compiler will then optimize th

RE: [PATCH] dma/idxd: fix return value for pci device commands

2022-06-07 Thread Walsh, Conor
> Subject: [PATCH] dma/idxd: fix return value for pci device commands > > When sending a command to an idxd device via pci bar, the response from > HW is checked to ensure it was successful. The response was incorrectly > being negated before being returned by the function, meaning error codes >

RE: [PATCH] dma/idxd: fix AVX2 code in non-datapath functions

2022-06-20 Thread Walsh, Conor
> While all systems which will use the idxd driver for hardware will > support AVX2, if the driver is present the initialization functions e.g. > to register logs, will be called on all systems - irrespective of HW > support. This can cause issues if the system running DPDK does not have > AVX2, an

RE: [PATCH] dma/idxd: fix missing default for workqueue options

2022-06-20 Thread Walsh, Conor
> When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the > default value used by argparse is None. This leads to later errors which > are expecting an array value: > > TypeError: 'NoneType' object is not iterable > > This is fixed by specifying that the empty array should be the

RE: [PATCH 1/2] rawdev, dmadev: remove passive voice in function doc

2022-06-23 Thread Walsh, Conor
> Remove extraneous phrase "This API is used to" and use > active instead of passive voice when describing a function. > > Signed-off-by: Stephen Hemminger > --- > drivers/raw/ioat/rte_ioat_rawdev.h | 2 +- > lib/dmadev/rte_dmadev.h| 2 +- > 2 files changed, 2 insertions(+), 2 deleti

Re: [dpdk-dev] [PATCH v5 3/5] examples/l3fwd: add FIB infrastructure

2021-04-01 Thread Walsh, Conor
> > > @@ -310,7 +328,10 @@ print_usage(const char *prgname) > > " Valid only if --mode=eventdev\n" > > " --event-eth-rxqs: Number of ethernet RX queues per > device.\n" > > "Default: 1\n" > > - "

Re: [dpdk-dev] [PATCH v6 3/5] examples/l3fwd: add FIB infrastructure

2021-04-06 Thread Walsh, Conor
> > Acked-by: Anatoly Burako > > --- > > Burakov* Sorry about that! > > > break; > > > > case 'L': > > - l3fwd_lpm_on = 1; > > + if (lookup_mode != L3FWD_LOOKUP_DEFAULT) { > > + fprintf(stderr, "Onl

Re: [dpdk-dev] [PATCH v2] usertools/telemetry: add list of available file-prefixes

2021-10-13 Thread Walsh, Conor
This patch is also compatible with the v8 of the "improve telemetry support with in-memory mode" patchset. Thanks, Conor. > -Original Message- > From: Walsh, Conor > Sent: Monday 11 October 2021 10:54 > To: Power, Ciara ; Richardson, Bruce > > Cc: dev@dpdk.

Re: [dpdk-dev] [PATCH v8 1/4] eal: limit telemetry to primary processes

2021-10-13 Thread Walsh, Conor
> From: dev On Behalf Of Bruce Richardson > Sent: Tuesday 12 October 2021 17:39 > To: dev@dpdk.org > Cc: Power, Ciara ; David Marchand > ; Burakov, Anatoly > ; Kevin Traynor ; > Richardson, Bruce > Subject: [dpdk-dev] [PATCH v8 1/4] eal: limit telemetry to primary processes > > Telemetry interfa

Re: [dpdk-dev] [PATCH v8 2/4] telemetry: fix socket path conflicts for in-memory mode

2021-10-13 Thread Walsh, Conor
> From: dev On Behalf Of Bruce Richardson > Sent: Tuesday 12 October 2021 17:39 > To: dev@dpdk.org > Cc: Power, Ciara ; David Marchand > ; Burakov, Anatoly > ; Kevin Traynor ; > Richardson, Bruce > Subject: [dpdk-dev] [PATCH v8 2/4] telemetry: fix socket path conflicts for > in- > memory mode >

Re: [dpdk-dev] [PATCH v8 3/4] usertools/dpdk-telemetry: connect to separate instances

2021-10-13 Thread Walsh, Conor
> From: dev On Behalf Of Bruce Richardson > Sent: Tuesday 12 October 2021 17:39 > To: dev@dpdk.org > Cc: Power, Ciara ; David Marchand > ; Burakov, Anatoly > ; Kevin Traynor ; > Richardson, Bruce > Subject: [dpdk-dev] [PATCH v8 3/4] usertools/dpdk-telemetry: connect to > separate instances > > F

Re: [dpdk-dev] [PATCH v8 4/4] usertools/dpdk-telemetry: provide info on available sockets

2021-10-13 Thread Walsh, Conor
> From: dev On Behalf Of Bruce Richardson > Sent: Tuesday 12 October 2021 17:39 > To: dev@dpdk.org > Cc: Power, Ciara ; David Marchand > ; Burakov, Anatoly > ; Kevin Traynor ; > Richardson, Bruce > Subject: [dpdk-dev] [PATCH v8 4/4] usertools/dpdk-telemetry: provide info > on available sockets >

Re: [dpdk-dev] [PATCH v8 00/12] dma: add dmadev driver for ioat devices

2021-10-19 Thread Walsh, Conor
This patchset is compatible with v9 of the "add dmadev driver for idxd devices" patchset (series-19786) Thanks, Conor. > This patchset adds a dmadev driver and associated documentation to > support > Intel QuickData Technology devices, part of the Intel I/O Acceleration > Technology (Intel I/OAT

Re: [dpdk-dev] [PATCH v8 00/12] dma: add dmadev driver for ioat devices

2021-10-19 Thread Walsh, Conor
This patchset is compatible with v10 of the "add dmadev driver for idxd devices" patchset (series-19797) Thanks, Conor. > This patchset is compatible with v9 of the "add dmadev driver for idxd > devices" patchset (series-19786) > > Thanks, > Conor. > > > This patchset adds a dmadev driver and a

Re: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array

2021-10-20 Thread Walsh, Conor
> Subject: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array > > No need to expose rte_dma_devices out of the dmadev library. > Existing helpers should be enough, and inlines make use of > rte_dma_fp_objs. > > Signed-off-by: David Marchand > --- The devices array is not needed by the drivers.

Re: [dpdk-dev] [PATCH v2 2/3] dmadev: enable build on Windows

2021-10-20 Thread Walsh, Conor
> From: dev On Behalf Of Bruce Richardson > Sent: Wednesday 20 October 2021 12:26 > To: dev@dpdk.org > Cc: david.march...@redhat.com; dmitry.kozl...@gmail.com; > navas...@linux.microsoft.com; dmit...@microsoft.com; Kadam, Pallavi > ; Richardson, Bruce > ; Chengwen Feng > > Subject: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v8 00/12] dma: add dmadev driver for ioat devices

2021-10-20 Thread Walsh, Conor
This patchset is compatible with v11 of the "add dmadev driver for idxd devices" patchset (series-19848) > This patchset is compatible with v10 of the "add dmadev driver for idxd > devices" patchset (series-19797) > > Thanks, > Conor. > > > This patchset is compatible with v9 of the "add dmadev

Re: [dpdk-dev] [PATCH v2 3/3] dmadev: fix compile error in debug mode

2021-10-21 Thread Walsh, Conor
> From: Laatz, Kevin > Sent: Thursday 21 October 2021 15:04 > To: Chengwen Feng ; dev@dpdk.org > Cc: david.march...@redhat.com; m...@ashroe.eu; Walsh, Conor > ; Richardson, Bruce > Subject: Re: [PATCH v2 3/3] dmadev: fix compile error in debug mode > > On 21/10/2021 13

Re: [dpdk-dev] [PATCH v2 2/3] app/test: add check for DMA info get API

2021-10-21 Thread Walsh, Conor
> From: Laatz, Kevin > Sent: Thursday 21 October 2021 15:04 > To: Chengwen Feng ; dev@dpdk.org > Cc: david.march...@redhat.com; m...@ashroe.eu; Walsh, Conor > ; Richardson, Bruce > Subject: Re: [PATCH v2 2/3] app/test: add check for DMA info get API > > On 21/10/2021 13

Re: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check

2021-10-27 Thread Walsh, Conor
> From: dev On Behalf Of Kevin Laatz > Sent: Tuesday 26 October 2021 15:21 > To: dev@dpdk.org > Cc: Richardson, Bruce ; Laatz, Kevin > > Subject: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status > check > > When checking if the DMA device is active, the result of the operand will

Re: [dpdk-dev] [PATCH] doc: two typos in documentation

2021-10-28 Thread Walsh, Conor
Hi Henry, When correcting these tags the corresponding tags within the code must also be updated to match or it will break the literalinclude link and cause the warnings shown below. doc/guides/sample_app_ug/dma.rst:240: WARNING: end-before pattern not found: >8 End of starting to process for e

Re: [dpdk-dev] [PATCH v2] devtools: clarify that lines up to 100 characters are ok

2021-10-28 Thread Walsh, Conor
> From: dev On Behalf Of Bruce Richardson > Sent: Wednesday 20 October 2021 15:26 > To: dev@dpdk.org > Cc: Andrew Rybchenko ; Richardson, > Bruce > Subject: [dpdk-dev] [PATCH v2] devtools: clarify that lines up to 100 > characters are ok > > Since we allow line lengths of up to 100, and the CI c

Re: [dpdk-dev] [PATCH] devtools: forbid additions of __reserved

2021-10-28 Thread Walsh, Conor
> From: dev On Behalf Of David Marchand > Sent: Saturday 23 October 2021 11:29 > To: dev@dpdk.org > Cc: dmitry.kozl...@gmail.com; Thomas Monjalon > Subject: [dpdk-dev] [PATCH] devtools: forbid additions of __reserved > > __reserved is a reserved keyword in Windows system headers. > > Signed-off

Re: [dpdk-dev] [PATCH v2] doc: fix CI typo warnings

2021-10-28 Thread Walsh, Conor
> From: dev On Behalf Of Ray Kinsella > Sent: Tuesday 10 August 2021 15:34 > To: dev@dpdk.org > Cc: Richardson, Bruce ; Mcnamara, John > ; aaron.con...@redhat.com; m...@ashroe.eu > Subject: [dpdk-dev] [PATCH v2] doc: fix CI typo warnings > > Fix documentation typos that are generating spurious

Re: [dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment

2021-11-03 Thread Walsh, Conor
> From: Joyce Kong > Sent: Wednesday 3 November 2021 02:41 > To: Ori Kam ; Mcnamara, John > ; Walsh, Conor ; > Conor Fogarty > Cc: dev@dpdk.org; n...@arm.com; sta...@dpdk.org > Subject: [PATCH v1] examples/flow_filtering: fix wrong comment > > Change the 'I

Re: [dpdk-dev] [PATCH v1] examples/flow_filtering: fix wrong comment

2021-11-04 Thread Walsh, Conor
> From: Joyce Kong > Sent: Thursday 4 November 2021 07:34 > To: Walsh, Conor ; Ori Kam ; > Mcnamara, John ; Conor Fogarty > > Cc: dev@dpdk.org; nd ; sta...@dpdk.org > Subject: RE: [PATCH v1] examples/flow_filtering: fix wrong comment > > > > >

Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: fix wrong comment

2021-11-04 Thread Walsh, Conor
> From: Joyce Kong > Sent: Thursday 4 November 2021 07:32 > To: Ori Kam ; Mcnamara, John > ; Conor Fogarty ; > Walsh, Conor > Cc: dev@dpdk.org; n...@arm.com; sta...@dpdk.org > Subject: [PATCH v2] examples/flow_filtering: fix wrong comment > > Change the 'I

Re: [dpdk-dev] [PATCH v4 1/3] examples/l3fwd: increase number of routes

2021-11-04 Thread Walsh, Conor
> From: dev On Behalf Of > pbhagavat...@marvell.com > Sent: Sunday 3 October 2021 21:25 > To: david.march...@redhat.com; jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v4 1/3] examples/l3fwd: increase number of > routes > > From: Pavan Nikhilesh > > Increas

Re: [dpdk-dev] [PATCH 2/3] examples/l3fwd: print port bdf when adding routes

2021-11-04 Thread Walsh, Conor
> From: dev On Behalf Of > pbhagavat...@marvell.com > Sent: Sunday 3 October 2021 21:11 > To: jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH 2/3] examples/l3fwd: print port bdf when > adding routes > > From: Pavan Nikhilesh > > Since the number of Ethernet

Re: [dpdk-dev] [PATCH v4] examples/l3fwd: ipv4 and udp/tcp cksum verification through software

2021-11-04 Thread Walsh, Conor
> From: dev On Behalf Of Usama Nadeem > Sent: Thursday 14 October 2021 19:43 > To: tho...@monjalon.net > Cc: dev@dpdk.org; Usama Nadeem > Subject: [dpdk-dev] [PATCH v4] examples/l3fwd: ipv4 and udp/tcp cksum > verification through software > > checks if ipv4 and udptcp cksum offload capability a

Re: [dpdk-dev] [PATCH v5 1/3] examples/l3fwd: increase number of routes

2021-11-05 Thread Walsh, Conor
> From: pbhagavat...@marvell.com > Sent: Friday 5 November 2021 08:39 > To: Walsh, Conor ; david.march...@redhat.com; > jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v5 1/3] examples/l3fwd: increase number of > routes >

Re: [dpdk-dev] [PATCH v5 2/3] examples/l3fwd: print port bdf when adding routes

2021-11-05 Thread Walsh, Conor
> From: pbhagavat...@marvell.com > Sent: Friday 5 November 2021 08:39 > To: Walsh, Conor ; david.march...@redhat.com; > jer...@marvell.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v5 2/3] examples/l3fwd: print port bdf when > adding routes >

Re: [dpdk-dev] [PATCH 1/2] doc: add programmer's guide for the RIB library

2021-11-09 Thread Walsh, Conor
> From: dev On Behalf Of Vladimir Medvedkin > Sent: Monday 8 November 2021 17:37 > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] doc: add programmer's guide for the RIB > library > > Currently, programmer's guide for the RIB library is missing. > This commit adds it. > > Signed-off-by: Vlad

Re: [dpdk-dev] [PATCH 2/2] doc: add programmer's guide for the FIB library

2021-11-09 Thread Walsh, Conor
> From: dev On Behalf Of Vladimir Medvedkin > Sent: Monday 8 November 2021 17:37 > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] doc: add programmer's guide for the FIB > library > > Currently, programmer's guide for the FIB library is missing. > This commit adds it. > > Signed-off-by: Vlad

Re: [dpdk-dev] [PATCH v5 12/12] raw/ioat: deprecate ioat rawdev driver

2021-09-27 Thread Walsh, Conor
> From: Richardson, Bruce > Sent: Friday 24 September 2021 17:57 > To: Walsh, Conor > Cc: fengcheng...@huawei.com; jer...@marvell.com; Laatz, Kevin > ; dev@dpdk.org > Subject: Re: [PATCH v5 12/12] raw/ioat: deprecate ioat rawdev driver > > On Fri, Sep 24, 2021 at 02:33

Re: [dpdk-dev] [PATCH] doc/sample_app_ug: use code snippets in sample app guides

2021-07-16 Thread Walsh, Conor
> Hello, Hi David, thanks for your reply I will be handling this as Conor Fogarty is OOO. > > On Wed, Jul 14, 2021 at 11:59 AM Conor Fogarty > wrote: > > > > Currently the sample app user guides use hard coded code snippets, > > this patch changes these to use literalinclude which will dynamica

Re: [dpdk-dev] [PATCH v13 4/6] dmadev: introduce DMA device library implementation

2021-08-05 Thread Walsh, Conor
> This patch introduce DMA device library implementation which includes > configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng > Acked-by: Bruce Richardson > Acked-by: Morten Brørup > --- > config/rte_config.h | 3 + > lib/dmadev/meson.build | 1 + >

Re: [dpdk-dev] [PATCH 2/2] fib: announce experimental tag removal of the fib API

2021-08-05 Thread Walsh, Conor
> This patch announces the experimental tag removal of all fib APIs, > which have been experimental for 2 years. > API will be promoted to stable in DPDK 21.11 > > Signed-off-by: Vladimir Medvedkin > --- > doc/guides/rel_notes/deprecation.rst | 2 ++ > 1 file changed, 2 insertions(+) Acked-by:

Re: [dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide

2021-08-10 Thread Walsh, Conor
[snip] Hi Chengwen, I have included some feedback to improve the grammar and readability of the docs inline. > +Device Management > +- > + > +Device Creation > +~~~ > + > +Physical DMA controller is discovered during the PCI probe/enumeration of ^ "controllers are" in

RE: [PATCH 7/7] lib/power: fix unused but set variables

2021-11-12 Thread Walsh, Conor
Hi David, I will make those changes to the commit logs and respin them. I'll also drop this patch from the set. Thanks, Conor. > Hello Conor, > > > On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh > wrote: > > > > This patch removes the tot_ppi variable from the update_stats function > > within em

RE: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Walsh, Conor
> On 11/12/2021 2:01 PM, Conor Walsh wrote: > > static void > > vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) > > { > > + #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > int completed = 0; > > + #endif > > vmxnet3_comp_ring_t *comp_ring = &txq->comp_ring; > > struct Vmxnet3_TxCompDes

RE: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Walsh, Conor
> Subject: Re: [PATCH 5/7] drivers/net: fix unused but set variables > > On Fri, Nov 12, 2021 at 5:18 PM Ferruh Yigit wrote: > > > > On 11/12/2021 2:01 PM, Conor Walsh wrote: > > > static void > > > vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) > > > { > > > + #ifdef RTE_LIBRTE_VMXNET

RE: [PATCH 5/7] drivers/net: fix unused but set variables

2021-11-12 Thread Walsh, Conor
> On Fri, 12 Nov 2021 16:38:37 + > "Walsh, Conor" wrote: > > > Would something along the lines of this make more sense? > > > > #ifdef RTE_LIBRTE_VMXNET3_DEBUG_TX > > completed += vmxnet3_unmap_pkt(tcd->txdIdx, txq); > > #else

RE: [PATCH v2] hash: fix thash gfni implementation

2021-11-16 Thread Walsh, Conor
> From: David Marchand > Sent: Tuesday 16 November 2021 13:54 > To: Medvedkin, Vladimir > Cc: dev ; Thomas Monjalon ; > Ananyev, Konstantin ; Lance Richardson > ; j...@dpdk.org; Ji, Kai ; > Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > > Subject: Re: [PATCH v2] hash: fix thash gfni impl

RE: [PATCH v1 1/3] fix PMD wording typo

2021-11-22 Thread Walsh, Conor
Hi Sean, A few minor nits, TBH not sure if they should be changed in this patch as this patch is just removing "driver" and correcting capitalisation of PMD. > diff --git a/drivers/net/hns3/hns3_ethdev.h > b/drivers/net/hns3/hns3_ethdev.h > index 6d30125dcc..488fe8dbbc 100644 > --- a/drivers/

RE: [PATCH v1 2/3] fix 'the the' typo

2021-11-22 Thread Walsh, Conor
Reviewed-by: Conor Walsh

RE: [PATCH v1 3/3] doc: capitalise PMD

2021-11-22 Thread Walsh, Conor
Reviewed-by: Conor Walsh

RE: [PATCH] dma/ioat: remove printf within ioat driver

2023-02-07 Thread Walsh, Conor
> On Fri, Feb 03, 2023 at 04:35:14PM +, Conor Walsh wrote: > > rte_log should be used instead of printf within the drivers this patch > > changes a printf within the ioat dma driver's start function to an rte log. > > The printfs within ioat's dump function will be retained. > > > > Signed-off-

Re: [dpdk-dev] [PATCH] usertools/telemetry: add listing of available file prefixes

2021-10-08 Thread Walsh, Conor
> > >+ > >+def list_fp(): > >+""" List all available file-prefixes to user """ > >+print("Valid file-prefixes:\n") > > Nit: I think it might be cleaner to move this down to just before the file > prefixes print out, so it doesn't print out when no apps are available. > > >+path = g

Re: [dpdk-dev] [PATCH v2] usertools/telemetry: add list of available file-prefixes

2021-10-11 Thread Walsh, Conor
I forgot to include the changelog. v2: - Only print valid prefixes list header if telemetry available apps are available. - Updated to v7 of the "improve telemetry support with in-memory mode" patchset. Thanks, Conor.

Re: [dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide

2021-08-13 Thread Walsh, Conor
Hi Chengwen, v15 looks good to me. Thanks for the changes, Conor. > Hi Conor, > > Already sent v15, Most of feedback modified, unmodified inline > > Thanks. > > On 2021/8/10 23:27, Walsh, Conor wrote: > > [snip] > > > > Hi Chengwen, > > I have

Re: [dpdk-dev] [PATCH v19 7/7] app/test: add dmadev API test

2021-09-02 Thread Walsh, Conor
Hi Chengwen, The output from the API tests is not very straightforward to interpret if you are not familiar with these tests. Could we change the log level of the dmadev library before and after the API tests using something similar to The code I have included inline below? > +static int > +te

Re: [dpdk-dev] [PATCH v19 7/7] app/test: add dmadev API test

2021-09-03 Thread Walsh, Conor
nion either way, I wanted to improve usability. With or without this change/cleanup: Reviewed-by: Conor Walsh > > > On 2021/9/2 22:11, Walsh, Conor wrote: > > Hi Chengwen, > > > > The output from the API tests is not very straightforward to interpret if > > you > are

Re: [dpdk-dev] [PATCH v2 05/10] dma/ioat: add start and stop functions

2021-09-07 Thread Walsh, Conor
> > +/* Stop a configured device. */ > > +static int > > +ioat_dev_stop(struct rte_dmadev *dev) > > +{ > > + struct ioat_dmadev *ioat = dev->dev_private; > > + > > + ioat->regs->chancmd = IOAT_CHANCMD_SUSPEND; > > + /* Allow the device time to suspend itself. */ > > + rte_delay_ms(1); > >

Re: [dpdk-dev] [PATCH v21 4/7] dmadev: introduce DMA device library implementation

2021-09-08 Thread Walsh, Conor
Hi Chengwen, While testing the IOAT driver I realised that we hadn't implemented the new RTE_DMADEV_ALL_VCHAN flag for stats. Rather than every driver that only supports 1 vchan enabling support for this flag it would probably be better to catch it in the library as shown below. Thanks, Conor

Re: [dpdk-dev] [PATCH v3 1/8] dmadev: add channel status check for testing use

2021-09-08 Thread Walsh, Conor
> Subject: [PATCH v3 1/8] dmadev: add channel status check for testing use > > Add in a function to check if a device or vchan has completed all jobs > assigned to it, without gathering in the results. This is primarily for > use in testing, to allow the hardware to be in a known-state prior to

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-08 Thread Walsh, Conor
> Subject: [PATCH v3 2/8] dmadev: add burst capacity API > > From: Kevin Laatz > > Add a burst capacity check API to the dmadev library. This API is useful to > applications which need to how many descriptors can be enqueued in the > current batch. For example, it could be used to determine wh

Re: [dpdk-dev] [PATCH v3 8/8] app/test: add dmadev burst capacity API test

2021-09-08 Thread Walsh, Conor
> Subject: [PATCH v3 8/8] app/test: add dmadev burst capacity API test > > From: Kevin Laatz > > Add a test case to validate the functionality of drivers' burst capacity > API implementations. > > Signed-off-by: Kevin Laatz > Signed-off-by: Bruce Richardson > --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v3 3/5] examples/l3fwd: add FIB infrastructure

2021-03-08 Thread Walsh, Conor
> > #define CMD_LINE_OPT_CONFIG "config" > > @@ -596,6 +611,10 @@ parse_args(int argc, char **argv) > > l3fwd_lpm_on = 1; > > break; > > > > + case 'F': > > + l3fwd_fib_on = 1; > > + break; > > + > >

Re: [dpdk-dev] [PATCH v3 4/5] examples/l3fwd: implement FIB lookup method

2021-03-08 Thread Walsh, Conor
> From: Burakov, Anatoly > Sent: Wednesday 3 March 2021 11:53 > To: Walsh, Conor ; jer...@marvell.com; > step...@networkplumber.org; Iremonger, Bernard > ; Ananyev, Konstantin > ; Medvedkin, Vladimir > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 4/5] ex

Re: [dpdk-dev] [PATCH v3 4/5] examples/l3fwd: implement FIB lookup method

2021-03-08 Thread Walsh, Conor
> Hi Conor, > > Please see comment below > > > +/* > > + * If the machine does not have SSE, NEON or PPC 64 then the packets > > + * are sent one at a time using send_single_packet() > > + */ > > +#if !defined FIB_SEND_MULTI > > +static inline void > > +fib_send_single(int nb_tx, struct lcore_

Re: [dpdk-dev] [PATCH v4 4/5] examples/l3fwd: implement FIB lookup method

2021-03-15 Thread Walsh, Conor
Hi Vladimir, > > + /* Add IPv4 and IPv6 hops to one array depending on type. */ > > + for (i = 0; i < nb_rx; i++) { > > + if (type_arr[i]) > > + nh = (uint16_t)hopsv4[ipv4_arr_assem++]; > > + else > > + nh = (uint16_t)hopsv6[ipv6_arr_as

RE: [PATCH 1/3] app/test: fix missing checks for DMA device capacity

2022-02-17 Thread Walsh, Conor
Reviewed-by: Conor Walsh

RE: [PATCH] dmadev: add missing header include

2022-02-22 Thread Walsh, Conor
> From: Thomas Monjalon > Sent: Tuesday 22 February 2022 11:41 > To: dev@dpdk.org > Cc: Richardson, Bruce ; sta...@dpdk.org; > Chengwen Feng ; Laatz, Kevin > ; Morten Brørup ; > Walsh, Conor > Subject: [PATCH] dmadev: add missing header include > > When checking C+

RE: [PATCH] examples/l3fwd: resolve stack buffer overflow issue

2022-03-07 Thread Walsh, Conor
dev@dpdk.org; Walsh, Conor > ; david.march...@redhat.com > Subject: RE: [PATCH] examples/l3fwd: resolve stack buffer overflow issue > > Ping.. > > -Original Message- > From: Rahul Bhansali > Sent: Tuesday, January 11, 2022 6:20 PM > To: dev@dpdk.org; conor.wa.

RE: [PATCH v3] dmadev: add telemetry support

2022-04-01 Thread Walsh, Conor
> From: Bruce Richardson > Sent: Friday 1 April 2022 11:50 > To: Morrissey, Sean > Cc: Chengwen Feng ; Laatz, Kevin > ; dev@dpdk.org; Pai G, Sunil > > Subject: Re: [PATCH v3] dmadev: add telemetry support > > On Fri, Apr 01, 2022 at 10:24:02AM +, Sean Morrissey wrote: > > Telemetry commands

Re: [dpdk-dev] [PATCH] raw/ioat: fix bus requiring virtual addressing when no devs

2021-05-07 Thread Walsh, Conor
> > > Reported-by: Harry van Haaren > > > Signed-off-by: Bruce Richardson > > > --- > > > > Tested-by: Anatoly Burakov > > Tested-by: Harry van Haaren I was having an issue while running l3fwd after rc2 where I had to force IOVA mode to PA, this patch fixes that issue. Tested-by: Conor Wals

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-09 Thread Walsh, Conor
d' was declared here struct rte_ring_zc_data zcd; ^~~ cc1: all warnings being treated as errors [2340/2407] Compiling C object drivers/libtmp_...ontx2.a.p/event_octeontx2_otx2_worker_dual.c.o ninja: build stopped: subcommand failed. Thanks, Conor. > From: Ho

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-09 Thread Walsh, Conor
Hi Honnappa, > From: Honnappa Nagarahalli > Sent: Monday 9 November 2020 16:45 > To: Walsh, Conor ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Chen, LingliX ; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH v1] app/test: zcd needs to be initialised to fi

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-09 Thread Walsh, Conor
> From: Honnappa Nagarahalli > Sent: Monday 9 November 2020 17:24 > To: Walsh, Conor ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Chen, LingliX ; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH v1] app/test: zcd needs to be initialised to fi

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-10 Thread Walsh, Conor
> From: Honnappa Nagarahalli > Sent: Monday 9 November 2020 22:44 > To: Walsh, Conor ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Chen, LingliX ; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH v1] app/test: zcd needs to be initialised to fi

Re: [dpdk-dev] [PATCH v1] build: add Wformat to fix gcc compile error

2020-11-13 Thread Walsh, Conor
Thanks for your reply Thomas, that's no problem. I will expand the explanation for this patch when I push a v2, v2 will hopefully also address the issues it caused with the icc build. /Conor > -Original Message- > From: Thomas Monjalon > Sent: Thursday 12 November 2020 18:

Re: [dpdk-dev] [PATCH v2 0/2] build: add Wformat to fix gcc compile warnings and format fixes

2020-11-19 Thread Walsh, Conor
Thank you for your feedback Luca, I pushed a v3 that now has stable cc'ed. /Conor > From: Luca Boccassi > Sent: Wednesday 18 November 2020 18:38 > To: Walsh, Conor ; Richardson, Bruce > ; ajit.khapa...@broadcom.com; > somnath.ko...@broadcom.com; stuart.schac...@broadcom.com

Re: [dpdk-dev] [PATCH 1/6] usertools/setup: remove make based build

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Patch tested. Thanks, Conor. > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH 1/6] usertools/setup: r

Re: [dpdk-dev] [PATCH 2/6] usertools/setup: remove inserting custom kernel modules

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Patch tested. Thanks, Conor. > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [

Re: [dpdk-dev] [PATCH 3/6] usertools/setup: remove running built applications

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Patch tested. Thanks, Conor. > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [

Re: [dpdk-dev] [PATCH 4/6] usertools/setup: remove hugepage functions

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Patch tested. Thanks, Conor. > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH 4/6] usertools/setup: r

Re: [dpdk-dev] [PATCH v2 1/6] usertools/setup: remove make based build

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Tested V2 patch, the docs also build successfully. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 2020 14:18 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ; Wa

Re: [dpdk-dev] [PATCH v2 2/6] usertools/setup: remove inserting custom kernel modules

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Tested V2 patch, the docs also build successfully. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 2020 14:18 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ; Wa

Re: [dpdk-dev] [PATCH v2 3/6] usertools/setup: remove running built applications

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Tested V2 patch, the docs also build successfully. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 2020 14:18 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ; Wa

Re: [dpdk-dev] [PATCH v2 4/6] usertools/setup: remove hugepage functions

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Tested V2 patch, the docs also build successfully. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 2020 14:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ; Wa

Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module

2020-11-26 Thread Walsh, Conor
26 November 2020 14:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ; Walsh, Conor > Subject: [PATCH v2 5/6] usertools/setup: fix loading vfio module > > script is checking the existing of the kernel

Re: [dpdk-dev] [PATCH v2 6/6] usertools/setup: move removal target to 21.11

2020-11-26 Thread Walsh, Conor
; ; Richardson, Bruce > ; Walsh, Conor > Subject: [PATCH v2 6/6] usertools/setup: move removal target to 21.11 > > There are still some functions in the script that not replaced > completely, give more time to complete removal of the tool. > > A warning added to script document

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix unchecked return value

2020-10-20 Thread Walsh, Conor
Thanks Haiyue, I will implement a v2, following your suggestions. /Conor. > -Original Message- > From: Wang, Haiyue > Sent: Tuesday 20 October 2020 09:34 > To: Walsh, Conor ; Guo, Jia ; > Yigit, Ferruh ; Awal, Mohammad Abdul > ; Doherty, Declan > > Cc: de

Re: [dpdk-dev] [PATCH v6 0/4] devtools: abi breakage checks

2020-10-14 Thread Walsh, Conor
Thanks for your feedback Ray, V7 with your suggested changes for the patchset is on its way. /Conor > -Original Message- > From: Kinsella, Ray > Sent: Wednesday 14 October 2020 10:37 > To: Walsh, Conor ; nhor...@tuxdriver.com; > Richardson, Bruce ; tho...@monjalon.net

Re: [dpdk-dev] [PATCH v2] lib/ipsec: remove experimental tag

2020-09-14 Thread Walsh, Conor
Hi David, > Hello Conor, > > On Mon, Sep 14, 2020 at 2:54 PM Conor Walsh > wrote: > > > > Since librte_ipsec was first introduced in 19.02 and there were no > > changes in it's public API since 19.11, it should be considered mature > > enough to remove the 'experimental' tag from it. > > The RTE

Re: [dpdk-dev] [PATCH v3 2/4] devtools: add generation of compressed abi dump archives

2020-09-15 Thread Walsh, Conor
> >> This patch adds a script that generates a compressed archive > >> containing .dump files which can be used to perform ABI breakage > >> checking for the build specified in the parameters. > >> Invoke using "./gen-abi-tarball.py -t -a [-cf ]" > >> - : dpdk tag e.g. "v20.11" > >> - : requi