Re: [PATCH 0/5] fix race-condition of proactive error handling mode

Hi Ferruh, Thanks for the reminder. I will send a new version as soon as possible. Thanks. On 2023/9/21 19:12, Ferruh Yigit wrote: > On 3/1/2023 3:06 AM, Chengwen Feng wrote: >> This patch fixes race-condition of proactive error handling mode, the >> discussion thread [1]. >> >> [1] >> http://

Re: [PATCH 14/20] dmadev: mark API's as not experimental

Acked-by: Chengwen Feng On 2023/8/9 1:35, Stephen Hemminger wrote: > These were added in 20.11 time now to remove experimental flag. > > Signed-off-by: Stephen Hemminger > --- > lib/dmadev/rte_dmadev.h | 85 - > lib/dmadev/version.map | 2 +- > 2 files

Re: [PATCH 01/14] drivers: remove duplicated PCI master control

Acked-by: Chengwen Feng On 2023/8/3 15:50, David Marchand wrote: > Use existing API to cleanup duplicated code. > > Signed-off-by: David Marchand > --- > drivers/bus/pci/linux/pci_uio.c| 32 +-- > drivers/bus/pci/linux/pci_vfio.c | 41 ++ >

Re: [PATCH v3 1/2] dmadev: offload to free source buffer

Hi Amit, On 2023/9/28 19:50, Amit Prakash Shukla wrote: > This changeset adds support in DMA library to free source DMA buffer by > hardware. On a supported hardware, application can pass on the mempool > information as part of vchan config when the DMA transfer direction is > configured as RTE_DM

Re: [PATCH v3 2/2] test/dma: add source buffer offload free test

Hi Amit, On 2023/9/28 19:50, Amit Prakash Shukla wrote: > Add a test case to validate the functionality of drivers' dma > source buffer offload free. As part of dmadev_autotest, test case > will be executed only if the driver supports source buffer offload > free and if the test is exported by env

Re: Technical board meeting agenda for 2023-09-20

Hi TB, On 2023/9/19 4:20, Maxime Coquelin wrote: > Dear DPDK community, > > Following topics are planned to be discussed at the next Technical board > meeting, which will take place on Sept. 20th @3PM UTC: >  1- Memarea library inclusion Sorry to miss this meeting. Could you help rescheduling on

Re: [PATCH 1/4] dmadev: add function to get list of device identifiers

Hi Gowrishankar, This could create a help function in test, just like: func() { RTE_DMA_FOREACH_DEV(i) { rte_dma_info_get(i, &dev_info); if (strncmp(dev_info->dev_name, xxx) ... } } If some application (not test) should pick some specific device, I suggest ad

Re: [PATCH] test/dma: add test skip status

Hi Gowrishankar, It was already support in test framework (unit_test_suite), I suggest not invent. Could you help refactoring the test_dmadev (use the test framework) ? PS: could refer test_fbarray.c Thanks. On 2023/8/10 19:59, Gowrishankar Muthukrishnan wrote: > Add status on skipped tests. >

Re: [PATCH v1 1/3] dmadev: add inter-domain operations

Hi Anatoly, On 2023/8/12 0:14, Anatoly Burakov wrote: > Add a flag to indicate that a specific device supports inter-domain > operations, and add an API for inter-domain copy and fill. > > Inter-domain operation is an operation that is very similar to regular > DMA operation, except either source

Re: [PATCH v3 1/2] app/testpmd: fix help string

Hi Dengdui, On 2023/10/8 9:56, Dengdui Huang wrote: > Command help string is missing 'mcast_addr add|remove'. > This patch add it. > > Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC > addresses") > Cc: sta...@dpdk.org > > Signed-off-by: Dengdui Huang > --- > app/te

Re: [PATCH v3 2/2] app/testpmd: add flush all multicast MAC address command

Hi Dengdui, On 2023/10/8 9:56, Dengdui Huang wrote: > Add command to flush all multicast MAC address > Usage: > mcast_addr flush : > flush all multicast MAC address on port_id > > Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng

Re: [EXT] Re: [PATCH v3 1/2] dmadev: offload to free source buffer

ck. Please find my reply in-line. > > Thanks, > Amit Shukla > >> -----Original Message- >> From: fengchengwen >> Sent: Saturday, October 7, 2023 2:31 PM >> To: Amit Prakash Shukla ; Kevin Laatz >> ; Bruce Richardson >> Cc: dev@dpdk.org; Jeri

Re: [PATCH v4 1/2] dmadev: offload to auto free DMA buffer

Acked-by: Chengwen Feng On 2023/10/9 20:02, Amit Prakash Shukla wrote: This changeset adds support in DMA library to auto free DMA buffer by hardware. On a supported hardware, application can pass on the mempool information as part of vchan config. Signed-off-by: Amit Prakash Shukla Acked-by:

Re: [PATCH] doc: remove confusing command to send patch

Acked-by: Chengwen Feng On 2023/10/11 0:26, Thomas Monjalon wrote: > In the contributor guide, it was said that no need to Cc maintainers > for new additions, probably for new directories not having a maintainer. > There is no harm, and it is a good habit, to always Cc maintainers. > > Remove th

Re: [PATCH] ethdev: add calculate hash function

Hi, On 2023/10/10 19:05, Ferruh Yigit wrote: > On 9/26/2023 12:37 PM, Ori Kam wrote: >> rte_flow supports insert by index table[1]. >> >> Using the above table, the application can create rules >> that are based on hash. >> For example application can create the following logic in order >> to crea

Re: [PATCH v4] dmadev: add tracepoints

Hi Thomas, Sorry for the late reply. On 2023/8/14 22:16, Thomas Monjalon wrote: > jeudi 3 août 2023, fengchengwen: >> Hi Thomas, >> >> On 2023/7/31 20:48, Thomas Monjalon wrote: >>> 10/07/2023 09:50, fengchengwen: >>>> Hi Thomas, >>>> >&

Re: [PATCH v5 37/40] app/proc-info: fix never show RSS info

Acked-by: Chengwen Feng On 2023/10/11 17:28, Jie Hai wrote: > Command show-port should show RSS info (rss_key, len and rss_hf), > However, the information is shown only when rss_conf.rss_key is not > NULL. Since no memory is allocated for rss_conf.rss_key, rss_key > will always be NULL and the rs

Re: [PATCH v5 38/40] app/proc-info: adjust the display format of RSS info

Hi HaiJie, On 2023/10/11 17:28, Jie Hai wrote: > This patch splits the length and value of RSS key into two parts, > removes spaces between RSS keys, and adds line breaks between RSS > key and RSS hf. > > Before the adjustment, RSS info is shown as: > - RSS > -- RSS len 40 key (hex): 6d

Re: [PATCH v5 39/40] app/proc-info: support querying RSS hash algorithm

Suggest add one new API for get hash_algo_name. e.g. rte_eth_get_rss_algo_name() On 2023/10/11 17:28, Jie Hai wrote: > Display RSS hash algorithm with command show-port as below. > - RSS info > -- hash algorithm : toeplitz > > Signed-off-by: Jie Hai > Signed-off-by: Dongdong Liu > Ack

Re: [PATCH v5 02/40] ethdev: support setting and querying RSS algorithm

On 2023/10/12 1:39, Stephen Hemminger wrote: > On Wed, 11 Oct 2023 17:27:27 +0800 > Jie Hai wrote: > >> Currently, rte_eth_rss_conf supports configuring and querying >> RSS hash functions, rss key and it's length, but not RSS hash >> algorithm. >> >> The structure ``rte_eth_rss_conf`` is exten

Re: [PATCH v5 36/40] net/hns3: support setting and querying RSS hash function

The new algorithm (RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT) should treat as Not Support. With above fix Acked-by: Chengwen Feng On 2023/10/11 17:28, Jie Hai wrote: > From: Huisong Li > > Support setting and querying RSS hash function by ethdev ops. > > Signed-off-by: Huisong Li > Sign

Re: [PATCH v5 01/40] ethdev: overwrite some comment related to RSS

On 2023/10/11 17:27, Jie Hai wrote: > 1. overwrite the comments of fields of 'rte_eth_rss_conf'. > 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev.h | 29 ++--- > lib/ethdev/rte_flow.h | 3 +++ > 2 files ch

Re: [PATCH v5 40/40] app/testpmd: add RSS hash algorithms display

Hi HaiJie, On 2023/10/11 17:28, Jie Hai wrote: > Add the command "show port X rss-hash algorithm" to display > the RSS hash algorithms of port X. An example is shown: > > testpmd> show port 0 rss-hash algorithm > RSS algorithms: > toeplitz > > Signed-off-by: Jie Hai > --- > app/test-pmd/cmdl

Re: [PATCH v5 36/40] net/hns3: support setting and querying RSS hash function

On 2023/10/12 11:05, Jie Hai wrote: > On 2023/10/12 10:23, fengchengwen wrote: >> The new algorithm (RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT) should >> treat as Not Support. >> >> With above fix >> Acked-by: Chengwen Feng >> > Actually,

Re: [PATCH] net/bonding: fix link status callback stop

On 2023/10/16 16:47, David Marchand wrote: > If a bonding port gets released, a link status alarm callback still > referenced the ethdev port that may be reused later. > Cancel this callback when stopping the port. > > Bugzilla ID: 1301 > Fixes: a45b288ef21a ("bond: support link status polling") >

Re: [PATCH 0/4] add telemetry commands for TM capabilities

Series-acked-by: Chengwen Feng On 2023/10/18 9:39, Jie Hai wrote: > This patch adds telemetry commands for TM capabilities and make some > bufix for hns3 driver. > > Jie Hai (4): > net/hns3: fix a typo > ethdev: add telemetry command for TM capabilities > ethdev: add telemetry command for

Re: [PATCH v3] app/dma-perf: fix physical address seg-fault

Acked-by: Chengwen Feng On 2023/10/19 12:16, Vipin Varghese wrote: > do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return > the start of the virtual address for both src and dst. > But in case of iova mode set as PA, this results in seg-fault. > This is because rte_memcpy uses VA address an

Re: [PATCH] app/testpmd: support config all offload

Add cc to testpmd's maintainer due tools failed to add. On 2023/10/23 10:29, Chengwen Feng wrote: > Extend supports all offload configuration in following commands: > 1. port config 0 rx_offload all on/off > 2. port config 0 tx_offload all on/off > 3. port 0 rxq 0 rx_offload all on/off > 4. port 0

Re: [PATCH] eal: support lcore usage ratio

Hi Morten, On 2023/10/23 16:58, Morten Brørup wrote: >> From: Chengwen Feng [mailto:fengcheng...@huawei.com] >> Sent: Monday, 23 October 2023 06.08 >> >> Current, the lcore usage only display two key fields: busy_cycles and >> total_cycles, which is inconvenient to obtain the usage ratio >> immedi

Re: [PATCH v8 1/9] memarea: introduce memarea library

Sorry to self-reply. On 2022/10/12 12:06, fengchengwen wrote: > Hi Dmitry, > > On 2022/10/11 23:58, Dmitry Kozlyuk wrote: >> 2022-10-11 12:17 (UTC+), Chengwen Feng: >> [...] >>> diff --git a/doc/guides/prog_guide/memarea_lib.rst >>> b/doc/guides/prog_

Re: [PATCH v12 2/5] ethdev: support proactive error handling mode

Hi Andrew, I rework part of rst according your comments, sent by v13, please take a look. Thanks. On 2022/10/13 16:58, Andrew Rybchenko wrote: > On 10/12/22 06:45, Chengwen Feng wrote: >> From: Kalesh AP >> >> Some PMDs (e.g. hns3) could detect hardware or firmware errors, one >> error recove

Re: [PATCH v2] doc: fix support table for ETH and VLAN flow items

Hi Ilya, I have some questions about has_vlan/has_more_vlan fields: a\ DPDK framework support cvlan-tag(0x8100) and svlan-tag(0x88A8), and also deprecated qinq-tag(eg. 0x9100) b\ If has_vlan is used, does it mean that all the VLAN tags(0x8100/88A8/9100) must be matched ? I think

Re: [PATCH v2] usertools: telemetry json support pretty print

Hi all, On 2022/10/15 0:10, Morten Brørup wrote: >> From: Bruce Richardson [mailto:bruce.richard...@intel.com] >> Sent: Friday, 14 October 2022 17.30 >> >> On Fri, Oct 14, 2022 at 08:01:11AM -0700, Stephen Hemminger wrote: >>> On Fri, 14 Oct 2022 14:02:10 +0100 >>> Bruce Richardson wrote: >>> >>>

Re: [PATCH v2] doc: fix support table for ETH and VLAN flow items

Thanks Ilya and Eli On 2022/10/16 13:26, Eli Britstein wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Friday, October 14, 2022 3:37 PM >> To: fengchengwen ; dev@dpdk.org; Ori Kam >> ; NBU-Contact-Thomas Monjalon (EXTERNAL) >>

Re: [PATCH v5] net/bonding: call Tx prepare before Tx burst

Hi Thomas, Ferruh and Andrew   This patch already reviewed by Humin and Chas, Could it accepted in 22.11 ? Thanks On 2022/10/15 23:26, Chas Williams wrote: This looks fine. Thanks for making the changes! Signed-off-by: Chas Williams <3ch...@gmail.com> On 10/11/22 09:20, Chengwen Feng wrote

Re: [PATCH v2 0/5] support dmadev/ethdev stats reset

Sorry to repeat send v2, this new version include change log. On 2023/1/11 20:06, Chengwen Feng wrote: > This patchset contains dmadev/ethdev stats reset, and also support > hide zero for ethdev xstats and two telemetry related bugs. > > Chengwen Feng (5): > dmadev: support stats reset telemetr

Re: [PATCH v5 2/5] telemetry: fix repeated display when callback don't set dict

Hi Bruce, On 2023/1/7 1:33, Bruce Richardson wrote: > On Fri, Jan 06, 2023 at 04:07:45PM +, Bruce Richardson wrote: >> On Mon, Dec 26, 2022 at 12:53:57PM +0800, fengchengwen wrote: >>> On 2022/12/19 17:33, Bruce Richardson wrote: >>>> On Mon, Dec 19, 2022 at 0

Re: [PATCH v2 5/5] ethdev: telemetry xstats support hide zero

Hi Bruce, On 2023/1/11 22:08, Bruce Richardson wrote: > On Wed, Jan 11, 2023 at 12:06:30PM +, Chengwen Feng wrote: >> The number of xstats may be large, after the hide zero option is added, >> only non-zero values can be displayed. >> >> Signed-off-by: Chengwen Feng >> --- >> lib/ethdev/rte_

Re: [PATCH v12 1/6] memarea: introduce memarea library

Hi Morten, On 2023/1/15 15:58, Morten Brørup wrote: >> From: Chengwen Feng [mailto:fengcheng...@huawei.com] >> Sent: Saturday, 14 January 2023 12.50 >> >> The memarea library is an allocator of variable-size object which based >> on a memory region. >> >> This patch provides rte_memarea_create() a

Re: [PATCH v11 1/3] cmdline: make rdline status not private

Acked-by: Chengwen Feng On 2023/2/4 3:14, Stephen Hemminger wrote: > The function cmdline_poll() returns values from rdline_status enum > but that was moved to being defined only in cmdline_private.h. > > For proper use of the API the return value needs to be visible > to callers. This was not a

Re: [PATCH v7 0/7] start cleanup of rte_flow_item_*

LGTM, Series-acked-by: Chengwen Feng On 2023/2/4 0:48, Ferruh Yigit wrote: > There was a plan to have structures from lib/net/ at the beginning > of corresponding flow item structures. > Unfortunately this plan has not been followed up so far. > This series is a step to make the most used items,

Re: [PATCH v8 5/5] eal: add lcore usage telemetry endpoint

Hi Robin, On 2023/2/2 21:43, Robin Jarry wrote: > Allow fetching CPU cycles usage for all lcores with a single request. > This endpoint is intended for repeated and frequent invocations by > external monitoring systems and therefore returns condensed data. > > It consists of a single dictionary w

Re: [PATCH v8 4/5] app/testpmd: report lcore usage

Suggest add field "busy ratio" to reduce hand-computing and improve readability. With above add, Acked-by: Chengwen Feng On 2023/2/2 21:43, Robin Jarry wrote: > Reuse the --record-core-cycles option to account for busy cycles. One > turn of packet_fwd_t is considered "busy" if there was at least

Re: [PATCH v8 3/5] app/testpmd: add dump command for lcores

Acked-by: Chengwen Feng On 2023/2/2 21:43, Robin Jarry wrote: > Add a simple command that calls rte_lcore_dump(). > > Signed-off-by: Robin Jarry > Acked-by: Morten Brørup > Acked-by: Konstantin Ananyev > Reviewed-by: Kevin Laatz > --- > ...

Re: [PATCH v8 1/5] eal: add lcore info in telemetry

Hi Robin, On 2023/2/2 21:43, Robin Jarry wrote: > Report the same information than rte_lcore_dump() in the telemetry > API into /eal/lcore/list and /eal/lcore/info,ID. > > Example: > > --> /eal/lcore/info,3 > { > "/eal/lcore/info": { > "lcore_id": 3, > "socket": 0, > "r

Re: [PATCH v8 2/5] eal: report applications lcore usage

Hi Robin, On 2023/2/2 21:43, Robin Jarry wrote: > Allow applications to register a callback that will be invoked in > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > The callback is expected to return the number of TSC cycles that have > passed since application start an

Re: [PATCH v8 2/5] eal: report applications lcore usage

On 2023/2/6 15:36, Morten Brørup wrote: >> From: fengchengwen [mailto:fengcheng...@huawei.com] >> Sent: Monday, 6 February 2023 05.00 >> >> Hi Robin, >> >> On 2023/2/2 21:43, Robin Jarry wrote: >>> Allow applications to register a callback that wil

Re: [PATCH v8 1/5] eal: add lcore info in telemetry

On 2023/2/6 16:22, Robin Jarry wrote: > fengchengwen, Feb 06, 2023 at 04:50: >> > +    return rte_lcore_iterate(lcore_telemetry_info_cb, &info); >> >> lcore_iterate will iterate and find the lcore. >> >> How about add one new API e.g. rte_lcore_cb(xxx) ? &g

Re: [PATCH v8 5/5] eal: add lcore usage telemetry endpoint

On 2023/2/6 16:24, Robin Jarry wrote: > fengchengwen, Feb 06, 2023 at 04:27: >> The telemetry should be human-readable also. >> >> so why not "/eal/lcore/usage": { >>     "lcore_4" : { >>     "total_cycles" : xxx >

Re: [PATCH v8 1/5] eal: add lcore info in telemetry

On 2023/2/6 19:46, Robin Jarry wrote: > fengchengwen, Feb 06, 2023 at 12:22: >> Just invoke callback on one specific lcore. >> >> In this patch, the lcore_telemetry_info_cb() only valid on specific lcore, >> but it was implements by rte_lcore_iterate which will iterat

Re: [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe

We make a test on this patch, test result show that it works fine. Below is the detail: HW: Kunpeng920 ARM Platform which is ARMv8 NIC: Kunpeng920 SOC NIC OS: Linux centos-C3 5.12.0-rc4+ DPDK: 21.02 DRV: hns3 Start three process: ./testpmd -w :bd:00.0 -l 67-68 --proc-type=auto -- -i --num-pr

Re: [dpdk-dev] [PATCH 1/2] raw/ntb: check spad user index

On 2021/4/21 11:31, Li, Xiaoyun wrote: > Hi > >> -Original Message- >> From: Min Hu (Connor) >> Sent: Wednesday, April 21, 2021 10:08 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Li, Xiaoyun >> ; >> Wu, Jingjing >> Subject: [PATCH 1/2] raw/ntb: check spad user index >> >> From: Chengwe

Re: [dpdk-dev] [PATCH] vdpa/mlx5: improve portability of thread naming

On 2021/4/22 1:59, Thomas Monjalon wrote: > The function pthread_setname_np is non-portable, > so it may be unavailable in old glibc or other systems. > The function rte_thread_setname is workarounding portability issues. > > Signed-off-by: Thomas Monjalon Reviewed-by: Chengwen Feng

Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail

On 2021/4/26 20:26, Ferruh Yigit wrote: > On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: >> From: Chengwen Feng >> >> The link fails code should be parsed using the structure >> hns3_mbx_vf_to_pf_cmd, else it will parse fail. >> >> Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mai

Re: [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail

On 2021/4/26 20:50, Ferruh Yigit wrote: > On 4/26/2021 1:41 PM, fengchengwen wrote: >> >> >> On 2021/4/26 20:26, Ferruh Yigit wrote: >>> On 4/22/2021 2:55 AM, Min Hu (Connor) wrote: >>>> From: Chengwen Feng >>>> >>

Re: [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration

From:Ferruh Yigit To:humin (Q) ;dev Date:2021-04-27 21:39:45 Subject:Re: [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration On 4/26/2021 4:34 AM, Min Hu (Connor) wrote: > From: Chengwen Feng < fengcheng...@huawei.com> > > The rte flow interface does not

Re: [dpdk-dev] [PATCH 1/6] net/hns3: delete some unused capabilities

From:Ferruh Yigit To:humin (Q) ;dev Date:2021-04-27 21:37:59 Subject:Re: [dpdk-dev] [PATCH 1/6] net/hns3: delete some unused capabilities On 4/26/2021 4:34 AM, Min Hu (Connor) wrote: > From: Chengwen Feng < fengcheng...@huawei.com> > > This patch deletes some un

Re: [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration

From:Ferruh Yigit To:Fengchengwen ;humin (Q) ;dev Date:2021-04-27 22:26:09 Subject:Re: [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration On 4/27/2021 3:15 PM, Fengchengwen wrote: > > > > > > *From:*Ferruh Yigit < ferruh.yi...@intel.com<mailto:ferruh.yi...@int

Re: [dpdk-dev] [PATCH 6/6] net/hns3: fix vector Rx burst default value

From:Ferruh Yigit To:humin (Q) ;dev Date:2021-04-27 21:47:08 Subject:Re: [dpdk-dev] [PATCH 6/6] net/hns3: fix vector Rx burst default value On 4/26/2021 4:34 AM, Min Hu (Connor) wrote: > From: Chengwen Feng < fengcheng...@huawei.com> > > Currently, driver uses t

Re: [dpdk-dev] [PATCH] eal: fix use wrong time API

On 2021/4/28 17:24, Morten Brørup wrote: >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Min Hu (Connor) >> Sent: Wednesday, April 28, 2021 10:13 AM >> >> From: Chengwen Feng >> >> Currently, the mp uses gettimeofday() API to get the time, and used as >> timeout parameter. >> >> But the

[dpdk-dev] How to disable SVE auto vectorization while using GCC

Hi, ALL We have a question for your help: 1. We have two platforms, both of which are ARM64, one of which supports both NEON and SVE, the other only support NEON. 2. We want to run on both platforms with a single binary file, and use the highest vector capability of the corresponding

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

On 2021/6/17 1:31, Bruce Richardson wrote: > On Wed, Jun 16, 2021 at 05:41:45PM +0800, fengchengwen wrote: >> On 2021/6/16 0:38, Bruce Richardson wrote: >>> On Tue, Jun 15, 2021 at 09:22:07PM +0800, Chengwen Feng wrote: >>>> This patch introduces 'dmadev

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

On 2021/6/17 22:18, Bruce Richardson wrote: > On Thu, Jun 17, 2021 at 12:02:00PM +0100, Bruce Richardson wrote: >> On Thu, Jun 17, 2021 at 05:48:05PM +0800, fengchengwen wrote: >>> On 2021/6/17 1:31, Bruce Richardson wrote: >>>> On Wed, Jun 16, 2021 at 05:41:

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

On 2021/6/18 13:52, Jerin Jacob wrote: > On Thu, Jun 17, 2021 at 2:46 PM Bruce Richardson > wrote: >> >> On Wed, Jun 16, 2021 at 08:07:26PM +0530, Jerin Jacob wrote: >>> On Wed, Jun 16, 2021 at 3:47 PM fengchengwen >>> wrote: >>>> >>>&g

Re: [dpdk-dev] [PATCH v8 1/2] config/arm: select most suitable -march for kunpeng soc

Hi, Thomas Another patch '[dpdk-dev] [PATCH v8 2/2] net/hns3: refactor SVE code compile method' has nothing to do with this patch (they're just in the same patchset) and has been reviewed by ARM guys. So please review it, thanks. On 2021/6/18 7:33, Honnappa Nagarahalli wrote: > > >> >> 24/0

Re: [dpdk-dev] [PATCH v3] build: fix SVE compile error with gcc8.3

Hi, Thomas This patch already reviewed by ARM guys. Please review it, thanks On 2021/6/12 15:07, fengchengwen wrote: > Friendly ping > > > On 2021/5/27 15:12, Fengchengwen wrote: >> Hi, Thomas >> >> Could you review this patch? Thanks >> >>

Re: [dpdk-dev] [PATCH] config/arm: add checking SVE cpuflag

Hi, ARM guys, Thomas Could you help review this patch ? Thanks On 2021/5/21 11:33, Chengwen Feng wrote: > If compiled with SVE feature (e.g. "-march=armv8.2-a+sve'), the binary > could not run on non-SVE platform else it will encounter illegal > instruction [1]. > > This patch fixes it by add '

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

On 2021/6/23 1:25, Jerin Jacob wrote: > On Fri, Jun 18, 2021 at 3:11 PM fengchengwen wrote: >> >> On 2021/6/18 13:52, Jerin Jacob wrote: >>> On Thu, Jun 17, 2021 at 2:46 PM Bruce Richardson >>> wrote: >>>> >>>> On Wed, Jun 16, 2021 at

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

On 2021/6/23 1:51, Jerin Jacob wrote: > On Fri, Jun 18, 2021 at 2:22 PM fengchengwen wrote: >> >> On 2021/6/17 22:18, Bruce Richardson wrote: >>> On Thu, Jun 17, 2021 at 12:02:00PM +0100, Bruce Richardson wrote: >>>> On Thu, Jun 17, 2021 at 05:48:05PM +0800, fe

Re: [dpdk-dev] [PATCH v8 1/2] config/arm: select most suitable -march for kunpeng soc

On 2021/6/23 16:08, Thomas Monjalon wrote: > 21/06/2021 02:52, fengchengwen: >> Hi, Thomas >> >> Another patch '[dpdk-dev] [PATCH v8 2/2] net/hns3: refactor SVE code compile >> method' >> has nothing to do with this patch (they're just in the sa

Re: [dpdk-dev] [RFC PATCH] dmadev: introduce DMA device library

[offlist, so we don't spam everyone], and I can try and co-ordinate if > everyone is ok with above suggested timeslot and send out calendar invite. > > Regards, > /Bruce > > On Wed, Jun 23, 2021 at 11:50:48AM +0800, fengchengwen wrote: >> On 2021/6/23 1:51,

[dpdk-dev] dmadev discussion summary

Hi, all I analyzed the current DPAM DMA driver and drew this summary in conjunction with the previous discussion, and this will as a basis for the V2 implementation. Feedback is welcome, thanks dpaa2_qdma: [probe]: mainly obtains the number of hardware queues. [dev_configure]: has follow

Re: [dpdk-dev] [PATCH 2/2] net/hns3: fix SVE code compile error with gcc8.3

On 2021/6/28 11:33, Ruifeng Wang wrote: >> -Original Message- >> From: Chengwen Feng >> Sent: Monday, June 28, 2021 10:58 AM >> To: tho...@monjalon.net; ferruh.yi...@intel.com; Ruifeng Wang >> >> Cc: dev@dpdk.org; bruce.richard...@intel.com; >> vladimir.medved...@intel.com; vikto...@rehiv

Re: [dpdk-dev] dmadev discussion summary

On 2021/6/28 18:00, Bruce Richardson wrote: >> 4) The driver's ops design (here we only list key points): >> [dev_info_get]: mainly return the number of HW-queues >> [dev_configure]: nothing important >> [queue_setup]: create one virt-queue, has following main parameters: >>

Re: [dpdk-dev] dmadev discussion summary

On 2021/7/1 23:01, Jerin Jacob wrote: >> [key point]: >> ------ >> | channel || channel | >> ------ >> \ / >> \ / >>\ / >> >> | H

Re: [dpdk-dev] dmadev discussion summary

On 2021/7/2 15:07, Liang Ma wrote: >> 8) One example: >> vq_id = rte_dmadev_queue_setup(dev, config.{HW-queue-index=x, opaque}); >> if (vq_id < 0) { >> // create virt-queue failed >> return; >> } >> // submit memcpy task >> cookit = rte_dmadev_memcpy(dev,

Re: [dpdk-dev] [PATCH 0/2] bugfix for SVE compile

Hi, Thomas Please review this patch set, thanks. PS: this patch set already reviewed by ARM guys, and the CI has some errors, but it seem not related to this patch set. On 2021/6/28 10:57, Chengwen Feng wrote: > This patch set contains two bugfixes for SVE compile. > Note: > 1) Because 2/2 patc

Re: [dpdk-dev] dmadev discussion summary

On 2021/7/2 22:57, Morten Brørup wrote: >> In the DPDK framework, many data-plane API names contain queues. e.g. >> eventdev/crypto.. >> The concept of virt queues has continuity. > > I was also wondering about the name "virtual queue". > > Usually, something "virtual" would be an abstraction of

Re: [dpdk-dev] dmadev discussion summary

On 2021/7/3 16:53, Morten Brørup wrote: >> From: fengchengwen [mailto:fengcheng...@huawei.com] >> Sent: Saturday, 3 July 2021 02.32 >> >> On 2021/7/2 22:57, Morten Brørup wrote: >>>> In the DPDK framework, many data-plane API names contain queues. >> e.g.

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

Many thanks, mostly OK, and a few comment inline On 2021/7/4 17:30, Jerin Jacob wrote: > On Fri, Jul 2, 2021 at 6:51 PM Chengwen Feng wrote: >> >> This patch introduces 'dmadevice' which is a generic type of DMA >> device. ... >> +#include > > Sort in alphabetical order. > >> + >> +/** >> + *

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

Many thanks, mostly OK, a few comment inline On 2021/7/4 22:57, Andrew Rybchenko wrote: > On 7/2/21 4:18 PM, Chengwen Feng wrote: >> This patch introduces 'dmadevice' which is a generic type of DMA >> device. [snip] >> +#ifndef _RTE_DMADEV_CORE_H_ >> +#define _RTE_DMADEV_CORE_H_ >> + >> +/** >>

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

On 2021/7/4 23:21, Matan Azrad wrote: > > > From: Chengwen Feng >> This patch introduces 'dmadevice' which is a generic type of DMA >> device. >> >> The APIs of dmadev library exposes some generic operations which can >> enable configuration and I/O with the DMA devices. >> > Did you consider RTE

Re: [dpdk-dev] dmadev discussion summary

oun...@dpdk.org] On Behalf Of Jerin Jacob >>>> Sent: Saturday, 3 July 2021 11.09 >>>> >>>> On Sat, Jul 3, 2021 at 2:23 PM Morten Brørup >> >>>> wrote: >>>>> >>>>>> From: fengchengwen [mailto:fengcheng...@huawei.com

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

On 2021/7/5 18:52, Bruce Richardson wrote: > On Sun, Jul 04, 2021 at 03:00:30PM +0530, Jerin Jacob wrote: >> On Fri, Jul 2, 2021 at 6:51 PM Chengwen Feng wrote: [snip] >>> + * >>> + * If dma_cookie_t is >=0 it's a DMA operation request cookie, <0 it's a >>> error >>> + * code. >>> + * When usin

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

On 2021/7/6 14:50, Matan Azrad wrote: > Hi > > From: fengchengwen >> On 2021/7/4 23:21, Matan Azrad wrote: >>> >>> >>> From: Chengwen Feng >>>> This patch introduces 'dmadevice' which is a generic type of DMA >>>> device

Re: [dpdk-dev] [RFC UPDATE PATCH 0/9] dmadev rfc suggested updates

LGTM, thanks And I'am prepare dmadev V2, include: a) Fix code review comments (e.g. multiple-process support, doxygen, comments, typo) b) Flatten device abstraction to two layer: dmadev <> vchan c) Public API use dev_id and vchan_id to locate one vchan d) Using the flags parameter instead of the

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

or >>> special-case the last transaction outside the loop), and within the driver, >>> there has to be a branch whether or not to call the doorbell function. The >>> code on both sides is far simpler and more readable if the doorbell >>> function is exactly that - a

Re: [PATCH] dma/hisilicon: remove support for HIP09 platform

Kindly ping. Best regards Chengwen Feng On 2024/7/4 10:53, Chengwen Feng wrote: > The DMA for HIP09 is no longer available, so delete it. > > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > --- > doc/guides/dmadevs/hisilicon.rst | 1 - > doc/guides/rel_notes/release_24_07.rst |

Re: [PATCH v3 0/3] bugfix about KEEP CRC offload

Series-reviewed-by: Chengwen Feng On 2024/7/19 17:04, Jie Hai wrote: > For hns3 NIC, when KEEP_CRC offload is enabled, the CRC data is > still be stripped in rare scenarios. Some users of hns3 are > already using this feature. So driver has to recaculate packet CRC. > In addition, in the mbuf, th

[dpdk-dev] How about public rte flow lock API

Hi, Ori and Ferruh Currently, the rte flow API has the lock of flow_ops_mutx default which used when driver hasn't provided mutex protection, it's inner API which was not public, but in hns3 driver there maybe concurrent access driver's rte flow data when doing reset recovery (which occur in i

Re: [dpdk-dev] [PATCH 0/7] support set thread name

On 2021/4/12 15:19, David Marchand wrote: > On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) wrote: >> >> This set of patches support set thread name for debugging. >> >> Chengwen Feng (7): >> net/ark: support set thread name >> net/ice: support set VSI reset thread name >> vdpa/ifc: supp

Re: [dpdk-dev] [PATCH v25 2/6] dmadev: add control plane API support

On 2021/10/11 23:44, Bruce Richardson wrote: > On Mon, Oct 11, 2021 at 03:33:44PM +0800, Chengwen Feng wrote: >> This patch add control plane API for dmadev. >> >> Signed-off-by: Chengwen Feng >> Acked-by: Bruce Richardson >> Acked-by: Morten Brørup >> Reviewed-by: Kevin Laatz >> Reviewed-by: C

Re: [dpdk-dev] [PATCH v25 1/6] dmadev: introduce DMA device library

On 2021/10/13 3:09, Thomas Monjalon wrote: > 11/10/2021 09:33, Chengwen Feng: >> --- /dev/null >> +++ b/doc/guides/prog_guide/dmadev.rst >> @@ -0,0 +1,60 @@ >> +.. SPDX-License-Identifier: BSD-3-Clause >> + Copyright 2021 HiSilicon Limited >> + >> +DMA Device Library >> +== >> + >

Re: [dpdk-dev] [PATCH v25 1/6] dmadev: introduce DMA device library

On 2021/10/15 16:29, Thomas Monjalon wrote: > 13/10/2021 09:41, Thomas Monjalon: >> 13/10/2021 02:21, fengchengwen: >>> On 2021/10/13 3:09, Thomas Monjalon wrote: >>>> 11/10/2021 09:33, Chengwen Feng: >>>>> +static void >>>>> +dma_re

Re: [dpdk-dev] [PATCH] dmadev: enable build on Windows

On 2021/10/19 20:28, Bruce Richardson wrote: > The dmadev library was not added to the list of libraries built on > Windows, meaning it was skipped in those builds and also that none of > the drivers were being considered for build. Adding dmadev to the list > fixes this, and also enables the skele

Re: [dpdk-dev] [PATCH v10 03/16] dma/idxd: add bus device probing

On 2021/10/19 22:10, Kevin Laatz wrote: > Add the basic device probing for DSA devices bound to the IDXD kernel > driver. These devices can be configured via sysfs and made available to > DPDK if they are found during bus scan. Relevant documentation is included. > [snip] > diff --git a/lib/dmad

Re: [dpdk-dev] [PATCH v10 04/16] dma/idxd: create dmadev instances on bus probe

On 2021/10/19 22:10, Kevin Laatz wrote: > When a suitable device is found during the bus scan/probe, create a dmadev > instance for each HW queue. Internal structures required for device > creation are also added. > [snip] > static void * > idxd_bus_mmap_wq(struct rte_dsa_device *dev) > { > @

Re: [dpdk-dev] [PATCH v10 05/16] dma/idxd: create dmadev instances on pci probe

On 2021/10/19 22:10, Kevin Laatz wrote: > When a suitable device is found during the PCI probe, create a dmadev > instance for each HW queue. HW definitions required are also included. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- [snip] >

Re: [dpdk-dev] [PATCH v10 06/16] dma/idxd: add datapath structures

On 2021/10/19 22:10, Kevin Laatz wrote: > Add data structures required for the data path for IDXD devices. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > drivers/dma/idxd/idxd_bus.c | 1 + > drivers/dma/idxd/idxd_common.c | 33 ++

Re: [dpdk-dev] [PATCH v10 07/16] dma/idxd: add configure and info_get functions

Reviewed-by: Chengwen Feng On 2021/10/19 22:10, Kevin Laatz wrote: > Add functions for device configuration. The info_get function is included > here since it can be useful for checking successful configuration. > > Documentation is also updated to add device configuration usage info. > > Signe

  1   2   3   4   5   6   7   >