Re: [dpdk-dev] [PATCH v10 08/16] dma/idxd: add start and stop functions for pci devices

2021-10-20 Thread fengchengwen
On 2021/10/19 22:10, Kevin Laatz wrote: > Add device start/stop functions for DSA devices bound to vfio. For devices > bound to the IDXD kernel driver, these are not required since the IDXD > kernel driver takes care of this. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Rev

Re: [dpdk-dev] [PATCH v10 09/16] dma/idxd: add data-path job submission functions

2021-10-20 Thread fengchengwen
On 2021/10/19 22:10, Kevin Laatz wrote: > Add data path functions for enqueuing and submitting operations to DSA > devices. > > Documentation updates are included for dmadev library and IDXD driver docs > as appropriate. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Revi

Re: [dpdk-dev] [PATCH v10 11/16] dma/idxd: add operation statistic tracking

2021-10-20 Thread fengchengwen
On 2021/10/19 22:10, Kevin Laatz wrote: > Add statistic tracking for DSA devices. > > The dmadev library documentation is also updated to add a generic section > for using the library's statistics APIs. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v10 12/16] dma/idxd: add vchan status function

2021-10-20 Thread fengchengwen
On 2021/10/19 22:10, Kevin Laatz wrote: > When testing dmadev drivers, it is useful to have the HW device in a known > state. This patch adds the implementation of the function which will wait > for the device to be idle (all jobs completed) before proceeding. > > Signed-off-by: Kevin Laatz > Rev

Re: [dpdk-dev] [PATCH v10 13/16] dma/idxd: add burst capacity API

2021-10-20 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2021/10/19 22:10, Kevin Laatz wrote: > Add support for the burst capacity API. This API will provide the calling > application with the remaining capacity of the current burst (limited by > max HW batch size). > > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Wal

Re: [dpdk-dev] [PATCH 1/2] dmadev: hide devices array

2021-10-20 Thread fengchengwen
On 2021/10/20 14:59, David Marchand wrote: > No need to expose rte_dma_devices out of the dmadev library. > Existing helpers should be enough, and inlines make use of > rte_dma_fp_objs. > > Signed-off-by: David Marchand > --- > app/test/test_dmadev.c | 5 +++-- > lib/dmadev/rte_dmadev.c

Re: [dpdk-dev] [PATCH v7 00/13] add test suite for DMA drivers

2021-10-21 Thread fengchengwen
Hi Bruce, I observed a large number of checkpatch errors [1] when synchronizing to our inner CI, almost all of them are over 80 lines, and many are not LONG LOG. The DPDK coding style recommends to be not more than 80 characters unless rarest situations (which LONG LOG belongs to this one I thin

Re: [dpdk-dev] [PATCH v2] devtools: clarify that lines up to 100 characters are ok

2021-10-25 Thread fengchengwen
On 2021/10/20 22:26, Bruce Richardson wrote: > Since we allow line lengths of up to 100, and the CI checkpatches job > only check for that amount, the rest of our tooling and docs should > reflect this reality. Therefore we can: > > * adjust the editorconfig to use that value, to save editors (e.g

Re: [dpdk-dev] [PATCH v4 0/8] port ioatfwd app to dmadev

2021-10-25 Thread fengchengwen
Hi Kevin, We test whole patch set and found it should add one judgement: the ring_size should be less than or equal to MBUF_RING_SIZE. If ring_size greater than MBUF_RING_SIZE, the tracking DMA bufs may be overwrited when the DMA copy is not in time. Thanks. On 2021/10/14 17:53, Kevin Laatz wrot

Re: [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array

2021-10-25 Thread fengchengwen
On 2021/10/26 14:04, Radha Mohan wrote: > On Thu, Oct 21, 2021 at 7:04 AM Kevin Laatz wrote: >> >> On 21/10/2021 13:59, Chengwen Feng wrote: >>> From: David Marchand >>> >>> No need to expose rte_dma_devices out of the dmadev library. >>> Existing helpers should be enough, and inlines make use of

Re: [dpdk-dev] [PATCH v2 1/6] dma/dpaa: introduce DPAA DMA driver

2021-11-02 Thread fengchengwen
On 2021/11/1 16:51, Gagandeep Singh wrote: > The DPAA DMA driver is an implementation of the dmadev APIs, > that provide means to initiate a DMA transaction from CPU. > The initiated DMA is performed without CPU being involved > in the actual DMA transaction. This is achieved via using > the QDMA

Re: [dpdk-dev] [PATCH v2 2/6] dma/dpaa: add device probe and remove functionality

2021-11-02 Thread fengchengwen
On 2021/11/1 16:51, Gagandeep Singh wrote: > This patch add device initialisation functionality. > > Signed-off-by: Gagandeep Singh [snip] > + > +static void fsl_qdma_free_chan_resources(struct fsl_qdma_chan *fsl_chan) > +{ > + struct fsl_qdma_queue *fsl_queue = fsl_chan->queue; > + str

Re: [dpdk-dev] [PATCH v2 4/6] dma/dpaa: support basic operations

2021-11-02 Thread fengchengwen
On 2021/11/1 16:51, Gagandeep Singh wrote: > This patch support basic DMA operations which includes > device capability and channel setup. > > Signed-off-by: Gagandeep Singh > --- > drivers/dma/dpaa/dpaa_qdma.c | 185 +++ > drivers/dma/dpaa/dpaa_qdma.h | 6 ++

Re: [dpdk-dev] [PATCH v2 5/6] dma/dpaa: support DMA operations

2021-11-02 Thread fengchengwen
On 2021/11/1 16:51, Gagandeep Singh wrote: > This patch support copy, submit, completed and > completed status functionality of DMA driver. > > Signed-off-by: Gagandeep Singh ... > + > +static int fsl_qdma_enqueue_desc(struct fsl_qdma_chan *fsl_chan, > + struct fsl

Re: [dpdk-dev] [PATCH v2 1/4] common/cnxk: add DPI DMA support

2021-11-02 Thread fengchengwen
On 2021/11/2 11:40, Radha Mohan Chintakuntla wrote: > Add base support as ROC(Rest of Chip) API which will be used by PMD > dmadev driver. > > This patch adds routines to init, fini, configure the DPI DMA device > found in Marvell's CN9k or CN10k SoC families. > > Signed-off-by: Radha Mohan Chint

Re: [dpdk-dev] [PATCH v2 2/4] dma/cnxk: create and initialize dmadev on pci probe

2021-11-02 Thread fengchengwen
On 2021/11/2 11:40, Radha Mohan Chintakuntla wrote: > This patch creates and initializes a dmadev device on pci probe. > > Signed-off-by: Radha Mohan Chintakuntla > --- ... > +RTE_PMD_REGISTER_PCI(cnxk_dmadev_pci_driver, cnxk_dmadev); > +RTE_PMD_REGISTER_PCI_TABLE(cnxk_dmadev_pci_driver, cnxk_d

Re: [dpdk-dev] [PATCH v2 3/4] dma/cnxk: add dma channel operations

2021-11-02 Thread fengchengwen
On 2021/11/2 11:40, Radha Mohan Chintakuntla wrote: > Add functions for the dmadev vchan setup and DMA operations. > > Signed-off-by: Radha Mohan Chintakuntla ... > > +static int > +cnxk_dmadev_info_get(const struct rte_dma_dev *dev, > + struct rte_dma_info *dev_info, uint32_

Re: [dpdk-dev] [PATCH v2 4/4] dma/cnxk: add copy_sg function

2021-11-02 Thread fengchengwen
On 2021/11/2 11:40, Radha Mohan Chintakuntla wrote: > Add the copy_sg function that will do the multiple DMA transfers of > different sizes and different source/destination as well. > ... > > +static int > +cnxk_dmadev_copy_sg(void *dev_private, uint16_t vchan, > + const struct

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread fengchengwen
On 2021/9/9 20:45, Bruce Richardson wrote: > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: >> 09/09/2021 13:18, Bruce Richardson: >>> On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: 07/09/2021 14:56, Chengwen Feng: > + * The first three APIs are used to

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-15 Thread fengchengwen
Hi Thomas, Most fixed in V22, some please see inline comment Thanks. On 2021/9/9 18:33, Thomas Monjalon wrote: > Hi, > > I am having a surface look at the API. > I hope we can do better than previous libs. > > 07/09/2021 14:56, Chengwen Feng: >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -49

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-21 Thread fengchengwen
On 2021/9/22 2:11, Jerin Jacob wrote: > On Tue, Sep 21, 2021 at 10:42 PM Pai G, Sunil wrote: >> >> Hi Jerin, >> >> >> > To understand it better, Could you share more details on feedback > mechanism on your application enqueue > > app_enqueue_v1(.., nb_seg) > { >

Re: [dpdk-dev] [PATCH v5 04/16] dma/idxd: create dmadev instances on bus probe

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > When a suitable device is found during the bus scan/probe, create a dmadev > instance for each HW queue. Internal structures required for device > creation are also added. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Con

Re: [dpdk-dev] [PATCH v5 05/16] dma/idxd: create dmadev instances on pci probe

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > When a suitable device is found during the PCI probe, create a dmadev > instance for each HW queue. HW definitions required are also included. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > > --- > v4: reba

Re: [dpdk-dev] [PATCH v5 15/16] devbind: add dma device class

2021-09-21 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2021/9/17 23:24, Kevin Laatz wrote: > Add a new class for DMA devices. Devices listed under the DMA class are to > be used with the dmadev library. > > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > usertools/dpdk-devbind.py | 12 +--- > 1

Re: [dpdk-dev] [PATCH v5 07/16] dma/idxd: add configure and info_get functions

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > Add functions for device configuration. The info_get function is included > here since it can be useful for checking successful configuration. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > > --- > v2: >

Re: [dpdk-dev] [PATCH v5 08/16] dma/idxd: add start and stop functions for pci devices

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > Add device start/stop functions for DSA devices bound to vfio. For devices > bound to the IDXD kernel driver, these are not required since the IDXD > kernel driver takes care of this. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Revi

Re: [dpdk-dev] [PATCH v5 09/16] dma/idxd: add data-path job submission functions

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > Add data path functions for enqueuing and submitting operations to DSA > devices. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > doc/guides/dmadevs/idxd.rst | 64 +++ > drivers/dma/i

Re: [dpdk-dev] [PATCH v5 10/16] dma/idxd: add data-path job completion functions

2021-09-21 Thread fengchengwen
On 2021/9/17 23:24, Kevin Laatz wrote: > Add the data path functions for gathering completed operations. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > > --- > v2: >- fixed typo in docs >- add completion status for invalid opcode > --- >

Re: [dpdk-dev] [PATCH v5 11/16] dma/idxd: add operation statistic tracking

2021-09-21 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2021/9/17 23:24, Kevin Laatz wrote: > Add statistic tracking for DSA devices. > > Signed-off-by: Bruce Richardson > Signed-off-by: Kevin Laatz > Reviewed-by: Conor Walsh > --- > doc/guides/dmadevs/idxd.rst | 11 +++ > drivers/dma/idxd/idxd_bus.c

Re: [dpdk-dev] [PATCH v4 01/11] dma/ioat: add device probe and removal functions

2021-09-21 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2021/9/17 23:42, Conor Walsh wrote: > Add the basic device probe/remove skeleton code and initial documentation > for new IOAT DMA driver. Maintainers update is also included in this > patch. > > Signed-off-by: Conor Walsh > Reviewed-by: Kevin Laatz > --- > MAINT

Re: [dpdk-dev] [PATCH v4 02/11] dma/ioat: create dmadev instances on PCI probe

2021-09-22 Thread fengchengwen
On 2021/9/17 23:42, Conor Walsh wrote: > When a suitable device is found during the PCI probe, create a dmadev > instance for each channel. Internal structures and HW definitions required > for device creation are also included. > > Signed-off-by: Conor Walsh > Reviewed-by: Kevin Laatz > --- >

Re: [dpdk-dev] [PATCH v4 04/11] dma/ioat: add configuration functions

2021-09-22 Thread fengchengwen
On 2021/9/17 23:42, Conor Walsh wrote: > Add functions for device configuration. The info_get and close functions > are included here also. info_get can be useful for checking successful > configuration and close is used by the dmadev api when releasing a > configured device. > > Signed-off-by: Co

Re: [dpdk-dev] [PATCH v4 06/11] dma/ioat: add data path job submission functions

2021-09-22 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2021/9/17 23:42, Conor Walsh wrote: > Add data path functions for enqueuing and submitting operations to > IOAT devices. > > Signed-off-by: Conor Walsh > Reviewed-by: Kevin Laatz > --- > doc/guides/dmadevs/ioat.rst| 54 > drivers/dma/ioat

Re: [dpdk-dev] [PATCH v5 1/9] dmadev: add channel status check for testing use

2021-09-22 Thread fengchengwen
On 2021/9/17 21:54, Bruce Richardson wrote: > Add in a function to check if a device or vchan has completed all jobs > assigned to it, without gathering in the results. This is primarily for > use in testing, to allow the hardware to be in a known-state prior to > gathering completions. > > Signed

Re: [dpdk-dev] [PATCH v5 3/9] dmadev: add device iterator

2021-09-22 Thread fengchengwen
On 2021/9/17 21:54, Bruce Richardson wrote: > Add a function and wrapper macro to iterate over all dma devices. > > Signed-off-by: Bruce Richardson > --- > lib/dmadev/rte_dmadev.c | 13 + > lib/dmadev/rte_dmadev.h | 18 ++ > lib/dmadev/version.map | 1 + > 3 files c

Re: [dpdk-dev] [PATCH v3 2/8] dmadev: add burst capacity API

2021-09-23 Thread fengchengwen
On 2021/9/23 1:29, Jerin Jacob wrote: > On Wed, Sep 22, 2021 at 10:06 PM Bruce Richardson > wrote: >> >> On Wed, Sep 22, 2021 at 08:56:50AM +0100, Bruce Richardson wrote: >>> On Wed, Sep 22, 2021 at 09:51:42AM +0800, fengchengwen wrote: >>>> On 2021/9/22 2:1

Re: [dpdk-dev] [PATCH v2 0/6] port ioatfwd app to dmadev

2021-09-23 Thread fengchengwen
Hi Kevin, Can you add the following functions? 1. Add dump dmadev which trigger by signal, like: ... static void dma_dump(void) { uint32_t i, j; if (copy_mode != COPY_MODE_DMA_NUM) return; for (i = 0; i < cfg.nb_ports; i++) { for (j

Re: [dpdk-dev] [PATCH v2 4/6] examples/ioat: port application to dmadev APIs

2021-09-23 Thread fengchengwen
On 2021/9/18 0:41, Kevin Laatz wrote: > The dmadev library abstraction allows applications to use the same APIs for > all DMA device drivers in DPDK. This patch updates the ioatfwd application > to make use of the new dmadev APIs, in turn making it a generic application > which can be used with any

Re: [dpdk-dev] [PATCH v2] dmadev: introduce DMA device library

2021-07-11 Thread fengchengwen
Note: 1) This patch hold dmadev <> vchan layer, I think vchan can be very conceptually separated from hw-channel. 2) I could not under struct dpi_dma_queue_ctx_s, so this patch I define the rte_dma_slave_port_parameters refer to Kunpeng DMA implemention. 3) This patch hasn't include doxy rela

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-13 Thread fengchengwen
Thank you for your valuable comments, and I think we've taken a big step forward. @andrew Could you provide the copyright line so that I can add it to relevant file. @burce, jerin Some unmodified review comments are returned here: 1. COMMENT: We allow up to 100 characters per line for DPDK co

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

2021-07-15 Thread fengchengwen
On 2021/7/14 20:22, Nipun Gupta wrote: > > >> +/** >> + * A structure used to configure a virtual DMA channel. >> + */ >> +struct rte_dmadev_vchan_conf { >> +uint8_t direction; >> +/**< Set of supported transfer directions >> + * @see RTE_DMA_MEM_TO_MEM >> + * @see RTE_DMA_MEM_TO_

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread fengchengwen
@burce, jerin Some unmodified review comments are returned here: 1. COMMENT: > +memset(dmadev_shared_data->data, 0, > +sizeof(dmadev_shared_data->data)); I believe all memzones are zero on allocation anyway, so this memset is unecessary and can be d

Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library

2021-07-15 Thread fengchengwen
On 2021/7/16 0:33, Bruce Richardson wrote: > On Fri, Jul 16, 2021 at 12:04:33AM +0800, fengchengwen wrote: >> @burce, jerin Some unmodified review comments are returned here: >> [snip] > >> 2. COMMENT: > + * @see struct rte_dmadev_info::dev_capa >>> + */ &

Re: [dpdk-dev] [PATCH v3] config/arm: split march cfg into arch and features

2021-07-15 Thread fengchengwen
[snip] >> + >> +# probe supported marchs and their features >> +candidate_march = '' >> +if part_number_config.has_key('march') >> +supported_marchs = ['armv8.6-a', 'armv8.5-a', 'armv8.4-a', >> 'armv8.3-a', >> +'armv8.2-a', 'armv8.1-a', 'armv8-a']

Re: [dpdk-dev] [PATCH v6] dmadev: introduce DMA device library

2021-07-19 Thread fengchengwen
Many thank. Most of the comment fixed in v7, and v7 still include implementation. I did a thorough test of the implementation, so could you please review the implementation also ? One comment is modified as follows: COMMENT: >> +*| | |-- >> +

Re: [dpdk-dev] [PATCH v8] dmadev: introduce DMA device library

2021-07-19 Thread fengchengwen
Thanks Jerin, comment inline On 2021/7/20 13:03, Jerin Jacob wrote: > On Tue, Jul 20, 2021 at 6:48 AM Chengwen Feng wrote: >> >> This patch introduce 'dmadevice' which is a generic type of DMA >> device. >> >> The APIs of dmadev library exposes some generic operations which can >> enable configur

[dpdk-dev] Question about hardware error handling policy

2021-07-22 Thread fengchengwen
Hi, all I notice ethdev support dev_reset ops, which could be used to recover from errors, and only 13+ drivers support this function. And also there is event for reset: RTE_ETH_EVENT_INTR_RESET, and only 6 drivers support it (most of them are VF). This provides users with two ways to

Re: [dpdk-dev] Question about hardware error handling policy

2021-07-22 Thread fengchengwen
On 2021/7/22 23:46, Thomas Monjalon wrote: > 22/07/2021 15:50, fengchengwen: >> Hi, all >> >> I notice ethdev support dev_reset ops, which could be used to recover >> from >> errors, and only 13+ drivers support this function. >> And also there is ev

Re: [dpdk-dev] Question about hardware error handling policy

2021-07-25 Thread fengchengwen
Hi On 2021/7/25 23:12, Matan Azrad wrote: > Hi > > From: fengchengwen: >> On 2021/7/22 23:46, Thomas Monjalon wrote: >>> 22/07/2021 15:50, fengchengwen: >>>> Hi, all >>>> >>>> I notice ethdev support dev_reset ops, which could be us

Re: [dpdk-dev] [PATCH v10] dmadev: introduce DMA device library

2021-07-25 Thread fengchengwen
Friendly ping. On 2021/7/20 20:46, Chengwen Feng wrote: > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng > --

[dpdk-dev] Question about ARM rte power intrinsics

2021-07-26 Thread fengchengwen
Hi, ARM guys I notice patch "Use WFE for spinlock and ring" was already accepted, and currently lib/eal/arm/rte_power_intrinsics.c still NULL implementation and it seem could use WFE to implement it, so do you have a plan for it ? Thanks

Re: [dpdk-dev] [PATCH v10] dmadev: introduce DMA device library

2021-07-26 Thread fengchengwen
+0800, fengchengwen wrote: >> Friendly ping. >> >> On 2021/7/20 20:46, Chengwen Feng wrote: >>> This patch introduce 'dmadevice' which is a generic type of DMA >>> device. >>> >>> The APIs of dmadev library exposes some generic oper

Re: [dpdk-dev] [PATCH v11 1/2] dmadev: introduce DMA device library

2021-07-28 Thread fengchengwen
Thanks, inline comment On 2021/7/28 19:13, Bruce Richardson wrote: > On Tue, Jul 27, 2021 at 11:39:59AM +0800, Chengwen Feng wrote: >> This patch introduce 'dmadevice' which is a generic type of DMA >> device. >> >> The APIs of dmadev library exposes some generic operations which can >> enable con

Re: [dpdk-dev] [PATCH v11 2/2] doc: add dmadev library guide

2021-07-29 Thread fengchengwen
On 2021/7/29 19:02, Jerin Jacob wrote: [snip] >> + >> +The DMA library follows the same basic principles as those used in DPDK's >> +Ethernet Device framework and the RegEx framework. The DMA framework >> provides >> +a generic DMA device framework which supports both physical (hardware) >> +and

Re: [dpdk-dev] [PATCH v11 2/2] doc: add dmadev library guide

2021-07-29 Thread fengchengwen
sorry, self-response, add an explanation inline On 2021/7/29 21:13, fengchengwen wrote: > On 2021/7/29 19:02, Jerin Jacob wrote: > > [snip] > >>> + >>> +The DMA library follows the same basic principles as those used in DPDK's >>> +Ethernet Devic

Re: [dpdk-dev] [PATCH v11 1/2] dmadev: introduce DMA device library

2021-07-29 Thread fengchengwen
Thanks, comment inline On 2021/7/29 18:44, Jerin Jacob wrote: > On Thu, Jul 29, 2021 at 6:56 AM fengchengwen wrote: >> >> Thanks, inline comment >> >> On 2021/7/28 19:13, Bruce Richardson wrote: >>> On Tue, Jul 27, 2021 at 11:39:59AM +0800, Chengwen F

Re: [dpdk-dev] [PATCH v11 1/2] dmadev: introduce DMA device library

2021-07-29 Thread fengchengwen
Thanks, comment inline On 2021/7/29 17:15, Bruce Richardson wrote: > On Thu, Jul 29, 2021 at 09:26:31AM +0800, fengchengwen wrote: >> Thanks, inline comment >> >> On 2021/7/28 19:13, Bruce Richardson wrote: >>> On Tue, Jul 27, 2021 at 11:39:59AM +0800, Chengw

Re: [dpdk-dev] [PATCH v13 0/6] support dmadev

2021-08-03 Thread fengchengwen
@Bruce @Jerin @Morten Could you please review 'doc: add DMA device library guide' patch ? PS: other patchs are well reviewed. Thanks On 2021/8/3 19:29, Chengwen Feng wrote: > This patch set contains six patch for new add dmadev. > > Chengwen Feng (6): > dmadev: introduce DMA device library pu

[dpdk-dev] Fwd: [dpdk] Patch notification: 6 patches updated

2021-08-03 Thread fengchengwen
Hi, Thomas Why the dmadev patchset v12/13 both deferred ? Does it have anything to do with the completion of 21.08? Thanks Forwarded Message Subject: [dpdk] Patch notification: 6 patches updated Date: Tue, 3 Aug 2021 12:20:03 + From: DPDK patchwork To: fengcheng...@huawei.

Re: [dpdk-dev] Fwd: [dpdk] Patch notification: 6 patches updated

2021-08-03 Thread fengchengwen
On 2021/8/3 20:59, Thomas Monjalon wrote: > 03/08/2021 14:54, fengchengwen: >> Hi, Thomas >> >> Why the dmadev patchset v12/13 both deferred ? Does it have anything to do >> with >> the completion of 21.08? > > We are fixing the last critical bugs to close

Re: [dpdk-dev] [PATCH v13 4/6] dmadev: introduce DMA device library implementation

2021-08-05 Thread fengchengwen
On 2021/8/5 20:56, Walsh, Conor wrote: >> This patch introduce DMA device library implementation which includes >> configuration and I/O with the DMA devices. [snip] >> >> /** >> * @warning >> @@ -952,10 +1029,27 @@ rte_dmadev_completed(uint16_t dev_id, >> uint16_t vchan, const uint16_t nb_cpl

Re: [dpdk-dev] [PATCH v13 5/6] doc: add DMA device library guide

2021-08-05 Thread fengchengwen
On 2021/8/3 22:55, Jerin Jacob wrote: > On Tue, Aug 3, 2021 at 5:03 PM Chengwen Feng wrote: >> >> This patch adds dmadev library guide. >> >> Signed-off-by: Chengwen Feng >> --- >> doc/guides/prog_guide/dmadev.rst| 126 +++ > > > doc build has following warning in my machine

Re: [dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide

2021-08-10 Thread fengchengwen
Many thanks, will fix in v15 On 2021/8/10 23:27, Walsh, Conor wrote: > [snip] > > Hi Chengwen, > I have included some feedback to improve the grammar and readability > of the docs inline. > [snip]

Re: [dpdk-dev] [PATCH v14 5/6] doc: add DMA device library guide

2021-08-13 Thread fengchengwen
Hi Conor, Already sent v15, Most of feedback modified, unmodified inline Thanks. On 2021/8/10 23:27, Walsh, Conor wrote: > [snip] > > Hi Chengwen, > I have included some feedback to improve the grammar and readability > of the docs inline. > [snip] >> +the EAL command line options. >> + >> +

RE: [PATCH v2 0/2] performance optimized for hns3 PMD

2021-11-16 Thread Fengchengwen
May be forgotten, I send v2 to him this morning, and maybe forgot adding the sign off. But the patch set is OK because we both check them. 发件人:Ferruh Yigit 收件人:humin (Q) ;dev 抄 送:thomas 时 间:2021-11-16 22:37:23 主 题:Re: [PATCH v2 0/2] performance optimized for hns3 PMD On 11/16/2021 1:22 AM, M

Re: [PATCH] telemetry: rework code to avoid compiler warnings

2023-02-08 Thread fengchengwen
Beatutiful +1 Acked-by: Chengwen Feng On 2023/2/8 22:37, Bruce Richardson wrote: > When printing values as hex strings, the telemetry code temporarily > disabled warnings about non-literal format strings. This was because the > actual format string was built-up programmatically to ensure the out

Re: [PATCH v4 2/5] telemetry: fix repeat display when callback don't init dict

2023-02-08 Thread fengchengwen
On 2023/2/8 22:15, Bruce Richardson wrote: > On Fri, Jan 20, 2023 at 03:34:53AM +, Chengwen Feng wrote: >> When a telemetry callback doesn't initialize the telemetry data >> structure and returns a non-negative number, the telemetry will repeat >> to display the last result. This patch zero the

Re: [PATCH v4 0/5] support dmadev/ethdev stats reset

2023-02-08 Thread fengchengwen
On 2023/2/8 22:17, Bruce Richardson wrote: > On Fri, Jan 20, 2023 at 03:34:51AM +, Chengwen Feng wrote: >> This patchset contains dmadev/ethdev stats reset, and also support >> hide zero for ethdev xstats and two telemetry related bugs. >> >> Chengwen Feng (5): >> dmadev: support stats reset

Re: [PATCH] mem: fix displaying heap ID failed for heap info command

2023-02-08 Thread fengchengwen
Acked-by: Chengwen Feng And, how abort add error log in telemetry valid_name, so so that problems can be identified as early as possible. On 2023/2/9 11:03, Huisong Li wrote: > The telemetry lib has added a allowed characters set for dictionary names, > See commit > 2537fb0c5f34 ("telemetry: lim

Re: [PATCH v13 1/6] memarea: introduce memarea library

2023-02-08 Thread fengchengwen
On 2023/2/9 8:04, Stephen Hemminger wrote: > On Wed, 8 Feb 2023 08:24:47 + > Chengwen Feng wrote: > >> +RTE_LOG_REGISTER_DEFAULT(rte_memarea_logtype, INFO); >> +#define RTE_MEMAREA_LOG(level, ...) \ >> +rte_log(RTE_LOG_ ## level, rte_memarea_logtype, RTE_FMT("memarea: " \ >> +

Re: [PATCH] ethdev: telemetry xstats support hide zero

2023-02-09 Thread fengchengwen
On 2023/2/10 7:30, Ferruh Yigit wrote: > On 2/9/2023 3:07 AM, Chengwen Feng wrote: >> The number of xstats may be large, after the hide zero option is added, >> only non-zero values can be displayed. >> > > Hi Chengwen, > > No objection on the functionality, we have similar config option in > tes

Re: [PATCH v3 01/16] gso: remove logtype

2023-02-09 Thread fengchengwen
On 2023/2/10 9:07, Stephen Hemminger wrote: > If a large packet is passed into GSO routines of unknown protocol > then library would log a message and pass it through. This is incorrect > behaviour on many levels: > - it allows oversize packet to get passed on to NIC driver > - no direct return

Re: [PATCH v3 03/16] efd: replace RTE_LOGTYPE_EFD with local type

2023-02-09 Thread fengchengwen
On 2023/2/10 9:07, Stephen Hemminger wrote: > Replace all uses of global logtype with a local log type. > Do not break message formats across source lines. > > Signed-off-by: Stephen Hemminger > --- ... > }; > EAL_REGISTER_TAILQ(rte_efd_tailq); > > +RTE_LOG_REGISTER_DEFAULT(efd_logtype, INF

Re: [PATCH v8] mempool cache: add zero-copy get and put functions

2023-02-10 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/2/9 22:58, Morten Brørup wrote: > Zero-copy access to mempool caches is beneficial for PMD performance, and > must be provided by the mempool library to fix [Bug 1052] without a > performance regression. > > [Bug 1052]: https://bugs.dpdk.org/show_bug.cgi?id=1052 >

Re: [PATCH] ethdev: telemetry xstats support hide zero

2023-02-12 Thread fengchengwen
On 2023/2/10 19:55, Ferruh Yigit wrote: > On 2/10/2023 1:23 AM, fengchengwen wrote: >> On 2023/2/10 7:30, Ferruh Yigit wrote: >>> On 2/9/2023 3:07 AM, Chengwen Feng wrote: >>>> The number of xstats may be large, after the hide zero option is added, >>>

Re: [PATCH v2] ethdev: telemetry xstats support hide zero

2023-02-13 Thread fengchengwen
On 2023/2/14 2:18, Ferruh Yigit wrote: > On 2/13/2023 2:34 AM, Chengwen Feng wrote: >> The number of xstats may be large, after the hide zero option is added, >> only non-zero values can be displayed. >> >> So display xstats with hide zero: >> /ethdev/xstats,0,hide_zero=true >> and without hid

Re: [PATCH v2 4/6] test/dmadev: check result for device stop

2023-02-14 Thread fengchengwen
Sorry late to see. On 2023/1/17 1:37, Bruce Richardson wrote: > The DMA device stop API can return an error value so check that return > value when running dmadev unit tests. > > Signed-off-by: Bruce Richardson > --- > app/test/test_dmadev.c | 6 +- > 1 file changed, 5 insertions(+), 1 dele

Re: [PATCH v2 5/6] test/dmadev: create separate function for single copy test

2023-02-14 Thread fengchengwen
On 2023/1/17 1:37, Bruce Richardson wrote: > The copy tests for dmadev had separate blocks in the test function for > single copy and burst copies. Separate out the single-copy block to its > own function so that it can be re-used if necessary. > > Signed-off-by: Bruce Richardson Acked-by: Cheng

Re: [PATCH v2 6/6] test/dmadev: add tests for stopping and restarting dev

2023-02-14 Thread fengchengwen
On 2023/1/17 1:37, Bruce Richardson wrote: > Validate device operation when a device is stopped or restarted. > > The only complication - and gap in the dmadev ABI specification - is > what happens to the job ids on restart. Some drivers reset them to 0, > while others continue where things left o

Re: [PATCH v4 0/3] add telemetry cmds for ring

2023-02-14 Thread fengchengwen
LGTM Series-acked-by: Chengwen Feng On 2023/2/10 10:48, Jie Hai wrote: > This patch set supports telemetry cmd to list rings and dump information > of a ring by its name. > > v1->v2: > 1. Add space after "switch". > 2. Fix wrong strlen parameter. > > v2->v3: > 1. Remove prefix "rte_" for static

Re: [PATCH v2 6/6] test/dmadev: add tests for stopping and restarting dev

2023-02-15 Thread fengchengwen
On 2023/2/15 19:57, Bruce Richardson wrote: > On Wed, Feb 15, 2023 at 09:59:06AM +0800, fengchengwen wrote: >> On 2023/1/17 1:37, Bruce Richardson wrote: >>> Validate device operation when a device is stopped or restarted. >>> >>> The only complication - and

Re: [PATCH] eal/bsd: fix spinlock not unlock in alarm callback

2023-02-15 Thread fengchengwen
add cc maintainer On 2023/2/13 20:44, Chengwen Feng wrote: > The spinlock should unlock when clock_gettime() failed. This patch > fixes it by invoking clock_gettime() before lock. > > Fixes: 26021a715067 ("eal/bsd: support alarm API") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > ---

Re: [PATCH] ethdev: add link speed 400G

2023-02-16 Thread fengchengwen
Hi Thomas, Higher rates are generally implemented with multiple lanes. The lane configuration is critical to link negotiation success. The number of lanes configured using the ethtool is provided [1]. Currently, the community uses only one u32 bit (link_speed) to indicate a rate, which is n

Re: [PATCH v3 4/6] test/dmadev: check result for device stop

2023-02-16 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/2/16 19:09, Bruce Richardson wrote: > The DMA device stop API can return an error value so check that return > value when running dmadev unit tests. > > Signed-off-by: Bruce Richardson > Reviewed-by: Conor Walsh > Acked-by: Kevin Laatz > --- > app/test/test_dm

Re: [PATCH v3 6/6] test/dmadev: add tests for stopping and restarting dev

2023-02-16 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/2/16 19:09, Bruce Richardson wrote: > Validate device operation when a device is stopped or restarted. > > The only complication - and gap in the dmadev ABI specification - is > what happens to the job ids on restart. Some drivers reset them to 0, > while others c

Re: [PATCH v5 2/2] ethdev: support xstats reset telemetry command

2023-02-16 Thread fengchengwen
On 2023/2/15 11:19, Dongdong Liu wrote: > Hi Chengwen > > On 2023/2/9 10:32, Chengwen Feng wrote: >> The xstats reset is useful for debugging, so add it to the ethdev >> telemetry command lists. >> >> Signed-off-by: Chengwen Feng > This patch looks good, so > Reviewed-by: Dongdong Liu > > A min

Re: [PATCH v5 2/2] ethdev: support xstats reset telemetry command

2023-02-16 Thread fengchengwen
On 2023/2/16 20:06, Ferruh Yigit wrote: > On 2/16/2023 11:53 AM, fengchengwen wrote: >> On 2023/2/15 11:19, Dongdong Liu wrote: >>> Hi Chengwen >>> >>> On 2023/2/9 10:32, Chengwen Feng wrote: >>>> The xstats reset is useful for debugging, so a

Re: [PATCH v5 2/2] ethdev: support xstats reset telemetry command

2023-02-17 Thread fengchengwen
On 2023/2/16 20:54, Bruce Richardson wrote: > On Thu, Feb 16, 2023 at 08:42:34PM +0800, fengchengwen wrote: >> On 2023/2/16 20:06, Ferruh Yigit wrote: >>> On 2/16/2023 11:53 AM, fengchengwen wrote: >>>> On 2023/2/15 11:19, Dongdong Liu wrote: >>>>&

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-19 Thread fengchengwen
On 2023/2/20 14:08, Ashok Kaladi wrote: > If ethdev enqueue or dequeue function is called during > eth_dev_fp_ops_setup(), it may get pre-empted after setting > the function pointers, but before setting the pointer to port data. > In this case the newly registered enqueue/dequeue function will use

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-19 Thread fengchengwen
Sorry resend, because forget one line. On 2023/2/20 14:08, Ashok Kaladi wrote: > If ethdev enqueue or dequeue function is called during > eth_dev_fp_ops_setup(), it may get pre-empted after setting > the function pointers, but before setting the pointer to port data. > In this case the newly regis

Re: [PATCH] net/hns3: support disable IOVA as PA mode

2023-02-20 Thread fengchengwen
On 2023/2/20 15:44, Thomas Monjalon wrote: > 16/02/2023 09:36, Ruifeng Wang: >> From: Chengwen Feng >>> Subject: [PATCH] net/hns3: support disable IOVA as PA mode > > Could we change the title to "support IOVA as VA" ? v2 fix it, please review, thanks. > >>> >>> Claim PMD supports pmd_supports

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-21 Thread fengchengwen
On 2023/2/22 1:00, Stephen Hemminger wrote: > On Tue, 21 Feb 2023 07:24:19 + > Ruifeng Wang wrote: > >>> -Original Message- >>> From: fengchengwen >>> Sent: Monday, February 20, 2023 2:58 PM >>> To: Ashok Kaladi ; jer...@marvell.com;

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-23 Thread fengchengwen
On 2023/2/23 12:40, Honnappa Nagarahalli wrote: > > >> >> On 2023/2/20 14:08, Ashok Kaladi wrote: >>> If ethdev enqueue or dequeue function is called during >>> eth_dev_fp_ops_setup(), it may get pre-empted after setting the >>> function pointers, but before setting the pointe

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-24 Thread fengchengwen
On 2023/2/23 21:31, Konstantin Ananyev wrote: > > > If ethdev enqueue or dequeue function is called during > eth_dev_fp_ops_setup(), it may get pre-empted after setting the > function pointers, but before setting the pointer to port data. > In this case the newly r

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-26 Thread fengchengwen
On 2023/2/27 1:22, Konstantin Ananyev wrote: > >>> If ethdev enqueue or dequeue function is called during >>> eth_dev_fp_ops_setup(), it may get pre-empted after setting the >>> function pointers, but before setting the pointer to port data. >>> In this case the new

Re: [PATCH 0/9] fix kvargs callback prototype not clearly defined

2023-03-02 Thread fengchengwen
Sorry to resend, because the original v1 --cc-cmd failed. On 2023/3/2 15:50, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. >

Re: [EXT] [PATCH 4/9] cryptodev: fix segment fault when parse input args

2023-03-02 Thread fengchengwen
On 2023/3/2 16:11, Akhil Goyal wrote: >> The rte_kvargs_process() was used to parse KV pairs, it also supports >> to parse 'only keys' (e.g. socket_id) type. And the callback function >> parameter 'value' is NULL when parsed 'only keys'. >> >> This patch fixes segment fault when parse input args wi

Re: [PATCH 4/5] net/bnxt: use fp ops setup function

2023-03-02 Thread fengchengwen
On 2023/3/2 20:30, Konstantin Ananyev wrote: > >> Use rte_eth_fp_ops_setup() instead of directly manipulating >> rte_eth_fp_ops variable. >> >> Cc: sta...@dpdk.org >> >> Signed-off-by: Chengwen Feng >> --- >> drivers/net/bnxt/bnxt_cpr.c| 5 + >> drivers/net/bnxt/bnxt_ethdev.c | 5 + >

Re: [PATCH 5/5] app/testpmd: add error recovery usage demo

2023-03-02 Thread fengchengwen
On 2023/3/2 21:01, Konstantin Ananyev wrote: > > >> >> This patch adds error recovery usage demo which will: >> 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event >>is received. >> 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS >>event is received.

Re: [PATCH 4/5] net/bnxt: use fp ops setup function

2023-03-02 Thread fengchengwen
On 2023/3/3 8:01, Konstantin Ananyev wrote: > 02/03/2023 12:30, Konstantin Ananyev пишет: >> >>> Use rte_eth_fp_ops_setup() instead of directly manipulating >>> rte_eth_fp_ops variable. >>> >>> Cc: sta...@dpdk.org >>> >>> Signed-off-by: Chengwen Feng >>> --- >>>   drivers/net/bnxt/bnxt_cpr.c    |

<    1   2   3   4   5   6   7   >