RE: [PATCH 1/3] ethdev: add frequency adjustment API

2023-09-27 Thread Su, Simei
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Monday, September 18, 2023 10:51 PM > To: Su, Simei ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Rybalchenko, Kirill > ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 > Subject: Re: [PATCH 1/

RE: [PATCH 3/3] examples/ptpclient: add frequency adjustment support

2023-09-27 Thread Su, Simei
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Monday, September 18, 2023 10:55 PM > To: Su, Simei ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Rybalchenko, Kirill > ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 > Subject: Re: [PATCH

[PATCH] net/ice: fix race condition for multi-cores

2022-06-07 Thread Simei Su
iptor") Fixes: 5543827fc6df ("net/ice: improve performance of Rx timestamp offload") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- drivers/net/ice/ice_ethdev.h | 3 --- drivers/net/ice/ice_rxtx.c | 48 ++-- drivers/net/ice/ice_rxtx.h | 3

[PATCH] net/ice: fix ieee1588fwd not show PTP timestamp

2022-01-20 Thread Simei Su
For received PTP packets, the flag "RTE_MBUF_F_RX_IEEE1588_TMST" has not been set which leads to received PTP packet not timestamped by hardware shown in testpmd/ieee1588 fwd. Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Simei Su

[PATCH] net/ice: fix incorrect Rx timestamp in Windows PTP

2022-01-23 Thread Simei Su
.@dpdk.org Signed-off-by: Simei Su --- drivers/net/ice/ice_ethdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 13a7a97..d57355d 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c

[PATCH v2] net/ice: fix missing clock initialization

2022-01-27 Thread Simei Su
.@dpdk.org Signed-off-by: Simei Su --- v2: * Rename commit title. drivers/net/ice/ice_ethdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index d01acb8..dbf822e 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drive

[PATCH v3] net/ice: fix missing clock initialization

2022-02-10 Thread Simei Su
.@dpdk.org Signed-off-by: Simei Su --- v3: * Fix use of undeclared identifier 'CLOCK_MONOTONIC'. v2: * Rename commit title. drivers/net/ice/ice_ethdev.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c in

[dpdk-dev] [PATCH] net/ice: fix performance issue for Rx timestamp

2021-10-28 Thread Simei Su
be6c701 ("net/ice: support IEEE 1588 PTP") Suggested-by: Harry van Haaren Signed-off-by: Simei Su --- drivers/net/ice/ice_ethdev.c | 4 +-- drivers/net/ice/ice_ethdev.h | 1 + drivers/net/ice/ice_rxtx.c | 59 ++-- drivers/net/ice/ice_rxtx.h |

[dpdk-dev] [PATCH v2] net/ice: fix performance issue for Rx timestamp

2021-10-28 Thread Simei Su
be6c701 ("net/ice: support IEEE 1588 PTP") Suggested-by: Harry van Haaren Signed-off-by: Simei Su --- v2: * Add "guard band" of checking wrap-around. drivers/net/ice/ice_ethdev.c | 4 +-- drivers/net/ice/ice_ethdev.h | 1 + drivers/net/ice/ice_rxtx.c | 59 +++

[dpdk-dev] [PATCH v3] net/ice: fix performance issue for Rx timestamp

2021-10-29 Thread Simei Su
be6c701 ("net/ice: support IEEE 1588 PTP") Suggested-by: Harry van Haaren Signed-off-by: Simei Su --- v3: * Use a macro to replace the "guard band" number. v2: * Add "guard band" of checking wrap-around. drivers/net/ice/ice_ethdev.c | 4 +--

[dpdk-dev] [PATCH v4] net/ice: fix performance issue for Rx timestamp

2021-10-29 Thread Simei Su
be6c701 ("net/ice: support IEEE 1588 PTP") Suggested-by: Harry van Haaren Signed-off-by: Simei Su --- v4: * Correct typo spelling. v3: * Use a macro to replace the "guard band" number. v2: * Add "guard band" of checking wrap-around. drivers/net/ice/ice_ethdev.c |

[dpdk-dev] [PATCH v3] net/ice: add 1PPS support for E810

2021-09-14 Thread Simei Su
for test command is as below: ./build/app/dpdk-testpmd -a af:00.0,pps_out='[pin:2]' -c f -n 4 -- -i Signed-off-by: Simei Su --- v3: * Rebase patch based on the latest code. v2: * Update the ice.rst for the new devargs. * Add the release notes. doc/guides/nics/ice.rst|

[dpdk-dev] [PATCH] net/ice: enable Rx timestamp on Flex Descriptor

2021-09-18 Thread Simei Su
Use the dynamic mbuf to register timestamp field and flag. The ice has the feature to dump Rx timestamp value into dynamic mbuf field by flex descriptor. This feature is turned on by dev config "enable-rx-timestamp". Currently, it's only supported under scalar path. Signed-o

[dpdk-dev] [PATCH v4] net/ice: support IEEE 1588 PTP for E810

2021-09-22 Thread Simei Su
ff-by: Simei Su --- v4: * Rework code to consider ice_dev_start and ice_timesync_enable order. v3: * Rework code to support scalar path only. * Update the doc/guides/nics/features/ice.ini to add "Timesync" feature. * Add release notes. v2: * Change patchset to one patch based on sh

Re: [dpdk-dev] [PATCH] net/ice: fix double free ACL flow entry

2021-09-23 Thread Su, Simei
> -Original Message- > From: Yu, DapengX > Sent: Friday, September 3, 2021 6:04 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Su, Simei ; Yu, DapengX > ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix double free ACL flow entry > >

Re: [dpdk-dev] [PATCH] net/ice: enable Rx timestamp on Flex Descriptor

2021-09-24 Thread Su, Simei
Hi, Qi > -Original Message- > From: Zhang, Qi Z > Sent: Friday, September 24, 2021 1:25 PM > To: Su, Simei > Cc: dev@dpdk.org; Wang, Haiyue > Subject: RE: [PATCH] net/ice: enable Rx timestamp on Flex Descriptor > > > > > -Original Message--

[dpdk-dev] [PATCH v2] net/ice: enable Rx timestamp on Flex Descriptor

2021-09-25 Thread Simei Su
Use the dynamic mbuf to register timestamp field and flag. The ice has the feature to dump Rx timestamp value into dynamic mbuf field by flex descriptor. This feature is turned on by dev config "enable-rx-timestamp". Currently, it's only supported under scalar path. Signed-o

[dpdk-dev] [PATCH v3] net/ice: enable Rx timestamp on Flex Descriptor

2021-09-26 Thread Simei Su
Use the dynamic mbuf to register timestamp field and flag. The ice has the feature to dump Rx timestamp value into dynamic mbuf field by flex descriptor. This feature is turned on by dev config "enable-rx-timestamp". Currently, it's only supported under scalar path. Signed-o

[dpdk-dev] [PATCH v4] net/ice: enable Rx timestamp on Flex Descriptor

2021-09-26 Thread Simei Su
Use the dynamic mbuf to register timestamp field and flag. The ice has the feature to dump Rx timestamp value into dynamic mbuf field by flex descriptor. This feature is turned on by dev config "enable-rx-timestamp". Currently, it's only supported under scalar path. Signed-o

[dpdk-dev] [PATCH v5] net/ice: support IEEE 1588 PTP

2021-09-27 Thread Simei Su
ff-by: Simei Su --- v5: * Refine patch title and commit log. * Simplify judge logic in ice_timesync_enable and ice_program_hw_rx_queue. * Add flag reset in ice_timesync_disable. v4: * Rework code to consider ice_dev_start and ice_timesync_enable order. v3: * Rework code to support scalar path

[dpdk-dev] [PATCH v6] net/ice: support IEEE 1588 PTP

2021-09-27 Thread Simei Su
ff-by: Simei Su --- v6: * Refine to simplify judge logic in ice_program_hw_rx_queue. * Remove "else" branch if already return in "if" branch. v5: * Refine patch title and commit log. * Simplify judge logic in ice_timesync_enable and ice_program_hw_rx_queue. * Add flag rese

[dpdk-dev] [PATCH] net/ice: fix SPI for ESP and NATT not work issue

2021-07-12 Thread Simei Su
ned-off-by: Simei Su --- drivers/net/ice/ice_fdir_filter.c | 14 ++ drivers/net/ice/ice_generic_flow.h | 3 +++ 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c index 4f1aa39..82adb1f 100644 --- a/drive

Re: [dpdk-dev] [PATCH] net/ice: fix SPI for ESP and NATT not work issue

2021-07-12 Thread Su, Simei
Hi, Qi > -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, July 13, 2021 9:07 AM > To: Su, Simei > Cc: dev@dpdk.org; Cao, Yahui > Subject: RE: [PATCH] net/ice: fix SPI for ESP and NATT not work issue > > > > > -Original Message- >

[dpdk-dev] [PATCH v2] net/ice: fix FDIR when SPI as input set for ESP flow

2021-07-12 Thread Simei Su
Fixes: 70feafc1a3f2 ("net/ice: support ESP/NATT flow director to match outer IP") Signed-off-by: Simei Su v2: * Refine title and commit log to be more accurate. * Correct spelling mistakes in commit log. --- drivers/net/ice/ice_fdir_filter.c | 14 ++ drivers/net/ice/ice

[dpdk-dev] [PATCH] net/ice: fix max entry number for ACL normal priority

2021-07-27 Thread Simei Su
ilter in DCF") Signed-off-by: Simei Su --- drivers/net/ice/ice_acl_filter.c | 4 ++-- drivers/net/ice/ice_ethdev.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_acl_filter.c b/drivers/net/ice/ice_acl_filter.c index 3375609..0c15a70 100644 ---

[dpdk-dev] [PATCH 0/4] net/ice: support IEEE 1588

2021-08-05 Thread Simei Su
for device clock control net/ice/base: add clock initialization function Simei Su (1): net/ice: support IEEE 1588 PTP drivers/net/ice/base/ice_adminq_cmd.h |2 + drivers/net/ice/base/ice_cgu_regs.h | 117 ++ drivers/net/ice/base/ice_common.c | 254 drivers/net/ice/base

[dpdk-dev] [PATCH 1/4] net/ice/base: add 1588 capability probe

2021-08-05 Thread Simei Su
From: Qi Zhang Parse 1588 timesync capability during device capability probing. Signed-off-by: Jacob Keller Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 1 + drivers/net/ice/base/ice_common.c | 111 ++ drivers/net/ice/base/ice_type.

[dpdk-dev] [PATCH 2/4] net/ice/base: add low level functions for device clock control

2021-08-05 Thread Simei Su
From: Qi Zhang The ice hardware supports exposing a hardware clock for high precision timestamping. This is primarily intended for accelerating the Precision Time Protocol. Add several low level functions intended to be used as the basis for enabling the device clock, and ensuring that the port

[dpdk-dev] [PATCH 3/4] net/ice/base: add clock initialization function

2021-08-05 Thread Simei Su
From: Qi Zhang Before the device PTP hardware clock can be initialized, some steps must be taken by the driver. This includes writing some registers and initializing the PHY. Some of these steps are distinct depending on the device type (E810 or E822). Additionally, a future change will introduc

[dpdk-dev] [PATCH 4/4] net/ice: support IEEE 1588 PTP

2021-08-05 Thread Simei Su
igned-off-by: Simei Su --- drivers/net/ice/ice_ethdev.c | 226 ++- drivers/net/ice/ice_ethdev.h | 5 + drivers/net/ice/ice_rxtx.c | 42 +++- drivers/net/ice/ice_rxtx.h | 1 + 4 files changed, 272 insertions(+), 2 deletions(-) diff --git a/driver

RE: [PATCH v2] net/i40e: don't check link status on device start

2023-02-07 Thread Su, Simei
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, February 7, 2023 7:32 PM > To: Zhang, Helin ; Su, Simei > Cc: David Marchand ; dev@dpdk.org; Zhang, > Yuying ; Xing, Beilei ; > Mcnamara, John ; sta...@dpdk.org; Zhang, Qi Z > ; Dapeng Yu ;

[PATCH v6] net/i40e: rework maximum frame size configuration

2023-02-20 Thread Simei Su
/i40e: fix max frame size config at port level") Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") Cc: sta...@dpdk.org Reported-by: David Marchand Signed-off-by: Simei Su --- v6: * Refine commit log. * Remove return error. v5: * Fix misspelling in commit log. v4: * Refi

[PATCH] net/ice: fix incorrect Rx timestamp for E822

2023-03-02 Thread Simei Su
t IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- drivers/net/ice/ice_ethdev.c | 31 ++- drivers/net/ice/ice_rxtx.h | 11 ++- 2 files changed, 28 insertions(+), 14 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ic

RE: [PATCH v2] net/i40e: don't check link status on device start

2023-03-05 Thread Su, Simei
an_be_set) { > - status = i40e_aq_set_mac_config(hw, size, TRUE, 0, false, NULL); > - if (status != I40E_SUCCESS) > - PMD_DRV_LOG(ERR, "Failed to set max frame size at port > level"); > - } else { > - PMD_DRV_LOG(ERR, "Set max frame size at port level not > applicable > on link down"); > - } > -} > - > RTE_LOG_REGISTER_SUFFIX(i40e_logtype_init, init, NOTICE); > RTE_LOG_REGISTER_SUFFIX(i40e_logtype_driver, driver, NOTICE); #ifdef > RTE_ETHDEV_DEBUG_RX > -- > 2.38.1 Acked-by: Simei Su Thanks, Simei

[PATCH v7] net/i40e: fix max frame size configuration

2023-03-06 Thread Simei Su
This patch sets max frame size at port level rather than queue level to avoid unexpected packets received by port. Fixes: 34fe803c051f ("net/i40e: don't check link status on device start") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- v7: * Split v6 patch into two parts: - D

[PATCH v2] net/ice: fix incorrect Rx timestamp

2023-03-07 Thread Simei Su
("net/ice: support IEEE 1588 PTP") Fixes: fb800fde66f4 ("net/ice/base: work around missing PTP capabilities") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- v2: * Refine commit title and commit log. * Remove duplicate code. * Rework share code for "SIMICS_SUPPORT".

[RFC v3 0/3] add frequency adjustment support for PTP timesync

2023-05-22 Thread Simei Su
more description for the new API. v2: * Remove the ice PMD part from the RFC. * Add description in cover letter. * Refine commit log in patch. Simei Su (3): ethdev: add frequency adjustment API examples/ptpclient: refine application examples/ptpclient: add frequency adjustment support

[RFC v3 1/3] ethdev: add frequency adjustment API

2023-05-22 Thread Simei Su
t. This new function gets the scaled_ppm (desired frequency offset from nominal frequency in parts per million, but with a 16 bit binary fractional field). Signed-off-by: Simei Su Signed-off-by: Wenjun Wu --- lib/ethdev/ethdev_driver.h | 5 + lib/ethdev/ethdev_trace.h

[RFC v3 2/3] examples/ptpclient: refine application

2023-05-22 Thread Simei Su
This patch reworks code to split delay request message parsing from follow up message parsing which doesn't break original logic. Signed-off-by: Simei Su Signed-off-by: Wenjun Wu --- examples/ptpclient/ptpclient.c | 48 -- 1 file changed, 32 inser

[RFC v3 3/3] examples/ptpclient: add frequency adjustment support

2023-05-22 Thread Simei Su
This patch applys PI servo algorithm to leverage frequency adjustment API to improve PTP timesync accuracy. The command for starting ptpclient with PI algorithm is: ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 --controller=pi Signed-off-by: Simei Su Signed-off-by

RE: [RFC v2 1/3] ethdev: add frequency adjustment API

2023-05-24 Thread Su, Simei
Hi Thomas, Thanks a lot for your review. I have already sent RFC v3 patch based on your comments. https://patchwork.dpdk.org/project/dpdk/cover/20230522132332.102030-1-simei...@intel.com/ Thanks, Simei > -Original Message- > From: Thomas Monjalon > Sent: Monday, May 15, 2023

RE: [PATCH] net/e1000: support launchtime feature

2023-12-19 Thread Su, Simei
Hi Chuanyu, > -Original Message- > From: Chuanyu Xue > Sent: Monday, December 18, 2023 4:21 AM > To: Lu, Wenzhuo ; Zhang, Qi Z > ; Xing, Beilei > Cc: dev@dpdk.org; Chuanyu Xue > Subject: [PATCH] net/e1000: support launchtime feature > > Enable the time-based scheduled Tx of packets bas

RE: [PATCH] net/e1000: support launchtime feature

2023-12-26 Thread Su, Simei
Hi Chuanyu, > -Original Message- > From: Chuanyu Xue > Sent: Friday, December 22, 2023 11:04 AM > To: Su, Simei > Cc: Xing, Beilei ; chuanyu@uconn.edu; > dev@dpdk.org; Zhang, Qi Z ; Lu, Wenzhuo > > Subject: RE: [PATCH] net/e1000: support launchtime featur

[PATCH] net/i40e: updated 23.11 recommended matching list

2023-12-28 Thread Simei Su
Signed-off-by: Simei Su --- doc/guides/nics/i40e.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 3432eab..15689ac 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e.rst @@ -104,6 +104,8 @@ For X710/XL710/XXV710

[PATCH] net/ice: updated 23.11 recommended matching list

2023-12-28 Thread Simei Su
Signed-off-by: Simei Su --- doc/guides/nics/ice.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 820a385..09a4302 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guides/nics/ice.rst @@ -75,6 +75,8 @@ are listed in the Tested

RE: [PATCH] net/e1000: support launchtime feature

2024-01-02 Thread Su, Simei
Hi Chuanyu, > -Original Message- > From: Chuanyu Xue > Sent: Saturday, December 30, 2023 5:30 AM > To: Su, Simei > Cc: Xing, Beilei ; chuanyu@uconn.edu; > dev@dpdk.org; Zhang, Qi Z ; Lu, Wenzhuo > > Subject: RE: [PATCH] net/e1000: support launchtime feature

RE: [PATCH] net/e1000: support launchtime feature

2024-01-03 Thread Su, Simei
Hi Chuanyu, > -Original Message- > From: Chuanyu Xue > Sent: Thursday, January 4, 2024 5:52 AM > To: Su, Simei > Cc: Xing, Beilei ; chuanyu@uconn.edu; > dev@dpdk.org; Zhang, Qi Z ; Lu, Wenzhuo > > Subject: RE: [PATCH] net/e1000: support launchtime feature &

RE: [PATCH v2] net/e1000: support launchtime feature

2024-01-03 Thread Su, Simei
> -Original Message- > From: Chuanyu Xue > Sent: Sunday, December 31, 2023 12:35 AM > To: Su, Simei ; Lu, Wenzhuo ; > Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Chuanyu Xue > Subject: [PATCH v2] net/e1000: support launchtime feature > > Enable the

[PATCH v2] net/i40e: updated 23.11 recommended matching list

2024-01-03 Thread Simei Su
Add suggested DPDK/kernel driver/firmware version matching list. Signed-off-by: Simei Su --- v2: * Add commit log. doc/guides/nics/i40e.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 3432eab..15689ac 100644 --- a/doc/guides

[PATCH] doc: update default value for config parameter

2024-01-04 Thread Simei Su
Update documentation value to match default value in code base. Signed-off-by: Simei Su --- doc/guides/prog_guide/ip_fragment_reassembly_lib.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst b/doc/guides/prog_guide

[PATCH] maintainers: update for e1000/igc

2024-01-16 Thread Simei Su
Remove myself from maintainers. Signed-off-by: Simei Su --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0d1c812..11043da 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -739,7 +739,6 @@ F: doc/guides/nics/hinic.rst F: doc/guides/nics/features

[PATCH 0/3] add frequency adjustment support for PTP timesync

2023-08-08 Thread Simei Su
/build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 -- controller=pi [1/3] ethdev: add frequency adjustment API. [2/3] examples/ptpclient: refine application. [3/3] examples/ptpclient: add frequency adjustment support. Simei Su (3): ethdev: add frequency adjustment API exampl

[PATCH 1/3] ethdev: add frequency adjustment API

2023-08-08 Thread Simei Su
t. This new function gets the scaled_ppm (desired frequency offset from nominal frequency in parts per million, but with a 16 bit binary fractional field). Signed-off-by: Simei Su Signed-off-by: Wenjun Wu --- lib/ethdev/ethdev_driver.h | 5 + lib/ethdev/ethdev_trace.h

[PATCH 2/3] examples/ptpclient: refine application

2023-08-08 Thread Simei Su
This patch reworks code to split delay request message parsing from follow up message parsing which doesn't break original logic. Signed-off-by: Simei Su Signed-off-by: Wenjun Wu --- examples/ptpclient/ptpclient.c | 48 -- 1 file changed, 32 inser

[PATCH 3/3] examples/ptpclient: add frequency adjustment support

2023-08-08 Thread Simei Su
This patch applys PI servo algorithm to leverage frequency adjustment API to improve PTP timesync accuracy. The command for starting ptpclient with PI algorithm is: ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 --controller=pi Signed-off-by: Simei Su Signed-off-by

[PATCH] common/idpf: rework single queue Tx function

2023-08-25 Thread Simei Su
This patch replaces flex Tx descriptor structure with base Tx descriptor. Signed-off-by: Simei Su --- drivers/common/idpf/idpf_common_rxtx.c| 72 +-- drivers/common/idpf/idpf_common_rxtx.h| 2 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 36

[PATCH v2 00/17] update idpf base code

2023-08-25 Thread Simei Su
This patch set updates idpf base code. v2: * Add two patches for share code update. * Add version update. * Fix coding style issue. Simei Su (17): common/idpf/base: enable support for physical port stats common/idpf/base: add miss completion capabilities common/idpf/base: initial PTP

[PATCH v2 02/17] common/idpf/base: add miss completion capabilities

2023-08-25 Thread Simei Su
Add miss completion tag to other capabilities list, to indicate support for detecting a miss completion based on the upper bit of the completion tag. Signed-off-by: Josh Hay Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/virtchnl2.h | 4 2

[PATCH v2 01/17] common/idpf/base: enable support for physical port stats

2023-08-25 Thread Simei Su
Add support to indicate physical port representor and query its statistics. Signed-off-by: Zhenning Xiao Signed-off-by: Jayaprakash Shanmugam Signed-off-by: Simei Su --- .mailmap | 2 + drivers/common/idpf/base/virtchnl2.h | 80 +++- 2

[PATCH v2 03/17] common/idpf/base: initial PTP support

2023-08-25 Thread Simei Su
. Signed-off-by: Milena Olech Signed-off-by: Simei Su --- drivers/common/idpf/base/virtchnl2.h | 145 +++ 1 file changed, 145 insertions(+) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h index c49e4b943c..320430df6f 100644 --- a/drivers

[PATCH v2 04/17] common/idpf/base: remove mailbox registers

2023-08-25 Thread Simei Su
Chittim Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/siov_regs.h | 13 ++--- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/.mailmap b/.mailmap index af452d54c6..f23f8fecfa 100644 --- a/.mailmap +++ b/.mailmap

[PATCH v2 05/17] common/idpf/base: add some adi specific fields

2023-08-25 Thread Simei Su
a) Add maximum ADI count in capabilities message b) Add PF side ADI index to create_adi message c) Define another constant to indicate 'Function active' state of ADI Signed-off-by: Shailendra Bhatnagar Signed-off-by: Simei Su --- .mailmap | 1 + drivers/c

[PATCH v2 06/17] common/idpf/base: add necessary check

2023-08-25 Thread Simei Su
Add necessary check for payload and message buffer. Signed-off-by: Julianx Grajkowski Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/idpf_common.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap

[PATCH v2 07/17] common/idpf/base: add union for SW cookie fields in ctlq msg

2023-08-25 Thread Simei Su
Instead of using something like a byte offset, we can add a union to the struct here to enable direct addressing. Signed-off-by: Alan Brady Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/idpf_controlq_api.h | 5 + 2 files changed, 6

[PATCH v2 08/17] common/idpf/base: define non-flexible size structure for ADI

2023-08-25 Thread Simei Su
) Define virtchnl2_non_flex_vector_chunks with a single chunk in it. c) Rename and modify virtchnl2_create_adi to use the above 2 new structs. New structure is virtchnl2_non_flex_create_adi. Signed-off-by: Shailendra Bhatnagar Signed-off-by: Simei Su --- drivers/common/idpf/base/virtchnl2.h | 66

[PATCH v2 09/17] common/idpf/base: use local pointer before updating 'CQ out'

2023-08-25 Thread Simei Su
Instead of updating directly to 'cq_out' double pointer, use a local pointer and update only when we return success. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_controlq.c | 43 +--- 1 file changed, 23 inserti

[PATCH v2 10/17] common/idpf/base: use 'void' return type

2023-08-25 Thread Simei Su
Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_common.c | 4 ++-- drivers/common/idpf/base/idpf_controlq.c | 7 ++- drivers/common/idpf/base/idpf_controlq_api.h | 2 +- drivers/common/idpf/base/idpf_prototype.h| 2 +- 4 files changed

[PATCH v2 11/17] common/idpf/base: refactor descriptor 'ret val' stripping

2023-08-25 Thread Simei Su
Conditional check is not necessary to strip and get status bits from the descriptor. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_controlq.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/common/idpf/base

[PATCH v2 12/17] common/idpf/base: refine comments and alignment

2023-08-25 Thread Simei Su
Refine the macros and definitions by using 'tab' spaces and new lines wherever necessary. Also refine the comment in 'idpf_ctlq_setup_regs' and remove the TODO comment in idpf_rss_hash enum as it doesn't make any sense. Signed-off-by: Pavan Kumar Linga Signed-off-b

[PATCH v2 13/17] common/idpf/base: use GENMASK macro

2023-08-25 Thread Simei Su
Instead of using a custom defined macro for generating a mask, use the standard GENMASK macro. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_lan_pf_regs.h | 26 ++--- drivers/common/idpf/base/idpf_lan_txrx.h| 116 +--- drivers

[PATCH v2 14/17] common/idpf/base: use 'type functionname(args)' style

2023-08-25 Thread Simei Su
Instead of splitting the function name and function type into multiple lines, use then in a single line. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_controlq.c | 5 ++--- drivers/common/idpf/base/idpf_controlq_setup.c | 5 ++--- 2 files

[PATCH v2 15/17] common/idpf/base: dont declare union with 'flex'

2023-08-25 Thread Simei Su
In idpf_flex_tx_desc structure, instead of naming the union with 'flex', use no name union as the union name is not really necessary there. This reduces the level of indirection in the hotpath. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common

[PATCH v2 16/17] common/idpf/base: remove unused Tx descriptor types

2023-08-25 Thread Simei Su
Remove the unused TX descriptor types and mark them as reserved. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_lan_txrx.h | 132 ++- 1 file changed, 10 insertions(+), 122 deletions(-) diff --git a/drivers/common/idpf/base

[PATCH v2 17/17] common/idpf/base: update version

2023-08-25 Thread Simei Su
Update README Signed-off-by: Simei Su --- drivers/common/idpf/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base/README b/drivers/common/idpf/base/README index 693049c057..457b5a81f3 100644 --- a/drivers/common/idpf/base/README +++ b

RE: [PATCH 14/33] doc: update igc guide

2023-03-21 Thread Su, Simei
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, March 22, 2023 7:59 AM > To: Mcnamara, John ; Guo, Junfeng > ; Su, Simei > Cc: Thomas Monjalon ; Andrew Rybchenko > ; dev@dpdk.org > Subject: [PATCH 14/33] doc: update igc guide > > - Mov

RE: [PATCH v6] net/i40e: rework maximum frame size configuration

2023-03-24 Thread Su, Simei
Hi Kevin, > -Original Message- > From: Kevin Traynor > Sent: Friday, March 24, 2023 5:40 PM > To: Jiang, YuX ; Zhang, Qi Z ; Su, > Simei ; Xing, Beilei ; Zhang, > Yuying ; david.march...@redhat.com > Cc: dev@dpdk.org; Yang, Qiming ; sta...@dpdk.org; > Luca B

[RFC 0/4] add frequency adjustment support for PTP

2023-03-30 Thread Simei Su
[RFC 1/4] ethdev: add frequency adjustment API. [RFC 2/4] net/ice: add frequency adjustment support for PTP. [RFC 3/4] examples/ptpclient: refine application. [RFC 4/4] examples/ptpclient: add frequency adjustment support. Simei Su (4): ethdev: add frequency adjustment API net/ice: add

[RFC 1/4] ethdev: add frequency adjustment API

2023-03-30 Thread Simei Su
This patch adds freq adjustment API for PTP high accuracy. Signed-off-by: Simei Su --- lib/ethdev/ethdev_driver.h | 5 + lib/ethdev/ethdev_trace.h| 9 + lib/ethdev/ethdev_trace_points.c | 3 +++ lib/ethdev/rte_ethdev.c | 18 ++ lib/ethdev

[RFC 2/4] net/ice: add frequency adjustment support for PTP

2023-03-30 Thread Simei Su
Add ice support for new ethdev API to adjust frequency for IEEE1588 PTP. Also, this patch reworks code for converting software update to hardware update. Signed-off-by: Simei Su --- drivers/net/ice/ice_ethdev.c | 111 --- 1 file changed, 72 insertions

[RFC 3/4] examples/ptpclient: refine application

2023-03-30 Thread Simei Su
This patch reworks code to split delay request message parsing from follow up message parsing. Signed-off-by: Simei Su Signed-off-by: Wenjun Wu --- examples/ptpclient/ptpclient.c | 48 -- 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a

[RFC 4/4] examples/ptpclient: add frequency adjustment support

2023-03-30 Thread Simei Su
This patch adds PI servo algorithm to support frequency adjustment API for IEEE1588 PTP. For example, the command for starting ptpclient with PI algorithm is: ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 --controller=pi Signed-off-by: Simei Su Signed-off-by: Wenjun

[RFC v2 0/3] add frequency adjustment support for PTP timesync

2023-04-03 Thread Simei Su
from the RFC. * Add description in cover letter. * Refine commit log in patch. Simei Su (3): ethdev: add frequency adjustment API examples/ptpclient: refine application examples/ptpclient: add frequency adjustment support examples/ptpclient/ptpclient.c | 222 +++

[RFC v2 1/3] ethdev: add frequency adjustment API

2023-04-03 Thread Simei Su
This patch introduces a new timesync API "rte_eth_timesync_adjust_freq" which enables frequency adjustment during PTP timesync. Signed-off-by: Simei Su --- lib/ethdev/ethdev_driver.h | 5 + lib/ethdev/ethdev_trace.h| 9 + lib/ethdev/ethdev_trace_poi

[RFC v2 2/3] examples/ptpclient: refine application

2023-04-03 Thread Simei Su
This patch reworks code to split delay request message parsing from follow up message parsing which doesn't break original logic. Signed-off-by: Simei Su Signed-off-by: Wenjun Wu --- examples/ptpclient/ptpclient.c | 48 -- 1 file changed, 32 inser

[RFC v2 3/3] examples/ptpclient: add frequency adjustment support

2023-04-03 Thread Simei Su
This patch applys PI servo algorithm to leverage frequency adjustment API to improve PTP timesync accuracy. The command for starting ptpclient with PI algorithm is: ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 --controller=pi Signed-off-by: Simei Su Signed-off-by

[PATCH] net/ice/base: support customized DDP package

2023-06-05 Thread Simei Su
This patch adds support for custom DDP version 255.4.0.0. Signed-off-by: Simei Su --- drivers/net/ice/base/ice_ddp.c | 41 ++ drivers/net/ice/base/ice_ddp.h | 1 + 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_ddp.c b

[RFC DPDK 21.11] net/ice/base: support customized DDP package

2023-06-05 Thread Simei Su
This patch adds support for custom DDP version 255.4.0.0 based on DPDK 21.11. Signed-off-by: Simei Su --- drivers/net/ice/base/ice_flex_pipe.c | 43 +--- drivers/net/ice/base/ice_flex_pipe.h | 1 + 2 files changed, 40 insertions(+), 4 deletions(-) diff --git a/drivers

RE: [PATCH] net/ice/base: support customized DDP package

2023-06-06 Thread Su, Simei
This patch is for customized DDP package based on DPDK 23.03. Customer use a custom package and a custom kernel driver, so DPDK won't upstream it. > -Original Message- > From: Su, Simei > Sent: Monday, June 5, 2023 5:38 PM > To: Zhang, Qi Z ; Yang, Qiming > &g

RE: [RFC v3 0/3] add frequency adjustment support for PTP timesync

2023-06-07 Thread Su, Simei
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Saturday, June 3, 2023 3:44 AM > To: Su, Simei ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Rybalchenko, Kirill > ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 > Subject: Re: [RFC v3 0/3]

RE: [RFC v3 3/3] examples/ptpclient: add frequency adjustment support

2023-06-07 Thread Su, Simei
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Saturday, June 3, 2023 3:53 AM > To: Su, Simei ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Rybalchenko, Kirill > ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 > Subject: Re: [RFC v3 3/3]

RE: [RFC v3 0/3] add frequency adjustment support for PTP timesync

2023-06-07 Thread Su, Simei
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 8, 2023 2:29 AM > To: Su, Simei ; tho...@monjalon.net; > andrew.rybche...@oktetlabs.ru; Rybalchenko, Kirill > ; Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 > Subject: Re: [RFC v3 0/3]

[PATCH] net/ice: fix PTP init failed

2022-09-19 Thread Simei Su
Because of share code update, "ice_ptp_init_phc" API for E810/E822 depends on PHY configuration, not whether the device is E810 based. So before this API is called, assign specific value to phy cfg. Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH] net/ice: fix dereferenced null pointer

2021-10-11 Thread Simei Su
This patch fixes coverity issue by avoiding use of null pointer in taking false branch. Coverity issue: 373360 Fixes: 437dbd2fd428 ("net/ice: support 1PPS") Signed-off-by: Simei Su --- drivers/net/ice/ice_ethdev.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[dpdk-dev] [PATCH] net/ice: fix compile failure when Rx desc size is 16

2021-10-11 Thread Simei Su
The Timestamp Overlay feature is available only in 32B Flex Descriptors. This patch adds compile option when in 16B Flex Descriptors. Fixes: 953e74e6b73a ("net/ice: enable Rx timestamp on flex descriptor") Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP") Sig

[PATCH] net/iavf: fix default state for Rx timestamp enabling

2022-10-11 Thread Simei Su
iptor") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- drivers/net/iavf/iavf_vchnl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index 4327c5a..729400c 100644 --- a/drivers/net/iavf/iavf_vchnl.c ++

[PATCH] net/iavf: fix default state for Rx timestamp enabling

2022-10-12 Thread Simei Su
This patch adds per queue offload check to turn off Rx timestamp offload by default. Fixes: b5cd735132f6 ("net/iavf: enable Rx timestamp on flex descriptor") Cc: sta...@dpdk.org Signed-off-by: Simei Su v2: * Refine commit log. --- drivers/net/iavf/iavf_vchnl.c | 3 ++- 1 file

[dpdk-dev] [PATCH] examples/ptpclient: enable Rx queue configuration

2021-08-19 Thread Simei Su
This patch adds support to enable per-queue Rx offloads so that it can convey the configuration to PMD. Signed-off-by: Simei Su --- examples/ptpclient/ptpclient.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient

[dpdk-dev] [PATCH v2] net/ice: support IEEE 1588 PTP for E810

2021-09-01 Thread Simei Su
p 0x1 Signed-off-by: Simei Su --- v2: * Change patchset to one patch based on share code update. * Change per device offload to per queue offload. drivers/net/ice/ice_ethdev.c | 228 ++- drivers/net/ice/ice_ethdev.h | 5 + drivers/net/ice/ice_rxtx.c

[dpdk-dev] [PATCH] net/ice: add 1PPS support for E810

2021-09-02 Thread Simei Su
for test command is as below: ./build/app/dpdk-testpmd -w af:00.0,pps_out='[pin:2]' -c f -n 4 -- -i Signed-off-by: Simei Su --- drivers/net/ice/ice_ethdev.c | 196 +++ drivers/net/ice/ice_ethdev.h | 15 2 files changed, 211 insertions(+) di

[dpdk-dev] [PATCH v3] net/ice: support IEEE 1588 PTP for E810

2021-09-08 Thread Simei Su
ff-by: Simei Su --- v3: * Rework code to support scalar path only. * Update the doc/guides/nics/features/ice.ini to add "Timesync" feature. * Add release notes. v2: * Change patchset to one patch based on share code update. * Change per device offload to per queue offload. doc/guide

<    1   2   3   4   5   >