[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in

2015-12-22 Thread Yong Wang
On 7/23/15, 5:53 PM, "dev on behalf of Marco Lee" wrote: >The RX of VMXNET3 PMD will have deadlock when a lot of traffic coming in. >The root cause is due to mbuf allocation fail in vmxnet3_post_rx_bufs() >and there is no error handling when it is called from vmxnet3_recv_pkts(). >The RXD will

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in

2015-10-21 Thread Thomas Monjalon
Any update? Yong, have you looked at it? 2015-07-24 09:58, Thomas Monjalon: > Hi Marco, > > It seems it is a new version of the patch. > Please, in order to ease patch management and review, could you add: > - a version number > - a changelog > - threading with previous patches

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in

2015-07-24 Thread Thomas Monjalon
Hi Marco, It seems it is a new version of the patch. Please, in order to ease patch management and review, could you add: - a version number - a changelog - threading with previous patches It can be done with: - subject-prefix option - annotate option

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in

2015-07-24 Thread Marco Lee
The RX of VMXNET3 PMD will have deadlock when a lot of traffic coming in. The root cause is due to mbuf allocation fail in vmxnet3_post_rx_bufs() and there is no error handling when it is called from vmxnet3_recv_pkts(). The RXD will not have "free" mbuf for it but the counter still increment.

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in

2015-07-23 Thread Marco Lee
The RX of VMXNET3 PMD will have deadlock when a lot of traffic coming in. The root cause is due to mbuf allocation fail in vmxnet3_post_rx_bufs() and there is no error handling when it is called from vmxnet3_recv_pkts(). The RXD will not have "free" mbuf for it but the counter still increment.

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in

2015-07-23 Thread Stephen Hemminger
On Thu, 23 Jul 2015 16:51:32 +0800 Marco Lee wrote: > The RX of VMXNET3 PMD will have deadlock when a lot of traffic coming in. > The root cause is due to mbuf allocation fail in vmxnet3_post_rx_bufs() and > there is no error handling when it is called > from vmxnet3_recv_pkts(). The RXD will

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in. The root cause is due to mbuf allocation fail in vmxnet3_post_rx_bufs() and there is no error handlin

2015-07-23 Thread mac_le...@yahoo.com.hk
From: marco --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 54 +++- 1 file changed, 53 insertions(+), 1 deletion(-) mode change 100644 => 100755 drivers/net/vmxnet3/vmxnet3_rxtx.c diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in. The root cause is due to mbuf allocation fail in vmxnet3_post_rx_bufs() and there is no error handlin

2015-07-23 Thread Stephen Hemminger
On Thu, 23 Jul 2015 07:31:01 + Vithal S Mohare wrote: > +/* VMXNET3 > + * In the above loop, vmxnet3_post_rx_bufs would fai if all the mbufs > currently allocated. > + * In such scenarios where hw device hasn't left with any of 'rx' > descriptors, packets from > + * network

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in. The root cause is due to mbuf allocation fail in vmxnet3_post_rx_bufs() and there is no error handlin

2015-07-23 Thread Vithal S Mohare
How about the below changes? I have been using below changes and helping to resolve the issue. === = dpdk/lib/librte_pmd_vmxnet3/vmxnet3_ring.h#3 edit (text) = @@ -155,10 +155,11 @@ typedef struct

[dpdk-dev] [PATCH] The VMXNET3 PMD can't receive packet suddenly after a lot of traffic coming in. The root cause is due to mbuf allocation fail in vmxnet3_post_rx_bufs() and there is no error handlin

2015-07-22 Thread Stephen Hemminger
On Thu, 23 Jul 2015 09:48:55 +0800 mac_leehk at yahoo.com.hk wrote: > From: marco Thank you for addressing a real bug. But there are several issues with the patch as submitted: * the standard way to handle allocation failure in network drivers is to drop the received packet and reuse