Re: Review Request 18841: Patch for DRILL-88

> On March 19, 2014, 10:36 a.m., Aditya Kishore wrote: > > distribution/src/resources/drill-config.sh, line 100 > > > > > > Include HBase conf folder at the beginning of HBASE_CLASSPATH. www.fixithere.net/bt-customer-

[jira] [Created] (DRILL-2450) JDBC : DatabaseMetaData.getColumns is missing the 'COLUMN_SIZE' in the result set

Rahul Challapalli created DRILL-2450: Summary: JDBC : DatabaseMetaData.getColumns is missing the 'COLUMN_SIZE' in the result set Key: DRILL-2450 URL: https://issues.apache.org/jira/browse/DRILL-2450

[jira] [Created] (DRILL-2451) JDBC : Connection.commit throws an UnsupportedOperationException

Rahul Challapalli created DRILL-2451: Summary: JDBC : Connection.commit throws an UnsupportedOperationException Key: DRILL-2451 URL: https://issues.apache.org/jira/browse/DRILL-2451 Project: Apach

Re: Review Request 31995: DRILL-2128 fix for DatabaseMetaData.getColumns's DATA_TYPE and TYPE_NAME (pt. 2--core fix)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31995/#review76433 --- exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java

[jira] [Created] (DRILL-2452) ResultSet.getDouble should not throw an exception when the underlying type is a FLOAT

Rahul Challapalli created DRILL-2452: Summary: ResultSet.getDouble should not throw an exception when the underlying type is a FLOAT Key: DRILL-2452 URL: https://issues.apache.org/jira/browse/DRILL-2452

Re: Review Request 31995: DRILL-2128 fix for DatabaseMetaData.getColumns's DATA_TYPE and TYPE_NAME (pt. 2--core fix)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31995/#review76436 --- Ship it! Ship It! - Parth Chandra On March 12, 2015, 8:58 p.m.,

Re: Review Request 31995: DRILL-2128 fix for DatabaseMetaData.getColumns's DATA_TYPE and TYPE_NAME (pt. 2--core fix)

> On March 13, 2015, 8:56 p.m., Parth Chandra wrote: > > exec/jdbc/src/main/java/org/apache/drill/jdbc/MetaImpl.java, line 249 > > > > > > Should we fix this and make it DECIMAL_DIGITS then? Per offline discussion: I

[jira] [Created] (DRILL-2453) hbase queries in certain env result in NPE at FragmentWritableBatch.getEmptyBatchWithSchema()

Ramana Inukonda Nagaraj created DRILL-2453: -- Summary: hbase queries in certain env result in NPE at FragmentWritableBatch.getEmptyBatchWithSchema() Key: DRILL-2453 URL: https://issues.apache.org/jira/brow

use AutoCloseable or Closeable: let the compiler (or other tools) help you

In my work for DRILL-1942, I discovered that one possible source of memory leak is the use of preallocation (See BufferAllocator.getNewPreAllocator()). If you pre-allocate, and then something happens (which results in throwing an exception) before you claim the pre-allocated space, that space (at l

[jira] [Created] (DRILL-2454) Support for local join filter in outer joins

Victoria Markman created DRILL-2454: --- Summary: Support for local join filter in outer joins Key: DRILL-2454 URL: https://issues.apache.org/jira/browse/DRILL-2454 Project: Apache Drill Issue

[jira] [Created] (DRILL-2455) Cluster deployment tool

Sudheesh Katkam created DRILL-2455: -- Summary: Cluster deployment tool Key: DRILL-2455 URL: https://issues.apache.org/jira/browse/DRILL-2455 Project: Apache Drill Issue Type: New Feature

[jira] [Created] (DRILL-2456) regexp_replace using hex codes fails on larger JSON data sets

Andries Engelbrecht created DRILL-2456: -- Summary: regexp_replace using hex codes fails on larger JSON data sets Key: DRILL-2456 URL: https://issues.apache.org/jira/browse/DRILL-2456 Project: Apac

Re: Review Request 31876: DRILL-2415: Export Drill C++ Client symbols so as to provide dynamic linking

> On March 11, 2015, 12:29 a.m., Parth Chandra wrote: > > contrib/native/client/src/include/drill/drillClient.hpp, line 311 > > > > > > This is required on Windows but not on Linux. Can you add a link to the > > expla

Re: Review Request 30701: DRILL-2173 partition queries for dynamic partition pruning

> On Feb. 6, 2015, 9:21 p.m., Jason Altekruse wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/PartitionExplorer.java, > > line 35 > > > > > > I am considering making it a requirement that implimento

Re: Review Request 30701: DRILL-2173 partition queries for dynamic partition pruning

> On Feb. 28, 2015, 12:26 a.m., Chris Westin wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java, > > line 67 > > > > > > To avoid future confusion with these, can we add units to the en

[jira] [Created] (DRILL-2457) aggregation function on complex type should give appropriate error

Chun Chang created DRILL-2457: - Summary: aggregation function on complex type should give appropriate error Key: DRILL-2457 URL: https://issues.apache.org/jira/browse/DRILL-2457 Project: Apache Drill

Re: Review Request 31871: 2406 - part 2 - (subset of 2060 part 2) enable interpreted expression evaluation at planning time

> On March 11, 2015, 9:52 p.m., Chris Westin wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/ops/BufferManager.java, > > line 27 > > > > > > Should be @link > > Jason Altekruse wrote: > Did not rea

Re: Review Request 31871: 2406 - part 2 - (subset of 2060 part 2) enable interpreted expression evaluation at planning time

> On March 10, 2015, 4:52 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java, > > line 183 > > > > > > This should be fixed. Otherwise, you're simply introducing

Re: Review Request 30754: DRILL-2143 - part 2 - remove record batch interface from UDF interface

> On March 7, 2015, 2:32 a.m., Jinfeng Ni wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java, > > line 140 > > > > > > I guess for now it's fine to add code just to handle Curre

[jira] [Created] (DRILL-2458) Extra hash column added when running CTAS with order by

Steven Phillips created DRILL-2458: -- Summary: Extra hash column added when running CTAS with order by Key: DRILL-2458 URL: https://issues.apache.org/jira/browse/DRILL-2458 Project: Apache Drill

[jira] [Created] (DRILL-2459) INFO._SCHEMA's CHARACTER_MAXIMUM_LENGTH is -1 for type CHAR

Daniel Barclay (Drill) created DRILL-2459: - Summary: INFO._SCHEMA's CHARACTER_MAXIMUM_LENGTH is -1 for type CHAR Key: DRILL-2459 URL: https://issues.apache.org/jira/browse/DRILL-2459 Project:

Re: Review Request 28686: For DRILL-1735, hook up JDBC connection closing, and fix follow-on resource bugs.

> On Jan. 29, 2015, 9:40 p.m., Mehant Baid wrote: > > Since this change touches about 50 files, I think it would be easier to > > review the changes if you separate out the code changes and the > > comment/TODO changes. Roger. Split misc. TODO changes out from code changes. See new patch.

Re: Review Request 28686: For DRILL-1735, hook up JDBC connection closing, and fix follow-on resource bugs.

> On Jan. 30, 2015, 1:08 a.m., Parth Chandra wrote: > > exec/java-exec/src/main/java/io/netty/buffer/DrillBuf.java, line 37 > > > > > > Because this (and other similar classes) need to access package private > > classe