Re: Review Request 32223: DRILL-2193: implement fast count / skip-all semantics for JSON reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32223/#review77027 --- exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/

Re: Review Request 32223: DRILL-2193: implement fast count / skip-all semantics for JSON reader

> On March 19, 2015, 7:40 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JsonProcessor.java, > > line 37 > > > > > > Is it necessary to have this method in the interface

Lets cut a 0.8 release

Hey Y'all, We haven't had a release in a while. I'd like to propose that we slice off our current master as 0.8 so users can take advantage of all the fixes since 0.7. I'm happy to be the release manager unless someone else wants to raise their hand. I'd like to target 6pm pacific today as the

Re: Lets cut a 0.8 release

+1 On Thu, Mar 19, 2015 at 11:47 AM, Jacques Nadeau wrote: > Hey Y'all, > > We haven't had a release in a while. I'd like to propose that we slice off > our current master as 0.8 so users can take advantage of all the fixes > since 0.7. I'm happy to be the release manager unless someone else w

Re: Lets cut a 0.8 release

Makes sense. Lots of progress since 0.7. On Thu, Mar 19, 2015 at 9:47 AM, Jacques Nadeau wrote: > Hey Y'all, > > We haven't had a release in a while. I'd like to propose that we slice off > our current master as 0.8 so users can take advantage of all the fixes > since 0.7. I'm happy to be the

Re: Lets cut a 0.8 release

+1 Many people want the fixes, and although they are out there, it would be nice to have it in a release. On Mar 19, 2015 9:47 AM, "Jacques Nadeau" wrote: > Hey Y'all, > > We haven't had a release in a while. I'd like to propose that we slice off > our current master as 0.8 so users can take ad

Re: Review Request 31876: DRILL-2415: Export Drill C++ Client symbols so as to provide dynamic linking

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31876/#review77061 --- Ship it! Ship It! - Parth Chandra On March 19, 2015, 3:16 a.m.,

Re: Lets cut a 0.8 release

+1 Definitely. Has been a long time. -Via mobile. Excuse brevity. On 19 Mar 2015 10:25 pm, "M. C. Srivas" wrote: > +1 > > Many people want the fixes, and although they are out there, it would be > nice to have it in a release. > On Mar 19, 2015 9:47 AM, "Jacques Nadeau" wrote: > > > Hey Y'all,

[jira] [Resolved] (DRILL-2415) Export Drill C++ Client symbols so as to provide dynamic linking

[ https://issues.apache.org/jira/browse/DRILL-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Chandra resolved DRILL-2415. -- Resolution: Fixed Fixed in ff9882b > Export Drill C++ Client symbols so as to provide dynamic l

Re: Review Request 32223: DRILL-2193: implement fast count / skip-all semantics for JSON reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32223/ --- (Updated March 19, 2015, 5:49 p.m.) Review request for drill, Aman Sinha and Pa

Review Request 32244: DRILL-2353: Handle more complex partition filters via interpreter based partition pruning

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32244/ --- Review request for drill and Jacques Nadeau. Repository: drill-git Descriptio

Review Request 32248: DRILL-2139: Star is not expanded correctly in "select distinct" query

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32248/ --- Review request for drill, Aman Sinha and Jinfeng Ni. Bugs: DRILL-2139 https

Re: Review Request 28686: For DRILL-1735, hook up JDBC connection closing, and fix follow-on resource bugs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28686/ --- (Updated March 19, 2015, 6:19 p.m.) Review request for drill, Mehant Baid and P

Re: Review Request 32248: DRILL-2139: Star is not expanded correctly in "select distinct" query

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32248/ --- (Updated March 19, 2015, 6:31 p.m.) Review request for drill, Aman Sinha and Ji

Re: Review Request 32248: DRILL-2139: Star is not expanded correctly in "select distinct" query

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32248/#review77076 --- A couple of comments after a quick look at the code. Will look mor

[jira] [Created] (DRILL-2501) POSTINST upgrade checks old drill install folder for drill pid to stop

Krystal created DRILL-2501: -- Summary: POSTINST upgrade checks old drill install folder for drill pid to stop Key: DRILL-2501 URL: https://issues.apache.org/jira/browse/DRILL-2501 Project: Apache Drill

Re: Review Request 32223: DRILL-2193: implement fast count / skip-all semantics for JSON reader

> On March 19, 2015, 7:40 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/reader/CountingJsonReader.java, > > line 36 > > > > > > The default JsonReader (which is used whe

Re: Review Request 32223: DRILL-2193: implement fast count / skip-all semantics for JSON reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32223/#review77092 --- Ship it! Ship It! - Aman Sinha On March 19, 2015, 5:49 p.m., Han

Re: Review Request 32223: DRILL-2193: implement fast count / skip-all semantics for JSON reader

> On March 19, 2015, 7:40 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/reader/CountingJsonReader.java, > > line 36 > > > > > > The default JsonReader (which is used whe

Re: Review Request 32248: DRILL-2139: Star is not expanded correctly in "select distinct" query

> On March 19, 2015, 6:35 p.m., Jinfeng Ni wrote: > > exec/java-exec/src/test/java/org/apache/drill/TestExampleQueries.java, line > > 747 > > > > > > Have you consider the case where * comes from join? > > > >

Re: Review Request 31435: DRILL-2245-core: core changes for improved drillbit stability

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31435/ --- (Updated March 19, 2015, 1:21 p.m.) Review request for drill, Jacques Nadeau an

RE: Lets cut a 0.8 release

+1. It's been a very long while since the last release. Norris -Original Message- From: Jacques Nadeau [mailto:jacq...@apache.org] Sent: Thursday, March 19, 2015 9:47 AM To: dev@drill.apache.org Subject: Lets cut a 0.8 release Hey Y'all, We haven't had a release in a while. I'd like t

[jira] [Created] (DRILL-2502) Improve code safety by providing a generic event delivery mechanism that supports queueing

Chris Westin created DRILL-2502: --- Summary: Improve code safety by providing a generic event delivery mechanism that supports queueing Key: DRILL-2502 URL: https://issues.apache.org/jira/browse/DRILL-2502

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/ --- (Updated March 19, 2015, 8:48 p.m.) Review request for drill and Venki Korukant

Re: Review Request 31435: DRILL-2245-core: core changes for improved drillbit stability

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31435/#review77103 --- Ship it! Ship It! - Jacques Nadeau On March 19, 2015, 8:21 p.m.,

[jira] [Created] (DRILL-2503) Having many WHENs causes ClassReader.accept()/EXPAND_FRAMES error

Daniel Barclay (Drill) created DRILL-2503: - Summary: Having many WHENs causes ClassReader.accept()/EXPAND_FRAMES error Key: DRILL-2503 URL: https://issues.apache.org/jira/browse/DRILL-2503 Pro

Review Request 32259: DRILL-2367: Need to remove drill.exec.storage.file.partition.column.label as BOOT option (from drill-module.conf)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32259/ --- Review request for drill and Venki Korukanti. Repository: drill-git Descripti

My last patch moved us to protobuf 2.6

Jacques just committed my patch for DRILL-2245. Among other things, this moved us to protobuf 2.6 (we were on 2.5, release notes are here https://code.google.com/p/protobuf/source/browse/trunk/CHANGES.txt). I needed to add some new enum symbols to QueryState, which required regenerating some of th

Re: Review Request 32259: DRILL-2367: Need to remove drill.exec.storage.file.partition.column.label as BOOT option (from drill-module.conf)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32259/#review77109 --- Ship it! Ship It! - Venki Korukanti On March 19, 2015, 9:13 p.m.

[jira] [Resolved] (DRILL-2245) Improve Drillbit resiliency

[ https://issues.apache.org/jira/browse/DRILL-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Nadeau resolved DRILL-2245. --- Resolution: Fixed Resolved in 2da618c > Improve Drillbit resiliency > ---

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/#review77111 --- exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/Memory

Re: My last patch moved us to protobuf 2.6

Hi, I think this may cause issues for C++ client, which relies on protobuf 2.5. It would be good to keep protobuf 2.5. On OS X, you can use homebrew-versions to get an older version of protoc: https://github.com/Homebrew/homebrew-versions Thanks, Xiao ___

Re: My last patch moved us to protobuf 2.6

I think the C++ client will be fine since we don't generate the code every time. There may be some protobuf changes coming soon that will require updating the code. I'll update the cmake required version at that time. Parth On Thu, Mar 19, 2015 at 2:43 PM, Xiao Meng wrote: > Hi, > > I think thi

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 19, 2015, 9:27 p.m., Chris Westin wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryRecord.java, > > line 108 > > > > > > I thought we were going to use "max_heap_size" since t

Re: My last patch moved us to protobuf 2.6

There is no wire difference between the two so having one client on 2.5 and one on 2.6 shouldn't have major impact. The changes are all in the library and generated code. Two concerns with the change come to mind: - We had an opportunity to stop shading our stuff since Hadoop 2 uses Protobuf 2.5.

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/#review77119 --- Can we use the following for column anmes: hostname user_port heap_

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 19, 2015, 3:16 p.m., Jacques Nadeau wrote: > > Can we use the following for column anmes: > > > > hostname > > user_port > > heap_current > > heap_max > > direct_current > > direct_max Doesn't sys.drillbits use host_name? If so, we should be consistent with that. - Chris

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 19, 2015, 10:16 p.m., Jacques Nadeau wrote: > > Can we use the following for column anmes: > > > > hostname > > user_port > > heap_current > > heap_max > > direct_current > > direct_max > > Chris Westin wrote: > Doesn't sys.drillbits use host_name? If so, we should be consistent

[jira] [Resolved] (DRILL-2488) Wrong result on join between two subqueries with aggregation

[ https://issues.apache.org/jira/browse/DRILL-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-2488. --- Resolution: Fixed Fix Version/s: (was: 0.9.0) 0.8.0 Fixed in master bran

[jira] [Created] (DRILL-2504) Aggregate query with grouping results in Error

Khurram Faraaz created DRILL-2504: - Summary: Aggregate query with grouping results in Error Key: DRILL-2504 URL: https://issues.apache.org/jira/browse/DRILL-2504 Project: Apache Drill Issue T

Re: Review Request 31697: DRILL-2323: Parquet record reader should log which file and which record caused an error in the reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31697/#review77126 --- Ship it! Ship It! - Jason Altekruse On March 18, 2015, 5:02 p.m.

Review Request 32264: sql extensions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32264/ --- Review request for drill and Bridget Bridget. Bugs: DRILL-2493 https://issu

Re: Review Request 32264: sql extensions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32264/ --- (Updated March 19, 2015, 11:47 p.m.) Review request for drill and Bridget Bridg

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/ --- (Updated March 20, 2015, 12:02 a.m.) Review request for drill and Venki Korukan

Review Request 32267: add sql extensions topic to docs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32267/ --- Review request for drill and Bridget Bridget. Bugs: DRILL-2403 https://issu

Review Request 32269: DRILL-2010: MergeJoin: Store/restore the right batch state when existing join loop due to output batch full.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32269/ --- Review request for drill and Aman Sinha. Repository: drill-git Description --

Review Request 32272: DRILL-2402: Updating hash functions so that combination hashing uses a chained approach rather than xor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32272/ --- Review request for drill, Aman Sinha and Mehant Baid. Repository: drill-git D

Re: Review Request 32272: DRILL-2402: Updating hash functions so that combination hashing uses a chained approach rather than xor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32272/ --- (Updated March 20, 2015, 12:23 a.m.) Review request for drill, Aman Sinha and M

Re: Review Request 28686: For DRILL-1735, hook up JDBC connection closing, and fix follow-on resource bugs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28686/ --- (Updated March 20, 2015, 12:25 a.m.) Review request for drill, Mehant Baid and

Re: Review Request 28686: For DRILL-1735, hook up JDBC connection closing, and fix follow-on resource bugs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28686/ --- (Updated March 20, 2015, 12:30 a.m.) Review request for drill, Mehant Baid and

Re: Review Request 32272: DRILL-2402: Updating hash functions so that combination hashing uses a chained approach rather than xor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32272/#review77146 --- Ship it! Ship It! - Aman Sinha On March 20, 2015, 12:23 a.m., Ve

[jira] [Created] (DRILL-2505) Add docs about functions to SQL Reference

Kristine Hahn created DRILL-2505: Summary: Add docs about functions to SQL Reference Key: DRILL-2505 URL: https://issues.apache.org/jira/browse/DRILL-2505 Project: Apache Drill Issue Type: Ta

Review Request 32273: DRILL-2408: Invalid (0 length) parquet file created by CTAS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32273/ --- Review request for drill, Aman Sinha and Jason Altekruse. Bugs: DRILL-2408

[jira] [Created] (DRILL-2506) IOOB with order by and limit

Chun Chang created DRILL-2506: - Summary: IOOB with order by and limit Key: DRILL-2506 URL: https://issues.apache.org/jira/browse/DRILL-2506 Project: Apache Drill Issue Type: Bug Compone

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/#review77148 --- One minor comment about a comment, but looks good otherwise. exec/

Re: Review Request 32269: DRILL-2010: MergeJoin: Store/restore the right batch state when existing join loop due to output batch full.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32269/#review77149 --- Ship it! MergeJoin code needs more cleanup/rework but this is a goo

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 20, 2015, 1:28 a.m., Chris Westin wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java, > > line 48 > > > > > > Shouldn't this be a TODO? Of course, inquiring minds

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 19, 2015, 6:28 p.m., Chris Westin wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java, > > line 48 > > > > > > Shouldn't this be a TODO? Of course, inquiring minds

Please be a little more choosey with method name verbs -- get vs create

In the course of things I've been doing, I've been cleaning up a large number of compilation warnings. These can help us find problems, so it pays to eliminate them whenever possible. One set concern dealing with resource leaks from failing to close() an AutoCloseable or Closeable. When I see thes

Re: Review Request 28686: For DRILL-1735, hook up JDBC connection closing, and fix follow-on resource bugs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28686/#review77154 --- Ship it! Perhaps we could change the behavior so that the connectio

Re: Review Request 32273: DRILL-2408: Invalid (0 length) parquet file created by CTAS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32273/#review77163 --- exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Pa

Re: Review Request 32244: DRILL-2353: Handle more complex partition filters via interpreter based partition pruning

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32244/#review77165 --- Ship it! Ship It! - Jacques Nadeau On March 19, 2015, 5:51 p.m.,

Re: Review Request 32273: DRILL-2408: Invalid (0 length) parquet file created by CTAS

> On March 20, 2015, 2:33 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java, > > line 338 > > > > > > You should also check fs.exists(path) before ca

Re: Lets cut a 0.8 release

I was just asked about a next release of drill in a meeting today. +1 On Thu, Mar 19, 2015 at 1:26 PM, Norris Lee wrote: > +1. It's been a very long while since the last release. > > Norris > > -Original Message- > From: Jacques Nadeau [mailto:jacq...@apache.org] > Sent: Thursday, Mar

Re: Review Request 32273: DRILL-2408: Invalid (0 length) parquet file created by CTAS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32273/ --- (Updated March 20, 2015, 4:33 a.m.) Review request for drill, Aman Sinha and Ja

[jira] [Resolved] (DRILL-1967) Null pointer exception in ParquetRecordWriter when caneled before data arrives

[ https://issues.apache.org/jira/browse/DRILL-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Nadeau resolved DRILL-1967. --- Resolution: Fixed Fixed in 838fd08 > Null pointer exception in ParquetRecordWriter when canel

[jira] [Resolved] (DRILL-1735) JDBC driver's close() leaks resources in local mode

[ https://issues.apache.org/jira/browse/DRILL-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Nadeau resolved DRILL-1735. --- Resolution: Fixed Fixed in 9c9ee8c > JDBC driver's close() leaks resources in local mode > --

[jira] [Resolved] (DRILL-2353) Support interpreter based partition pruning

[ https://issues.apache.org/jira/browse/DRILL-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Nadeau resolved DRILL-2353. --- Resolution: Fixed Fixed in 48c9c01 > Support interpreter based partition pruning > --

Re: Review Request 32273: DRILL-2408: Invalid (0 length) parquet file created by CTAS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32273/#review77171 --- Ship it! Ship It! - Aman Sinha On March 20, 2015, 4:33 a.m., abd

[jira] [Resolved] (DRILL-2319) JDBC DrillStatementRegistry unimplemented; Statements leak, throw errors

[ https://issues.apache.org/jira/browse/DRILL-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Barclay (Drill) resolved DRILL-2319. --- Resolution: Fixed Fix Version/s: (was: 0.9.0) 0.8

Re: Lets cut a 0.8 release

Looks like we have a good quorum. I think we've had a bunch of patches merged today. I'll roll a release first thing in the morning if everything looks good at that time. On Thu, Mar 19, 2015 at 9:30 PM, Ted Dunning wrote: > I was just asked about a next release of drill in a meeting today. >