Re: Accessing QueryContext inside a StoragePluginOptimizerRule

Just wanted to let you know I've uploaded the patch: https://issues.apache.org/jira/browse/DRILL-1950 Be great to get some feedback or start a review board so I can see what needs to be done to get it merged in! On Fri, May 1, 2015 at 12:13 PM, Jacques Nadeau wrote: > Yes. Once per query is f

Re: Accessing QueryContext inside a StoragePluginOptimizerRule

Hey Adam, just saw that. Can you post to reviewboard? If you don't have an account, you can easily register for one. On May 4, 2015 8:25 AM, "Adam Gilmore" wrote: > Just wanted to let you know I've uploaded the patch: > > https://issues.apache.org/jira/browse/DRILL-1950 > > Be great to get som

Re: Review Request 33779: DRILL-2932: Fix: Error printed to System.out; text not in exception message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33779/#review82370 --- LGTM - abdelhakim deneche On May 2, 2015, 6:12 a.m., Daniel Barcl

[jira] [Created] (DRILL-2947) AllocationHelper.allocateNew() doesn't have a consistent behavior when it can't allocate

Deneche A. Hakim created DRILL-2947: --- Summary: AllocationHelper.allocateNew() doesn't have a consistent behavior when it can't allocate Key: DRILL-2947 URL: https://issues.apache.org/jira/browse/DRILL-2947

Re: Review Request 33779: DRILL-2932: Fix: Error printed to System.out; text not in exception message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33779/#review82390 --- Suggestion: can you make the change to distribution/src/resources/sq

what is the correct behavior when an upstream operator returns STOP

What is the correct behavior for an operator when it receives an IterOutcome.STOP from upstream: 1. should it just stop right away and return STOP downstream ?, or 2. should it cleanup it's resources before returning STOP downstream ? Some operators follow 1 and others (like OrderedPartitionRecord

Re: Review Request 33812: DRILL-2928: C++ client - io_service needs to be reset after running out of work

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33812/ --- (Updated May 4, 2015, 4:50 p.m.) Review request for drill, Alexander zarei, Meh

Review Request 33812: DRILL-2928: C++ client - io_service needs to be reset after running out of work

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33812/ --- Review request for drill, Alexander zarei, Mehant Baid, Norris Lee, and Xiao Men

Re: Review Request 33779: DRILL-2932: Fix: Error printed to System.out; text not in exception message.

> On May 4, 2015, 4:49 p.m., Sudheesh Katkam wrote: > > Suggestion: can you make the change to distribution/src/resources/sqlline > > (mentioned > > [here](https://github.com/sudheeshkatkam/drill/commit/7d31db0c3958065a2b61b61d0b0fe45cf56ed83a#diff-038a53b6ec34c26bde1682faf16d79ba)) > > to add

Re: what is the correct behavior when an upstream operator returns STOP

In general, an operator should release its resources as soon as it can. I believe Steven is working on a patch to make all resource intensive operators do just this. On Mon, May 4, 2015 at 9:47 AM, Abdel Hakim Deneche wrote: > What is the correct behavior for an operator when it receives an > I

Re: what is the correct behavior when an upstream operator returns STOP

The *current* correct behavior is to return STOP downstream. That is because the ownership of batches created by that operator's allocator may have been transferred downstream, and if we try to cleanup right away, it will result in apparent memory leaks. Like Jacques mentioned, I am working on a p

Re: Review Request 33779: DRILL-2932: Fix: Error printed to System.out; text not in exception message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33779/#review82394 --- This patch seems to have more than what the JIRA says. Can you updat

[jira] [Created] (DRILL-2948) Drill MicroStrategy Document has an incorrect image

Andries Engelbrecht created DRILL-2948: -- Summary: Drill MicroStrategy Document has an incorrect image Key: DRILL-2948 URL: https://issues.apache.org/jira/browse/DRILL-2948 Project: Apache Drill

[jira] [Created] (DRILL-2949) TPC-DS queries 1 and 30 fail with CannotPlanException

Abhishek Girish created DRILL-2949: -- Summary: TPC-DS queries 1 and 30 fail with CannotPlanException Key: DRILL-2949 URL: https://issues.apache.org/jira/browse/DRILL-2949 Project: Apache Drill

[jira] [Resolved] (DRILL-2934) Exception when distinct aggregate is compared to numeric literal with decimal point

[ https://issues.apache.org/jira/browse/DRILL-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-2934. --- Resolution: Fixed Fix Version/s: (was: 0.9.0) 1.0.0 This is fixed in mas

[jira] [Created] (DRILL-2950) remove Unit tests output to System.out

Deneche A. Hakim created DRILL-2950: --- Summary: remove Unit tests output to System.out Key: DRILL-2950 URL: https://issues.apache.org/jira/browse/DRILL-2950 Project: Apache Drill Issue Type:

RecordBatchLoader.load(...) SchemaChangeException

In RecordBatchLoader, the load(...) method is declared to throw SchemaChangeException, but it never actually throws SchemaChangeException. It supposed to be declared to throw SchemaChangeException? (E.g., are we reserving the "right" for load(...) to throw that, and declaring "throws SchemaChang

Re: RecordBatchLoader.load(...) SchemaChangeException

I think it is most likely a remnant that should be removed. On Mon, May 4, 2015 at 11:38 AM, Daniel Barclay wrote: > In RecordBatchLoader, the load(...) method is declared to throw > SchemaChangeException, but it never actually throws SchemaChangeException. > > It supposed to be declared to thro

Re: RecordBatchLoader.load(...) SchemaChangeException

We now use return value as an indicator of schema change. As Steven says, throws statement should be removed. On Mon, May 4, 2015 at 11:54 AM, Steven Phillips wrote: > I think it is most likely a remnant that should be removed. > > On Mon, May 4, 2015 at 11:38 AM, Daniel Barclay > wrote: > > >

Re: Review Request 33779: DRILL-2932: Fix: Error printed to System.out; text not in exception message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33779/#review82418 --- exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java

Re: RecordBatchLoader.load(...) SchemaChangeException

I've seen a lot of these (this and other exceptions), and they seem to be remnants from an earlier time when things worked differently. So I just remove them. On Mon, May 4, 2015 at 11:59 AM, Hanifi Gunes wrote: > We now use return value as an indicator of schema change. As Steven says, > throws

[jira] [Created] (DRILL-2951) Tables are not visible when Drillbit is specified in the connection URL

Kunal Khatua created DRILL-2951: --- Summary: Tables are not visible when Drillbit is specified in the connection URL Key: DRILL-2951 URL: https://issues.apache.org/jira/browse/DRILL-2951 Project: Apache D

Re: RecordBatchLoader.load(...) SchemaChangeException

To clarify: load(...) returns a boolean value to indicate whether there was a schema change. Initially, I thought that throwing SchemaChangeException was an old way of indicating a schema change, and so thought that the throws declaration and various catches were obsolete. However, reportedly

Re: RecordBatchLoader.load(...) SchemaChangeException

Daniel, your description is correct. Let's remove if we're not using them anymore. On Mon, May 4, 2015 at 1:18 PM, Daniel Barclay wrote: > To clarify: > > load(...) returns a boolean value to indicate whether there was a schema > change. > > Initially, I thought that throwing SchemaChangeExcept

[jira] [Created] (DRILL-2952) Hive 1.0 plugin for Drill

Na Yang created DRILL-2952: -- Summary: Hive 1.0 plugin for Drill Key: DRILL-2952 URL: https://issues.apache.org/jira/browse/DRILL-2952 Project: Apache Drill Issue Type: Task Components: Fun

[ANNOUNCE] Release of Apache Drill 0.9.0

Gooday Everyone, I'm pleased to announce the release of Apache Drill 0.9.0. We've made a number of strides in both stability and security. There are huge number of enhancements and bug fixes. You can check out our release highlights at [1]. Download at [2] or review the list of more than 200 i

[jira] [Created] (DRILL-2953) Group By + Order By query results are not ordered.

Khurram Faraaz created DRILL-2953: - Summary: Group By + Order By query results are not ordered. Key: DRILL-2953 URL: https://issues.apache.org/jira/browse/DRILL-2953 Project: Apache Drill Iss

Re: [ANNOUNCE] Release of Apache Drill 0.9.0

Also, please note that the Drill docs are now posted and maintained on a new site: http://drill.apache.org/docs/ Thanks to Tomer, Bridget, and Kristine for getting the new site up and running. Bob On Mon, May 4, 2015 at 2:40 PM, Jacques Nadeau wrote: > Gooday Everyone, > > I'm pleased to annou

Re: Review Request 33662: DRILL-2902: Add support for context functions: user (synonyms session_user and system_user) and current_schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33662/ --- (Updated May 4, 2015, 10:09 p.m.) Review request for drill and Mehant Baid. C

Review Request 33822: DRILL-2952: Hive 1.0 plugin for Drill

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33822/ --- Review request for drill. Bugs: DRILL-2952 https://issues.apache.org/jira/b

Re: Review Request 33139: Drill-1827: Unit test framework reports expected and actual values backwards in unordered comparison

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33139/#review82452 --- Ship it! Ship It! - Venki Korukanti On April 13, 2015, 7:10 p.m.

[jira] [Resolved] (DRILL-2921) Query with a mix of distinct and not distinct scalar aggregates runs out of memory

[ https://issues.apache.org/jira/browse/DRILL-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Markman resolved DRILL-2921. - Resolution: Invalid > Query with a mix of distinct and not distinct scalar aggregates runs

[jira] [Created] (DRILL-2954) OOM: CTAS from JSON to Parquet on a single wide row JSON file

Chun Chang created DRILL-2954: - Summary: OOM: CTAS from JSON to Parquet on a single wide row JSON file Key: DRILL-2954 URL: https://issues.apache.org/jira/browse/DRILL-2954 Project: Apache Drill

Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/ --- Review request for drill, Hanifi Gunes, Jacques Nadeau, and Steven Phillips. Bu

[jira] [Resolved] (DRILL-2232) Flatten functionality not well defined when we use flatten in an order by without projecting it

[ https://issues.apache.org/jira/browse/DRILL-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-2232. Resolution: Later Flatten has been disabled in the order by clause by 2181. We will look at

[jira] [Resolved] (DRILL-2228) Projecting '*' returns all nulls when we have flatten in a filter and order by

[ https://issues.apache.org/jira/browse/DRILL-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-2228. Resolution: Later Flatten has been disabled in the order by clause by DRILL-2181. We will lo

source position of subidentifier, not whole name

Jinfeng, I notice that in this error message: java.sql.SQLException: PARSE ERROR: From line 7, column 12 to line 7, column 14: Table 'dfs.cross-sources.fewtypes_null_view1' not found the columns numbers referring to this line 7: inner join dfs.`cross-sources`.fewtypes_null_view1 o point to j

[jira] [Resolved] (DRILL-2264) Incorrect data when we use aggregate functions with flatten

[ https://issues.apache.org/jira/browse/DRILL-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-2264. Resolution: Later Flatten has been disabled in the group by clause by DRILL-2181. We will lo

Review Request 33833: DRILL-2848: Part 2: Provide option to disable decimal type

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33833/ --- Review request for drill, Jason Altekruse and Jinfeng Ni. Repository: drill-git

Review Request 33834: DRILL-2848: Part 1: ParquetToDrillTypeConverter hygiene patch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33834/ --- Review request for drill and Jason Altekruse. Repository: drill-git Descripti

Re: source position of subidentifier, not whole name

Please open a JIRA. We should point to the compound name in the error message. On Mon, May 4, 2015 at 5:44 PM, Daniel Barclay wrote: > Jinfeng, > > I notice that in this error message: > > java.sql.SQLException: PARSE ERROR: From line 7, column 12 to line 7, > column 14: Table 'dfs.cross-sourc

[jira] [Resolved] (DRILL-2208) Error message must be updated when query contains operations on a flattened column

[ https://issues.apache.org/jira/browse/DRILL-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-2208. Resolution: Duplicate Fix Version/s: (was: 1.0.0) > Error message must be updated

Review Request 33836: DRILL-1950: Parquet pushdown filtering

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33836/ --- Review request for drill and Jacques Nadeau. Repository: drill-git Descriptio

Re: Accessing QueryContext inside a StoragePluginOptimizerRule

No worries - just posted it to https://reviews.apache.org/r/33836/ and updated the JIRA accordingly. On Mon, May 4, 2015 at 11:26 PM, Jacques Nadeau wrote: > Hey Adam, just saw that. Can you post to reviewboard? If you don't have > an account, you can easily register for one. > On May 4, 2015

[jira] [Resolved] (DRILL-1827) Unit test framework reports expected and actual values backwards in unordered comparison

[ https://issues.apache.org/jira/browse/DRILL-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-1827. Resolution: Fixed Fixed in dcbf46194775b01031e817b715dfed98b8be5c3e > Unit test framework r

[jira] [Resolved] (DRILL-2221) CTAS (JSON) creates unreadable files when writing empty arrays

[ https://issues.apache.org/jira/browse/DRILL-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-2221. Resolution: Fixed Fixed in ac823fe8bd9d6b778f37e32d95ab0d199f8ff551 > CTAS (JSON) creates u

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/ --- (Updated May 5, 2015, 2:51 a.m.) Review request for drill, Hanifi Gunes, Jacque

Re: Review Request 33779: DRILL-2932: Fix: Error text reported via System.out.println rather than thrown SQLException's message

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33779/ --- (Updated May 5, 2015, 3:08 a.m.) Review request for drill, abdelhakim deneche,

Re: Review Request 33779: DRILL-2932: Fix: Error text reported via System.out.println rather than thrown SQLException's message

> On May 4, 2015, 5:43 p.m., Parth Chandra wrote: > > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java, line 144 > > > > > > This looks odd since RecordBatchLoader.load() does not seem to be > > throwing

Re: Review Request 33779: DRILL-2932: Fix: Error text reported via System.out.println rather than thrown SQLException's message

> On May 4, 2015, 4:49 p.m., Sudheesh Katkam wrote: > > Suggestion: can you make the change to distribution/src/resources/sqlline > > (mentioned > > [here](https://github.com/sudheeshkatkam/drill/commit/7d31db0c3958065a2b61b61d0b0fe45cf56ed83a#diff-038a53b6ec34c26bde1682faf16d79ba)) > > to add

Re: Review Request 33779: DRILL-2932: Fix: Error text reported via System.out.println rather than thrown SQLException's message

> On May 4, 2015, 7:08 p.m., Parth Chandra wrote: > > exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillCursor.java, line 148 > > > > > > This is never released if an exception is throw. Added finally clause around t

Re: Review Request 33779: DRILL-2932: Fix: Error text reported via System.out.println rather than thrown SQLException's message

> On May 4, 2015, 4:49 p.m., Sudheesh Katkam wrote: > > Suggestion: can you make the change to distribution/src/resources/sqlline > > (mentioned > > [here](https://github.com/sudheeshkatkam/drill/commit/7d31db0c3958065a2b61b61d0b0fe45cf56ed83a#diff-038a53b6ec34c26bde1682faf16d79ba)) > > to add

[jira] [Created] (DRILL-2955) Enable color in sqlline for exceptions

Sudheesh Katkam created DRILL-2955: -- Summary: Enable color in sqlline for exceptions Key: DRILL-2955 URL: https://issues.apache.org/jira/browse/DRILL-2955 Project: Apache Drill Issue Type: I

[jira] [Created] (DRILL-2956) "SELECT * BadAlias ..." yields "SYSTEM ERROR ... index (-1) must not be negative"

Daniel Barclay (Drill) created DRILL-2956: - Summary: "SELECT * BadAlias ..." yields "SYSTEM ERROR ... index (-1) must not be negative" Key: DRILL-2956 URL: https://issues.apache.org/jira/browse/DRILL-2956