[jira] [Created] (DRILL-3168) Char overflow in LimitRecordBatch

2015-05-22 Thread JIRA
徐波 created DRILL-3168: - Summary: Char overflow in LimitRecordBatch Key: DRILL-3168 URL: https://issues.apache.org/jira/browse/DRILL-3168 Project: Apache Drill Issue Type: Bug Affects Versions:

Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type instantiate its children upon construction

2015-05-22 Thread Hanifi Gunes
On May 21, 2015, 10:42 p.m., Mehant Baid wrote: exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java, line 145 https://reviews.apache.org/r/34499/diff/1/?file=965701#file965701line145 In which case where we creating vector with Late type.

Re: Review Request 34530: DRILL-3130: Add DrillUnionRule

2015-05-22 Thread Sean Hsuan-Yi Chu
On May 22, 2015, 7:01 p.m., Aman Sinha wrote: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectPastUnionRule.java, line 48 https://reviews.apache.org/r/34530/diff/1/?file=966108#file966108line48 With this new rule, what will happen if we are

Re: Review Request 34530: DRILL-3130: Add DrillUnionRule

2015-05-22 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34530/ --- (Updated May 22, 2015, 10:33 p.m.) Review request for drill, Aman Sinha and

Re: Review Request 34498: DRILL-3143: MaterializedField#clone should deep copy itself without disregarding its children

2015-05-22 Thread Jason Altekruse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34498/#review85003 --- Ship it!

[jira] [Created] (DRILL-3174) Calcite blocks queries whose type-missmatch can be resolved by Drill's Implicit casting

2015-05-22 Thread Sean Hsuan-Yi Chu (JIRA)
Sean Hsuan-Yi Chu created DRILL-3174: Summary: Calcite blocks queries whose type-missmatch can be resolved by Drill's Implicit casting Key: DRILL-3174 URL: https://issues.apache.org/jira/browse/DRILL-3174

Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type instantiate its children upon construction

2015-05-22 Thread Mehant Baid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34499/#review85012 --- Ship it! Ship It! - Mehant Baid On May 22, 2015, 9:19 p.m.,

Re: Review Request 34497: DRILL-3108: Replace templated returns with covariant return overrides

2015-05-22 Thread Parth Chandra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34497/#review85008 --- Ship it! Ship It! - Parth Chandra On May 20, 2015, 9:04 p.m.,

Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type instantiate its children upon construction

2015-05-22 Thread Hanifi Gunes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34499/ --- (Updated May 22, 2015, 9:19 p.m.) Review request for drill and Mehant Baid.

Re: Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

2015-05-22 Thread abdelhakim deneche
On May 22, 2015, 10:14 p.m., Chris Westin wrote: protocol/src/main/protobuf/UserBitShared.proto, line 162 https://reviews.apache.org/r/34603/diff/1/?file=969528#file969528line162 Is this aligned right? It doesn't look right in the diff for some reason. the other lines contain a

[jira] [Created] (DRILL-3176) Need an easier way to configure JDBC clients to connect to Drill in embedded mode

2015-05-22 Thread Bob Rumsby (JIRA)
Bob Rumsby created DRILL-3176: - Summary: Need an easier way to configure JDBC clients to connect to Drill in embedded mode Key: DRILL-3176 URL: https://issues.apache.org/jira/browse/DRILL-3176 Project:

[jira] [Created] (DRILL-3177) Upgrade Mongo java driver to 3.0.1

2015-05-22 Thread Bhallamudi Venkata Siva Kamesh (JIRA)
Bhallamudi Venkata Siva Kamesh created DRILL-3177: - Summary: Upgrade Mongo java driver to 3.0.1 Key: DRILL-3177 URL: https://issues.apache.org/jira/browse/DRILL-3177 Project: Apache

Review Request 34520: DRILL-3159: Part 1--Prep., Hyg. for: Make JDBC throttling threshold configurable.

2015-05-22 Thread Daniel Barclay
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34520/ --- Review request for drill, Mehant Baid and Parth Chandra. Bugs: DRILL-3159

Review Request 34521: DRILL-3159: Part 2--Core: Make JDBC throttling threshold configurable.

2015-05-22 Thread Daniel Barclay
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34521/ --- Review request for drill. Bugs: DRILL-3159

Re: Review Request 34541: DRILL-3147: tpcds-sf1-parquet query 73 causes memory leak

2015-05-22 Thread abdelhakim deneche
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34541/ --- (Updated May 22, 2015, 11:15 p.m.) Review request for drill, Chris Westin and

[jira] [Created] (DRILL-3178) csv reader should allow newlines inside quotes

2015-05-22 Thread Neal McBurnett (JIRA)
Neal McBurnett created DRILL-3178: - Summary: csv reader should allow newlines inside quotes Key: DRILL-3178 URL: https://issues.apache.org/jira/browse/DRILL-3178 Project: Apache Drill Issue

Re: Review Request 34498: DRILL-3143: MaterializedField#clone should deep copy itself without disregarding its children

2015-05-22 Thread Hanifi Gunes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34498/ --- (Updated May 22, 2015, 10:21 p.m.) Review request for drill, Jason Altekruse

Re: Review Request 34541: DRILL-3147: tpcds-sf1-parquet query 73 causes memory leak

2015-05-22 Thread Chris Westin
On May 22, 2015, 11:15 a.m., Chris Westin wrote: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestTpcdsSf1Leaks.java, line 56 https://reviews.apache.org/r/34541/diff/3/?file=966939#file966939line56 Can we indent this a little better so it's easier to see the nested

[jira] [Created] (DRILL-3169) gz files cannot be accessed without gz plugin extension definition

2015-05-22 Thread Kristine Hahn (JIRA)
Kristine Hahn created DRILL-3169: Summary: gz files cannot be accessed without gz plugin extension definition Key: DRILL-3169 URL: https://issues.apache.org/jira/browse/DRILL-3169 Project: Apache

Re: Review Request 34575: DRILL-3019: Extra column in Schema of Recordbatch from scanning Values

2015-05-22 Thread Sean Hsuan-Yi Chu
On May 22, 2015, 12:41 a.m., Aman Sinha wrote: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java, line 436 https://reviews.apache.org/r/34575/diff/1/?file=968424#file968424line436 The JIRA talks about performance degradation - is that as a

Review Request 34598: DRILL-2923: Ensure all unit tests pass without assertions enabled

2015-05-22 Thread Chris Westin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34598/ --- Review request for drill. Bugs: DRILL-2923

[jira] [Resolved] (DRILL-2346) Star is not expanded correctly in create view if view fields are specified

2015-05-22 Thread Jinfeng Ni (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinfeng Ni resolved DRILL-2346. --- Resolution: Won't Fix Please re-open it if you feel this feature is strongly required. Otherwise, I

[GitHub] drill pull request: Update 020-develop-a-simple-function.md

2015-05-22 Thread kristinehahn
Github user kristinehahn commented on the pull request: https://github.com/apache/drill/pull/77#issuecomment-104726522 @hsuanyi please close this pull request, it has been fixed, and I can't close it. --- If your project is set up for it, you can reply to this email and have your

[GitHub] drill pull request: updated output of select * from sys.drillbits

2015-05-22 Thread kristinehahn
Github user kristinehahn commented on the pull request: https://github.com/apache/drill/pull/74#issuecomment-104728083 Doc fixed, please close pull request @adeneche --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] drill pull request: drill version fix

2015-05-22 Thread adeneche
Github user adeneche closed the pull request at: https://github.com/apache/drill/pull/73 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: updated output of select * from sys.drillbits

2015-05-22 Thread adeneche
Github user adeneche closed the pull request at: https://github.com/apache/drill/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: drill version fix

2015-05-22 Thread kristinehahn
Github user kristinehahn commented on the pull request: https://github.com/apache/drill/pull/73#issuecomment-104728479 Please close this pull request. I have fixed the doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] drill pull request: fix drill version

2015-05-22 Thread kristinehahn
Github user kristinehahn commented on the pull request: https://github.com/apache/drill/pull/72#issuecomment-104728563 Please close this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Review Request 34541: DRILL-3147: tpcds-sf1-parquet query 73 causes memory leak

2015-05-22 Thread Chris Westin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34541/#review84943 --- Steven knows much more about this area of the code than I do, so my

Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

2015-05-22 Thread abdelhakim deneche
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34603/ --- Review request for drill, Chris Westin, Jacques Nadeau, and Sudheesh Katkam.

memory leak in TestResourceLeak, is it expected ?

2015-05-22 Thread Abdel Hakim Deneche
I'm seeing the following a memory leak in TestResourceLeak: Total 51599 allocation(s) of byte size(s): 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, ... at stack location: org.apache.drill.exec.memory.TopLevelAllocator$ChildAllocator.buffer(TopLevelAllocator.java:273)

[jira] [Resolved] (DRILL-2985) REGRESSION : NPE seen for project distinct values from CSV

2015-05-22 Thread Khurram Faraaz (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khurram Faraaz resolved DRILL-2985. --- Resolution: Fixed REGRESSION : NPE seen for project distinct values from CSV

[GitHub] drill pull request: Update 020-core-modules.md

2015-05-22 Thread kristinehahn
Github user kristinehahn commented on the pull request: https://github.com/apache/drill/pull/76#issuecomment-104727307 @jinfengni please close this pull request, I fixed the doc, but can't close this pull request. --- If your project is set up for it, you can reply to this email and

Re: Review Request 34074: DRILL-3035 Create ControlsInjector interface to enforce implementing methods

2015-05-22 Thread Chris Westin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34074/#review84941 --- Ship it (non-binding).

Re: Review Request 34575: DRILL-3019: Extra column in Schema of Recordbatch from scanning Values

2015-05-22 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34575/ --- (Updated May 22, 2015, 5:41 p.m.) Review request for drill, Aman Sinha and

[GitHub] drill pull request: fix version in 047-installing-drill-on-the-clu...

2015-05-22 Thread kristinehahn
Github user kristinehahn commented on the pull request: https://github.com/apache/drill/pull/75#issuecomment-104727797 @adeneche please close this pull request. I have fixed the doc, but can't close the pull request. --- If your project is set up for it, you can reply to this email

[GitHub] drill pull request: fix drill version

2015-05-22 Thread adeneche
Github user adeneche closed the pull request at: https://github.com/apache/drill/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: fix version in 047-installing-drill-on-the-clu...

2015-05-22 Thread adeneche
Github user adeneche closed the pull request at: https://github.com/apache/drill/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is