[jira] [Created] (DRILL-3277) SUM(CAST(columns[0] AS INT)) OVER(...) gives wrong results

Deneche A. Hakim created DRILL-3277: --- Summary: SUM(CAST(columns[0] AS INT)) OVER(...) gives wrong results Key: DRILL-3277 URL: https://issues.apache.org/jira/browse/DRILL-3277 Project: Apache Drill

[jira] [Created] (DRILL-3278) SUM(CAST(columns[0] AS BIGINT)) OVER(...) gives wrong results

Deneche A. Hakim created DRILL-3278: --- Summary: SUM(CAST(columns[0] AS BIGINT)) OVER(...) gives wrong results Key: DRILL-3278 URL: https://issues.apache.org/jira/browse/DRILL-3278 Project: Apache Dri

Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/ --- Review request for drill, Aman Sinha and Jinfeng Ni. Bugs: DRILL-3182, DRILL-31

Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

> On June 11, 2015, 12:24 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java, > > line 60 > > > > > > I think you should modify the DrillUnionRule to handl

Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35163/ --- (Updated June 11, 2015, 5:56 p.m.) Review request for drill, Aman Sinha and Jin

[jira] [Created] (DRILL-3279) Window functions without ORDER BY - Error message needs to be fixed

Khurram Faraaz created DRILL-3279: - Summary: Window functions without ORDER BY - Error message needs to be fixed Key: DRILL-3279 URL: https://issues.apache.org/jira/browse/DRILL-3279 Project: Apache D

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/ --- (Updated June 11, 2015, 8:33 p.m.) Review request for drill, Aman Sinha and Jin

[jira] [Created] (DRILL-3280) Missing OVER clause in window function query results in AssertionError

Khurram Faraaz created DRILL-3280: - Summary: Missing OVER clause in window function query results in AssertionError Key: DRILL-3280 URL: https://issues.apache.org/jira/browse/DRILL-3280 Project: Apach

Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35163/#review87636 --- Ship it! Ship It! - Aman Sinha On June 11, 2015, 5:56 p.m., Sean

[jira] [Created] (DRILL-3281) window functions that involve TIME columns generate wrong results

Deneche A. Hakim created DRILL-3281: --- Summary: window functions that involve TIME columns generate wrong results Key: DRILL-3281 URL: https://issues.apache.org/jira/browse/DRILL-3281 Project: Apache

[jira] [Created] (DRILL-3282) Example in workspace documentation is invalid

Hanifi Gunes created DRILL-3282: --- Summary: Example in workspace documentation is invalid Key: DRILL-3282 URL: https://issues.apache.org/jira/browse/DRILL-3282 Project: Apache Drill Issue Type:

[DISCUSSION] How can we improve the performance of Window Functions

Hi all, The purpose of this email is to describe how window functions are computed and to try to come up with "better" ways to do it. DRILL-3200 added support for RANK, ROW_NUMBER, DENSE_RANK, PERCENT_RANK and CUME_DIST but also made some signifi

Re: Review Request 34004: DRILL-1942: Improved memory allocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34004/ --- (Updated June 11, 2015, 3:58 p.m.) Review request for drill and Jacques Nadeau.

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/#review87639 --- exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/pars

Re: Review Request 35144: DRILL-3216: Part 2--Fix existing(+) INFORMATION_SCHEMA.COLUMNS columns.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35144/#review87647 --- Ship it! Ship It! - Parth Chandra On June 7, 2015, 12:40 a.m., D

Re: Review Request 35235: DRILL-3262: Rename DrillDatabaseMetaData -> DrillDatabaseMetaDataImpl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35235/#review87650 --- There appears to be an empty file in this patch. Can you fix that?

Re: Review Request 35236: DRILL-3198: Fix: DatabaseMetaData.getTypeInfo(...), etc., return null.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35236/#review87651 --- Ship it! Ship It! - Parth Chandra On June 9, 2015, 6:38 a.m., Da

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

> On June 11, 2015, 11:20 p.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java, > > line 120 > > > > > > Instead of 'disabled' we should be

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/ --- (Updated June 11, 2015, 11:46 p.m.) Review request for drill, Aman Sinha and Ji

Re: Review Request 34004: DRILL-1942: Improved memory allocator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34004/ --- (Updated June 11, 2015, 4:56 p.m.) Review request for drill and Jacques Nadeau.

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/#review87660 --- exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/pars

[jira] [Resolved] (DRILL-3172) Can not plan exception when over clause is empty

[ https://issues.apache.org/jira/browse/DRILL-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-3172. --- Resolution: Fixed Fixed in commit: fb1d3f384e6c79a540e34e70f8268feb689208ee > Can not plan exception

Re: [DISCUSSION] How can we improve the performance of Window Functions

Speed in many such loops depends a lot on how the loops are ordered so that cache and registers can be re-used. I have no idea what will make your windowing functions fast, but I can say some things about what makes matrix math fast. The key with matrix multiplication is that there are n^3/2 oper

Re: [DISCUSSION] How can we improve the performance of Window Functions

Can you give us some data on what the current performance looks like, vs what you would expect? Are we spend most of the time in the sort, or the Window function operator? On Thu, Jun 11, 2015 at 10:55 PM, Ted Dunning wrote: > Speed in many such loops depends a lot on how the loops are ordered s