[DISCUSS] DRILL-4132

2016-01-18 Thread yuliya Feldman
Hello here, I wanted to start discussion on [1] Would be nice to have a hangout session with @jacques-n, @hnfgns,  @StevenMPhillips Let me know suitable time Thanks,Yuliya [1] https://issues.apache.org/jira/browse/DRILL-4132

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-18 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/325#issuecomment-172747355 Let's do a separate hangout. This seems to deep/specific to cover in a large group. On Jan 18, 2016 9:51 AM, "Hanifi Gunes" wrote: > Cool. Let's sync up

[GitHub] drill pull request: DRILL-4278: Fix issue where WorkspaceConfig wa...

2016-01-18 Thread jacques-n
GitHub user jacques-n opened a pull request: https://github.com/apache/drill/pull/331 DRILL-4278: Fix issue where WorkspaceConfig was not returning consist…ent hashCode()s for equal objects. WorkspaceConfig was generating different values which caused us to cache separate instanc

[GitHub] drill pull request: Bumps FMPP version to 0.9.15

2016-01-18 Thread laurentgo
GitHub user laurentgo opened a pull request: https://github.com/apache/drill/pull/330 Bumps FMPP version to 0.9.15 FMPP 0.9.14 pom.xml specifies a version range for FreeMarker dependency, which should be okay except that latest SNAPSHOT version doesn't resolve anymore. FM

[GitHub] drill pull request: DRILL-4256: Create HiveConf per HiveStoragePlu...

2016-01-18 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/329 DRILL-4256: Create HiveConf per HiveStoragePlugin and reuse it wherev… …er needed. Creating new instances of HiveConf() are very costly, we should avoid creating new ones as much as p

[GitHub] drill pull request: DRILL-4131: Move RPC allocators under Drill's ...

2016-01-18 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/327#issuecomment-172623959 One quick note, I still am receiving failures on a small set of unit tests because of metric registration conflicts so I'll be fixing those. (Happens only in tests wher

[GitHub] drill pull request: DRILL-4131: Move RPC allocators under Drill's ...

2016-01-18 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/327#discussion_r50033277 --- Diff: exec/memory/base/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java --- @@ -59,7 +59,7 @@ public PooledByteBufAllocatorL(MetricRegistry reg

[GitHub] drill pull request: DRILL-4131: Move RPC allocators under Drill's ...

2016-01-18 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/327#discussion_r50033210 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -56,22 +60,83 @@ private final DrillConfig config;

[jira] [Created] (DRILL-4281) Drill should support inbound impersonation

2016-01-18 Thread Keys Botzum (JIRA)
Keys Botzum created DRILL-4281: -- Summary: Drill should support inbound impersonation Key: DRILL-4281 URL: https://issues.apache.org/jira/browse/DRILL-4281 Project: Apache Drill Issue Type: Impro

[jira] [Created] (DRILL-4280) Kerberos Authentication

2016-01-18 Thread Keys Botzum (JIRA)
Keys Botzum created DRILL-4280: -- Summary: Kerberos Authentication Key: DRILL-4280 URL: https://issues.apache.org/jira/browse/DRILL-4280 Project: Apache Drill Issue Type: Improvement

[GitHub] drill pull request: DRILL-4270: Create a separate WindowFramer tha...

2016-01-18 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/322#issuecomment-172619347 Renaming sounds fine to avoid misinterpretation. +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] drill pull request: DRILL-4131: Move RPC allocators under Drill's ...

2016-01-18 Thread adeneche
Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/327#issuecomment-172604924 apart from a small code change, LGTM. Let's run a couple of tests (performance and concurrency) before merging this PR. +1 --- If your project is set up f

[GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...

2016-01-18 Thread hnfgns
Github user hnfgns commented on the pull request: https://github.com/apache/drill/pull/325#issuecomment-172604790 Cool. Let's sync up on tomorrow's weekly hangout. Let me know if that does not work for you. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] drill pull request: DRILL-4131: Move RPC allocators under Drill's ...

2016-01-18 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/327#discussion_r50026812 --- Diff: exec/memory/base/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java --- @@ -59,7 +59,7 @@ public PooledByteBufAllocatorL(MetricRegistry regi

[GitHub] drill pull request: DRILL-4131: Move RPC allocators under Drill's ...

2016-01-18 Thread adeneche
Github user adeneche commented on a diff in the pull request: https://github.com/apache/drill/pull/327#discussion_r50024752 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java --- @@ -56,22 +60,83 @@ private final DrillConfig config;