[GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...

2016-02-14 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/376#discussion_r52864208 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -45,6 +48,10 @@ public List files; public

[GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...

2016-02-14 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/376#discussion_r52864039 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java --- @@ -157,7 +159,20 @@ private String

[GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...

2016-02-14 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/374#issuecomment-184037187 Looks reasonable. I added a few comments. I think the Mongo interface => class changes should be a separate patch. It adds noise to this patch and is really a

[GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52855320 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java --- @@ -206,6 +205,16 @@ public DistributedSemaphore

[GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52855239 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/ZookeeperPersistentStore.java --- @@ -0,0 +1,136 @@ +/** + * Licensed

[GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52855204 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/serialization/JacksonSerializer.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to the

[GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52855187 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/serialization/InstanceSerializer.java --- @@ -6,20 +6,20 @@ * to you under the Apache

[GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52855145 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/PathUtils.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52855121 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/store/TransientStoreListener.java --- @@ -0,0 +1,22 @@ +/** + * Licensed to the

[GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52855054 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/ClusterCoordinator.java --- @@ -60,16 +62,23 @@ public abstract

[GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52855063 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/MapBackedStore.java --- @@ -0,0 +1,86 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/376#discussion_r52854912 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java --- @@ -45,6 +48,10 @@ public List files; public

[GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...

2016-02-14 Thread jacques-n
Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/376#discussion_r52854886 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java --- @@ -157,7 +159,20 @@ private String

[jira] [Created] (DRILL-4385) Support metadata and prepare operations on User RPC layer

2016-02-14 Thread Jacques Nadeau (JIRA)
Jacques Nadeau created DRILL-4385: - Summary: Support metadata and prepare operations on User RPC layer Key: DRILL-4385 URL: https://issues.apache.org/jira/browse/DRILL-4385 Project: Apache Drill

[GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...

2016-02-14 Thread amansinha100
GitHub user amansinha100 opened a pull request: https://github.com/apache/drill/pull/376 DRILL-4287: During initial DrillTable creation don't read the metadat… …a cache file; instead do it during ParquetGroupScan. Maintain state in FileSelection to keep track of whether

[GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...

2016-02-14 Thread amansinha100
Github user amansinha100 closed the pull request at: https://github.com/apache/drill/pull/345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature