[GitHub] drill pull request: DRILL-4452: Uses Apache Calcite Avatica driver...

Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/395#issuecomment-193418830 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

Re: Time for the 1.6 Release

I reopened DRILL-4384 (blocker); it is assigned to Jacques. On the latest master, the visualized and physical plan tabs on web UI are empty. Thank you, Sudheesh > On Mar 7, 2016, at 11:39 AM, Jason Altekruse wrote: > > I don't know if there a

[GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...

Github user chunhui-shi commented on the pull request: https://github.com/apache/drill/pull/408#issuecomment-193430786 As to the test code that use original cpp implementation to generate the test vectors in murmur3_buf.json and murmur3_double.json. Please refer to here: http

Re: Time for the 1.6 Release

I'm inclined to go ahead with the release unless DRILL-4477 is a regression. On Mon, Mar 7, 2016 at 11:39 AM, Jason Altekruse wrote: > I don't know if there are any specific time constraints for getting out the > release, but I'm inclined to go with Vicky on DRILL-4477, at least some > investiga

Re: Time for the 1.6 Release

DRILL-4384 is a blocker for the release though On Mon, Mar 7, 2016 at 12:01 PM, Sudheesh Katkam wrote: > I reopened DRILL-4384 > (blocker); it is assigned to Jacques. > > On the latest master, the visualized and physical plan tabs on web UI are

Re: Time for the 1.6 Release

DRILL-4482 is also a regression On Mon, Mar 7, 2016 at 8:36 PM, Parth Chandra wrote: > I'm inclined to go ahead with the release unless DRILL-4477 is a > regression. > > On Mon, Mar 7, 2016 at 11:39 AM, Jason Altekruse > > wrote: > > > I don't

Re: Time for the 1.6 Release

The new bug (currently filed under DRILL-4384) is a completely different bug than the original (original one has to do with profile metrics, this has to do with plan text). I try to look at it tonight if noone can get to it sooner. -- Jacques Nadeau CTO and Co-Founder, Dremio On Mon, Mar 7, 2016

Re: Time for the 1.6 Release

It is in 1.4.0 On Mon, Mar 7, 2016 at 11:35 AM, Zelaine Fong wrote: > Vicky, > > Per our discussion today, let us know if this issue also exists in 1.4. > From the discussion, it sounds like this is not a recent regression. > > -- Zelaine > > On Mon, Mar 7, 2016 at 10:44 AM, Vicky Markman > wro

Re: Time for the 1.6 Release

Thanks for clarifying Jacques. I haven’t looked into the fix for DRILL-4384; I reopened it because the description mentioned “visualized plan” section is (also) empty. Thank you, Sudheesh > On Mar 7, 2016, at 1:08 PM, Jacques Nadeau wrote: > > The new bug (currently filed under DRILL-4384) is

[GitHub] drill pull request: DRILL-4184: support variable length decimal fi...

Github user daveoshinsky commented on a diff in the pull request: https://github.com/apache/drill/pull/372#discussion_r55277730 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLengthValuesColumn.java --- @@ -81,6 +112,14 @@ public boolea

Re: Time for the 1.6 Release

WebUI profile issue: this is a regression cause by refactoring of Calcite integration code (DRILL-4465) which sets the text plan only if debug is enabled. Will submit a patch soon. On Mon, Mar 7, 2016 at 1:29 PM, Sudheesh Katkam wrote: > Thanks for clarifying Jacques. > > I haven’t looked into t

Re: Time for the 1.6 Release

There is a small test issue with some of the refactoring that accompanied the operator unit tests. These don't change any user-facing behavior, so I don't think it really needs to get into the release. I will be working to merge them into master after we cut the release branch. The change to updat

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user paul-rogers commented on the pull request: https://github.com/apache/drill/pull/396#issuecomment-193489132 Thanks for addressing the review comments! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user hnfgns commented on a diff in the pull request: https://github.com/apache/drill/pull/396#discussion_r55286410 --- Diff: contrib/native/client/example/querySubmitter.cpp --- @@ -317,16 +320,20 @@ int main(int argc, char* argv[]) { std::vector::iterator queryH

[jira] [Created] (DRILL-4483) Fix text plan issue in query profiles

Venki Korukanti created DRILL-4483: -- Summary: Fix text plan issue in query profiles Key: DRILL-4483 URL: https://issues.apache.org/jira/browse/DRILL-4483 Project: Apache Drill Issue Type: Bu

[jira] [Created] (DRILL-4484) NPE when querying empty directory

Victoria Markman created DRILL-4484: --- Summary: NPE when querying empty directory Key: DRILL-4484 URL: https://issues.apache.org/jira/browse/DRILL-4484 Project: Apache Drill Issue Type: Bu

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user hnfgns commented on a diff in the pull request: https://github.com/apache/drill/pull/396#discussion_r55290473 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -1392,6 +1390,206 @@ void DrillClientQueryResult::clearAndDestroy(){ } }

[GitHub] drill pull request: DRILL-4313: Improve method of picking a random...

Github user hnfgns commented on the pull request: https://github.com/apache/drill/pull/396#issuecomment-193499159 +1 once comments above are addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] drill pull request: DRILL-4443: MIN/MAX on VARCHAR throw a NullPoi...

Github user hnfgns commented on the pull request: https://github.com/apache/drill/pull/409#issuecomment-193500314 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[jira] [Resolved] (DRILL-4384) Query profile is missing important information on WebUi

[ https://issues.apache.org/jira/browse/DRILL-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venki Korukanti resolved DRILL-4384. Resolution: Fixed > Query profile is missing important information on WebUi > --

[GitHub] drill pull request: DRILL-4483: Fix text plan regression in query ...

GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/411 DRILL-4483: Fix text plan regression in query profiles You can merge this pull request into a Git repository by running: $ git pull https://github.com/vkorukanti/drill profile_fix Alternati

[jira] [Created] (DRILL-4485) MapR profile - use MapR 5.1.0

Patrick Wong created DRILL-4485: --- Summary: MapR profile - use MapR 5.1.0 Key: DRILL-4485 URL: https://issues.apache.org/jira/browse/DRILL-4485 Project: Apache Drill Issue Type: New Feature

[jira] [Created] (DRILL-4486) Expression serializer incorrectly serializes escaped characters

Steven Phillips created DRILL-4486: -- Summary: Expression serializer incorrectly serializes escaped characters Key: DRILL-4486 URL: https://issues.apache.org/jira/browse/DRILL-4486 Project: Apache Dri

[GitHub] drill pull request: DRILL-4486: Fix expression serialization escap...

GitHub user StevenMPhillips opened a pull request: https://github.com/apache/drill/pull/412 DRILL-4486: Fix expression serialization escaping You can merge this pull request into a Git repository by running: $ git pull https://github.com/StevenMPhillips/drill parser Alternati

Re: Time for the 1.6 Release

DRILL-4486 is a pretty simple fix. Without it, currently some regex queries will fail. I think we should include it in the release. https://github.com/apache/drill/pull/412 On Mon, Mar 7, 2016 at 2:15 PM, Jason Altekruse wrote: > There is a small test issue with some of the refactoring that a

[GitHub] drill pull request: DRILL-4483: Fix text plan regression in query ...

Github user sudheeshkatkam commented on the pull request: https://github.com/apache/drill/pull/411#issuecomment-193531465 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

Re: Time for the 1.6 Release

4474 is actually revealing a few invalid tests in the Regression suite that test for the current incorrect plans. The fix should be included in the release, but I will post a PR on the regression suite to update the tests before I push it. On Mon, Mar 7, 2016 at 4:44 PM, Steven Phillips wrote: >

[GitHub] drill pull request: DRILL-4486: Fix expression serialization escap...

Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/412#discussion_r55304775 --- Diff: logical/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java --- @@ -119,14 +126,14 @@ public Void visitSchemaPath(Schem

[GitHub] drill pull request: DRILL-4486: Fix expression serialization escap...

Github user StevenMPhillips commented on a diff in the pull request: https://github.com/apache/drill/pull/412#discussion_r55305190 --- Diff: logical/src/main/java/org/apache/drill/common/expression/ExpressionStringBuilder.java --- @@ -119,14 +126,14 @@ public Void visitSchemaPath(

[GitHub] drill pull request: DRILL-4486: Fix expression serialization escap...

Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/412#issuecomment-193558494 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] drill pull request: DRILL-4485 - switch to MapR 5.1.0

GitHub user pwong-mapr opened a pull request: https://github.com/apache/drill/pull/413 DRILL-4485 - switch to MapR 5.1.0 https://issues.apache.org/jira/browse/DRILL-4485 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pwong-mapr/i

Re: Time for the 1.6 Release

The train is about to leave :). I'd like to propose a cutoff for tomorrow 5 pm. (This will be a full week after the initial mail so plenty of time for everyone to get their issues aired.) Here are the open items (that I am aware of) - Waiting to be merged DRILL-4483/pr 411 (Fix text plan regressi

[GitHub] drill pull request: DRILL-4483: Fix text plan regression in query ...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (DRILL-4483) Fix text plan issue in query profiles

[ https://issues.apache.org/jira/browse/DRILL-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Venki Korukanti resolved DRILL-4483. Resolution: Fixed Fix Version/s: 1.6.0 > Fix text plan issue in query profiles >

Re: Time for the 1.6 Release

The cutoff time sounds good to me. I don't think I'm too overburdened, I mostly tried putting together a merge branch today and had to kick a few things out as I found issues. As we are not running the full regression cluster at Dremio, it would be helpful if someone could merge Jacques patch (DRI

[GitHub] drill pull request: DRILL-4332: Makes vector comparison order stab...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/389 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request: DRILL-4375: Fix the maven release profile

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/402 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request: DRILL-4486: Fix expression serialization escap...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Time for the 1.6 Release

We should update the expected results (i.e. the expected query plan in this case) and not mark them as Failing. We do not have a Failing test directory today. If we are sure the expected query plans for these tests are incorrect (today), we should go ahead and update the expected results files wit

[GitHub] drill pull request: DRILL-3488: Allow Java 1.8

Github user adeneche closed the pull request at: https://github.com/apache/drill/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] drill pull request: DRILL-4443: MIN/MAX on VARCHAR throw a NullPoi...

GitHub user adeneche opened a pull request: https://github.com/apache/drill/pull/409 DRILL-4443: MIN/MAX on VARCHAR throw a NullPointerException You can merge this pull request into a Git repository by running: $ git pull https://github.com/adeneche/incubator-drill DRILL-4443

RE: Optimizing SUM(1) query

Hi, Extremely sorry for the delayed response! Basically , I am experimenting an Apache Solr plugin for Drill and tried to use Tableau. On intial selection of a "Table" , I see these queries from drill webui profile SELECT * FROM (SELECT * FROM `solr`.`CSVStringData`) T LIMIT 0 SELECT * FROM (

[GitHub] drill pull request: DRILL-4457: Difference in results returned by ...

GitHub user adeneche opened a pull request: https://github.com/apache/drill/pull/410 DRILL-4457: Difference in results returned by window function over BI… …GINT data You can merge this pull request into a Git repository by running: $ git pull https://github.com/adeneche/in

Re: Time for the 1.6 Release

Hi guys, I'm still waiting for the following to be reviewed/merged by today. DRILL-4437 (and others)/pr 394 (Operator unit test framework). Waiting to be merged (Jason) DRILL-4372/pr 377(?) (Drill Operators and Functions should correctly expose their types within Calcite.) - (Jinfeng to review)

[jira] [Resolved] (DRILL-4281) Drill should support inbound impersonation

[ https://issues.apache.org/jira/browse/DRILL-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudheesh Katkam resolved DRILL-4281. Resolution: Fixed > Drill should support inbound impersonation > ---

Re: Time for the 1.6 Release

If we still have time, I would like to include DRILL-4457 [1], it's a wrong results issue, I already have a fix and it's passing all tests, I am just waiting for a review [2] [1] https://issues.apache.org/jira/browse/DRILL-4457 [2] https://github.com/apache/drill/pull/410 On Mon, Mar 7, 2016 at

[GitHub] drill pull request: DRILL-4457: Difference in results returned by ...

Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/410#issuecomment-193362442 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] drill pull request: DRILL-4457: Difference in results returned by ...

Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/410#issuecomment-193363168 Thanks Jason --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

Re: Time for the 1.6 Release

Hakim, The patch looks good, I just gave you a +1. I will be merging the operator unit tests today, I would recommend checking it out for writing tests like this in future commits. - Jason On Mon, Mar 7, 2016 at 9:31 AM, Abdel Hakim Deneche wrote: > If we still have time, I would like to incl

[GitHub] drill pull request: DRILL-4332: Makes vector comparison order stab...

Github user jaltekruse commented on the pull request: https://github.com/apache/drill/pull/389#issuecomment-193372672 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

Re: Time for the 1.6 Release

DRILL-4477 is a really bad bug and should be fixed in 1.6 On Mon, Mar 7, 2016 at 9:40 AM, Jason Altekruse wrote: > Hakim, > > The patch looks good, I just gave you a +1. > > I will be merging the operator unit tests today, I would recommend checking > it out for writing tests like this in future

[GitHub] drill pull request: DRILL-4457: Difference in results returned by ...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/410 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Resolved] (DRILL-4457) Difference in results returned by window function over BIGINT data

[ https://issues.apache.org/jira/browse/DRILL-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deneche A. Hakim resolved DRILL-4457. - Resolution: Fixed Fixed in a2fec78695df979e240231cb9d32c7f18274a333 > Difference in resul

Re: Time for the 1.6 Release

Just merged DRILL-4457 into master. Thanks On Mon, Mar 7, 2016 at 7:44 PM, Vicky Markman wrote: > DRILL-4477 is a really bad bug and should be fixed in 1.6 > > On Mon, Mar 7, 2016 at 9:40 AM, Jason Altekruse > wrote: > > > Hakim, > > > > The patch looks good, I just gave you a +1. > > > > I wi

[GitHub] drill pull request: DRILL-4354: Remove sessions in anonymous (auth...

Github user vkorukanti closed the pull request at: https://github.com/apache/drill/pull/360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Re: Time for the 1.6 Release

Vicky, Per our discussion today, let us know if this issue also exists in 1.4. >From the discussion, it sounds like this is not a recent regression. -- Zelaine On Mon, Mar 7, 2016 at 10:44 AM, Vicky Markman wrote: > DRILL-4477 is a really bad bug and should be fixed in 1.6 > > On Mon, Mar 7, 2

Re: Time for the 1.6 Release

Hakim, Yes, we'll include this in the release. -- Zelaine On Mon, Mar 7, 2016 at 9:31 AM, Abdel Hakim Deneche wrote: > If we still have time, I would like to include DRILL-4457 [1], it's a wrong > results issue, I already have a fix and it's passing all tests, I am just > waiting for a review

Re: Time for the 1.6 Release

I don't know if there are any specific time constraints for getting out the release, but I'm inclined to go with Vicky on DRILL-4477, at least some investigation into the scope of a fix would be good. I think it's reasonably big problem whether it's a regression or not. On Mon, Mar 7, 2016 at 11:3