Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/463#issuecomment-206128408
apart from a small javadoc change, LGTM
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/463#discussion_r58653528
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/RemoteConnection.java ---
@@ -121,17 +115,72 @@ public void disable() {
}
}
Github user adeneche closed the pull request at:
https://github.com/apache/drill/pull/442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/460#issuecomment-206115245
+1, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58650141
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -354,17 +335,57 @@ public void success(QueryId queryId,
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/462#discussion_r58645138
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
---
@@ -169,4 +176,223 @@ private static boolean
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/462#issuecomment-206092089
@amansinha100, can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user jacques-n opened a pull request:
https://github.com/apache/drill/pull/466
DRILL-4576: Add PlannerCallback interface for additional planner
initialization.
DRILL-4576: Add PlannerCallback interface for additional planner
initialization.
- Allow a storage plugin
GitHub user ykrips opened a pull request:
https://github.com/apache/drill/pull/465
DRILL-4583: Test fails on TestNewDateFunctions#testIsDate
DRILL-4583: Test fails on TestNewDateFunctions#testIsDate
- changed constructor parameters of joda datetime
You can merge this pull
Jihun Kang created DRILL-4583:
-
Summary: Test fails on TestNewDateFunctions#testIsDate
Key: DRILL-4583
URL: https://issues.apache.org/jira/browse/DRILL-4583
Project: Apache Drill
Issue Type: Bug
GitHub user ykrips opened a pull request:
https://github.com/apache/drill/pull/464
DRILL-4582: TestCastFunctions#testToDateForTimeStamp returns error by
timezone difference
DRILL-4582: TestCastFunctions#testToDateForTimeStamp returns error by
timezone difference
- changed
Jihun Kang created DRILL-4582:
-
Summary: TestCastFunctions#testToDateForTimeStamp returns error by
timezone difference
Key: DRILL-4582
URL: https://issues.apache.org/jira/browse/DRILL-4582
Project:
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/403#issuecomment-206039007
This looks good to me. Let's get this merged. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58633147
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -133,6 +133,10 @@ private RpcChannel(int index, int value) {
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/442#issuecomment-206037954
I came up with an alternative approach as I mentioned above. Basically
moving coordination management to the RemoteConnection instead of handling at
the RpcBus level.
GitHub user jacques-n opened a pull request:
https://github.com/apache/drill/pull/463
DRILL-3714: Avoid cascading disconnection when a single connection is broken
DRILL-3714: Avoid cascading disconnection when a single connection is broken
- Move the coordination id
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58631424
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222 @@
+/**
+ *
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58631107
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222 @@
+/**
+ *
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/460#issuecomment-206027992
Addressed review comments.
+ Move new changes
+ Improve error and logging messages
---
If your project is set up for it, you can reply to this email
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58629471
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -133,6 +133,10 @@ private RpcChannel(int index, int value) {
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58629500
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222 @@
+/**
+ *
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58629311
--- Diff:
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
@@ -133,6 +133,10 @@ private RpcChannel(int index, int value) {
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58628326
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222 @@
+/**
+ *
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58625882
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222 @@
+/**
+ *
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58624266
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java
---
@@ -0,0 +1,222 @@
+/**
+ *
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58624118
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97 @@
+/**
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58624039
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97 @@
+/**
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58623875
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97 @@
+/**
Paul Rogers created DRILL-4581:
--
Summary: Various inconsistencies in the Drill startup scripts
Key: DRILL-4581
URL: https://issues.apache.org/jira/browse/DRILL-4581
Project: Apache Drill
Issue
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58623695
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97 @@
+/**
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58623402
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97 @@
+/**
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58623171
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97 @@
+/**
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/368#discussion_r58622650
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/ExchangeManipulatorMaterializerVisitor.java
---
@@ -0,0 +1,97 @@
+/**
Abhishek Girish created DRILL-4580:
--
Summary: Provide options to import and export storage plugin
configurations
Key: DRILL-4580
URL: https://issues.apache.org/jira/browse/DRILL-4580
Project: Apache
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/368#issuecomment-205994496
@yufeldman , sorry for the delay in reviewing. I will review the
parallelizer related enhancements (the new code since existing parallelizer is
not impacted) and
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/461#issuecomment-205991638
@hsuanyi , did you do some preliminary performance comparison, to measure
the performance gain, with bulk loading and skip get_partition() for hive table
when doing
Github user vkorukanti commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r58617109
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
@@ -72,4 +80,56 @@ public String
Github user vkorukanti commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r58616976
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java ---
@@ -194,4 +195,26 @@ public void dropTable(String tableName) {
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/461#discussion_r58616431
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java ---
@@ -194,4 +195,26 @@ public void dropTable(String tableName) {
No need for apologies John, today was pretty lively for discussion. These
are the notes I took.
---
community hangout 4/5/2016
---
Attendees: Jason, Arina, Vitalli, Stefan, Pawan, Parth, Jingeng, Sudheesh,
Aman
Pawan is new - might not have had a working mic, he
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58613516
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -278,49 +297,31 @@ public void
Github user jacques-n commented on a diff in the pull request:
https://github.com/apache/drill/pull/442#discussion_r58611408
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java ---
@@ -159,19 +159,15 @@ public ChannelClosedHandler(C clientConnection,
Channel
Sorry I missed this, anything exciting happen?
On Tue, Apr 5, 2016 at 11:57 AM, Jason Altekruse wrote:
> Anyone with an interest in Drill is welcome to attend to hear what is
> happening in the Drill community. Feel free to ask questions or just listen
> in.
>
>
Thanks for bringing this up. BI compatibility is super important.
The discussions here are primarily about internal implementation changes as
opposed to external API changes. From a BI perspective, I think (hope)
everyone shares the goal of having zero (to minimal) changes in terms of
ODBC and
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58595373
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -351,20 +352,5 @@ public void success(QueryId
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/445#issuecomment-205945078
+1
How did you test this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user vkorukanti opened a pull request:
https://github.com/apache/drill/pull/462
DRILL-4539: Add support for Null Equality Joins
@amansinha100 @jacques-n Could you please review the patches?
You can merge this pull request into a Git repository by running:
$ git pull
What I ended up doing is restart our Drill cluster.
The same query ran in 19 minutes, scanning the same amount of rows (~79
Billions)
So it looks like that after long period of up time and heavy usage, our
Drill cluster got into a certain state and become difficult to work with.
Until we find a
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58589485
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -351,20 +352,5 @@ public void success(QueryId queryId,
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58589199
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -189,20 +218,10 @@ private UserResultsListener
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58587852
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -351,20 +352,5 @@ public void success(QueryId
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58587275
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -278,49 +297,31 @@ public void
Bridget Bevens created DRILL-4579:
-
Summary: Drill Architecture Doc Updates
Key: DRILL-4579
URL: https://issues.apache.org/jira/browse/DRILL-4579
Project: Apache Drill
Issue Type: Bug
GitHub user hsuanyi opened a pull request:
https://github.com/apache/drill/pull/461
DRILL-4577: Construct a specific path for querying all the tables froâ¦
â¦m a hive database
@vkorukanti Can you help review? Thanks.
You can merge this pull request into a Git repository
Sorry for coming back to this thread late.
I have some feedback on the compatibility aspects of 2.0.
We are working with a variety of BI vendors to certify Drill and provide
native connectors for Drill. Having native access from BI tools helps with
seamless experience for the users with
Anyone with an interest in Drill is welcome to attend to hear what is
happening in the Drill community. Feel free to ask questions or just listen
in.
https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc
Jason Altekruse
Software Engineer at Dremio
Apache Drill Committer
I'm going to rescind my offer to be the 1.7 release manager and move it to
the 2.0 release.
The features I was going to shepherd into the release have now moved to the
v2 release. I'd like to focus all my time on helping get the v2 features
merged and at parity with the 1.x release line (per
I'm going to take this as lazy consensus. I'll create the branch.
Once created, all merges to the master (1.x branch) should also go to the
v2 branch unless we have a discussion here that they aren't applicable.
When committing, please make sure to commit to both locations.
thanks,
Jacques
--
Hi,
How much data you got from this query
create table ANALYSIS_RESULT as (
select Int32Field1 as SECONDS from hdfs.`/data/` where Int32Field2=123456
or Int32Field2=4567898);
As per your email you said single record.Also, in this query you used
Int32Field1 as Seconds whereas in the first query
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/445#discussion_r58505187
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -177,6 +182,13 @@ public void run() {
});
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/445#discussion_r58505168
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
@@ -177,6 +182,13 @@ public void run() {
});
Sudheesh, I think you are right. Whenever a query is started,
DrillOperatorTable
is created again.
This setting has been there for a long time. One "possible" explanation I
can think of is for query option. For example, if Decimal type is turned
on, the behavior of some functions/ operators could
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58491998
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -351,20 +352,5 @@ public void success(QueryId queryId,
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58491800
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -278,49 +297,31 @@ public void queryIdArrived(QueryId
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/460#discussion_r58491456
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
@@ -189,20 +218,10 @@ private UserResultsListener
65 matches
Mail list logo