[GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...

2016-04-06 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/463#discussion_r58821834 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java --- @@ -84,7 +115,7 @@ public void operationComplete(ChannelFuture future)

[GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...

2016-04-06 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/463#discussion_r58821796 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java --- @@ -20,51 +20,82 @@ import io.netty.buffer.ByteBuf; import

[GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...

2016-04-06 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/463#discussion_r58821789 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java --- @@ -20,51 +20,82 @@ import io.netty.buffer.ByteBuf; import

[GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...

2016-04-06 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/463#discussion_r58821752 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java --- @@ -20,51 +20,82 @@ import io.netty.buffer.ByteBuf; import

[GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-3743: Fail active listeners if server co...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-4588: Enable JMX reporting

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...

2016-04-06 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/463#discussion_r58806651 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java --- @@ -261,6 +251,7 @@ public void execute(Runnable command) {

[GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...

2016-04-06 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/463#discussion_r58806611 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java --- @@ -20,51 +20,82 @@ import io.netty.buffer.ByteBuf; import

[GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...

2016-04-06 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/463#discussion_r58806623 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java --- @@ -20,51 +20,82 @@ import io.netty.buffer.ByteBuf; import

[GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...

2016-04-06 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/463#discussion_r58806604 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java --- @@ -282,15 +283,19 @@ public void interrupted(final

[GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...

2016-04-06 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/463#discussion_r58806614 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java --- @@ -20,51 +20,82 @@ import io.netty.buffer.ByteBuf; import

[GitHub] drill pull request: DRILL-4588: Enable JMX reporting

2016-04-06 Thread parthchandra
Github user parthchandra commented on the pull request: https://github.com/apache/drill/pull/469#issuecomment-206624211 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4588: Enable JMX reporting

2016-04-06 Thread sudheeshkatkam
GitHub user sudheeshkatkam opened a pull request: https://github.com/apache/drill/pull/469 DRILL-4588: Enable JMX reporting @parthchandra please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sudheeshkatkam/drill

[GitHub] drill pull request: DRILL-4589: Reduce planning time for file syst...

2016-04-06 Thread jinfengni
Github user jinfengni commented on the pull request: https://github.com/apache/drill/pull/468#issuecomment-206611168 @amansinha100 , could you please review this PR? thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] drill pull request: DRILL-4589: Reduce planning time for file syst...

2016-04-06 Thread jinfengni
GitHub user jinfengni opened a pull request: https://github.com/apache/drill/pull/468 DRILL-4589: Reduce planning time for file system partition pruning by… … reducing filter evaluation overhead You can merge this pull request into a Git repository by running: $ git pull

Re: Including Drill and Hadoop jars in the same program

2016-04-06 Thread Laurent Goujon
I also believe Hadoop have some optional classloader to isolate hadoop internal classpath from application classpath, like that guy: https://hadoop.apache.org/docs/r2.7.2/api/org/apache/hadoop/util/ApplicationClassLoader.html Laurent On Wed, Apr 6, 2016 at 12:34 PM, Hanifi Gunes

[jira] [Created] (DRILL-4589) Reduce planning time for file system partition pruning by reducing filter evaluation overhead

2016-04-06 Thread Jinfeng Ni (JIRA)
Jinfeng Ni created DRILL-4589: - Summary: Reduce planning time for file system partition pruning by reducing filter evaluation overhead Key: DRILL-4589 URL: https://issues.apache.org/jira/browse/DRILL-4589

[jira] [Created] (DRILL-4588) Enable JMXReporter to Expose Metrics

2016-04-06 Thread Sudheesh Katkam (JIRA)
Sudheesh Katkam created DRILL-4588: -- Summary: Enable JMXReporter to Expose Metrics Key: DRILL-4588 URL: https://issues.apache.org/jira/browse/DRILL-4588 Project: Apache Drill Issue Type:

Re: [DISCUSS] Nonblocking RPC

2016-04-06 Thread Hanifi GUNES
I would like to see Drill making less use of blocking calls as well. Inlined: *- I was thinking of changing acceptExternalEvents to a boolean flag, and if not ready, resubmit cancellation and early termination requests as is to the executor, and not a two phase event. Wouldn't this be

Re: Including Drill and Hadoop jars in the same program

2016-04-06 Thread Hanifi Gunes
Shading might be an option here. Thanks. -Hanifi 1: https://maven.apache.org/plugins/maven-shade-plugin/ On Thu, Mar 31, 2016 at 6:04 PM, Paul Rogers wrote: > Hi All, > > Here’s an obscure question for the expert developers… > > We’re developing the YARN Application

[jira] [Created] (DRILL-4587) Document Drillbit launch options

2016-04-06 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-4587: -- Summary: Document Drillbit launch options Key: DRILL-4587 URL: https://issues.apache.org/jira/browse/DRILL-4587 Project: Apache Drill Issue Type: Improvement

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58761862 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -169,4 +176,223 @@ private static boolean

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58761755 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -169,4 +176,223 @@ private static boolean

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58759667 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java --- @@ -72,4 +80,76 @@ public String

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-06 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58758201 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java --- @@ -72,4 +80,76 @@ public String

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-06 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58758011 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java --- @@ -72,4 +80,76 @@ public String

[jira] [Created] (DRILL-4586) Create CLIENT ErrorType

2016-04-06 Thread Sudheesh Katkam (JIRA)
Sudheesh Katkam created DRILL-4586: -- Summary: Create CLIENT ErrorType Key: DRILL-4586 URL: https://issues.apache.org/jira/browse/DRILL-4586 Project: Apache Drill Issue Type: Improvement

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58757405 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java --- @@ -407,11 +342,94 @@ public void

[GitHub] drill pull request: DRILL-4132 Ability to submit simple type of ph...

2016-04-06 Thread yufeldman
Github user yufeldman commented on a diff in the pull request: https://github.com/apache/drill/pull/368#discussion_r58754414 --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java --- @@ -133,6 +133,10 @@ private RpcChannel(int index, int value) {

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58754467 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4132 Ability to submit simple type of ph...

2016-04-06 Thread yufeldman
Github user yufeldman commented on a diff in the pull request: https://github.com/apache/drill/pull/368#discussion_r58753681 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizerMultiPlans.java --- @@ -0,0 +1,222 @@ +/** + *

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58753568 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58753354 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java --- @@ -72,4 +80,76 @@ public String

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58751970 --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java --- @@ -215,6 +192,36 @@ public void eval() { } } +

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on the pull request: https://github.com/apache/drill/pull/466#issuecomment-206487918 Patch overall looks good to me (except maybe the abstract class vs interface stuff) --- If your project is set up for it, you can reply to this email and have your

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-06 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58751518 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java --- @@ -72,4 +80,56 @@ public String

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58751431 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58751332 --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java --- @@ -215,6 +192,36 @@ public void eval() { } }

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-06 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58750954 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java --- @@ -194,4 +195,26 @@ public void dropTable(String tableName) {

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58749059 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4576: Add PlannerCallback interface for ...

2016-04-06 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/466#discussion_r58749026 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58742916 --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java --- @@ -215,6 +192,36 @@ public void eval() { } } +

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58742546 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -169,4 +176,223 @@ private static boolean

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58741416 --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java --- @@ -215,6 +192,36 @@ public void eval() { } } +

[jira] [Created] (DRILL-4585) Add ability to view logs from all drillbits in Web UI

2016-04-06 Thread Arina Ielchiieva (JIRA)
Arina Ielchiieva created DRILL-4585: --- Summary: Add ability to view logs from all drillbits in Web UI Key: DRILL-4585 URL: https://issues.apache.org/jira/browse/DRILL-4585 Project: Apache Drill

[jira] [Created] (DRILL-4584) JDBC/ODBC Client IP in Drill audit logs

2016-04-06 Thread Vitalii Diravka (JIRA)
Vitalii Diravka created DRILL-4584: -- Summary: JDBC/ODBC Client IP in Drill audit logs Key: DRILL-4584 URL: https://issues.apache.org/jira/browse/DRILL-4584 Project: Apache Drill Issue Type:

Re: Proposal: Create v2 branch to work on breaking changes

2016-04-06 Thread Neeraja Rentachintala
Jacques can you elaborate on what you mean by 'internal' implementation changes but maintain external API. I thought that changes that are being discussed here are the Drill client library changes. What I am suggesting is that we need to maintain backward compatibility with a defined set of 1.x

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58730151 --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java --- @@ -215,6 +192,36 @@ public void eval() { } }

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58728331 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -169,4 +176,223 @@ private static boolean

[GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...

2016-04-06 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the pull request: https://github.com/apache/drill/pull/445#issuecomment-206378459 1. Updated host file so hostname points to the localhost address: a. started Drill in embedded mode -> started successfully. b. started drillbit in

[GitHub] drill pull request: DRILL-3894: Upgrade functions MaxDir, MinDir.....

2016-04-06 Thread vdiravka
GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/467 DRILL-3894: Upgrade functions MaxDir, MinDir... Optional filename parameter Functions MaxDir, MinDir, iMaxDir, iMinDir with one (schema) parameter were added. You can merge this pull request into

Re: is there a way to "clean" drill test framework datasources ?

2016-04-06 Thread Abhishek Girish
Hello Hakim, The Drill Test Framework packages a few large files and also downloads much larger files from Amazon S3 buckets. Most of these files within the framework resources directory are required for running tests (some are large baselines). However, to safely recover some space, you may

is there a way to "clean" drill test framework datasources ?

2016-04-06 Thread Abdel Hakim Deneche
Drill test framework is using 26GB of disk space after it uncompressed it's datasets. Running "bin/build_framework clean" doesn't seem to remove those files. Is there an easy way to clean those resources ? Thanks -- Abdelhakim Deneche Software Engineer Now