[GitHub] drill pull request: DRILL-4143: Fix inconsistency in writing metad...

Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/470#issuecomment-207904457 The code change is in the reading of the cache file but the commit message and JIRA descriptions indicates a permission issue when writing the metadata cache

[GitHub] drill pull request: DRILL-4589: Reduce planning time for file syst...

Github user hsuanyi commented on the pull request: https://github.com/apache/drill/pull/468#issuecomment-207904379 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SU...

Github user hsuanyi commented on the pull request: https://github.com/apache/drill/pull/458#issuecomment-207904016 And can you share the details regarding the performance improvement? For example, how the setting and data look like? Observed % of improvements? --- If your project is

Re: Jira DRILL-4573

I took a look and add some comments. Can you respond on the PR? On Fri, Apr 8, 2016 at 4:41 AM, Jean-Claude Cote wrote: > Hi, > > I've created a pull request for issue DRILL-4573. I'm wondering if it's in > the queue of pull request to be reviewed? > > Thanks > Jean-Claude >

[GitHub] drill pull request: DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SU...

Github user hsuanyi commented on the pull request: https://github.com/apache/drill/pull/458#issuecomment-207903918 Except for the comments, LGTM. Do you run the unit test ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] drill pull request: DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SU...

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/458#discussion_r59125828 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java --- @@ -0,0 +1,49 @@ +/** + * Licensed to the

[GitHub] drill pull request: DRILL-4573: Zero copy LIKE, REGEXP_MATCHES, SU...

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/458#discussion_r59125807 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java --- @@ -0,0 +1,49 @@ +/** + * Licensed to the

[GitHub] drill pull request: DRILL-4199: Add Support for HBase 1.X

Github user adityakishore commented on a diff in the pull request: https://github.com/apache/drill/pull/443#discussion_r59120474 --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java --- @@ -19,36 +19,75 @@ import