[
https://issues.apache.org/jira/browse/DRILL-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sudheesh Katkam resolved DRILL-4654.
Resolution: Fixed
Fixed in
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/458#issuecomment-219858967
@jcmcote ,
(copy from my comment in DRILL-4573)
I re-visited your first patch. Looks like that the change you made would
cause incorrect result when
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/481#discussion_r63602468
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
---
@@ -1280,6 +1280,43 @@ public void eval() {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/495#discussion_r63597486
--- Diff:
common/src/main/java/org/apache/drill/exec/util/SystemPropertyUtil.java ---
@@ -0,0 +1,189 @@
+/**
+ * Licensed to the Apache
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/495#discussion_r63593914
--- Diff:
common/src/main/java/org/apache/drill/exec/util/SystemPropertyUtil.java ---
@@ -0,0 +1,189 @@
+/**
+ * Licensed to the Apache
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/503#discussion_r63577241
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -1191,7 +1195,7 @@ public void failed(final RpcException
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/503#discussion_r63578261
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -1206,42 +1210,18 @@ public void interrupted(final
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/503#discussion_r63577164
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -869,44 +861,44 @@ protected void processEvent(final StateEvent
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/503#discussion_r63576357
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -1191,7 +1195,7 @@ public void failed(final RpcException ex) {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/503#discussion_r63574135
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -1191,7 +1195,7 @@ public void failed(final RpcException
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/503#discussion_r63573819
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -163,7 +161,7 @@ public Foreman(final WorkerBee bee,
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/503#discussion_r63573505
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -1206,42 +1210,18 @@ public void interrupted(final
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/503#issuecomment-219803152
+1 (some minor comments)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Attendees: Hakim, Parth, Paul, Jinfeng, Aman, Neeraja, Andries, Vitalii,
John O, Wojtek, Khurram, Gautam, Jeff Downton
1) Andries noted that BI tool vendors are hitting DRILL-3510 and
DRILL-4682 in the SQL dialect they're generating. I'll have folks on the
MapR end look into fixing these.
2)
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/503#discussion_r63573488
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java ---
@@ -869,44 +861,44 @@ protected void processEvent(final
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/503#issuecomment-219794472
addressed Sudheesh comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Starting in a minute
https://plus.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc
On Tue, May 17, 2016 at 9:59 AM, John Omernik wrote:
> Is there link today?
>
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/495#issuecomment-219757831
Some minor comments, otherwise +1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/495#discussion_r63546312
--- Diff:
common/src/main/java/org/apache/drill/exec/util/SystemPropertyUtil.java ---
@@ -0,0 +1,189 @@
+/**
+ * Licensed to the Apache Software
Github user adeneche commented on a diff in the pull request:
https://github.com/apache/drill/pull/495#discussion_r63544498
--- Diff:
common/src/main/java/org/apache/drill/exec/util/SystemPropertyUtil.java ---
@@ -0,0 +1,189 @@
+/**
+ * Licensed to the Apache Software
Andries Engelbrecht created DRILL-4682:
--
Summary: Allow full schema identifier in SELECT clause
Key: DRILL-4682
URL: https://issues.apache.org/jira/browse/DRILL-4682
Project: Apache Drill
22 matches
Mail list logo