[GitHub] drill issue #512: Drill 4573 fix issue with unicode chars

2016-06-13 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/512 @jcmcote , Overall the patch looks good to me. Once you revise the code, I'll run the regression and merge the code if no problem is found. Thanks for your patch! --- If your project is

[GitHub] drill pull request #512: Drill 4573 fix issue with unicode chars

2016-06-13 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/512#discussion_r66894981 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java --- @@ -114,6 +114,19 @@ public void testRegexpMatches()

[GitHub] drill pull request #512: Drill 4573 fix issue with unicode chars

2016-06-13 Thread jinfengni
Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/512#discussion_r66894665 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CharSequenceWrapper.java --- @@ -17,13 +17,52 @@ */ package

[GitHub] drill issue #511: DRILL-4701: Fix log name and missing lines in logs on Web ...

2016-06-13 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/511 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] drill issue #500: DRILL-3149: TextReader should support multibyte line delim...

2016-06-13 Thread parthchandra
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/500 Looks Good. Can you add another test case where a field contains a some of the initial bytes of the multibyte line delimiter. --- If your project is set up for it, you can reply to this email

[jira] [Created] (DRILL-4721) Doc "dateDiff" in Drill

2016-06-13 Thread Bridget Bevens (JIRA)
Bridget Bevens created DRILL-4721: - Summary: Doc "dateDiff" in Drill Key: DRILL-4721 URL: https://issues.apache.org/jira/browse/DRILL-4721 Project: Apache Drill Issue Type: Task

Re: Suggestions for hangout topics for 06/14

2016-06-13 Thread AnilKumar B
Hi Aman, I will just check with Yash and If he is not working on it, then I will start looking into https://issues.apache.org/jira/browse/DRILL-92 Thanks & Regards, B Anil Kumar. On Mon, Jun 13, 2016 at 4:05 PM, Aman Sinha wrote: > Sounds good Jason. > > On Mon, Jun 13,

Re: Suggestions for hangout topics for 06/14

2016-06-13 Thread Aman Sinha
Sounds good Jason. On Mon, Jun 13, 2016 at 1:47 PM, Jason Altekruse wrote: > I would be interested in showing the operator unit test system I checked in > a little while back, I think transitioning to using these more targeted > tests could improve coverage and speed up the

[jira] [Created] (DRILL-4720) MINDIR() and IMINDIR() functions return no results with metadata cache

2016-06-13 Thread Krystal (JIRA)
Krystal created DRILL-4720: -- Summary: MINDIR() and IMINDIR() functions return no results with metadata cache Key: DRILL-4720 URL: https://issues.apache.org/jira/browse/DRILL-4720 Project: Apache Drill

Re: Suggestions for hangout topics for 06/14

2016-06-13 Thread Aman Sinha
Hi Anil, if you are referring to DRILL-92 ( https://issues.apache.org/jira/browse/DRILL-92) we could discuss if someone wants to pick up where it left off...it looks like no activity has happened on it for a while. On Mon, Jun 13, 2016 at 9:54 AM, AnilKumar B wrote: > Hi

[GitHub] drill pull request #:

2016-06-13 Thread adityakishore
Github user adityakishore commented on the pull request: https://github.com/apache/drill/commit/323849e48fed967d43108e5cf85ba150a50f073e#commitcomment-17847479 In contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePluginConfig.java: In

Re: Suggestions for hangout topics for 06/14

2016-06-13 Thread AnilKumar B
Hi Aman, Shall we consider cassandra plugin discussion? As most of the users are interested in it. Seems most of the work is already done, but seems final review comments are pending on it. Thanks & Regards, B Anil Kumar. On Mon, Jun 13, 2016 at 11:00 AM, Aman Sinha

Suggestions for hangout topics for 06/14

2016-06-13 Thread Aman Sinha
If you have any suggestions for Drill hangout topics for tomorrow, you can add it to this thread. We will also ask around at the beginning of the hangout for any topics. The goal is to try to cover whatever possible during the 1 hr. Couple of pending topics: 1. (leftover from last time)

[GitHub] drill pull request #:

2016-06-13 Thread jacques-n
Github user jacques-n commented on the pull request: https://github.com/apache/drill/commit/323849e48fed967d43108e5cf85ba150a50f073e#commitcomment-17843683 In contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePluginConfig.java: In

[jira] [Created] (DRILL-4718) call to ResultSet.getObject(int columnIndex) results in InvalidCursorStateSqlException

2016-06-13 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-4718: - Summary: call to ResultSet.getObject(int columnIndex) results in InvalidCursorStateSqlException Key: DRILL-4718 URL: https://issues.apache.org/jira/browse/DRILL-4718

[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

2016-06-13 Thread vdiravka
GitHub user vdiravka opened a pull request: https://github.com/apache/drill/pull/520 DRILL-3510: Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL identifiers - added calcite's Lex.MYSQL_ANSI (double quote) supporting for SQL identifiers; - replaced

[GitHub] drill issue #443: DRILL-4199: Add Support for HBase 1.X

2016-06-13 Thread adityakishore
Github user adityakishore commented on the issue: https://github.com/apache/drill/pull/443 The latest patch, 323849e48fed967d43108e5cf85ba150a50f073e, moves the GuavaPatcher class to java-exec module and run the GuavaPatcher at Drillbit start (before the Stopwatch class is loaded