Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70379773
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java
---
@@ -0,0 +1,129 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70379333
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java
---
@@ -0,0 +1,129 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70379318
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java
---
@@ -0,0 +1,129 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70378389
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DescribeSchemaHandler.java
---
@@ -0,0 +1,129 @@
+/**
+ * Licensed
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/436#discussion_r70377349
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestInfoSchema.java ---
@@ -351,4 +359,51 @@ public void showFilesWithDefaultSchema() throws
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/526#discussion_r70370300
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestPartitionFilter.java ---
@@ -362,4 +362,13 @@ public void testLogicalDirPruning2() throws Exception
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/543#discussion_r70361935
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java
---
@@ -209,8 +213,10 @@ private DrillHiveM
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/543#discussion_r70360847
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java
---
@@ -209,8 +213,10 @@ private DrillHiveM
Github user vkorukanti commented on a diff in the pull request:
https://github.com/apache/drill/pull/543#discussion_r70358080
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java
---
@@ -209,8 +213,10 @@ private DrillHive
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/543
Revise the patch based on @vkorukanti 's comments.
Pls let me know if you have any further comment. Otherwise, I'll run
regression and merge the patch. Thanks.
---
If your project
Github user julianhyde commented on the issue:
https://github.com/apache/drill/pull/541
The method in the parser and the class should both be called `DropTable`.
`ifExists` should just be a boolean field.
At some point you might want to add an `OR REPLACE` clause to `CREATE
V
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/541
I agree; I was confused with the [command
definition](https://github.com/apache/drill/pull/541/commits/efbd0df49a6f998900aa9ac0755e1775e1b1bff5#diff-f4825f92440b9aa467d135f04498f406R260)
in the
Github user julianhyde commented on the issue:
https://github.com/apache/drill/pull/541
Why rename DropTable to DropTableIfExists? It's still the DROP TABLE
command.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70342391
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableIfExistsHandler.java
---
@@ -28,47 +30,57 @@
import org
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70342372
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
---
@@ -106,36 +106,43 @@ public PhysicalPlan getPla
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/542
Commiters asked that DoY not be pushed at this time. Closing this request;
will open a new one with only the Drill changes, but no DoY scripts.
---
If your project is set up for it, you can reply
Github user paul-rogers closed the pull request at:
https://github.com/apache/drill/pull/542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70340564
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableIfExistsHandler.java
---
@@ -28,47 +30,57 @@
import org
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/543
@vkorukanti , thanks for pointing the place it might leaking. I'll revise
the patch.
Agree with @sudheeshkatkam that HiveStoragePlugin may leak connection (I
saw Drill leaked a connection,
While opening a new drill jira, I observed that the drop down for "Affects
Version" has "1.7.0" under the unreleased versions section. Did we forget
anything during 1.7 release :)
- Rahul
Sudheesh Katkam created DRILL-4774:
--
Summary: Replace NonCloseableHiveClientWithCaching
Key: DRILL-4774
URL: https://issues.apache.org/jira/browse/DRILL-4774
Project: Apache Drill
Issue Type
Sudheesh Katkam created DRILL-4773:
--
Summary: Close all HiveMetaStoreClients when HiveStoragePlugin is
closed
Key: DRILL-4773
URL: https://issues.apache.org/jira/browse/DRILL-4773
Project: Apache Dri
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/543
Yes, we leak connections. There is a fix in Hive for [closing before
reconnecting](https://github.com/apache/hive/commit/8fb805225c9d6960c7d39d862de6b3326650551c),
but that is in a later versio
Github user vkorukanti commented on the issue:
https://github.com/apache/drill/pull/543
Change seems reasonable to me. One thing: is the reconnect() call not
closing the existing connection? If yes why are we leaking the connections?
I think there is one more place we need to
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/534#discussion_r70316280
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
---
@@ -81,6 +81,11 @@
new RangeLongValidat
Rahul Challapalli created DRILL-4772:
Summary: Corrections required for the "Supported Data Types"
documentation page
Key: DRILL-4772
URL: https://issues.apache.org/jira/browse/DRILL-4772
Project:
Please complete review of DRILL-4704:
https://github.com/apache/drill/pull/517
Thanks,
Dave Oshinsky
-Original Message-
From: Jinfeng Ni [mailto:j...@apache.org]
Sent: Monday, July 11, 2016 11:49 AM
To: dev; user
Subject: Drill Hangout Topics for 07/12/2016
Hey,
Just a reminder that we
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/518
@chunhui-shi , I saw you made comments days ago. Can you pls take a look at
the new patch to see if it addressed your comment? thx.
---
If your project is set up for it, you can reply to thi
Can drill-4653 be reviewed?
On Mon, Jul 11, 2016 at 8:49 AM, Jinfeng Ni wrote:
> Hey,
>
> Just a reminder that we will have Drill hangout at 10am-11am, 07/12/16 PST.
>
> If you have any topics to discuss on tomorrow's hangout, please reply
> this thread and list the topics you want to discuss. I
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/543
@sudheeshkatkam and @vkorukanti , can one of you review this PR? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
GitHub user jinfengni opened a pull request:
https://github.com/apache/drill/pull/543
DRILL-4768: Fix leaking hive meta store connection in Drill's hive meâ¦
â¦tastore client call.
do not call reconnect if the connection is still alive and the error is
caused by either Un
Hey,
Just a reminder that we will have Drill hangout at 10am-11am, 07/12/16 PST.
If you have any topics to discuss on tomorrow's hangout, please reply
this thread and list the topics you want to discuss. I'll also collect
topics at the beginning of the hangout.
Thank you,
Jinfeng
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/436
@jinfengni, agree. Added schema in the output and updated PR comment with
example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user vdiravka commented on the issue:
https://github.com/apache/drill/pull/541
@sudheeshkatkam @parthchandra
I resolved the issue with binary representation of two files.
The patch is updated. Please check.
---
If your project is set up for it, you can reply to this e
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70230071
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java ---
@@ -591,4 +591,27 @@ public void
showProperMsgWhenTryingToDropANonV
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70230053
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestDropTable.java
---
@@ -171,4 +175,45 @@ public void testDropOnImmutableSchema() throws
Exception
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/541#discussion_r70229922
--- Diff: exec/java-exec/src/test/java/org/apache/drill/TestDropTable.java
---
@@ -19,14 +19,18 @@
import org.apache.drill.common.exceptions.UserEx
37 matches
Mail list logo
