[GitHub] drill issue #583: DRILL-4877: If pruning was not applicable only keep the se...

2016-09-08 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/583 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] drill issue #583: DRILL-4877: If pruning was not applicable only keep the se...

2016-09-08 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/583 @jinfengni could you pls review ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] drill pull request #583: DRILL-4877: If pruning was not applicable only keep...

2016-09-08 Thread amansinha100
GitHub user amansinha100 opened a pull request: https://github.com/apache/drill/pull/583 DRILL-4877: If pruning was not applicable only keep the selectionRoot… … in the entries field. You can merge this pull request into a Git repository by running: $ git pull https://gith

Question on input file parsing

2016-09-08 Thread Subbu Srinivasan
Folks, What is the general thoughts of the team on how DRILL parses input data? Is the philosophy that the input is typically delimited (Eg: new line in case of JSON data) or should we remain agnostic and let the underlying parser implementation interpret start of the next input record ? Is it val

Re: [DISCUSS] - Design Docs

2016-09-08 Thread Paul Rogers
I like the template. The key contribution of the template is to remind us of the topics and suggest a default document structure with which to start. It will turn out that each project will need to make adjustments (topic A expands into multiple sections, say, topics B and C are trivial and coll

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78038409 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -218,4 +302,141 @@ private void registerOpera

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78031041 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -218,4 +302,141 @@ private void registerOpera

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78030875 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -64,62 +76,134 @@ .put("CONVERT_FRO

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78030815 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -64,62 +76,134 @@ .put("CONVERT_FRO

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78028875 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestDynamicUDFSupport.java --- @@ -0,0 +1,292 @@ +/** + * Licensed to the Apache Software F

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78027749 --- Diff: common/src/main/java/org/apache/drill/common/config/DrillConfig.java --- @@ -164,6 +164,15 @@ public static DrillConfig create(String overr

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78018512 --- Diff: common/src/main/java/org/apache/drill/common/scanner/RunTimeScan.java --- @@ -75,4 +77,20 @@ public static ScanResult fromPrescan(DrillConfi

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78017223 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java --- @@ -64,6 +64,15 @@ public DrillOperatorTable(Fun

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78015486 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionInitializer.java --- @@ -42,22 +42,29 @@ public class FunctionIniti

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78014300 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -186,4 +226,105 @@ public boolean isF

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78012385 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -186,4 +226,105 @@ public boolean isF

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78011083 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -186,4 +226,105 @@ public boolean isF

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78009045 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -186,4 +226,105 @@ public boolean isF

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78008586 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java --- @@ -86,6 +108,7 @@ public FunctionImplem

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r78007166 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -64,62 +76,134 @@ .put("CONVERT_FRO

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r77977654 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillSimpleFuncHolder.java --- @@ -40,10 +40,12 @@ static final org.slf4j

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r77977432 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -218,4 +302,141 @@ private void registerOpera

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r77976915 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -64,62 +76,134 @@ .put("CONVERT_FRO

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r77976736 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/exception/FunctionValidationException.java --- @@ -0,0 +1,43 @@ +/** + * License

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r7797 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/JarUtil.java --- @@ -0,0 +1,33 @@ +/** + * Licensed to the Apache Software F

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r77974864 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/JarUtil.java --- @@ -0,0 +1,33 @@ +/** + * Licensed to the Apache Software F

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r77974471 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZookeeperClient.java --- @@ -179,6 +220,22 @@ public void create(final String p

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r77972898 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/ZookeeperPersistentStore.java --- @@ -63,7 +63,18 @@ public PersistentSt

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r77967306 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZookeeperClient.java --- @@ -133,13 +137,50 @@ public boolean hasPath(final Str

[GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support

2016-09-08 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/574#discussion_r77966607 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/exception/VersionMismatchException.java --- @@ -0,0 +1,45 @@ +/** + * Licensed t