[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-10-25 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r85036776 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanType.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Softwar

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-10-25 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r85036858 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanType.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Softwar

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-10-25 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r85038037 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestSimpleCastFunctions.java --- @@ -18,18 +18,108 @@ package org.apache.drill.exec.sql;

[GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...

2016-10-25 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r85036792 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanType.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Softwar

[GitHub] drill issue #628: DRILL-4964: Drill fails to connect to hive metastore after...

2016-10-25 Thread sohami
Github user sohami commented on the issue: https://github.com/apache/drill/pull/628 @jinfengni - Can you please help to review ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request #628: DRILL-4964: Drill fails to connect to hive metastor...

2016-10-25 Thread sohami
GitHub user sohami reopened a pull request: https://github.com/apache/drill/pull/628 DRILL-4964: Drill fails to connect to hive metastore after hive metas… …tore is restarted unless drillbits are restarted also Changes: For certain methods in DrillHiveMetaSto

[GitHub] drill pull request #628: DRILL-4964: Drill fails to connect to hive metastor...

2016-10-25 Thread sohami
Github user sohami closed the pull request at: https://github.com/apache/drill/pull/628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] drill pull request #628: DRILL-4964: Drill fails to connect to hive metastor...

2016-10-25 Thread sohami
GitHub user sohami opened a pull request: https://github.com/apache/drill/pull/628 DRILL-4964: Drill fails to connect to hive metastore after hive metas… …tore is restarted unless drillbits are restarted also Changes: For certain methods in DrillHiveMetaStore

[jira] [Created] (DRILL-4965) query snappy data of hive

2016-10-25 Thread rainday (JIRA)
rainday created DRILL-4965: -- Summary: query snappy data of hive Key: DRILL-4965 URL: https://issues.apache.org/jira/browse/DRILL-4965 Project: Apache Drill Issue Type: Improvement Componen

[jira] [Created] (DRILL-4964) Drill fails to connect to hive metastore after hive metastore is restarted unless drillbits are restarted also

2016-10-25 Thread Sorabh Hamirwasia (JIRA)
Sorabh Hamirwasia created DRILL-4964: Summary: Drill fails to connect to hive metastore after hive metastore is restarted unless drillbits are restarted also Key: DRILL-4964 URL: https://issues.apache.org/jira

[GitHub] drill issue #584: DRILL-4884: Fix bug that drill sometimes produced IOB exce...

2016-10-25 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/584 The fix looks fine to me. But do you plan to add a unit test case? thx. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] drill issue #602: Improve Drill C++ connector

2016-10-25 Thread laurentgo
Github user laurentgo commented on the issue: https://github.com/apache/drill/pull/602 Just uploaded a new version of the branch @parthchandra: on windows, I'm using PowerShell to extract the project information from the pom.xml instead of a call to maven (which I assume is p

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r84975052 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats() { @GE

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r84973496 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats() { @GE

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r84970266 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -207,6 +210,21 @@ private void javaPropertiesToSystemOptions()

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r84972014 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats() { @GE

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r84975543 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats() { @GE

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r84976814 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -207,6 +210,21 @@ private void javaPropertiesToSystemOptions()

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r84973313 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats() { @GE

[GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r84969332 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -17,6 +17,7 @@ */ package org.apache.drill.exec;

Re: isDateCorrect field in ParquetTableMetadata

2016-10-25 Thread Jinfeng Ni
I'm not sure if I fully understand your answers. The bottom line is quite simple: given a set of parquet files, the ParquetTableMeta instance constructed in Drill should have identical value for "isDateCorrect", whether it comes from parquet footer, or parquet metadata cache, or whether there is pa

Re: isDateCorrect field in ParquetTableMetadata

2016-10-25 Thread Paul Rogers
Would it make sense to write the Drill version into the Parquet metadata, and decide on date format based on the Drill version? This works if Drill versions after, say, 1.9 has the “correct” format and anything with an earlier version has “incorrect” dates. This is the typical way that folks han

[GitHub] drill pull request #592: DRILL-4826: Query against INFORMATION_SCHEMA.TABLES...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/592#discussion_r84967719 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java --- @@ -233,6 +236,30 @@ private Drill

Re: isDateCorrect field in ParquetTableMetadata

2016-10-25 Thread Vitalii Diravka
Hi Jinfeng, 1.If the parquet files are generated with Drill after Drill-4203 these files have "isDateCorrect = true" property. Drill serializes this property from metadata now. When we set this property in the first constructor we will hide the value from metadata. IsDateCorrect will be false only

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/551#discussion_r84965675 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -107,6 +107,42 @@ FOREMAN: ${model.getProfile().getForeman().getAddres

[GitHub] drill pull request #551: DRILL-4792: Include session options used for a quer...

2016-10-25 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/551#discussion_r84965750 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -107,6 +107,42 @@ FOREMAN: ${model.getProfile().getForeman().getAddres

[jira] [Created] (DRILL-4963) Issues when overloading Drill native functions with dynamic UDFs

2016-10-25 Thread Roman (JIRA)
Roman created DRILL-4963: Summary: Issues when overloading Drill native functions with dynamic UDFs Key: DRILL-4963 URL: https://issues.apache.org/jira/browse/DRILL-4963 Project: Apache Drill Issue

[jira] [Created] (DRILL-4962) Drill registers UDFs from packages which were not included in drill-module.conf

2016-10-25 Thread Roman (JIRA)
Roman created DRILL-4962: Summary: Drill registers UDFs from packages which were not included in drill-module.conf Key: DRILL-4962 URL: https://issues.apache.org/jira/browse/DRILL-4962 Project: Apache Drill

Re: isDateCorrect field in ParquetTableMetadata

2016-10-25 Thread Jinfeng Ni
Forgot to copy the link to the code. [1] https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java#L950-L955 On Tue, Oct 25, 2016 at 9:16 AM, Jinfeng Ni wrote: > @Jason, @Vitalli, > > Any thoughts on this question, since both you

Re: isDateCorrect field in ParquetTableMetadata

2016-10-25 Thread Jinfeng Ni
@Jason, @Vitalli, Any thoughts on this question, since both you worked on fix of DRILL-4203? Looking through the code, there is a third case [1], where this flag is set to false when Parquet metadata is cloned (after partition pruning, etc). That means, for the 2nd case where the flag is set to