Vitalii Diravka created DRILL-5097:
--
Summary: Need to change the default width of the timestamp vector
Key: DRILL-5097
URL: https://issues.apache.org/jira/browse/DRILL-5097
Project: Apache Drill
Github user zfong commented on the issue:
https://github.com/apache/drill/pull/675
Looks good to me. +1 (non-binding)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Hello Nitin,
It's definitely possible to support offsets other than 1 for Lead and Lag,
the main reason I didn't do it is just lack of time :P
Things that need to be done to make Lag (or Lead) support offsets other
than 1:
- WindowFunction.Lead should extract the offset value from its FunctionCal
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/674
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/673
@parthchandra, I have made some changes and added few test values. Could
you please review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/675#discussion_r90688989
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/AssignmentCreator.java
---
@@ -50,7 +50,8 @@
private static Comparator> c
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90688304
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/RemoteFunctionRegistry.java
---
@@ -189,6 +188,7 @@ private void prepareStor
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90687564
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -170,7 +170,17 @@ drill.exec: {
threadpool_size: 8,
decode_threadp
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90689224
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -45,11 +45,13 @@ drill.client: {
supports-complex-types: true
}
-
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90687630
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -170,7 +170,17 @@ drill.exec: {
threadpool_size: 8,
decode_threadp
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/672#discussion_r90688097
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
@@ -377,14 +374,12 @@ private ScanResult scan
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/675#discussion_r90690712
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/AssignmentCreator.java
---
@@ -50,7 +50,8 @@
private static Comparator> c
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/673#discussion_r90694144
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java
---
@@ -56,6 +58,31 @@ p
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/673#discussion_r90694935
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java
---
@@ -56,6 +58,31 @@ p
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/638
Addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/659
+1 based on @laurentgo 's review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/676
Drill 5091: JDBC unit test fails to set up test storage plugin config on
Java 8
Two parts: hygiene and the bug fixes.
Hygiene just cleans up nuisance compiler warnings seen in Eclipse.
Github user amansinha100 commented on the issue:
https://github.com/apache/drill/pull/675
Seems like some of the review spilled over to the JIRA. @chunhui-shi and
@laurentgo , did you come to an agreement ? :) I am fine with either
way..this is a small change.
---
If your proj
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/660
Revised title to include correct JIRA title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/638
LGTM too. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Sorabh Hamirwasia created DRILL-5098:
Summary: Improving fault tolerance for connection between client
and foreman node.
Key: DRILL-5098
URL: https://issues.apache.org/jira/browse/DRILL-5098
Proje
21 matches
Mail list logo
