Github user paul-rogers closed the pull request at:
https://github.com/apache/drill/pull/684
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/684
Closing pull request since we don't want to have golden copies of generated
code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/665
Used a generated serial id for UserException (even though it is never
serialized.) Remove the code cleanup. Changed code to use a string builder.
---
If your project is set up for it, you can rep
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r91826699
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -115,6 +118,7 @@ public UserSession build() {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r91823124
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -357,10 +357,54 @@ protected void afterExecute(final Runnabl
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r91821466
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/ConnectTriesPropertyTestClusterBits.java
---
@@ -0,0 +1,244 @@
+/**
+ * Licensed to
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r91820952
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -357,10 +357,54 @@ protected void afterExecute(final Runnable r, fin
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r91822093
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcConnectTriesTestEmbeddedBits.java
---
@@ -0,0 +1,162 @@
+/**
+ * Licensed to the Apach
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/665#discussion_r91820261
--- Diff:
common/src/main/java/org/apache/drill/common/exceptions/UserException.java ---
@@ -549,7 +550,12 @@ public UserException build(final Logger lo
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/665#discussion_r91820335
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/fragment/FragmentExecutor.java
---
@@ -224,6 +224,7 @@ public void run() {
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/665#discussion_r91820210
--- Diff:
common/src/main/java/org/apache/drill/common/exceptions/UserException.java ---
@@ -549,7 +550,12 @@ public UserException build(final Logger lo
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/681
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/680
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/669
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Karthikeyan Manivannan created DRILL-5121:
-
Summary: A memory leak is observed when exact case is not
specified for a column in a filter condition
Key: DRILL-5121
URL: https://issues.apache.org/jira/browse
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/676
Opened DRILL-5120 for the JDBC Driver update for JDBC 4.2. Added TODOs as
requested. Squashed commits to simplify commit to master.
---
If your project is set up for it, you can reply to this ema
Paul Rogers created DRILL-5120:
--
Summary: Upgrade JDBC Driver for new Java 8 methods
Key: DRILL-5120
URL: https://issues.apache.org/jira/browse/DRILL-5120
Project: Apache Drill
Issue Type: Bug
Github user adityakishore commented on the issue:
https://github.com/apache/drill/pull/688
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user spanchamiamapr commented on the issue:
https://github.com/apache/drill/pull/688
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/680
The non-verbose output is, indeed, blank. The value of the plugin seems to
be that it creates Maven variables that can be used elsewhere in the POM for
various purposes. Dumping to console is an "
Github user Agirish commented on the issue:
https://github.com/apache/drill/pull/688
@spanchamiamapr, @adityakishore can one of you please review this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user Agirish commented on the issue:
https://github.com/apache/drill/pull/688
+1 (non-binding). Thanks for making the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
GitHub user pwong-mapr opened a pull request:
https://github.com/apache/drill/pull/688
DRILL-5119 - Update MapR version to 5.2.0.40963-mapr
Change for https://issues.apache.org/jira/browse/DRILL-5119
You can merge this pull request into a Git repository by running:
$ git pull h
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/687
DRILL-4996: Parquet Date auto-correction is not working in auto-partiâ¦
â¦tioned parquet files generated by drill-1.6
- Changed detection approach of corrupted date values for the case, wh
Abhishek Girish created DRILL-5119:
--
Summary: Update MapR version to 5.2.0.40963-mapr
Key: DRILL-5119
URL: https://issues.apache.org/jira/browse/DRILL-5119
Project: Apache Drill
Issue Type:
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/657
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/672
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/676
+1, pending minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/676#discussion_r91797180
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/Drill2489CallsAfterCloseThrowExceptionsTest.java
---
@@ -477,18 +468,32 @@ public void tes
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r91768005
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -357,10 +357,54 @@ protected void afterExecute(final Runnabl
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r91795818
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/ConnectTriesPropertyTestClusterBits.java
---
@@ -0,0 +1,244 @@
+/**
+ * Lic
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r91796042
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcConnectTriesTestEmbeddedBits.java
---
@@ -0,0 +1,162 @@
+/**
+ * Licensed to t
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/680
What does the non verbose message look like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/682
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user Serhii-Harnyk commented on a diff in the pull request:
https://github.com/apache/drill/pull/673#discussion_r91753304
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetFixedWidthDictionaryReaders.java
---
@@ -56,6 +58,31 @@
Github user Serhii-Harnyk commented on the issue:
https://github.com/apache/drill/pull/594
@chunhui-shi, could you please review new changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
GitHub user Serhii-Harnyk opened a pull request:
https://github.com/apache/drill/pull/686
DRILL-5117: Compile error when query a json file with 1000+columns
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Serhii-Harnyk/drill DRIL
Gopal Nagar created DRILL-5118:
--
Summary: Select Query Limit is not working in Drill 1.8
Key: DRILL-5118
URL: https://issues.apache.org/jira/browse/DRILL-5118
Project: Apache Drill
Issue Type: B
Serhii Harnyk created DRILL-5117:
Summary: Compile error when query a json file with 1000+columns
Key: DRILL-5117
URL: https://issues.apache.org/jira/browse/DRILL-5117
Project: Apache Drill
I
Github user nagarajanchinnasamy commented on the issue:
https://github.com/apache/drill/pull/685
@paul-rogers as per my requirement the SessionId needs to be unique. Thats
all. It does not have to be a monotonically increasing sequence. So, UUID
should be fine. Will look into #666
Github user nagarajanchinnasamy commented on a diff in the pull request:
https://github.com/apache/drill/pull/685#discussion_r91685705
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java ---
@@ -115,6 +118,7 @@ public UserSession build() {
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/660
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/660#discussion_r91679324
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java ---
@@ -246,6 +246,12 @@ public void rotateBlock() {
ro
43 matches
Mail list logo
