[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99017885 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321 @@ +/* + *

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99039654 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/OperatorCodeGenerator.java --- @@ -0,0 +1,271 @@ +/* + *

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99028564 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/InMemorySorter.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99028635 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/InMemorySorter.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99041705 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SpillSet.java --- @@ -0,0 +1,261 @@ +/* + * Licensed to the

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99024407 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java --- @@ -0,0 +1,1321 @@ +/* + *

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99045403 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -177,13 +177,47 @@ drill.exec: { sort: { purge.threshold : 1000,

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99040449 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopier.java --- @@ -0,0 +1,43 @@ +/* + *

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99027623 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/InMemorySorter.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] drill pull request #717: DRILL-5080: Memory-managed version of external sort

2017-02-01 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/717#discussion_r99036541 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/MSortTemplate.java --- @@ -0,0 +1,237 @@ +/* + * Licensed to

NPE On UDF in Directory Query

2017-02-01 Thread Charles Givre
Hello everyone, I’m working on a UDF (https://github.com/cgivre/drill-geoip-functions ) that does a bunch of IPGEO stuff. So far it works relatively well, but I encountered a Null Pointer Exception that I’m not quite sure how to resolve. If I

[jira] [Resolved] (DRILL-4179) Update UDF documentation now that classpath scanning is more strict

2017-02-01 Thread Julien Le Dem (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-4179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Le Dem resolved DRILL-4179. -- Resolution: Fixed > Update UDF documentation now that classpath scanning is more strict >

Re: OpenTSDB plugin development for Drill

2017-02-01 Thread Ted Dunning
Moving user@drill to bcc. The key questions here have to do with the following: 1) how is the best way to write rules that will help drill force the query into recognizable form 2) is there a good way to pass parameters to the data source. Things like resampling parameters and resampling

[GitHub] drill issue #735: DRILL-5237: FlattenRecordBatch loses nested fields from th...

2017-02-01 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/735 lgtm. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] drill issue #725: DRILL-5215: CTTAS: disallow temp tables in view expansion ...

2017-02-01 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/725 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

OpenTSDB plugin development for Drill

2017-02-01 Thread Dmintriy Gavrilovich
Hi everyone. TLTR; I have started to develop an OpenTSDB Plugin for Drill available here: https://github.com/mapr-demos/drill/tree/openTSDB-plugin/contrib/storage-opentsdb This is a work in progress and I have some ideas, and questions, see below DETAILS I am developing a storage plugin for

[GitHub] drill issue #685: Drill 5043: Function that returns a unique id per session/...

2017-02-01 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/685 @nagarajanchinnasamy thank you, looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill pull request #735: DRILL-5237: Same query produces different/wrong res...

2017-02-01 Thread Serhii-Harnyk
GitHub user Serhii-Harnyk opened a pull request: https://github.com/apache/drill/pull/735 DRILL-5237: Same query produces different/wrong results Fixed loss of nested fields from the schema when the first FlattenRecordBatch is empty You can merge this pull request into a Git

[jira] [Created] (DRILL-5237) Same query produces different/wrong results

2017-02-01 Thread Serhii Harnyk (JIRA)
Serhii Harnyk created DRILL-5237: Summary: Same query produces different/wrong results Key: DRILL-5237 URL: https://issues.apache.org/jira/browse/DRILL-5237 Project: Apache Drill Issue Type: