[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102393352 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractServerConnection.java --- @@ -0,0 +1,121 @@ +/** + * Licensed to the

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102393799 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ServerAuthenticationHandler.java --- @@ -0,0 +1,269 @@ +/** + *

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102395784 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -88,22 +129,183 @@ public void

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102396422 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ClientConnection.java --- @@ -0,0 +1,30 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102391399 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnectionConfig.java --- @@ -0,0 +1,59 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102389973 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java --- @@ -89,14 +90,36 @@ public MessageLite

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102396712 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java --- @@ -105,8 +128,83 @@ protected void

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102396769 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java --- @@ -75,27 +87,118 @@ public MessageLite

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102396526 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ServerConnection.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102391859 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java --- @@ -0,0 +1,238 @@ +/** + *

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102390094 --- Diff: common/src/main/java/org/apache/drill/common/KerberosUtil.java --- @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #754: DRILL-5275: Sort spill is slow due to repeated allo...

2017-02-21 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/754#discussion_r102382826 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java --- @@ -57,6 +57,12 @@ private

[GitHub] drill pull request #747: DRILL-5257: Run-time control of query profiles

2017-02-21 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/747#discussion_r102378871 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -178,6 +182,19 @@ public Foreman(final WorkerBee bee, final

[GitHub] drill pull request #747: DRILL-5257: Run-time control of query profiles

2017-02-21 Thread ppadma
Github user ppadma commented on a diff in the pull request: https://github.com/apache/drill/pull/747#discussion_r102378651 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -413,4 +413,15 @@ String DYNAMIC_UDF_SUPPORT_ENABLED =

[GitHub] drill pull request #754: DRILL-5275: Sort spill is slow due to repeated allo...

2017-02-21 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/754#discussion_r102378905 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java --- @@ -57,6 +57,12 @@ private

[GitHub] drill pull request #747: DRILL-5257: Run-time control of query profiles

2017-02-21 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/747#discussion_r102378009 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -162,6 +162,9 @@ drill.exec: { size: 1 } }, +

[GitHub] drill pull request #747: DRILL-5257: Run-time control of query profiles

2017-02-21 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/747#discussion_r102377957 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -853,7 +875,9 @@ public void close() throws Exception {

[GitHub] drill pull request #747: DRILL-5257: Run-time control of query profiles

2017-02-21 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/747#discussion_r10236 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -413,4 +413,19 @@ String DYNAMIC_UDF_SUPPORT_ENABLED

[GitHub] drill pull request #750: DRILL-5273: CompliantTextReader excessive memory us...

2017-02-21 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/750#discussion_r102377194 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java --- @@ -118,12 +118,21 @@ public

[GitHub] drill issue #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on the issue: https://github.com/apache/drill/pull/729 I have addressed the comments from the earlier pull request. Please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2017-02-21 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/755 For 8266 profiles, when measured from Chrome browser's Network tool: ``` Load First Time: 2.43s Load Second Time (no new profiles): 829ms ``` --- If your project is set up for it,

[GitHub] drill pull request #613: DRILL-4730: Update JDBC DatabaseMetaData implementa...

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/613#discussion_r102364337 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillMetaImpl.java --- @@ -78,19 +111,237 @@ private MetaResultSet s(String s) { }

[GitHub] drill issue #755: DRILL-5270: Improve loading of profiles listing in the Web...

2017-02-21 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/755 A summary of the performance is available in this

[GitHub] drill pull request #613: DRILL-4730: Update JDBC DatabaseMetaData implementa...

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/613#discussion_r102363803 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java --- @@ -24,33 +24,260 @@ import java.util.ArrayList; import

[GitHub] drill pull request #755: DRILL-5270: Improve loading of profiles listing in ...

2017-02-21 Thread kkhatua
GitHub user kkhatua opened a pull request: https://github.com/apache/drill/pull/755 DRILL-5270: Improve loading of profiles listing in the WebUI Using Hadoop API to filter and reduce profile list load time Using an in-memory treeSet-based cache, maintain the list of most recent

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

2017-02-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102362622 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java --- @@ -109,7 +121,37 @@ public MockSchema(MockStorageEngine

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

2017-02-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102336171 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/package-info.java --- @@ -60,14 +62,26 @@ * The mode is one of the supported

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

2017-02-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102320948 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java --- @@ -89,14 +85,30 @@ public boolean supportsRead() {

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

2017-02-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102294277 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/BooleanGen.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

2017-02-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102298318 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java --- @@ -124,7 +125,7 @@ public void

[GitHub] drill pull request #752: DRILL-5258: Access mock data definition from SQL

2017-02-21 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/752#discussion_r102360734 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockGroupScanPOP.java --- @@ -75,20 +76,50 @@ */ private boolean

[GitHub] drill pull request #613: DRILL-4730: Update JDBC DatabaseMetaData implementa...

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/613#discussion_r102363018 --- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/DatabaseMetaDataGetColumnsTest.java --- @@ -2712,22 +2712,18 @@ public void

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102304062 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ClientConnection.java --- @@ -0,0 +1,30 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102344639 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ServerAuthenticationHandler.java --- @@ -0,0 +1,269 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102295865 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java --- @@ -75,27 +87,118 @@ public MessageLite

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101598598 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101116414 --- Diff: common/src/main/java/org/apache/drill/common/map/CaseInsensitiveMap.java --- @@ -55,6 +55,18 @@ } /** + * Returns a new

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102347409 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -88,22 +124,178 @@ public void submitQuery(UserResultsListener

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101601121 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102330939 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/plain/PlainFactory.java --- @@ -0,0 +1,166 @@ +/** + * Licensed to the

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102346707 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java --- @@ -88,22 +129,183 @@ public void submitQuery(UserResultsListener

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101121400 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -412,37 +427,155 @@ connectionStatus_t

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101599452 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102307826 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -358,25 +291,59 @@ public BitToUserHandshake

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102278730 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractClientConnection.java --- @@ -0,0 +1,61 @@ +/** + * Licensed to the

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102279444 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractServerConnection.java --- @@ -0,0 +1,121 @@ +/** + * Licensed to the

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101123168 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101600048 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.hpp --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101602793 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101631177 --- Diff: common/src/main/java/org/apache/drill/common/KerberosUtil.java --- @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101598438 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101600545 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102336062 --- Diff: common/src/main/java/org/apache/drill/common/KerberosUtil.java --- @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102348994 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java --- @@ -358,25 +291,59 @@ public BitToUserHandshake

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102303605 --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/ServerConnection.java --- @@ -0,0 +1,37 @@ +/** + * Licensed to the Apache Software

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102342473 --- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp --- @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102344797 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java --- @@ -0,0 +1,109 @@ +/** + * Licensed

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102294263 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlConnectionConfig.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102292416 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java --- @@ -105,8 +128,83 @@ protected void

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102344235 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationOutcomeListener.java --- @@ -0,0 +1,238 @@ +/** + *

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102358541 --- Diff: contrib/native/client/cmakeModules/FindSASL.cmake --- @@ -0,0 +1,55 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r101605131 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -435,9 +427,14 @@ public synchronized boolean reconnect() {

[GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication

2017-02-21 Thread laurentgo
Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/578#discussion_r102299705 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java --- @@ -89,14 +90,36 @@ public MessageLite

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102345408 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdSelectivity.java --- @@ -0,0 +1,219 @@

[jira] [Resolved] (DRILL-5103) External Sort pop shadows variable "initialAllocation" from AbstractBase

2017-02-21 Thread Paul Rogers (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Rogers resolved DRILL-5103. Resolution: Fixed > External Sort pop shadows variable "initialAllocation" from AbstractBase >

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102327621 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsAggBatch.java --- @@ -0,0 +1,256 @@ +/** + * Licensed

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102326907 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[jira] [Created] (DRILL-5287) Provide option to skip updates of ephemeral state changes in Zookeeper

2017-02-21 Thread Padma Penumarthy (JIRA)
Padma Penumarthy created DRILL-5287: --- Summary: Provide option to skip updates of ephemeral state changes in Zookeeper Key: DRILL-5287 URL: https://issues.apache.org/jira/browse/DRILL-5287 Project:

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102325216 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102324705 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102324596 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102323849 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102322555 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102320614 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102319897 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102316247 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/UnpivotMaps.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102314383 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillStatsTable.java --- @@ -0,0 +1,347 @@ +/** + * Licensed to the

[jira] [Created] (DRILL-5286) When rel and target candidate set is the same, planner should not need to do convert for the relNode since it must have been done

2017-02-21 Thread Chunhui Shi (JIRA)
Chunhui Shi created DRILL-5286: -- Summary: When rel and target candidate set is the same, planner should not need to do convert for the relNode since it must have been done Key: DRILL-5286 URL:

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102310795 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102306890 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill issue #738: DRILL-5190: Display planning and queued time for a query i...

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/738 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] drill issue #751: DRILL-5259: Allow listing a user-defined number of profile...

2017-02-21 Thread sudheeshkatkam
Github user sudheeshkatkam commented on the issue: https://github.com/apache/drill/pull/751 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Resolved] (DRILL-5203) Provide per-test control over logging for unit tests

2017-02-21 Thread Paul Rogers (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-5203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Rogers resolved DRILL-5203. Resolution: Fixed Added as part of the new "cluster fixture" unit test framework. > Provide

[GitHub] drill pull request #754: DRILL-5275: Sort spill is slow due to repeated allo...

2017-02-21 Thread Ben-Zvi
Github user Ben-Zvi commented on a diff in the pull request: https://github.com/apache/drill/pull/754#discussion_r102295524 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorAccessibleSerializable.java --- @@ -57,6 +57,12 @@ private

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102295174 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102295106 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #742: DRILL-5242: The UI breaks when rendering profiles h...

2017-02-21 Thread kkhatua
Github user kkhatua closed the pull request at: https://github.com/apache/drill/pull/742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill issue #742: DRILL-5242: The UI breaks when rendering profiles having u...

2017-02-21 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/742 This closes PR #742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] drill issue #739: DRILL-5230: Translation of millisecond duration into hours...

2017-02-21 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/739 This closes PR #739 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] drill pull request #739: DRILL-5230: Translation of millisecond duration int...

2017-02-21 Thread kkhatua
Github user kkhatua closed the pull request at: https://github.com/apache/drill/pull/739 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102294356 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[jira] [Created] (DRILL-5285) Provide detailed, accurate estimate of size consumed by a record batch

2017-02-21 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-5285: -- Summary: Provide detailed, accurate estimate of size consumed by a record batch Key: DRILL-5285 URL: https://issues.apache.org/jira/browse/DRILL-5285 Project: Apache

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102292075 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[jira] [Created] (DRILL-5284) Roll-up of final fixes for managed sort

2017-02-21 Thread Paul Rogers (JIRA)
Paul Rogers created DRILL-5284: -- Summary: Roll-up of final fixes for managed sort Key: DRILL-5284 URL: https://issues.apache.org/jira/browse/DRILL-5284 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102291655 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillFilterRelBase.java --- @@ -113,6 +114,6 @@ public double getRows() {

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102291099 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unpivot/UnpivotMapsRecordBatch.java --- @@ -0,0 +1,276 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102290203 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatchCreator.java --- @@ -0,0 +1,39 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102290224 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unpivot/UnpivotMapsBatchCreator.java --- @@ -0,0 +1,40 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102289330 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

[GitHub] drill pull request #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/729#discussion_r102286549 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/statistics/StatisticsMergeBatch.java --- @@ -0,0 +1,532 @@ +/** + *

  1   2   >