[GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...

Github user laurentgo commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r106083106 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java --- @@ -184,6 +184,17 @@ private ServerMeta getServerMeta() thr

[GitHub] drill pull request #784: DRILL-5355: Misc. code cleanup

Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/784#discussion_r106071847 --- Diff: logical/src/main/java/org/apache/drill/common/expression/FieldReference.java --- @@ -1,4 +1,4 @@ -/** --- End diff -- In Java,

[jira] [Created] (DRILL-5356) Refactor Parquet Record Reader

Paul Rogers created DRILL-5356: -- Summary: Refactor Parquet Record Reader Key: DRILL-5356 URL: https://issues.apache.org/jira/browse/DRILL-5356 Project: Apache Drill Issue Type: Improvement A

[GitHub] drill pull request #785: DRILL-5323: Test tools for row sets

GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/785 DRILL-5323: Test tools for row sets Provide test tools to create, populate and compare row sets To simplify tests, we need a TestRowSet concept that wraps a VectorContainer and provid

[GitHub] drill pull request #784: DRILL-5355: Misc. code cleanup

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/784#discussion_r106044432 --- Diff: logical/src/main/java/org/apache/drill/common/expression/FieldReference.java --- @@ -1,4 +1,4 @@ -/** --- End diff -- I have se

[GitHub] drill pull request #784: DRILL-5355: Misc. code cleanup

Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/784#discussion_r106044402 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisualizerVisitor.java --- @@ -0,0 +1,217 @@ +/* + * Li

[GitHub] drill pull request #784: DRILL-5355: Misc. code cleanup

GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/784 DRILL-5355: Misc. code cleanup Recent work in Drill has identified a number of cases where code can be cleaned up: adding missing annotations, etc. These changes don't fit as part of a separa

[jira] [Created] (DRILL-5355) Misc. code cleanup

Paul Rogers created DRILL-5355: -- Summary: Misc. code cleanup Key: DRILL-5355 URL: https://issues.apache.org/jira/browse/DRILL-5355 Project: Apache Drill Issue Type: Improvement Affects Vers

[jira] [Created] (DRILL-5354) Create CTTAS Documentaion

Padma Heid created DRILL-5354: - Summary: Create CTTAS Documentaion Key: DRILL-5354 URL: https://issues.apache.org/jira/browse/DRILL-5354 Project: Apache Drill Issue Type: Task Component

[jira] [Resolved] (DRILL-4024) CTAS with auto partition gives an NPE when the partition column has null values in it

[ https://issues.apache.org/jira/browse/DRILL-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Challapalli resolved DRILL-4024. -- Resolution: Duplicate > CTAS with auto partition gives an NPE when the partition column

Re: Drill date & time types encoding

I don’t think 4713 BC comes from the SQL standard. That is a Postgres thing. I believe that the standard says you should support timestamp precision up to 9 (i.e. nanoseconds). 2 ^ 64 nanoseconds is 584 years. So, it’s not possible to cram all of the timestamp values we’d like into a 64 bit inte

[jira] [Resolved] (DRILL-4681) ChannelClosedException causes all queries which are communicating on that channel to fail

[ https://issues.apache.org/jira/browse/DRILL-4681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Challapalli resolved DRILL-4681. -- Resolution: Not A Bug > ChannelClosedException causes all queries which are communicatin

Re: Drill date & time types encoding

Thanks for the detailed research, Paul, INTERVAL by the (SQL-99 ?) standard should be either a SECOND-DAY interval or a MONTH-YEAR interval. This is a result of the inconsistent “number of days in a month”. DATE expressed in days, starting at 4713-BC sound like the standard as well (at least

[jira] [Resolved] (DRILL-4318) Drill hangs with a malformed Tpcds query

[ https://issues.apache.org/jira/browse/DRILL-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Challapalli resolved DRILL-4318. -- Resolution: Cannot Reproduce > Drill hangs with a malformed Tpcds query > --

[GitHub] drill issue #777: DRILL-5330: NPE in FunctionImplementationRegistry

Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/777 +1, looks good. Please squash the commits and put read-to-commit label in Jira when done. Thank you! --- If your project is set up for it, you can reply to this email and have your reply app