Re: Running cartesian joins on Drill

2017-05-11 Thread Aman Sinha
Muhammad, The join condition ‘a = b or (a is null && b is null)’ works. Internally, this is converted to ‘a is not distinct from b’ which is processed by Drill. For some reason, if the second form is directly supplied in the user query, it is not working and ends up with the Cartesian join con

[jira] [Created] (DRILL-5506) Apache Drill Querying data from compressed .zip file

2017-05-11 Thread john li (JIRA)
john li created DRILL-5506: -- Summary: Apache Drill Querying data from compressed .zip file Key: DRILL-5506 URL: https://issues.apache.org/jira/browse/DRILL-5506 Project: Apache Drill Issue Type: Bug

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115860398 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } }

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115614489 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } }

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115877434 --- Diff: contrib/native/client/src/clientlib/utils.cpp --- @@ -111,4 +111,52 @@ AllocatedBuffer::~AllocatedBuffer(){ m_bufSize = 0; } +

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115612998 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } }

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115557153 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } }

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115532000 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } }

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115614854 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } }

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115527833 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -370,6 +453,33 @@ void DrillClientImpl::handleHShakeReadTimeout(const boost::system::e

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115612782 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } }

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r11119 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } }

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115530271 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -495,26 +612,45 @@ connectionStatus_t DrillClientImpl::handleAuthentication(const Dril

[GitHub] drill pull request #809: Drill-4335: C++ client changes for supporting encry...

2017-05-11 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/809#discussion_r115861013 --- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp --- @@ -854,75 +990,328 @@ void DrillClientImpl::waitForResults(){ } }

Re: Running cartesian joins on Drill

2017-05-11 Thread Aman Sinha
I think Muhammad may be trying to run his original query with IS NOT DISTINCT FROM. That discussion got side-tracked into Cartesian joins because his query was not getting planned and the error was about Cartesian join. Muhammad, can you try with the equivalent version below ? You mentioned

[GitHub] drill pull request #827: DRILL-5481: Persist profiles in-memory only with a ...

2017-05-11 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/827#discussion_r116116864 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStoreConfig.java --- @@ -106,9 +113,14 @@ protected StoreConfigBuilde

[GitHub] drill pull request #827: DRILL-5481: Persist profiles in-memory only with a ...

2017-05-11 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/827#discussion_r116116935 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/InMemoryPersistentStore.java --- @@ -15,28 +15,40 @@ * See the Lice

[GitHub] drill pull request #827: DRILL-5481: Persist profiles in-memory only with a ...

2017-05-11 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/827#discussion_r116116220 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/InMemoryPersistentStore.java --- @@ -15,28 +15,40 @@ * See the Lice

[GitHub] drill pull request #827: DRILL-5481: Persist profiles in-memory only with a ...

2017-05-11 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/827#discussion_r116116899 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/InMemoryPersistentStore.java --- @@ -15,28 +15,40 @@ * See the Lice

[GitHub] drill pull request #827: DRILL-5481: Persist profiles in-memory only with a ...

2017-05-11 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/827#discussion_r116116596 --- Diff: exec/java-exec/src/main/resources/drill-module.conf --- @@ -138,7 +138,10 @@ drill.exec: { class: "org.apache.drill.exec.store.sys.s

[GitHub] drill pull request #827: DRILL-5481: Persist profiles in-memory only with a ...

2017-05-11 Thread sudheeshkatkam
Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/827#discussion_r116116310 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/InMemoryPersistentStore.java --- @@ -93,6 +105,14 @@ public void put(fina

Re: Running cartesian joins on Drill

2017-05-11 Thread Zelaine Fong
I’m not sure why it isn’t working for you. Using Drill 1.10, here’s my output: 0: jdbc:drill:zk=local> alter session set `planner.enable_nljoin_for_scalar_only` = false; +---+-+ | ok | summary | +-

Re: Running cartesian joins on Drill

2017-05-11 Thread Muhammad Gelbana
​But the query I provided failed to be planned because it's a cartesian join, although I've set the option you mentioned to false. Is there a reason why wouldn't Drill rules physically implement the logical join in my query to a nested loop join ? *-* *Muhammad Gelbana* http://

[jira] [Created] (DRILL-5505) Enabling exchanges increased the external sorts spill count by 2 times

2017-05-11 Thread Rahul Challapalli (JIRA)
Rahul Challapalli created DRILL-5505: Summary: Enabling exchanges increased the external sorts spill count by 2 times Key: DRILL-5505 URL: https://issues.apache.org/jira/browse/DRILL-5505 Project:

[GitHub] drill issue #827: DRILL-5481: Persist profiles in-memory only with a max cap...

2017-05-11 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/827 @sudheeshkatkam & @ppadma ... please review and bless the PR if everything looks fine.! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] drill pull request #832: DRILL-5504: Vector validator to diagnose offset vec...

2017-05-11 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/832 DRILL-5504: Vector validator to diagnose offset vector issues Validates offset vectors in VarChar and repeated vectors. Validates the special case of repeated VarChar vectors (two layers of of

[GitHub] drill issue #819: DRILL-5419: Calculate return string length for literals & ...

2017-05-11 Thread jinfengni
Github user jinfengni commented on the issue: https://github.com/apache/drill/pull/819 +1 The revised commit looks good to me. Thanks for taking effort to separate the return type inference logic from function scope logic. You may consider adding brief description of that cha

Re: Running cartesian joins on Drill

2017-05-11 Thread Zelaine Fong
Provided `planner.enable_nljoin_for_scalar_only` is set to false, even without an explicit join condition, the query should use the Cartesian join/nested loop join. -- Zelaine On 5/11/17, 4:20 AM, "Anup Tiwari" wrote: Hi, I have one question here.. so if we have to use Cartesian

[GitHub] drill pull request #831: DRILL-5432: Added pcap-format support

2017-05-11 Thread Vlad-Storona
GitHub user Vlad-Storona opened a pull request: https://github.com/apache/drill/pull/831 DRILL-5432: Added pcap-format support See DRILL-5432 for details. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mapr-demos/drill pcap-forma

Re: Running cartesian joins on Drill

2017-05-11 Thread Anup Tiwari
Hi, I have one question here.. so if we have to use Cartesian join in Drill then do we have to follow some workaround like Shadi mention : adding a dummy column on the fly that has the value 1 in both tables and then join on that column leading to having a match of every row of the first table wit