GitHub user prasadns14 opened a pull request:
https://github.com/apache/drill/pull/939
DRILL-5550: Missing CSV column value set to null
1) Changed the CSV datatype to nullable VARCHAR
2) Missing CSV column value set to null
3) Unit test added
You can merge this pull request
+1 to add checkstyle for the Apache license header. It will be good to
enforce consistency and avoid unnecessary warnings. I would also
recommend to add .idea/copyright to the drill git repository to simplify
adding license header to new files. +1 to enforce indents as well (I
hope usage of tab
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/932#discussion_r137963963
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java
---
@@ -680,9 +680,11 @@ public MergeTask con
Github user sudheeshkatkam commented on the issue:
https://github.com/apache/drill/pull/925
Nice catch @weijietong
Looks like the Netty thread, that is failing all outstanding requests to a
certain endpoint, is itself trying to send a message (cancel fragment) to that
endpoin
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/925#discussion_r137955415
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java ---
@@ -54,10 +52,14 @@ void channelClosed(Throwable ex) {
isOpen.se
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/919
OK, thanks. Got confused by the commit messages that appeared after the +1.
Maybe in the future, when we rebase, just add a comment saying that's what
happened.
---
Github user weijietong commented on a diff in the pull request:
https://github.com/apache/drill/pull/925#discussion_r137953813
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java ---
@@ -54,10 +52,14 @@ void channelClosed(Throwable ex) {
isOpen.set
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/919
@paul-rogers - Not sure which commit you are referring to. All the commits
are reviewed by @parthchandra. I just rebased commits to latest master after
last week pull request since @amansinha100 was ob
