[GitHub] drill issue #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-30 Thread ilooner
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/940 Yeah this is ready for final review and commit. To do a quick build and smoke test you can do ``` mvn -T 1C clean install -DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache

[GitHub] drill issue #949: DRILL-5795: Parquet Filter push down at rowgroup level

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/949 Please resolve commits and rebase onto master. ---

[GitHub] drill pull request #963: DRILL-5259: Allow listing a user-defined number of ...

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/963#discussion_r142018753 --- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl --- @@ -37,7 +37,42 @@ No running queries. - Completed

[GitHub] drill issue #958: DRILL-5808: Reduce memory allocator strictness for "manage...

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/958 @Ben-Zvi, you are right that, in the worst case, this change will allow operators to exceed the memory allotment. But, that is actually the purpose. As we know, it is *very* difficult to g

[GitHub] drill pull request #958: DRILL-5808: Reduce memory allocator strictness for ...

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/958#discussion_r140960874 --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/memory/Accountant.java --- @@ -80,6 +119,23 @@ public Accountant(Accountant parent, long re

[GitHub] drill pull request #958: DRILL-5808: Reduce memory allocator strictness for ...

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/958#discussion_r140960868 --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/memory/Accountant.java --- @@ -22,16 +22,55 @@ import javax.annotation.concurrent.Thre

[GitHub] drill issue #954: DRILL-5803: Show the hostname for each minor fragment in o...

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/954 The fixes are an improvement. In some future commit, an actual class would be better than nested immutable pairs. At present, the code has become a bit cryptic and Python-like. But, we can do that

[GitHub] drill issue #940: DRILL-5752 Speed Up Unit Tests add Test Categories

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/940 @ilooner, thanks for the improvements. Is this PR now ready for final review and commit? Also, if all tests are enabled by default, is there a suggestion of a Maven command that developer

[GitHub] drill pull request #932: DRILL-5758: Fix for repeated columns; enable manage...

2017-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/932 ---

[GitHub] drill pull request #968: DRILL-5830: Resolve regressions to MapR DB from DRI...

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/968#discussion_r142017916 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryRowSetIterator.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Softwar

[GitHub] drill issue #932: DRILL-5758: Fix for repeated columns; enable managed sort ...

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/932 Squashed commits. ---

[GitHub] drill issue #932: DRILL-5758: Fix for repeated columns; enable managed sort ...

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/932 Rebased onto master. ---

[GitHub] drill pull request #932: DRILL-5758: Fix for repeated columns; enable manage...

2017-09-30 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/932#discussion_r142017748 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java --- @@ -74,53 +74,52 @@ public final int

[GitHub] drill pull request #968: DRILL-5830: Resolve regressions to MapR DB from DRI...

2017-09-30 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/968#discussion_r142017186 --- Diff: exec/java-exec/src/test/java/org/apache/drill/test/QueryRowSetIterator.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software F

[GitHub] drill pull request #805: Drill-4139: Exception while trying to prune partiti...

2017-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/805 ---

[GitHub] drill pull request #968: DRILL-5830: Resolve regressions to MapR DB from DRI...

2017-09-30 Thread paul-rogers
GitHub user paul-rogers opened a pull request: https://github.com/apache/drill/pull/968 DRILL-5830: Resolve regressions to MapR DB from DRILL-5546 DRILL-5546 fixed a wide variety of "empty batch" problems. But, it introduced a regression in the HBase and MapR-DB binary storage plugi