[GitHub] drill issue #990: DRILL-5872: Workaround for invalid cost in physical plans

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/990 Fixed in planner, so closing this. ---

[GitHub] drill pull request #990: DRILL-5872: Workaround for invalid cost in physical...

2017-11-05 Thread paul-rogers
Github user paul-rogers closed the pull request at: https://github.com/apache/drill/pull/990 ---

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r148997365 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r148997959 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r148997565 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -828,8 +828,13 @@ public void close() throws Exception {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r148997637 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/user/PlanSplitter.java --- @@ -79,6 +80,15 @@ public QueryPlanFragments planFragments(

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r148998119 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -158,38 +165,49 @@ public DrillbitContext getContext() {

[GitHub] drill pull request #1023: DRILL-5922 Fixed Child Allocator Leak. DRILL-5926 ...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1023#discussion_r148997788 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java --- @@ -59,12 +61,14 @@ public class WorkManager implements AutoC

[GitHub] drill issue #1015: DRILL-5899: Simple pattern matchers can work with DrillBu...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/1015 Second long list of detailed comments sent privately to keep dev list traffic down. ---

[GitHub] drill issue #978: DRILL-5842: Refactor and simplify the fragment, operator c...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/978 Rebased and squashed commits. ---

[GitHub] drill issue #970: DRILL-5832: Migrate OperatorFixture to use SystemOptionMan...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/970 Addressed comments. Rebased on master. Resolved merge conflicts. Squashed commits. @ilooner, @sachouche please do a quick final review to check for loose ends. ---

[GitHub] drill pull request #652: DRILL-4990:Use new HDFS API access instead of listS...

2017-11-05 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/652#discussion_r148991210 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java --- @@ -151,17 +152,32 @@ public WorkspaceSchemaFactory(

[GitHub] drill pull request #652: DRILL-4990:Use new HDFS API access instead of listS...

2017-11-05 Thread sohami
Github user sohami commented on a diff in the pull request: https://github.com/apache/drill/pull/652#discussion_r148991415 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java --- @@ -151,17 +152,32 @@ public WorkspaceSchemaFactory(

[GitHub] drill issue #978: DRILL-5842: Refactor and simplify the fragment, operator c...

2017-11-05 Thread paul-rogers
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/978 @sohami, pushed a commit that addresses your PR comments. Regarding the "one stop shop" comment. This PR removes the `OperExecContextImpl` class. That class was an earlier attempt to combi

[jira] [Created] (DRILL-5934) How to deploy drill by sub-component?

2017-11-05 Thread Yi Zhao (JIRA)
Yi Zhao created DRILL-5934: -- Summary: How to deploy drill by sub-component? Key: DRILL-5934 URL: https://issues.apache.org/jira/browse/DRILL-5934 Project: Apache Drill Issue Type: New Feature

[jira] [Created] (DRILL-5933) Support spring-boot package

2017-11-05 Thread Yi Zhao (JIRA)
Yi Zhao created DRILL-5933: -- Summary: Support spring-boot package Key: DRILL-5933 URL: https://issues.apache.org/jira/browse/DRILL-5933 Project: Apache Drill Issue Type: New Feature Repo

[GitHub] drill issue #1007: DRILL-5864 Selecting a non-existing field from a MapR-DB ...

2017-11-05 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/1007 Merged in 125a9271d7cf0dfb30aac8e62447507ea0a7d6c9. @HanumathRao pls close the PR (for some reason I don't have permission). ---

[GitHub] drill issue #996: DRILL-5878: TableNotFound exception is being reported for ...

2017-11-05 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/996 Merged in 7a2fc87ee20f706d85cb5c90cc441e6b44b71592. @HanumathRao pls close the PR. ---

[GitHub] drill pull request #1021: DRILL-5923: Display name for query state

2017-11-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1021#discussion_r148967310 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -135,6 +135,8 @@ table.sortable thead .sorting_desc { background-image:

[GitHub] drill issue #1018: Drill-5834: Add Networking Functions

2017-11-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1018 Aman, thanks for agreeing to squash the commits. Marked Jira as ready-to-commit. ---

[GitHub] drill pull request #1021: DRILL-5923: Display name for query state

2017-11-05 Thread prasadns14
Github user prasadns14 commented on a diff in the pull request: https://github.com/apache/drill/pull/1021#discussion_r148963451 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -135,6 +135,8 @@ table.sortable thead .sorting_desc { background-image: url("/

[GitHub] drill issue #1018: Drill-5834: Add Networking Functions

2017-11-05 Thread amansinha100
Github user amansinha100 commented on the issue: https://github.com/apache/drill/pull/1018 @arina-ielchiieva if this is good to go, can you mark the JIRA as read-to-commit ? I will squash the 3 commits that @cgivre has created and modify the commit message before committing. ---

[GitHub] drill pull request #1021: DRILL-5923: Display name for query state

2017-11-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/1021#discussion_r148961643 --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl --- @@ -135,6 +135,8 @@ table.sortable thead .sorting_desc { background-image:

[GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r148959786 --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/Schema.java --- @@ -0,0 +1,119 @@ +/* + * Licen

[GitHub] drill issue #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/774 @Vlad-Storona I have deployed your branch and have noticed several more issues: 1. When I openTSDB storage plugin tab for the first time, its content is showing as null. 2. When I hav

[GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread Vlad-Storona
Github user Vlad-Storona commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r148957508 --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/Schema.java --- @@ -0,0 +1,119 @@ +/* + * Licensed

[GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread Vlad-Storona
Github user Vlad-Storona commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r148957504 --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/OpenTSDBSubScan.java --- @@ -0,0 +1,132 @@ +/* + * License

[GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread Vlad-Storona
Github user Vlad-Storona commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r148957506 --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/Util.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apa

[GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread Vlad-Storona
Github user Vlad-Storona commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r148957511 --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/query/DBQuery.java --- @@ -0,0 +1,148 @@ +/* + * Li

[GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread Vlad-Storona
Github user Vlad-Storona commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r148957497 --- Diff: contrib/storage-opentsdb/README.md --- @@ -0,0 +1,64 @@ +# drill-storage-openTSDB + +Implementation of TSDB storage plugin. Plugin u

[GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread Vlad-Storona
Github user Vlad-Storona commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r148957509 --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/client/Schema.java --- @@ -0,0 +1,119 @@ +/* + * Licensed

[GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread Vlad-Storona
Github user Vlad-Storona commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r148957514 --- Diff: contrib/storage-opentsdb/src/test/java/org/apache/drill/store/openTSDB/TestOpenTSDBPlugin.java --- @@ -0,0 +1,165 @@ +/* + * Licensed

[GitHub] drill pull request #774: DRILL-5337: OpenTSDB storage plugin

2017-11-05 Thread Vlad-Storona
Github user Vlad-Storona commented on a diff in the pull request: https://github.com/apache/drill/pull/774#discussion_r148957500 --- Diff: contrib/storage-opentsdb/src/main/java/org/apache/drill/exec/store/openTSDB/Constants.java --- @@ -0,0 +1,32 @@ +/* + * Licensed to th