[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2018-01-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r161512862 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java --- @@ -160,4 +165,19 @@ public void testJoinWith

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2018-01-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r161510835 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java --- @@ -333,4 +339,55 @@ public void testNlJoinWith

[GitHub] drill pull request #1059: DRILL-5851: Empty table during a join operation wi...

2018-01-15 Thread vdiravka
Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/1059#discussion_r161510606 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestNullInputMiniPlan.java --- @@ -354,9 +354,9 @@ public void testHashJoinRight

Re: Odd Error on Login with 1.13-SNAPSHOT

2018-01-15 Thread Sorabh Hamirwasia
I have opened a PR for review. Would be great if you can pull that in and try out, unfortunately just adding the new config will not help 😞 Thanks, Sorabh From: Sorabh Hamirwasia Sent: Sunday, January 14, 2018 9:36 PM

[GitHub] drill pull request #1066: DRILL-3993: Changes to support Calcite 1.15

2018-01-15 Thread chunhui-shi
Github user chunhui-shi commented on a diff in the pull request: https://github.com/apache/drill/pull/1066#discussion_r161607926 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java --- @@ -1303,6 +1305,8 @@ private void checkGr

[jira] [Created] (DRILL-6089) Planner changes needed as Hash-Join spill breaks left-side order

2018-01-15 Thread Timothy Farkas (JIRA)
Timothy Farkas created DRILL-6089: - Summary: Planner changes needed as Hash-Join spill breaks left-side order Key: DRILL-6089 URL: https://issues.apache.org/jira/browse/DRILL-6089 Project: Apache Dril

[jira] [Resolved] (DRILL-6083) RestClientFixture does not connect to the correct webserver port

2018-01-15 Thread Karthikeyan Manivannan (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthikeyan Manivannan resolved DRILL-6083. --- Resolution: Not A Problem > RestClientFixture does not connect to the correct

[GitHub] drill pull request #570: DRILL-4834 decimal implementation is vulnerable to ...

2018-01-15 Thread daveoshinsky
Github user daveoshinsky commented on a diff in the pull request: https://github.com/apache/drill/pull/570#discussion_r161630462 --- Diff: exec/java-exec/src/main/codegen/templates/SqlAccessors.java --- @@ -127,6 +127,25 @@ public String getString(int index) { }

[GitHub] drill issue #1082: DRILL-5741: Automatically manage memory allocations durin...

2018-01-15 Thread kkhatua
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1082 Done the following changes: 1. The file names have been changed to the following: * `./bin/auto-setup.sh` * `./conf/distrib-setup.sh` * `./conf/drill-setup.sh` `auto-setup.sh` and `